From patchwork Tue Oct 8 11:15:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13826355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 553DECEF15C for ; Tue, 8 Oct 2024 11:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X1OWtPdu0I5/ZasHrFlDpj/URLpeG1tE956GBIFcCCs=; b=rNwUWveRbR6dLe 0N/HTmJ1wRm7PDCUOtewl8Do+gkpKxVXl8Hu4ZsAwECIyHMakSqFkOuvG9vUwqcjxh7Xu/3wfF1xE aTrtxDuzyvwVbnbGw8JO5zstdqKuD1qplXPHMbg3BctJTbOTxGuWdiwNLCOoQuvpVZXYpNCFKx48Q B0jT47qB+dpJoCwpC3CoXgr+q3KIsRenngu6suRlJUwof9NfrIAQb3J7rnQebwK14vCtE9Vp+0T8M K9Lg4BvI4FO6uiPKHGUTphvXwEJtgWrPiLJpBp1JmXyyP3TCjLXWbRCS09F5uabIe5W4904XI2Rsu aNCCmguZaWVugwcHDhdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy8gw-00000005gt7-21cf; Tue, 08 Oct 2024 11:47:50 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy8Tx-00000005dxY-2Ij8 for linux-rockchip@lists.infradead.org; Tue, 08 Oct 2024 11:34:27 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728387263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZ+i+HZ0rdHDHJHDLF23OW3zaIUfIrmSTf6E1PPqT9E=; b=yDy3J+/cMtLHcUvZheYWqUpPALn6ryr/gIZaHpW/2exGa9wHvjNjMZfFjPD+FHathn5KmE kHOM1QGOpCqlS4eI6MkOByZzNRnM7lpuSy/Z/y0XLWs0jJAFaqImgxyNn4270VeM/jNkA4 4IRDBa9pLdChclFMdsVoJDpkxyI8HyVsC7FgsiseJ74+1IKJaj6iR0mmGbAyLWLMFVWzGi J9y3su7H2RjUmjDO/buJhqqQDLidgIkx6cEQ5pL+aAS+gLY4B/XlFLix7btS4UkoyVuqKI zDUhKYTNcvUPsk/orBE2DWZA/ZtGMbJZjTnWbnPrApou8TUJPZktVusT7cuPHw== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , Michael Riesch , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] arm64: dts: rockchip: Add PD to csi dphy node on rk356x Date: Tue, 8 Oct 2024 13:15:36 +0200 Message-ID: <20241008113344.23957-2-didi.debian@cknow.org> In-Reply-To: <20241008113344.23957-1-didi.debian@cknow.org> References: <20241008113344.23957-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_043425_761864_E86EE1A2 X-CRM114-Status: UNSURE ( 7.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The "rockchip-inno-csi-dphy.yaml" binding requires the power-domains property. According to RK3568 TRM Part 1 section 7.3 (page 475) the CSIHOST is placed in the PD_VI power domain. So set the csi_dphy node power-domains property accordingly. Fixes: b6c228401b25 ("arm64: dts: rockchip: add csi dphy node to rk356x") Signed-off-by: Diederik de Haas --- changes in v2: - No change arch/arm64/boot/dts/rockchip/rk356x.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index 0ee0ada6f0ab..d581170914f9 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -1790,6 +1790,7 @@ csi_dphy: phy@fe870000 { clocks = <&cru PCLK_MIPICSIPHY>; clock-names = "pclk"; #phy-cells = <0>; + power-domains = <&power RK3568_PD_VI>; resets = <&cru SRST_P_MIPICSIPHY>; reset-names = "apb"; rockchip,grf = <&grf>; From patchwork Tue Oct 8 11:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13826356 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D83DECEF15B for ; Tue, 8 Oct 2024 11:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tzp9S3u5VBMBPaSaYHVpKf8D4zKnqktr7wM8B0Feb2w=; b=sJcwWCPHzFear7 iMwdl1AZQiM1K2l6ykMln0uylRD+tR3YogXO6bT3Gqxq+x73sBsF9QH5r51yOe0kH/vOQMbEeQOMm QLGKWeMwb3Xnc/sUnZiCjyX1pKuzm/1y3sLDvYKmPTQTSDYBjRv+fp0RTlVhZM+cIz02q/xh/1FVZ t9ltRl568y67KfR6IdypKvonq/jx5XELpjHjOgVgtb2Bow20+P9NFmF4FBUFRj/BQYQad067lKT/Q IVwC5Hq7iV7X+qJdL/4Q4KxvWPskt/F5+Q3qGoV/p2CxHBLWsEqnEwp2/wt39M30apVQAgrU881lb ng1Y03buM0RYnA6v6FAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy8iC-00000005h3n-1eBb; Tue, 08 Oct 2024 11:49:08 +0000 Received: from out-179.mta0.migadu.com ([91.218.175.179]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy8U0-00000005dzH-1Rba for linux-rockchip@lists.infradead.org; Tue, 08 Oct 2024 11:34:29 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728387265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyJ7Z5sCax3H+U1/xrEos8F1I+KiAxNN6XMVHBXY4YM=; b=GEDW03eJ3ggGaiWlnJZzvdHe2KnXWLCVhZE2Ly0QfRU60p6HxGcEy3sEz4zYCVsVYk6pkO /R8n4MlSnb76WoQKEvLP9xwV56S8m4VS99AYVRrNVFtYlh48IosF7o8CH3MYFOociduR0M nKuiqlzoCSvj8E61OY0eWKk59BS/sDAGg+cxFDoRJR4K5WoVWAdJEDTJV3sYdEb7FinaZ9 IbCVmafzbuuz7c+ofPoOVTVtLoxeNqFBvlkg9BSTSjPTExL+BfV2XrsK0qi1Bq9X8xIkRu 0yE5ztEWRZnD1dmGEtBrO5wxd5qhs8mKU5xl39PJqqdYfC7Zumw1NU03wbLeWA== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , Michael Riesch , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328 Date: Tue, 8 Oct 2024 13:15:37 +0200 Message-ID: <20241008113344.23957-3-didi.debian@cknow.org> In-Reply-To: <20241008113344.23957-1-didi.debian@cknow.org> References: <20241008113344.23957-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_043428_568255_D83E9D7F X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts property of the hdmi node has 'maxItems: 1', so the hdmi node in rk3328.dtsi having 2 is incorrect. Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1 page 16 and 17 define the following hdmi related interrupts: - 67 hdmi_intr - 103 hdmi_intr_wakeup The difference of 32 is due to a different base used in the TRM. The RK3399 (which uses the same binding) has '23: hdmi_irq' and '24: hdmi_wakeup_irq' according to its TRM (page 19). The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi' according to page 17 of its TRM. In both cases the non-wakeup IRQ was used, so use that too for rk3328. Helped-by: Heiko Stuebner Fixes: 725e351c265a ("arm64: dts: rockchip: add rk3328 display nodes") Signed-off-by: Diederik de Haas --- changes in v2: - Added Fixes tag arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index b5cbe7cab10b..0597de415fe0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -754,8 +754,7 @@ hdmi: hdmi@ff3c0000 { compatible = "rockchip,rk3328-dw-hdmi"; reg = <0x0 0xff3c0000 0x0 0x20000>; reg-io-width = <4>; - interrupts = , - ; + interrupts = ; clocks = <&cru PCLK_HDMI>, <&cru SCLK_HDMI_SFC>, <&cru SCLK_RTC32K>; From patchwork Tue Oct 8 11:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13826359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBB8CCEF15B for ; Tue, 8 Oct 2024 11:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=peeabTOABYC0nWIg+RP928nGWNb+TXD9OrAxjF/5V8E=; b=ZWSo0s0bQooFGj cPxKdG9vLuKKMZjjhUn4PhH9m/+w/4OJ+v0VDYyUZ28D9yYNhhj4IKA5ZAZ7rNgWmQDrQzHC+pbqT sJI+WliRqm9rK5kq0FbQRgkFbMXWMG9dt9plzr+wd7/ouvxBW8W+K/IEHJjiugPctvLNlg2FjztK+ jfeKHviSnyDHqY/3XxtpNp9O23k1UJ/XuuQ/HsgDjgC6LYM/HY1X8pRL3QE+whVaWUtzxNX2hw04S IzCcHy27EWY30wPVGUM6oTo3Ia0A5KSia3TvffVWfLX53t7Y5UhHwEJl5ZewR8HSJX0CNC5ZKgQxi GsDetQ785T8I0/J5fcwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy8ko-00000005hhY-1lFE; Tue, 08 Oct 2024 11:51:50 +0000 Received: from out-184.mta0.migadu.com ([91.218.175.184]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy8U2-00000005e0d-2K3p for linux-rockchip@lists.infradead.org; Tue, 08 Oct 2024 11:34:31 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728387268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNxjNd6yrVtYzBsqUHl4cB5Rc4c+PEgl84/4jE5hQ1o=; b=d51xGEiiShgKMKwdlw+LhAZoNulcDjKyuK6LJMYI/xJvPYmnbpQRMzFHh2PvpuYhdX69MM LnsHWaFdVMgp17WzooASMZ+rBqzWnRcG0wmDnWOzKz1r7DFOeMvibOztovfiWdueS2g/yi 9URd2+OkF91KjDK4ZnrXPEqVFqQQtEWPYLtXeyuKRdo1SxTUEcGuxV+cBI3BJRsbXwY85O quWZdrsd+mo+jNSqVQr8UfaG7RoXssjI6KvnoRiE2OvMS61lnHDZvbkd1DZBNrvv1lcWZj LNOB6huoVfvVirxyoCfx0ToaRpH6J1a1ybK6KLWZbu7oVJnfAUeRkdx/WPYivA== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , Michael Riesch , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] arm64: dts: rockchip: Fix wakeup prop names on PineNote BT node Date: Tue, 8 Oct 2024 13:15:38 +0200 Message-ID: <20241008113344.23957-4-didi.debian@cknow.org> In-Reply-To: <20241008113344.23957-1-didi.debian@cknow.org> References: <20241008113344.23957-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_043430_776431_3C1A583A X-CRM114-Status: UNSURE ( 8.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The "brcm,bluetooth.yaml" binding has 'device-wakeup-gpios' and 'host-wakeup-gpios' property names, not '*-wake-gpios'. Fix the incorrect property names. Note that the "realtek,bluetooth.yaml" binding does use the '*-wake-gpios' property names. Fixes: d449121e5e8a ("arm64: dts: rockchip: Add Pine64 PineNote board") Signed-off-by: Diederik de Haas --- changes in v2: - Dropped change already covered by Heiko's patch; updated commit message accordingly - Added Fixes tag arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi index de4c082dce07..7381bb751852 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi @@ -684,8 +684,8 @@ bluetooth { compatible = "brcm,bcm43438-bt"; clocks = <&rk817 1>; clock-names = "lpo"; - device-wake-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>; - host-wake-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>; + device-wakeup-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>; + host-wakeup-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; pinctrl-0 = <&bt_enable_h>, <&bt_host_wake_l>, <&bt_wake_h>; pinctrl-names = "default"; From patchwork Tue Oct 8 11:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diederik de Haas X-Patchwork-Id: 13826360 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D48ACEF15A for ; Tue, 8 Oct 2024 11:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=625L4M+dcVRYfDL9AfTMOCj34mdjbWhZy2MqlIFIl1U=; b=ssBFCp4TDNe0s5 qU0hA85nPK1FuGUiCLGeEzlO0O/a6ddSTA1jN+w99ahONxi23CVifmy4LON7OShQrMtWm7hXdiPtd cL1D7uf/61mYf7gL07iMha0W2FDcHGTsUodX6YPzu2vZQv71U7ZM6kr+dGyuCBnGTXHd44tN49FTu +NFfMLujIQr+K8shX2TTQqjczVmiX6UYGrPkiy6ZY6l/RpTBcrYGN6oookwe7hkJ5QWqGPL1ymqE7 HX402hCuFEDz/6JG5UT5vTCurhGlseHe0QnUvUA8L8e0U1dsqxp9qr1SIhz4M3gXt7ABl7qIN+P8Y ku+WD/tImU4vRjmZ4Teg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy8ko-00000005hho-3ZM8; Tue, 08 Oct 2024 11:51:50 +0000 Received: from out-184.mta0.migadu.com ([91.218.175.184]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy8U8-00000005e2V-1Gum for linux-rockchip@lists.infradead.org; Tue, 08 Oct 2024 11:34:37 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1728387273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dKlqz7no2Q0t056MIy0/Nk83i3CyvmCGheL9X0Hx2a4=; b=Gih9R00ND98f9TxWntc7iICTyevgHbEJHne476iMNtuYR3DmO8m1rXXY2CM9F8xB0VAaSr 5m+uFIcE2deDLKvzy63wQ4Fn54thb3LPC0nvzHjmLreIpxVidW+Zsay+r3bkOTOg6EeEQV sHpTopbwjLFUYybAis2ixpUgJmqUSW7viIKDbJ4jbld5mZ8Sj70sPDPr0+2/h+5NEZovQG 8M4D0FBvCjqRoj5gIAB1/03yIJheWUK8O/hBGCqtBkpiOshbd+zF2PYd7X5sSzR9tMjLl2 Fdh2yNdjc/zdtyfvC7Kmtt4ZnL/J76TFm9oPE9iEX1raH3/Ltpr3jXJgUxzSsA== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Diederik de Haas , Dragan Simic , Michael Riesch , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] arm64: dts: rockchip: Fix reset-gpios property on brcm BT nodes Date: Tue, 8 Oct 2024 13:15:39 +0200 Message-ID: <20241008113344.23957-5-didi.debian@cknow.org> In-Reply-To: <20241008113344.23957-1-didi.debian@cknow.org> References: <20241008113344.23957-1-didi.debian@cknow.org> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_043436_511570_A73083DF X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org For most compatibles, the "brcm,bluetooth.yaml" binding doesn't allow the 'reset-gpios' property, but there is a 'shutdown-gpios' property. Page 12 of the AzureWave-CM256SM datasheet (v1.9) has the following wrt pin 34 'BT_REG_ON' (connected to GPIO0_C4_d on the PineNote): Used by PMU to power up or power down the internal regulators used by the Bluetooth section. Also, when deasserted, this pin holds the Bluetooth section in reset. This pin has an internal 200k ohm pull down resistor that is enabled by default. So it is safe to replace 'reset-gpios' with 'shutdown-gpios'. Fixes: d449121e5e8a ("arm64: dts: rockchip: Add Pine64 PineNote board") Signed-off-by: Diederik de Haas --- changes in v2: - Extended commit message to explain why replacing 'reset' with 'shutdown' is safe - Added Fixes tag arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi index 7381bb751852..100a2774bbb5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi @@ -686,9 +686,9 @@ bluetooth { clock-names = "lpo"; device-wakeup-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>; host-wakeup-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>; - reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; pinctrl-0 = <&bt_enable_h>, <&bt_host_wake_l>, <&bt_wake_h>; pinctrl-names = "default"; + shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; vbat-supply = <&vcc_wl>; vddio-supply = <&vcca_1v8_pmu>; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi index d09e6542e236..3e0cbfff96d8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi @@ -402,9 +402,9 @@ bluetooth { clock-names = "lpo"; device-wakeup-gpios = <&gpio2 RK_PB2 GPIO_ACTIVE_HIGH>; host-wakeup-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_HIGH>; - reset-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&bt_host_wake_h &bt_reg_on_h &bt_wake_host_h>; + shutdown-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_LOW>; vbat-supply = <&vcc_3v3>; vddio-supply = <&vcc_1v8>; };