From patchwork Tue Oct 8 15:18:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13826629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CAA2CEFC26 for ; Tue, 8 Oct 2024 15:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VmnxBpXlFHXhKFBYS5KznXkNQ72/KcT03vd/jPVdgFI=; b=SUzmemXVPSXobyQCBcmuf3QjPX fBpQpI+9t+maaB8K5v/Za3fL4vJBPIXsDVWWsV2wRmzY/JsR862N7zasYMm6/nCwml4eKArtcfH6X ACZNTVAB8cvagjuGVMwldiW+HhhTtFYogwAucPN1XrlFvcF/L+YwmlVWtvrgWNBknYKlahW4JSGly 4EVknZqVUAXC1L0jfhpA4ZGitoYjE5fba8sRwhqONUg19EI2bi2UO1xVNKjtQWPbsFc10zc4I3ux6 s8XfZAaKc8MXW+xTPm0V62geJTR4DLzXm2om2dbxTSZkHfmMn8dRDsxgDmNlRQE1FK0jCZ87teHhF piRuWERw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syC06-00000006LSP-0f1o; Tue, 08 Oct 2024 15:19:50 +0000 Received: from mail-northeuropeazlp170130004.outbound.protection.outlook.com ([2a01:111:f403:c200::4] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syBzI-00000006LAZ-0Nn4 for linux-i3c@lists.infradead.org; Tue, 08 Oct 2024 15:19:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L2V2LYdcjEA0jgBTzCYfg8KcJF2zvjpDwo2mVgvhaSmCZKlUMQ0etZ2QyeZnexMjkKgmPUboBIiRKg/w1jsMAjXRMSM2ksreHo83yhMI3wpedEPsOeqRzaux6E3YkacWhEeQPKljlPz86VnSOPaRS1T7lf7gosqnoKxNkuSGhd3nswLwR3wXUokHk4p1dWSnJwt39H6xrB3WPLmU5Jk7x5wIsDMoQ9wqMB2VWmmFNDQFk/TxchVQqJYERSgvubPthgDQPLanL/T6xKG7w8awbp+qQdo8Yp/Vj5vEONm+EOtvKTceLRsQZ2NcBJa+Gqz6qPFGXuE8ueYIF9vvA/qVnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CtrMS8OXbe0qcYxmNRu2SlrZq9vhMYyZCg5B65vBMeY=; b=soocErKvx1hSo5ye/7oSqx8Y+s6/UooqD4cj5i35hKZSTz/a3KB9YZo62cQTGShfOjSyFcx+57tuh2TAjLUfHZyr8yuVeVCNoMPwirporRDydLcyxxl4qzJzwtDmDQ//WPnhRg7bRo+++TZAt9FZVXNydQU0udEySLUpbilqKU04GaagRN8yHqdmFMPOtkrmeOpMvcKNi6EQwhTAigFJvvZD1Y+PGVJvkfLBp9SOQAL/F5AvnSAQ/ZaANad6BoF4wZleZYrSM8k7hdMLXRwE2Eo0TjlJ4eRz+StH6M7qMxnvNWSVPFiJtdIoRvlyaOUTgyqBmGcfZCjXjTUClKI0MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CtrMS8OXbe0qcYxmNRu2SlrZq9vhMYyZCg5B65vBMeY=; b=aDHwHjT6R3oBw8A2rX3nt/STBxD1aODnZtXarkBNXrJnYeR7w1serANqLxLcPPqcngJgJXUI4lqXfgFEkiFM9GL/rt1tUOYWSsM7BiM0E2Y4VRGLpAn0OhpgF2WBXlUsFtXGI9ZiRD1+IQcMjhkcI3bp/ZOVgQ02DyYJYOuKXTsWjjeuh5jcucUePo9kf+L+CyjPI8auPAmqUucyjQjGwC3NgZBkfWtP87l4+Z150taaSsnPeY3EuOZHX0R9euH4TsCBqz5HTgVYqcMZQFx6oGh91u5JS9+tj1TGBvYzYoLdG6FZT/o9Qq58dUFNvkEHMgxbySHwgv1ZmZ8+5GIt7w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DB8PR04MB7194.eurprd04.prod.outlook.com (2603:10a6:10:127::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 15:18:47 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%3]) with mapi id 15.20.8026.019; Tue, 8 Oct 2024 15:18:47 +0000 From: Frank Li Date: Tue, 08 Oct 2024 11:18:24 -0400 Subject: [PATCH v7 1/3] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_STATUS_BITS Message-Id: <20241008-i3c_dts_assign-v7-1-96ec93d1f34c@nxp.com> References: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> In-Reply-To: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, bbrezillon@kernel.org, boris.brezillon@collabora.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, miquel.raynal@bootlin.com, pthombar@cadence.com, ravindra.yashvant.shinde@nxp.com, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1728400720; l=2178; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=mJQ2NVwjODXELkcDKNUIEYw/DZI0LGJGAQy+lGen7bE=; b=UnbOBSsYXxfymZwvnMKhf6Sj/J6XWt0gN36MJyZunF41KlP0gmWvL/QhEQ82FL183JmvlROKG 00ALDPU/NVyAP0Zf4eLkR/JyXjkaQxwKyAF7afIoDtL2fERVCQmqUcR X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR11CA0101.namprd11.prod.outlook.com (2603:10b6:a03:f4::42) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DB8PR04MB7194:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e3c7333-6db8-4aa6-61d0-08dce7ac8156 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?bh1bNck+8qaZwKygIZMLDDpj/ffTlQ1?= =?utf-8?q?tnnVvz927Exs9Sds9uVBDPxCXp2d589Y0FrHJmF07fGbbdlnpl7HofHxqTTxyI4yh?= =?utf-8?q?8hskS8ZKQIVqLvIDqZ3lY3EqD2u0Jm2rZVx7rOEyu4Oj1Bnn+qIfy7JzWB7hNaP2B?= =?utf-8?q?IRRL6FA5WTpghSEbssVfdK84ono474zpPlJOWtUWj+yyOkY9Bk7exNlNyH1q8VUfW?= =?utf-8?q?Hh48gm1l4knU/9g4XHg3UHTQdJCFgHiTpy2UAKBjhMx+YIHBrCGr6ybNRMAtus6ho?= =?utf-8?q?MX9xctlfZuf5f0/Bx2bvOd1i2HVHL94J3o3u4LRYg7pl+cDfGzWV5IPvs57b96DUn?= =?utf-8?q?zy9MocLYuRJM5hJiQbZireIKu/DGKgvwwLlqh1inv6DaeXGz5rSkpHOnZo+O+/Wc1?= =?utf-8?q?w4DIvumkodSLrZIzLtVYVWlBHvtkh9rC+V2at2ZiPrSbQdjY+PRxS0GJBaGAac6Ks?= =?utf-8?q?C6nFiG42HK6Sk4btO6XGuuGluaSAknwxW4pYi2u3mxU8paWAaeP7GoFEO0AAvWnfN?= =?utf-8?q?G72qkSlnSGgSM46sJWIvyrbWVpq6XOuw7MtPlKDwGYJqTbeMNpfPfKioKlnK0yKBZ?= =?utf-8?q?ADe3FVUNNXkSLnB1pUdKgFk2xAKFffpNDpqdOw4I2dFdM0W/1a1ecleYQkt4AP82X?= =?utf-8?q?Tbi5h6pERkvMNdJ3ZinY3K85IGs/VOI7+dWCoEiqw+PoIfLdis/uRsoq8/V/iP9QK?= =?utf-8?q?5sDDSr0HCHW+CKFfSdtjL8HFRjckiidbZEgWiN+YiU5vewVgkz4rLNedmDVViPGDU?= =?utf-8?q?6lJD2WjCT/V3PTaOnJhiSF5IxAXWsBv0sLxz2H/x5N0WP7pif5Ahy/G6/SC1WJ8JI?= =?utf-8?q?v/nTbQgvUXYIW/UnxHpp64IC3oEIsIFsb5QYdy+uyyxAyL+xslSwCiCuTP40mt7/Q?= =?utf-8?q?uBI7yiyJ/MwtVFXLAje6cg4eapObQRv4UEy/2TfSu1YvWXkvaBIekL2QvIDB2j+rA?= =?utf-8?q?CN+NynBAjWpzJdv2croNLyry+y73T9PyePzFP8uD8c7zsPeFZAhhwc/xlT2s1JH76?= =?utf-8?q?D6zPfswA+llknmAKygKMeusn1+MLX/X86B6r6MkZl0f2JX8I4nqo1Lqlc96pVJZnR?= =?utf-8?q?MoGcwUGv+VEyQWAT+hyXFoC/7il9OatN+Xu3mYWoqQcdC+yMUbCTaEBi719rC7631?= =?utf-8?q?R6bH37zXnZ4dXmP/ApviWPxazs692RUQMNspnApvmfCR4ifK0Ph25YBxR+5l2DqCL?= =?utf-8?q?ONZ/g+tIEGa+UTBvVks4C4vv/jZyjpxg2QC013dvXP2cZEBRevYXpoPZL0wx8O13S?= =?utf-8?q?NFvZIfmub498npaWvZkt5FGuiB7mamIwV7Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NV63vVP+fBiiqS4CpsX1ock6zEbS?= =?utf-8?q?lPNME85KdqDhJWiJ3q21hmXQA5h/eofufdX/w1cd0rNVbRf7U8o8I910Bh37Q3Uen?= =?utf-8?q?baX1iNaEg4AH7c9s4RRf+Pf9OYEM9kY849ID0Ci1qQYSYGyV67doTx4kT2boR6w/Y?= =?utf-8?q?vj7quP4KpcPMEuvQJnvPZPfJhuOU+93MmbY2N9IqOcA6WDW6r23rt9MQFLXjFdXAF?= =?utf-8?q?wcecQERtRXDHuLM5sWEgltBILPcBz1u1U2Th7sW/MTlGr9J0iMDVNxSMNvwahtV+j?= =?utf-8?q?NK4F4j122gnQFd2bSoFpqucmn7RzgZ29Nx0A3PvRBCiMhAqKYhng3bNMeCALaROE3?= =?utf-8?q?7aeUVoHbo4Ms/xZYtgwCANXCmOnZQmjZ5PZN7bxCCvfd9X9TV8hqVR90sYC9OpWtt?= =?utf-8?q?2glRcgvKT61KR9pvfOy+V9y+/TLoPcWujsZsOQnFyNhwTX7irGiWoicv8f61UWYVN?= =?utf-8?q?aoTuhJausVYJ5SE1RTKIpcMpoSyxRPL5S7bZ85zlwhgMflsfrzISLF5lzBHh7RY3O?= =?utf-8?q?BV4M5MrWPogd9Sh+7nOQ3Omiop2c4JiSgqD++AhcqkDXXNFcYk6PK7bvinO976sXV?= =?utf-8?q?fmECn9LtCiX76ApeKgRlKDtpQ9/4fUa4tPioA/aJEFN5NnduBubiixHTX630IZak3?= =?utf-8?q?IKcJxbvHlXZObqyIpVj4YKv3SiSAcmDAw77SZ/hMm/aGucKrw4tcBfCfwluOVO64p?= =?utf-8?q?3DXYAuw7u9t52JL7yxqzddDaHAz7X7NSuuxF1E54fJjotOLS87mup1h1srk3OHgta?= =?utf-8?q?OU/uHewb2kNEk0p0krTeIV/upI+T+2HBrTtmWY7lVWohoRSqzbOSNRcEoRQNDQW9c?= =?utf-8?q?JNHMiqL5WFUrDZZC9YCD7KwRt65075OcPSlzvrkd/X3O7UA3bBu3dko100yZTJBzr?= =?utf-8?q?YgGj+u/tHr/iYkgUsVpM4/GxRzf9vpSXaihSAQB0cvnIPha74Fmgdc0jIB4b6Fs5x?= =?utf-8?q?dwQgcNhUlsn0N2qIViqwt7v7ovLAQwHbuWLs+IqWftGt/TMdbLQ4HS17+k+MOqed3?= =?utf-8?q?nsRXkLPtQ0YoHnceWmy45egAlYtZPH1Q8az+nsVUAme/QzyEqmwkGzoTgsDmPXJa4?= =?utf-8?q?WR5Y8IJ7RIwr3/DcD7YGtPgz56Qj8SLJPV7B1Z6iJmVsjObcr3YQpkgK9Yq8CfgFZ?= =?utf-8?q?t/CEt0jEyN+oBEN4ayJyycWhfvggAnRCfILo/HsMwvMbzMOni70DJxgoMFpV2gV8z?= =?utf-8?q?wNt+EoXVwa2G+uagC/ybDgBFIJg6v5hatYJqmW1q5KOxqjGHrrcBn26ZhxcJ1Upah?= =?utf-8?q?LY1ONuPK8eCVi6bxQ0rpQBz4gGLoedCVLWn6bbF864VSKO72oRVf5MLVIqOWa+siE?= =?utf-8?q?Yxp+ncxtfPo3NzUWUQnNMu9ki7dfQNe8WOzPvXPESFeBxZ0kXNKe2KJGB95hO6LAl?= =?utf-8?q?66q2i2Z7EqmDp3TezjYvPvimtc6z1xWKhIY7rQ61+8FiuLrvgYKW+sfnz9B9yO51D?= =?utf-8?q?OY7bqkMfSkDt7iBF+MtUzBBZCLLFeywjlefNtRFnXKHjStGLNqydob74=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3c7333-6db8-4aa6-61d0-08dce7ac8156 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 15:18:47.1137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Yj42lLtg32gIdIQBoCSe6mwHyiSIugfzpGMYfpN7YT3u338H8Io7SMOIX4AiIQigdtMLWmi9PfWTfcuWLz9KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7194 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_081900_323833_B6026EA7 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org Replace the hardcoded value 2, which indicates 2 bits for I3C address status, with the predefined macro I3C_ADDR_SLOT_STATUS_BITS. Improve maintainability and extensibility of the code. Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Change from v6 to v7 - none Change from v5 to v6 - fix version, should start from v5 - add Miquel's review tag Change from v3 to v4 - rename to I3C_ADDR_SLOT_STATUS_BITS --- drivers/i3c/master.c | 4 ++-- include/linux/i3c/master.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 6f3eb710a75d6..dcf8d23c5941a 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -348,7 +348,7 @@ static enum i3c_addr_slot_status i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) { unsigned long status; - int bitpos = addr * 2; + int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; if (addr > I2C_MAX_ADDR) return I3C_ADDR_SLOT_RSVD; @@ -362,7 +362,7 @@ i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, enum i3c_addr_slot_status status) { - int bitpos = addr * 2; + int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; unsigned long *ptr; if (addr > I2C_MAX_ADDR) diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 2a1ed05d5782a..2100547b2d8d2 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -313,6 +313,8 @@ enum i3c_addr_slot_status { I3C_ADDR_SLOT_STATUS_MASK = 3, }; +#define I3C_ADDR_SLOT_STATUS_BITS 2 + /** * struct i3c_bus - I3C bus object * @cur_master: I3C master currently driving the bus. Since I3C is multi-master @@ -354,7 +356,7 @@ enum i3c_addr_slot_status { struct i3c_bus { struct i3c_dev_desc *cur_master; int id; - unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; + unsigned long addrslots[((I2C_MAX_ADDR + 1) * I3C_ADDR_SLOT_STATUS_BITS) / BITS_PER_LONG]; enum i3c_bus_mode mode; struct { unsigned long i3c; From patchwork Tue Oct 8 15:18:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13826628 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54EE2CEFC25 for ; Tue, 8 Oct 2024 15:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Iluhnb01AKGNGR+jBx1DVqxu+M/Ai5MzHHw3cckrtF4=; b=J3nr4YrH4Bf1znURRM5/iqtl5R k0YjlK8nWoym4V0cBhwuS+rhVrICQ23ziFld84lRa3qZUyIoJGEvMZqUaOddbpqtNhIk8DZ4W+WKd PhLHUZ2ftLMBhnik3A5HJQM4JZb3zE2+Oa8paD7lxWwBo8p9KQj5WsKfJEkkRLiv4nRvNttbMi2ee bCR2uKXKeieavgRqKYI0xdpapYuJh3yiIJxVHwXv40Or7CMY4kTUBKIPpJTfFpFFrxAU49rboK7zI jzaJDCGkNEsHkTilaiMqwpovpNMdlvRNWPPapTrHgGkIll6QMlDgLg4jYi9pOmFx1QAdXt/HVustF dDvLetPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syC05-00000006LRs-373E; Tue, 08 Oct 2024 15:19:49 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syBzE-00000006LCV-2KRA for linux-i3c@lists.infradead.org; Tue, 08 Oct 2024 15:19:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HGreRLiFMWsTP2plL6yEGXGK2OMRE/WOj5M4zmOfgrawzjqy9h/tKvFOHmsRarN4wzNjbUr3HwIr0vc54WEXJUJ1nMjmmCTTUv5gd9EHRFEcJM4qv68omoBYN5yAc+j7lUXVX9rxkUNTei8jmGCLtB2ntifBheRUHEaa1yf0pabExgKetgskufYIVGR0hMqIzAvBHP8oEyZ6I7n+3PCJMjN/1O0Sw98u506eDS3IFb0lXSn9pZeD93+qzaFSlB71MlsDDEkPLEGtf6v9Y9f3XEXNyMbf/g9el+Hoh4InEW8TObCo/3sSuHLxOfZNNsHDRZ8sCiwp7TObdhluz7Wf+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=08TqXfMeHDz+1O9efCr97YY0qpO561DtJ9QcljgnDAw=; b=ARwXktwgsQdGZFloA04YHGUl17okMYFF2oyugjB+IO2o2xpBRw1I2aZDypsCTJyTRPw/e5ygmrNtY0Y8R37zyyifK7Ab8BCJe6t/Z5zrFWv+7fRf75g4BR4bOt7T361nRQ24r2xirLhJRC47V2r+fJWfxLmDzCbZPSY3bbW4rxWdcvdEKYsoiEHbpYFnCZFgENQZJtXTdUp3AtibZ63feeawCBEydQfbYckFz/SciJXxoqVFnCcTvRB5pfy4osM7j6ZTFz1uA5IryXLBu+wjrgiMt5249XpjpYvPliPvsvMieb/mctol0bxJpUik+yGlDu4UJeFdshskFU2LbkgJPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08TqXfMeHDz+1O9efCr97YY0qpO561DtJ9QcljgnDAw=; b=S0sc6oP+IiLDsmXL7w/UOdobBdHR2y3beiar0Hee0BJBRjAk36UriAGXAGU5Yik5xGybKXx0jPEa1KjtkNGNnfK7G10lcf5/sUbjsfoEuz3kPHLNzkeGoA/A0Wf7akDizIhNgKrflEoEXgDyg5vIoR/a8jdJFZ0k5claPReXE7h1blaO9sp3ea1Mb0GpeGjhg5bofOJ1MLZ4KGJ3TVdHIJ/gMSJFhc049tEeRKiHMzoY7Hp8ly7eNNR4hQlzpNYjySIokNKjbvosdS7xkEpyhjzyMCbaOHf9X+BFA6nsttealP6Cl/m2GUNdYJT//Ji9HNiKEJAIeMJh3dPq1IAEOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by GV1PR04MB9151.eurprd04.prod.outlook.com (2603:10a6:150:26::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.16; Tue, 8 Oct 2024 15:18:50 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%3]) with mapi id 15.20.8026.019; Tue, 8 Oct 2024 15:18:50 +0000 From: Frank Li Date: Tue, 08 Oct 2024 11:18:25 -0400 Subject: [PATCH v7 2/3] i3c: master: Extend address status bit to 4 and add I3C_ADDR_SLOT_EXT_DESIRED Message-Id: <20241008-i3c_dts_assign-v7-2-96ec93d1f34c@nxp.com> References: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> In-Reply-To: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, bbrezillon@kernel.org, boris.brezillon@collabora.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, miquel.raynal@bootlin.com, pthombar@cadence.com, ravindra.yashvant.shinde@nxp.com, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1728400720; l=9439; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=DM49R5v8+YMNDR9//TMHOLBKzBjtV69ySuusFjVM3qY=; b=Y/5zhBvg8X6/Qsayadwo5NAKGThxoscxMRhH+p4wkb8KLg+9IwTPxgB5IvDzYkMViMwicvkBc aEgBOYryRubDxlAQ21oYyKlQGt/iMC68Szt/8mE1L4gZR772P74L46N X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR11CA0101.namprd11.prod.outlook.com (2603:10b6:a03:f4::42) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|GV1PR04MB9151:EE_ X-MS-Office365-Filtering-Correlation-Id: 75433974-652d-4c6e-05ad-08dce7ac835c X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|366016|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ezdfSS4DwvLSPgvFolJo7s92+fNslY2?= =?utf-8?q?iRdM1VE5lrjq4CtXZnG054c57a0aS1j1tdBUz+U/8cuB6gNbe0mNhHW3Qjb79MMFn?= =?utf-8?q?e/+8XbXJhySVwg4w6wW5x0H6uMcICZfK7jV2pfaILMH6ftRwb3T26LvqakWqdkfb8?= =?utf-8?q?Vitf40Fciwvd3Rr8qTWPdJDq4uGT7erwZCst0Q6yzcLDjXqfP6VzNFdyTIqPUJddD?= =?utf-8?q?DEPmK1eNqI10Qe34YSDr8F33Ka/QsEcttT7dQ2Msdw+RTtxtM1BQX6B9mwzs2C9jj?= =?utf-8?q?NzpbGqQYM+XzH79CjVVbV7g0zvm1GeG9NhSprAJ9q/DBccf47VmFDwgzGwqzW+Ak4?= =?utf-8?q?r2z6u1or6HLDjCBHMRUHg9GkhqesofktwKKfw5sNt0VvsV2F3iyeGxthl3G6VU2ak?= =?utf-8?q?i3NQJCZINZY4mQjqHJg0242nK9WLf0y1PGxXVPebx4FQIQEL/d6Uhoo7UKs/ml2rB?= =?utf-8?q?AXoPbG1hcINF+CpV8+n5SulJVKTdnOzEvDy4XI2fmkSeygyQ9qbgeTmS+5axSgpp/?= =?utf-8?q?lU4HiSfJfpRxER2MLjv97sUAMe8hLTLnDUhfWXcjXRDnwEeA/+LpG8CBhaa3uHduM?= =?utf-8?q?EPLXD1n3g03rdeywZHdZ7+iFvMk4SYcRC5u4m40k53BFt2EQhLGiu88zpGcajh90r?= =?utf-8?q?YYmU1UZHBnwulshRAaotf3Tal5uWHGfnzKzEw8ueQQK9OwlZp5sZTXlN+wQzBxfLo?= =?utf-8?q?LNj8wwgz1+JE7nZQWJ7w18T0M2tP/9eOg1xj0b6AA5M8GHYYoNifda3URVYlHXLE+?= =?utf-8?q?RC0qTk2tsi1OQb79E/ll9iEDSUU0SFC4p+d1bvh2DEBzsaEYmUM+//9srSGLHZvp/?= =?utf-8?q?ZnfvRBbHLm4r7F+C6JRAfRhpuDWkbjcpV8n10xFolyRymB4OK7pufOVwk7Mr1rcbA?= =?utf-8?q?umm06mzIYSaEMJspcxWI27hSS8EAQhCJGqx1MqCfA95uCiHpu4VrDdjNudzyO48xM?= =?utf-8?q?gPtrhQ0YvwRxbHSF6nozqtRUWwSHq/4vo28JHa1ohiFpJKDmHeaNDncsw0ipHynmc?= =?utf-8?q?iW44C+iZxum/r7CPXSGthcdFhcVAbTWYHhJA2ZhXG9sw9uNts3Y1dt7iNgvgbf+0G?= =?utf-8?q?ZaQyuL6eExJYAFlq6EkmV+IGOqv4rPqY1x9rzisxc1ij+s1DqxH0wOUdoQzOC+xvY?= =?utf-8?q?gGWF0yxBOSLwt1rq6+Z9fUzaX2OrBPreEDzyfLKGOMOHuT97IO+1Yp+jgi1wNEYva?= =?utf-8?q?MPCgX0khQL8qFENJGsPRMZYz8Lx592CHHV/t8F0Tnk2QOi/JRiplUbej/DVYCOp6O?= =?utf-8?q?0aIyqX0LiK3bE4ikIKB5KkVnF2HetedGpRw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(366016)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?wVl0Xv+1lTeGOq+snZbPbppAPMs6?= =?utf-8?q?asP+KPKrxAOL3Akewb+Am7gKKnIzCdZo/9i7gIrqlu64kOUbmzlWM/ByCNkk8A0oh?= =?utf-8?q?e5dGwBFPAof5lXpEqB5laSydOaWfZijTrOOsd6wAmEJsSnM6Mg9TXmPVHlB0DsOGR?= =?utf-8?q?ETVvE5isRSoffwCKBrs47/SsV54lbGu0xmqmlhaK7NUzakA/maZWoMgyuPC1hE5B9?= =?utf-8?q?aKc17t6UHewaHb5gTnKkb9VY/sdSTbpgYEEPZwFPuc44EZgn0vCw21enbsXHWfkCr?= =?utf-8?q?CnOxDdefdBNRvTZ0/eXguf0kfAZgKg/a24vG52m+dsL1IdsL4NQILg2vTd3VDIYHp?= =?utf-8?q?3xeRinmZH114t0MNsuZYSGB3lCrM3zAfn5RWHwMnhbkHAxXTnEBDVTIgoOz19ajR5?= =?utf-8?q?QPKhN5lR8vlBPvJrhR8N97iRkhVHSSWZFbgkys8eqAOOEnOJVYNc0ajQqXIQCG/vW?= =?utf-8?q?wjfD18rw8ddvQaEWLXC9lVb9R9CnN29e3pBm7IaNZ0WwqZFJWtWR/88Uo1PsJ1Cdi?= =?utf-8?q?SMYiYlBgZdZFPshTK7BP1QXummnyaN7S/0WHj2d/AHtTVD2QXoDuwbIfY76dikghz?= =?utf-8?q?kSbARRZw8A+4t1q5WkD7vJKdluKdifGg7ppFfVAoO4x6MkM+JoB39Q6ZWFnLmmJig?= =?utf-8?q?E2pXjhVs41AEOpeVrFpZaM4xI419QtoK+RSAZXg0cSj4EqjOYeQPEIbocrSbDYfO9?= =?utf-8?q?ru4XxWyB6qj5bH+PaV29wyFdepIfx4g8biUjGvRAJZgL6bnF1V9R3SLyMp5iKW8Dx?= =?utf-8?q?FnIaSYAs9dg17qP1kD0xo8OdQZrWe6M/cfWOlsV37Fm+E+wi5SXcVVBFnt/LfaFpg?= =?utf-8?q?AOnYOQlg3Snu4DTJh2larBaBjxJ6A1KGBIepkXaA4AiGXKRDewN5DkXBNI0FFhPA+?= =?utf-8?q?fH0hY9dwokPFqcbpB9FANlie3nel+Wj+tgFVj3xR3tw9XTieN/gb6k6lqTGIEjdTN?= =?utf-8?q?PDdO5qSD+iSi/5a8Iidwge+QXzHuVkhiGIYBfkrqgoOpxZWK7+p7lHct1dEtgai+c?= =?utf-8?q?0h1k/QF50KYAwcD+WrO0waIyc7ysQcxd3ZhXKLZKNy4W+Apx5DKNZSkm3AG/Gl/7u?= =?utf-8?q?/qj9TAs2uSa7IAqNO5e1e1o8jmHgUwV/vfQUfGEVIkkml3TbdQE/RgdSSHxwGrEJU?= =?utf-8?q?O85zxogVdQCDzpQh1+aNbFfnmnMxtmMnueTEbO860jUGlBoqwwHwRd+fyhnlbIleh?= =?utf-8?q?TC2J6oIWPK8kmR58k/UfszHCUWDCLpHEQ8wKoW8p1AuXhyW7hrI063ytPzcDDs0AG?= =?utf-8?q?J1KF3WDPkOkUFqM0LFFDh4MjcwBSHha4xWANvF9EBc7pw8sWFLquznVBc18IoHAUX?= =?utf-8?q?R5ep9pTdfGTbadXUVnmUNHgggJE5hOjz0rNmjpV12Zeyxj4H15ymSMTFPpo8LAbtI?= =?utf-8?q?0IjGWvD4m/FRI9LUgU7YAN/bOCYI7Nbj9WhvkeWyVJGbUh6wUW98thQOwfPkB1RjA?= =?utf-8?q?3jYnowLyMmAJXHHjz3YNg53X0I7Q+dl4Pc2KXddZsEIbXqk1hezK1LwU=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75433974-652d-4c6e-05ad-08dce7ac835c X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 15:18:50.4993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wbt7H1okrLvUtjQKUkve1STdF9THYaOShL/9FHvedbXdSQB81BuERBg7eRXqmtRwLybTqbePVKdlqXwg/0Fysg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9151 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_081856_864964_D068D191 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org Extend the address status bit to 4 and introduce the I3C_ADDR_SLOT_EXT_DESIRED macro to indicate that a device prefers a specific address. This is generally set by the 'assigned-address' in the device tree source (dts) file. ┌────┬─────────────┬───┬─────────┬───┐ │S/Sr│ 7'h7E RnW=0 │ACK│ ENTDAA │ T ├────┐ └────┴─────────────┴───┴─────────┴───┘ │ ┌─────────────────────────────────────────┘ │ ┌──┬─────────────┬───┬─────────────────┬────────────────┬───┬─────────┐ └─►│Sr│7'h7E RnW=1 │ACK│48bit UID BCR DCR│Assign 7bit Addr│PAR│ ACK/NACK│ └──┴─────────────┴───┴─────────────────┴────────────────┴───┴─────────┘ Some master controllers (such as HCI) need to prepare the entire above transaction before sending it out to the I3C bus. This means that a 7-bit dynamic address needs to be allocated before knowing the target device's UID information. However, some I3C targets may request specific addresses (called as "init_dyn_addr"), which is typically specified by the DT-'s assigned-address property. Lower addresses having higher IBI priority. If it is available, i3c_bus_get_free_addr() preferably return a free address that is not in the list of desired addresses (called as "init_dyn_addr"). This allows the device with the "init_dyn_addr" to switch to its "init_dyn_addr" when it hot-joins the I3C bus. Otherwise, if the "init_dyn_addr" is already in use by another I3C device, the target device will not be able to switch to its desired address. If the previous step fails, fallback returning one of the remaining unassigned address, regardless of its state in the desired list. Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- Change from v6 to v7 - always use i3c_bus_get_addr_slot_status_mask() in i3c_bus_get_free_addr - ((unsigned long)status & mask) in i3c_bus_set_addr_slot_status_mask() incase status bigger than mask; Change from v5 to v6 - fix version number, should start v5 - change to I3C_ADDR_SLOT_EXT_DESIRED - remove _ext function and direct use _mask function - rework commit message and comments according to Miquèl's feedback. - change mask type to u32 change from v3 to v4 - rewrite commit message and comment for i3c_bus_get_free_addr() --- drivers/i3c/master.c | 65 ++++++++++++++++++++++++++++++++++++++-------- include/linux/i3c/master.h | 7 +++-- 2 files changed, 59 insertions(+), 13 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index dcf8d23c5941a..e0962a17de7f0 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -345,7 +345,7 @@ const struct bus_type i3c_bus_type = { EXPORT_SYMBOL_GPL(i3c_bus_type); static enum i3c_addr_slot_status -i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) +i3c_bus_get_addr_slot_status_mask(struct i3c_bus *bus, u16 addr, u32 mask) { unsigned long status; int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; @@ -356,11 +356,17 @@ i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) status = bus->addrslots[bitpos / BITS_PER_LONG]; status >>= bitpos % BITS_PER_LONG; - return status & I3C_ADDR_SLOT_STATUS_MASK; + return status & mask; } -static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, - enum i3c_addr_slot_status status) +static enum i3c_addr_slot_status +i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) +{ + return i3c_bus_get_addr_slot_status_mask(bus, addr, I3C_ADDR_SLOT_STATUS_MASK); +} + +static void i3c_bus_set_addr_slot_status_mask(struct i3c_bus *bus, u16 addr, + enum i3c_addr_slot_status status, u32 mask) { int bitpos = addr * I3C_ADDR_SLOT_STATUS_BITS; unsigned long *ptr; @@ -369,9 +375,14 @@ static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, return; ptr = bus->addrslots + (bitpos / BITS_PER_LONG); - *ptr &= ~((unsigned long)I3C_ADDR_SLOT_STATUS_MASK << - (bitpos % BITS_PER_LONG)); - *ptr |= (unsigned long)status << (bitpos % BITS_PER_LONG); + *ptr &= ~((unsigned long)mask << (bitpos % BITS_PER_LONG)); + *ptr |= ((unsigned long)status & mask) << (bitpos % BITS_PER_LONG); +} + +static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, + enum i3c_addr_slot_status status) +{ + i3c_bus_set_addr_slot_status_mask(bus, addr, status, I3C_ADDR_SLOT_STATUS_MASK); } static bool i3c_bus_dev_addr_is_avail(struct i3c_bus *bus, u8 addr) @@ -383,13 +394,44 @@ static bool i3c_bus_dev_addr_is_avail(struct i3c_bus *bus, u8 addr) return status == I3C_ADDR_SLOT_FREE; } +/* + * ┌────┬─────────────┬───┬─────────┬───┐ + * │S/Sr│ 7'h7E RnW=0 │ACK│ ENTDAA │ T ├────┐ + * └────┴─────────────┴───┴─────────┴───┘ │ + * ┌─────────────────────────────────────────┘ + * │ ┌──┬─────────────┬───┬─────────────────┬────────────────┬───┬─────────┐ + * └─►│Sr│7'h7E RnW=1 │ACK│48bit UID BCR DCR│Assign 7bit Addr│PAR│ ACK/NACK│ + * └──┴─────────────┴───┴─────────────────┴────────────────┴───┴─────────┘ + * Some master controllers (such as HCI) need to prepare the entire above transaction before + * sending it out to the I3C bus. This means that a 7-bit dynamic address needs to be allocated + * before knowing the target device's UID information. + * + * However, some I3C targets may request specific addresses (called as "init_dyn_addr"), which is + * typically specified by the DT-'s assigned-address property. Lower addresses having higher IBI + * priority. If it is available, i3c_bus_get_free_addr() preferably return a free address that is + * not in the list of desired addresses (called as "init_dyn_addr"). This allows the device with + * the "init_dyn_addr" to switch to its "init_dyn_addr" when it hot-joins the I3C bus. Otherwise, + * if the "init_dyn_addr" is already in use by another I3C device, the target device will not be + * able to switch to its desired address. + * + * If the previous step fails, fallback returning one of the remaining unassigned address, + * regardless of its state in the desired list. + */ static int i3c_bus_get_free_addr(struct i3c_bus *bus, u8 start_addr) { enum i3c_addr_slot_status status; u8 addr; for (addr = start_addr; addr < I3C_MAX_ADDR; addr++) { - status = i3c_bus_get_addr_slot_status(bus, addr); + status = i3c_bus_get_addr_slot_status_mask(bus, addr, + I3C_ADDR_SLOT_EXT_STATUS_MASK); + if (status == I3C_ADDR_SLOT_FREE) + return addr; + } + + for (addr = start_addr; addr < I3C_MAX_ADDR; addr++) { + status = i3c_bus_get_addr_slot_status_mask(bus, addr, + I3C_ADDR_SLOT_STATUS_MASK); if (status == I3C_ADDR_SLOT_FREE) return addr; } @@ -1918,9 +1960,10 @@ static int i3c_master_bus_init(struct i3c_master_controller *master) goto err_rstdaa; } - i3c_bus_set_addr_slot_status(&master->bus, - i3cboardinfo->init_dyn_addr, - I3C_ADDR_SLOT_I3C_DEV); + i3c_bus_set_addr_slot_status_mask(&master->bus, + i3cboardinfo->init_dyn_addr, + I3C_ADDR_SLOT_I3C_DEV | I3C_ADDR_SLOT_EXT_DESIRED, + I3C_ADDR_SLOT_EXT_STATUS_MASK); /* * Only try to create/attach devices that have a static diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 2100547b2d8d2..6e5328c6c6afd 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -298,7 +298,8 @@ enum i3c_open_drain_speed { * @I3C_ADDR_SLOT_I2C_DEV: address is assigned to an I2C device * @I3C_ADDR_SLOT_I3C_DEV: address is assigned to an I3C device * @I3C_ADDR_SLOT_STATUS_MASK: address slot mask - * + * @I3C_ADDR_SLOT_EXT_DESIRED: the bitmask represents addresses that are preferred by some devices, + * such as the "assigned-address" property in a device tree source. * On an I3C bus, addresses are assigned dynamically, and we need to know which * addresses are free to use and which ones are already assigned. * @@ -311,9 +312,11 @@ enum i3c_addr_slot_status { I3C_ADDR_SLOT_I2C_DEV, I3C_ADDR_SLOT_I3C_DEV, I3C_ADDR_SLOT_STATUS_MASK = 3, + I3C_ADDR_SLOT_EXT_STATUS_MASK = 7, + I3C_ADDR_SLOT_EXT_DESIRED = BIT(2), }; -#define I3C_ADDR_SLOT_STATUS_BITS 2 +#define I3C_ADDR_SLOT_STATUS_BITS 4 /** * struct i3c_bus - I3C bus object From patchwork Tue Oct 8 15:18:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13826630 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 760D3CEFC21 for ; Tue, 8 Oct 2024 15:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Gt0h43Ami16S9HFQC1qfmI6Yb1Zj9E6y+zTm3TcdMkI=; b=RCx844HvCTXWlD1QotZiQDYtiF vrefqy4U/XAiUujbuYhpDO1zZ3Z+YxQO+mg+Coy5qKEDnu6RUZWHUcxDOhYxQl4E5TSce6jzJfewf I8n6zZTh0FycAAbRALVQu/wnG0m18n72hrNh2JfGzMKPUjkklPhBQajUU862N54zZeWpUJ8WPQBgz rUZL9rS57iiXJxDOPYbMC5FmBM0tsAyVlyyIb3BISiksiLyrWVdqjAE5qa5NXz8H7CKrTcDsFyXNn qFbBFuaH6+px3QwxnusvMDizNmmS/6Qj40Yztp9q2PYEwuOBv2xxw+xxk7DgFOdGRyBHvOGObHLrA ZGYzN9WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syC1O-00000006Ll2-0p1I; Tue, 08 Oct 2024 15:21:10 +0000 Received: from mail-northeuropeazlp170130004.outbound.protection.outlook.com ([2a01:111:f403:c200::4] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syBzs-00000006LNl-1VWt for linux-i3c@lists.infradead.org; Tue, 08 Oct 2024 15:19:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TqwLvup6EdrLHRJ414dPRWhGjnhrA1AkGTRUGFkWl7aKQrql83+lbSVEKcZCRibe3ML4hq4RnMphLG7e3RvLXEOC7hMjFV0i3zlJDSzeEYy1ONXBpntMoVcHpPxCKhBRSDyGIrhLGoqnx35jEwJKYL+ymH8pE4kav9tjaXlLVtg0Tqgjg9BCiR6JYZxM9LetYUuMOp8RUNONtEg5hs23/0rtsTaWntAthsL5RCrp6n28ilk595JvbO8F+njMfEO/Pn1A6H0LL6RDu9VpFOjHqu5k5g1lcF+Pskdr3TEqrjryiZfTkP8lBd7RFzKlcUlUE8CIVBPeli4oSyxDZLM6+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=seUGrhq7525Aji8QqixFCyRDtakFX5/Xp2TzxWHsoBo=; b=ZspkfjTWVEsxMGBpUOgZkJv/KhTx8NswpCAUSXPGyWKOhT5KzBE113DOwW/wDuoAXEXKJsdGMQICODBf1xWpSzSkOknB5+6uriAf6nowi8v+hwXaeJLppXcpgoMsQaTFxivUsEbK8pZf24IQG3c7KfJD83r2OfvdqYEtEwSOPZSIgdKs+50J2CTc6wAMMgvxYyDeH5AOL2T+HDq4mnMLxgGQKkD0AIBmL4w2+b8BSVT/NiaLmOiMo/8KXxmEwRiajNZA9E1j4jVa1kAxLOB6SfxYkLYgJxrzxG2t2BScRXFQApuT2pTnWvjk8hYJFlNCkzIPx24P4Vf7q/AdqPmj9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=seUGrhq7525Aji8QqixFCyRDtakFX5/Xp2TzxWHsoBo=; b=cPuEWmBSz2OzFXF2vGAicNujW/AoF467Zg4+4IAYduv6Sx6SZ9/f0MJuyf5Bk5B+TaaOtBFSdso4l2RC9K2yeKFHaJRoCqrM10dtCllgMJTolvMyZ4v1N+k2h+YvwsPveFqE+IBfvMXgdlhRL8CktbrPYhmUQaHThB7SC9m+XR522sDLa5yverifAJ4Bz60KZTRobTh7JfXXj/WO1qmEg6qHtmF5NGXqjkgzV4C2HtN8Q7TeNmmLHT5uoHxOmsZzVf3BMjtKL8WWigK52oeULGzjZFWZwfON5NCqWzIYuy+ACIhoKCHwQqLlcTtMhDB0a5QcVBF4Ojl+smj66qkiiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by GV1PR04MB9151.eurprd04.prod.outlook.com (2603:10a6:150:26::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.16; Tue, 8 Oct 2024 15:18:54 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%3]) with mapi id 15.20.8026.019; Tue, 8 Oct 2024 15:18:53 +0000 From: Frank Li Date: Tue, 08 Oct 2024 11:18:26 -0400 Subject: [PATCH v7 3/3] i3c: master: Fix dynamic address leak when 'assigned-address' is present Message-Id: <20241008-i3c_dts_assign-v7-3-96ec93d1f34c@nxp.com> References: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> In-Reply-To: <20241008-i3c_dts_assign-v7-0-96ec93d1f34c@nxp.com> To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, bbrezillon@kernel.org, boris.brezillon@collabora.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, miquel.raynal@bootlin.com, pthombar@cadence.com, ravindra.yashvant.shinde@nxp.com, Frank Li , stable@kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1728400720; l=3796; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=fYQXCdK74snyRv7MsUE/w/+rHiPoijiH/nm36eU6gIs=; b=fWsH4+cyiVF/9mzhKugs22BvUe9clSOdxCT1bXI5Bgz4y689aIN7eUb0FtFKIHI6be7lQrHO3 nuPZK+209xKCOPxfesfwwoMuXAU5Gr56ar5Dv4NqrtXME+t41GT0Rmr X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR11CA0101.namprd11.prod.outlook.com (2603:10b6:a03:f4::42) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|GV1PR04MB9151:EE_ X-MS-Office365-Filtering-Correlation-Id: 8985153a-0e14-4ddf-f2b1-08dce7ac8561 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|366016|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HfnjiFm6iMjuddy3HjvnqFPZVTYTHfl?= =?utf-8?q?8Ypv0hH11GnMscrSdoTZZNobSvmiJKey7zs15jGfecou79CFQ7ZZQ/8DirFDOPtzf?= =?utf-8?q?7LeIOM+EKQAZcl8m2ZXRVXkjBOQ4i5gODDgR+HO7OrQioTFClOaKwNEd77pAGXnGz?= =?utf-8?q?LUoexc8p5/xL1xIHNz5itUCVU4fvyOWXFX3hU/lAtOIJbtJos50piwczkOJMTO2+n?= =?utf-8?q?MEnypY1fhRB8vGKO4czk8HcQGNr4/xd1OdBrQj755C87IQZYZslrezc7+17caTAgU?= =?utf-8?q?UkDAPqh3I6TGY6l0R6I+ssw+h3KHQW9GEpXy13U7gQnJL0j+uYw/NZc+FwcPRvang?= =?utf-8?q?3pfJW8J5l4JKzlpFKzJo9wDrUnARpNfmmGB/7DNSv4lqJovEPjXY7Q+SKLDUe1fkC?= =?utf-8?q?Xm3OA5/1u9bY8t9ik5d2mFLAQun31d8W/nA7Lpfic1L70VBwrCHW0SFNAKWwYByND?= =?utf-8?q?r4jbXK75ZWCDTCn4Rcwcdox2KB+CXUP2h4jy4oj6kNcQH34Brd8y2FHb7gJ+qzUPn?= =?utf-8?q?GXaMk26AaIMzXH056xiWogHpEV9Oqkpni/a/luugiM8cTXhw4+IO002VaSnsslW6y?= =?utf-8?q?uIitRLL2YXqfJkWavZTfwthyRUGKPOO+GcQUflP65jBEvevXL7V8ImQ5Wy3tSJqDc?= =?utf-8?q?Uhcdy+k3VLKbUsHS5S/BKUdl/IdMMfaABrsjLgo1dsyK9Vsk8hW+AsP7N6twWuxp7?= =?utf-8?q?t9Tvzv5L+hoJQHnMH3+ACo1kgzXZrig9H0/95WujZQj2kutDfHwwFlHzhFfdWmOXD?= =?utf-8?q?Lm0RUlpxqa3DTDzj6/pFCJ8Nnqj3hNVHwETrYekr+75Zldn4MZ+LwwwbqeH0TcVXi?= =?utf-8?q?MtcnG43R/Q8rZxL37Nw2Hz/KKvPHGoew1+KIcVmYr1dYtyFUpIQE5CpQT0MI08LTg?= =?utf-8?q?vE1qMwHGqChK5dW8T4NfKYF8YReAT27BbWFoPH266yYXycr1RabEG7ZDctoiZkBqP?= =?utf-8?q?wfTwWWfPt+t1UJtI8fRqMeCXGz1qOeCoyfWWaabqcjWwwO4K8IICdVvLqb/b8yuDK?= =?utf-8?q?BQqWgYyuRd80kO1ogfSqhb40/cQCXol0w3q45RGRYnGHlEv+h8tjhEjSFtfdhoiyb?= =?utf-8?q?VfhihV1bOYv5wmMtO3uotAGjHomBK3p98lBztO+Y8pUKmIulnEP+7ZIojrISLfRS1?= =?utf-8?q?n+xVBPwDdoV4dKJK5yjsfGXxgOSpAcR0wUluBCSnB3lxaItcU7MBZICfw1BQtn4nK?= =?utf-8?q?gDUBck4BRetbO+l13A2+XBQZRNdAuPcd2w7ZG2EC9m5sjTa0mjhS1hCWWYCxSkM5i?= =?utf-8?q?4vsi6AKQxvBloV8ioKt4L5333GcCisHKuEg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(366016)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?k1Gg/FCDF9rgbz3XDzQCSSD6JjRx?= =?utf-8?q?n4l5ewNQ60yqrGfNGeBKO9o3wDE2H+kfAX1p4oOzlSELjQrtQC0gRiuXSBRfcdDVi?= =?utf-8?q?4tBjOCiBcWUZSy7K19TlQt4Ywp9LvksPcro+kjgYMsMoL+haS5mtim6b7RrTJFwBM?= =?utf-8?q?500kbOm3LcgL/Vxr10p4NfLqpwogWnqM4HnjoznaODm+uCZvl+voLnvDrimDWMzA9?= =?utf-8?q?lG3N0psJu7pgsXIyFcZs9oPUatMXx7jVEIlI5hy/pykwHTsrKY1Ltv8HANYdMglQX?= =?utf-8?q?MwfzLkNON9hUTzwuR/bXMUR58cIw9HF3ZuadfRk3q7wySAJAFiZZ9/vrUuPwWOLkR?= =?utf-8?q?dsl+uirievbwrP+xiX0a/x3ukjtu3PmN5sPRUWRGwmnDzLi/eqoZSsje7ZJjPtuDz?= =?utf-8?q?Ggxdhjt7I4SjfyevDWuXs1lNPs9pXvO8QenlzASJzzpLBk+alrZKak5G/H3S1BExr?= =?utf-8?q?+XeZV2T6UBaRVlo4SSrqP2+6rpn4wl4KyMpRdMTVLDhQ8f/Mw+yzl1r/5H0m8S2sD?= =?utf-8?q?/W+kaCpkocsAeciTkCKWEtVVJHB4Fe6TCYdMNMiObtVzle1xa5DorgeUkC2Nlrdat?= =?utf-8?q?7BmHA+wjZgAXOCYuQs2mAP3LIM+n+97ruLl0aN4pvqTGJrzt8u15NDnarvpjyO+wf?= =?utf-8?q?vurVF8Q2ppjZESaMXESAhNw8/gxFXAuyVjhiBREq0neACrAnW7SgfsBCrZUO5tsY5?= =?utf-8?q?jRm66dRCWrbKSsHYfic4keb3i0or3LN6fYAw7gDi8t7j6jfkUxt3moxSYo4l3Kbqw?= =?utf-8?q?/fhQI0RsACPnGce4be3Z6NaSgIcmVgDBW3cJnGStkfrPhLk/DUtonn3GI1bxot4hi?= =?utf-8?q?C9vcFp3GiaGI/cZv0n8QN81WuNfbuor9ZkebaEWzmB6pq4l5U8EK05RQRgn9OPtiJ?= =?utf-8?q?if9Euf9Kgw4WQwG7at1fWzCfTSoa8p5wmXMkE08Gmf3nlYj9MllvHqlLrvD0QXmH5?= =?utf-8?q?XJgHZqghXaqfyxk5HEW4A6F+wzX95h7GVC43PNrJxx3+W2UkCNwumHnev93oNoB5+?= =?utf-8?q?We12WAsA7lYFARVCH3cA+GcPxGUweKvBhWq/NTdqOoGuPXArGTmlyReHK6O2tCyxK?= =?utf-8?q?eZ6lAvMvxpx/RBUH8e0L30Oa5K+wpBNsD0CIZkI9x8rshbtnHz+aqrgoj2wdHGB/Z?= =?utf-8?q?wEK/GC69D2vuDbfdE820/V8xn2WzcrLjaBwstZ/2zxD++8b5KZIoeXqtKEs9NB4Ft?= =?utf-8?q?/j5GOHwJdRLCm+gnbBxsbkdKGHOFctApCIa6T8OrrgSWKv9AcDKLgUWNo3c8ii+aL?= =?utf-8?q?nGiyUB8RD4UXioIgDmH+Li4T+ONt9LjzjNj+S8q0qPE1r6QVntKh19yz3TcPUDQWx?= =?utf-8?q?N6IPw3OPyqkC6DalrnrGX+l0/qjGtfUzm6oJP5hF9pAmZDDpyjnMJ8Oo5EGkFzJL3?= =?utf-8?q?vCc/MkP/jM/ocMaWv5ZW3yEliDu8P52YezV2pj40BjAXRm77TzQKRcW6MuLHOC2vz?= =?utf-8?q?O672v8ekqOPTMl1P/IpiktU10m/ZZ5l/07GrRBOUmNPsuADGKxiKdOig=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8985153a-0e14-4ddf-f2b1-08dce7ac8561 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 15:18:53.9025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2373gy8CNq5op3mKurhu64q+HZIqSF9+0gg/9Kjlit+VnXWEvhSbzjWCw4tLQxl9DhytBQXWc7dikFF8SaBxUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9151 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_081936_443194_B46FEC3E X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org If the DTS contains 'assigned-address', a dynamic address leak occurs during hotjoin events. Assume a device have assigned-address 0xb. - Device issue Hotjoin - Call i3c_master_do_daa() - Call driver xxx_do_daa() - Call i3c_master_get_free_addr() to get dynamic address 0x9 - i3c_master_add_i3c_dev_locked(0x9) - expected_dyn_addr = newdev->boardinfo->init_dyn_addr (0xb); - i3c_master_reattach_i3c_dev(newdev(0xb), old_dyn_addr(0x9)); - if (dev->info.dyn_addr != old_dyn_addr && ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0xb != 0x9 -> TRUE (!dev->boardinfo || ^^^^^^^^^^^^^^^ -> FALSE dev->info.dyn_addr != dev->boardinfo->init_dyn_addr)) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0xb != 0xb -> FALSE ... i3c_bus_set_addr_slot_status(&master->bus, old_dyn_addr, I3C_ADDR_SLOT_FREE); ^^^ This will be skipped. So old_dyn_addr never free } - i3c_master_get_free_addr() will return increased sequence number. Remove dev->info.dyn_addr != dev->boardinfo->init_dyn_addr condition check. dev->info.dyn_addr should be checked before calling this function because i3c_master_setnewda_locked() has already been called and the target device has already accepted dyn_addr. It is too late to check if dyn_addr is free in i3c_master_reattach_i3c_dev(). Add check to ensure expected_dyn_addr is free before i3c_master_setnewda_locked(). Fixes: cc3a392d69b6 ("i3c: master: fix for SETDASA and DAA process") Cc: stable@kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- Chagne v6 to v7 - none Chagne v5 to v6 - fixed version number to v5 - fix merge conflict because change function name and macro name. Change v3 to v4 - none --- drivers/i3c/master.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index e0962a17de7f0..9ccfabf849c42 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1548,16 +1548,9 @@ static int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 old_dyn_addr) { struct i3c_master_controller *master = i3c_dev_get_master(dev); - enum i3c_addr_slot_status status; int ret; - if (dev->info.dyn_addr != old_dyn_addr && - (!dev->boardinfo || - dev->info.dyn_addr != dev->boardinfo->init_dyn_addr)) { - status = i3c_bus_get_addr_slot_status(&master->bus, - dev->info.dyn_addr); - if (status != I3C_ADDR_SLOT_FREE) - return -EBUSY; + if (dev->info.dyn_addr != old_dyn_addr) { i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, I3C_ADDR_SLOT_I3C_DEV); @@ -1960,9 +1953,10 @@ static int i3c_master_bus_init(struct i3c_master_controller *master) goto err_rstdaa; } + /* Not mark as occupied until real device exist in bus */ i3c_bus_set_addr_slot_status_mask(&master->bus, i3cboardinfo->init_dyn_addr, - I3C_ADDR_SLOT_I3C_DEV | I3C_ADDR_SLOT_EXT_DESIRED, + I3C_ADDR_SLOT_EXT_DESIRED, I3C_ADDR_SLOT_EXT_STATUS_MASK); /* @@ -2126,7 +2120,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master, else expected_dyn_addr = newdev->info.dyn_addr; - if (newdev->info.dyn_addr != expected_dyn_addr) { + if (newdev->info.dyn_addr != expected_dyn_addr && + i3c_bus_get_addr_slot_status(&master->bus, expected_dyn_addr) == I3C_ADDR_SLOT_FREE) { /* * Try to apply the expected dynamic address. If it fails, keep * the address assigned by the master.