From patchwork Tue Oct 8 20:39:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 216EBCEF17E for ; Tue, 8 Oct 2024 20:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=277QVKUgBZx9Kqmh10Kpiu8kjEqYEgwLRvpKlI61ue8=; b=JBUxCHqCL/sPqw5RuqAEGAPf/s CAS3X/d3XIogWM/7WGl+Vby3nAQC2SOPzphjPM3cFf9dJeo0PwDop1h1BMfH3vsPH4BLFOUbX2PYA dmzgtf5+nC1ZBYCnIXw91whMFRkE418GFWQB1g/6Gkw27igyhrdjqlh940luudfu7Ood+UmanOweU 6vXolXfDMM56jvawYDbfaLjeYfoW6sI3+mBdf86KeYze7mqAP/OwZ4I8E7tFqb7e6r+uG/SX4Qg3y qxSfogb7BvfHYupUnr05gYhgDuUianq4EyW7rzN+Rp/TVVnyQ3CuP84/TYkRgPWiAXT0j/Ib/hYqA SWrKRSfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH2T-000000075eh-1gIX; Tue, 08 Oct 2024 20:42:37 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syGzr-0000000759G-0r2r; Tue, 08 Oct 2024 20:39:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=277QVKUgBZx9Kqmh10Kpiu8kjEqYEgwLRvpKlI61ue8=; b=o7h9IlgjVc1SIzTNCKVOgehWbk xYBuL9RXaDHs+VW9PS7Hvn9QW/UIePNVYtyJIvrn8PT67J0IL1miaGCaoWdgfN6TkcStuFP40KVxV 3lQg5oTlOGxeG/Ekm7kLUnE5m4NbBL8w6y74XTdbiVMxZF5h321DE2kIEiZ+AmtFmMVVxZ6rbVP2+ 8YVDf3qgN38u6F+DL+JGrlSMX/MPcNWxzhdv2EGqr/+VJ/kO0WynBGIkULRnlzo6Rw4+694OuGdBf ipN8G4hNG/tjsjcds4ZFo0Q4pTBBr1KMSRmBv/3fTBEAq4jQn6sHgjJPjI9fbzYhl7YVzq41v6dPf yi9joteg==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzp-0007ua-TI; Tue, 08 Oct 2024 22:39:53 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Chris Morgan Subject: [PATCH v2 01/14] arm64: dts: rockchip: fix i2c2 pinctrl-names property on anbernic-rg353p/v Date: Tue, 8 Oct 2024 22:39:27 +0200 Message-ID: <20241008203940.2573684-2-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_133955_268184_F167F749 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We want to control pins, not beer mugs, so rename pintctrl-names to the expected inctrl-names. This was not affecting functionality, because the i2c2 controller already had a set of pinctrl properties. Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503") Fixes: 1e141cf12726 ("arm64: dts: rockchip: add Anbernic RG353V and RG353VS") Cc: Chris Morgan Signed-off-by: Heiko Stuebner Acked-by: Chris Morgan Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts index a73cf30801ec..9816a4ed4599 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts @@ -92,7 +92,7 @@ button-r2 { }; &i2c2 { - pintctrl-names = "default"; + pinctrl-names = "default"; pinctrl-0 = <&i2c2m1_xfer>; status = "okay"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts index e9954a33e8cd..a79a5614bcc8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts @@ -79,7 +79,7 @@ button-r2 { }; &i2c2 { - pintctrl-names = "default"; + pinctrl-names = "default"; pinctrl-0 = <&i2c2m1_xfer>; status = "okay"; From patchwork Tue Oct 8 20:39:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA68FCEF17E for ; Tue, 8 Oct 2024 20:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MkCaKskrO/nF9QQnRoBZ2O5aN148arkIhAAPWOoj440=; b=0cFXp61U1KHeYfGdIbW0cYplSh Bd6eVO+YTVYYO/ZdEPhpKb24DIDJHTheHkzfSPSZtyMk5wsZdfRb+43IJnqtTdvKE3ewYzoPoLla9 dl/Kv2zR4NuW4d/8YLGulneoDoimgnhP3THMsK83U4c+pK2xDUUIGpmY4QyVUeUWF/JSzTC4Br6W4 nK5XdcuWoJtxxM/0ZPPpnZN5xxFD/LpVpc1hW5YH1EFa5TzhiHPCvcNsViXJ9ej/Jon03mY60cuJL buqW2+hAeBsF54f3OnVChd4LGgOGfdzINFz5oOcD5dUM/iFD1Seqg0OAnvpLC6VDScTOTLvhWPCSE JOxhtKrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH3k-000000075tN-1Uqp; Tue, 08 Oct 2024 20:43:56 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syGzs-000000075AO-2GMD; Tue, 08 Oct 2024 20:39:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MkCaKskrO/nF9QQnRoBZ2O5aN148arkIhAAPWOoj440=; b=1svss9TRSdDFMG59J/YDEISSGa DOGQzSUOW37901EZPDKCM/9xQFAX5VPyIMy6vaI4LXnXWnghjEOhf1hL2L1vtgRLWimAGucn7uuUE 6E7BQdgDGlA9I4Hi5kD0PF7zyM6ztcceO31pxSFfi0ab/yUFMyReIDcYXojRI/ljzDR1nIxREMoTf ebWrnrPpu5EGL4mPsZEpDNeVaAR2IpWPEXsTUokPVPJfzvcoi8Hhl220yS/vzep/hkQEriz8RK8zT Q9N4AJL2cfu3atZDdiVuIqZEyHBu/9tcdsjRO3UAcdl6SiWfH/tF223VN3VJ+etExe81tI/YJpPVV lssjVf3A==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzq-0007ua-7Q; Tue, 08 Oct 2024 22:39:54 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Furkan Kardame , Elon Zhang Subject: [PATCH v2 02/14] arm64: dts: rockchip: Drop regulator-init-microvolt from two boards Date: Tue, 8 Oct 2024 22:39:28 +0200 Message-ID: <20241008203940.2573684-3-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_133956_602986_8FB756F2 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org rk3568-roc-pc and rk3588-toybrick-x0 re-introduced this property despite previous patches removing older instances already. regulator-init-microvolt is not part of any regulator binding and is only used in the Rockchip vendor kernel. So drop it. It is used by u-boot in some places to setup initial regulator-state, but that should happen in the existing -u-boot devicetree additions. Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc") Cc: Furkan Kardame Fixes: 8ffe365f8dc7 ("arm64: dts: rockchip: Add devicetree support for TB-RK3588X board") Cc: Elon Zhang Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts | 1 - 2 files changed, 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts index e333449ead04..2fa89a0eeafc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts @@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -285,7 +284,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -309,7 +307,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts index d0021524e7f9..328dcb894ccb 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts @@ -428,7 +428,6 @@ vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 { regulator-boot-on; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; - regulator-init-microvolt = <750000>; regulator-ramp-delay = <12500>; regulator-state-mem { From patchwork Tue Oct 8 20:39:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C712CF0421 for ; Tue, 8 Oct 2024 20:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k/5sNKevC+o9Lp1ItqUhRy3pPTMdn3RRBndu2fGnT5c=; b=EuUSrxKUasnxau3rc93fDtQ8GL B0mdG6npw8j+rlCMrtsSNocXNRRBMX80Wxub0ePwLR/Ms55KP7+K/8AZNhwSSQhzYLU0CGlhmwnB/ eBMAnPTogmwnGhna452G/TxwrzUkA7FV8FPhTTX+QEmhOohWIi25yhrgxeKYRuEjXn/V8lrB7N34O 5og8hxi1RwW4bAsKofcHXj6r5G7p0MOVsGTtzuaxvpzM25Vc0N8mDlvnM0DwQJD9G/Uhf8iOZMbvC Lj6oGzJcjyt0XwFE5MTc13T31yEOOFDEfF2DEpgK2YKMllo2LAMFnt90KS5um541udYcyklLBS3PH u9aKliXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH7X-000000076Gx-1un1; Tue, 08 Oct 2024 20:47:51 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0E-000000075I2-3SV1; Tue, 08 Oct 2024 20:40:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=k/5sNKevC+o9Lp1ItqUhRy3pPTMdn3RRBndu2fGnT5c=; b=iuwlSqvR36x7nwhum8+pM28/BS 9ukE513xiryH26afSTnx9Ezf6pqryQE2TESEBFTkfPsb7Boh0+K/Zu23h7LGurxB1gRDtgIx2s5Xj EnARFY9IUPjlJdByE9iiGW956unbtqbdqzuPwVaZFUr91IKUFmuQy3V+gp7ZkBej+Lv7h2hznFGpv KVgttV3y181J6g445OTS/Gsq4VNPNv3fLohfid0UFuowCGWRe8zVSftJSCDT6sV1xKQj4phm41nCM VTdmnoNW/NGH6rBFKcbK4Krr4u0OafZZMnWHQQCko9ILaPZIzCfifk4AQav8aH+gmBHEkqReqCMN1 VoWurD5w==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH06-00000004gel-3Lil; Tue, 08 Oct 2024 20:40:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k/5sNKevC+o9Lp1ItqUhRy3pPTMdn3RRBndu2fGnT5c=; b=0Jly2FwYX3Ck1HU3A++7h39T1n Qx/WO/nnoMpEc3Fm1fSa0+iLFTiPwN9eSbT7krtfJIF0lYkqZFH1KlP16gMN/fc+VX57Z71Pay3kC pj98cjFwi0tU8ZUTSV9YQ9DUwtyq9QI4GvqhO76L8ZCMULQrxx9LNvOVoa8gDJH1RaFoKiWoxpPAv i/xCQ8t8TrBZW8rbAXe46BWsqw3AILnpzjetD4V0Dd8IuV9W9C67d8MoJn1X0OpmlgSAGOmwz07dq mGs00UADlqGgt3tH/ff/Os2ge7KCnO9sjy6KgjPTgyYnq8t7lUFo0fOOU1vIT2FRodNloQHOYcaQu QOjShNyg==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzw-0007ua-Rh; Tue, 08 Oct 2024 22:40:00 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Andy Yan Subject: [PATCH v2 03/14] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo Date: Tue, 8 Oct 2024 22:39:29 +0200 Message-ID: <20241008203940.2573684-4-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_214015_021555_1178FAD6 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The expected clock-name is different, and extclk also is deprecated in favor of txco for clocks that are not crystals. The wakeup gpio properties are named differently too, when changing from vendor-tree to mainline. So fix those to match the binding. Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board") Cc: Andy Yan Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 0c18406e4c59..7d4680933823 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -449,9 +449,9 @@ &uart1 { bluetooth { compatible = "brcm,bcm43438-bt"; clocks = <&pmucru CLK_RTC_32K>; - clock-names = "ext_clock"; - device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; - host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; + clock-names = "txco"; + device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; + host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>; From patchwork Tue Oct 8 20:39:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB20BCEF17E for ; Tue, 8 Oct 2024 20:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LNyTDXAOfDtfweQQ1cZdwJvM/wUwnqE+NuSrFe9SWt8=; b=SnbZ6MWmcJAcoJy4WnoAcdUXtL QFdcyIELdQ972ykBoUupaeUtO0OxC/4OwdvzZ0Ed8/SaNezU5EN9UjQ+7zLoEY4BrVruW7Pf1ES7k +T3dS50r+8TnrcwR6X2eGK9G5I7ep19HHZ6DMLY2mjGOUDNnsNCE4BmXX73yhLsLQQRWT6gVALJnX pgeWXi4vs9Ay8s8uUejZaaKhm2avjmGhdLnuH1tgleLtSmlgXQ8QsjAWmbu7JN/ogaPNPYCGKBoD0 8dMh0bPIMmF6kiI5o6V2SlsgsKTrI0usZrImop097Ad/aevBTq9OmHsmxZogeE02RVbidwPu/JZlD 3mB3hCzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH50-0000000761y-0ten; Tue, 08 Oct 2024 20:45:14 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syGzy-000000075Cg-2Oxp; Tue, 08 Oct 2024 20:40:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LNyTDXAOfDtfweQQ1cZdwJvM/wUwnqE+NuSrFe9SWt8=; b=VfbiDGfHVRvxIAbCjkJLJjZMue HyvmLash0GJ39tj9tTWqgw/FXzkHscbAcUm6nSzgHamVVLOtA5wiZrcmoKg8mPseMyQWTBIktWsaZ cvQZfTe/W8RVcaMzhHLGKIiZLxhclR1Jp9MuXFF3PPGZh74NMfhQzjQk6HLhv36fZxWtvjGnW22o7 mnzPid57rh63V6YyatuljFzwe8hvPu7QWgQg7DLstP/VuwRo2+mBaG7Vx+jffhlo3BmNWARh7ttxj rrezg5TsCgJfl8Vt1wk+XikvPooRcT7ESyHw7UtRqi59TMf2Ej+ih+lJ0ngXGuwcX/lLvlYEgA+Dn tZ8lzasg==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzx-0007ua-5P; Tue, 08 Oct 2024 22:40:01 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v2 04/14] arm64: dts: rockchip: Fix bluetooth properties on Rock960 boards Date: Tue, 8 Oct 2024 22:39:30 +0200 Message-ID: <20241008203940.2573684-5-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134002_639568_D3F9ECC4 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The expected clock-name is different, and extclk also is deprecated in favor of txco for clocks that are not crystals. So fix it to match the binding. Fixes: c72235c288c8 ("arm64: dts: rockchip: Add on-board WiFi/BT support for Rock960 boards") Cc: Manivannan Sadhasivam Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index 8146f870d2bd..ab890e7b6c59 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi @@ -576,7 +576,7 @@ &uart0 { bluetooth { compatible = "brcm,bcm43438-bt"; clocks = <&rk808 1>; - clock-names = "ext_clock"; + clock-names = "txco"; device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>; host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>; shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>; From patchwork Tue Oct 8 20:39:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B430CCF0422 for ; Tue, 8 Oct 2024 20:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fMY3Hx2YxzWWEFZLZHGJcI0fZev4CYGwKOUcWpqRbzI=; b=h5NBVAG8PGO4xjlYlZvqeJFRZD hZQs+U1DzWtzgiQ6lgk/TX4N7MPDIDxbQcMpn/L0VXHJ0TLsJG5FB6hcfluZQlrbVmMm9F1yMC90i FqrDfWtI3XoVJbWW1Y0k1lNtfbLumTN5uYyUCy67lWgNjUGx47WDdk4FjJvxQZBJRoPS7si2MFztH VzNFeaSBVuyl77LAKZcDsRXIM6kqvhs6nkD5yPDS63rEt005+ukVt6D4chbcd4tFp2faGQs2Ftu+u sBTv9oheT/jJ+G/EIcosXFTibnkHR2+x+qH5vdO2yL0Ble6Tu5DUZHu90oK/HXgBBnsa/5isxlBGh 3CuslITg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHBM-000000076jz-3pIS; Tue, 08 Oct 2024 20:51:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0H-000000075IZ-0GRT; Tue, 08 Oct 2024 20:40:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=fMY3Hx2YxzWWEFZLZHGJcI0fZev4CYGwKOUcWpqRbzI=; b=X9Ib9pCri1RVikiNl2SRQO3Bnj hHnRmUsFUQI6VMwtC7ySowyda6EeH2GXeSib5CPJpF9dq/fXje/1As8KIOQK3xe72y6Fkg39/GA0j RCfjpaWiyWUkLtgXek4VhPj2c8Sj9IrMrOlEwiGfym7foPzUkdFjMYgBi5CzwjBTlKmGzxGIxlgR2 Wl1CAVFx9TCPxD/ns38Vb6eIFqD0OxuFLkoQEcC6ph+emtqlLRST/1OqlvDL//fbK+p9MhujHFOVW 7iKu/PsSE+kucos3DOJ+woLknl+bKICG6xvJvuCiKfgQdCHZAuP3JHWrhLRsUROYhburfbWhM9BFb X1p8cYQQ==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH06-00000004gen-3LrC; Tue, 08 Oct 2024 20:40:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fMY3Hx2YxzWWEFZLZHGJcI0fZev4CYGwKOUcWpqRbzI=; b=gr5OUt9OETpicas45k1+5dGprA K6+y+lKFC/aShZr7VJC+ty2lnMUW+vVKmm+JQMb7qq5H5ReWLAebTp3iOdmxz2LWYwi6BJKQi3u/t wB8QrfUcmI4eOHgBS3vlb6CGPt1QrGHNM+V2ABkW+SERNz9DwTaZrnvGpu1e0tkJ0MrQAB2ffCcjf lWhjcSfjLmMs9GnjihLLxmwNg17tuGmEuLV7rDjL3gW7M4pAtnS1UuUQUrqKbsvJFSTIJ0g7Yrf4o xSXO3BBY4kpjlSbAgIQRq2V6ZD1g501bCwVcPcBsDP5hTpDRqqUlXCB3dv0RAYNovsoFxOLVLTFNa BIHKTD1g==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzx-0007ua-Hi; Tue, 08 Oct 2024 22:40:01 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Quentin Schulz , Sergey Bostandzhyan , Wenhao Cui , Andy Yan Subject: [PATCH v2 05/14] arm64: dts: rockchip: Remove undocumented supports-emmc property Date: Tue, 8 Oct 2024 22:39:31 +0200 Message-ID: <20241008203940.2573684-6-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_214015_064859_2334423C X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org supports-emmc is an undocumented property that slipped into the mainline kernel devicetree for some boards. Drop it. Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard") Cc: Quentin Schulz Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM NanoPi R2S Plus") Cc: Sergey Bostandzhyan Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1") Cc: Wenhao Cui Fixes: cdf46cdbabfc ("arm64: dts: rockchip: Add dts for EmbedFire rk3568 LubanCat 2") Cc: Andy Yan Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 - arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 - arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts | 1 - 4 files changed, 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi index bb1aea82e666..b7163ed74232 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi @@ -66,7 +66,6 @@ &emmc { bus-width = <8>; cap-mmc-highspeed; mmc-hs200-1_8v; - supports-emmc; mmc-pwrseq = <&emmc_pwrseq>; non-removable; vmmc-supply = <&vcc_3v3>; diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts index cb81ba3f23ff..3093f607f282 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts @@ -27,6 +27,5 @@ &emmc { num-slots = <1>; pinctrl-names = "default"; pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>; - supports-emmc; status = "okay"; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts index c1194d1e438d..9a2f59a351de 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts @@ -507,7 +507,6 @@ &sdhci { non-removable; pinctrl-names = "default"; pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>; - supports-emmc; status = "okay"; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts index a3112d5df200..b505a4537ee8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts @@ -589,7 +589,6 @@ &sdhci { non-removable; pinctrl-names = "default"; pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>; - supports-emmc; status = "okay"; }; From patchwork Tue Oct 8 20:39:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B958CEFC56 for ; Tue, 8 Oct 2024 20:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Yf04+QXT03J/TjvEQgDGnbMwpR73yd5cNPeoOtdIFnk=; b=PwayT1QZNAWZv5TpjZdNHZLOPS wulJWGwYEeJsq/gfKuDcxluIYMq1o8dZklLnJqIrsACdkAruzqtifOMx9CHX082Crz7nd1yBpAe9C 812Ua5Epu8TitizcJW9nBts9wQcyfgRRj5lhd6wB0IQI7KClCxwJ7ym3NpRbHPDjsBKX9/fgdVKJs rME/7yI8VA4Ww6uKpwp2KohDzKrHyaSxlQY0Mdi15FjEULHSR4NENWZnlogxFi37suSBSvrfNjKuj YjF0V8IPqT3dQ3Ika++QUvmSuAOZH7bkfuviH9Hie9x+DOJ8uZlEOLUkVBobOd9RmPTvkxmPe4mUy J1BMrdGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH6G-000000076AV-397x; Tue, 08 Oct 2024 20:46:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syGzz-000000075Cv-1m0J; Tue, 08 Oct 2024 20:40:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yf04+QXT03J/TjvEQgDGnbMwpR73yd5cNPeoOtdIFnk=; b=gx5ShjBNYIrZSk4OMsyqJE52fQ q/5S+Z/47L4AfMrv4gQePKJrCmjdLlyA2T/4Aa23YZxjFLYY81yOlWLvnUIL4h0AWR2iZE7QNum7X iikekfZtptftfTv4Cr0TuwKO0+uOJWv9PIYWYzalHaIMuIvFFJW8Uf5wqANODACIUxhFkUpsRNfXe t7/LSZtkfHkKTM9Z6MSCMtfDEQTRpA+YK1sEppjpUKTdwHvihfi9mGyvXyKPTCxVAsRdSZcajtmuM KbgJKzlhIJP74te5EVl3clRhSEbeyDPegeavLzsL1bjOTC+oWP5RPJz07TXTMISlJqarpiLGOwfyz /FweGeFg==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzx-0007ua-TZ; Tue, 08 Oct 2024 22:40:01 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Quentin Schulz , Klaus Goger , Quentin Schulz Subject: [PATCH v2 06/14] arm64: dts: rockchip: Remove #cooling-cells from fan on Theobroma boards Date: Tue, 8 Oct 2024 22:39:32 +0200 Message-ID: <20241008203940.2573684-7-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134003_511107_6DD0EFD3 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org All Theobroma boards use a ti,amc6821 as fan controller. It normally runs in an automatically controlled way and while it may be possible to use it as part of a dt-based thermal management, this is not yet specified in the binding, nor implemented in any kernel. Newer boards already don't contain that #cooling-cells property, but older ones do. So remove them for now, they can be re-added if thermal integration gets implemented in the future. Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard") Fixes: d99a02bcfa81 ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM") Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Cc: Quentin Schulz Cc: Klaus Goger Signed-off-by: Heiko Stuebner Reviewed-by: Quentin Schulz Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 1 - 3 files changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi index b7163ed74232..a6ea9d8c785c 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi @@ -293,7 +293,6 @@ &i2c1 { fan: fan@18 { compatible = "ti,amc6821"; reg = <0x18>; - #cooling-cells = <2>; }; rtc_twi: rtc@6f { diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi index 8ac8acf4082d..ab3fda69a1fb 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi @@ -61,7 +61,6 @@ i2c_lvds_blc: i2c@0 { fan: fan@18 { compatible = "ti,amc6821"; reg = <0x18>; - #cooling-cells = <2>; }; rtc_twi: rtc@6f { diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi index 650b1ba9c192..6de3128556b7 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi @@ -395,7 +395,6 @@ &i2c7 { fan: fan@18 { compatible = "ti,amc6821"; reg = <0x18>; - #cooling-cells = <2>; }; rtc_twi: rtc@6f { From patchwork Tue Oct 8 20:39:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826924 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C8B0CF0425 for ; Tue, 8 Oct 2024 20:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kbHRuisZyrs8FwUsSu90NxL13w/ixqtP/x+s/iP2Gds=; b=Q7H9wjIv8zNIPcH3m/jOkS2swn WIzfNs8j6sJeJPC3/NdyQCNAWDblxwC44G4oXC63jBeUk1iOa1f0NQuuOK+mf9jPYNhhIuzHHISXN y/4Pzj3tWgKi5NoJPHHPBmtbOtOPI0qXf2CFErHarQ5tHyyUL2ALeX4KO4hK064xlzoywDKcuJzwV gE3h2E6OK/2PotFywX8yvG0yp9oBTP1qWZduadEBe4JTPnoW52iQJYPsjvvxQV4a86ZWQ549FE4LB dVxM5/9tTYlsjenYPQiXAARD5lLGJP+r0B3vkJu++UxeXFZuFBeGjU0hcMVw8Z2p5mHPbQikbv5wW qS3BvdjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHCe-000000076tI-1x1H; Tue, 08 Oct 2024 20:53:08 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0O-000000075Jj-0qi9; Tue, 08 Oct 2024 20:40:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=kbHRuisZyrs8FwUsSu90NxL13w/ixqtP/x+s/iP2Gds=; b=V3AG0I/oRGdy4wiZdq6TlcbXnO c4sLFN/0z61kWE9/W0Gg8XBHnMfxo/uej7jmpYJtXnq07T+qKGvK5go3AyubDO0/e2GXZTM58ZaQT 9NqH7DB3bGDOKDcWe3qHTITQt8g3PuE4UFRfPaucdaym0iZMRMwmpqaYTymnPIvLfnesYKpdZdAly OPvi+masElahz4+MKpkm/srQxxYpVDOH9wKM1j6fGqJ+g595wGUz0FIsFjYzIcaLIZIc52OCL5tmU MzP8kNNa2CdCbvGnUw9kK19dmTKNNgNU13JLgKeedeQjVtEgsd3SgMyaja/JOF5fTnAwmx3+e58Bz V3ROAfFQ==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH06-00000004gem-3Lpk; Tue, 08 Oct 2024 20:40:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kbHRuisZyrs8FwUsSu90NxL13w/ixqtP/x+s/iP2Gds=; b=HO2z7P7te2LlOPQDTUNm2sOiS0 ohQxYqIRHUnzUDJUa7BLcVLMMhdthbTmn4w2QybkyGoFLkMese5KxQnPr/Iz7W+TuV2iLfHe1PNYY i+CsEEIngdYImpIwK8sAd4oVNzWilrGA9NHU9BRoUWCzSOQMp4RdbAk/vPorj8M4yUYUrwZH41eYw nFhIoslajt/4G0i/qmbidLy59uNpM7ShZ+0cC5F53Y7iM3OcEZnyCQ+YO1IyEQXnIJ/peEcjgaUrv v7lX0SD6bOosGXtPkmpg8C/fAzMfYwUAj1cMGrbYQI1FAfLbFVTCxPM3ahNc8zWAJhPmadiD8lr8d XOmjVxQw==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzy-0007ua-6k; Tue, 08 Oct 2024 22:40:02 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Andy Yan Subject: [PATCH v2 07/14] arm64: dts: rockchip: Fix LED triggers on rk3308-roc-cc Date: Tue, 8 Oct 2024 22:39:33 +0200 Message-ID: <20241008203940.2573684-8-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_214015_165362_21F5CAEB X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are two LEDs on the board, power and user events. Currently both are assigned undocumented IR(-remote) triggers that are probably only part of the vendor-kernel. To make dtbs check happier, assign the power-led to a generic default-on trigger and the user led to the documented rc-feedback trigger that should mostly match its current usage. Fixes: 4403e1237be3 ("arm64: dts: rockchip: Add devicetree for board roc-rk3308-cc") Cc: Andy Yan Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts index 9232357f4fec..d9e191ad1d77 100644 --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts @@ -36,14 +36,14 @@ leds { power_led: led-0 { label = "firefly:red:power"; - linux,default-trigger = "ir-power-click"; + linux,default-trigger = "default-on"; default-state = "on"; gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; }; user_led: led-1 { label = "firefly:blue:user"; - linux,default-trigger = "ir-user-click"; + linux,default-trigger = "rc-feedback"; default-state = "off"; gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_HIGH>; }; From patchwork Tue Oct 8 20:39:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826922 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E52D7CF0421 for ; Tue, 8 Oct 2024 20:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a8vwVyS29rOLWb4fTtAHqldYQww/UW84ULndF4f+v14=; b=4LDb26/WqQCT10jzDGJQLU+5Pt TYd4rKwugtJQwZ+WJhAm2HrnneJ1l450nmotqMhYKUW5laN3T7zmlT9EHjmIcvl3elw5hM6AfF3Qe IRYiTI01CcHLYgiatjTyxoH0N9ihs1x+objJsxQEwoAGqSSkywBUbX0XwpD7FpgublCQplbxcEhBp pgeRnnciv/PoPu5NCki9woetn5cjVS49sSnAjpAa11lEiwG0DhGpYgeptYvHqG7b6Vb+WLLARjVS4 ZNFwFyBEhw3N3HGc3WU7HwTGRPhddEla1DD1XwAmhq4tC+1NWA20Z09vEOEr/jy1kSFl2a6y/9LrO eLJnmnqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHA5-000000076Y9-31RM; Tue, 08 Oct 2024 20:50:29 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0G-000000075IW-1JnC; Tue, 08 Oct 2024 20:40:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=a8vwVyS29rOLWb4fTtAHqldYQww/UW84ULndF4f+v14=; b=GZsUGU49LeV3TzcJF9i3z9CzHt P97xFVzm6yG9aLOqtsgaK8LDNGjUDmSwVVPK77Fx/YnPHeIsFY5BFHuiidKMVDmqN2UVrei+zboxl n8K+CON0/4Ku/NRW344LFtXsmhv+6LpTGJfDw9n+feAeXrqqwMmH5SD9E8D4ZA7PpUC8nQuOSvKrn BltjPV0iIIfxcO0df/1l0nKUFI/nctske7SIbmL/5OTIofts8WWzQoDFEUdguxdclbiMhCTzcATHs ec3pbzukRAq6I6d8ZTcgu0RyFyOGq2bdGAumWnPTNW0r6mvLlnuOW6JrRh0mnH7+eHsEeRN6x7Znh 7kZEX11g==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH06-00000004geo-3LyC; Tue, 08 Oct 2024 20:40:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a8vwVyS29rOLWb4fTtAHqldYQww/UW84ULndF4f+v14=; b=dmAdLIz2XoO9eTTfpODgOR3J9I LUwukipOXckhy0cbfKUF7OkXYm51EZap+kxUx5we10CXlFrWU/7h8KvqQDZoWT9TUGtocA2t/St+p yJb4QTfxMmucSoZhfNI3L4DQFFkjNHakPECIirua6+QS2EmIcn8U4Q95xTu8E1aOwhJwvTThdHEdn W8UzHlXHLio5/3VhdprthvYrXPZVMdIJD8F0y8yvDajh02C2qykevskc0GRLa24ellBjScvu3Z/zI gP7v00pt275dInHrMorPd3xiIFBYcrj5lFt2ZFQeA3iwgdCdhvu6i9ldhX0CQYcYYvAR70qmsou8i ronxEveQ==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzy-0007ua-GD; Tue, 08 Oct 2024 22:40:02 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Sergey Bostandzhyan Subject: [PATCH v2 08/14] arm64: dts: rockchip: remove num-slots property from rk3328-nanopi-r2s-plus Date: Tue, 8 Oct 2024 22:39:34 +0200 Message-ID: <20241008203940.2573684-9-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_214015_113828_1361DB80 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org num-slots was not part of the dw-mmc binding and the last slipage of one of them seeping in from the vendor kernel was removed way back in 2017. Somehow the nanopi-r2s-plus managed to smuggle another on in the kernel, so remove that as well. Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM NanoPi R2S Plus") Cc: Sergey Bostandzhyan Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts index 3093f607f282..4b9ced67742d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts @@ -24,7 +24,6 @@ &emmc { disable-wp; mmc-hs200-1_8v; non-removable; - num-slots = <1>; pinctrl-names = "default"; pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>; status = "okay"; From patchwork Tue Oct 8 20:39:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD7FCF0421 for ; Tue, 8 Oct 2024 20:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eDd5It6L888PWBPkJXs5nl2b05MH0ha+y3DJsf2KZJ8=; b=CALTXb1ce0m3Rmp7/lymTbwsY4 B3/iQgM9dxoBdtxb7gpBMtL5vVomVRROvLRrcqdico48BkOLVcm5aNSOnflfUF2VHEVfdfH4NLrNT +Dr4gIn26YaIspepjROaAQNAwAZp+b+dietHVVKT2qKQtjjwZa/YZZoFHl5tHSQKGrdVqgPFGF4TB eikIpaQ77M933fE39I32Jet58KDHsg9Ch2DKNizGVELVhj/6yiK4EDuwYPKnsikTWraZ22Cj8W2GO D1X14dJWw65Zu9hZ72ayEOxAj8hXPQ2/wMfb5QBSvR0pKsDGQ4HautkOKVneNaCHZgH5Rt4pqHub/ iiVENWMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syH8p-000000076QI-2tXG; Tue, 08 Oct 2024 20:49:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0F-000000075I4-07uK; Tue, 08 Oct 2024 20:40:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=eDd5It6L888PWBPkJXs5nl2b05MH0ha+y3DJsf2KZJ8=; b=UTjbr40Vlh/Fy6lMgbcsfjHeB5 Sl8WtzULm7bfnesmMHTsk+3FxUyE7Ptb7qxx1Nt8RM1SyoQYEDUfCbaxHZIa9N7285NNUGu2v5KRh DPNicvcqu86pjrhxyTuoQQJzFfq79MojXRi7F7DfsdV8E9D/9M9F5JxorWWcgRELJs0u1ByUPuO1M 2QhNGew61W+qJmXa5L4rkIgKr8H9rXgb1ZVjQlrpj4666rTFESTXr6aNM/AFvBa1+oRZz0k0G2buo odWPsVhz5Q0eb0z3ad1iG7evhNgulgARy+uUhlEhbmy+1vidk5vi9jCF3UPaAeIR5OAjN9fxsZ0EE BlqJjCCQ==; Received: from gloria.sntech.de ([185.11.138.130]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH06-00000004gep-3Le7; Tue, 08 Oct 2024 20:40:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eDd5It6L888PWBPkJXs5nl2b05MH0ha+y3DJsf2KZJ8=; b=jSuUVASO5JpD0ixglqh5ZhtT99 MeAKJjnELiy/DWwPry9+m8z8UQD5tpS7pEl8AeWysUqbNvedrQZ/5LVI4M+BKs4xV6OVaPjzGUWVD swCc2sP0IblT7YS7PS7WjULFljKN2pcVQhHmVHvh4OZvX9m6FKln8u/nfV3/PdoWUsTiXih/AoAQD eB5QBnNvQN502Yo4JpTrYqmpa+Z8B+92Yzrd/k6/Dit7+gf2bgRtgguB2s7hzgXz1NwX3NoatxI+f pNERTHWjtRQh5qXFQ89dK9y/hypK+4JbN3IZ7GG+ZQnELS745vZb8Sn+21UhKcU/VX3atPTCCWgNT 3Cu93X/w==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzy-0007ua-Qg; Tue, 08 Oct 2024 22:40:02 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Michael Riesch , Muhammed Efe Cetin Subject: [PATCH v2 09/14] arm64: dts: rockchip: Remove 'enable-active-low' from two boards Date: Tue, 8 Oct 2024 22:39:35 +0200 Message-ID: <20241008203940.2573684-10-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_214013_811717_63EA7CFF X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 'enable-active-low' property is not a valid, because it is the default behaviour of the fixed regulator. Only 'enable-active-high' is valid, and when this property is absent the fixed regulator will act as active low by default. Both the rk3588-orange-pi-5 and the Wolfvision pf5 io expander overlay smuggled those enable-active-low properties in, so remove them to make dtbscheck happier. Fixes: 28799a7734a0 ("arm64: dts: rockchip: add wolfvision pf5 io expander board") Cc: Michael Riesch Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5") Cc: Muhammed Efe Cetin Signed-off-by: Heiko Stuebner Reviewed-by: Michael Riesch Reviewed-by: Dragan Simic --- .../boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso | 1 - arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso index ebcaeafc3800..fa61633aea15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso +++ b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso @@ -49,7 +49,6 @@ vcc1v8_eth: vcc1v8-eth-regulator { vcc3v3_eth: vcc3v3-eth-regulator { compatible = "regulator-fixed"; - enable-active-low; gpio = <&gpio0 RK_PC0 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&vcc3v3_eth_enn>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts index feea6b20a6bf..6b77be643249 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts @@ -71,7 +71,6 @@ vcc5v0_sys: vcc5v0-sys-regulator { vcc_3v3_sd_s0: vcc-3v3-sd-s0-regulator { compatible = "regulator-fixed"; - enable-active-low; gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_LOW>; regulator-name = "vcc_3v3_sd_s0"; regulator-boot-on; From patchwork Tue Oct 8 20:39:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D1BECF0425 for ; Tue, 8 Oct 2024 20:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Ss5v3ULHCunVrXhSZIkIP3MNlCeEJXebPB4aKeixYg=; b=givJFpbw/kvi9u3BubgBHvu5B8 o6qPt8t5Xc2J7lUft2OacTIPUvgZOJI1ZprhamgWRosOB63m0Hly/dTx3661xIoOiRz++/AKbnKvC h2Z05FcEC7nDloD9AQ0bltDKMq9g2yVgcc7jHNUbozjF/EJ5JSICwpNEieQUGpbyJvt69c72fI8Yg pG8hniYLig6lA1lHwuTw41OUJ9ijI6sxEbIUJ8F3SneEwg/eppzgnaIbhzgyy0j1M26Y0eRe19lbg WYLYBdibS/COgKoebE70OB9yD+GONR4LIJ7qbbInasaewqIWKHSAhE1VCTnWsMrqMzE4HvoLcc4WE SyIrwkaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHFD-000000077K2-0BVz; Tue, 08 Oct 2024 20:55:47 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0u-000000075N8-2zhc; Tue, 08 Oct 2024 20:41:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Ss5v3ULHCunVrXhSZIkIP3MNlCeEJXebPB4aKeixYg=; b=M8u38ivjJa5SgkMHeQ87g9oobd 35EWhNuyBA6J8ORwC2Z5xqmPXwt49xG7IuvJOPz1+Un8Ov70uGpXpW32fuJYORzgi3cqpC8jFif3Y +q0PtIfAmEOneHWGkPiO4Uqdfz9KQJZO7ZFvCCuKRLoO8XII0+SH+i9jKZyLISuT4zg//K68AebN2 XO95qG5U7Y45BUfJNvAqCwpte6zHXzIEqeKybOOr+5WhtjGtscoFzDTHBG7+nxXCzf9XYlneSgARR CEIuD6gSk6fYIATOi2JWuZmozNQI8c3HHvspmtaWe8fyYWFC+gRci0DiMcU1mDdAfllcr462u1fBo Z7ahKUAQ==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzz-0007ua-5e; Tue, 08 Oct 2024 22:40:03 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Martijn Braam , Javier Martinez Canillas , Ondrej Jirman Subject: [PATCH v2 10/14] arm64: dts: rockchip: remove orphaned pinctrl-names from pinephone pro Date: Tue, 8 Oct 2024 22:39:36 +0200 Message-ID: <20241008203940.2573684-11-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134100_773070_9C296FD5 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The patch adding display support for the pinephone pro introduced two regulators that contain pinctrl-names props but no pinctrl-assignments. Looks like someone forgot the pinctrl settings, so remove the orphans for now, until that changes. Fixes: 3e987e1f22b9 ("arm64: dts: rockchip: Add internal display support to rk3399-pinephone-pro") Cc: Martijn Braam Cc: Javier Martinez Canillas Cc: Ondrej Jirman Signed-off-by: Heiko Stuebner Reviewed-by: Ondrej Jirman Reviewed-by: Javier Martinez Canillas Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 1a44582a49fb..09a016ea8c76 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -166,7 +166,6 @@ vcc1v8_lcd: vcc1v8-lcd { regulator-max-microvolt = <1800000>; vin-supply = <&vcc3v3_sys>; gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; }; /* MIPI DSI panel 2.8v supply */ @@ -178,7 +177,6 @@ vcc2v8_lcd: vcc2v8-lcd { regulator-max-microvolt = <2800000>; vin-supply = <&vcc3v3_sys>; gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; }; vibrator { From patchwork Tue Oct 8 20:39:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58446CF0425 for ; Tue, 8 Oct 2024 20:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dx6qSKCScjkQMoZc8ORhv4gyksrl/9l68dxlNO0Nn/Q=; b=U8CianhymvZkBVfkiHkb5zdvjq GRK7jEPHpu/JVkMtwLbLXEtuOQmdQVErGdvrj634mnU8PkGf+p5ahAKzf4fQ/dSRnKny8kCnN4D92 tqcR2wh/rXURDqylGAtwPHe6aT0xF5IKt3bUB9BN9DAcNd+T49bpdPPDHSQzgAUcgsUMiUNuKYvoB Yp1lAmWp8lDruZ0ZdHGtQIoL77eS8PkfT7DEdT68zy/RWw3S1nAYluyeyRetuVxfiKSzYbozHvUpC kExMH3amyga20Us/WaLcNCvSMdLHqzkx72ogjC+RXSNvr6lHIBW0rF7lAYoXDekAQkzTeb2XJx/OM izzyfq/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHJ1-000000077p7-1lPT; Tue, 08 Oct 2024 20:59:43 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH1B-000000075QX-0dgw; Tue, 08 Oct 2024 20:41:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Dx6qSKCScjkQMoZc8ORhv4gyksrl/9l68dxlNO0Nn/Q=; b=WiwbPRuRkG4uxFgmzeN33dV/06 M0/4AHjFt9JTYPHJ2l7MinthOje+M2tZHH3PTtojU1x4qVJdv/I9c7s+9qWsRvF3Rpfbtf2HGt2rr 51LnTDkacVJYEVBDE77+Th6MF8tKaN1KK7v5hV0I4nEySBMhnS6OQLVdJJ7zXGcmYuB0CsAO1h/b8 kXpUZ0xmHLzRRH5mDM2VYEgtQkTcL4ROOgr2WO/XaZyvptVjxuqLLlx1+3k4ZqmHsVX5AjfGzKc47 t9uEYolu1Nkqol8V0E8TPgqVW+8oRZVxfCFl8AlUmTREyQZMd3cF8m2yJo+FU2JwtX1yua2Yom7M8 FtnU8ihw==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzz-0007ua-Dh; Tue, 08 Oct 2024 22:40:03 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH v2 11/14] ARM: dts: rockchip: fix rk3036 acodec node Date: Tue, 8 Oct 2024 22:39:37 +0200 Message-ID: <20241008203940.2573684-12-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134117_226980_FBFF92CC X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The acodec node is not conformant to the binding. Set the correct nodename, use the correct compatible, add the needed #sound-dai-cells and sort the rockchip,grf below clocks properties as expected. Fixes: faea098e1808 ("ARM: dts: rockchip: add core rk3036 dtsi") Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm/boot/dts/rockchip/rk3036.dtsi | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/rockchip/rk3036.dtsi index 96279d1e02fe..37369538483f 100644 --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi @@ -384,12 +384,13 @@ reboot-mode { }; }; - acodec: acodec-ana@20030000 { - compatible = "rk3036-codec"; + acodec: audio-codec@20030000 { + compatible = "rockchip,rk3036-codec"; reg = <0x20030000 0x4000>; - rockchip,grf = <&grf>; clock-names = "acodec_pclk"; clocks = <&cru PCLK_ACODEC>; + rockchip,grf = <&grf>; + #sound-dai-cells = <0>; status = "disabled"; }; From patchwork Tue Oct 8 20:39:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE9CBCF0425 for ; Tue, 8 Oct 2024 21:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxRN7J/sVj1N0EB6Jrbue+PuLHyGkoW89UPYH/fY9Tw=; b=EYpCXoprYMzzK1mfYXQzGZfr8s rOTAFCzRJbOz5rhtgIzt+gqHzr3d1Na6ugjdFJubkAEU5ThCBWHuxNt1KMyyIftpAt8H1KwX4eOpd 72x8M9uz7UocckuHRfANy5XoraOFXWkkLTAryeHh8T9X4rkUaSEmN2Dp3UQSbcG5Iq+gu7UzMGi9W Kv5eTq1veNx3qvvKtsKvjyxdRTU67RunQVTWuWkqE+sTbCIOFY8DVYg2m1Gqv3ZbAP1bP9NunF2Co mpgJFKMrm+vCphFtqj+MkaIII6usKfBdIyaPtTStxAEqadqDTLajtMT+7keerbzmhU83ty/qp563X JsjFI4Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHKM-0000000782d-2xo6; Tue, 08 Oct 2024 21:01:06 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH1Q-000000075Va-32Bi; Tue, 08 Oct 2024 20:41:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uxRN7J/sVj1N0EB6Jrbue+PuLHyGkoW89UPYH/fY9Tw=; b=BfheFS4b+uK7DdRCnUMyljRUyT cSkO9CvVsxiqxZ8es5SzLldtEoAX98KzigFlchbyXRgQ3KCJLOUjUU2sMz7yJocbL1vhpmmxI/feq UWttdfnh4vEedSvbftR9tsWMYZCkBg28LJ1TjcsH8K74toVil3V8K0XcP+rCKhXoOVBH5tY6zqVvt KKJdpsJrLOik1VgTSD4BO0lNARcV6NUfwV9LUi4q6KrXhtjO/1Pv9yuAHfk569t75D9MtuyWeekRL PExHofEUoe/XP+xaqxjXHs+yqsTMOycj2L3eN2KDHgt6ULPBsEUrUhyq24lptKkaFD+nG5aXdZKyh WjF2Opew==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syGzz-0007ua-NC; Tue, 08 Oct 2024 22:40:03 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Caesar Wang Subject: [PATCH v2 12/14] ARM: dts: rockchip: drop grf reference from rk3036 hdmi Date: Tue, 8 Oct 2024 22:39:38 +0200 Message-ID: <20241008203940.2573684-13-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134132_786604_5EBB13F4 X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Neither the binding nor the driver implementation specify/use the grf reference provided in the rk3036. And neither does the newer rk3128 user of the hdmi controller. So drop the rockchip,grf property. Fixes: b7217cf19c63 ("ARM: dts: rockchip: add hdmi device node for rk3036") Cc: Caesar Wang Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm/boot/dts/rockchip/rk3036.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/rockchip/rk3036.dtsi index 37369538483f..09371f07d7b4 100644 --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi @@ -400,7 +400,6 @@ hdmi: hdmi@20034000 { interrupts = ; clocks = <&cru PCLK_HDMI>; clock-names = "pclk"; - rockchip,grf = <&grf>; pinctrl-names = "default"; pinctrl-0 = <&hdmi_ctl>; #sound-dai-cells = <0>; From patchwork Tue Oct 8 20:39:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6689CF0423 for ; Tue, 8 Oct 2024 20:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=39rBIKasij5KGq63zlzPweJVheIerVbw/yLE/z9fdVM=; b=pJPtCnp7QMoO4VGnR5MlH0XLLm WF3qgrrFVZYFDM1xxncfyXzo1poKggzMwUbIKRjj62dSSrkREKMI32A3z2LQwQurInqElGbZxTo5w rTKSLk6dCOCQOGnM14gITQdvmYmg9+xlTLUIn7CMhmu0t7ROnkLxTcwQofTBYFFKWpTaKh/oWDUVd GdQW5032YXU9wAhOXEM5ZNNJdbWDaG3k2zzJMiDwjdCZhGqlZP+UtJZ5wfqvb6VBvAx2ElDGQjTop HpmzTPA1W2eSJYizrrLsXQ04H4uFi23J0Ve0TVY9IssR+Ntd8BAsgPBv6COdXzymid3HCFSYtzN3F b5AaxmWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHDw-0000000776f-09nW; Tue, 08 Oct 2024 20:54:28 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH0o-000000075MI-1fVf; Tue, 08 Oct 2024 20:40:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=39rBIKasij5KGq63zlzPweJVheIerVbw/yLE/z9fdVM=; b=RbhEone2yOaB55CwxtXmK1QKIe cBThqv15TfOmICmCrNoXwHtDYdXjJGxBYqRRVtGJ0tQcp00tB+sKpb+92kON1q0uKElzkrgIcH+ac fMc1hoi76LJTPiOFks5k8z6Y2UXDK05rvu/2UphUt12vxOLKw0ze7UG8YbtoAh3d7NbbGcfWtsem9 7pjX5D9K4uBFUFbB+Ne20lXaAewkCschbeyk9UiSWapXYp2HxYHpqCptWaZVJ3FVGDVpNmSQQoIOW B3T4csHuPvtE0Z4JQN+lP+GOW8Iib+XBD83deDwX8fca2aG3EMppiwm0Lfy+QM2jxoelJOwx4YkLO t1T4MvBw==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syH00-0007ua-0Z; Tue, 08 Oct 2024 22:40:04 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Caesar Wang Subject: [PATCH v2 13/14] ARM: dts: rockchip: Fix the spi controller on rk3036 Date: Tue, 8 Oct 2024 22:39:39 +0200 Message-ID: <20241008203940.2573684-14-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134054_458675_7F0F80D6 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Compatible and clock names did not match the existing binding. So set the correct values and re-order+rename the clocks. It looks like no rk3036 board did use the spi controller so far, so this was never detected on a running device yet. Fixes: f629fcfab2cd ("ARM: dts: rockchip: support the spi for rk3036") Cc: Caesar Wang Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm/boot/dts/rockchip/rk3036.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts/rockchip/rk3036.dtsi index 09371f07d7b4..63b9912be06a 100644 --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi @@ -553,11 +553,11 @@ i2c0: i2c@20072000 { }; spi: spi@20074000 { - compatible = "rockchip,rockchip-spi"; + compatible = "rockchip,rk3036-spi"; reg = <0x20074000 0x1000>; interrupts = ; - clocks = <&cru PCLK_SPI>, <&cru SCLK_SPI>; - clock-names = "apb-pclk","spi_pclk"; + clocks = <&cru SCLK_SPI>, <&cru PCLK_SPI>; + clock-names = "spiclk", "apb_pclk"; dmas = <&pdma 8>, <&pdma 9>; dma-names = "tx", "rx"; pinctrl-names = "default"; From patchwork Tue Oct 8 20:39:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13826935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDCC1CF0425 for ; Tue, 8 Oct 2024 20:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m5w6xdKWUgNdPkw7Y5rv8zDO3m/QxCrIMKoWlCUHjdI=; b=CgfubxLGArbkWkFxzT0wT2sAq1 h5OQRbNgq0SqvPXqLBCntovzmE76aE5TbdTa+5puw1+tYPUu1yTSxFVDshKKSMpKWXL//XsMFNwPs d6mHXopdTSzXWhlWpvwk68NzzN9zByfP3SfoCu2nosAuBC2ythFiSjjc/MuMg1sW0obXaLhTpzruV U8DcBaI/Ea5ZZSPMinlHKIF2BxbV2RAuBZDC9Oy/7KE6EYTB6AzW3xLI5rabvFdCfQprsQ4DqUFQA ESWuGIsqlxfGOUvP9TWFfw6JmeNviSZxUtz3Xz6HtyxwPFoBgdMIv5sDe+CI1Gj0yqUgg1Ji4HCZO LITQccYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syHHk-000000077bO-0N7q; Tue, 08 Oct 2024 20:58:24 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syH15-000000075Oj-0IvT; Tue, 08 Oct 2024 20:41:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=m5w6xdKWUgNdPkw7Y5rv8zDO3m/QxCrIMKoWlCUHjdI=; b=ZiltC2Y/4qz7/TO1MouhOb+BsU 4nzW+5G/9qde5KRnd8AdEDJxirPanR46GCVLITS4FONDTZUHS4Iiksaoh7dnC3K2RmuHUCbUSCQJQ imngiRZnBrpF3fji8GMJ7OufWhqUG9Y1MdcMzLlzXdKPyV0GAyZ9ib5z1+EZCbb5ksbE+v23ND4cM agxI9RsAAthFgOeiz5kOMTRnf+kiRxRHdJ2/ystFihhD7r/Y+v073znqv2Tn/C9iRt5kDSmAMgEn5 tdw+JQoKub41vYN0RDj/6p0P4R434FeYmbaRuf4E8YXp9cOKcE9gB8s7ZP00qB+b6jevaUDtHXpLS dMYEHEqA==; Received: from i53875ad9.versanet.de ([83.135.90.217] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1syH00-0007ua-AF; Tue, 08 Oct 2024 22:40:04 +0200 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Caesar Wang Subject: [PATCH v2 14/14] ARM: dts: rockchip: Fix the realtek audio codec on rk3036-kylin Date: Tue, 8 Oct 2024 22:39:40 +0200 Message-ID: <20241008203940.2573684-15-heiko@sntech.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241008203940.2573684-1-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_134111_128825_5F3776B6 X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Both the node name as well as the compatible were not named according to the binding expectations, fix that. Fixes: 47bf3a5c9e2a ("ARM: dts: rockchip: add the sound setup for rk3036-kylin board") Cc: Caesar Wang Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic --- arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts index e32c73d32f0a..2f84e2805712 100644 --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts @@ -325,8 +325,8 @@ regulator-state-mem { &i2c2 { status = "okay"; - rt5616: rt5616@1b { - compatible = "rt5616"; + rt5616: audio-codec@1b { + compatible = "realtek,rt5616"; reg = <0x1b>; clocks = <&cru SCLK_I2S_OUT>; clock-names = "mclk";