From patchwork Thu Oct 10 12:56:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alice Ryhl X-Patchwork-Id: 13830073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE588CF11E9 for ; Thu, 10 Oct 2024 12:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77CA26B0093; Thu, 10 Oct 2024 08:57:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72C596B0095; Thu, 10 Oct 2024 08:57:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7EA6B0096; Thu, 10 Oct 2024 08:57:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3600D6B0093 for ; Thu, 10 Oct 2024 08:57:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 45EE840161 for ; Thu, 10 Oct 2024 12:57:13 +0000 (UTC) X-FDA: 82657693230.12.4164205 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf11.hostedemail.com (Postfix) with ESMTP id ED45640013 for ; Thu, 10 Oct 2024 12:57:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V9hG6iNY; spf=pass (imf11.hostedemail.com: domain of 3KM8HZwkKCCUBMJDFSZIMHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--aliceryhl.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3KM8HZwkKCCUBMJDFSZIMHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728564989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmWVfi2+jb15UkB9G2ciZscfxbiqLOksHLt4pyPQzx4=; b=KK2/rulwJK6wDhlmdPwvwQ61v0U5MKwkt8G9NP3Mde2liRqFjWcrdjswuY4qBEvP8L+6oe Sa98158rdcbTu+3O4oh+fdET3rqsGIKn5kyLJWTQDXrQ7GMA+nDwCDptXAD3lZzkQnrKdr JvdQHyHGeMQEocgKmLwvoDYzFGziGcA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=V9hG6iNY; spf=pass (imf11.hostedemail.com: domain of 3KM8HZwkKCCUBMJDFSZIMHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--aliceryhl.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3KM8HZwkKCCUBMJDFSZIMHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728564989; a=rsa-sha256; cv=none; b=DqA+H0lChjUUqfX01QHYfGqF8xzIc9GARp1mpe5zprN/kVaTlzUbZ9L5j5+V8ruYwTtgvK PeP5Pd1NulSxSm4WiKQbtZ+1ZvStoorCaIBJQIGPgmZrUczKS4Bf8A9DTEDWjeSlFV256R Bgk0R3Binv2LOgMnmedjr3s1xd+9Zf8= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e28fdb4f35fso1574132276.0 for ; Thu, 10 Oct 2024 05:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728565033; x=1729169833; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MmWVfi2+jb15UkB9G2ciZscfxbiqLOksHLt4pyPQzx4=; b=V9hG6iNYUGHCMGRH3P33vVkQjDC8aLU+tul4AoanWxuYFeQC1RO1skhli33Lggxjmb nBlWqdZhMxXHfaJ0QYcO/GqC4+Daa5EQtOHO/w6JJ0R+DiIfFSFzGMn9/WDJJcjDxpo7 n4GBEqWi2ilTYvJO8c59Gf3ZDiO0bK42WfY5dgxTCjTenNRISXPY5EBMLxEPVK4iaq/0 TnJ591tDvp/J227KQ77W7KPCRIl6Sy09LRDBNrMnpBUePwBlpS+sL7AzjngXTDmSL6QF gqpo3HjJ9UE3xvGeKu1KJdn9WKfGsdvalyZQ5sXsHPs1Qi3NzPZrwAnuJeOiH8tzcdsN OZDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728565033; x=1729169833; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MmWVfi2+jb15UkB9G2ciZscfxbiqLOksHLt4pyPQzx4=; b=Hpl1W3IMnx7/qZqNn7dUpbIVMA1e28UOVkhQiy722gjp2qPOYF09HKb99EAMos3IrL /ImyzWCwdvPRSfIaiaRvGJswJ8KQcG3SYqd5nHgYC7G16Lsmf0/r5trCzXAmHaLLW67M ugxJoLiaqha9zg2mzODYLKprvmYUWTDsy6WLZWkPLsVye7eAAgTIICcukw2EFHmVBY8e MXrRacn0E5wni6VIpCCfgPh505T/MwUM80HMri+C8i7yiJ0vY5G7ALORcjW0VsiDPUr/ I8yqra3gr+1RoKXNHB+UCm/0wZa4UJs4GOLthuhFrW28qyFIHJvyQ4cMWlrr8tbrp8ej RPXA== X-Forwarded-Encrypted: i=1; AJvYcCVcknX7hm+4uMTh9D4NeYfMiOl/m8PyDBGm9Owc/NXjmX9Mvy4XIFYBDQdApuG5gOMtHhUTaYl5xg==@kvack.org X-Gm-Message-State: AOJu0Yy0SWmRbc3XEN+iK1whapj5/XiaaJyA188r8uRYrl0S5PtCmTZW lqvOgXwGlgOwSCJJvsfHS5uoe8qzpnLV4aP0Fc9ATFVZQirmW7BY5yGfE2H685lAfZUF3e7Ey9s r1Cp1qzj5S3UpoQ== X-Google-Smtp-Source: AGHT+IF5KCyzko67R7iXNaEYOunY6fQkyjLZ3wiupTzT85+WZ+fIRr8fem+kxgLc0B0QKwId48EaLuHZPrMEjnM= X-Received: from aliceryhl.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:35bd]) (user=aliceryhl job=sendgmr) by 2002:a25:9105:0:b0:e20:25f5:a889 with SMTP id 3f1490d57ef6-e28fe4a5550mr4026276.5.1728565032146; Thu, 10 Oct 2024 05:57:12 -0700 (PDT) Date: Thu, 10 Oct 2024 12:56:35 +0000 In-Reply-To: <20241010-vma-v6-0-d89039b6f573@google.com> Mime-Version: 1.0 References: <20241010-vma-v6-0-d89039b6f573@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=25185; i=aliceryhl@google.com; h=from:subject:message-id; bh=Pku27YwuXm2j1rDbiMh5cMtYJ6eJYKBpSYm4k8LPr+M=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBnB88h0HfMQ9LKUkFEmmT/MZOuLOtFCeyWctHvM XBTI4xRIQOJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCZwfPIQAKCRAEWL7uWMY5 RjqhEACgAEgxmuU7gQkEAoro5XgPsEc0Xf8IxBcMJWstrd3IvKUc7p/mC3FgWtYSc3/lpJn667a 8zgiZHXt2w0VIJUgg8JsrxZ/cnGhNUWc9XrcdWJiaEz/mI5CWaRoMti4rMEimvnNEkwGrHBbDU+ LNEXqrgSpntgyb5BM9+heIVqxXhgUtsdJ2eLS5XjuRr6RR7eX4om7y2HjiRIS3nOQfvhAPWbIqM SOdH3ZgfsxEKHJEKkdPFOuk5Fggb6OVwYuMEV8pCu1xA+x96KC/Ln4QlpFz5AZ0oQfsStnBvM5m ro1WfN48Ws4J7g1KJtYUGBEOwQLaJjj1ylE4dmTSKItvbyhuOqhiNt2oW0d9mh4pNEcXi8lq16J KNwaXm28iZCtS+A2GMxUU8n8TdQ/DSiZlhLbdl6/KGpa46MWWGWRvddhyvDKn74uHaGJayyas42 V6E5/qj+BEwxOgg38ZaSDM5TZRNvNxQhprR5pJxegK7FFX1LhMNTIYoLH08y0nUmhtO0WbO7H4+ NTX1u2FewCvJuF/DcyHn1BuInZqM13HJPb5s+U19Hqpa6STpRSSHqyb7BhejwUvkXpBFslX6S8E rg7z5CUYS5ds3YCJZ6sBL/4hDStEx2UERNOvOEcrPZo2OcUe7kSs0GAWrvCxI43irjZB/GHI99/ 7IaUZCJuk3kSv6Q== X-Mailer: b4 0.13.0 Message-ID: <20241010-vma-v6-1-d89039b6f573@google.com> Subject: [PATCH v6 1/2] rust: mm: add abstractions for mm_struct and vm_area_struct From: Alice Ryhl To: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann Cc: Alex Gaynor , Boqun Feng , Gary Guo , " =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= " , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Alice Ryhl , Andreas Hindborg , Wedson Almeida Filho X-Rspam-User: X-Stat-Signature: n6hot7yi816giwtbwcqr71sddqikrs7s X-Rspamd-Queue-Id: ED45640013 X-Rspamd-Server: rspam11 X-HE-Tag: 1728565032-661805 X-HE-Meta: U2FsdGVkX196pU/JQTdNtBDaTV/ZuLZlwE+xqLGz6mMCVHmBmfS6BIHwLpZQVYEfdXLcH+KFiEqfAF0/aBYQNmYspS1+s/tyVkpDkHnouBDoE5zJ2gp+cNbqEHeegFeQYO6fB1VDoC+wnrcHaTqHYKV+b9tf7CvtVb3oawz6p0F85EUei+QvXn8eM4Ot/xamI9D3NxkZZA5BXZ9KOGO4eW50S1pS9kF0jbu9e1UOpiPdNxxAskhPKPqrBhA3aU1pgN5LJ1Xs25L+KVqJPMD6MAZH9VxNltjEyhuEvzX9CYTT+0HZa2ruinmEOFOGU7y4cLwdlRpJ6Kc9+lvh8vVtmXV8hobIqOzf3Ar3FzQx0doBpGYJctm1UD5PetMSIk/z4NXYH7rLcnKDm8swUL2ffiEWVnCgb3YQ5v/Rlh/B5TKjPkzMkVxoTIgCCpB58RrxYC72qERmkXdTXEAG4DV4t14ojbclK8AMtnAbDpMRdyD6VvVZ436nrsmnxczJC9bUr5xk2q8ipR+edzBXpHUl5IiynmJV+E902xQtl7rc3iQRcTE0PKzB8y4PbzWjHqEGv7DIxWNiR9RFp5X2y5vho9GS0liGMY5DQHUb6Tagh+9Wm8ebC1AxAEHggDyUP2IqGCd++LcVbKju9Ju60m7M2ylJ7rF6jzNy/gaHvT7cn4UU6/lfDZQXZDHfVtF5/RUn0+hxx7vLwM+9umoM0Vm3vIZ3fDo/UP6ZCmDeJrZNk9e+tmaAAGZqqCi+YdmqvFlKkmHynEnf5cx3DHgOWWJNWIZeA5IvmKGnOT/QD1B9A1dW+ci6vd1+NJwfqPHCgSl6pWgSCn54ssXrGpCw9AIDBPMS6pd/5Dr7AnikBZMj3ErK3cmyzJZBRXUAj1osKtnawvgYZ2qk6OCmYAIDyTgQs8CTj8rwYGZrhuK887g0Z34ULfZ3IwfLCu3NUE/0lnRa6tuOM086AtzMT18/cqV bimJX0/u SJERLgG/ba0F10e47zlzYDO7Y2B1Z7JzagmiZmC/Iyqy+ZoHURkWhdt2aQ0hMcaTi7ROcG2WSxHS0oX7Q3gsUNIHkSfCZo/bCQ6GduaI3pqbQQLQZQ0F+4oVgxpzZf5WgV0DNUJK1h2KVpEmEEeN7s14z0bQkhWDIix1abyHvTeK7OApMmOTj9tzwJ4esko2vptke10c906/iI4sPNDzKoL9KP4AMBeeWRKmwdscQX3swEWp2dqJiZge1FPPo+ocNh443CwD/dF/DtorD6lMDczoJJjhECfhbCN2tk8ZVLy7jHHklZ9XbmWeVfvzEFmMSj65g/BW0hOZ7ypgXlTFYKZkQD0wokrfihxM4yRXGAAu0+HHBlKBWWSGfwd3nMMCZBut6gIv8mOwqFThcUyTZrqDv2jy3JX6QGMJoL9bdBBZVL3ujyUgSST/gUNQZtKdmgtlzCIUQIPrgnm4KdN4tWo35StOwuc6oqhlPcRVq6nLSIBnpiawzMYJ3rOOPHIlMLmslWp/p9MgkGrt32MNL0p+MtiLYEeDhcfxD2CzeP20Oh0GFAyAguUYaWq1Zw//D4TctF5t75HBiIX/s4Ua/3KK5EHww+ZMSStQpQrucantqFtPb4T4HNbQZPbPl1BtB5FXksY/hpw/iR/ruxOoOm1mdgPo6dszJBSLp++0RfFpKYd6cuJhfYKTFxW1REtZmmrfX8EJjgif9Two= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: These abstractions allow you to manipulate vmas. Rust Binder will uses these in a few different ways. In the mmap implementation, a VmAreaNew will be provided to the mmap call which allows it to modify the vma in ways that are only okay during initial setup. This is the case where the most methods are available. However, Rust Binder needs to insert and remove pages from the vma as time passes. When incoming messages arrive, pages may need to be inserted if space is missing, and in this case that is done by using a stashed ARef and calling mmget_not_zero followed by mmap_write_lock followed by vma_lookup followed by vm_insert_page. In this case, since mmap_write_lock is used, the VmAreaMut type will be in use. Another use-case is the shrinker, where the mmap read lock is taken instead, and zap_page_range_single is used to remove pages from the vma. In this case, only the read lock is taken, so the VmAreaRef type will be in use. Future extensions could involve a VmAreaRcuRef for accessing vma methods that are okay to use when holding just the rcu read lock. However, these methods are not needed from Rust yet. This uses shared references even for VmAreaMut. This is preferable to using pinned mutable references because those are pretty inconvenient due to the lack of reborrowing. However, this means that VmAreaMut cannot be Sync. I think it is an acceptable trade-off. This patch is based on Wedson's implementation on the old rust branch, but has been changed significantly. All mistakes are Alice's. Co-developed-by: Wedson Almeida Filho Signed-off-by: Wedson Almeida Filho Signed-off-by: Alice Ryhl --- rust/helpers/helpers.c | 1 + rust/helpers/mm.c | 55 ++++++++ rust/kernel/lib.rs | 1 + rust/kernel/mm.rs | 344 +++++++++++++++++++++++++++++++++++++++++++++++++ rust/kernel/mm/virt.rs | 264 +++++++++++++++++++++++++++++++++++++ 5 files changed, 665 insertions(+) diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c index 30f40149f3a9..907ee77b3bb9 100644 --- a/rust/helpers/helpers.c +++ b/rust/helpers/helpers.c @@ -13,6 +13,7 @@ #include "build_bug.c" #include "err.c" #include "kunit.c" +#include "mm.c" #include "mutex.c" #include "page.c" #include "rbtree.c" diff --git a/rust/helpers/mm.c b/rust/helpers/mm.c new file mode 100644 index 000000000000..0a2c2cc1903f --- /dev/null +++ b/rust/helpers/mm.c @@ -0,0 +1,55 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include +#include + +void rust_helper_mmgrab(struct mm_struct *mm) +{ + mmgrab(mm); +} + +void rust_helper_mmdrop(struct mm_struct *mm) +{ + mmdrop(mm); +} + +void rust_helper_mmget(struct mm_struct *mm) +{ + mmget(mm); +} + +bool rust_helper_mmget_not_zero(struct mm_struct *mm) +{ + return mmget_not_zero(mm); +} + +void rust_helper_mmap_read_lock(struct mm_struct *mm) +{ + mmap_read_lock(mm); +} + +bool rust_helper_mmap_read_trylock(struct mm_struct *mm) +{ + return mmap_read_trylock(mm); +} + +void rust_helper_mmap_read_unlock(struct mm_struct *mm) +{ + mmap_read_unlock(mm); +} + +void rust_helper_mmap_write_lock(struct mm_struct *mm) +{ + mmap_write_lock(mm); +} + +void rust_helper_mmap_write_unlock(struct mm_struct *mm) +{ + mmap_write_unlock(mm); +} + +struct vm_area_struct *rust_helper_vma_lookup(struct mm_struct *mm, + unsigned long addr) +{ + return vma_lookup(mm, addr); +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 8a228bcbbe85..6fa97e8866a9 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -40,6 +40,7 @@ pub mod kunit; pub mod list; pub mod miscdevice; +pub mod mm; #[cfg(CONFIG_NET)] pub mod net; pub mod page; diff --git a/rust/kernel/mm.rs b/rust/kernel/mm.rs new file mode 100644 index 000000000000..b5d29ce0c6ef --- /dev/null +++ b/rust/kernel/mm.rs @@ -0,0 +1,344 @@ +// SPDX-License-Identifier: GPL-2.0 + +// Copyright (C) 2024 Google LLC. + +//! Memory management. +//! +//! C header: [`include/linux/mm.h`](srctree/include/linux/mm.h) + +use crate::{ + bindings, + types::{ARef, AlwaysRefCounted, Opaque}, +}; + +use core::{ + ops::Deref, + ptr::{self, NonNull}, +}; + +pub mod virt; + +/// A wrapper for the kernel's `struct mm_struct`. +/// +/// Since `mm_users` may be zero, the associated address space may not exist anymore. You can use +/// [`mmget_not_zero`] to be able to access the address space. +/// +/// The `ARef` smart pointer holds an `mmgrab` refcount. Its destructor may sleep. +/// +/// # Invariants +/// +/// Values of this type are always refcounted using `mmgrab`. +/// +/// [`mmget_not_zero`]: Mm::mmget_not_zero +pub struct Mm { + mm: Opaque, +} + +// SAFETY: It is safe to call `mmdrop` on another thread than where `mmgrab` was called. +unsafe impl Send for Mm {} +// SAFETY: All methods on `Mm` can be called in parallel from several threads. +unsafe impl Sync for Mm {} + +// SAFETY: By the type invariants, this type is always refcounted. +unsafe impl AlwaysRefCounted for Mm { + fn inc_ref(&self) { + // SAFETY: The pointer is valid since self is a reference. + unsafe { bindings::mmgrab(self.as_raw()) }; + } + + unsafe fn dec_ref(obj: NonNull) { + // SAFETY: The caller is giving up their refcount. + unsafe { bindings::mmdrop(obj.cast().as_ptr()) }; + } +} + +/// A wrapper for the kernel's `struct mm_struct`. +/// +/// This type is like [`Mm`], but with non-zero `mm_users`. It can only be used when `mm_users` can +/// be proven to be non-zero at compile-time, usually because the relevant code holds an `mmget` +/// refcount. It can be used to access the associated address space. +/// +/// The `ARef` smart pointer holds an `mmget` refcount. Its destructor may sleep. +/// +/// # Invariants +/// +/// Values of this type are always refcounted using `mmget`. The value of `mm_users` is non-zero. +/// #[repr(transparent)] +pub struct MmWithUser { + mm: Mm, +} + +// SAFETY: It is safe to call `mmput` on another thread than where `mmget` was called. +unsafe impl Send for MmWithUser {} +// SAFETY: All methods on `MmWithUser` can be called in parallel from several threads. +unsafe impl Sync for MmWithUser {} + +// SAFETY: By the type invariants, this type is always refcounted. +unsafe impl AlwaysRefCounted for MmWithUser { + fn inc_ref(&self) { + // SAFETY: The pointer is valid since self is a reference. + unsafe { bindings::mmget(self.as_raw()) }; + } + + unsafe fn dec_ref(obj: NonNull) { + // SAFETY: The caller is giving up their refcount. + unsafe { bindings::mmput(obj.cast().as_ptr()) }; + } +} + +// Make all `Mm` methods available on `MmWithUser`. +impl Deref for MmWithUser { + type Target = Mm; + + #[inline] + fn deref(&self) -> &Mm { + &self.mm + } +} + +/// A wrapper for the kernel's `struct mm_struct`. +/// +/// This type is identical to `MmWithUser` except that it uses `mmput_async` when dropping a +/// refcount. This means that the destructor of `ARef` is safe to call in atomic +/// context. +/// +/// # Invariants +/// +/// Values of this type are always refcounted using `mmget`. The value of `mm_users` is non-zero. +/// #[repr(transparent)] +#[repr(transparent)] +pub struct MmWithUserAsync { + mm: MmWithUser, +} + +// SAFETY: It is safe to call `mmput_async` on another thread than where `mmget` was called. +unsafe impl Send for MmWithUserAsync {} +// SAFETY: All methods on `MmWithUserAsync` can be called in parallel from several threads. +unsafe impl Sync for MmWithUserAsync {} + +// SAFETY: By the type invariants, this type is always refcounted. +unsafe impl AlwaysRefCounted for MmWithUserAsync { + fn inc_ref(&self) { + // SAFETY: The pointer is valid since self is a reference. + unsafe { bindings::mmget(self.as_raw()) }; + } + + unsafe fn dec_ref(obj: NonNull) { + // SAFETY: The caller is giving up their refcount. + unsafe { bindings::mmput_async(obj.cast().as_ptr()) }; + } +} + +// Make all `MmWithUser` methods available on `MmWithUserAsync`. +impl Deref for MmWithUserAsync { + type Target = MmWithUser; + + #[inline] + fn deref(&self) -> &MmWithUser { + &self.mm + } +} + +// These methods are safe to call even if `mm_users` is zero. +impl Mm { + /// Call `mmgrab` on `current.mm`. + #[inline] + pub fn mmgrab_current() -> Option> { + // SAFETY: It's safe to get the `mm` field from current. + let mm = unsafe { + let current = bindings::get_current(); + (*current).mm + }; + + if mm.is_null() { + return None; + } + + // SAFETY: The value of `current->mm` is guaranteed to be null or a valid `mm_struct`. We + // just checked that it's not null. Furthermore, the returned `&Mm` is valid only for the + // duration of this function, and `current->mm` will stay valid for that long. + let mm = unsafe { Mm::from_raw(mm) }; + + // This increments the refcount using `mmgrab`. + Some(ARef::from(mm)) + } + + /// Returns a raw pointer to the inner `mm_struct`. + #[inline] + pub fn as_raw(&self) -> *mut bindings::mm_struct { + self.mm.get() + } + + /// Obtain a reference from a raw pointer. + /// + /// # Safety + /// + /// The caller must ensure that `ptr` points at an `mm_struct`, and that it is not deallocated + /// during the lifetime 'a. + #[inline] + pub unsafe fn from_raw<'a>(ptr: *const bindings::mm_struct) -> &'a Mm { + // SAFETY: Caller promises that the pointer is valid for 'a. Layouts are compatible due to + // repr(transparent). + unsafe { &*ptr.cast() } + } + + /// Check whether this vma is associated with this mm. + #[inline] + pub fn is_same_mm(&self, area: &virt::VmAreaRef) -> bool { + // SAFETY: The `vm_mm` field of the area is immutable, so we can read it without + // synchronization. + let vm_mm = unsafe { (*area.as_ptr()).vm_mm }; + + ptr::eq(vm_mm, self.as_raw()) + } + + /// Calls `mmget_not_zero` and returns a handle if it succeeds. + #[inline] + pub fn mmget_not_zero(&self) -> Option> { + // SAFETY: The pointer is valid since self is a reference. + let success = unsafe { bindings::mmget_not_zero(self.as_raw()) }; + + if success { + // SAFETY: We just created an `mmget` refcount. + Some(unsafe { ARef::from_raw(NonNull::new_unchecked(self.as_raw().cast())) }) + } else { + None + } + } +} + +// These methods require `mm_users` to be non-zero. +impl MmWithUser { + /// Obtain a reference from a raw pointer. + /// + /// # Safety + /// + /// The caller must ensure that `ptr` points at an `mm_struct`, and that `mm_users` remains + /// non-zero for the duration of the lifetime 'a. + #[inline] + pub unsafe fn from_raw<'a>(ptr: *const bindings::mm_struct) -> &'a MmWithUser { + // SAFETY: Caller promises that the pointer is valid for 'a. The layout is compatible due + // to repr(transparent). + unsafe { &*ptr.cast() } + } + + /// Use `mmput_async` when dropping this refcount. + pub fn use_mmput_async(me: ARef) -> ARef { + // SAFETY: The layouts and invariants are compatible. + unsafe { ARef::from_raw(ARef::into_raw(me).cast()) } + } + + /// Lock the mmap write lock. + #[inline] + pub fn mmap_write_lock(&self) -> MmapWriteLock<'_> { + // SAFETY: The pointer is valid since self is a reference. + unsafe { bindings::mmap_write_lock(self.as_raw()) }; + + // INVARIANT: We just acquired the write lock. + MmapWriteLock { mm: self } + } + + /// Lock the mmap read lock. + #[inline] + pub fn mmap_read_lock(&self) -> MmapReadLock<'_> { + // SAFETY: The pointer is valid since self is a reference. + unsafe { bindings::mmap_read_lock(self.as_raw()) }; + + // INVARIANT: We just acquired the read lock. + MmapReadLock { mm: self } + } + + /// Try to lock the mmap read lock. + #[inline] + pub fn mmap_read_trylock(&self) -> Option> { + // SAFETY: The pointer is valid since self is a reference. + let success = unsafe { bindings::mmap_read_trylock(self.as_raw()) }; + + if success { + // INVARIANT: We just acquired the read lock. + Some(MmapReadLock { mm: self }) + } else { + None + } + } +} + +impl MmWithUserAsync { + /// Use `mmput` when dropping this refcount. + pub fn use_mmput(me: ARef) -> ARef { + // SAFETY: The layouts and invariants are compatible. + unsafe { ARef::from_raw(ARef::into_raw(me).cast()) } + } +} + +/// A guard for the mmap read lock. +/// +/// # Invariants +/// +/// This `MmapReadLock` guard owns the mmap read lock. +pub struct MmapReadLock<'a> { + mm: &'a MmWithUser, +} + +impl<'a> MmapReadLock<'a> { + /// Look up a vma at the given address. + #[inline] + pub fn vma_lookup(&self, vma_addr: usize) -> Option<&virt::VmAreaRef> { + // SAFETY: We hold a reference to the mm, so the pointer must be valid. Any value is okay + // for `vma_addr`. + let vma = unsafe { bindings::vma_lookup(self.mm.as_raw(), vma_addr as _) }; + + if vma.is_null() { + None + } else { + // SAFETY: We just checked that a vma was found, so the pointer is valid. Furthermore, + // the returned area will borrow from this read lock guard, so it can only be used + // while the read lock is still held. + unsafe { Some(virt::VmAreaRef::from_raw(vma)) } + } + } +} + +impl Drop for MmapReadLock<'_> { + #[inline] + fn drop(&mut self) { + // SAFETY: We hold the read lock by the type invariants. + unsafe { bindings::mmap_read_unlock(self.mm.as_raw()) }; + } +} + +/// A guard for the mmap write lock. +/// +/// # Invariants +/// +/// This `MmapReadLock` guard owns the mmap write lock. +pub struct MmapWriteLock<'a> { + mm: &'a MmWithUser, +} + +impl<'a> MmapWriteLock<'a> { + /// Look up a vma at the given address. + #[inline] + pub fn vma_lookup(&mut self, vma_addr: usize) -> Option<&virt::VmAreaMut> { + // SAFETY: We hold a reference to the mm, so the pointer must be valid. Any value is okay + // for `vma_addr`. + let vma = unsafe { bindings::vma_lookup(self.mm.as_raw(), vma_addr as _) }; + + if vma.is_null() { + None + } else { + // SAFETY: We just checked that a vma was found, so the pointer is valid. Furthermore, + // the returned area will borrow from this write lock guard, so it can only be used + // while the write lock is still held. + unsafe { Some(virt::VmAreaMut::from_raw(vma)) } + } + } +} + +impl Drop for MmapWriteLock<'_> { + #[inline] + fn drop(&mut self) { + // SAFETY: We hold the write lock by the type invariants. + unsafe { bindings::mmap_write_unlock(self.mm.as_raw()) }; + } +} diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs new file mode 100644 index 000000000000..7c09813e22f9 --- /dev/null +++ b/rust/kernel/mm/virt.rs @@ -0,0 +1,264 @@ +// SPDX-License-Identifier: GPL-2.0 + +// Copyright (C) 2024 Google LLC. + +//! Virtual memory. + +use crate::{ + bindings, + error::{to_result, Result}, + page::Page, + types::Opaque, +}; + +use core::ops::Deref; + +/// A wrapper for the kernel's `struct vm_area_struct` with read access. +/// +/// It represents an area of virtual memory. +/// +/// # Invariants +/// +/// The caller must at least hold the mmap read lock. +#[repr(transparent)] +pub struct VmAreaRef { + vma: Opaque, +} + +/// A wrapper for the kernel's `struct vm_area_struct` with write access. +/// +/// It represents an area of virtual memory. +/// +/// # Invariants +/// +/// The caller must at least hold the mmap write lock. +#[repr(transparent)] +pub struct VmAreaMut { + vma: Opaque, +} + +/// A wrapper for the kernel's `struct vm_area_struct` during initial VMA setup. +/// +/// It represents an area of virtual memory. +/// +/// # Invariants +/// +/// The caller must have mutable access and the vma must not have been shared yet. +#[repr(transparent)] +pub struct VmAreaNew { + vma: Opaque, +} + +// Make all VmAreaRef methods available on VmAreaMut. +impl Deref for VmAreaMut { + type Target = VmAreaRef; + #[inline] + fn deref(&self) -> &VmAreaRef { + // SAFETY: We hold at least the write lock, so we have read access. + unsafe { VmAreaRef::from_raw(self.vma.get()) } + } +} + +// Make all VmAreaMut methods available on VmAreaNew. +impl Deref for VmAreaNew { + type Target = VmAreaMut; + #[inline] + fn deref(&self) -> &VmAreaMut { + // SAFETY: The vma is not yet shared, so we have write access. + unsafe { VmAreaMut::from_raw(self.vma.get()) } + } +} + +impl VmAreaRef { + /// Access a virtual memory area given a raw pointer. + /// + /// # Safety + /// + /// Callers must ensure that `vma` is valid for the duration of 'a, and that the mmap read lock + /// (or stronger) is held for at least the duration of 'a. + #[inline] + pub unsafe fn from_raw<'a>(vma: *const bindings::vm_area_struct) -> &'a Self { + // SAFETY: The caller ensures that the invariants are satisfied for the duration of 'a. + unsafe { &*vma.cast() } + } + + /// Returns a raw pointer to this area. + #[inline] + pub fn as_ptr(&self) -> *mut bindings::vm_area_struct { + self.vma.get() + } + + /// Returns the flags associated with the virtual memory area. + /// + /// The possible flags are a combination of the constants in [`flags`]. + #[inline] + pub fn flags(&self) -> usize { + // SAFETY: By the type invariants, the caller holds at least the mmap read lock, so this + // access is not a data race. + unsafe { (*self.as_ptr()).__bindgen_anon_2.vm_flags as _ } + } + + /// Returns the start address of the virtual memory area. + #[inline] + pub fn start(&self) -> usize { + // SAFETY: By the type invariants, the caller holds at least the mmap read lock, so this + // access is not a data race. + unsafe { (*self.as_ptr()).__bindgen_anon_1.__bindgen_anon_1.vm_start as _ } + } + + /// Returns the end address of the virtual memory area. + #[inline] + pub fn end(&self) -> usize { + // SAFETY: By the type invariants, the caller holds at least the mmap read lock, so this + // access is not a data race. + unsafe { (*self.as_ptr()).__bindgen_anon_1.__bindgen_anon_1.vm_end as _ } + } + + /// Unmap pages in the given page range. + #[inline] + pub fn zap_page_range_single(&self, address: usize, size: usize) { + // SAFETY: By the type invariants, the caller holds at least the mmap read lock, so this + // access is okay. Any value of `address` and `size` is allowed. + unsafe { + bindings::zap_page_range_single( + self.as_ptr(), + address as _, + size as _, + core::ptr::null_mut(), + ) + }; + } +} + +impl VmAreaMut { + /// Access a virtual memory area given a raw pointer. + /// + /// # Safety + /// + /// Callers must ensure that `vma` is valid for the duration of 'a, and that the mmap write lock + /// (or stronger) is held for at least the duration of 'a. + #[inline] + pub unsafe fn from_raw<'a>(vma: *const bindings::vm_area_struct) -> &'a Self { + // SAFETY: The caller ensures that the invariants are satisfied for the duration of 'a. + unsafe { &*vma.cast() } + } + + /// Sets the flags associated with the virtual memory area. + /// + /// The possible flags are a combination of the constants in [`flags`]. + #[inline] + pub fn set_flags(&self, flags: usize) { + // SAFETY: By the type invariants, the caller holds the mmap write lock, so this access is + // not a data race. + unsafe { (*self.as_ptr()).__bindgen_anon_2.vm_flags = flags as _ }; + } + + /// Maps a single page at the given address within the virtual memory area. + /// + /// This operation does not take ownership of the page. + #[inline] + pub fn vm_insert_page(&self, address: usize, page: &Page) -> Result { + // SAFETY: By the type invariants, the caller holds the mmap write lock, so this access is + // not a data race. The page is guaranteed to be valid and of order 0. The range of + // `address` is already checked by `vm_insert_page`. + to_result(unsafe { bindings::vm_insert_page(self.as_ptr(), address as _, page.as_ptr()) }) + } +} + +impl VmAreaNew { + /// Access a virtual memory area given a raw pointer. + /// + /// # Safety + /// + /// Callers must ensure that `vma` is valid for the duration of 'a, and that the vma is + /// currently undergoing initial VMA setup. + #[inline] + pub unsafe fn from_raw<'a>(vma: *const bindings::vm_area_struct) -> &'a Self { + // SAFETY: The caller ensures that the invariants are satisfied for the duration of 'a. + unsafe { &*vma.cast() } + } + + /// Make this vma anonymous. + #[inline] + pub fn set_anonymous(&self) { + // SAFETY: The vma is not yet shared. + unsafe { (*self.as_ptr()).vm_ops = core::ptr::null() }; + } +} + +/// Container for [`VmArea`] flags. +pub mod flags { + use crate::bindings; + + /// No flags are set. + pub const NONE: usize = bindings::VM_NONE as _; + + /// Mapping allows reads. + pub const READ: usize = bindings::VM_READ as _; + + /// Mapping allows writes. + pub const WRITE: usize = bindings::VM_WRITE as _; + + /// Mapping allows execution. + pub const EXEC: usize = bindings::VM_EXEC as _; + + /// Mapping is shared. + pub const SHARED: usize = bindings::VM_SHARED as _; + + /// Mapping may be updated to allow reads. + pub const MAYREAD: usize = bindings::VM_MAYREAD as _; + + /// Mapping may be updated to allow writes. + pub const MAYWRITE: usize = bindings::VM_MAYWRITE as _; + + /// Mapping may be updated to allow execution. + pub const MAYEXEC: usize = bindings::VM_MAYEXEC as _; + + /// Mapping may be updated to be shared. + pub const MAYSHARE: usize = bindings::VM_MAYSHARE as _; + + /// Do not copy this vma on fork. + pub const DONTCOPY: usize = bindings::VM_DONTCOPY as _; + + /// Cannot expand with mremap(). + pub const DONTEXPAND: usize = bindings::VM_DONTEXPAND as _; + + /// Lock the pages covered when they are faulted in. + pub const LOCKONFAULT: usize = bindings::VM_LOCKONFAULT as _; + + /// Is a VM accounted object. + pub const ACCOUNT: usize = bindings::VM_ACCOUNT as _; + + /// should the VM suppress accounting. + pub const NORESERVE: usize = bindings::VM_NORESERVE as _; + + /// Huge TLB Page VM. + pub const HUGETLB: usize = bindings::VM_HUGETLB as _; + + /// Synchronous page faults. + pub const SYNC: usize = bindings::VM_SYNC as _; + + /// Architecture-specific flag. + pub const ARCH_1: usize = bindings::VM_ARCH_1 as _; + + /// Wipe VMA contents in child.. + pub const WIPEONFORK: usize = bindings::VM_WIPEONFORK as _; + + /// Do not include in the core dump. + pub const DONTDUMP: usize = bindings::VM_DONTDUMP as _; + + /// Not soft dirty clean area. + pub const SOFTDIRTY: usize = bindings::VM_SOFTDIRTY as _; + + /// Can contain "struct page" and pure PFN pages. + pub const MIXEDMAP: usize = bindings::VM_MIXEDMAP as _; + + /// MADV_HUGEPAGE marked this vma. + pub const HUGEPAGE: usize = bindings::VM_HUGEPAGE as _; + + /// MADV_NOHUGEPAGE marked this vma. + pub const NOHUGEPAGE: usize = bindings::VM_NOHUGEPAGE as _; + + /// KSM may merge identical pages. + pub const MERGEABLE: usize = bindings::VM_MERGEABLE as _; +} From patchwork Thu Oct 10 12:56:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alice Ryhl X-Patchwork-Id: 13830072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77F2CF11EC for ; Thu, 10 Oct 2024 12:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55CB26B0095; Thu, 10 Oct 2024 08:57:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46DF86B0098; Thu, 10 Oct 2024 08:57:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD3B6B0099; Thu, 10 Oct 2024 08:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B1326B0095 for ; Thu, 10 Oct 2024 08:57:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A1CF16025F for ; Thu, 10 Oct 2024 12:57:14 +0000 (UTC) X-FDA: 82657693314.07.41020D9 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf25.hostedemail.com (Postfix) with ESMTP id 6646FA0016 for ; Thu, 10 Oct 2024 12:57:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VwD7mPu5; spf=pass (imf25.hostedemail.com: domain of 3K88HZwkKCCgEPMGIVcLPKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--aliceryhl.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3K88HZwkKCCgEPMGIVcLPKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728564965; a=rsa-sha256; cv=none; b=TeJ6WKNEXM0ie+qGqykH6JZkriak+PsC242nhtUgcpvd3HFRqLIqjNmiP1N6wsXH02h9vo V4Jej231QppiSTyLx2AfSkxtACvzW3e3pxEGcwWMgmdqJQrfpqC5IvB76nkLLW/yc4wPkU TpfxUmtEhAnGuLHd7h1/gMOIU5UNS4g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VwD7mPu5; spf=pass (imf25.hostedemail.com: domain of 3K88HZwkKCCgEPMGIVcLPKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--aliceryhl.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3K88HZwkKCCgEPMGIVcLPKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728564965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=glV3fv5SFFf1x3gt0c73tA5JY4awjp99N5v6GnmrQXY=; b=QHrPYxOTUSchJS8xgL+lHZ/kylQwYtcqhi8enisw1NKxL6BUP6eIiv3P4KQQ+X5qhkf3pe 7WzX/Im4AoiliEfUiLB+j+HrUrjOLAjYafG05qhyzFeFM9kRMibU5p/gJ2zBYwHiTvJB0D Kd9y+R4uBWk2ZWQjg7xY5gKXu+vA5mQ= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e3231725c9so16456777b3.1 for ; Thu, 10 Oct 2024 05:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728565035; x=1729169835; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=glV3fv5SFFf1x3gt0c73tA5JY4awjp99N5v6GnmrQXY=; b=VwD7mPu5IZw0S0RoYQB/R8o1AmrYfGFXV8YuwB1fIaQ5WYz6cuAuWwZU3bT3e1Xiq5 bT79e15o0Cd6A/nauGnDvRb7C7NtAX7/ZZPDzy4jLqromeJiqrZN5holBz59gPsQeuRF pe2PgLSZQ0k4KnvUeUs5Ox2XcHmZZThaDklUqC6yOff1sFSGQkd6IOV5pMAugE/YU+jv sI6PCJoxk8dKw6LKYkDw/v0g+gUTgzP31XFEy2axwbf9ONwxSL2JmUeds+o364UsRhx3 2n1k4odOqfxTYEGkPi0EuCwGtEKjZFs/zKXdveA69ZBo/ZUlA2y9UV6RHyb5ONyAgjgo 4bpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728565035; x=1729169835; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=glV3fv5SFFf1x3gt0c73tA5JY4awjp99N5v6GnmrQXY=; b=liugZn1aBUJeMGrhym0TGO/2JR4I6/K+dbBhtb3lVBVNw0ErMkiErr4pAe3+fHuq1z bbwmKz4xg0cI5mQpOXep5vBVeQIiUlY1qSFJi6/nooVEf2w5jFXcpSlQZ0J4jeS7VX5W /fN7B5dvXtLH2umj1LbmUnvwvp5jkX/k/tbi65sl5SFfrY4625L3N8ePgQsr76ZnWHov NhusQYsDK7qh8rEbnFzJGv5122C1e9j8uZog0St8GsTO0aZneycK57ETePNYUp7y7lnM WAz4WKCAT7jSl76fn+1NpYQvyKUN1gSWRY+EA/pXpBpVYV49otMRryPSgeQRp9/xegiz +qUA== X-Forwarded-Encrypted: i=1; AJvYcCWZ46mcf1cczxg4FdFOaYqJxXIsE3HonPDUhTNGcUH5E7qjKwO2yf+qpjdKuhAIVI0g+rv5UgD3JA==@kvack.org X-Gm-Message-State: AOJu0YxHX5QwK1X5plx3CyrJXcAwi7uiP7/OOyyBAgZ7DRrGohMY/BSc SWQPE1yaAVbiHVBSRlI/+vWXK4F3rn0ZEFT5jXR1lIww6cZvyvKcZYhkXcwKw0WQN7mmU+fusyo Xxip6ckz+zlVaCQ== X-Google-Smtp-Source: AGHT+IFHaXXnl7DU3u8thuin4117bTfSXLLKlSu8pzsSBybwnadUftHI2kg9Z9q4pkU1hrzfZE6VLP9WSb+EI/o= X-Received: from aliceryhl.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:35bd]) (user=aliceryhl job=sendgmr) by 2002:a05:690c:6681:b0:6e2:12e5:356f with SMTP id 00721157ae682-6e32215bd01mr1397177b3.3.1728565035062; Thu, 10 Oct 2024 05:57:15 -0700 (PDT) Date: Thu, 10 Oct 2024 12:56:36 +0000 In-Reply-To: <20241010-vma-v6-0-d89039b6f573@google.com> Mime-Version: 1.0 References: <20241010-vma-v6-0-d89039b6f573@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=2493; i=aliceryhl@google.com; h=from:subject:message-id; bh=NyWGuEgAoTCOUDUDd9sQnT8nfx0rvhH11rLVW8whQqU=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBnB88i1QasOE6/sMcz8AIIZHVv4kJthm+7hFroE Cs46FuoTkuJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCZwfPIgAKCRAEWL7uWMY5 RjpgD/0e+GOn8RpHZKr1Y0np5kF/2v08wVH5Zf/VaSpmrg3HwgpMPqxJ3feyy05Z6oBtzK1hkNN Wv+G/SpeKhnmzLFgNfbMp5kgoYF1NNoQ7A6bZXnv+MNE24RjvXYhZusm8c4ckJ3Me9xMJBUwO9x nK5ClqLjOZajAQiZDQbLfQn58RCc164miHTgRRSSxpBIH0BOszm2qqv9hHhL36aXKd4uh6ldb3q hfwUwOuhe8rOCOXFi1Vwrxv9haulc4c47qernQjLpV4WDiscoo0el4OYFCLb+pFx+C9W1GDJzbt IrvwUBF+Zau7gsoJlGsLKVKh3Y+N+pJ5/JPHe78rcXLObocbLyDRrTQGuM847vPeazglMm3xSk/ 23EVG4PaTO93mWkCYzxceXM7KEpngQg9/sAkTy3UF3w0oCnxoMkgka1kzwpYFqiet6n/oHnv57k q4g1hT0XU9JWAKzWmeonS9vSsB9drqmuMFzPGWt4wbnM8qrI9OFjycdKlvAGzUrBMDitkXW8JEN Hx3VDAfZUaB02JEPa36P7/O4T22ElByztu3XaiWl7ngKqFooX7NMUgtH6Ke/RtbCyFIYD3k9SY0 G/CwzbbswhCVel0TVBbBL4/nzBqcH/FASmIzINtNDhTbaikGPAixxwT1b4Jx0NpNWpSKrrHPuGs OFT+MdwYBY7CHQQ== X-Mailer: b4 0.13.0 Message-ID: <20241010-vma-v6-2-d89039b6f573@google.com> Subject: [PATCH v6 2/2] rust: miscdevice: add mmap support From: Alice Ryhl To: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann Cc: Alex Gaynor , Boqun Feng , Gary Guo , " =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= " , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Alice Ryhl , Andreas Hindborg X-Stat-Signature: b1kj3zaionosziighkbagwrne3rbprp7 X-Rspamd-Queue-Id: 6646FA0016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728565035-510408 X-HE-Meta: U2FsdGVkX1/v+zVk5DYodmfSf4zgX4CHIpLJMsJs7l82NSBtXSGsWR5xb0dDbSBh0Ph0VGoPOV5XSlwPSpgwPvJCoufa2V+2ZH4L8zQQsEjh/aKRhzbnPQYQNDboAK2G7nY6EX+ZcI6mW6DTY1lzXLKdhOiUMm60a1tl5oW7ywtT8JS3CwngSFBfaTNgp41p1Oz7BN8z/aL0YDUHmzXcRnDYq+FyHY9MQwKFS/O4spSbNGBy/o3gHI5LeDOGzXJW4ypDpcG8EDURqh19aUcYzw189UWL9s/+de8+7AJ+EqDUSxBa41S2QqIEBDbNUeGuc7AwSfpTmThce0ZQ0ZqMuAafz3IjnDw8UwB7sVcBakHmIbJErU3hQiDXkuQH10SzfnwWbDIvo5Zif0WKKOoc1grPwWst5cbLxsEEhAWaYPWpF39SN1wW899xF38Vf1iJl+iGIy3ZsTZAN8Jw1puOCfSbsZXk3dLWqpdZz3GmMLD/nrX/+YFMFohTx/FKuPvS5GPOC5GIM8tov5UrzBLJ8FXkNYNbw+fIotdVwsMFZ5i9wExeQqBRiGupH4eLoSBGP3zdvjOemmwUUB9zUE9C1jC08NDcSRTZhxvWf34FggATy7SixMfLWhUmJwQHlKsyoHRFwTc/4ddgweCX7gFNwJ0fNoF93boHrzzFGFLMI2xCL8K7NB26Nt2/piMXBxK0F2yL/B2/xsSQjaIPgXyRUxnBLmYpKuDlqkMi2g0rtdgZyon2xKCHTp2kKhwEzZrxMnKHccZSrHkpwqJKPI9vzeyFnqAPhqFFbm7+VYAoOFNi8BOeej5rDY6bmZYmZvWYZZzWIEuBmL01OxyZbKmFpYfyCMcOrW0GKe8Xzi4CuktcCvwW2sOzXqNau3l8m3/mRBZEIkcTkEMYwpL1h2IJz+WOP7g2/8MNjYGyGm+amfKwikU4uz4b7tjyK4QoBZpmyHBpYDzvVnKub4G+EVk K3Vpp8b4 aM0O4eXoGOv5kdvwderjv0vuQ5LxMuwIHhJWzuQSt6gaeOjWPkOnynEP2+4v8wvVB+DwBLTih9QldTFDdK5DATUpyQATjQKWxpB8m/Q9xsCZvJeZCl5GHFzF2gfLeQ1Rx4wwumBU5FXPKjY3z8IYMfeg5LXNXK68FIQIk/XKcyGO4qRH/O5N4JuR28BfpFptDg/ihTwgHVhM13NkCsXlGl4abquC6fi0xtxSvKrC8YJffoSOHkeXCpuItw6hyikY/bqp+QKdEuf573ElV808tuU6sDTadG+ZeopmQr9HbpxrlznaV3CXwe+HUflK2fOIJPdHVbjEgGTRb6Eu8nueEVenOS80aeUR1l0PNC59U+OmNDJUA52EiidlB+mD/+qCf1BNAwh1F+vxWu9QQUdUs821Vc/J9qpAxKWHXIQXr+qJeZ6dqvugd98e8w4+yfpULFsJ8/c+PyFOMvbzAPzEf6MaqlBpkbCNsgkbcTTYp3PHaEndgzitpo/lr+YRuei1SOLdnshhxfx3VG9gKKm3Bmkb9Ywuf6IuWkilggeYHW4JBSlRWkKzs4gdDvgAezI1r69K30hSF3aSpciy/TyupvU5W5+rhVMwcnn5lu+sMdKPxQ2v0TBwL9GYPzorZmed4tOBuF/a0DEimm8d9vfOaJwL0bSohWaS0Ts4k5RhCtfrolf8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using the vma support introduced by the previous commit, introduce mmap support for miscdevices. The mmap call is given a vma that is undergoing initial setup, so the VmAreaNew type is used. Signed-off-by: Alice Ryhl --- rust/kernel/miscdevice.rs | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs index cbd5249b5b45..c9428a6154e3 100644 --- a/rust/kernel/miscdevice.rs +++ b/rust/kernel/miscdevice.rs @@ -11,6 +11,7 @@ use crate::{ bindings, error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR}, + mm::virt::VmAreaNew, prelude::*, str::CStr, types::{ForeignOwnable, Opaque}, @@ -110,6 +111,11 @@ fn release(device: Self::Ptr) { drop(device); } + /// Handle for mmap. + fn mmap(_device: ::Borrowed<'_>, _vma: &VmAreaNew) -> Result { + kernel::build_error(VTABLE_DEFAULT_ERROR) + } + /// Handler for ioctls. /// /// The `cmd` argument is usually manipulated using the utilties in [`kernel::ioctl`]. @@ -156,6 +162,7 @@ impl VtableHelper { const VTABLE: bindings::file_operations = bindings::file_operations { open: Some(fops_open::), release: Some(fops_release::), + mmap: maybe_fn(T::HAS_MMAP, fops_mmap::), unlocked_ioctl: maybe_fn(T::HAS_IOCTL, fops_ioctl::), #[cfg(CONFIG_COMPAT)] compat_ioctl: if T::HAS_COMPAT_IOCTL { @@ -207,6 +214,23 @@ impl VtableHelper { 0 } +unsafe extern "C" fn fops_mmap( + file: *mut bindings::file, + vma: *mut bindings::vm_area_struct, +) -> c_int { + // SAFETY: The mmap call of a file can access the private data. + let private = unsafe { (*file).private_data }; + // SAFETY: Mmap calls can borrow the private data of the file. + let device = unsafe { ::borrow(private) }; + // SAFETY: The caller provides a vma that is undergoing initial VMA setup. + let area = unsafe { kernel::mm::virt::VmAreaNew::from_raw(vma) }; + + match T::mmap(device, area) { + Ok(()) => 0, + Err(err) => err.to_errno() as c_int, + } +} + unsafe extern "C" fn fops_ioctl( file: *mut bindings::file, cmd: c_uint,