From patchwork Sun Oct 13 20:45:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13833442 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 721FF82C7E for ; Sun, 13 Oct 2024 20:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852325; cv=none; b=WpOZpa8Xoo0WbuelqkcX4hwljPOej14b4MsJk1Ohmrjejq1r2ucMzK3ddwFbWXDFg/uepGPYb3e+OCmpmwFQoYNvAWIWW/+kGksj+6OyA5UAG80rOU3dME5EJc4pKYI3B/RYcjqG42nPcooXV35+NIaQfV5lTZco3f7kz6Dzb2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852325; c=relaxed/simple; bh=avldfsQ7dAPVuGQJrjBHF7JPmTu4FsehzURUNX6Ybt4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pL4xhb0zGgPIwjT7er2Ghaf7CEMmBadxzo2/j0NWE95nPDasx0PeC0dkeaEiQy4gC+cqSb4oq5uCxqzHbx+LNxpBMdQVvDDylNtHrEquyepyuVj6nCICLymOIuE3smj9m8FszU9ih+Uz8bKj4d5eGuo2pIg8nZs3KjaJ2IQqM38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KAgYFBTG; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KAgYFBTG" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a99ea294480so167265166b.2 for ; Sun, 13 Oct 2024 13:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728852321; x=1729457121; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mh5b3fLKFrmas27aO98OK/DGsN3T/vUtw+HvnH2RNqw=; b=KAgYFBTG2W9byqn6gJhFTsk8sG8YDgSWsiy+bDYl7eDHxNj1MO3A1WTYLbAWUfDqZn k5AaW50kx+Nvh/jGzjX8NhzJUgJ1hK/Tqw3UbypA0ergvZ2wIEpvZ7fkPPRKTOWzRXw5 yZ7wzOpj8QZYd/V1kkz8B5w1vo8+6GNzIdYUrDpnOj+mDfhLxmehmii5Uhw4+nIY53Bm 1CG2L9sYffrDkmFjxa8bD0X1/fnYWJxn1/w7seojO9ExAwzOmi4DSvQv90Wj9hl7kQVB yRa0gaSuUe+3aNh4Pc3BTwGTlTTfMT9+W3DFSGQMFDaVGYNPGcOslEieFZMk/mJ7ql0B ZmhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728852321; x=1729457121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mh5b3fLKFrmas27aO98OK/DGsN3T/vUtw+HvnH2RNqw=; b=iCTKRXKtzAHtLHA5xpeamfk0zdnD4YFPChxfMJQUg56WrE+e+ENirgUWhL1/06/9Fd 3QvI+ZWpnmBFCbZljyHVriR8Lv4HW/S3lDuBw7HpeCeABa4VMFc8ggwPXLKuZ3zYuipW B7t5aJxbO+p/vKWWMw5mIcB3XlxOpb/h1Lbsv+OP6JASCbeW76zt6RkfRKxE9ttfm/M0 Dkkt9aYIbbY7UJ8Kp3q8ffd9c0tWbW2tfde/eErs/lpVFlUrVwCtdF3M03RZBPP0RomV I22lYRPu5IPsn6HWDuv3EFB3pj2PjVfHBbcVVAz+Mo+shzini7AZn9zf18XKe9T5HPRT 2jfQ== X-Gm-Message-State: AOJu0YwAvexuTIiY4wioZPdunDHaQZfuKmB4h1LuS70a6M8L5MooWrZA 1DaP25rNBuFFdl96RO+y0DPWYnBQuNrtubY1W6BOtw1fP8nqVl6QUgs0Ng== X-Google-Smtp-Source: AGHT+IEs0QAsrJvN9U2GVxq7bs2GnexaNmjuYi4OAo9wAvsNnvSYth/j2JDTTfya+8g85vZ1W1i0Pw== X-Received: by 2002:a05:6402:5c9:b0:5c9:5745:de9a with SMTP id 4fb4d7f45d1cf-5c95ac15776mr9139379a12.9.1728852320836; Sun, 13 Oct 2024 13:45:20 -0700 (PDT) Received: from 127.0.0.1localhost ([85.255.233.136]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99f86b689dsm186078166b.181.2024.10.13.13.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 13:45:19 -0700 (PDT) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: Jens Axboe , asml.silence@gmail.com Subject: [PATCH liburing 1/3] Add io_uring_prep_cmd_discard Date: Sun, 13 Oct 2024 21:45:44 +0100 Message-ID: <45357cbdcbea27505bd43ed53e19722737fa4179.1728851862.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add a helper for io_uring block discard commands. Since the discard opcode is in newly added linux/blkdev.h we need to do some configure magic defining it ourselves if the header is missing from the system. Signed-off-by: Pavel Begunkov --- configure | 32 ++++++++++++++++++++++++++++++++ src/include/liburing.h | 10 ++++++++++ 2 files changed, 42 insertions(+) diff --git a/configure b/configure index e2221d3..6c9cea0 100755 --- a/configure +++ b/configure @@ -417,6 +417,21 @@ if compile_prog "" "" "futexv"; then fi print_config "futex waitv support" "$futexv" +########################################## +# Check block discard cmd support +discard_cmd="no" +cat > $TMPC << EOF +#include +int main(void) +{ + return BLOCK_URING_CMD_DISCARD; +} +EOF +if compile_prog "" "" "discard command"; then + discard_cmd="yes" +fi +print_config "io_uring discard command support" "$discard_cmd" + ########################################## # Check idtype_t support has_idtype_t="no" @@ -651,6 +666,23 @@ typedef enum } idtype_t; EOF fi + +if test "$discard_cmd" != "yes"; then +cat >> $compat_h << EOF + +#include + +#ifndef BLOCK_URING_CMD_DISCARD +#define BLOCK_URING_CMD_DISCARD _IO(0x12, 0) +#endif + +EOF +else cat >> $discard_cmd << EOF +#include + +EOF +fi + cat >> $compat_h << EOF #endif EOF diff --git a/src/include/liburing.h b/src/include/liburing.h index c5a2fda..f5903d7 100644 --- a/src/include/liburing.h +++ b/src/include/liburing.h @@ -1292,6 +1292,16 @@ IOURINGINLINE void io_uring_prep_ftruncate(struct io_uring_sqe *sqe, } #endif +IOURINGINLINE void io_uring_prep_cmd_discard(struct io_uring_sqe *sqe, + int fd, + uint64_t offset, uint64_t nbytes) +{ + io_uring_prep_rw(IORING_OP_URING_CMD, sqe, fd, 0, 0, 0); + sqe->cmd_op = BLOCK_URING_CMD_DISCARD; + sqe->addr = offset; + sqe->addr3 = nbytes; +} + /* * Returns number of unconsumed (if SQPOLL) or unsubmitted entries exist in * the SQ ring From patchwork Sun Oct 13 20:45:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13833443 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFBF14EC4B for ; Sun, 13 Oct 2024 20:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852326; cv=none; b=X8NK6ZYQHSBVpfs+ZAMnADMmEGIBd+/ybXo1XgRx+XUls9yn3+/KDYUxTR2zW+eCdasP00JlT0nPQXPqxAUNy8ixn3gBjImnuwwShp0TK6rk4cqBe2Lkj+/dU/eVvz0kyBuq2xTn7ZyI3HCp2H989QuA2ynVmGtybnnLkQUnW10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852326; c=relaxed/simple; bh=imLekR43HMRhU5H4My08P33i9mOb71GJ5hzxhwXulw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SLiMZio9mOw+L6z+KB/FoyDSQCn8IDilJr0/A+fujcDfoG3Tq1/zGtKmY1P6ZABuS0VJ/aSahGudo5qvul3NpnasMq7lqCqsyViYLJtCXg3YQsvM35//AbsvijtUzsvAB3SsjoURwDHeaVa6HHojv80nNRjPkttDJ9ezmlKkS3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cd7VSf9/; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cd7VSf9/" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-37d58377339so2410715f8f.1 for ; Sun, 13 Oct 2024 13:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728852323; x=1729457123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QRTyUDVCzMrA5F/WLPTK2W5lykgzHuT4WRXwN8fNmqs=; b=Cd7VSf9/LSESExGuLQz5353IXTFBWZ1rNy5/TpFdf22E6g9gtssfBXcD8CNksPknrI k/f2byOVOprRB2Dmyb3356357s/oWgtl7CxHW3ZLp3P2+BLzTiCmPONzWI6DjRFi2/yh 1vyJXalvt4MDBVscAqN5jPgSDcBNqOFuwKq7h76Hy5v0FAe6lnqcw75c6BibRD/GJlPp JkWG2GQrLC5Tsa3Oh90rcNAMW9Hgg3C/I8x+NeZmsLupvQxRq/YKJrbH/ztxSMUqxIco O0RJlFH4ubzZS6ZFci/9L5SU7RXvI8NrIfHcK0pa2ustyacc19oyxdJPiwQgHFBEpjBE H2tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728852323; x=1729457123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QRTyUDVCzMrA5F/WLPTK2W5lykgzHuT4WRXwN8fNmqs=; b=klHU+aGGerkET7SZEXblB/G97B9+Q0J9sFLPabSMvOhOjoRiFx9S+vaeJVxXIT7+L6 0xnQaUsU26Ji/vg3x2C6MZ3PD7uN0C2mTNfvY2jGPI4gtv2PTUQ3fu/j6sIQqnrsrJOe ycoaAHaFIehOmAjJoHptbxpJwuLMRD3jQ7G8HzjuiQeLoeJgIwGQoLEOU5dUxvHR1yJF nb/asHC8xqo4LT/tKLy0SJifwmCd5hDacXJ0ZOEE/0HffDBDOTV4hr9lU/NJSGzHjxMU +4poy+52EbkENvW73lODhgh/NqxveDsaHZsD0q0h7qpl6uA55u8RGZVzHydbELEydBpS qnCw== X-Gm-Message-State: AOJu0Yzr27OC3j4jVglIIltqxVfPeQXuh9yd4sYWBAO2L63ncxOAD4rW OgqeDRuFOtVFwORNDLds7McwHcuztduufSYlEkXYur7U/PjrU6DmNLKfPg== X-Google-Smtp-Source: AGHT+IE/98d03MKnCLQv0FZlsNw3rdMc9IPPkcU1SK5U3SjcvTgWOPzMjh7oCoq1KbUd+gDuUgT1Tg== X-Received: by 2002:a5d:64ec:0:b0:37d:37c6:7af0 with SMTP id ffacd0b85a97d-37d5ff2678fmr7079531f8f.6.1728852322396; Sun, 13 Oct 2024 13:45:22 -0700 (PDT) Received: from 127.0.0.1localhost ([85.255.233.136]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99f86b689dsm186078166b.181.2024.10.13.13.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 13:45:21 -0700 (PDT) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: Jens Axboe , asml.silence@gmail.com Subject: [PATCH liburing 2/3] test: add discard cmd tests Date: Sun, 13 Oct 2024 21:45:45 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Pavel Begunkov --- test/Makefile | 1 + test/cmd-discard.c | 402 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 403 insertions(+) create mode 100644 test/cmd-discard.c diff --git a/test/Makefile b/test/Makefile index de5f98d..b22c3f1 100644 --- a/test/Makefile +++ b/test/Makefile @@ -65,6 +65,7 @@ test_srcs := \ connect.c \ connect-rep.c \ coredump.c \ + cmd-discard.c \ cq-full.c \ cq-overflow.c \ cq-peek-batch.c \ diff --git a/test/cmd-discard.c b/test/cmd-discard.c new file mode 100644 index 0000000..4d7f91e --- /dev/null +++ b/test/cmd-discard.c @@ -0,0 +1,402 @@ +/* SPDX-License-Identifier: MIT */ + +#include +#include +#include +#include +#include +#include +#include + +#include "liburing.h" +#include "helpers.h" + +#define MAX_TEST_LBAS 1024 + +static const char *filename; +static int opcodes[] = { + BLOCK_URING_CMD_DISCARD, +}; + +static int lba_size; +static uint64_t bdev_size; +static uint64_t bdev_size_lbas; +static char *buffer; + +#define TEST_BLOCK_URING_CMD_MAX 3 + +static void prep_blk_cmd(struct io_uring_sqe *sqe, int fd, + uint64_t from, uint64_t len, + int cmd_op) +{ + assert(cmd_op == BLOCK_URING_CMD_DISCARD); + + io_uring_prep_cmd_discard(sqe, fd, from, len); +} + +static int queue_cmd_range(struct io_uring *ring, int bdev_fd, + uint64_t from, uint64_t len, int cmd_op) +{ + struct io_uring_sqe *sqe; + struct io_uring_cqe *cqe; + int err; + + sqe = io_uring_get_sqe(ring); + assert(sqe != NULL); + prep_blk_cmd(sqe, bdev_fd, from, len, cmd_op); + + err = io_uring_submit_and_wait(ring, 1); + if (err != 1) { + fprintf(stderr, "io_uring_submit_and_wait failed %d\n", err); + exit(1); + } + + err = io_uring_wait_cqe(ring, &cqe); + if (err) { + fprintf(stderr, "io_uring_wait_cqe failed %d (op %i)\n", + err, cmd_op); + exit(1); + } + + err = cqe->res; + io_uring_cqe_seen(ring, cqe); + return err; +} + +static int queue_cmd_lba(struct io_uring *ring, int bdev_fd, + uint64_t from, uint64_t nr_lba, int cmd_op) +{ + return queue_cmd_range(ring, bdev_fd, from * lba_size, + nr_lba * lba_size, cmd_op); +} + +static int queue_discard_lba(struct io_uring *ring, int bdev_fd, + uint64_t from, uint64_t nr_lba) +{ + return queue_cmd_lba(ring, bdev_fd, from, nr_lba, + BLOCK_URING_CMD_DISCARD); +} + +static int test_parallel(struct io_uring *ring, int fd, int cmd_op) +{ + struct io_uring_sqe *sqe; + struct io_uring_cqe *cqe; + int inflight = 0; + int max_inflight = 16; + int left = 1000; + int ret; + + while (left || inflight) { + int queued = 0; + unsigned head, nr_cqes = 0; + int lba_len = 8; + + while (inflight < max_inflight && left) { + int off = rand() % (MAX_TEST_LBAS - lba_len); + sqe = io_uring_get_sqe(ring); + assert(sqe != NULL); + + prep_blk_cmd(sqe, fd, off * lba_size, + lba_len * lba_size, cmd_op); + if (rand() & 1) + sqe->flags |= IOSQE_ASYNC; + + queued++; + left--; + inflight++; + } + if (queued) { + ret = io_uring_submit(ring); + if (ret != queued) { + fprintf(stderr, "io_uring_submit failed %d\n", ret); + return T_EXIT_FAIL; + } + } + + ret = io_uring_wait_cqe(ring, &cqe); + if (ret) { + fprintf(stderr, "io_uring_wait_cqe failed %d\n", ret); + exit(1); + } + + io_uring_for_each_cqe(ring, head, cqe) { + nr_cqes++; + inflight--; + if (cqe->res != 0) { + fprintf(stderr, "cmd %i failed %i\n", cmd_op, + cqe->res); + return T_EXIT_FAIL; + } + } + io_uring_cq_advance(ring, nr_cqes); + } + + return 0; +} + +static int cmd_issue_verify(struct io_uring *ring, int fd, int lba, int len, + int cmd_op) +{ + int verify = (cmd_op != BLOCK_URING_CMD_DISCARD); + int ret, i; + ssize_t res; + + if (verify) { + for (i = 0; i < len; i++) { + size_t off = (i + lba) * lba_size; + + res = pwrite(fd, buffer, lba_size, off); + if (res == -1) { + fprintf(stderr, "pwrite failed\n"); + return T_EXIT_FAIL; + } + } + } + + ret = queue_cmd_lba(ring, fd, lba, len, cmd_op); + if (ret) { + if (ret == -EINVAL || ret == -EOPNOTSUPP) + return T_EXIT_SKIP; + + fprintf(stderr, "cmd_issue_verify %i fail lba %i len %i ret %i\n", + cmd_op, lba, len, ret); + return T_EXIT_FAIL; + } + + if (verify) { + for (i = 0; i < len; i++) { + size_t off = (i + lba) * lba_size; + + res = pread(fd, buffer, lba_size, off); + if (res == -1) { + fprintf(stderr, "pread failed\n"); + return T_EXIT_FAIL; + } + if (!memchr(buffer, 0, lba_size)) { + fprintf(stderr, "mem cmp failed, lba %i\n", lba + i); + return T_EXIT_FAIL; + } + } + } + return 0; +} + +static int basic_cmd_test(struct io_uring *ring, int cmd_op) +{ + int ret, fd; + + fd = open(filename, O_DIRECT | O_RDWR | O_EXCL); + if (fd < 0) { + fprintf(stderr, "open failed %i\n", errno); + return T_EXIT_FAIL; + } + + ret = cmd_issue_verify(ring, fd, 0, 1, cmd_op); + if (ret == T_EXIT_SKIP) { + printf("cmd %i not supported, skip\n", cmd_op); + close(fd); + return T_EXIT_SKIP; + } else if (ret) { + fprintf(stderr, "cmd %i fail 0 1\n", cmd_op); + return T_EXIT_FAIL; + } + + ret = cmd_issue_verify(ring, fd, 7, 15, cmd_op); + if (ret) { + fprintf(stderr, "cmd %i fail 7 15 %i\n", cmd_op, ret); + return T_EXIT_FAIL; + } + + ret = cmd_issue_verify(ring, fd, 1, MAX_TEST_LBAS - 1, cmd_op); + if (ret) { + fprintf(stderr, "large cmd %i failed %i\n", cmd_op, ret); + return T_EXIT_FAIL; + } + + ret = test_parallel(ring, fd, cmd_op); + if (ret) { + fprintf(stderr, "test_parallel() %i failed %i\n", cmd_op, ret); + return T_EXIT_FAIL; + } + + close(fd); + return 0; +} + +static int test_fail_edge_cases(struct io_uring *ring, int cmd_op) +{ + int ret, fd; + + fd = open(filename, O_DIRECT | O_RDWR | O_EXCL); + if (fd < 0) { + fprintf(stderr, "open failed %i\n", errno); + return T_EXIT_FAIL; + } + + ret = queue_cmd_lba(ring, fd, bdev_size_lbas, 1, cmd_op); + if (ret >= 0) { + fprintf(stderr, "cmd %i beyond capacity %i\n", + cmd_op, ret); + return 1; + } + + ret = queue_cmd_lba(ring, fd, bdev_size_lbas - 1, 2, cmd_op); + if (ret >= 0) { + fprintf(stderr, "cmd %i beyond capacity with overlap %i\n", + cmd_op, ret); + return 1; + } + + ret = queue_cmd_range(ring, fd, (uint64_t)-lba_size, lba_size + 2, + cmd_op); + if (ret >= 0) { + fprintf(stderr, "cmd %i range overflow %i\n", + cmd_op, ret); + return 1; + } + + ret = queue_cmd_range(ring, fd, lba_size / 2, lba_size, cmd_op); + if (ret >= 0) { + fprintf(stderr, "cmd %i unaligned offset %i\n", + cmd_op, ret); + return 1; + } + + ret = queue_cmd_range(ring, fd, 0, lba_size / 2, cmd_op); + if (ret >= 0) { + fprintf(stderr, "cmd %i unaligned size %i\n", + cmd_op, ret); + return 1; + } + + close(fd); + return 0; +} + +static int test_rdonly(struct io_uring *ring, int cmd_op) +{ + int ret, fd; + int ro; + + fd = open(filename, O_DIRECT | O_RDONLY | O_EXCL); + if (fd < 0) { + fprintf(stderr, "open failed %i\n", errno); + return T_EXIT_FAIL; + } + + ret = queue_discard_lba(ring, fd, 0, 1); + if (ret >= 0) { + fprintf(stderr, "discarded with O_RDONLY %i\n", ret); + return 1; + } + close(fd); + + fd = open(filename, O_DIRECT | O_RDWR | O_EXCL); + if (fd < 0) { + fprintf(stderr, "open failed %i\n", errno); + return T_EXIT_FAIL; + } + + ro = 1; + ret = ioctl(fd, BLKROSET, &ro); + if (ret) { + fprintf(stderr, "BLKROSET 1 failed %i\n", errno); + return T_EXIT_FAIL; + } + + ret = queue_discard_lba(ring, fd, 0, 1); + if (ret >= 0) { + fprintf(stderr, "discarded with O_RDONLY %i\n", ret); + return 1; + } + + ro = 0; + ret = ioctl(fd, BLKROSET, &ro); + if (ret) { + fprintf(stderr, "BLKROSET 0 failed %i\n", errno); + return T_EXIT_FAIL; + } + close(fd); + return 0; +} + +int main(int argc, char *argv[]) +{ + struct io_uring ring; + int fd, ret, i; + int cmd_op; + + if (argc != 2) + return T_SETUP_SKIP; + filename = argv[1]; + + fd = open(filename, O_DIRECT | O_RDONLY | O_EXCL); + if (fd < 0) { + fprintf(stderr, "open failed %i\n", errno); + return T_EXIT_FAIL; + } + + ret = ioctl(fd, BLKGETSIZE64, &bdev_size); + if (ret < 0) { + fprintf(stderr, "BLKGETSIZE64 failed %i\n", errno); + return T_EXIT_FAIL; + } + ret = ioctl(fd, BLKSSZGET, &lba_size); + if (ret < 0) { + fprintf(stderr, "BLKSSZGET failed %i\n", errno); + return T_EXIT_FAIL; + } + assert(bdev_size % lba_size == 0); + bdev_size_lbas = bdev_size / lba_size; + close(fd); + + buffer = aligned_alloc(lba_size, lba_size); + if (!buffer) { + fprintf(stderr, "aligned_alloc failed\n"); + return T_EXIT_FAIL; + } + for (i = 0; i < lba_size; i++) + buffer[i] = i ^ 0xA7; + + if (bdev_size_lbas < MAX_TEST_LBAS) { + fprintf(stderr, "the device is too small, skip\n"); + return T_EXIT_SKIP; + } + + ret = io_uring_queue_init(16, &ring, 0); + if (ret) { + fprintf(stderr, "queue init failed: %d\n", ret); + return T_EXIT_FAIL; + } + + + for (cmd_op = 0; cmd_op < TEST_BLOCK_URING_CMD_MAX; cmd_op++) { + ret = basic_cmd_test(&ring, opcodes[cmd_op]); + if (ret) { + if (ret == T_EXIT_SKIP) + continue; + + fprintf(stderr, "basic_cmd_test() failed, cmd %i\n", + cmd_op); + return T_EXIT_FAIL; + } + + ret = test_rdonly(&ring, opcodes[cmd_op]); + if (ret) { + fprintf(stderr, "test_rdonly() failed, cmd %i\n", + cmd_op); + return T_EXIT_FAIL; + } + + ret = test_fail_edge_cases(&ring, opcodes[cmd_op]); + if (ret) { + fprintf(stderr, "test_fail_edge_cases() failed, cmd %i\n", + cmd_op); + return T_EXIT_FAIL; + } + } + + io_uring_queue_exit(&ring); + free(buffer); + return 0; +} From patchwork Sun Oct 13 20:45:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Begunkov X-Patchwork-Id: 13833444 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7F0C82C7E for ; Sun, 13 Oct 2024 20:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852327; cv=none; b=ed4Sl8Zgj9XEvSYyVUeeAVIZjBGlcvUQVwBEkwR6XvXaxzMlC/MNLqG+JgPWuJzxNsptgI04NENTsaebsacAmRUf9UJGzMJmdcthNJ6CqwWkNd/o7rIbMaaqNHIgdr8oo1CSSSDi+phnVG4vznvUHaLZQQCN+8fAegy55iuzKlU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728852327; c=relaxed/simple; bh=idTE/ZoyUAY2FfIC7N922Le2YuZkQAgfND7CHavmnlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HN+ZXM17NPZLJhY0Cpp95aKGZ1Y27GnCPeHEH6G7doJIjKWYUEdnovg9Ia3/fU5I7L9Cu+/IA7Jf44m0HLtbaBDMBsB2D6/zLo141Kz/DGCr4iqh/I3vRjiS+qm2cMlSgqeIyMFQkDzWVTm5Rksw8DZKLzW13/gxL1/KFG75epA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a5UHjtKW; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a5UHjtKW" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a99f1fd20c4so197116566b.0 for ; Sun, 13 Oct 2024 13:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728852324; x=1729457124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/hcqGpvYvx9e+u8f8c8/gljD8DVc1Gr458BRRpYb63I=; b=a5UHjtKWfNrc4vvb5MYxlB2rB/AdT9k/kyXTnPOE/nD5a7hiWd+pTx0I83ThVePt8b ArKKlL9QpnM1O3cVWx5EXubCd+Enf+mF7ypIBo9fjBr933J30eFHo+lnligJ1bqC7fhL XCWGsFz+xpaL8S66sX72DE+0gCZ9U1d8Ifw990HuQFQSUM3FIu+o5vQlmuNKLlQMneIy yns1gMy8T28u4AtsZMupAc+7lsGZ0XmEj1tPodx71EcmkKb6NKi7NEkpyRGGsGRr1Hvx I7CcclMGVrJzPJ+7QEy9kX+Ijf3xTbRwevlnOjCRyz6sJKsW+SAXWOpISNRH2E9JjV/5 /9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728852324; x=1729457124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/hcqGpvYvx9e+u8f8c8/gljD8DVc1Gr458BRRpYb63I=; b=mdN0iO8AXEfK2Dk1Us/IDbRFuVyBfYxyzSdxZGwefEFu5b7rlxrofDmfoe96jiseM6 +lbKlZ7zY357EvvPKH7cE/JPSOgXJtrxIdNYwsFyz5kCEcTyG+DkizV5gxmc4HPFTuMw YjAmakAnngef8bFgW7TJDNOctV5rBZSzOv4CPW5er9ORJQ5FVjNQ6zgGvieOeqmC3faN AZvtXKPSYlxlOWiGLmLjY06+J9OZOR3A0oEFgAkpFhV1bFHTCm0cKYWdQnLnM18rY0xQ LubAsYytzTbaQ6DLWoqqJQG+TGgnzh5f+4DU0ryC9vz9xF+hV0FzV9KhdbfjkwGACGcm CJEQ== X-Gm-Message-State: AOJu0YwKKqMqgUFWDGWaR4Wlm/zXInum/Dw0dqGYDYVXbIsD8/o9e2yI GihqMcttXwr/UaK2RdOKrqeO9ugDlhMHwC/P2O1X0ZX3JovajLPxN9B/7g== X-Google-Smtp-Source: AGHT+IFy5WtDRpYZtQoU9sBeH//45mi9JUBHNKJAz1ObFJRFVvZZVpCIkHGY+IGDqsE0MR4J4TvZLQ== X-Received: by 2002:a17:907:3e1c:b0:a99:f3fb:f88e with SMTP id a640c23a62f3a-a99f3fbf984mr410631766b.41.1728852323523; Sun, 13 Oct 2024 13:45:23 -0700 (PDT) Received: from 127.0.0.1localhost ([85.255.233.136]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99f86b689dsm186078166b.181.2024.10.13.13.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 13:45:22 -0700 (PDT) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: Jens Axboe , asml.silence@gmail.com Subject: [PATCH liburing 3/3] man/io_uring_prep_cmd_discard.3: add discard man pages Date: Sun, 13 Oct 2024 21:45:46 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Pavel Begunkov --- man/io_uring_prep_cmd_discard.3 | 60 +++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 man/io_uring_prep_cmd_discard.3 diff --git a/man/io_uring_prep_cmd_discard.3 b/man/io_uring_prep_cmd_discard.3 new file mode 100644 index 0000000..75e25bb --- /dev/null +++ b/man/io_uring_prep_cmd_discard.3 @@ -0,0 +1,60 @@ +.\" Copyright (C) 2024 Pavel Begunkov +.\" +.\" SPDX-License-Identifier: LGPL-2.0-or-later +.\" +.TH io_uring_prep_cmd_discard 3 "Oct 13, 2024" "liburing-2.8" "liburing Manual" +.SH NAME +io_uring_prep_cmd_discard \- prepare a discard command +.SH SYNOPSIS +.nf +.B #include +.PP +.BI "void io_uring_prep_cmd_discard(struct io_uring_sqe *" sqe "," +.BI " int " fd "," +.BI " uint64_t " offset "," +.BI " uint64_t " nbytes ");" +.fi +.SH DESCRIPTION +The +.BR io_uring_prep_cmd_discard (3) +function prepares a discard command request. The submission queue entry +.I sqe +is setup to use the file descriptor +.IR fd +to start discarding +.I nbytes +at the specified +.IR offset . + +The command is an asynchronous equivalent of +.B BLOCK_URING_CMD_DISCARD +ioctl with a few differences. It allows multiple parallel discards, and it does +not exclude concurrent writes and reads. As a result, it may lead to races for +the data on the disk, and it's the user's responsibility to account for that. +Furthermore, we only do best effort to invalidate page caches, the user has +to make sure there are no other inflight requests are modifying or reading +the range(s), otherwise it might result in stale page cache and data +inconsistencies. + +Available since 6.12. + +.SH RETURN VALUE +None +.SH ERRORS +The CQE +.I res +field will contain the result of the operation. See the related man page for +details on possible values. Note that where synchronous system calls will return +.B -1 +on failure and set +.I errno +to the actual error value, io_uring never uses +.IR errno . +Instead it returns the negated +.I errno +directly in the CQE +.I res +field. +.SH SEE ALSO +.BR io_uring_get_sqe (3), +.BR io_uring_submit (3),