From patchwork Tue Oct 15 18:51:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 13836980 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29845D1F9BD for ; Tue, 15 Oct 2024 18:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=1wp0G8prSPJVXGJ7JVRFymoijPyck/04+wrCIyKuPSY=; b=m69e0X3GTOGgiMCWiaG8i+5ZlA TbfMcUovsvEkfUqFcc73FuQc53Wt6kpqzOsFEp5lPLRtHE4HjUxrgCulup3/obx0ezzW5G724sVLb X2vtmWv2wg+ulpcC6kdtRQw5SF6GnMAwlihUOV5osia/NjYx7qJu1idNnHU8ji8hefkL4a+/ihxul /dQkjP5kZOUFyV9e4o0AkRyQJ3LIh92XHFGGtH5SpFD27BgXzfL454y9iTeRwdwsglGMEnHVn1IGj OlDZS0bydR6wTsAarvIXbygzimG23lCVlmzdBrSin8ssnVrpy//zcNsxiDqsnglNsPbiNtYD6y78Y 0CKhB2Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0mhL-00000009IWv-2VwS; Tue, 15 Oct 2024 18:55:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0mdr-00000009HYT-1iZF for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 18:51:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58019DA7; Tue, 15 Oct 2024 11:52:04 -0700 (PDT) Received: from usa.arm.com (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DA9DC3F58B; Tue, 15 Oct 2024 11:51:33 -0700 (PDT) From: Sudeep Holla To: ARM SoC Team , SoC Team , ALKML Cc: Sudeep Holla , Arnd Bergmann , Cristian Marussi Subject: [GIT PULL] firmware: arm_scmi: Fixes for v6.12 Date: Tue, 15 Oct 2024 19:51:28 +0100 Message-Id: <20241015185128.1000604-1-sudeep.holla@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_115135_513163_EB392432 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi ARM SoC Team, Please pull ! Regards, Sudeep -->8 The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-fixes-6.12 for you to fetch changes up to da1642bc97c4ef67f347edcd493bd0a52f88777b: firmware: arm_scmi: Queue in scmi layer for mailbox implementation (2024-10-14 21:36:46 +0100) ---------------------------------------------------------------- Arm SCMI fixes for v6.12 Couple of fixes to address the issues found and reported on Broadcom STB platforms following the recent refactor of all the SCMI transports as standalone drivers. One of the issue is that the effective timeout value is much less than the intended value due to the way mailbox messages are queues in the mailbox framework. Since we block or serialise the shmem access anyway, there is no point in utilizing mailbox queues. The issue is fixed with exclusive lock on the channel when sending the message. The other issues is actually non-issue for upstream, but the workaround is just changing the link order of the transport drivers which enables Broadcom STB platforms to run both upstream and custom downstream kernel without any device tree changes. So pushing this to help them test upstream seamlessly as it has no practical or theoretical impact for others. There is also a fix to address possible double freeing of the name string in scmi_debugfs_common_cleanup() when devm_add_action_or_reset() fails. ---------------------------------------------------------------- Florian Fainelli (1): firmware: arm_scmi: Give SMC transport precedence over mailbox Justin Chen (1): firmware: arm_scmi: Queue in scmi layer for mailbox implementation Su Hui (1): firmware: arm_scmi: Fix the double free in scmi_debugfs_common_setup() drivers/firmware/arm_scmi/driver.c | 4 +--- drivers/firmware/arm_scmi/transports/Makefile | 6 +++-- drivers/firmware/arm_scmi/transports/mailbox.c | 32 +++++++++++++++++--------- 3 files changed, 26 insertions(+), 16 deletions(-)