From patchwork Thu Oct 24 06:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA67BD0BB61 for ; Thu, 24 Oct 2024 06:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=40/UnIWeLTa0TAoUnvMWcwUGsrAyDJptNdjU386k0w0=; b=3B3QdJ+p/pjBAKbt9EhqajCgiK IRW1YLcVWB/MPh8pBOnLYsjmKfGgLekjAzRrrbIYp4Qx1xNTCV54DlDJk91H/DNtlEl/kzqnbvvJn KrRAhMmsx94DK6tvf9OF9fIw+AiG6k2wRIc9MZvEhPaxlmSQ8ymxFLqCrxGdJqlbvXd3d3Dn+swNb 0qg8bS0q2qWWgqCdy6pCKJEEWjzOhkzzqfN1Hc3Udkd7KFXhTJPt+yRDFN6Js2+HejJ9WdPqyvkMT w5P+h8i6t7wd+JIPcrvd9NwWXDYImREQOW1B3Afdow3w24r9OqcmOl1rJmO18GOm9xtBAlQ2gTVpC jeE5/5Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3r89-0000000Gstn-2jpT; Thu, 24 Oct 2024 06:15:33 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6b-0000000GsRc-2amq for linux-phy@lists.infradead.org; Thu, 24 Oct 2024 06:13:59 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-6e3705b2883so11402387b3.3 for ; Wed, 23 Oct 2024 23:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750436; x=1730355236; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=S5iA2AnUVrc0O90c8bMEmAoqaAOjPdur9H2qrQVSoQPNOjbEexy5sCUCwqc4eTOhpe ZPFy+svQphhU7lltTDVlvc4HvNm0eidlgMKQ4ZAct7ZctrPEuWQmZZBYRf4yYtXwlcVD LdQMCkMY7lJdn0Rbc2AS+hD9mA8TEodr0VZJgqru62zChy1s2Fez42w1A8Tt8mEZElmr 00Exta0e/vWfsdejyxKdiKHi56O4056WRN6E35SveeXlOpt0j14n2bdYpyaGnw8abDJm ykppa4LlGcGdd3J2Wt8do63Q9hwHTv2hnNrjcbU5hHshsGaJzQMWfKz2kIDfcQ3+gu5y HeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750436; x=1730355236; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=Y6r+XY5SZT1sJqsPGbqF9LzlxitKlpARLpLpLF404u8WSnHPWbyKvURSD5e6cSbs6K AA35dPIXjJC/g6XMblZuSHzuHGMHHem/XB9H796upnTtVNKh8vmZ/gZoh4KwuumqsKGj p/Q+pW81B9pnezCsG3NnBzOsdhUO2MHa0Rshk5v3/XI0L5EzrP2kP5tdBmZxnU9exxfr je0EEmzFsC8Y3RVJenxJPQV9rEaemwGgTg/5cTcmwdtESDWhv0zte7R0rSzC886P+/3W 17OoF+Z5gSgNGt5esFqt1LrCNVXaQ3qOiJfqolgXv7jz+zw7DkuzICbM+xxTgGlw5cDQ 0glw== X-Forwarded-Encrypted: i=1; AJvYcCU3ymNt1UG5Jyagq5Vo5hdtr8ahIuM9bNzpr5Uz5j1SLudPE1bfcYV5v8LbSaljFPEoTs2qXouO3X4=@lists.infradead.org X-Gm-Message-State: AOJu0YydrJyK1mPP7lgvR4ozy4qW/3jqSC9S9rzWYhFMNe/eS9tsKUMS 3dZESI1rJVc8uJLLLlebXQnHJ5JslwWzDJ/iG8mgxKWhKs+8D3eNnDM5z+Px03/JMW7Xo/cN9xe fNdipfH8xjicnJw== X-Google-Smtp-Source: AGHT+IHCEMkQ2RfyYdNtjaLmn7Q1IV6vv3d2IoDuURVXiH0KtdFNDJTv0BNk9TxANKxuJUTxCoodn7NIA1qQz7g= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:6811:b0:6e3:19d7:382a with SMTP id 00721157ae682-6e85813d7f5mr589267b3.1.1729750435897; Wed, 23 Oct 2024 23:13:55 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:42 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-2-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 1/3] drm: display: Set fwnode for aux bus devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231357_684243_01B05953 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: "Nícolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Reviewed-by: Thierry Reding Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent = aux->dev; aux_ep->dev.bus = &dp_aux_bus_type; aux_ep->dev.type = &dp_aux_device_type_type; - aux_ep->dev.of_node = of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); ret = device_register(&aux_ep->dev); From patchwork Thu Oct 24 06:13:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B08ED0BB61 for ; Thu, 24 Oct 2024 06:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=fQTRtAeYteD8NzgUaM0VbaobARTiyzG5qP3NTBRlenU=; b=KkAWVmPHpgtDW+sm2JsG/E/230 KnxFEKLEXi2ASLgojrQLAtjpdU1J8Gq7az3kaMbrpycDwElUWXAF4cpkowBU9okdZdH4lIKUAZMZN +JiHjy0SqcJUl669zuoXSA6rN+au+H//K8Kw4Kzp6g5wbMyjWPj8pP5FAJ0HgNJX2TkLZs1mRBkh3 YI8ZobTuEF3v0Co9f6IMcjQOCsw7XBw9cSToVSs3TbLGicF2ExhLONLk+Al/uG+HK2U/tSudE+OOz rsA50ieiY8Gq/+OhOIdwSSqMBC/fF83YkwxyiIGsvFE05t3RgXa5Peieya+Xq6AsiOI6AdUNaBYnH vVTwkdZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3rBC-0000000GtSZ-03jc; Thu, 24 Oct 2024 06:18:42 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6g-0000000GsUD-2SLM for linux-phy@lists.infradead.org; Thu, 24 Oct 2024 06:14:05 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-6e3497c8eb0so7635827b3.0 for ; Wed, 23 Oct 2024 23:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750441; x=1730355241; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=IXgfvbYsY1d1Uw/bAd3dB6/xLCclHbu32zXuO3GvjhL7npcJRsFYVrb+fGvlKoBRN0 FfDjNvnVGTCvrlf7gAWFUQGCSA3HMLGBI4+JoNBSWE2RSeWsBr8eIpg3OYpWH6xUjR19 qvBX8h9RuXV04oBKHr4cpzp/5f0ycG20QYlgBmZEUlgDw1P2Q/K1uDKQZ6iwHJ0AzGxP KFGnto3GNLU0Lb642lPh/S9Mgf0mNrjQNwphZWJdD/OsA/C7WSuKPD51+W9GlViGwvps W/Jvo9ZlyG8EdIHYjrRJ8rYQyolFK2MZ2wSKCsV2KAG0GMcKwu8prR31KPEKJyqTrH4v Vk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750441; x=1730355241; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=XSnj9jjyZs48hARaYbnZroCPjA86+yMSoy0O7J8Zi47a8TJ8linmxX4/eGEAHhhAno jWddR+WoHXLwccxkXw4kco2CwKynS7BFQwlPtktHZKVEZPwNZegarKpKtqThE6zQVoNE FLKsqXRUPOykm6T+Iv1oElR6aJB0AXhnj06Gf74dXe69+UiesJ4JrivJ3CBfwsPffFGx 3u089NzfCFGzQr2zR2IigoFGZt/6rJSG6AUJMSzsIAudY/oDiWKCVIqWTmAwEW528y2W 0BDisLywra6miqRJK3qZkk4qI26AfyHx22Qxwbbx4PJ9Or6Dum84HcTKbxfE8xKTvLHc yl8w== X-Forwarded-Encrypted: i=1; AJvYcCX/SE0yrboQ2AYjCk2afLoYVdhIzKvesUajU89wzW9fZDk5n+1jtYqlqfsrCsetdwuWHevsb1qrQKU=@lists.infradead.org X-Gm-Message-State: AOJu0Yz0Iwu+iTt2P3tg8qcmMxAmcDhLJpMK1iTNchASjbg6+mLjUmkO BzOJ7FovimK93PpKCWYc9h4gkK0ZPZBWzBNEcS7JLGBWRrTWLHgImIWF1Rsplm/WSHX36oBzzXD +hNe2k7krVYNYiw== X-Google-Smtp-Source: AGHT+IEvWKI797qzaVIyJQytUKUTuDrxqDTilc69F1bH77+J3k5wYMBvLRY6cYuzVgsPwwCo2eftygSjpmQuXoI= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:9c06:b0:6e3:c4cb:689b with SMTP id 00721157ae682-6e866350bbfmr483267b3.4.1729750440665; Wed, 23 Oct 2024 23:14:00 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:43 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-3-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231402_648879_6EB4A581 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter Suggested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Acked-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index); From patchwork Thu Oct 24 06:13:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4692D0BB5E for ; Thu, 24 Oct 2024 06:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uHtTVoTi+csgoP2FyF09uv5nfZA+dh93Ln8kBEKxtCc=; b=ICkJ/AeBhPAsT+a3IrXcezfWkA I2SBh8WdWiKdJHVKf2t1Iv8FVqi/w24y94pyPt6Z691AyV2cDOZ/P+CEOZyzs7X4y6dqkmQxYf6R7 KzMuX8xyyGVo7J/fa/OGY3o5yHKSNEhFU1ttnVHp59IINlkbedjeUZEwqXTT26u691xsGp6MVC2wG kp99eoUlhLG3kRe3w2xofmzMtXclPP0hDralwXXewo9tCOErgXbqSCkeLNP9p0xpr6y4ubGbK2zEZ l+ozxLQpOVgZlY6J03g+bDAJbDdT90QoZpTysMuNOnuW7rbiNGgTpsg2W/QEynpsK5OD/s5NTDsm8 E8vahpBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3rBC-0000000GtSp-1IPp; Thu, 24 Oct 2024 06:18:42 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6l-0000000GsY0-2Mru for linux-phy@lists.infradead.org; Thu, 24 Oct 2024 06:14:09 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-6e31d9c8efcso10585367b3.0 for ; Wed, 23 Oct 2024 23:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750446; x=1730355246; darn=lists.infradead.org; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=xLakp9LDgPw6u/JgaXLpCgqQgG97e1imMYD3tlOJh3yzwVzXsDBUFJazeDdsnYaa18 I3TEhbYtt8mibexjODfu5FZYPGwjG/a/g/y46yKd6XuDJQ0SCblBTrH+paKoTVMrbkcd optt0D0JEVQbHUNo5LneZE+7ABdZ/BwbCnd7ZlQR+RaiFuvyTo8FycOdmV29InVyGEQB 5/Da8JnZFPm1OJunqZqHesEt9cP6uRodTFVFNOlR2RLY1OsZhD2D99tO2hXIYQR9lWOo 9FdCDuzp4xzqABDPeoOfO075gM76IicVhnBAJnSRQsSJAwSioytaw1GSoUffJJXFvLDP swGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750446; x=1730355246; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=TTxHvZwz4SCeUvYLX/SeAogEtsAUU/w/3ceFMlwaoiFEGCuM2cUiXrXypVIDWcvJuI 5dMl3/xk3bTBWk5RWMonHX3lpnscMc5NGctUgF6w1MhegejV43nayHK+cJDEwJojyZxP jfQP4Uj5H4j68bZ5FGnleHQ22IzcQw93NHLMzSm3tvXQwrOqSPXCzIqqsibIrXclrqnK wx3axLLTmeQLYd0brcDy+97OiJjNJC5ma5PHgZQmDXesiPHO5I6q2Wj3HN8UH7Sv8l2w 6kav1vu3V8ibnR8XtlLmzecrql1jrCNHZ/Q1o6nDXVPn8N+d7ugLXI+SvCJnr4oPBUpX mkfg== X-Forwarded-Encrypted: i=1; AJvYcCXE/0COPX78OJIr4LfspP13aR/3hjBQgmuivwjxTkHV86o7KLv/39w226X5H93QYAp+cUYQ5o+IFbo=@lists.infradead.org X-Gm-Message-State: AOJu0Ywog4kbqpY4Vs0xVX2TN+mvaOVw3i+iWBxt+lW1gIzIe2cyU7r/ sPxXYeSxvMhSfp5i30qanOT6Z6iT7vULDSGagoJ8cKaPGVqaMNKyvFPR9/rQrwd6yrWlyW9Y2B1 QQppftJlpaEbuwQ== X-Google-Smtp-Source: AGHT+IEJXaAAeZpuDAkTsefFXLL2kex4B2AlfwjdclQcvPn636A6m5nX8BurNhgR4ykV7U+QaaWd5sb2nHuey3k= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:3749:b0:6e2:4b3:ee22 with SMTP id 00721157ae682-6e866359b6fmr171667b3.6.1729750445961; Wed, 23 Oct 2024 23:14:05 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:44 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-4-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231407_626056_C785B63F X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Signed-off-by: Saravana Kannan --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index a4c853411a6b..3b13fed1c3e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2181,8 +2181,8 @@ static int fw_devlink_create_devlink(struct device *con, } if (con != sup_dev && !device_link_add(con, sup_dev, flags)) { - dev_err(con, "Failed to create device link (0x%x) with %s\n", - flags, dev_name(sup_dev)); + dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n", + flags, dev_name(sup_dev), link->consumer); ret = -EINVAL; }