From patchwork Thu Oct 24 06:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13120D0BB5E for ; Thu, 24 Oct 2024 06:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:From:Subject:References:Mime-Version:Message-Id: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=zO7u+DlOeCbPB1XgeNbybFHTdd IKssTl/sEQ7mGkqNNPlG4vDN/lVoiN89wRusGx+p3RiLVLOS91qVBYqKsrM0+6LFspVpERWuE3sOT NgrGJU+XmkTRNzjyS80AfEVDVrcUDZDNIv3lr5h99/ZCrgChaN6+ofpcKew6GHCePfqCs058Qd7M1 qhK839VvLWWJbQe7AEi1oVsd2qESjdQ/HBXWLbgXpQFIZOYlWNtD53gH8fpaGJ6Ghh9WZweQpw6dZ u6NQ1V9aONhZwx1JjtFVEgkXleU6rb8cn2THGnhPTCQvdR/xQ+JKQGFRpH77s/SUjfNlQo0RfOm5E 6RtvBLvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3r9f-0000000Gt9X-0riA; Thu, 24 Oct 2024 06:17:07 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6b-0000000GsRb-2Ysa for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2024 06:14:00 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-6e3d660a1afso10478327b3.0 for ; Wed, 23 Oct 2024 23:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750436; x=1730355236; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=S5iA2AnUVrc0O90c8bMEmAoqaAOjPdur9H2qrQVSoQPNOjbEexy5sCUCwqc4eTOhpe ZPFy+svQphhU7lltTDVlvc4HvNm0eidlgMKQ4ZAct7ZctrPEuWQmZZBYRf4yYtXwlcVD LdQMCkMY7lJdn0Rbc2AS+hD9mA8TEodr0VZJgqru62zChy1s2Fez42w1A8Tt8mEZElmr 00Exta0e/vWfsdejyxKdiKHi56O4056WRN6E35SveeXlOpt0j14n2bdYpyaGnw8abDJm ykppa4LlGcGdd3J2Wt8do63Q9hwHTv2hnNrjcbU5hHshsGaJzQMWfKz2kIDfcQ3+gu5y HeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750436; x=1730355236; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ULy+zyN1BivKyLwzuPRCl/8UJCnpTGDPYrNtb9eDcL4=; b=fjErAy2ROviI0OzMEgPTRcFJ+WOaBNp2v0txaar8mv/BXgmuWIgHYXmbD9tuQONUGj 1JAm/8/6Lc3e36zEA8dYM9DKSFaag2o5ApxdKJRBWqmIDt0T2tIZ6EL5yxYyxC9sHxFd AYXgTkZ8VkGyiVNGI97MXssDswk1YIyTUJybpYcx1rGDQ+08EjoAijaCM0a+p4l8qgDx xZcYXFsLozucgPszzQBeTIvkaSQ7kfer18LyhEm7pm+mCb29ole8bjJeXK3VxeShCx1M YKU0KULIcqdDLJ2uod3VPKklG6prvY3/AfXLo9CI77//WKv5+cVoK+QhwTinKrN+ifM1 YZjw== X-Forwarded-Encrypted: i=1; AJvYcCVxKNBKdmfUCfEPqvMAWp5HZVwwz94hUicxT9gBfynEgf+AjljqVZ78uObxRfsOsm8iBpnYew0Uv08+grOjqxxU@lists.infradead.org X-Gm-Message-State: AOJu0Yws8V/DW0PUkY1cvlGPQvcocywsbwvzKQZwkKD2Jmd+ICsy0DL4 y2SuhYF+L5v6XvCn2YNnM0RDfO4AU5itiNtoazBM7ktZtQ4QyS91hsdz3zL0XqgTtUxjAmbWW6c NN/5/yxFYd2alGA== X-Google-Smtp-Source: AGHT+IHCEMkQ2RfyYdNtjaLmn7Q1IV6vv3d2IoDuURVXiH0KtdFNDJTv0BNk9TxANKxuJUTxCoodn7NIA1qQz7g= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:6811:b0:6e3:19d7:382a with SMTP id 00721157ae682-6e85813d7f5mr589267b3.1.1729750435897; Wed, 23 Oct 2024 23:13:55 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:42 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-2-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 1/3] drm: display: Set fwnode for aux bus devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231357_681000_5499548B X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: "Nícolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Reviewed-by: Thierry Reding Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c index d810529ebfb6..ec7eac6b595f 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c @@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux, aux_ep->dev.parent = aux->dev; aux_ep->dev.bus = &dp_aux_bus_type; aux_ep->dev.type = &dp_aux_device_type_type; - aux_ep->dev.of_node = of_node_get(np); + device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np))); dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev)); ret = device_register(&aux_ep->dev); From patchwork Thu Oct 24 06:13:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848352 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D79C2D0BB5E for ; Thu, 24 Oct 2024 06:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:From:Subject:References:Mime-Version:Message-Id: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=z6wo+OJpr4pRwmMe/HsBgC5tc9 sQXdQzB962mGxeZGieoO2Qaila5vkYVQyvnBoniSE+CaHa6QD1X6k+mxz4uygOoGX1oUyf9N/Rr9h F4dTE5dQzmrXcKO5X3IcTQcbxJ8FGonraEzKiEQoziRk/zIceyhfZwyAwGaPhDyHpi73RX8yeh/IT D1euKbGptiJNY2BYEVxTgxIrfIPbngzsaHF5gd+KwGpZGffxRVDCBapXYJQmjLVxjfbReFZHuQVef DXyHjJOgPlV2/YGq9gcG7Zz0dZF9T5rJfx2wKm7EeAjAiB56VXdvm5UhsEr+tXLxxmGkC1/BrPNgx +dkCx8SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3rBB-0000000GtSB-1s7f; Thu, 24 Oct 2024 06:18:41 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6g-0000000GsUF-3CTm for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2024 06:14:05 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-6e3497c8eb0so7635837b3.0 for ; Wed, 23 Oct 2024 23:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750441; x=1730355241; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:from:to:cc:subject:date :message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=IXgfvbYsY1d1Uw/bAd3dB6/xLCclHbu32zXuO3GvjhL7npcJRsFYVrb+fGvlKoBRN0 FfDjNvnVGTCvrlf7gAWFUQGCSA3HMLGBI4+JoNBSWE2RSeWsBr8eIpg3OYpWH6xUjR19 qvBX8h9RuXV04oBKHr4cpzp/5f0ycG20QYlgBmZEUlgDw1P2Q/K1uDKQZ6iwHJ0AzGxP KFGnto3GNLU0Lb642lPh/S9Mgf0mNrjQNwphZWJdD/OsA/C7WSuKPD51+W9GlViGwvps W/Jvo9ZlyG8EdIHYjrRJ8rYQyolFK2MZ2wSKCsV2KAG0GMcKwu8prR31KPEKJyqTrH4v Vk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750441; x=1730355241; h=content-transfer-encoding:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pXMUNc/LORv2j86/u57jzQlk6FOM7Zoz5+8UmtPcmgU=; b=CQlf2M0vwBsZqjEKU+Y99k6768NbkYZ8Dox9lY9KPFlLa1/2KaUHXE78G/SlMkr7at PwyWaR3apRzHdxesLPc6WT14Yf8vXGYf4BzfUI3r31EZE9S0HgUxAyJFjBNiprl69+Gs tjZcTyZXCY499zkQIfE7Q2GInphdk5FaU9nJ0Dhfeloset+EcuIm+1+L9EVUKZIaf/DM MEvc5zdBePgEM3Tv9fWgdOlCeBmH1dPHeeM0FIDa/tmWKtPt3jMGqAhSRzgEx+Oyhabt BGdraCGvRlWSAP5uigHj/GDkvobvq/eGkI7/53Um8GVJ1QJv8P5rK7tadCl6x2rtvcyA XHwQ== X-Forwarded-Encrypted: i=1; AJvYcCWTtZChYpvniqyWe11JedYTsaAAGRWcFF2Glv1YW/S8MDOKiEOWhTBWsI2/d+yosiJ5RvLIwh8e29aVil70O2R7@lists.infradead.org X-Gm-Message-State: AOJu0YxdnAtBn1K179oM1QJou0/9gcKZKGGJRO6THBz7zPlFdX/VVTkQ To+M5MyVnHUdrAXFtH6MSqw7hpt27PbUowD+NgmafLTFdYZ0USVjhvFhGogygfUvbp4Q1lS9P0f +O0VFvhbK/0EEoA== X-Google-Smtp-Source: AGHT+IEvWKI797qzaVIyJQytUKUTuDrxqDTilc69F1bH77+J3k5wYMBvLRY6cYuzVgsPwwCo2eftygSjpmQuXoI= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:9c06:b0:6e3:c4cb:689b with SMTP id 00721157ae682-6e866350bbfmr483267b3.4.1729750440665; Wed, 23 Oct 2024 23:14:00 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:43 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-3-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231402_814434_C99ECFE9 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter Suggested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan Acked-by: Thierry Reding --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index cfdb54b6070a..0a2096085971 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -543,7 +543,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index); From patchwork Thu Oct 24 06:13:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13848353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A289D0BB63 for ; Thu, 24 Oct 2024 06:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=irQl4h255OnLo1GnNqtlgW3gkD D8oK2TgfEdntGhIj0x+QwN4PQ4Oka+Tm2cqh7eAn5ueVf2wzPtqnhjREJzw8ZlneOXWJ+xlNN8g1P ah2Jg2MqZqJRRYZD2FoLpQfLJkCiL/HTr/KtJsx4HcNw8H3VU6ANi9a8QjeADi2AUJJCdqFrHueXr xt/96F882AVyraurTvdN0nfezF0aRUGggy3R8Nic3qzylmT7LxBR3rwOxgSIGamqALIiU0WgA5KTD +EyV1XSawVhelvKBT2kZBMR1baPyLyCRItefKETEuykA3kBlrAGi94lVHGf9yivaCAsyBR+K3hj/i 6TZfH9gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3rCi-0000000GtlV-3QVB; Thu, 24 Oct 2024 06:20:16 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3r6l-0000000GsY2-2UMS for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2024 06:14:09 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-6e0082c1dd0so11563987b3.3 for ; Wed, 23 Oct 2024 23:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729750446; x=1730355246; darn=lists.infradead.org; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=xLakp9LDgPw6u/JgaXLpCgqQgG97e1imMYD3tlOJh3yzwVzXsDBUFJazeDdsnYaa18 I3TEhbYtt8mibexjODfu5FZYPGwjG/a/g/y46yKd6XuDJQ0SCblBTrH+paKoTVMrbkcd optt0D0JEVQbHUNo5LneZE+7ABdZ/BwbCnd7ZlQR+RaiFuvyTo8FycOdmV29InVyGEQB 5/Da8JnZFPm1OJunqZqHesEt9cP6uRodTFVFNOlR2RLY1OsZhD2D99tO2hXIYQR9lWOo 9FdCDuzp4xzqABDPeoOfO075gM76IicVhnBAJnSRQsSJAwSioytaw1GSoUffJJXFvLDP swGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729750446; x=1730355246; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RirtA7EgN4fQOOKugcSYCvUnz6k6FXA4tnIv667SP2U=; b=UWhlRXj7ZIHGuIoP7h1ABI50RusAvcFSon4z5pSrcdQgkqV0oU4y5g08pdiqBveR3Z xaQ9vd4+tKzSSh7953dByuvxtuvXRAmiGAfGhOiX/Y+MGH6+ywW9uBNFDHfEF03Hxthh MXQ89kjWobX1+btEyUUWqHv0+bkRHWGUTRF3ghcP4T7+m/TC3fob0knGtcalIilwtY61 c0j4mw6+8i4gozd0JlLXC8PG8uaFVoyhcsGwZf/5PxRTPvSPhpTGMen92s3mGNIlaW0l /tuOAaI4esTHHbTS5+0Zr7wUVOpzexbW7pDCo+6yFtrLepAVmdNsy+RhOMjTTq384rVc 4oRA== X-Forwarded-Encrypted: i=1; AJvYcCX9pGIa2oaXQtGKrYBGH4UJgm0hcHHQ07QC3YgirspXFurTjtxAb9v4ap9GkoNTNT2cgzV+EyJVIBpOT//z1Z/k@lists.infradead.org X-Gm-Message-State: AOJu0YzMfByjODnap7CyM6ShcF2zllsQM2xlq7thKNtGn4zRCifzGL2/ XT1dZT00s/D6nlVZhntOR5pmp4nanz0zl0o8PVTVzAXqDfGE0rY3e61xzYjJ2XcajTyNQqucIzH DFFGduDKTO+1gBw== X-Google-Smtp-Source: AGHT+IEJXaAAeZpuDAkTsefFXLL2kex4B2AlfwjdclQcvPn636A6m5nX8BurNhgR4ykV7U+QaaWd5sb2nHuey3k= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:965e:f81d:c9fb:b352]) (user=saravanak job=sendgmr) by 2002:a05:690c:3749:b0:6e2:4b3:ee22 with SMTP id 00721157ae682-6e866359b6fmr171667b3.6.1729750445961; Wed, 23 Oct 2024 23:14:05 -0700 (PDT) Date: Wed, 23 Oct 2024 23:13:44 -0700 In-Reply-To: <20241024061347.1771063-1-saravanak@google.com> Message-Id: <20241024061347.1771063-4-saravanak@google.com> Mime-Version: 1.0 References: <20241024061347.1771063-1-saravanak@google.com> X-Mailer: git-send-email 2.47.0.105.g07ac214952-goog Subject: [PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Saravana Kannan , " =?utf-8?b?TsOtY29sYXMgRi4g?= =?utf-8?b?Ui4gQS4gUHJhZG8=?= " , kernel-team@android.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241023_231407_643335_EFE2E916 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Signed-off-by: Saravana Kannan --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index a4c853411a6b..3b13fed1c3e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2181,8 +2181,8 @@ static int fw_devlink_create_devlink(struct device *con, } if (con != sup_dev && !device_link_add(con, sup_dev, flags)) { - dev_err(con, "Failed to create device link (0x%x) with %s\n", - flags, dev_name(sup_dev)); + dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n", + flags, dev_name(sup_dev), link->consumer); ret = -EINVAL; }