From patchwork Fri Oct 25 19:21:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Houghton X-Patchwork-Id: 13851427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D92D149E8 for ; Fri, 25 Oct 2024 19:21:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49B0A6B0082; Fri, 25 Oct 2024 15:21:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44B586B0083; Fri, 25 Oct 2024 15:21:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339726B0085; Fri, 25 Oct 2024 15:21:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 10D896B0082 for ; Fri, 25 Oct 2024 15:21:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 662E3C0F16 for ; Fri, 25 Oct 2024 19:20:50 +0000 (UTC) X-FDA: 82713092112.21.22ABFF3 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf23.hostedemail.com (Postfix) with ESMTP id 00F1414001B for ; Fri, 25 Oct 2024 19:20:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="uqPf/eEG"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3pO8bZwoKCDMYiWdjVWidcVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--jthoughton.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3pO8bZwoKCDMYiWdjVWidcVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--jthoughton.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729884017; a=rsa-sha256; cv=none; b=HnVMM5/VytPti733oMwSFb3IMmrhrpWXM47atJVVIvL+0wVTYOddVSY7AxUP5SK3v5JG2Y xT8xQwQTR/wrSYmdt/ZV23FKMhvieqmIrJ/r7AylhxhHxrK3SDf0sW6vrUaRW8Iyl9I61P FEO9ApNM8rLjb2aBbzMM9Gad28zUlFg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="uqPf/eEG"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3pO8bZwoKCDMYiWdjVWidcVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--jthoughton.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3pO8bZwoKCDMYiWdjVWidcVddVaT.RdbaXcjm-bbZkPRZ.dgV@flex--jthoughton.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729884017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K8NR4IYBByYjHNBssdMWQfaKh03I9jRdtJJnrSyn6yE=; b=MFCxS9FK7i63pofxq9cHz/O7fgVSb8BI3TMNplyzDwoNPfI13VumjduqiBekoy8pqkZIR8 osSXNsOyj7FVKuun5KLThv46Y2a6H4WPke31nbcj+EbuEY866r3Oz7f96cNFBYOzv5tymV CwDCmzDpQiQOsF+PghOj7AQ7gRHDd48= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e32b43e053so36304427b3.1 for ; Fri, 25 Oct 2024 12:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729884069; x=1730488869; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=K8NR4IYBByYjHNBssdMWQfaKh03I9jRdtJJnrSyn6yE=; b=uqPf/eEGEDu50yHIU31I4P9zx9bsq49d4jeAx3JDbeyayaJfHSNKsLtt2t2F26MZL0 NHtYz9sNH4akk58y0XII4aWfVuJdArdAvY3Mn6+YkleK5HXGlalYyyn96Y3P/Eqta/+z 0oDzVaET3I/m6agt60V/M0YzXGSPIdZsFf681UZzoz3iP7HmMX4Dobve+K4sobyyfBO+ m8SKp3IzZwEYHtU/UX82v9ixJl8UYCYUlSmsRIssLFxg3JBWS1W8Skjtt+dFATcsQ7+Q qYsD87OeUfSM2ih46fJcix1i/AsVljrJIKMhv+x3bzOxiuEqNSJclksArWxo48xKMyeW Ai5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729884069; x=1730488869; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K8NR4IYBByYjHNBssdMWQfaKh03I9jRdtJJnrSyn6yE=; b=aASujuyxze0hQv+Cd9td4exWtcz7xhXDNBC+3sSQNcaw3IRxkD4Aar0bP1hYRXTadf g6qe9seKFs1oQohN9UgmeultMcgZQF3reJrLKZ7H0PUkCFb3J1XX1kMhQVXfAyOwBCbE JhALGoz5OBqFbxyr0ZGqtIy162BD2omqM5T2URm4pNSYLJ+etnbd1zX0V2dSBnJT2THK IsapdzsnIk0bWfFxgCx51ycyIJ3eHrUDQLbCnVlOMZpZoOW6n10/K6bBXQFmQl+0VVw2 Um0w4ZRbPjqb73xGxqhF8BBHbxGobKCwcDoy6nibQ0IO9IM0oFdVY/E+CGsCCKbPNNNC nvQw== X-Forwarded-Encrypted: i=1; AJvYcCWT7rL7pG2xG7SjQDrNd4jqRXhtlR6xeqTXOvaa3cYSK8MqUrxSmhPyKPI4Y59sumrlJJ3SJgvNUA==@kvack.org X-Gm-Message-State: AOJu0YyfnsOem2ADvag52/SMjFL0IV31yFW8SA4uup+1r6mG0EPv3tsH 3fmJKOAukP+awjKEahIm2ZM5r+qqhLQYeUd0fV5ACXd0sKwT3aCniEImVZodcs/XbRmOD6tgC21 Q4wb1Qx03W4ZgoIVy9w== X-Google-Smtp-Source: AGHT+IGwJn9EJP8GtKGgKNxrH0BY4CkxYPV45y1cD8icRFgRw9CbGp2WvYHGCQMogrHt+opwFvFH2GIGVKy8VGCv X-Received: from jthoughton.c.googlers.com ([fda3:e722:ac3:cc00:13d:fb22:ac12:a84b]) (user=jthoughton job=sendgmr) by 2002:a05:6902:3297:b0:e2e:2e79:207c with SMTP id 3f1490d57ef6-e3087728d56mr466276.0.1729884068955; Fri, 25 Oct 2024 12:21:08 -0700 (PDT) Date: Fri, 25 Oct 2024 19:21:06 +0000 In-Reply-To: <202410252141.djLwbAYF-lkp@intel.com> Mime-Version: 1.0 References: <202410252141.djLwbAYF-lkp@intel.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241025192106.957236-1-jthoughton@google.com> Subject: [linux-next:pending-fixes 301/373] mm/vmscan.c:3498: undefined reference to `pmdp_test_and_clear_young' From: James Houghton To: akpm@linux-foundation.org Cc: lkp@intel.com, jthoughton@google.com, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev, yuzhao@google.com X-Rspam-User: X-Rspamd-Queue-Id: 00F1414001B X-Rspamd-Server: rspam01 X-Stat-Signature: rapajfhh9zc1h3ea8orkoiokqadmmd9t X-HE-Tag: 1729884056-241393 X-HE-Meta: U2FsdGVkX19wymXSBScRyws/YsdNKE64wqSITsKqu49O/2Wx5R6cd6uBSJvbual+DqJsfuu6YSGYMcWfwastb1MXfcfwfzqZtb0uql+/OStTf3+h0sW9kEzFntYDIWWudAXNnANB7gAiKrCE0XfclA8Z81yzdWtIonQwe4QRJMsm9UA7UpqqR2OSvr2OI7W6ablW7HthNB1QQAi+uFqgvDU7cHDi46zePVWMYexIGQNxumhzBmdLbfFbxno2cJggVOPbP6llnXV4uWF7aF7pEJPgRnWgyQGQkuXyceuPhCEbNprTyxHmw9g6sOw5fmQ544pQyYnyhZYs7bD3TfG79b6zM6ZGmxV0s/KQAtpl5gVvM6RZHT+LGI1uQ1nbUkVyMnct8TfKhdyTfHpJqmb1vQIVbrUoZYylh/5J6uO1Vdd9gal4FyOy6HrpRzNKIOqjnjUSP9/mt8/+vWcsrK7PfBoF6TBeTTS40Er1S+q1Tbub6Yxw7at62FNR7Us5Cxt+rnHwYMyAoSKqGchiaavbRKF19mu1+YM47q0C4OTwI9pU6AtHLshj201JLy3SBCtj651uyxk5J5BTSQkJwAelak8BbS9X9WDGVcIIco3TFURE1Dm47CG5PtQrtoQRs2O3xD7uLe/1iZ3LAktGmUomNpju0ioP39JkZaNKXyZBc43HC47k98EeEfJDBe3qkVEowl09FZ3wTunP5BjFmeaQRr9caE4kPwlN6RwTeKQENxCWjy8RsafMWq119ybG/2hoYJGJWFhiyaX5+A2nBvDB3gRt4ahTBFlOeTyTLD43MUEGMwRiyN34vG02fzTIXhYtQIiklBakWw3LpqdkhQE/f3zC+6k0OvAHZ3/Fg3lKovihPzod2r4B7DBiEvXlwQTHyR7g8QUqroplQ7bzHVaFwle6SywZBUmMpvJvlHruLkSKfTgOXteAMO1f1oEd78tybLqtRnlyBsVXne2kcki WYLlaZ9N 5/vqYxPg4Sk+a8JF1uG2tEOy8pVOJufWk5RTDleoy5XAyqlTcFv3j7NOmQL/63x28ztZUA95hyMwtCkZQivPiU2S8h/BjGnAg9HmWLSagp6uYEeKcKkKmp+vTJcuxeuF/lxSxl5eUFMOB1C1AiQfeC6EA0uMUW0RFUQhVYFM8ud2tkUdX3dQmIrhhm2pmUrnGzm85/FWFydxcC+yCqHxhuCU3ikdyXjMTSIODvylKIEHiJ3hnISS4sbzIGAQbrd9JO6/ZbtG+kudLl1wz4JU9r6qzM03UqJKNYDdE0Zh3Pl17huhEP08OPJoi+nFa2rQeHDoWDcAHsyt5oift5AL2oidF2dceo89v2U0D/OL5eZBVZqiHjZsYyXYf0+rNEU45n6SF9FyQrtT/cWtteO9RnTUPaiBVenY93RBxrSCL7Us3VW2bFwEMdYzmKt9ur/jVmlCsyhnbiU+hZlGR9JHhZSMX3FE3pzDyFk6b/ESuAniWI86X9CAPvaBDeCOe5hPDlT30KnjKOORGBBalA/0RoRg4sPJE+V6sr3ff1PMBq627TFfVmc4uNTWZNYJcfr4TVa0S/9RyQBNAwfp99yXfipIOqAeSFgY17dSHj6lnfl3iSvfXW9OhSIDcYMH1B4+A/3QXlxAFKNY7XO8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004884, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, The following diff applied to the second patch[1] fixes this error. The diff is functionally a no-op; the get_pmd_pfn() immediately following the code here would return -1 in the !pmd_present() case. I can send a brand new patch if you'd prefer. [1]: https://lore.kernel.org/linux-mm/20241019012940.3656292-3-jthoughton@google.com/ diff --git a/mm/vmscan.c b/mm/vmscan.c index 29c098790b01..70604eef0dd3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3486,7 +3486,10 @@ static void walk_pmd_range_locked(pud_t *pud, unsigned long addr, struct vm_area /* don't round down the first address */ addr = i ? (*first & PMD_MASK) + i * PMD_SIZE : *first; - if (pmd_present(pmd[i]) && !pmd_trans_huge(pmd[i])) { + if (!pmd_present(pmd[i])) + goto next; + + if (!pmd_trans_huge(pmd[i])) { if (!walk->force_scan && should_clear_pmd_young() && !mm_has_notifiers(args->mm)) pmdp_test_and_clear_young(vma, addr, pmd + i);