From patchwork Mon Oct 28 13:31:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffen Dirkwinkel X-Patchwork-Id: 13853466 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 677DCD1039A for ; Mon, 28 Oct 2024 13:32:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91D1310E4AB; Mon, 28 Oct 2024 13:32:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=steffen.cc header.i=@steffen.cc header.b="luo7zlF9"; dkim-atps=neutral Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id D424210E4AB for ; Mon, 28 Oct 2024 13:31:58 +0000 (UTC) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4XcZ6y4czPz9slB; Mon, 28 Oct 2024 14:31:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=steffen.cc; s=MBO0001; t=1730122314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaiWgQ1AXzTNomMAaUXn9Y1bpdRE43DfhiGZpik/Y10=; b=luo7zlF9FBoaEfUANDbeaf2YgSmiEd/LXMh1DINtKPbqtLaxF2NaE8YdkrulyYLpKF6tbh OlZLLuLVC4MOJVnjscSHavPP5sOkhRnWcSaWo93+IJevkS1B5y1pbqPL9QLfyhkYt56y81 ik/u3jyHoV3qix7fAqahHeFiuQUBmEJR8ZOgjuMu/n3rWOFgozcfXxdK0/Ff/SfbMgMC3Z 2aiJ4phODmpoebf4K+0IJpwVCslmGKaQtty5t9q9HkGEBAxiPSC0bw41GzkG/t2JxnWLMw MPw8tLVkIv+B9NBm91wEkJ3an53Hz8oZrxqdRnQjGD8Bnihn4Lei61QZJal9uQ== From: Steffen Dirkwinkel To: dri-devel@lists.freedesktop.org, Laurent Pinchart , Tomi Valkeinen Cc: Dmitry Baryshkov , stable@vger.kernel.org, Steffen Dirkwinkel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection Date: Mon, 28 Oct 2024 14:31:38 +0100 Message-ID: <20241028133138.52973-1-lists@steffen.cc> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4XcZ6y4czPz9slB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Steffen Dirkwinkel drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init. zynqmp_dpsub_kms_init creates the connector and without it we don't enable hotplug detection. Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge") Signed-off-by: Steffen Dirkwinkel --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index bd1368df7870..311397cee5ca 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub) if (ret) return ret; - drm_kms_helper_poll_init(drm); - ret = zynqmp_dpsub_kms_init(dpsub); if (ret < 0) goto err_poll_fini; + drm_kms_helper_poll_init(drm); + /* Reset all components and register the DRM device. */ drm_mode_config_reset(drm);