From patchwork Mon Oct 28 18:48:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13853867 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A447718C333; Mon, 28 Oct 2024 18:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141307; cv=none; b=Bv6IBdQ0rfLvP3Vr2K0uHKfaU10GJcHDv9aiiz0M6FAADc10eeBNvLEWChHqQ5o/Mgmbw51AHDER/L/8lNWYos1x4S8OW5BYBAVFdLf+Us/JqAI4Aq8bsHeNzCIhQR9GlykeCn1Q5VALgLp+QP3z1r72ERqtdulPOwcm7qPxy2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141307; c=relaxed/simple; bh=wZLVeHunQ9dJsgdquHVUPhJkc/woD7Y+33ssUq+Ml3Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KNj4tmP+G9KJe0KzP8KA4ConHiQeVgatvwtXHSI48YkjwCXuClhGcfUC69sPu9dOvRLsZtzNq9wQL4Cb2R5apvgJ31psTL1c6yb1otC47KIcgQQJnNhTISuDjygrGj6siS8pVeXMusb3RUi1pYA2lf5Z+WcfMehCk0ykY1XjoEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EJ03qTEJ; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EJ03qTEJ" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5cbb0900c86so3726618a12.0; Mon, 28 Oct 2024 11:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730141304; x=1730746104; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6lyVZZQvsRXJg47YjpFjAC0Jg41UFgIBO25Gj/6D5U4=; b=EJ03qTEJjT/zmeS/ebVg+KCJLKkFLGyYvFCjR5ZwbEqAmcLLEA/feYuYsXlh8rGQK3 PfzojPWQMYhpICitT1JjBsn3orrNyqwnzTzVEQIMmz6YOXSsS4tgjpJmInXTAoBsKWSD LP7jhJHLydTI1nlH9RhfGzia01MAP8FvyWqBjGQ83qAnAVWxXca+mpLE12qSjBa30gF8 PcZtquEXiWdkiYlb0bpLuDmwBs8+nat0aks8F4GO1s+A7UBJxxi8WlORpfo0RoqebzQB oB8LRLaqrtLoN1g5UfWdu117+7msNo/9gPtdqIVxCV4uvcAFWipHQuNdrkQRqWerC2NT JStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141304; x=1730746104; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6lyVZZQvsRXJg47YjpFjAC0Jg41UFgIBO25Gj/6D5U4=; b=SPsASlfWqT9NhMQ7vBaKpuDj0CjU+ri9nzTFgWSQ8Ee28hD0ifQw1s1IVJMrG1Zv8j q2GHXRtivjMEvPJG9Vq33OrLhCU6E0Oz5s4VmLExsb4rG6AQyTORhqR4hs9Ay4B2E0mF 9UyUiastammf43/CCRN2IHS8+bp2LrOhrOoBcbnxiz6KiUAuuk11/gh/gB6Dm/PD1obO LZ2JNkGJOaD6O3pZa7uUR1xGEPYLuyzCrJeYBFSX/0x6XmaVCGDljACmw7B9IIY9Hmiq 21/PcC0lD7kQuOC5EuONYkxoXwbz0LaB6qSIETlD6GR0SYkg1S6tzn5hrr/78pBrZMsb atdA== X-Forwarded-Encrypted: i=1; AJvYcCUds0Zg5tYRfX1oeleg7aMjCTYwE9sFzAsBkEi/oBW0mgw0IArCEOymbfkZLkq7ZSr6p3aodhilS4M=@vger.kernel.org, AJvYcCWmh9giFkoSRVecEnJQ1x1yEgBpU8gq+a0Aete5bADOCuIj6/NZCHr5TMmm99tw9Qn/PQZ/+70KCTUg8VFO@vger.kernel.org X-Gm-Message-State: AOJu0YwOWaLBdd7glfn5XQL5Vw5U8MwWnoLYr1GzOvzjEcHI1hGrWB54 vWf1/6bbsz4EMTPh3Lo6nJNYkYtrYKMO4kMMTgEQbo2GRULEfYQZdX+23Q== X-Google-Smtp-Source: AGHT+IH9e+K88V08b5r7guPqVP/9VmKvjlWqm98/H7ACquxAyI37SX3lLxRp50uQIbH7tbpHUd78mQ== X-Received: by 2002:a17:907:7e8e:b0:a99:e939:d69e with SMTP id a640c23a62f3a-a9de61d1a8cmr686281566b.51.1730141303768; Mon, 28 Oct 2024 11:48:23 -0700 (PDT) Received: from [192.168.0.2] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9b1f029617sm397585166b.81.2024.10.28.11.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 11:48:23 -0700 (PDT) From: Gabor Juhos Date: Mon, 28 Oct 2024 19:48:15 +0100 Subject: [PATCH v2 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241028-alpha-mode-cleanup-v2-1-9bc6d712bd76@gmail.com> References: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> In-Reply-To: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate. Despite that enabling alpha mode is not needed for the initial configuration, the set_rate() op might require that it is enabled already. In this particular case however, the clk_alpha_pll_stromer_set_rate() function will get reset the ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask' is safe. No functional changes, the initial rate of the PLL is the same both before and after the patch. Tested on TP-Link Archer AX55 v1 (IPQ5018). Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- Changes in v2: - extend the commit message to indicate that dropping 'alpha_en_mask' is safe - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-1-55df8ed73645@gmail.com --- drivers/clk/qcom/apss-ipq-pll.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index e8632db2c542806e9527a22b54fe169e3e398a7a..dec2a5019cc77bf60142a86453883e336afc860f 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -73,7 +73,6 @@ static const struct alpha_pll_config ipq5018_pll_config = { .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2), From patchwork Mon Oct 28 18:48:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13853868 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58DC71DFE13; Mon, 28 Oct 2024 18:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141310; cv=none; b=c7zHr3A10K4550MO937SaBm64ipWvwx2J5GbVhGeDeCephTqxwduoCY7q/0DuGs1nbX/7n5g8A63e+h1CWP2kjHBjAaxp8TMRRL6xRq5naH2mgiU2EwjMaB2esUE0KLTisG/Af7XvO5pqtQ3N7qaqE7nfVm32HH0rdITCJaSwW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141310; c=relaxed/simple; bh=Bc6r+NncPoReD4r5h4VypBRYmiGXN3f3EsIGE6RHtRM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RUqmH+DS2qQU4K0Fo0RcSiKR7DYfeiNvpwMZ6V0L0KrXSW6PtWC2DP4OvNzOTmhFjG9uaHng10eGaxAy0sig60+C3nYEQA2f7dsytixO3vlBubMVvqkVRMNx9aJc6+FpXNq52XXrLn+dt5zKzsLaULbBwKTTV0o0u4eSvn2KgBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lewgeHeq; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lewgeHeq" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c9150f9ed4so5955325a12.0; Mon, 28 Oct 2024 11:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730141305; x=1730746105; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ThqSmsGvu8DQRNRTmh8NRaZWskBUyhvYPLVqXS2yzxQ=; b=lewgeHeqetDACwFpNb/O+Ojmbq7AknFsxTckdx8+zWYE1Ec6RNMXcHp70tAGTPbCdQ JrZRLvG1BM69OkMa6l0fNliuy9GoZmkcT8TwgDwd7CA7iJ6pHsHZUOizLEFxjFS5nzkZ la/X4P8TtRTazexHED2uyAHG9Fksd9vlk6AB9NdMM/QtNG3ahqXNTXMTX7xWJhxZ21zF IpOK/mG4Y6IdZpIQmGjPeS9o6ZCIn0Rax88c20Ks85xCjtOeiZzZqAWN+AguM6+mcBI2 AuUozHLBTndFvGx6KTMYFgE8rGQ6iG9G2BCKdi1sbt9c7sEUo5w+0ZP7Y3GS5jYidbjs JorA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141305; x=1730746105; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ThqSmsGvu8DQRNRTmh8NRaZWskBUyhvYPLVqXS2yzxQ=; b=JPi61+on71KO7cLHwZWKUHzVCUBbKVRvtP41qiptT7zEFbHFeFs70XR1TzDvSTzhLG utHP022HbO2V3of4mZwqiEexNgzPymwfTLr/AKEWES+rfd4YH9bP4mn4hpLA05Tfwepx +th8OrTCcDOkvO5GQr2Q0Zq6hUjZRA743+LUseGfeMQn/1mGKvkscTU/rAqhZpeUlSSJ ahy5K6bB58lshTfk31fTT60FIuY+hnijkhtvUJXOoCTVxQV/Fb/swOHeUCIzhTn6i4aU 2+8/M8GvZrNRXLi7PTryQAxw1E9duf0QBp8Kbkl7EqHogv2RtzewuRB4VP/SAI6uMFSU BE9Q== X-Forwarded-Encrypted: i=1; AJvYcCWLTtowAxlwJj24a+PiUQb7ffPRJH6KBUyJUMGXvXwPsUIHP1TRdw65x5Cdx80Qp+fVuC+rj0GK1l0=@vger.kernel.org, AJvYcCXJygLXJXtOlB2yQqGsI/Yf+bI9WSFjEFyN6xUsw8g/szrfJs1B7iCuipaZeR1q4mYIYjV9grX0QxxEVH15@vger.kernel.org X-Gm-Message-State: AOJu0YxmVPmPnnmgQzpcJP+8UCbzKGFI/jzUO8A3dgirwood6rmoFnFO uRqD9ibv4UUcFbuvN3RJwQQoUTnJDUysFB5UsPviEi0awiUvKtrHmcO1hQ== X-Google-Smtp-Source: AGHT+IECr+9CX0Ix+JZuvZG+xwLIhqaBFb5T2Pyng6mgve6qUhZBQyuSvI98yJT+zfpZUWi9sRRZCA== X-Received: by 2002:a17:907:7245:b0:a99:f8e2:edec with SMTP id a640c23a62f3a-a9de5d6f21cmr996733966b.21.1730141305387; Mon, 28 Oct 2024 11:48:25 -0700 (PDT) Received: from [192.168.0.2] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9b1f029617sm397585166b.81.2024.10.28.11.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 11:48:25 -0700 (PDT) From: Gabor Juhos Date: Mon, 28 Oct 2024 19:48:16 +0100 Subject: [PATCH v2 2/5] clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241028-alpha-mode-cleanup-v2-2-9bc6d712bd76@gmail.com> References: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> In-Reply-To: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate. Despite that enabling alpha mode is not needed for the initial configuration, the set_rate() op might require that it is enabled already. In this particular case however, the clk_alpha_pll_stromer_plus_set_rate() function will get reset the ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask' is safe. While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration. No functional changes, the initial rate of the PLL is the same both before and after the patch. Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board). Reviewed-by: Dmitry Baryshkov Signed-off-by: Gabor Juhos --- Changes in v2: - extend the commit message to indicate that dropping 'alpha_en_mask' is safe - add RB tag from Dmitry - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-2-55df8ed73645@gmail.com --- drivers/clk/qcom/apss-ipq-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index dec2a5019cc77bf60142a86453883e336afc860f..d6c1aea7e9e1e50a8d7561ce352feac4e76fb1e3 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -79,13 +79,13 @@ static const struct alpha_pll_config ipq5018_pll_config = { .test_ctl_hi_val = 0x00400003, }; +/* 1.080 GHz configuration */ static const struct alpha_pll_config ipq5332_pll_config = { .l = 0x2d, .config_ctl_val = 0x4001075b, .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2), From patchwork Mon Oct 28 18:48:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13853869 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E141DFE23; Mon, 28 Oct 2024 18:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141310; cv=none; b=j1dnvl0ca6AUDu1wX8CmhlhFsQO4UQfo6euC52ddBMKtBiEs5ooIhCZ9XA28sk+vf6IZUbtmuOsL3kzsbQQOA0UY/yjjkizVH8qGhbRwvHn8//9lGLAc/URto64TXIAIZLoVH/1PtSL56JLVFICINcxNnmE27Qtm7psPC6iB+IM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141310; c=relaxed/simple; bh=yM0OWmtAcDKn2FuZk6in24tAsAFJrfmMDU9dm2pIGiU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sNVl1scrsX/wy9kLyI4cGVRlNPvRkesz2I8qSvN6SlAosyIy0cO9uUO03Njxo601IThe/Jn+x4MrsPwA+CgAZcUcCDuB6tbx4lDgJpXvubMomUYvdB9YtepP9t5tfB3K1dDmPOP4aIJQfR7RuUVBWTgdVpaV27SpdaabHZ0A9pA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tu/IewWd; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tu/IewWd" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a9a16b310f5so725249166b.0; Mon, 28 Oct 2024 11:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730141307; x=1730746107; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IBKU3i7B0mk4YfvFEK4QQaKbeBZNcN9N7bMX66oe7cQ=; b=Tu/IewWdjbJ96/TeQNG2PMvEUTX25ATDQm9alOo5dXUJjqBa3Lw8F90liYvqn5JhEm yg+//pjRbAl6NW5GgkTXotGUAPfLJE9g16JMzAjrgnx3OXEyFBimzQkx5M+GBz+ZBooq VlLh56yClbJ0mTGS408OIqBBvZbWSTKRfiwRpyEGYmRAc14U2gfYYeb/FhvAmUfY4HH6 n0RfRSzdJLUSlo9BwlIDE0TGjZsGSzXXVP59zGAH7luEUnWfZ1/Mczvz9ArAMBdOG/XM aFuCUnV9YOkQ1Wy5vlYu/RjRl/Gwr3YpQ1V8pD/rF7DINxAKB9BPdDRL1uKm9OcmXw/3 ZqcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141307; x=1730746107; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IBKU3i7B0mk4YfvFEK4QQaKbeBZNcN9N7bMX66oe7cQ=; b=MTN+ZFGTtwk5A8zndSnGCxA2N8JiGjdUxx5sWKK3VqMZbZajANTXfzeEXJZE3S2z9x OGWH/MCVCNQGM08ppN/EHv8P4aGsUpIxASiLtp70Exe8Se0AhsgnxfmndIxMVsGx3pE4 YaJ2dXT5HtJcL3euSw/mDx+go7mkmS4vDxKCPCyPNN6Rigch93MWFR/IvHIgWhTlreCu RRFHgnNnwuEB0w6SI4N+TY98IkPz60C+z5qC5R4EiWqrCL9SO+6+aXxqQvYic/WVSl1U aL9cu0UbdM0Nuyp3ydZBktyPMsWNYSla/tQCJStXy+yDEVxVpCdfpWpBGVGgAw97hYJE t65Q== X-Forwarded-Encrypted: i=1; AJvYcCURq2RCNV7633pdFqijX4iVT0VrqP3JQAmBbE+wQThZ6588HmXfuoEIahjvwnxyFni+SepFelsXsBTlTLOo@vger.kernel.org, AJvYcCWZ7zySTxcwFzlpNezWS1aox1p2oZXgOIDBgutrml96ddFXTa0h0E3au+6g0QawqdXmXqWgAonRHCs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4agj4nkrPk80ZKeXTSDnfGmjT25jzYoupNK7FOsFmO9yBWt3Q ZKcUE9lwytLcvN7EI7mlGrO+P5WLclegAOQgK2aEfkblksOaJE99WShvHg== X-Google-Smtp-Source: AGHT+IHvbm0YXq5I5z7ls6NUwBrW0g1B7TNGWLeHRTUpyQ8rJAobLexARTglStPKazAs2xEKKpnWwQ== X-Received: by 2002:a17:907:7ea2:b0:a99:f4c3:580d with SMTP id a640c23a62f3a-a9de61a0042mr658100166b.42.1730141306868; Mon, 28 Oct 2024 11:48:26 -0700 (PDT) Received: from [192.168.0.2] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9b1f029617sm397585166b.81.2024.10.28.11.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 11:48:26 -0700 (PDT) From: Gabor Juhos Date: Mon, 28 Oct 2024 19:48:17 +0100 Subject: [PATCH v2 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241028-alpha-mode-cleanup-v2-3-9bc6d712bd76@gmail.com> References: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> In-Reply-To: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate. Despite that enabling alpha mode is not needed for the initial configuration, the set_rate() op might require that it is enabled already. In this particular case however, the clk_alpha_pll_set_rate() function will get reset the ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask' is safe. While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration. No functional changes, the PLL runs at 1.2 GHz both before and after the change. Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board). Reviewed-by: Dmitry Baryshkov Signed-off-by: Gabor Juhos --- Changes in v2: - extend the commit message to indicate that dropping 'alpha_en_mask' is safe - add RB tag from Dmitry - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-3-55df8ed73645@gmail.com --- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c index ab0f7fc665a9790dd8edba0cf4b86c5c672a337d..d861191b0c85ccc105ac0e62d7a68210c621fc13 100644 --- a/drivers/clk/qcom/gcc-ipq6018.c +++ b/drivers/clk/qcom/gcc-ipq6018.c @@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, }; +/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l = 0x32, - .alpha = 0x0, - .alpha_hi = 0x0, .config_ctl_val = 0x4001055b, .main_output_mask = BIT(0), .pre_div_val = 0x0, @@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24), }; static struct clk_hw *gcc_ipq6018_hws[] = { From patchwork Mon Oct 28 18:48:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13853870 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9AC11DFE32; Mon, 28 Oct 2024 18:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141311; cv=none; b=n791NdtgBZwMMSiB5T5lwWFtb0mH0w9baTC2/QuwZ70/AFKPbEpyRmBc0ZtVlEOUhISYIPCTiPqVt54IZLj/ptBiFsnc8gOLuQEYYNvT+jG9ph6pWX1GwLiXUhAP6wxoopQNx7EhZAKjBGyqdm3a2rTPKCxsLZFfbFxJ+AIzeQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141311; c=relaxed/simple; bh=tJy7WRxFzYmpR4M+/fV3d8Qijiy2s/1g7HIRtP8Dflk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rZVZKjzKa71QGgi+V50fc94mdl1gtkZ6UWSVWLaiL33bVSoylPZ9PbFky1JrnL28K2ABVWSklcjnOgah8+uw4bthxH70JjemclepzM2iEdDIR1V3w7kyHJP3CrnVwRgonE7vJoYWgG1LQ6/i86Tys5I7lNZX+1IMGfTXEFstyEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QrUJpRuw; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QrUJpRuw" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9a2cdc6f0cso626901966b.2; Mon, 28 Oct 2024 11:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730141308; x=1730746108; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WawemXe+1+8ApO76dXS2S+ra0pV/e8rA+QZSseLvbvM=; b=QrUJpRuwTXfB8S/5tlOOXkdk/qgSkbnc50Xj+Z+HEKEo6Py6vp3z9CiPx5L8LLBcdN N5+dPUJV+xtVpTbf03sZpp9c+ikvV3pWKHeqWT9x3A5CK+Hx6Q6orcpehH1F8SQ4WeiB 51s08oAQMLJ/Ir9ZG9psMQbrijVVem5J0GjcYGSM5HiFIXeyywYqohiuGxe4IxGHDi2v Hae0wN/ei9NYUUf7CV/bg+j/d3FB/JsMf/m3pw2ThoXFpjKHRR31nyqNWv9lifM7GB5x 6NBskEyYf3WQQcFEHURT2Rjg0lWgt4soKkfxV+yUQ+Ry81myqaQXbX9OrTbMOsTx2O20 0K6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141308; x=1730746108; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WawemXe+1+8ApO76dXS2S+ra0pV/e8rA+QZSseLvbvM=; b=oGxcdJF0BfIRfr65lyEm8TwgMtuUBzl2BR4X0W3ThRZnNaAiNCJqVi65gNQE8sghF3 j0Uwne4o2Hniit0RY6jHXnWi3KCS7KTCNREPQcSh8wOtz5lK0x972PTyayAxB0K5VKd7 /bnbhWLSV0TLNSkNKcShqv3im20Xl4Nnm4RNuDFG1rrRpCOfcza82Zed5vC4KYVrVKNu igYXkVfgRpk1Rr1euU9A9DFx8z5oe62t0nkaB6gcUQUKigsCyeEL7NNiijOAygdm74kD 9dBnNo2F81NdRreTSx/J1uTOH+IpSiH3yhu/0P5XCy6gEtyILhGbhJQcrqbF+ASfzmi/ EC3A== X-Forwarded-Encrypted: i=1; AJvYcCULsRSKS/KvOWzrDOcCKhqaTWT3EayIEOEqN7L+dE8dVlEuXRqrFJ0lPg4Xmwssw0aDg+FiozTO+zw=@vger.kernel.org, AJvYcCXYwvO50zh2Nq+ds8iqCIgEbyt11t8zrEGR9346OMpqc1JbHCTs2WCF4Ov308bbieR3YtrBa2pELUyFdjp6@vger.kernel.org X-Gm-Message-State: AOJu0YzYBGjqqdKhJ2CFbrRh5gtNKx1VnJ8yI5kupgMFHD72Mje7zUNl KKgc0fkH98T+I2YPDLt2Gl/GxO840a4oyANBlw0Ex2mKcsAvfL6ERy9t0w== X-Google-Smtp-Source: AGHT+IHeEImOIFlRf6rqC6W0xEOD7To8xmifzI9uf6RD2K8NXlb3pzQMKVBf/U1LU6OEfWBCyyCMtA== X-Received: by 2002:a17:907:7d87:b0:a9a:f0e:cd4 with SMTP id a640c23a62f3a-a9de619a63bmr955258366b.55.1730141307881; Mon, 28 Oct 2024 11:48:27 -0700 (PDT) Received: from [192.168.0.2] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9b1f029617sm397585166b.81.2024.10.28.11.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 11:48:27 -0700 (PDT) From: Gabor Juhos Date: Mon, 28 Oct 2024 19:48:18 +0100 Subject: [PATCH v2 4/5] clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241028-alpha-mode-cleanup-v2-4-9bc6d712bd76@gmail.com> References: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> In-Reply-To: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate. Despite that enabling alpha mode is not needed for the initial configuration, the set_rate() op might require that it is enabled already. In this particular case however, the clk_alpha_pll_set_rate() function will get reset the ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask' is safe. No functional changes intended, compile tested only. Signed-off-by: Gabor Juhos Reviewed-by: Dmitry Baryshkov --- Changes in v2: - extend the commit message to indicate that dropping 'alpha_en_mask' is safe - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-4-55df8ed73645@gmail.com --- drivers/clk/qcom/dispcc-qcm2290.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c index 449ffea2295d3760f40abe8b1195e9022f46a9b0..d7bb1399e1022afc68e45ee335d615d4a5be5add 100644 --- a/drivers/clk/qcom/dispcc-qcm2290.c +++ b/drivers/clk/qcom/dispcc-qcm2290.c @@ -40,8 +40,6 @@ static const struct pll_vco spark_vco[] = { /* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l = 0x28, - .alpha = 0x0, - .alpha_en_mask = BIT(24), .vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0), From patchwork Mon Oct 28 18:48:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 13853871 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A77C21E008D; Mon, 28 Oct 2024 18:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141312; cv=none; b=Dw9q0b87wFgL72jCwuBZtO7FnYJsIOxuDSP94Gks3HQee71EdSQrv2aIy/B52bdvibYW9w4L+YDu5tMCfJ7DJWgdkW0mfjSVJLPGFruAHeptP/j3jQzOqlh59bLLRk9keGS7qn5mnxpP3Ih50CqmtKyjsmD182GxwqCJnGhzhLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730141312; c=relaxed/simple; bh=7yCnSD/2GuSo3KNhazT7H6gIGvBqe4Cbts6U9Qd+Fg8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K8lSEnIVg2zKKJ8LbkqmftP/CXZywqogjsB8FO/2J4MtUyMjtrp5+yDk1FL1bMoT5nEGZHHc0m8pZn1OqJfsqza6j0MVLFCT5bejbbGZCxzkUUb5nhSkL8xO9dWbjnRv/xUp90uDavSu3+aUPV7dvEZf46Z+KmxcxAhCk8Q1D3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W8yGEmz9; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W8yGEmz9" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a99cc265e0aso719530666b.3; Mon, 28 Oct 2024 11:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730141309; x=1730746109; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XXXfTAEkam83QhXgigwp3Sp4eBqaqdCR04cbjsml3X4=; b=W8yGEmz9LgWONsXNJaiSNIPic8TINgDswiyzrE8WAEhs+QQbYcc09dpt7KVVy0twZk gK9lWAm8SgN9dQX2PEpSHKMpOCLrlKrKjnegvObo1icAY30MVbndBBZyXuUH71iHAx9a YyhFQr68thwwMA97wgWlgVGD8RJbI6uagBOeWumJn4X+mM0hXZZ6eff57lDvtZmsh290 nMfX52zJYfes8Bq6vMCCENgziMewRNVT4+ft9rTQiNNPhgjiWLQzsxp+cQpzNjVY7nRm Hxm0Jr8qoaKCt3WW+1KgHlNWsR734ZLbmr67mhm5K0dz9NUqnasLKgwFIts+k2FUzcSw 7afA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141309; x=1730746109; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XXXfTAEkam83QhXgigwp3Sp4eBqaqdCR04cbjsml3X4=; b=Sz7vH0RfNOZTzySXuuYBZeJDkBjsEwpjXtDboZ74EtVT99oKtLkFO1MDjbSnoJPNR9 FMpvKiUPzEVnMZ7d0/LWsaZsO+GnXz9MHXvzc6eDYc1qQ/cyahJ/Dxp2tafnV/GJxFOQ UTyPOQT7GRjCmmzq84Lub81ATJ4bNMUtMSfDYhG3JtO41kl0pQ/VhSGsHDKeupQDEL9V Oc8eoznU8BvW7HARjLKXZbjDyR3PmBlzeKbUGNoXtPlFxQAMGKedbqQrvpb+HdoF3ZZQ gpR5SUs4WA3BUwoLJFUDRPWNdNDvCfH/HA/i+0ws0gGs6qwEL2jZW5qhZgANDkCU+85a U9IQ== X-Forwarded-Encrypted: i=1; AJvYcCUJtMTEv+JHjJ5ZMquBSWcBQ8PAg8nPmlCJIgiuZAUBIMNCq9tvakwA49aFzs1v423qCBrZZso4tSRK6Gyl@vger.kernel.org, AJvYcCX8YDcOePkuohnUIJ3G5wlEaqVvb01ki0MwjS5sw2ZyO3YcyhsJrW2no61v28YQ832aQ/Vdqgo0sHg=@vger.kernel.org X-Gm-Message-State: AOJu0YzkE44LQG63gCQrj4H6ryyhh7vIEaIBxMOT0lhsm7SDqYwDCP3C lkBHR0oot58rQcCVTPyJ/KZ7Ms0RC68m3TOAyuNb4hzIoSQ+H9gETyuQ4g== X-Google-Smtp-Source: AGHT+IGuGvnH3S2IwavGjjh3kYjtHwOl0iZ9ybgjficwGHEPIT7DcThmtudj7m8KEo7CQR/coYkVrw== X-Received: by 2002:a17:907:6d23:b0:a99:4aa7:4d6f with SMTP id a640c23a62f3a-a9de5d6f211mr877704366b.12.1730141308878; Mon, 28 Oct 2024 11:48:28 -0700 (PDT) Received: from [192.168.0.2] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a9b1f029617sm397585166b.81.2024.10.28.11.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 11:48:28 -0700 (PDT) From: Gabor Juhos Date: Mon, 28 Oct 2024 19:48:19 +0100 Subject: [PATCH v2 5/5] clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241028-alpha-mode-cleanup-v2-5-9bc6d712bd76@gmail.com> References: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> In-Reply-To: <20241028-alpha-mode-cleanup-v2-0-9bc6d712bd76@gmail.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Since both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not. Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate. Despite that enabling alpha mode is not needed for the initial configuration, the set_rate() op might require that it is enabled already. In this particular case however, the clk_alpha_pll_set_rate() function will get reset the ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask' is safe. No functional changes intended, compile tested only. Reviewed-by: Dmitry Baryshkov Signed-off-by: Gabor Juhos --- Changes in v2: - extend the commit message to indicate that dropping 'alpha_en_mask' is safe - add RB tag from Dmitry - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-5-55df8ed73645@gmail.com --- drivers/clk/qcom/dispcc-sm6115.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm6115.c b/drivers/clk/qcom/dispcc-sm6115.c index 939887f82ecc3da21a5f26168c3161aa8cfeb3cb..2b236d52b29fe72b8979da85c8bd4bfd1db54c0b 100644 --- a/drivers/clk/qcom/dispcc-sm6115.c +++ b/drivers/clk/qcom/dispcc-sm6115.c @@ -48,8 +48,6 @@ static const struct pll_vco spark_vco[] = { /* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l = 0x28, - .alpha = 0x0, - .alpha_en_mask = BIT(24), .vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0),