From patchwork Thu Oct 31 15:00:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858016 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62B5CD767D8 for ; Thu, 31 Oct 2024 15:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EDFhDh5Dsbm8CIbr2G+SLWNj/UFzwMVxtyg6fSq7G5I=; b=iC9YCy0vXkQyJU1csKvgpc0X52 IgyZmiB9KYkMwsNrNyxxzXr4jCYvvnTUY0Sw/Sp7hc6uASLkXsnSUcmjhA/r72hcjGWETiHdgawvZ 2FWmH9644X1/LbVzvMaRQVTcaN9VsQ9GSeGMgQBBmhLnw8j6H5MJQXBnU/cyALb1PEjrNCxWdLjd9 HMqgBy0EhSidunRYXUttdxaTNuSOAspHMRn+HLPxftNoFPLAoQ/V1MN2GdzihGY9TT/MMoO8bdaS6 YbWgIkqYBQrZTdCBGXYzooxD89fevk3OQErcBgdyElvRYGd/DGvJ+3Br/NY47hUNkwUI5TgKBNsVi aiShEMdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6Wgt-00000003u52-19Hn; Thu, 31 Oct 2024 15:02:27 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfA-00000003tav-18t7 for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:42 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4316cce103dso10967535e9.3 for ; Thu, 31 Oct 2024 08:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386838; x=1730991638; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EDFhDh5Dsbm8CIbr2G+SLWNj/UFzwMVxtyg6fSq7G5I=; b=r9JJJ6HQ7wMbETuuON352p9mb6aatVwu+emmzEgfG8CpCM0T4PLlpFhzeBK3Jt3JvK Rus8N/P1ttRelwwNx6c8uPRKLa5VDGNm3c7kJX4b6wrGOj4nanSLFKgSk6hJCV8cZjrz R9cgizk6lw9+o6KakPjO6W+CWe2Y/F5fIksr+PCixUyhSyKBafUVK+uwI3ATZkKgy8X5 r6zPJXsyAqB6SKqERHjTMOKQklqTFKDcmmvCi6aRtIEuJNj0ChzBTYQ1NUX45omS48pK aHhE3wCKMc/pJmwgVkWu+nfSAFFM9/LO+Q2sAKLucuyFEEBIMG9hmo2y/mb5dc3vzmK8 A9mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386838; x=1730991638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EDFhDh5Dsbm8CIbr2G+SLWNj/UFzwMVxtyg6fSq7G5I=; b=Pa4eR9YntKwAZkC3UE7WTv0ncXMek95baAqB/aDw3zoIMhMJaRJPoNtw2GHb6MDMP0 WBdQ8qVvN/5iDWwzQA/SEXEEDQs+At5Xr5YKOouBAZrBRqFGwhWr/VOg6kYwkUlx4rTp 9r6D7l8SbU29HGWFUDhbyxKwt44gsN6FD/y+fxqNsKt/oOTqfX88A7uqV3yvg4Tjqxf7 XvPVvgks6WevCLkg9/CKQ3kJThjAW+ZIowi84NjCCVpxETextStlYDG7LyG7REfoPG/y ec6XOFQb4njy7gzTYT0Lsy7kSoe7EIEAsQC1gD2Dl/K2PzSg2cAsSivVmW3kaEd7GqSG w54Q== X-Forwarded-Encrypted: i=1; AJvYcCVhEpp4KiKwjyuw/1WZxHWqgUzl3tCI98vRbBRDiB3upXbHEaQ8yLXQiJRLoXPQ2iLBSs+cb2zCH6rr5dZ3JGcV@lists.infradead.org X-Gm-Message-State: AOJu0Ywg3q8hecJ13s0YrqJWInpI4ZRmA/p+iqJJcya37BXZjPmwr92X H3d29BEAnegjduMDAXpd0rXXCgCxobXb7I0Y+BRcfwJA1Kp+o5pn21Cp6rFq+9I= X-Google-Smtp-Source: AGHT+IGql7rcBkBJZy/lkpZXVd8eJAHNb/N13bQ4wyVM/GFRhvhCqwbQi4nJvY1Ydgt8QtXoBjQJgQ== X-Received: by 2002:a7b:c459:0:b0:431:5f8c:ccb9 with SMTP id 5b1f17b1804b1-43283255a2cmr1881175e9.17.1730386837895; Thu, 31 Oct 2024 08:00:37 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:37 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/14] scsi: ufs: exynos: remove empty drv_init method Date: Thu, 31 Oct 2024 15:00:20 +0000 Message-ID: <20241031150033.3440894-2-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080040_335203_E5391CCE X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tudor Ambarus Remove empty method. When the method is not set, the call is not made, saving a few cycles. Signed-off-by: Tudor Ambarus --- drivers/ufs/host/ufs-exynos.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 9ec318ef52bf..db89ebe48bcd 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -198,11 +198,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) exynos_ufs_ctrl_clkstop(ufs, false); } -static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) -{ - return 0; -} - static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) { struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; @@ -2036,7 +2031,6 @@ static const struct exynos_ufs_drv_data exynos_ufs_drvs = { EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX | EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB | EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER, - .drv_init = exynos7_ufs_drv_init, .pre_link = exynos7_ufs_pre_link, .post_link = exynos7_ufs_post_link, .pre_pwr_change = exynos7_ufs_pre_pwr_change, From patchwork Thu Oct 31 15:00:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F16BED767D8 for ; Thu, 31 Oct 2024 15:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=urpAMkkpNWFIk6PVSyaaYZWs9YFQU6kSEcUKCd3ox2A=; b=sjapOnkyCna5LiTQiUTm2CqQII quuBJaP2NMPvaP0Nh2SiaR2iu5D7TIiAirFhE3XTBK9QoJKPEP5AFhwVDVlWuhyCHTZH3kGKenoIG K8svLYBxkSAUDFtPDGru1rjgG3YzmamQKrzZu6KritXbB1kIDgwUERLCAdxYD6+ozw1gd2BYEAZWh VacOgQcrTb1RDYWmHrbuxgnxtJdJwhuAgUcCoMGqSiYoyF1AWwKE/8krOLIHYEIYxCY38MCWTXH78 dO/OUkniPZnEa78QgqVmcWSaDwT8IJbwq/SLY5Okr4ibXqL0vPad2R3Spii87hCw7xH5Emi4qmB6F rJ/FEKHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6WkA-00000003uxu-1xvR; Thu, 31 Oct 2024 15:05:50 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfB-00000003tbQ-3n9x for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:43 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-431695fa98bso8028515e9.3 for ; Thu, 31 Oct 2024 08:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386839; x=1730991639; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=urpAMkkpNWFIk6PVSyaaYZWs9YFQU6kSEcUKCd3ox2A=; b=oSJjBZiiVY/M2tIhIjzME18SPDIm1T2vQj6OnBzb+G9Djaj+n61+8SiqUTHHxcjnKS PKr4QkHTQnA4VnST0+EcX5mvo7KpC7PuVtX9cPsEdacUYFToMIPn16ACRfkEmIipd/PX hb7RjvYDRP5R8MM/YZGL567Sc1gDaRQKXPe07Yuz7H6fauzjrh26onJ0AfE2k8PTA1qn urvd7mv2cTy/vZ5gRFQ8PB5FksrjIKPa7GILyPscI/ejHReEa7SMLPudCOQshm1qgmbM L5Lgg8b2FKLp0AZnXMpC59u5DOvpwNRmUSQm5F9CmKSvsM09CPIbAK+mhDC+MK7WquQw KN+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386839; x=1730991639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=urpAMkkpNWFIk6PVSyaaYZWs9YFQU6kSEcUKCd3ox2A=; b=Fzd0juwFtq/5EuyMB2lAuRueZHrawBlw/EqDlYz6Ce6C4F1z01Uk3vINfC8I8XJbQl mk0uiU7coOyH0fQd+spmWh96UH1pwzBQMhRTZQN3OSJNXLq5+ykq7VEaOq3H/ac2Ju1Q +5jEyQ+LKu5hLuBQ9agSLJPWaTTw3ahXtVc2T9tI9sYgskzIMe1ori65PoStuo91WhhX O4F2p7deUWINAoTyLPRytqC1TWtg23jLWo8nuNz8N3JaKVzs7C1yKJ8t8KpN+FgfQ8ed Tee9rZF4SgPR62FYow1MQZSMaG83TpDk0d59pKD7ufglNbc6BLoDIzzniMqIlM2OzWIx v1tA== X-Forwarded-Encrypted: i=1; AJvYcCV/XXOBN3t9fNB9uoXPsJ1RzpYLut34yDaL4YBDZUZnawfNHN82ruo2cQk9I5O+wtOde4tibkgv5/DhmLE/hfcw@lists.infradead.org X-Gm-Message-State: AOJu0Yx9U9CosmW4y9ISKhTwOTUu40QZiqekNYLjz3uY2xj2Sp8wSmAw 7EPbJYLtkPVD9YcQ/wm9IqPLiqCaAhQwhR9V2sy3Wfzo6MKLdBcWNDT1rqhzG4I= X-Google-Smtp-Source: AGHT+IFTosXWqLxskayZ0wRDzdlL1GztSsFX/UDdCXtOBwG7ObEMDNWxQFLNrN1eK+iWQPCODsvrkQ== X-Received: by 2002:a05:600c:19c8:b0:430:54a4:5b03 with SMTP id 5b1f17b1804b1-4319ac6fad6mr150296415e9.6.1730386839067; Thu, 31 Oct 2024 08:00:39 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:38 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/14] scsi: ufs: exynos: remove superfluous function parameter Date: Thu, 31 Oct 2024 15:00:21 +0000 Message-ID: <20241031150033.3440894-3-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080041_968774_09AC54CB X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tudor Ambarus The pointer to device can be obtained from ufs->hba->dev, remove superfluous function parameter. Signed-off-by: Tudor Ambarus --- drivers/ufs/host/ufs-exynos.c | 4 ++-- drivers/ufs/host/ufs-exynos.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index db89ebe48bcd..7e381ab1011d 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) exynos_ufs_ctrl_clkstop(ufs, false); } -static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) { struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; @@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba) exynos_ufs_fmp_init(hba, ufs); if (ufs->drv_data->drv_init) { - ret = ufs->drv_data->drv_init(dev, ufs); + ret = ufs->drv_data->drv_init(ufs); if (ret) { dev_err(dev, "failed to init drv-data\n"); goto out; diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h index 1646c4a9bb08..9670dc138d1e 100644 --- a/drivers/ufs/host/ufs-exynos.h +++ b/drivers/ufs/host/ufs-exynos.h @@ -182,7 +182,7 @@ struct exynos_ufs_drv_data { unsigned int quirks; unsigned int opts; /* SoC's specific operations */ - int (*drv_init)(struct device *dev, struct exynos_ufs *ufs); + int (*drv_init)(struct exynos_ufs *ufs); int (*pre_link)(struct exynos_ufs *ufs); int (*post_link)(struct exynos_ufs *ufs); int (*pre_pwr_change)(struct exynos_ufs *ufs, From patchwork Thu Oct 31 15:00:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DEFED767D8 for ; Thu, 31 Oct 2024 15:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y2Vb0OX4E/WTGDIc/yOnji+pIDApby9HKvJHMTYprvI=; b=K8BzHq/bb93k28+uwXRPz6xYWc AkQNVz52I7fAe655GXRxJHaU/5Ft6fHV2z0qeFhVf1vIqHcybmDH1+8UisJgJncIvCu36A0JRbzhD VHHGK9QAZIeXJeHwJYtO0UbAelQl86M5kMLlCTQ0VQ4fTAtj9iU9ZIyqsGqAmgIAdVrN68bUPb8hp dJWNifh+ab/TGsl49lNWgca1a9runiM4Sn0FfTGzxIoOBieRSjcLuR8bnf2LDkNPOk4gBcMz3lMdv UHPPEgVE/fBSqfHA8yinIVTDCw97fksTHEX19OK0WDYe2o3Z+r/gPZQiXshkX0q+9CJVSLbNg6ZO5 fufxsezw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6Wlo-00000003vOU-3OJT; Thu, 31 Oct 2024 15:07:32 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfE-00000003tcU-0GeO for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:45 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-37d538fe5f2so756334f8f.2 for ; Thu, 31 Oct 2024 08:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386841; x=1730991641; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y2Vb0OX4E/WTGDIc/yOnji+pIDApby9HKvJHMTYprvI=; b=pARvwh4GN/LFeOOgtNK823fU4z5vio2hmX5DooLCzgDRgSz1tJHhnk/z0XQd5Xuo/3 cuLjB3Tj7CCtqMlfRlv83AQ9J+2lqEbLo4UX2iTE/UVOszJdZNFZeVwVnfMv8UUrYaBi b0ynPA6pQU+qbfI2lYMUT6+f0R5ZdqU18cBsflJmdjB4BQ1R3bTH8cIl5ES5L1Y4Q0/M C52OVWKlrXT+nfS5M+NALgXD/19Zu7VbI1hoozQftRwgIdFMffdt6QsKTRabnnLwmhw8 zSQFEo+zeQi5D0P4AR9r2Ys/ry+25WMiVL4aKw/PNuHJPdp8jiiUHx5vpmM46zvvKhHz hDkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386841; x=1730991641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y2Vb0OX4E/WTGDIc/yOnji+pIDApby9HKvJHMTYprvI=; b=oMAiYbMf339HBDyMTx6MHH+YRwuPVZ3z1eesh6H3vqWeNkZ5cnt4Scc8NOIu0o3sAC SzgdeWma76i3YQIk7CnpWQ3X4FPHylRdsttP5FdG/y29DVkfAmtgXbSEkUB+qeCMvxlb 7QpBBPOzWIBx32zxOBgwGTbkuQRbPqc04Q/cFpWY4Xf7Qj2EK32eTPafiiQGWPwM9zbu qB3ZuxSZebn0mJSKoeDe5/e7QNglQONGvUmc3fPFbBCWj+a07Ce5ksT44Fje++CcAwZ5 iHQs8zUhHkoclRt8IMzW7beHYNc/G3wdQcnMJzVd/eP0f18u6h+V4KDPLTX+EVtfhfM/ BVrw== X-Forwarded-Encrypted: i=1; AJvYcCVsGdaHkil6yLMzt6mjdd/V+RkjtE8QRpSie51T5fmG5ackosm1+8N0h22uINgL72lpqARoVb1ClcjKXSQjoPPW@lists.infradead.org X-Gm-Message-State: AOJu0YyEx0grEBt3dUugzkCXkeiExmF54WPyPqdf/adJ6NZkr86h3nx7 v+uiC3zATJgsXozi17FZtoY6TBA5c+HMymoduVluThdQY2NBr58isqWQ+5aJzLI= X-Google-Smtp-Source: AGHT+IGXtCtOp+k+YpkFkrrnLo8FdCOGm8rJP9u1NXSvYnnTVw6wLqsMEn/qZwk48etVCRMN23bvZg== X-Received: by 2002:a05:6000:1a85:b0:37d:4125:5cba with SMTP id ffacd0b85a97d-381be7d8c46mr2818779f8f.32.1730386840477; Thu, 31 Oct 2024 08:00:40 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:40 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 03/14] scsi: ufs: exynos: Allow UFS Gear 4 Date: Thu, 31 Oct 2024 15:00:22 +0000 Message-ID: <20241031150033.3440894-4-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080044_122416_1421CC4B X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UFS Gear 4 offers faster speeds, and better power usage so lets enable it. Currently ufshcd_init_host_params() sets UFS_HS_G3 as a default, so even if the device supports G4 we end up negotiating down to G3. For SoCs like gs101 which have a UFS major controller version of 3 or above advertise Gear 4. This then allows a Gear 4 link on Pixel 6. For earlier controller versions keep the current default behaviour of reporting G3. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: Added blank line and split hs_tx_gear/hs_rx_gear into separate lines (Tudor) --- drivers/ufs/host/ufs-exynos.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 7e381ab1011d..33de7ff747a2 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -766,6 +766,21 @@ static void exynos_ufs_config_sync_pattern_mask(struct exynos_ufs *ufs, exynos_ufs_disable_ov_tm(hba); } +#define UFS_HW_VER_MAJOR_MASK GENMASK(15, 8) + +static u32 exynos_ufs_get_hs_gear(struct ufs_hba *hba) +{ + u8 major; + + major = FIELD_GET(UFS_HW_VER_MAJOR_MASK, hba->ufs_version); + + if (major >= 3) + return UFS_HS_G4; + + /* Default is HS-G3 */ + return UFS_HS_G3; +} + static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba, struct ufs_pa_layer_attr *dev_max_params, struct ufs_pa_layer_attr *dev_req_params) @@ -783,6 +798,10 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba, ufshcd_init_host_params(&host_params); + /* This driver only support symmetric gear setting e.g. hs_tx_gear == hs_rx_gear */ + host_params.hs_tx_gear = exynos_ufs_get_hs_gear(hba); + host_params.hs_rx_gear = exynos_ufs_get_hs_gear(hba); + ret = ufshcd_negotiate_pwr_params(&host_params, dev_max_params, dev_req_params); if (ret) { pr_err("%s: failed to determine capabilities\n", __func__); From patchwork Thu Oct 31 15:00:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858020 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48349D767D8 for ; Thu, 31 Oct 2024 15:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=usrOkYEIhJMHpNEH11NB+5bvhSO9JoP7forJzaG92bc=; b=0y8NYZewxQMiPzZ/bzxS5oPHNJ Sca2WcIKLlnEDZ4h96QG3ZWiqUv3pUfi0uh3dv0Ddg1aS8EpP53e88zJh6XB1xrAvnbpqhQDd7RAc M5b9jcqXgwexVZs7oVL/VIeWvM8RISdmOd805pSQJUkYYPsVC5S6WRcsblDmONHMruJ/b/p4Mh3Ti RedtFKVS2pinNiWXF1upCPH2b3tiMfq7FcKkdj8+BdmfWtnFRH10dwPMQfwEXn0i+6wH/QE8RCXvt fiCrwaOnjzbJKz2GfLZc5VV6lTT69sKDFeAw0vik/9bOqAJJNq891r9o3BG06NmAQ926aazdmSRos QHgZzLBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6WnS-00000003va3-1Txb; Thu, 31 Oct 2024 15:09:14 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfF-00000003td0-1LTI for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:46 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4319399a411so9004195e9.2 for ; Thu, 31 Oct 2024 08:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386843; x=1730991643; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usrOkYEIhJMHpNEH11NB+5bvhSO9JoP7forJzaG92bc=; b=iLZzc5hCY8RgngjmDBDTxnCURQvLBVYT745HHF41DfRqkE9EXz19PZibCsq460zyhe tSEy0oreYFmrdjCe64dWMNelEwV5myl0r11Sh739Ay/cxYSgRwaje9izIXS0Xyh2Rvk3 j8r3GprEzdv4adwuzWj8PRUAzs3F8o2t0LX2K+hO6E3hhwkU3QQ9vxgKg9L1NOweTvxP yJ1OVqj2IP+CK4noK4T9Yco12hgCfWrar+dL6/k09yqFCyy4yfDFOAIwX1uVI+dtK+F4 eowG10h0Y53igru0otfOFHBzkhkbfoIyMDqu85JyrDYcw0bwZeB6gbGia31O3SRJsHw/ nqmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386843; x=1730991643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=usrOkYEIhJMHpNEH11NB+5bvhSO9JoP7forJzaG92bc=; b=tptwU+bq7zi/fxcM7U6Al6AgBoxIEQKNr4IOei0vKQIE/pinhQp91PFYt1QrgemaZx bY7Ak4iHNuhRtjes4Jlpnp8plfoopxGUysT9gYm1a0md2Y4ReecCgbKdbG8cX4aVVBhv LDkiU28t+seiPvDAiB8enBHVtaQljOISsxz8QZoomJCoAcXX/BmRBZjSMN8BBI1A07jc nVtOeBxdek9cAxKRdIwFTcWsUrj5ag1xbAFGC6CGdEDazjzw+o1Xfbs65ZgnU0SC6Oep 0m4njXEIJ8JTYND+CLvvjY5iKD/8bynY3D8mbCrpIFP3UcpnEyIC14RSTYR8IN6rBd3r wGRw== X-Forwarded-Encrypted: i=1; AJvYcCV/oT02qXLnqiXhYNPxvvI54SKFds3qG8xDYG5AjOh9YlNssM97fx1BhTKgPFhSA8U2i2y38t7CrDBc6/1AgBOP@lists.infradead.org X-Gm-Message-State: AOJu0YxFWL6lr5EzFgNg8VUGqYc2AUkQCIt1VeemFzh4oQ05XdA74fof dVHmDZJxYwP6OhPUnPkxrni7DJFNfYIQbxBw16KltpKlPvzZJiuqZg7sv13N/xA= X-Google-Smtp-Source: AGHT+IE2nRqDWcprFbqsyiRnRrZSmdUyGUKgVh+UN0C5kREuaiIMyson1wnaLb7mms/VbQSk1nr2fA== X-Received: by 2002:a05:600c:4a88:b0:431:9397:9ac9 with SMTP id 5b1f17b1804b1-431aa292eb4mr115733635e9.15.1730386842144; Thu, 31 Oct 2024 08:00:42 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:41 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin , stable@vger.kernel.org Subject: [PATCH v3 04/14] scsi: ufs: exynos: add check inside exynos_ufs_config_smu() Date: Thu, 31 Oct 2024 15:00:23 +0000 Message-ID: <20241031150033.3440894-5-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080045_378466_541347B4 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move the EXYNOS_UFS_OPT_UFSPR_SECURE check inside exynos_ufs_config_smu(). This way all call sites will benefit from the check. This fixes a bug currently in the exynos_ufs_resume() path on gs101 as it calls exynos_ufs_config_smu() and we end up accessing registers that can only be accessed from secure world which results in a serror. Fixes: d11e0a318df8 ("scsi: ufs: exynos: Add support for Tensor gs101 SoC") Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus Cc: stable@vger.kernel.org --- v3: CC stable and be more verbose in commit message (Tudor) --- drivers/ufs/host/ufs-exynos.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 33de7ff747a2..f4454e89040f 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -719,6 +719,9 @@ static void exynos_ufs_config_smu(struct exynos_ufs *ufs) { u32 reg, val; + if (ufs->opts & EXYNOS_UFS_OPT_UFSPR_SECURE) + return; + exynos_ufs_disable_auto_ctrl_hcc_save(ufs, &val); /* make encryption disabled by default */ @@ -1454,8 +1457,8 @@ static int exynos_ufs_init(struct ufs_hba *hba) if (ret) goto out; exynos_ufs_specify_phy_time_attr(ufs); - if (!(ufs->opts & EXYNOS_UFS_OPT_UFSPR_SECURE)) - exynos_ufs_config_smu(ufs); + + exynos_ufs_config_smu(ufs); hba->host->dma_alignment = DATA_UNIT_SIZE - 1; return 0; From patchwork Thu Oct 31 15:00:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21883D767D8 for ; Thu, 31 Oct 2024 15:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=86sA0f6Os+pjSfGkaxQ4yImAusqnRJDENyNfYooIZr8=; b=VPjr/W6hryyjKdbpxWeskLXiuQ NXIG0Tr5JcHwTbrR+rwC5sWT1Ql8eelBqLXP4zUQri0RBUyxp8P/USF+Dy+sQLGzSlH96ykLPgdqp CDY/v1oYNxgKUi6QPU4k32Upt+egB+2dFRfF3wS+IsCrMJSxTqs0HTdX3oSx54JCJonMOumX1YHFT jhTvilYN1g80NBNfRJTiAvZPd2JBxR5qzGOOCwKbKieCf/G1WbP33SKjFSdwFSj2TAy3IWZ12MgtY davsO5l7W11pJ7m5YH3EpyJny8BaYMlM/MIlS5ycDGbYMu94BASJMgIlCiSsjiEpDYXcyAr1bOn1G r+pRUP7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6Wp4-00000003vlc-2DgA; Thu, 31 Oct 2024 15:10:54 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfF-00000003td3-3FHJ for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:47 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-431695fa98bso8029245e9.3 for ; Thu, 31 Oct 2024 08:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386843; x=1730991643; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=86sA0f6Os+pjSfGkaxQ4yImAusqnRJDENyNfYooIZr8=; b=PucWpU4GJfLg6W2wulrAygLJjniv/T2MPeL03fOVNUa6Y5/RIUe3fSy0FS2YICfOxo 0R2zqH/G7cY94Ec+Dwn65ihmIZinG+wkDeg03+9cgVqOSkMEAlTS3H2WX3z8tXuDoe/p wdMq/brHN06PNUCwxagtslWUAagFpyQb81fxh+iu47Y9Gf4ux/VUhAXNH6HBiQNHBH/2 0dquUydNmNZy/Wiitp2va8IcWopeK0xpgmb38LYNyXh96mcNqsH9kdHGWuvBOs3wObaU 7O3OLBAQUyf5nKQLBC9GOie8jwEwDtCBz5C/UVOl4Hxi6yvKSw7U3r70yM5ErrnzuWYi x1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386843; x=1730991643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=86sA0f6Os+pjSfGkaxQ4yImAusqnRJDENyNfYooIZr8=; b=dHGIavEUMR2CglHFHO2vAbOePvoOM+y4GVT/bmN+oUES5DXibqwwPfyjVz/ZlFYsL2 OASH8UojbvtdStacrtkuYRtm8KU95f10J489igm8e6vaKU63yWOsU+nm0XhLPtK1LKWq kER1CtZOjJ3TNNiHnOhJlYH05rNg5XZQwv2ieU5jpMl5H5NI5qkle1VFhbOGOgJOdBFF ISVD56sUI/1iu88XeqQxmyep5dtfbRk+gPGO7sqzdzgsEWDleTVU+HtR4x61EV0PNrdD eTwBpZXSO6OM46mQIq939aq9jMDiu7XkV+HoUGfYrz2Jm4d81RWtcRQBU15ztmaJqTmO MuiQ== X-Forwarded-Encrypted: i=1; AJvYcCWv1fjyhs/NPi2LaCFlXNYswVBicqw3yFj4wAN4F8mneEqA4akPMgnASllwXzVPFiV0Ke3u9SKQUapqngvgk18c@lists.infradead.org X-Gm-Message-State: AOJu0YwJpaCc9jJIWD+XNm9n1+uj6v2dL+v+5w45bWQJvnEVs6ktp1gx Xt111WxEAGRJ5OEqZEkiuhrmwvPGEmboAxs23Sg22sWf2T4Y6U0g6Rb1IBxwvAk= X-Google-Smtp-Source: AGHT+IHBzn01GkaFrVY+fjAehvpLRixtUxLHicSEaRnq3vqepb6mFx2FPf0yhN2kuBANtTE7+uHjZw== X-Received: by 2002:a05:600c:46d4:b0:427:ff3b:7a20 with SMTP id 5b1f17b1804b1-4319ad049a8mr154531185e9.27.1730386843327; Thu, 31 Oct 2024 08:00:43 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:43 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 05/14] scsi: ufs: exynos: gs101: remove EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL Date: Thu, 31 Oct 2024 15:00:24 +0000 Message-ID: <20241031150033.3440894-6-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080045_836675_18378412 X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Auto clk control works fine for gs101, so remove EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL flag. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: Adjust commit message to use imperative (Tudor) --- drivers/ufs/host/ufs-exynos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index f4454e89040f..2c2fed691b95 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -2138,8 +2138,7 @@ static const struct exynos_ufs_drv_data gs101_ufs_drvs = { UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR | UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL | UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING, - .opts = EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL | - EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | + .opts = EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | EXYNOS_UFS_OPT_UFSPR_SECURE | EXYNOS_UFS_OPT_TIMER_TICK_SELECT, .drv_init = exynosauto_ufs_drv_init, From patchwork Thu Oct 31 15:00:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C280D767D8 for ; Thu, 31 Oct 2024 15:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HABtOu8vBnUR430AFYIUSUDi3ELEcFC5jVUmm0tB11Y=; b=UNkII3bXXV3gMxeqXuzKoRjJf6 ygWzBnv0gg71+3FUoPQ4buS5/5Wxg7amS8nt71WY0qyvrX0szLrsIIGufF8BjByoOf5Rnym47zzKi TvwdgtOKeR9DcAmBDTRIO63E8nVLLUIOeU5XgepwwVCb7i5A45y3buN1/3qnISyL5DZr7fIFC4G8B GwIvqDBI2ossk8XI6FptftO0IfbONRT7ZpoEKjYivr9Cr9OaD0L2XcvZrR0g7IwQo5czNkB5ls5h3 iSOWfimW3Zf4b3s2h2IL+jCodHOaGsctOef0tl3JGVOEuSnIP/6KaUhCIv1FG5Qcv1Zf/0NssNbRS TlURnO6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6Wqi-00000003vzZ-0CnP; Thu, 31 Oct 2024 15:12:36 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfG-00000003tde-0iHZ for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:48 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43167ff0f91so9262725e9.1 for ; Thu, 31 Oct 2024 08:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386845; x=1730991645; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HABtOu8vBnUR430AFYIUSUDi3ELEcFC5jVUmm0tB11Y=; b=GRAfvvc+NiEOGxjNcc4vdWmBRuCyYPUEXsP+Nk5EDdr1tIaq048hnUWjMng0w1sXta hVk93acq5A5gIEJ/9kDTUYCiADgraA248sGgeXoR5faOynOxLkrPJSJd/B6OudC+kTYt OBNIzBc11cEo64EV9PU3ZZT5IbtHxy2/VbHHI2N4xguPxxqaQ668nFCeMUxed7legRXk gkWtBJMkODRMBUjDNTeRGxUup+YHV2L2VR3NN47vK5KETiJ9CS26WkcdxkaXc7Lr7XgA SdrQF1RtxZc1zBMtlKEuIuAWNkA1nKibFvH12FKvv4hsXSfVrltVoD2Ml20s3LKA7us6 1q4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386845; x=1730991645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HABtOu8vBnUR430AFYIUSUDi3ELEcFC5jVUmm0tB11Y=; b=ddSiFzwUZdQSF5rJMVnokaBlK2WDC9RpEkRQ4EKOHUkoQOiH3E+dE9Uk06vpnXW512 itzXta1b//+MfSitmDuZ7VGt9ENZbXB/WIBs2NzeFx4ALwXfHkh53bltD6HDrn1JZy3q LydELphxnsTv8kzFdRtA0v5yxCSB5OTWBPaBhdfYvHAmwGpPvG1edS7r5M9b/oqiL6u0 YKDbKLzt3+4Dra9526fzlchhFXbOSQtp24Ic7sKaUuMoJshTa2U17asYCGAbiEuWBySM r7SgKTfMSWxC5kUZWuPkY+Y2ir1r3cks0FsJetSqG+gRCSsm1Kf8PRqPsOajgJNXnlcf 9pOQ== X-Forwarded-Encrypted: i=1; AJvYcCWqy9Vaa4tOUCkoEA7DFU9KFZ+IVUX20ErB2Z7+uhnemVIBR/2iws0+FbQ9RKp+0DiRBZ9BcLB7VI72i2MdordD@lists.infradead.org X-Gm-Message-State: AOJu0Yw3z5hjBU6CK5orgoY0jOODUrtl47ICEOrs6oOlrPJQ76VY9Uty dcp2ng/aYSswM/glWmfmdfI/DpaYs5HylYNahXkaLQS6iTVjGvvbsEVIhfQLv68= X-Google-Smtp-Source: AGHT+IHrOUYyAxFC1VJUc6y5oX3ddkyV0eSXyUdqL+WEdAPlUpCNJwf8n2c1O5ZakYFeCDJkSDGQIQ== X-Received: by 2002:a5d:64a1:0:b0:37d:4fe9:b6a7 with SMTP id ffacd0b85a97d-381bea1c1f4mr3210183f8f.36.1730386844715; Thu, 31 Oct 2024 08:00:44 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:44 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 06/14] scsi: ufs: exynos: Add EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR check Date: Thu, 31 Oct 2024 15:00:25 +0000 Message-ID: <20241031150033.3440894-7-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080046_236868_E79501DF X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The values calculated in exynos_ufs_specify_phy_time_attr() are only used in exynos_ufs_config_phy_time_attr() which is only called if the EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag is not set. Add a check for this flag to exynos_ufs_specify_phy_time_attr() and return for platforms that don't set it. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: update commit message (Tudor) --- drivers/ufs/host/ufs-exynos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 2c2fed691b95..0ac940690a15 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -541,6 +541,9 @@ static void exynos_ufs_specify_phy_time_attr(struct exynos_ufs *ufs) struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; struct ufs_phy_time_cfg *t_cfg = &ufs->t_cfg; + if (ufs->opts & EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR) + return; + t_cfg->tx_linereset_p = exynos_ufs_calc_time_cntr(ufs, attr->tx_dif_p_nsec); t_cfg->tx_linereset_n = From patchwork Thu Oct 31 15:00:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858038 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03312D767D8 for ; Thu, 31 Oct 2024 15:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EGlRIDiWOIW/oUdNVyUFBt1pPENWr+qbw5BPnPtDdZA=; b=M+Ec+eVg0hdgP4NGt19DH8QTKk KJ/QoqDrtQnw1iewi6qSPrVOep1QUfdUF0fumNVb0HLWclIrn69kuZdMM+pXopSqGvr/kF6i2HtoX jUOxyqb+e45BQpGWMMbA2woHWCI+YDjtsg738jBhu/laNmtTRGvmoEqoD3HFiXF25+/oIWqLBwghn rjyM1Hi7+Iw+nKdDebYa1LqDrQGcSj03spH7/x2aVUsy9fxAA/5TECD9NkbXhJC6nzppuRyWSho/M JQHgMfFRNdQDTRWtN3RKiintpes5u2jQkznk2uVbQWXANUQDHdi5RjBsx0xfLZ/Ku5F+FbI1pBeqE e8YFJAhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6WsO-00000003wRL-2jbf; Thu, 31 Oct 2024 15:14:20 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfI-00000003teu-2shu for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:50 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-53a097aa3daso1007884e87.1 for ; Thu, 31 Oct 2024 08:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386846; x=1730991646; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EGlRIDiWOIW/oUdNVyUFBt1pPENWr+qbw5BPnPtDdZA=; b=kyIyesYUtMeO1hNufFR2zWhFlYPfaU/XTE4zp+WWpJje3OTcCl+1hTa8XbiIcQ1q5X I4TZYZEQWceuZuipKnUssEJCsOHzasxiJ0t4RJOVlumI3xYT94+Fb9Vv6dHbzOP9Xhpt GEKaV9X4Lutm2fkxKp/xiWxM7axwIc+pe98NOZj9iUIw4PWrHi5cBzqd7obqJaRC7NCr gX3vnAjatpvA/zv05Ci9RAWJEndoUgYlLLebskB0a3DuGRRkT9p3o2fm3VzriAslh5Vm xrDrp5RjIOm4m4/FMcUSBQABWJ1VeV0gMm0y37ks5ioUfnH2+kYBK67Eg0e6U9P9QaWD qi9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386846; x=1730991646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EGlRIDiWOIW/oUdNVyUFBt1pPENWr+qbw5BPnPtDdZA=; b=YHiDid9uHkNI9BmyedRfV6lOT7ks1VURg3+COQ6cv3NVrbDnzQUKy6M/maFDbCFIS+ qhKU76dND95hRwvXVMvE0L2/BYEH9cg7GAr3XHyUkoycQdOYu9H32JFUJgk8FFyWO563 AIJo1bkdms/eZy8kzQNb04Rnc6a412ms6/OnGlMkZ8BXJqTXFHPLHuLoNyraJvsPG+1b 67sRNOZv6BfFV8IvxxauOPmtLdlH62M/HMkvyqlmZCLABmUyNIDakqu0j0Eop4x/It2x /FigheVReNiTzCd7Hs9If3R99rQhirDe22tXUxPFSou2ytBKLX4+wT8TEAWmg6BflgPa 3fIg== X-Forwarded-Encrypted: i=1; AJvYcCVZGo2F/5vvEYOVzs3tm49u93+6ML59x04DGn9Ht199iEjcugwn+3RGSi6gZ2+CfYzv8j8spMrMcR+N/pjF/qxB@lists.infradead.org X-Gm-Message-State: AOJu0Yx+M3TaZED05eLkfXOfS2NiSYUe7eWqZ9RrIliDNYJV5NKRVJz9 7otxyTofCe9JMmMTuiovM6b0T0D+S5INnFnkUwLTgeXyVxbjCZNLX1zts0fXntA= X-Google-Smtp-Source: AGHT+IEXzbBlOP0V8hZQy8KaxBb5hcC2ucoOBrtqsnAW7CPkAU8t5qtuC/NhFTjTUjwZ36RRBVibJA== X-Received: by 2002:a05:6512:32ca:b0:539:93e8:7eca with SMTP id 2adb3069b0e04-53d65e02513mr162912e87.35.1730386845937; Thu, 31 Oct 2024 08:00:45 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:45 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 07/14] scsi: ufs: exynos: gs101: remove unused phy attribute fields Date: Thu, 31 Oct 2024 15:00:26 +0000 Message-ID: <20241031150033.3440894-8-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080048_751579_DD3D24AA X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that exynos_ufs_specify_phy_time_attr() checks the appropriate EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag. Remove the unused fields in gs101_uic_attr. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- drivers/ufs/host/ufs-exynos.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 0ac940690a15..e477ab86e3c1 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -2064,26 +2064,6 @@ static const struct exynos_ufs_drv_data exynos_ufs_drvs = { static struct exynos_ufs_uic_attr gs101_uic_attr = { .tx_trailingclks = 0xff, - .tx_dif_p_nsec = 3000000, /* unit: ns */ - .tx_dif_n_nsec = 1000000, /* unit: ns */ - .tx_high_z_cnt_nsec = 20000, /* unit: ns */ - .tx_base_unit_nsec = 100000, /* unit: ns */ - .tx_gran_unit_nsec = 4000, /* unit: ns */ - .tx_sleep_cnt = 1000, /* unit: ns */ - .tx_min_activatetime = 0xa, - .rx_filler_enable = 0x2, - .rx_dif_p_nsec = 1000000, /* unit: ns */ - .rx_hibern8_wait_nsec = 4000000, /* unit: ns */ - .rx_base_unit_nsec = 100000, /* unit: ns */ - .rx_gran_unit_nsec = 4000, /* unit: ns */ - .rx_sleep_cnt = 1280, /* unit: ns */ - .rx_stall_cnt = 320, /* unit: ns */ - .rx_hs_g1_sync_len_cap = SYNC_LEN_COARSE(0xf), - .rx_hs_g2_sync_len_cap = SYNC_LEN_COARSE(0xf), - .rx_hs_g3_sync_len_cap = SYNC_LEN_COARSE(0xf), - .rx_hs_g1_prep_sync_len_cap = PREP_LEN(0xf), - .rx_hs_g2_prep_sync_len_cap = PREP_LEN(0xf), - .rx_hs_g3_prep_sync_len_cap = PREP_LEN(0xf), .pa_dbg_opt_suite1_val = 0x90913C1C, .pa_dbg_opt_suite1_off = PA_GS101_DBG_OPTION_SUITE1, .pa_dbg_opt_suite2_val = 0xE01C115F, From patchwork Thu Oct 31 15:00:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 762A0D767E3 for ; Thu, 31 Oct 2024 15:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CdJwrtv6R6hjXktx6QL/5y82lOaBKNXG+b2XzR89bZE=; b=C/JGQMvJIO4SgfLm3/2OAIntcB 8eG9WrqXXCEXnv2vVscBbUKqhWhzZcqHYkfpiQaW4TXNyI+AeafXQT1EcDIBmgzsTRLCGx62NyKnV fhqt1NM491wXDSIhMYN/ufUCqFuGfe+4WGtMsGM/TjWqX07YAEO9gkOL3sNuE05trjrTcMZjKMyRA QTwnx3D1M3fogQQ/B/xYZvE5SCdqgB4SC80wrkxOdBjNWTwjtLtMuN5ssKBfbaL5d/E0nJs0NW9du a+MpRhgzLeZMtXs/tT+4ri+aJgV+c4/d96dj+11MaZ82mEw1MrNKMSZhYmD8Pb4msib5CS/BNoxeo wHQ4BRVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAh-000000040aH-1sEk; Thu, 31 Oct 2024 15:33:15 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfK-00000003tg9-44E1 for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:52 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43168d9c6c9so8633505e9.3 for ; Thu, 31 Oct 2024 08:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386849; x=1730991649; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CdJwrtv6R6hjXktx6QL/5y82lOaBKNXG+b2XzR89bZE=; b=XtMh+AedvZQSEEQoDI1Ko6HQ0lehrqF4GtWc8lLAj0ahB92e/RI0pLQiWYVHoVXkZj KXzhuZSHr9EiMUIbnpXxjJ4/tuJx+zabGEis/PJqbkxr3TvwS9jlSWts3l+4oKITwFUx SDdGJOrvCrFfASIjmCKDtTwfRMIxbit1GEJ4JyONEVWxqVPiNRks46fnhWeLvHhI75JE vgMgWUwdcv8/Ydi7KnSt5zHIqK1Lj9o4kHn4/eEhwQc2S50FxVSp0dR5qKigJpYsXizf qAJfgqlt9h/xNDtINigx5tRvk5fr8XX5MSndeMNNr4lDx4BCuHu2g3ACB2BTTIX06JjZ IEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386849; x=1730991649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CdJwrtv6R6hjXktx6QL/5y82lOaBKNXG+b2XzR89bZE=; b=eFoXXNF6oylvMG5sHfMnlfMqL/wXkp6xSjXvYlcGozb70vY1NnoBujhL+PQUFa5iAs cQYnz7yNTZXc6JSbTclYwnS6zps8o/lzB9rH/oxDzMljdRNqeuKCRJeBibJXmr8sZZfD vrWE8/JQ4wHYxh06GDc6k5rocF4LAL1xShMR9BlVGjQW5PiHawXABTHMiGe0bnew0x0S 8LRglgE8FPpZcbBjbVV0yd/Er5fjAm59XmkwQyFTuTdEaF05HqxQIIXEagt1f5OzZsry yeT0853c/arJ079pJSvBGo/2CwJXM0oMX9d1jkt3hjGhIctRTRWlM5kANlrdlBuZs1EO fhgg== X-Forwarded-Encrypted: i=1; AJvYcCUUgWPk1cwdp5Wbx8n/ep4z3A+FXhPpUH/9Hw7h4aspOPtPA/PRDJU/UuCQYfvzMzv8ylUKY3OLfaKSxKlG8zsZ@lists.infradead.org X-Gm-Message-State: AOJu0Yy/kxiWVi8avrRD4Zm2FvmNng4qJ1C9bqlQUMvcBbRAPJEKZTbT 1WobFbRmuFyB4GJ2r0spU8lB9Vc4Gqe4AkVqBcAT1xivRv9+HEV2RTPxcrmmozA= X-Google-Smtp-Source: AGHT+IGte4mqUxYrFCHTiw7rYYrBl9FrCw5E7TjmHzs9HacaVeMVUjhzif1Rg3DaulCZuAOdHbN/KA== X-Received: by 2002:a05:600c:45cd:b0:431:5eeb:2214 with SMTP id 5b1f17b1804b1-4319ad363eamr152298075e9.33.1730386847155; Thu, 31 Oct 2024 08:00:47 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:46 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 08/14] scsi: ufs: exynos: remove tx_dif_p_nsec from exynosauto_ufs_drv_init() Date: Thu, 31 Oct 2024 15:00:27 +0000 Message-ID: <20241031150033.3440894-9-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080051_028951_74E8A8B0 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove the assignment of tx_dif_p_nsec as both users of exynosauto_ufs_drv_init() function (exynosauto and gs101) set the EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag meaning that tx_dif_p_nsec has no effect. Additionally both users also set the samsung,sysreg dt property, meaning the execution flow will always return on the regmap_update_bits() call before the assignment. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: update commit message (Tudor) --- drivers/ufs/host/ufs-exynos.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index e477ab86e3c1..378c16d905c1 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -200,8 +200,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) { - struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; - /* IO Coherency setting */ if (ufs->sysreg) { return regmap_update_bits(ufs->sysreg, @@ -209,8 +207,6 @@ static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) UFS_SHARABLE, UFS_SHARABLE); } - attr->tx_dif_p_nsec = 3200000; - return 0; } From patchwork Thu Oct 31 15:00:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07C7AD767D8 for ; Thu, 31 Oct 2024 15:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+843px0rCbg1sKJc99pP4x3dOG1mc5oHs0HJIyYuQ44=; b=grAhBRkUaVzLl1PnzKISUiVUBL pRxaEkIsOOFMTqMyyWj2n5qh2DA7RlF6X5F3BR05uTXLDNFgvcIgQs645+avGSvS/NCLdIt9SB2r+ ozd4v07KekoBtTNbXFg/om2HUZeO+kUmOC+U33whEkX3VE7vOeSNafdWxHqnwWA5NKnfXCyhgu5XT J+0yv0TcLjo6SIywM0hvEtrvf7thg2kVqEtQ1EhvcjMOeHhe81FfXTI+XSsjfTrSI+P0RlKAjlesu 4ctuTOx4q5v/UOl2Fa3jC5///kaAFThNqlzC7lRW17zxvO2PjewswDQx/eAQZDyBZ0dNbQOi26hWz U786mLXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAi-000000040aN-0hkQ; Thu, 31 Oct 2024 15:33:16 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfL-00000003tgE-1nJu for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:53 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so9182015e9.0 for ; Thu, 31 Oct 2024 08:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386849; x=1730991649; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+843px0rCbg1sKJc99pP4x3dOG1mc5oHs0HJIyYuQ44=; b=rm4RS/bkSEgK+6YshUOhJZ248kXksQA/1Jdnvz8KI5zVLQfCeNS/xz8ePsVyVL4wvG kLbUQektS8doZxUpsXLwC4TRUxraQEQAjwA5bfH+TnisEQQ85A3xCayopt8/3zXOtl01 wC/7IB/4B55hXkKd0dMuSfauNfiImMmXjieZ/EP9iRIhtI4VLhNsLlYtprEMsrGg3bP8 jj5HJsnudXcVdVMuXdT3WtpP+w7rHXtgyjp39bLVNQ2FCZSTuTl+t83iOD+MorLRva9i 2IlTzFV+V3sCNeuDdTcRLqUqa6z7EjVfncsCxqbbG+LzBr7wHHUpjI1fLXfwRxCqfdt1 YraQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386849; x=1730991649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+843px0rCbg1sKJc99pP4x3dOG1mc5oHs0HJIyYuQ44=; b=ISBpS2NkUjcImI9mHtskuF1y3YgBsYt9FpYhd4ev2mRc9j/gY6ybaA2TKRu4BH6pIV gYiHHJrw9GzdEGQAEdGNMyeueFFPLwUdzPF6nPg+vFah3YBoBuXyR7GcaVzaM127BmcN w0Py6CyNCuVSZnxQ1H78tfj0/nWJTVpwFzzg/rbQekTHBW7W/c4RVcO/kczM4PB3x7oW IOzokdpm75yl5DPeKaeFdzjzaw01AkKmSlFd9ouR8pCo/PPolY/eOE2vWdeAWMQVOTeD kgB4WAHdggDDKOlTMNtxXnhPyI3BC7/0cLj20zp0sQM8isRRCX04+/xJwbrpTWzHHxGP AQjw== X-Forwarded-Encrypted: i=1; AJvYcCU6L5TJhDQLN0jPdSsOntEj1knxT5xXAw1hpTyDoAumTbIwQ4zDAegDdIBq6sXYliM95yKCVWbYU8CtJifyJwN4@lists.infradead.org X-Gm-Message-State: AOJu0YyKczpwjTropXw9Qv7bF8zkGt5VIhpvaY0O4va4KmMiISKfXDfZ I+gjBqyuuZnrZglZCGgMH2klrjuyUX2z0byN912l+9uJ/cvtU86Z10oHlPkWRQ0= X-Google-Smtp-Source: AGHT+IFz1+UYr4hSStn9sPc2pavAOWRlpkPtO9pHTEtEu9q/PXw/hM8RRdJlrb371+ewLtzLK5Lt6Q== X-Received: by 2002:a05:600c:3587:b0:42c:c401:6d67 with SMTP id 5b1f17b1804b1-4327b6f464amr27709765e9.6.1730386848476; Thu, 31 Oct 2024 08:00:48 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:48 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 09/14] scsi: ufs: exynos: add gs101_ufs_drv_init() hook and enable WriteBooster Date: Thu, 31 Oct 2024 15:00:28 +0000 Message-ID: <20241031150033.3440894-10-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080051_583264_D6FBD861 X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Factor out the common code into a new exynos_ufs_shareability() function and provide a dedicated gs101_drv_init() hook. This allows us to enable WriteBooster capability (UFSHCD_CAP_WB_EN) in a way that doesn't effect other SoCs supported in this driver. WriteBooster improves write speeds by enabling a pseudo SLC cache. Using the `fio seqwrite` test we can achieve speeds of 945MB/s with this feature enabled (until the cache is exhausted) before dropping back to ~260MB/s (which are the speeds we see without the WriteBooster feature enabled). Assuming the UFSHCD_CAP_WB_EN capability is set by the host then WriteBooster can also be enabled and disabled via sysfs so it is possible for the system to only enable it when extra write performance is required. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: update to new drv_init() protoype --- drivers/ufs/host/ufs-exynos.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 378c16d905c1..d59e1933b64e 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs) exynos_ufs_ctrl_clkstop(ufs, false); } -static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) +static int exynos_ufs_shareability(struct exynos_ufs *ufs) { /* IO Coherency setting */ if (ufs->sysreg) { @@ -210,6 +210,21 @@ static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) return 0; } +static int gs101_ufs_drv_init(struct exynos_ufs *ufs) +{ + struct ufs_hba *hba = ufs->hba; + + /* Enable WriteBooster */ + hba->caps |= UFSHCD_CAP_WB_EN; + + return exynos_ufs_shareability(ufs); +} + +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs) +{ + return exynos_ufs_shareability(ufs); +} + static int exynosauto_ufs_post_hce_enable(struct exynos_ufs *ufs) { struct ufs_hba *hba = ufs->hba; @@ -2120,7 +2135,7 @@ static const struct exynos_ufs_drv_data gs101_ufs_drvs = { .opts = EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | EXYNOS_UFS_OPT_UFSPR_SECURE | EXYNOS_UFS_OPT_TIMER_TICK_SELECT, - .drv_init = exynosauto_ufs_drv_init, + .drv_init = gs101_ufs_drv_init, .pre_link = gs101_ufs_pre_link, .post_link = gs101_ufs_post_link, .pre_pwr_change = gs101_ufs_pre_pwr_change, From patchwork Thu Oct 31 15:00:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858090 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 610AAD767DE for ; Thu, 31 Oct 2024 15:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/9jgbEBOHttlHnzoEFJvpzWVhBO7kDylk6QvL3iIgjQ=; b=iIW+FWns3xJRGjq2hTtumf21he 9m0Mbiw2s+BqEroZlSA8HXCJP0Kd74ShkMn4N+o5LfTd34Yds18pplf6UfjfuhGaCT5B88sE8mPKJ JImRgF5UzI0qA5ou6jnf6urcA4Ddq3sqSJavYO+g+8tJTc/uAOrdI4z7VE01A+6iTt3NOPsT8L68B 5z7gHGKR4XjVI87Ny56Ru+JckhrkQUzB9o9RbPPAoWWILK+4Cj8GOd5vqFplo0oS4qwdXFdHuqyva qLE9e29XxWxbLrsgX8t0cqEBHZ2f3y+vEF8UBAJTciK2lJBCW/o8Bik+b4v1Z3C3s0D62exDrrRIo 34aNIWXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAi-000000040an-3dBR; Thu, 31 Oct 2024 15:33:16 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfN-00000003tgd-1VHU for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:54 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43168d9c6c9so8633875e9.3 for ; Thu, 31 Oct 2024 08:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386850; x=1730991650; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/9jgbEBOHttlHnzoEFJvpzWVhBO7kDylk6QvL3iIgjQ=; b=AGjmPv4KcE1xlaxwxth3+VIvC4rDqBZkwsi3CvKJd15pV8lZvYy2UcumhLUjAKiWaD Im00CIHTlPPSUa6cUB9agKjOLwkupVrdyenB2OHRek2mD85RRzLr7ZvWdMJlBIOeF+oH E+SFqVjc66dVjSWNm0s3gQ+dP9W8KU716iNu6MRZXn/xYmucg11NFdRE9jAv+hSH7dlU le7GRroq5hJmNpU00YY9FnEDeYXAhTRPOqeCd6KZBCNYmBytfMIyi9fPHTW33+Ymktwo CB34WPX3GhNQSg+SufimUHIsfRxXLNuN29jV5El/N/RCwjzvKM6cURdpB+MxkBofjQ/6 6+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386850; x=1730991650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/9jgbEBOHttlHnzoEFJvpzWVhBO7kDylk6QvL3iIgjQ=; b=vXHqjwmv3H+GUIXLLPmzLoKDjPFrUEfU+ip9avT4yE3pRWE9YNZXpOiOXaU5dEl4Fm zgECzrl7FwBrXZbwBUNV9j/KuNw4tvmQTYgCPFzDNL6qpmbDyDVXhJPn3NbAtmBwP05l 4hWubGZmIwqYlzF1G+yxX7Br8IKLQj6/6tK0cCOv9iMlfzhvK6UzN/fqnBxumKckngxf MQ1yyJIZ5SHCI7UlPfPkDZULkSu3PVy2x4qSjbSyexnhgciJM8Qd+Ij9lMMiU0ofSf7z vFNOzBUlvFpckxGD+s6hNlEv6P1KLeLLDSjSgp72YIidwq+d3sLGRXrlQR2UH/rEE0kC ZX2g== X-Forwarded-Encrypted: i=1; AJvYcCXx0QUOPqxwEWmh7e/YZtR4SH4PIA7AyTbb5P4gM1Bb2RENI9PWZ7Y06P0n444/FkcCPOoYRJHNq2lxfVwgaqvF@lists.infradead.org X-Gm-Message-State: AOJu0YxEO8TynHBWdjGVtCS2S0x+Lg5HyCZ1bQHDRjQifObqXOJbUU1H /zRtoRmHeEQMOQN0X3ghCeh4TFkDPEaju7rgLoXknasvAju8mv/MuGgMUkybOoo= X-Google-Smtp-Source: AGHT+IGBloKnQyzK042bxpPzzNwKfFJqeBubjE+dIc7DcjDnTJukogo204p6ptQH0HImb9KtmNPitA== X-Received: by 2002:a05:600c:1d1c:b0:431:55bf:fe4 with SMTP id 5b1f17b1804b1-431b17365ffmr107037035e9.24.1730386850219; Thu, 31 Oct 2024 08:00:50 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:49 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 10/14] scsi: ufs: exynos: enable write line unique transactions on gs101 Date: Thu, 31 Oct 2024 15:00:29 +0000 Message-ID: <20241031150033.3440894-11-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080053_565584_3AA0B7E3 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently just AXIDMA_RWDATA_BURST_LEN[3:0] field is set to 8 in exynos_ufs_post_link() function. To enable WLU transaction additionally we need to set Write Line Unique enable [31], Write Line Unique Burst Length [30:27] and AXIDMA_RWDATA_BURST_LEN[3:0]. To support WLU transaction on gs101, both burst length fields need to be 0x3. As all other SoCs expect the current value we update this in the gs101_ufs_post_link() specific hook. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- v3: fix typo s/burth/burst typo (Tudor) v3: update commit message (Peter) --- drivers/ufs/host/ufs-exynos.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index d59e1933b64e..78307440107f 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -48,6 +48,8 @@ #define HCI_UNIPRO_APB_CLK_CTRL 0x68 #define UNIPRO_APB_CLK(v, x) (((v) & ~0xF) | ((x) & 0xF)) #define HCI_AXIDMA_RWDATA_BURST_LEN 0x6C +#define WLU_EN BIT(31) +#define WLU_BURST_LEN(x) ((x) << 27 | ((x) & 0xF)) #define HCI_GPIO_OUT 0x70 #define HCI_ERR_EN_PA_LAYER 0x78 #define HCI_ERR_EN_DL_LAYER 0x7C @@ -1922,6 +1924,12 @@ static int gs101_ufs_post_link(struct exynos_ufs *ufs) { struct ufs_hba *hba = ufs->hba; + /* + * Enable Write Line Unique. This field has to be 0x3 + * to support Write Line Unique transaction on gs101. + */ + hci_writel(ufs, WLU_EN | WLU_BURST_LEN(3), HCI_AXIDMA_RWDATA_BURST_LEN); + exynos_ufs_enable_dbg_mode(hba); ufshcd_dme_set(hba, UIC_ARG_MIB(PA_SAVECONFIGTIME), 0x3e8); exynos_ufs_disable_dbg_mode(hba); From patchwork Thu Oct 31 15:00:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DB7AD767DB for ; Thu, 31 Oct 2024 15:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4dhr5+lgkwJp/4xdbeZNcQAzRLkNmuREPhlR8Kw0nM4=; b=3Jv3dQ8UzFhCzAy1ut3BL39IFK NP/DiYM0o77p7jrYZNuD9bFlWU/mTSua7RBj/6sldD0oNC5O5MRS55ezZ85zw91PSNx25ifZVO+36 Ph/5v9eztwMt8ePHnd3BXZkENpbIFNBlPcILuYaalzuHRdPtoQSNqgw34koKLNn1KF1JygOpSQwwT 3/Zg4/xhX8goQ4W4iBxRdgs5lgLkCJKOPa2uNg8eZH21TNmUB/gX/CJ3gwLvrgDN9xjVQyFXP5BKv Vj2TRgugDttkdgcJZ5AROAsxiekCb+Xgys6Gq64PiYvDWM9WZ1VqnoRBzL28BADF9fryusfBmTiDz vv606yRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAj-000000040bI-2HOy; Thu, 31 Oct 2024 15:33:17 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfO-00000003ths-1eec for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:55 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-37d3ecad390so1382144f8f.1 for ; Thu, 31 Oct 2024 08:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386852; x=1730991652; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4dhr5+lgkwJp/4xdbeZNcQAzRLkNmuREPhlR8Kw0nM4=; b=xZ19lwjQwSotFCKOkslDP8h/Zv5YDXH2VmfFDrZ/o4t2ir64hK67tXlFkVJkc69pfc V3qAqOq/5NdIlviJDrOXuLvjqpmYtQCC6QtwK+aI69d1yvAeEVHUlicRb/wrR2LXGrg/ 0t3l/7ZVG3HLit+UzLWSfJQPpK4reUdaE0FAxdE925iYZhcCpLNnMs5GvjO0O0vqVrwK zI3MVSzXGW+XujT6N/DAERdL3feYZV4nPsmiU79P+5c5R/+HJR0D4kJYX6/erYMJswT1 QoC6UDs0Vv1MQ9aecRk/9zmLTrUGIjKODvtlP3NKu06UrGe3Hm9CYr0ELoIh6jo6euRc C0XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386852; x=1730991652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4dhr5+lgkwJp/4xdbeZNcQAzRLkNmuREPhlR8Kw0nM4=; b=v4EPVVawZOHL3Yy5VHfgISeqU21FP5cFEF3lx2OOJMEaAAVuR2i5k4dcMkKP8vjxU6 QG4zOF6MFrIshMQnHH5O4eaMHTXa/gUrBVLL6Pk+Xrr58eLcVhjleOi2cOhTDIIu6nIz fRZnLabd7hBi7hO/vtfs4jo/IJRjMgXp9EjiDxQ3Uc2W06RlftXgHDEIR4ZLqqih1k+9 pqEtcK3thri1ZsISNGCLvN57td91YCIrfKDVLtlbAOUsdeU0EA9PygDPBAv6aFRhaHdH OlVzmnlAPpt9/W+M42keHH6Wi8ES8Zv1g3sSAGPeRXwND92zWxcsp3eceh6m3QiUrsWk oWzw== X-Forwarded-Encrypted: i=1; AJvYcCUeDojpLoKyNoAbuHv3gIO1WNGmxnZYrw5dGO41RB9Y9SDR67FUaAI0Ty3JfbLNgAApZDUQlZ8azFrNl+wJEJXb@lists.infradead.org X-Gm-Message-State: AOJu0YxGwdHpbL1UYo+Wqo2xsO53qZNPm223SJI/rIJ+FTUVxR5sqXkv NYW3hN4JUpn43XwqlCVuUbzJpUMTRBQBLk2Uqr1Iu1XHHbTJwMTrnDXRVpZTSqw= X-Google-Smtp-Source: AGHT+IHKfc7pJ6Zm8piuDfmKaMIbjSaLV4oLGDh35XiuzbNsP65XFtHQ4OrcCPyxEHtqyv/uMEAbZg== X-Received: by 2002:a05:6000:1566:b0:374:cee6:c298 with SMTP id ffacd0b85a97d-381c79e3662mr280380f8f.21.1730386851639; Thu, 31 Oct 2024 08:00:51 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:51 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 11/14] scsi: ufs: exynos: set ACG to be controlled by UFS_ACG_DISABLE Date: Thu, 31 Oct 2024 15:00:30 +0000 Message-ID: <20241031150033.3440894-12-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080054_466273_0598CBCF X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org HCI_IOP_ACG_DISABLE is an undocumented register in the TRM but the downstream driver sets this register so we follow suit here. The register is already 0 presumed to be set by the bootloader as the comment downstream implies the reset state is 1. So whilst this is a nop currently, it should protect us in case the bootloader behaviour ever changes. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- drivers/ufs/host/ufs-exynos.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 78307440107f..5078210b2a5c 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -76,6 +76,10 @@ #define CLK_CTRL_EN_MASK (REFCLK_CTRL_EN |\ UNIPRO_PCLK_CTRL_EN |\ UNIPRO_MCLK_CTRL_EN) + +#define HCI_IOP_ACG_DISABLE 0x100 +#define HCI_IOP_ACG_DISABLE_EN BIT(0) + /* Device fatal error */ #define DFES_ERR_EN BIT(31) #define DFES_DEF_L2_ERRS (UIC_DATA_LINK_LAYER_ERROR_RX_BUF_OF |\ @@ -215,10 +219,15 @@ static int exynos_ufs_shareability(struct exynos_ufs *ufs) static int gs101_ufs_drv_init(struct exynos_ufs *ufs) { struct ufs_hba *hba = ufs->hba; + u32 reg; /* Enable WriteBooster */ hba->caps |= UFSHCD_CAP_WB_EN; + /* set ACG to be controlled by UFS_ACG_DISABLE */ + reg = hci_readl(ufs, HCI_IOP_ACG_DISABLE); + hci_writel(ufs, reg & (~HCI_IOP_ACG_DISABLE_EN), HCI_IOP_ACG_DISABLE); + return exynos_ufs_shareability(ufs); } From patchwork Thu Oct 31 15:00:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858092 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C468D767E5 for ; Thu, 31 Oct 2024 15:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pek064Hz7CIKn8YheYCxRzKFA8nRolzJISWb5PBD7ls=; b=pDfIJVhIs2iv8vh34RKSj+RL9R GeA6IrfbcHk1bwcUeXas1HuBCDV3LDxZKJOEK66hQ0w5CDFMYaKcpRX3hlWMYyfx0Stei9fmnZ6wp f0b4Emf5fF7Efs6Sw68K/delDYFV7hClJDJRnH4KDvRFQdWyUvStcNutab2I5hn5Nmb3rPWv8vbyH 3+McpKWswqdE5riHS780yEqo1E7aUbLu/1/s9EOexwNYW5N+11Ua+IVCj8k/WBPsXO9hjZy52S32y If5AOwDSpIqZVJMdZhOKjwEzLzaXfTfR3+e2e7dr3tF68YtIMJAA+cAHZwTTL4GCDPYtVn3YB+vbO GavSf5fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAk-000000040bY-0vrr; Thu, 31 Oct 2024 15:33:18 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfQ-00000003tiU-027W for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:57 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-37d538fe5f2so756479f8f.2 for ; Thu, 31 Oct 2024 08:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386854; x=1730991654; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pek064Hz7CIKn8YheYCxRzKFA8nRolzJISWb5PBD7ls=; b=cLiqBmiOUntAnaEUXltJ3ZAtQ/PtgjEHxEJl/7oybq3HnHo8XyRlziuSfhlj/YmglM R0G/OsWLeA6MwvYw/SwMlNYjZvAWZTJq4MKMHvpazbzuOiO6w76eiRkQXxrmD3Vfdzgz eXp4nCdzpU4M+kyciPI4zJvKWCtsQyq1zWO0/TXVYUxuYleUbM4+BxyCEC0iKSyeHbUA 2nMwEnDfRmiQ+EfDLYyoHzZbiJaffdr87GWoe6oxGXG/ujJr8Dkq9VgLBxxXpqHPwLUr o6scOhsmuVTtPqpxYyqmp7IgwccfGfCICFInsj9QwiaDMEXbNsBz414CL1zUg4N7WS/h zB2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386854; x=1730991654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pek064Hz7CIKn8YheYCxRzKFA8nRolzJISWb5PBD7ls=; b=kVrqclcI/L5q7UxlF+E9j4vuIOumz95C0AQ85tXMurx6wki+R/7ypjs+Hh+ALJEBiS wbf/iEuvaxVVslCAwIRoaHj0fj8tfhj/1w6L2rbdgalZuZ3tpxwksdq1BaEZhMVBoNck L8IEMYnqwoYuITemGOL4kbCPgLHzsfF5ilQL83p1gMBrrrCKtFoqNJF8X7IrtyN5odio y783vvRjyNfepk6y8nc+6lbhwClRaHOnnapqJZy05YJAmKa7NPy3xc2qVNNv0UjD68rr lvv/CHZiYYiq2RN7GhZ+Yw5jZZJ1KPAHT/fLbp2Ad1xLmwhoBDL6a8SfOrZWr5G55ddH gVkQ== X-Forwarded-Encrypted: i=1; AJvYcCXryIezhoIE4hTCjiVHvS8uEybW+KneJ7oge0vmcPzhQpmu88/wOQbRGXgPrbw4juUrvM4DT9tWfgZ1mkvvsoTv@lists.infradead.org X-Gm-Message-State: AOJu0YzhMtLw/wnuVbwLgEU+sFGQ7crOUr3zvuxqpQTQYi6te4yDshXw HXbQyxTbYgjXHoI0mMfkPDfN8HoKbpSX/1WRNpTUcfRz5r3wLeNftcR2mx1X5RQ= X-Google-Smtp-Source: AGHT+IFW5CC5JRXdKxYGdEgD1gfJan72KWcvXpNH/k/uV7fOOa8gSAbAZdmjlZXVCXNa52l8mJQzTA== X-Received: by 2002:a05:6000:1a8e:b0:368:37ac:3f95 with SMTP id ffacd0b85a97d-381be7d8f8bmr2977899f8f.31.1730386853121; Thu, 31 Oct 2024 08:00:53 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:52 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin , stable@vger.kernel.org Subject: [PATCH v3 12/14] scsi: ufs: exynos: fix hibern8 notify callbacks Date: Thu, 31 Oct 2024 15:00:31 +0000 Message-ID: <20241031150033.3440894-13-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080056_077739_3EF9FEB7 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v1 of the patch which introduced the ufshcd_vops_hibern8_notify() callback used a bool instead of an enum. In v2 this was updated to an enum based on the review feedback in [1]. ufs-exynos hibernate calls have always been broken upstream as it follows the v1 bool implementation. Link: https://patchwork.kernel.org/project/linux-scsi/patch/001f01d23994$719997c0$54ccc740$@samsung.com/ [1] Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus Cc: stable@vger.kernel.org --- v3: Added Link tag, and CC stable, and Reviewed-by (Tudor) --- drivers/ufs/host/ufs-exynos.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 5078210b2a5c..9b6c4cfd7665 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1526,12 +1526,12 @@ static void exynos_ufs_dev_hw_reset(struct ufs_hba *hba) hci_writel(ufs, 1 << 0, HCI_GPIO_OUT); } -static void exynos_ufs_pre_hibern8(struct ufs_hba *hba, u8 enter) +static void exynos_ufs_pre_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; - if (!enter) { + if (cmd == UIC_CMD_DME_HIBER_EXIT) { if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) exynos_ufs_disable_auto_ctrl_hcc(ufs); exynos_ufs_ungate_clks(ufs); @@ -1559,11 +1559,11 @@ static void exynos_ufs_pre_hibern8(struct ufs_hba *hba, u8 enter) } } -static void exynos_ufs_post_hibern8(struct ufs_hba *hba, u8 enter) +static void exynos_ufs_post_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); - if (!enter) { + if (cmd == UIC_CMD_DME_HIBER_EXIT) { u32 cur_mode = 0; u32 pwrmode; @@ -1582,7 +1582,7 @@ static void exynos_ufs_post_hibern8(struct ufs_hba *hba, u8 enter) if (!(ufs->opts & EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB)) exynos_ufs_establish_connt(ufs); - } else { + } else if (cmd == UIC_CMD_DME_HIBER_ENTER) { ufs->entry_hibern8_t = ktime_get(); exynos_ufs_gate_clks(ufs); if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) @@ -1669,15 +1669,15 @@ static int exynos_ufs_pwr_change_notify(struct ufs_hba *hba, } static void exynos_ufs_hibern8_notify(struct ufs_hba *hba, - enum uic_cmd_dme enter, + enum uic_cmd_dme cmd, enum ufs_notify_change_status notify) { switch ((u8)notify) { case PRE_CHANGE: - exynos_ufs_pre_hibern8(hba, enter); + exynos_ufs_pre_hibern8(hba, cmd); break; case POST_CHANGE: - exynos_ufs_post_hibern8(hba, enter); + exynos_ufs_post_hibern8(hba, cmd); break; } } From patchwork Thu Oct 31 15:00:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EA2FD767DD for ; Thu, 31 Oct 2024 15:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BNj/fO2D5WmaTEfTa8PNOYPo7uMWdpoJlT4sv1Vsh0M=; b=QAPwYb342Jqt2AugaEGx6tgg6p o9ym16HNrjsIrioxK37UuXjbiaUwk2uoy7qUDuvA0f6cf1uWzrIrdfDpBVKTla62GJi+Tk5DkRk8C JYQzFS82f0grPyReN46KFnHdFx2Cm87x4KXqld8hPleYnTIuW0z5iI21w3tpSYIUMV+PAr8BOUov+ LCXy/EyJ5fCKg5Z59/K9xyL07XHsNg2TbgHbJ51q8URAMAKtm1PRiBGQPIvJ7T80s+6WsF2DBdZ2K bLevoJKjB3z5Y4SOHtT8bsfjqXd5gOucaZo4+kqQEIa13wJCxqwvPydqiGXF2X5HLx29nK3TY5iDM 52zCdGrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAl-000000040bt-0N6Z; Thu, 31 Oct 2024 15:33:19 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfR-00000003tjN-3mgr for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:00:59 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4315839a7c9so8990415e9.3 for ; Thu, 31 Oct 2024 08:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386856; x=1730991656; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BNj/fO2D5WmaTEfTa8PNOYPo7uMWdpoJlT4sv1Vsh0M=; b=lN1OPVrUvPBqCVfBhC7VR93ms1oZwvAscCMrMoezJpPKCGthF2Na+qCVFrv4npObuf cuQ0tGvRAomu3KhBqU/gVu/mb5Zx3ru95kiebmyFlj//cWZ67EsXqIFsHfzTBmgIEBoR KVxz4B7V8FAm6T+BDzYXC82WwlnvNeqzfapIQqkgnoltTdEJHtHWev0xuzA0jqTVLZtG uSLQYL/iGPZ4ZmAq2Eg1os4xodXVr5dbDHKw5s5Oy/BMlH5dBXV7kCrGdxK8mEsKa5qw gdYcl7fKaIkysnM82cCEb84pISaES+XJoXb/TF0RHyi+ToUITu18MM1DQCqNSYdITZ+P 0t/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386856; x=1730991656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNj/fO2D5WmaTEfTa8PNOYPo7uMWdpoJlT4sv1Vsh0M=; b=OKaIT1rbFJGAsTLha74vXziYQld5dndoPIhpNjXcdl3BLZ9C38+A9o4tsfQfkhUqCN e8rfFJNKfNmtNsM88qlp9k4DJWno1K9iKqgSvZ2dfdZmMQgRTE/WoJ90DLJWiDcPUV+x 8DRsgFiBFryNo84E7AUDrEBrSp2FIOoJH7DIdN6yEMQk4r9cHLEGljQR8RMs/kYzhP0R CndDVa+N6GTMwRjI63+UnbU/UelzFF3sFRwgR7jLhKG161rE83fnAPhispJSVUA/b/tg oc8P//m0XB0a+7tL/iKEyiKbtlL5PsMgCytXclNSSshu1dQzMbvdDTtts57PH82dms58 b+PA== X-Forwarded-Encrypted: i=1; AJvYcCU1YxXOt2YWna53BHV71qMOeX5uYSt1I9jH220I+bQRr8q5yeGPilLYcDnUs64UZMAAB3uCPIeBqvLEKZ2XLHip@lists.infradead.org X-Gm-Message-State: AOJu0YwRMyJs0Rg1oZBPGW2a/EglQc0gZnBA/WJh1iobGbFi23CUmAtc AM4FtnJi0QlbHIix1CT8008QvxEGXPEaBuFkx6xaM2eraF9vW6hnvEraHBMrnSI= X-Google-Smtp-Source: AGHT+IFk2eCgQm8YNMTKlqq1iucR50hnkbAH1iMz8u+bWLPGYs3QFvnZ+3u+58W5gWdqPaK2uS9iZg== X-Received: by 2002:a05:600c:4e46:b0:430:52ec:1e2b with SMTP id 5b1f17b1804b1-4319ad2b89emr185435505e9.29.1730386854912; Thu, 31 Oct 2024 08:00:54 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:53 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 13/14] scsi: ufs: exynos: gs101: enable clock gating with hibern8 Date: Thu, 31 Oct 2024 15:00:32 +0000 Message-ID: <20241031150033.3440894-14-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080057_978925_0E28B71D X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Enable clock gating and hibern8 capabilities for gs101. This leads to a significantly cooler phone when running the upstream kernel. The exynos_ufs_post_hibern8() hook is also updated to remove the UIC_CMD_DME_HIBER_EXIT code path as this causes a hang on gs101. The code path is removed rather than re-factored as no other SoC in ufs-exynos driver sets UFSHCD_CAP_HIBERN8_WITH_CLK_GATING capability. Additionally until the previous commit the hibern8 callbacks were broken anyway as they expected a bool. Signed-off-by: Peter Griffin Reviewed-by: Tudor Ambarus --- drivers/ufs/host/ufs-exynos.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 9b6c4cfd7665..91827b3e582b 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -224,6 +224,9 @@ static int gs101_ufs_drv_init(struct exynos_ufs *ufs) /* Enable WriteBooster */ hba->caps |= UFSHCD_CAP_WB_EN; + /* Enable clock gating and hibern8 */ + hba->caps |= UFSHCD_CAP_CLK_GATING | UFSHCD_CAP_HIBERN8_WITH_CLK_GATING; + /* set ACG to be controlled by UFS_ACG_DISABLE */ reg = hci_readl(ufs, HCI_IOP_ACG_DISABLE); hci_writel(ufs, reg & (~HCI_IOP_ACG_DISABLE_EN), HCI_IOP_ACG_DISABLE); @@ -1563,26 +1566,7 @@ static void exynos_ufs_post_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); - if (cmd == UIC_CMD_DME_HIBER_EXIT) { - u32 cur_mode = 0; - u32 pwrmode; - - if (ufshcd_is_hs_mode(&ufs->dev_req_params)) - pwrmode = FAST_MODE; - else - pwrmode = SLOW_MODE; - - ufshcd_dme_get(hba, UIC_ARG_MIB(PA_PWRMODE), &cur_mode); - if (cur_mode != (pwrmode << 4 | pwrmode)) { - dev_warn(hba->dev, "%s: power mode change\n", __func__); - hba->pwr_info.pwr_rx = (cur_mode >> 4) & 0xf; - hba->pwr_info.pwr_tx = cur_mode & 0xf; - ufshcd_config_pwr_mode(hba, &hba->max_pwr_info.info); - } - - if (!(ufs->opts & EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB)) - exynos_ufs_establish_connt(ufs); - } else if (cmd == UIC_CMD_DME_HIBER_ENTER) { + if (cmd == UIC_CMD_DME_HIBER_ENTER) { ufs->entry_hibern8_t = ktime_get(); exynos_ufs_gate_clks(ufs); if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) From patchwork Thu Oct 31 15:00:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13858093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB693D767D8 for ; Thu, 31 Oct 2024 15:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5HsH55Dd4lXD8RaepfS+tYZBwCj18S0+Osi4b6XYRas=; b=OVfwhfuAkY78dGwIYRn3xTCm6S 0+tPMxFz2K5Hqp0yMBeIC2wNu3I5vQ11U1UIIcrgrTZwXE5/3VpYUpgvRtUm8uRd+5G4d088nA5Cl v4X2l+kA5qlNb8ZZNIVjLgAQhGdNELyglb6R9sASTc+p7dYlIJVxvTLkDi1AAUoacTJfnGb2aGXkR F0hdP3sUiRv97NjKnbj5uKx8htTIQUs9GYVSs95DbtC6+Zjl3Sd4NDkf0hNUBBnZRtpyn313LlCSr 0ZgJpzb7Bfds4yb0v8W0XBh8Q5cTEnP+hfUKNqZL0eRVzeCsOBcF3y6zmsEjidcRFE4Uhi7H8l/2+ dj/MKGtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t6XAl-000000040cI-3Maf; Thu, 31 Oct 2024 15:33:19 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t6WfV-00000003tk5-05DX for linux-arm-kernel@lists.infradead.org; Thu, 31 Oct 2024 15:01:07 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-43161c0068bso8558075e9.1 for ; Thu, 31 Oct 2024 08:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730386858; x=1730991658; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5HsH55Dd4lXD8RaepfS+tYZBwCj18S0+Osi4b6XYRas=; b=ibBapZNAKM7pwEvTbH0cqNTUdw9OzEkH88j19b5lmVRprbPT07KHUo0WGbR8Xsx3sG dbAt/wiWx6RfZRmUlpRZ3/+IhvYc64Fort3fzbN4iXxN8aOzHNljdnu2vwAYWKwjTsPV Q8ZYW8XVtdZu+qbwyRqXU4Ylgqg6P/UcUJQwrzfNHuUPCW7uCtpSBIbpymTtH6bSb8cj RGCk/x/bRSqhNOc8c0vJr/aBj/mXekultBkRXYKy4k1f7WMmr+jgZnFP21aeZjtPdOLf /GpyuEzPYQ4N6Tf6Ebf/7TzF/xY6q5zQC9jPV0rS7F5z3XR/pcVszC5vLzunwAQTAi83 Megw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730386858; x=1730991658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HsH55Dd4lXD8RaepfS+tYZBwCj18S0+Osi4b6XYRas=; b=F6hDL2a8fY2aIAKrt3SwnvI0hcCYCgXFXUKWfXCOJG36Wz6wzMbWbvKCk+GRMK2Pyd tUM2hsYrOwicr3TR2Hg4JLyFrmQ66fRwNeJmF9qMYXhAYM0sUyZVuDZHRD0o1UG5am/C UfSMhi9QMBGVeAi9QfvtvLvqOLVr8q31FGXiy2WY9HUho4/MzKxNR93HjyE5WlNB/equ MP7lBP76wwpWBjtv8QYL3uxYIBNxpNxb8Njm0nAgLYtJcbqmyobBRQAwYDZqSPPomLG1 gZcbz31v1CEo8GbOgJFpaeHm8FY4qp1I8DhIpfMDzvDGBYzxGSHWam1+bY7g5NIhmVql uAWw== X-Forwarded-Encrypted: i=1; AJvYcCWyxNe3KYtt5hX1RZ14dUwYrtjSr4eDA5qnZUnhgDYm9kpp1iQ9D/sIMkSbrbmR+pkUgjG2WvN3RnSfqJkQ1A/5@lists.infradead.org X-Gm-Message-State: AOJu0YwwF+9ruGvxlwbGItPGfSwGwYIC2Udo6SI0FUk/KSbmVI9LyQX8 uryRGu5EsKzmRZtz8wH//fxcVeqg91j2wQ8CeyUhrFiUHJGDGxD0CEjPJ1somyk= X-Google-Smtp-Source: AGHT+IGnBCp8cTrb3nL5Yu4gI9ybHFIG3eHfaMc7SBxhRN7NF7+XLcEhVXV1Ky/UKTvujdddg7F7rg== X-Received: by 2002:a05:600c:1ca9:b0:431:50cb:2398 with SMTP id 5b1f17b1804b1-4328323f576mr1510895e9.2.1730386856237; Thu, 31 Oct 2024 08:00:56 -0700 (PDT) Received: from gpeter-l.lan ([145.224.65.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8524sm59163225e9.5.2024.10.31.08.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:00:55 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, ebiggers@kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin Subject: [PATCH v3 14/14] MAINTAINERS: Update UFS Exynos entry Date: Thu, 31 Oct 2024 15:00:33 +0000 Message-ID: <20241031150033.3440894-15-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog In-Reply-To: <20241031150033.3440894-1-peter.griffin@linaro.org> References: <20241031150033.3440894-1-peter.griffin@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241031_080101_102208_FBE0B24A X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add myself as a reviewer for ufs-exynos as I'm doing various work in this driver currently for gs101 SoC and would like to help review relevant patches. Additionally add the linux-samsung-soc@vger.kernel.org list as that is relevant to this driver. Signed-off-by: Peter Griffin Acked-by: Alim Akhtar --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea8a2227b822..0057faff6239 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23826,7 +23826,9 @@ F: drivers/ufs/host/*dwc* UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER EXYNOS HOOKS M: Alim Akhtar +R: Peter Griffin L: linux-scsi@vger.kernel.org +L: linux-samsung-soc@vger.kernel.org S: Maintained F: drivers/ufs/host/ufs-exynos*