From patchwork Wed Nov 13 02:39:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sung-Chi Li X-Patchwork-Id: 13873122 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E91913D53F for ; Wed, 13 Nov 2024 02:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731465629; cv=none; b=fiLvcMvqhunOgZhRsxxk3uDrFGQfFAQqIfooEqZ8CZ//aJps927YZTj6WbFjhFRC+Z9rQGKRMesHNeJpRqG9CiMZcKIqMmWWppdlW6lsHGc9mTumf+jbSeKDNBJkPoEuzNYPVz/Zrs1X6YWhuwSx5XUh24QkJHkNgoNbmiMa80o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731465629; c=relaxed/simple; bh=T13dYZj5wf2Zd3XF41N7aemiKFJr6ayRHpqcY9xRpR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tffpi3N8stqxrbV0zKdn2pMDWFkUQdDU2ltFV3FTW4TzkW1Cuj1C5wN7H1wvwJpV0pdnx1lX5Wc4+Qs4AyKMZfP2BaYcy8bIn1V1sGlcUFtAZUUkMeugOmJTzvfcLq1Mhz664yTGilKYf783H1CYL0E/+9pG5BPaC886XEwc5ag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YVt4KH5U; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YVt4KH5U" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-210e5369b7dso66251925ad.3 for ; Tue, 12 Nov 2024 18:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1731465627; x=1732070427; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lUswgydF4ecDD8gA1hGl988rFxQMVbM/Q/QpWYHHIvg=; b=YVt4KH5U2TCU2g+w3TlOg4x2eYXdIuMOkdnefXaX9j1eHu/OFVDGF2Gol0dqK8aSmi xPb7hpy5FvdiLYTwf4KMlftKYD7RxQkYx+oUljPzLdM2gfQS5VqG9bG/d1B+zUen8iKM YtPCeQ9sKx22IVtoZNisArhDFAQHmwVeTQMGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731465627; x=1732070427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lUswgydF4ecDD8gA1hGl988rFxQMVbM/Q/QpWYHHIvg=; b=jkq1SydDCvuONWQEjGwARgmhhg9Yu6HOztgeLoCOXboBhbIEDmtZVfDQsXTpZPNt16 vo0FrpBxAVHDB3vhbs26dR6q/Ud1cN1zK6x+0cBVoqW4BH4NKlhjSYdMDcbJyTuyHaTN ozmgNXbglZKNZsqKkf06RkNFDqFu4EQ7vNh/XZJQN3v+Lc+dZEEdHfHXjucSWZT92VDG x3gGveC/LhlZFZ8vIpOdeNDQEKEcU0+Z/8IckQTWlt0W0ExHvVLq8HOLX/k8VhWoOZzs gsjYqYpZ/twpIENs/xlvfuq8n8zC7mzAIXORem+bYQBUqf5Dx/JOqeDND3jKJcEkmFHX zfgQ== X-Forwarded-Encrypted: i=1; AJvYcCX3EXLi4ZV3GZW1hTRtvRQ0Q1A4zqChA77nA10jQpV0dXhjypavH2X66qn2tFNEMXLUlNcp0cLdQ7hBJTziiSE=@lists.linux.dev X-Gm-Message-State: AOJu0YyCJvdUo59QuXGRDyk1xZZ7e8GoxOZaUz+80nA0dv5YZTDrZQLo 0wn2QqL2BILSv+C/gMBFUmDfdARXw/7ZlOs2duDa7QeWys0+fZvQCZq8sqRWPg== X-Google-Smtp-Source: AGHT+IGby99YKs2n1DW3eqEgTozJAq71CGujBYHsrQ+I43rpaTsytkJKH0YHFTNW8GkOp0t5qemLMg== X-Received: by 2002:a17:902:d505:b0:20b:8e18:a396 with SMTP id d9443c01a7336-21183c7e137mr245463495ad.9.1731465627355; Tue, 12 Nov 2024 18:40:27 -0800 (PST) Received: from lschyi-p920.tpe.corp.google.com ([2401:fa00:1:10:3dd4:86fa:9696:4236]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e418d6sm101831325ad.142.2024.11.12.18.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 18:40:26 -0800 (PST) From: "Sung-Chi, Li" To: Cc: "Sung-Chi, Li" , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Jean Delvare , devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v3 1/2] hwmon: (cros_ec) register thermal sensors to thermal framework Date: Wed, 13 Nov 2024 10:39:51 +0800 Message-ID: <20241113024000.3327161-1-lschyi@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241111074904.1059268-1-lschyi@chromium.org> References: <20241111074904.1059268-1-lschyi@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 cros_ec hwmon driver probes available thermal sensors when probing the driver. Register these thermal sensors to the thermal framework as well via setting HWMON_C_REGISTER_TZ as a chip info, such that thermal framework can adopt these sensors as well. To make cros_ec registrable to thermal framework, the cros_ec dts need the corresponding changes: &cros_ec { #thermal-sensor-cells = <1>; }; Signed-off-by: Sung-Chi, Li --- Changes in v2: - Rename `cros_ec_sensor_data` to `cros_ec_hwmon_thermal_zone_data`. - Rename `addr` in struct `cros_ec_hwmon_thermal_zone_data` to `idx`. - Use `cros_ec_hwmon_temp_to_millicelsius` to do value conversion in `cros_ec_thermal_get_temp` function. - Rename `cros_ec_thermal_get_temp` to `cros_ec_hwmon_thermal_get_temp` to make `cros_ec_hwmon` a prefix. - Use `%pe` in `cros_ec_hwmon_probe_temp_sensors` when printing out `data->tz_dev` if failed register thermal device. - Remove `cros_ec_hwmon_remove`, and the `.remove` value in `cros_ec_hwmon_driver` since there is no need to call `devm_thermal_of_zone_unregister` for clean up. - Revert function signature of `cros_ec_hwmon_probe_temp_sensors` since all needed parameters are presented. - Revert include of `linux/list.h` because no list data structure is used. --- Changes in v3: - Revert all changes and just as add HWMON_C_REGISTER_TZ as a chip info. - Remove unneeded Change-Id tag in commit message. --- drivers/hwmon/cros_ec_hwmon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c index 5514cf780b8b..9991c3fa020a 100644 --- a/drivers/hwmon/cros_ec_hwmon.c +++ b/drivers/hwmon/cros_ec_hwmon.c @@ -141,6 +141,7 @@ static umode_t cros_ec_hwmon_is_visible(const void *data, enum hwmon_sensor_type } static const struct hwmon_channel_info * const cros_ec_hwmon_info[] = { + HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ), HWMON_CHANNEL_INFO(fan, HWMON_F_INPUT | HWMON_F_FAULT, HWMON_F_INPUT | HWMON_F_FAULT, From patchwork Wed Nov 13 02:39:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sung-Chi Li X-Patchwork-Id: 13873123 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F661442F6 for ; Wed, 13 Nov 2024 02:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731465637; cv=none; b=KLP7Nk/CGp2fzG9j6HZ9j9C4vPkxjsslSp9SCTH9O0igsoucbTzgFoolkMjsWWaiyjAtY4CgRujjMyMJ9/8/fH40IhQqHnqPqyiZTsxDW0ywtzpGWUKNn3R8wM+tL4SH3heQCfD8m9t4kjLO25jReIjxoaDz5Z5vb+0BSzmp7Qw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731465637; c=relaxed/simple; bh=8lt7eykDFZw7fIigqij0E5lpK1ubBDThz9WowdmROho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jl8ubSFDzCQ4OEPrUFlN+RGEaK27E0870sEz7ZJcMW0vYyTDlSArpeunvsEHFKToCyPAXuh6TKzsNYbNTFLYmCdWuUKqSXuVgfDkq7JLGIY2DXGGSO27MeHvZT9bGyQRJw2C7RpI8bx93u4zpbrXjB2KZ3BxU6MVtp7ANcgvg8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Fjq8/uVI; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fjq8/uVI" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2114214c63eso54350975ad.3 for ; Tue, 12 Nov 2024 18:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1731465635; x=1732070435; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vjvrd2avQzhgqp6lHzhNNlW4+aoD1gw3mVGy/cwxKNk=; b=Fjq8/uVIMewl900tcFSG1d8V4HgcwmSSr6sfKlYBkRbbF3+09dn2uolBTJQjOls71w eCAtSnDBbRHCqgsYPQ6oDrsN5Qsjb0kS4M25BDzmxSvMMc9YVdS9gqSY6sJgjU4K+jlq bILH/+GQ2J5ybNzJIVxlXkdibbTEG3+hY5Gu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731465635; x=1732070435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vjvrd2avQzhgqp6lHzhNNlW4+aoD1gw3mVGy/cwxKNk=; b=qUa8I+tTvQ6HTGFcR+qddsD6zWFkLif5fpMLAmanRMBg+SuRrGGzQMDN/TqGfTsyk6 yf8Br5xshh4p4+j7glZEdEBt/agDCKRUvHs2DKAhYnofnC/SHZIAqPM1LGPcrTQT7CRp GhfUe54jIEiQb939lPKoCYQUh+av5TMpidyomnlUpfjLG67BJh6ui+Rg0dk7KSxn+CjY cM/C5QyticWJqVb250XCvI7RKv6kguoJwOCho5EA3abzJ3u1G9oHyXIJfnFD8IDbvxML e1Qyv6zCZtCrqnqYegl7KxA72xo6mUc0zS4AtZXt3G2c9nRzmtdFz/3M15XXF5UcNwe+ KZhg== X-Forwarded-Encrypted: i=1; AJvYcCUeGYuY4ZAznb5eDBPEX5iXYxhBZI1Ks/5tPrXm7yp+nFNA5XNXDR3qiDPGY6FonXNMHBazcSO2MTepvCmnLNY=@lists.linux.dev X-Gm-Message-State: AOJu0YwWjp3oRW3McY6p2OBQlr4+6uSp1U8odh8oyLCbU2A1jNyR11Ux EaCjblxTlQraneSiKqRHmjnUppEXw3IEM532XpX2O4CTOJUZFLPskPACTSmtLQ== X-Google-Smtp-Source: AGHT+IHe721yXQHCRZeRjkW+n+uLrfYbkZjFfwy3XKSXli/Bjhg1eEXBQdFZlkHS9zXTLG7hxYMmCQ== X-Received: by 2002:a17:903:1cb:b0:20c:bffe:e1e5 with SMTP id d9443c01a7336-21183521d84mr274072955ad.19.1731465635278; Tue, 12 Nov 2024 18:40:35 -0800 (PST) Received: from lschyi-p920.tpe.corp.google.com ([2401:fa00:1:10:3dd4:86fa:9696:4236]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e418d6sm101831325ad.142.2024.11.12.18.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 18:40:34 -0800 (PST) From: "Sung-Chi, Li" To: Cc: "Sung-Chi, Li" , Conor Dooley , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Jean Delvare , devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v3 2/2] dt-bindings: mfd: Add properties for thermal sensor cells Date: Wed, 13 Nov 2024 10:39:52 +0800 Message-ID: <20241113024000.3327161-2-lschyi@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241113024000.3327161-1-lschyi@chromium.org> References: <20241111074904.1059268-1-lschyi@chromium.org> <20241113024000.3327161-1-lschyi@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The cros_ec supports reading thermal values from thermal sensors connect to it. Add the property '#thermal-sensor-cells' bindings, such that thermal framework can recognize cros_ec as a valid thermal device. Signed-off-by: Sung-Chi, Li Acked-by: Conor Dooley Acked-by: Guenter Roeck --- Changes in v2: - Add changes for DTS binding. Changes in v3: - Remove unneeded Change-Id tag in commit message. --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index aac8819bd00b..c7d63e3aacd2 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -96,6 +96,9 @@ properties: '#gpio-cells': const: 2 + '#thermal-sensor-cells': + const: 1 + gpio-controller: true typec: