From patchwork Wed Nov 13 07:40:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Ekenberg X-Patchwork-Id: 13873300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A638D41C17 for ; Wed, 13 Nov 2024 08:40:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7340510E1A0; Wed, 13 Nov 2024 08:40:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=axis.com header.i=@axis.com header.b="gl6pfd2c"; dkim-atps=neutral Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2048.outbound.protection.outlook.com [40.107.103.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3DAD10E26E for ; Wed, 13 Nov 2024 07:40:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=htDztN/WXs6bQQdPQeawZo8Unjog+pF3gsDOmdqO65ZTiBvrOmYdPKH+GIb2xe4P/hZt0L9PDjp/8GwHKSkApuh2rKmDRe0PdaxXZUC6pmFuJ/c9PDKQNCEeLxUSjV8M4SmkLX6rE6RFwNUFdcrzY4TSGn99ORsTfIeaF+2jkEIbWjjPNIqBVp5YwPKgvqFUWEMa/ma6GqBRcXsTtH4duYT+KkELm3bvTvs/2DM8gHupPGLVVhueG2Mw9wBJicd2gmjhfgDJRk47S27ZGoD+W+JPflAnfkExqxhBCiRt7866mwNEgrm/1RwDVGFYmaBu/0xbbGTkHRLarZMPbaxBOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZIPP5VvJz8RxsOkGuQRvoyiC/7cc9OSBu+FlRLRFaVE=; b=rYQUqbzBxVh12Kq8bed3AsST/9qtgPZZHVMQIn5C6CYMqKF1d9xs4cAlVJQsqscvJYbypGGyye80HtxC1FJpW9vuwIoAwzOlTyZb2k/ROkQm1PtbHiSR0dLbKpbXvoBbLKkJuYaeP2Hq7DZTMONgDLNknIYSAsaHryvTlzLmEeEBgex0BaxYUjGCxola7pVPDAC+0oGHcl9Z/UQ553GoCDpA6X0mcFQiM81Qxe6F/zWyGNczgU4TEl4QbbsgQIHSkuIIgD5jMjcIbWeT6QSbpJS2ulAqNuVybJ/pz9XNZaCUlo4vK/D3yexpYC87TXMafAhdpgzh7jAKjtoGX0U2iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=ffwll.ch smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZIPP5VvJz8RxsOkGuQRvoyiC/7cc9OSBu+FlRLRFaVE=; b=gl6pfd2c2+xtnaYqAEZcpMjT5DBwNEEo1Z1ASNondL8YARVBCei7lGSK5Ce/005Za/cMZuSbF4utrNPtwxds7iT5nEoMYANi7H+fAT7ny84rpHHUVFdGz+hW8J8bEYymJJ06fl59PYnIisEWQS/FEv2XGR/f8NnloIJGClLCiw0= Received: from DU7P189CA0015.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::14) by AS4PR02MB8526.eurprd02.prod.outlook.com (2603:10a6:20b:585::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Wed, 13 Nov 2024 07:40:41 +0000 Received: from DU6PEPF0000B621.eurprd02.prod.outlook.com (2603:10a6:10:552:cafe::e0) by DU7P189CA0015.outlook.office365.com (2603:10a6:10:552::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29 via Frontend Transport; Wed, 13 Nov 2024 07:40:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by DU6PEPF0000B621.mail.protection.outlook.com (10.167.8.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8158.14 via Frontend Transport; Wed, 13 Nov 2024 07:40:41 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 13 Nov 2024 08:40:38 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 13 Nov 2024 08:40:38 +0100 Received: from se-intmail01x.se.axis.com (10.4.0.28) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Wed, 13 Nov 2024 08:40:38 +0100 Received: from pc39391-2017.se.axis.com (pc39391-2017.se.axis.com [10.92.82.2]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id A08F01CA; Wed, 13 Nov 2024 08:40:38 +0100 (CET) Received: by pc39391-2017.se.axis.com (Postfix, from userid 10612) id 9BB1E4462505; Wed, 13 Nov 2024 08:40:38 +0100 (CET) From: Stefan Ekenberg Date: Wed, 13 Nov 2024 08:40:15 +0100 Subject: [PATCH] drm/bridge: adv7533: Reset DSI receiver logic MIME-Version: 1.0 Message-ID: <20241113-adv7533-dsi-reset-v1-1-6c1069e35fd3@axis.com> X-B4-Tracking: v=1; b=H4sIAN5XNGcC/x3MPQqAMAxA4atIZgP9U4tXEYdqU82i0ogI4t0tj t/w3gNCmUmgrx7IdLHwvhXouoJ5DdtCyLEYjDJOa+UxxKtrrMUojJmETnTez22apoacgdIdmRL f/3MY3/cDkOUzx2MAAAA= X-Change-ID: 20241108-adv7533-dsi-reset-488c6fbb5e42 To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , "Jernej Skrabec" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , Stefan Ekenberg X-Mailer: b4 0.14.2 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000B621:EE_|AS4PR02MB8526:EE_ X-MS-Office365-Filtering-Correlation-Id: 74791916-f2f9-431c-ce48-08dd03b67958 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?2Lbi3R7EvhPC+YzfEt6Xp75CK9vLird?= =?utf-8?q?+hRr/9M4pDmwhPFTskwZHaymPWC8qz11OHjKYbQtIfthv2ZFQXaE7oPUB3cSh8zpq?= =?utf-8?q?Kwz8xJ7uG9mvHwHvEm74PPxoKzIYv+VmU/Z6mHAXbob/JOL5OgMTahxC0Fzg2Rd6D?= =?utf-8?q?bAn3RDhHPVq4y7GnpZpQG91GXvR4KwiF6IqMcos6wpOrgNAl0naoHrMuktqtMXk+6?= =?utf-8?q?B1EUzfvelYolpuc+x5ZxjDJilsJt5+VdE1pl/uVRDkeBYf1/0Pq9yeXJ97OzZN6tD?= =?utf-8?q?fSlrzTdQuaMuM2ptk17lb1CP+SEdOszAMHfinp7rm5En4fd3Ghgtj4rR89ggLDk04?= =?utf-8?q?P38BCdbn5B/bh9YHDef9/zJQTVsmriNiJDs2z7TSAb08Bgl+aMcapLDCahZ3W0Mvi?= =?utf-8?q?BdWww7Tt/hM781dae4FL2gx3UCEAhNEOzssaKrX5C/sRv7zWuoZOMiaPhJ3wzJdgW?= =?utf-8?q?69tf+MU6Xg5awoFVmRD84JHld86MmStYYPwH8yrdobmIkpIvdgUmEtMl+Jt4fxgJD?= =?utf-8?q?FDqB1vfAKUh9IBfedYsBMP330/wnLN4NJx143MbB27OLyd/kHxJYyHchC3OiJcTKj?= =?utf-8?q?8vakexm9lols5gt5jJYvt1uTQyWbX3kbDLi3InB04sLbqrH+N+ISsiROdl831pyEe?= =?utf-8?q?1Y0r1L6FFtrEKinc4GphlLogeCTW8FL7m18ViuFGweVkenQ6MwjxqE9fB7rZpgH2U?= =?utf-8?q?sc9BsuOgIOuN5cBrxl3PeCwNtR9cS9QxEpB0PtfYwGVqXGwD1FtYyqjQyBspDl6A1?= =?utf-8?q?CipbinZiIu7/kbk+3N4p9KXNSlINWgla4U1FcgFxnwz9q7LUsUMLHT6ynokN78RfN?= =?utf-8?q?/aUlDiNzd0yaBrOlGaguNpV2d4sikLOYqoC21WfApH0bQZiUV/mAqnvnrCfbowAaK?= =?utf-8?q?2gEt93Po6fb+b7xPpFyBSmmvR1JiftaiHxLMXF/P4LwMWdSrlECBIJMhY0gX5YHjc?= =?utf-8?q?zYIsFv0yZjqkczSFYAUEJaS5BFeDFpimusPNVM++fLLThA29lSdix/l3SeJHA1vh/?= =?utf-8?q?mOOPms94/7ipMjXUMsBB7O09CyOkUPAY9loT1484D9SI73OLAON3Gduf/pN1jrDZV?= =?utf-8?q?4F+bcLniVOyhAJodEhiA7MAoGczi1xaa5svchEYVyxPeh10gCyUzb7IVl2R0FcmIO?= =?utf-8?q?zSARUz0DVRuGBUnjaoUOe5x1QZqQ8l49d64Ex4PHE6dKz5hfRbfw8g/VIAeNJAd6N?= =?utf-8?q?quLz3/ckjLVQDDZFF3Va+GENH5xCFZ0Nh0sWKsG7NYQ0R1pYvIvZlk9eLnYjF91Ru?= =?utf-8?q?wkHqCaseZ0wheKsmjlE59FWn84DOHYsqEeA1BOzpCQ6w9xI1p6lumHkS+9eYcFHT9?= =?utf-8?q?gWS7qXDBWwa4uJ7dzfz7MCxBlQqCZyH3myhAP+ear/8lVMji6OVh+I4=3D?= X-Forefront-Antispam-Report: CIP:195.60.68.100; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.axis.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(7416014)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2024 07:40:41.0647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74791916-f2f9-431c-ce48-08dd03b67958 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af; Ip=[195.60.68.100]; Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B621.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR02MB8526 X-Mailman-Approved-At: Wed, 13 Nov 2024 08:40:38 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Reset DSI receiver logic during power on. The need for this change was discovered when investigating issue with ADV7535. The symptom of the problem was that ADV7535 continuously outputs a black image. This happened for about 10% of the times that ADV7535 was powered on. The rest of the times the image was as expected. The solution in this patch (placement of reset and sleep time of 200ms) is implemented as outlined by the Analog Devices support team. Signed-off-by: Stefan Ekenberg Tested-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- base-commit: 59b723cd2adbac2a34fc8e12c74ae26ae45bf230 change-id: 20241108-adv7533-dsi-reset-488c6fbb5e42 Best regards, diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c index 4481489aaf5ebf164313c86cbf3447d2d7914ab9..93085c2b872ed98f4ee394236dc66c568c0e5ccf 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c @@ -67,6 +67,15 @@ void adv7533_dsi_power_on(struct adv7511 *adv) { struct mipi_dsi_device *dsi = adv->dsi; + /* + * Reset DSI receiver block logic to avoid ADV7535 startup problem. + * Without this reset it sometimes continuously fails to receive + * incoming DSI packets and outputs black image. + */ + regmap_write(adv->regmap_cec, 0x26, 0x18); + msleep(200); + regmap_write(adv->regmap_cec, 0x26, 0x38); + if (adv->use_timing_gen) adv7511_dsi_config_timing_gen(adv);