From patchwork Thu Nov 14 06:57:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874626 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DFECD65C4F for ; Thu, 14 Nov 2024 07:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IRynxFW9aNZQni5CG0EFRzQH66e0Aj08vs5GffqmRC8=; b=CwY7Iv2dKs/zhPK48SojKaDWbF ITM7qYSFEpkgpcsQ4pVnVYoigo1A3aqtvdXR+axAANRg77I0ZOJaPLO0oiomWFQbDBEB3txWbHoAP +xYCK2NrgMc+qvh4upj2czyLPpOZLGaxeGutYt+3dN8YZuwmnSS7K68GoxiBztNkp0ivZlSaPlSQC azKYYg1yhVLIGLT2W6LwACMLcJ3VTccjt93dKwz+O+91AYCQRKXHF0U5xsDgn6eOD2sRe4V311uoA t6mpwRDtyZVALB02u6A+cadlBZqged60I/h0aLr//H4NU1RGQlmgDI3/DxnuKCLtpIV+uTDxriJl1 zOeoG4+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBTrK-000000091Ly-2egc; Thu, 14 Nov 2024 07:01:42 +0000 Received: from mail-vi1eur05on20607.outbound.protection.outlook.com ([2a01:111:f403:2613::607] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBTnh-000000090IG-22qo for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:57:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cbXtoPQWL9Mbn3UX/vBv4JCYbKy0tZvDBkcg6ZankbA4WeQyIPXwGf1XBau2rB3uNhN7TBB1tQfp1RZZlHcYbD4BTJGAhHDNUOcP3/Nv00r2EYhYTq0T4OsIe1fZ1CTF7hGf92pxGtefWsCKlwP1l6aDZx8Hvom+TC0OJpkZHMmh33Her71yEWVNKAkek2TGZLPxfsAzvTOOJEOYRxdFzEF+j/RzQTcVLtIXzeils76Ytw4KsSIUpxSdtdWBpjJA9AupOsmtk6KZMk9XkVMs2auIkaj4iM22fIp7S3vivfWoxNFkalL0bZz40IYJDroDSHJfDJLTTwdAFq+tTlezng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IRynxFW9aNZQni5CG0EFRzQH66e0Aj08vs5GffqmRC8=; b=oMNmAdokxkAjMocjAaPrgHEm0WTgiIweULjSm3Mk6Zcm26mHu00ereKqOQuhgWlIrd9AdmikyTJc9+Cg/djUb6JKtSoPC1P9bJBMfDF5EHywYOUb5bPa216cRE4NBEx8VffiTher62NUafLg3G3fOC5dm6Zt7N81lO0FIyBvgaVqNcm7c8EZbFcleOop2vnA71b7H5TemjohHx5Ya7B7P6wI5dzeSF9lZbbvAZOJ3HzKrwDoUEWx7IVAN8g/6yswBa4VAddtNwFvBilYukrOtVyaq1bjQa5KRTGuOWmOLgUWjh7Kwbq209M0ue7gme9FxihiqhLUeDB26K8eUq0r3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRynxFW9aNZQni5CG0EFRzQH66e0Aj08vs5GffqmRC8=; b=d+SZS1hTvGYGEYobzErRfVJsoVMFzTkPMFfoRXMdXnIQUVxKaqnq62GK9I0CAAzaMnJ+17gi0gZ0BdQe+T/B6RL1HvswCf8LhMWRdZKV2oq99DKdVqYE/oeKNLmEiAP99EQRmXBWYEjrNnZy+rJeGuO1Z4/v3qj6TkoQ/b+Cy5if4iKGN66fPGFA9pHk1AR/2jb28nYmayggHbeuv7lH/lc2WI3sRT5Y5YE2bg1hKY/p2KRdl/1rE2GUlQ6bJmoAggVNTwuXC1IgAAwbvk6wdw6Q4/e7CjH5IrQwDaBkIu5/e9w4eISByklJ4UR15b6z8Ot+nqDDurk8A5Rn34GhVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB9510.eurprd04.prod.outlook.com (2603:10a6:20b:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:57:54 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:57:54 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 1/7] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Set "media_disp2_pix" clock rate to 70MHz Date: Thu, 14 Nov 2024 14:57:53 +0800 Message-Id: <20241114065759.3341908-2-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c9839db-a379-49ff-5e07-08dd0479a986 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: 0/vmQY21x8FBnPgL18ueYA4gfcgNGFsMRXWClyqNHDpRRgN2YE+MZkUCeDeMMNjI/+a7AHLrHpeLiK0vb+/VUn8igN0d2Vtkmp6vPXJZXFGRQM9KPQR+8HcZLPmQG9F/CsDZENL4/1rXIAAZdD+lrZRppCVQzyYlaYIqXLJMiI06GjMflTwvo+RG+lQiOvJol/l9HicmjWlu9G5CteixQT4mp8SdxS+87i0L2q1IwQx2kHj45J/cEDWPOinlpz1n9IMOUid8Eb+RXNyskX5gwHh1quCnvg+WzOSAn6LTNeTNZTCac8pny/IAbaV3p5SEbvibkGRcIbHxLElsEG4zzrrZqy9YL0zYRNl3MrqaZ/mvn5+63680PMmFpYzG7aUP5qHXJ2+GUeFRFG6mPHIjaI5/kLsf9HTTmFyCD84wK9SgbST8LJzPXo6Eb31tsyMhXHpqPVKyi2yB6jSxyzVaUXLzoz83ULarNrqqL45ak6+oQ2MU2W27I+MK9DucvJVX3LsJV7xyXe4TShramwnPgOltGm6SUtnv6vmHUOOYcKTs+fkJhiouruPIWUShFRAWC9moSZUuxKROP1wqIYKFRjWaStY0EexI8a+vxHelm6TxBIM+TKEuVwSdVZmzQ5GwX6KnP6DQSu39s0hSGTqZ4xSUQxzt17tC0p9i0eJXTo0iR8wmoV30ZgWNjUjof86QpSm/iiB3ohLdbTMDREGHcNTEozh1GfqZk57rKKpFZ6lNh7pFdlyHABD1h4Xe7UkFgmfWUzjU8D/5BMRawkIJYnS4zbEhReOdvx26f024+HGcyDhk+xqbut+yJhbh9vLCLjE6djdXJZM/vdaSGKtJPT3Ff7TMYs6rdqPWkVDMB8V3lQRKZ7aIdIspDVoXL85OJmmlKaPI54eCzbR/wmOq5B1nImD6h7bpfyV1E05gJGrNOT15+exGMpsCfGvJeHzaf6YKPKNLmTH6kZgHE2xOR2DrjnzMJeLbamRqpLt21XBp9Cyo+saNm53VVcbaO7WJ7cZX1UpCWlse3ebbJ7naJtpF5gT9NK3CZvVx367IBbFaYP7fxHfcbnbPEGmZW7ymJWg8l4K7H8t5OgqwrB+UrOVF2IMwZAjMONHEGwtD45NlOSvMlIOz96+wjPq0gHNUsn9UvKX3+ulrrXFCzMjFjucvDHbAf+ubNl2QztkIMQgdu+DnSrIteBRsiU/S6xUkXjFCPH0Af22axjRwl0P7htRN05tRvTSNUL3zPlYy0LrChogpTc1kZWrss8T892479gLfiu4DG7NaQsdes1syqpvvtsxxcMr3qOcWpElyFA9wGW751gaOGfmcnW7zRUDU8sMGFPEI5BEGnSR4vh+iyAPNWISlcwThq9V9Qxxi8z0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EUgVbm+0ofDiqJIMjvQJ7hevPYNTgL7ItC8sbHJRt2IEgBaytT0NVpdd1YFq8onjMXEhpxF2WCiCrlCvlYFW67QTUSuTIeoDdNss5ErUdNtB83h1P2dz6PfjKaCRZfHRGq2JpLSSFAX62WPN8ipPlt1LHwBQQBHqE1awLLIb30crDWM82sVRm7lOmdHxqB75sy/nPtQstBmHrjLsRCbJIS3JWfg/tUkW4RlafPkiw2YY+Ob9GQQysK/0+1Fye9DJyLj5buzb5VbM4xOa4soVnGkOQt3YEJiRARl6TTZ+C1tX/nbUg2eB+IzlOERUYuFAHB4QF96n671e4Nc8Q/sbdGGPFSkapDI0gUhTGyNjCvwdRcjrckGikuFPplqSr4d2Ft4K/rZsK/0zmsh5gPYYk8tTZpBRW8T8H0hySDO4vmgwwIKV1LR2O+ruT4tT59C6mmpYpq8IvvYuhn/QEbi5NJxFdxXYJ1V/5eqkGaYPrPjO0Vm752zwKb9tDTR0DEsQ9fXhCclrr9Fty6do+/tRS4MO8BVe/kfqLVQ2rDGbwJXQiB2cT5l2U7JikFl+tB5ceZmtXklrMTz7tl80gEJMfJRMJqWO4sGOKmrEovHO26U03mlTh1zd7OMAzCWX4qBXjI9nSm7NAa0npE8mCiiwobRjbWv9y65fd4nH/TKvjN4F6oGTpLvHZtSV0ukz1FkO7HDxkv/XbL142GO4MVLxCe53CrHihHuZdA/QFWfCvG12F3sL+T3XoI4z1OPVlLI8TyAsnUQbmNNekjS/n0M6vRk1NaAMjvm8nd/2Wkntu3Pb4FUUTfSDSRWF2ujkB7JBTG4aYsO1POO9kfVKRPOoEZDD1iDSUT4OYFw63ffPP2sCvv6yEE/FyB6yNtBtPdS9PMd9L7HurjxE5G6RezWQe8IzOZj7f38rYm09obfunzuC2695vogHGDoFtbBmRds1NiMItFoKWzxInPKaAn8Lrjsb3jWCRIrbtQ5MLxJzDQ9dRjq6uD7eCp0p9xiBruXTKrX5tREZXFhp1559OwaEps6Ykt4xbDFYuPGJZGX9T6wZ9VNFtO5OQXil1eOzvHmKNVwF1jcY8d+i4lmGaH33Se0rQ7ri07OYTkVOgsKWZTTBX3BrDnMvXayGM0byu5o9VdLZR718b1wZ4VUwnrclkHo+9XqYoeuAtYa4Fpy18K6HwhQJ4r6Cfe+RTxXz0YFWUC595iGAeCzWAdgf3vMTLrP/lT9oH84dYz89TW9mwj3VT/zpMaUvb0h6Fq+di+GjNNFkYKL6x+RpIiJB+V5CgRXtpKJyEOV2KLGCDG2Ni3EUg7bDMNdAVrbWbAAZSmFzpTfHG0BJcQ6OIBZQ4F+LCW9rkRJCPB9eAU+dgnOSjWy/PhVVjsBsNRl/EKQLeVKDy/P1hnCyRjJpiu7KOZ5AhlcpK8c+HKYXCUdwqDJKBSU5K8z2Q9k7dvUQV95RGkU7RzvQHU4KWrzKHfPjWZm32CXgII0ejkFIZ2YZTPkw7xpodQ3yxZTnx+i/LzsxJss6SQx1SRxadxDDG7A7tCalmzDbOrXeDQ1/bWVfq+6qlM8sVpHGaPx/tanMqaF3f9h0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c9839db-a379-49ff-5e07-08dd0479a986 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:57:54.1215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y3FIja4xpmwsMA4erbdme4LdUcsFF7c6plzRh9n2vlQP7rfPrNZhUJU4Us1W/xAtFXuyrWAWpD7TA7nAqdnYrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9510 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225757_553837_0F9026A4 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The LVDS panel "multi-inno,mi1010ait-1cp" used on this platform has a typical pixel clock rate of 70MHz. Set "media_disp2_pix" clock rate to that rate, instead of the original 68.9MHz. The LVDS serial clock is controlled by "media_ldb" clock. It should run at 490MHz(7-fold the pixel clock rate due to single LVDS link). Set "video_pll1" clock rate and "media_ldb" to 490MHz to achieve that. This should be able to suppress this LDB driver warning: [ 17.206644] fsl-ldb 32ec0000.blk-ctrl:bridge@5c: Configured LDB clock (70000000 Hz) does not match requested LVDS clock: 490000000 Hz This also makes the display mode used by the panel pass mode validation against pixel clock rate and "media_ldb" clock rate in a certain display driver. Signed-off-by: Liu Ying --- v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * New patch. .../dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts index 30962922b361..2c75da5f064f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-mi1010ait-1cp1.dts @@ -52,7 +52,7 @@ &lcdif2 { &lvds_bridge { /* IMX8MP_CLK_MEDIA_LDB = IMX8MP_CLK_MEDIA_DISP2_PIX * 7 */ - assigned-clock-rates = <482300000>; + assigned-clock-rates = <490000000>; status = "okay"; ports { @@ -70,10 +70,10 @@ &media_blk_ctrl { */ assigned-clock-rates = <500000000>, <200000000>, <0>, /* IMX8MP_CLK_MEDIA_DISP2_PIX = pixelclk of lvds panel */ - <68900000>, + <70000000>, <500000000>, - /* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_LDB * 2 */ - <964600000>; + /* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_LDB */ + <490000000>; }; &pwm4 { From patchwork Thu Nov 14 06:57:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7671D65C52 for ; Thu, 14 Nov 2024 07:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VnE6sVd+9Xicb/i9eboO3B6IYiB5VE3HFC4Ua1xPbQ8=; b=pgvqhE8U4lU/4layjwDtrP1HYt EfO2jZ6I8n6pnP+hlaAbVsNNjAqsZgDWsv8LmXVrpePNzcMHXUHBF+vVCCQqomVuItEokD9lv9ltd lpXwnRqZey/TvM5u+YadSigeQ3iS/p0dr5f5NLTJM2IjdGBAyQHJNQf7qDuPCeRkl0DmBnBCeL5Hu v5KQwiHtCgYq9L0NngjERDSmsQoT4GAUDJoE73+XynryX3Z6Ol81EzVlDhllUkUbwWyFQFxQxhp0g 51ut7oLmq4ChMLX/F81VjcgpWsvS1gvQ1TM8mJGfDXblSG1Pk450D+0tr17+HEz+BuUrwhuFNr4TF NxNZGeAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBTt9-000000091js-2faB; Thu, 14 Nov 2024 07:03:35 +0000 Received: from mail-am6eur05on20616.outbound.protection.outlook.com ([2a01:111:f403:2612::616] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBTnu-000000090Md-1Fzo for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:58:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TDkv2g5VtILIolC5YSytaSZsGa2PfZ7WOK262GYQAPZvJT3h8roIvS/A5SrlF8odzpMJrjcQ6Ge9d/inM9sC8NyD1GAm9ff4wPK1s0vBblrldm6kXHrplS2pvSM1gu1gp5RFhJZn1ekdAvUJiYR0xlnt/Iyq7e29jtFJM65nCE4kTvs+vbd6aDYkpprXkPJ01X0PAMynaWYx6Jj8TbrzllMCE1e6aIC37k9saTpNN1DJJ/kDpEDClZHqDT1e66gKOnD7sclQzlNrc+1y/bGuwiNSwJKYVSarB7iH8Gl9e1g26PhBAk0EIiUOrMinlt1OXubwsh1fvEOANGQn61fQzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VnE6sVd+9Xicb/i9eboO3B6IYiB5VE3HFC4Ua1xPbQ8=; b=ZSPVgexP8B+iE7Hh1zecy+kySMiDyzUBBnK1Mh+YGiGi5dtOzjnOXHlqK5+gnL6XheZzEghSXo/wOvAhDxwczeFykaTh3nEzrX1Hcrla+6BdkC4i3x7fXZaivxj9vMqICiEeyh8nGiaLZ1z3arBhUFvUJSBNGlk61fbZ4dJ99AKp9McIcEFxYua2b9tkpTX/7Ggc/gVZsnOS8y3Q/0qJFLfQziUoqttDBn42qqxZzlujxLyLAw3z54+TueW3cWLIRLuIQkP8lfxBgzqoLvmECJMvy+7XBA7Mj50n+MLefDauKeIgLmgCC7pQqWGXlm4uLROrFg5QnDfTzcWC7e14Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VnE6sVd+9Xicb/i9eboO3B6IYiB5VE3HFC4Ua1xPbQ8=; b=T8uGMh4W7aV0MQQVcwy4e5D1Wra4YJeZekAkAVbCWepwx0U07Ar/TLeZxShM9sWFS5Fh8h68wMoz4EcUeWMvCuuwV2bZB5PFEY6z4UA2SHF2rp38PzBqRUPQYvMW0f6zUOnl7S5pHYyGCwTeLiUQnCa2AHon15qshb4Nb8tcz7DesfDLr9+X7kPBxwyBzrsyHolDboiy2HuiJHZ06pIPqPEJSRULjBp41Xsrk5s3FRUB6LYQFPclsu+JEjHKpm/BzCB+ZsZ/P+M1FgaAkcDW6d/hsamVCwCmRhKAOGH0QSNFS+Cx8Jk0xXiw/bkzB96rm/D5lokJYAJUuEaqwtnGVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB9510.eurprd04.prod.outlook.com (2603:10a6:20b:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:58:06 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:58:05 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate" Date: Thu, 14 Nov 2024 14:57:54 +0800 Message-Id: <20241114065759.3341908-3-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: 30d4c226-bcac-4744-72d7-08dd0479b088 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: sAlztiED4coEkMcStXU2NsH6jntbPw7312Y0/TU6N6/MGk7h0brhadLHhxTxoWrKYbSasD0T7VqIvvUYE2ehL7qese61mrQnqRr+XO6a1tiliIXVH9OQ0zt+/3P6jjc9XWHxUlKWcpNboDmovv3pxnfyRskV/AAC+AC+MrdNlEJjFNZHTGUIAMGc9fN5nZss8JNrtsLWFEAGe9GSengutnHPz9xNaaVSe2qEJ6XTm5ixlnik/YxkaQMnavXwkWRK24eZsYzIAHYDmaXR9RXzNlpdrLhG3ruToZAxpqam/NxDb9g0kveChWXlTGlfuIXuYerNf9I2hnsR1c/1xrsiPyWj+BSWqp/8NovI6Ow33t++H+JReAwQrYNHkgf1WImiPiBN4qPSOy9RqULBZqalBCwLAHF3l+1x7mQ1z6UxHkhkGukFxpecu8rfjuD2ShRBHRWKvSL5uKzWiUnNCzGdYdCMfOmgLvh3i5Nd+aWhhO01877XceuObr1h2o5ar0dTl7IIsHwjGh0voBkFn6Jr/Tg1xnFf5I3Cq+vsckv23zhDOFH0TUoaxS227xHDG3NIREqs2H0ySo8J6AYuWJGQ6InRD7m1eg+OdtU324djImxLKl09GyWrLx/V/q9fWAjd5qPLWxUHw5IdhuEU2dr7vZitcBd5y8ouhAVhGU20zactaU2q6U1yYkTR7fq1IIGHppbSa1xBH/OaX2TOvO8y6mQPHQQR4wXlkLyeayjMWXcgXLlLbBJZzAVsFESFG1okxNUCTeEIEU2BhRSzEXy1687RR04omoegXdTbDic9f3qk8EHP5mmmvfidoElBJkb7uF4dihpxuBFprZJ/1LRPnJ3JTkhm64M6OfIsy7h5PH/WIf1VtkxiztoHJlV9GVz9dizVToJMoEd2Fuh3yAc5pFKjsxIN7vMrE33WVBFu5N1aZxKzk5Wc3phkv0y1aV3xv0ax9Jd3uuNkXABAR7sWQ8mfCvtnxZTTxD8xqHamC5pBS+Xc7vIS8WZnMJ9pRjBFdaZlpX3pxN/jk0AXxWE9EEW6fYsEE6ZWOQpK0CoLgz01/2zmvMbsGaTAQgP/hjv4VTnBc4lAncG33xYh4uW6jaQRWM+9Kic90+0sLXhS9fInzBJ0P479Ua9oHNt9avdnv6ZInsUNRiKb6dW+9Hx4uH2lS8DYy4zaYikd+6bpmQEu13I0cp7oaOujG9vixE7Qap3zlnBYhjojPUa8LzfQMKjfJobCAGRGY4LGu2CLKn7xqvMJuBaSVlYIPOQyX1LrPUE5lysmMoB9DIpW+5uQxZKDzWWBg+gN2cRPOaw4XHLaehK/UnYhnYPT2sFSovTV74cBcMWtwuAFZjN9W7fhnrYEQdAFXcfSnZzb7PqAFl8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UVvPMVH0Yyr8dRTjZFCLbBf9g9Q1f8Wrc5YYoP8D3vk7D0waSOTaKigOnf9v8oc9zS+bOC0qTJWoXWi8KJWIjMJ9rr4hfxGkP3s+mNd59iJm6YG3eSkdqKZjRnG3oM6fF53/MvYil3BgBfoAzQjlQ/jPqG3Sr/zQpoog7S64Ih0MFrh+MOKvy6PworgaA2e8RNvDEboXcCtTmGzLuEUw3PCjqBGm6ahLeifV+UaFaCwCCfKL5ycY9fEipGiderVD+oXXmSNGsps/QUc9M+4Qmqy5mgI0092OXSKjwxoD2rVg21uNmJjRPt4g+a72ifWWnGG7KygGGP4S5XmuQhhAJRlCdHBjrEwHoONyquDsoBhFQ2VHMRbA7ElxZgL92vJMphWN3IUP2MIxHZCeMo1o3N1mHHZz7vuHfxMtSuJTrzNOWgYwD2lfefXyqSxLJo41LHzlBrMCnT0fGYxIM013r0BQ4X68qfZDxRywQP4zz9VI62PQ1HgYIJ/7K9cwzlcAjNEAK9W2GYOtQqBS7YQ9tB7b+zQ+Cyl49qWWxYPdgPyt66COecEA4s4BOmnzM6Fx5G6CXqmy0FzVD7T6gkPubDU3/mtSlUTXQqw1tFWGzsdvjMkt65qc3u02R42yVMsarVXY5E+S2GGypVDudAkJOmavyJ7bzQji9qrqM6P/3GfwH4OgMfdbRnqcnE8H3YUageLQFYxZOXgfxvuEO9E6uYr2RUduGuyNjO3RZRAwSWiHa38uInsa0LQJak9PljZiyhvj0Q2hhYnQNMghi6PGu5mKy8y68f4BdXCAMbV2cA8SIH6mDPoJkRV133pcyR5CgqsAAUMMtbfglIAwQyz+P40Emu7KOGu+cvOHRHMs4VwaQ2o0UnPdqKJ5ZpKNprkUs8PZ2TLRfL8orkFsMIWCO3diOjbFm8Yz8lOcX4KAUWUxsj25+KcGOPqQ/J8jcqewQpwA6Km7qJQBqqMXAKCfxTzKiu9nfdQCAFbNAp7Bs8XdMfDYHU9n+vH6vANvP/PMhwi5EsPttxcsQs1/G+hStovi+vbhUBwRqtiTMUKD39F7cm8yXjMikL5ol5sxzrcJLrZA7B/NSgfGP69A5FWmwTsqyoJZHaYYkJIIf041gU9+01FfPnjE3MXPDX6LSLBRihlRYczVMqyCVQLWKufmWdr+r/DAWQjklnZyg9mlHuJjUPDLFSCSo8COYDcTyE5mVtx6htk49fi6UIbQ318RiJa1Y+NJzdqyFltY1qUGbu2W8S6kmJ27swRZvQV1zlAq8GgVgi8QlEArK+eeBGEPIpSVD0fDH7Xao4rZVPvLqXiGgXa9pfFdu67Fx9SEQbdsXPgLc7qhBrUhimay+rLPbKmyt46G1eSEBVyR9zvXZHiY/ZeRTMqZaEoR7eFyfQ21Lnk+qOlcTq08kvg2pH31R7L1dxWwBsE09f22CjNc4cS7eQCyLjB5OYygPrC9xCRR0w7kJG3ROpEVDan+s/jLpKZYavAtFGtmUUmN0FnSk4qE0aP1Mact8VOKE/J1YLX6IYCXf2C+EG3OCGbjvDw70gN69Lc8Y2nm/zsb2W5mHwKNkcOZRiM3eA9Xjy5nxXLk X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30d4c226-bcac-4744-72d7-08dd0479b088 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:58:05.8962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W9wSQEcro7MqVaJPQVFBg2NIA9crcvkezh3CGtfO0J2QPxSPRWsK7TykC3C10E/zDG9d9L50+AY9qoMk9CU6FA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9510 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225810_393087_D32D229A X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit ff06ea04e4cf3ba2f025024776e83bfbdfa05155. media_disp1_pix clock is the pixel clock of the first i.MX8MP LCDIFv3 display controller, while media_disp2_pix clock is the pixel clock of the second i.MX8MP LCDIFv3 display controller. The two display controllers connect with Samsung MIPI DSI controller and LVDS Display Bridge(LDB) respectively. Since the two display controllers are driven by separate DRM driver instances and the two pixel clocks may be derived from the same video_pll1_out clock(sys_pll3_out clock could be already used to derive audio_axi clock), there is no way to negotiate a dynamically changeable video_pll1_out clock rate to satisfy both of the two display controllers. In this case, the only solution to drive them with the single video_pll1_out clock is to assign a sensible/unchangeable clock rate for video_pll1_out clock. Thus, there is no need to set the CLK_SET_RATE_PARENT flag for media_disp{1,2}_pix clocks, drop it then. Fixes: ff06ea04e4cf ("clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate") Signed-off-by: Liu Ying Acked-by: Peng Fan --- v7: * No change. v6: * New patch. drivers/clk/imx/clk-imx8mp.c | 4 ++-- drivers/clk/imx/clk.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index 516dbd170c8a..e561ff7b135f 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++ b/drivers/clk/imx/clk-imx8mp.c @@ -547,7 +547,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) hws[IMX8MP_CLK_AHB] = imx8m_clk_hw_composite_bus_critical("ahb_root", imx8mp_ahb_sels, ccm_base + 0x9000); hws[IMX8MP_CLK_AUDIO_AHB] = imx8m_clk_hw_composite_bus("audio_ahb", imx8mp_audio_ahb_sels, ccm_base + 0x9100); hws[IMX8MP_CLK_MIPI_DSI_ESC_RX] = imx8m_clk_hw_composite_bus("mipi_dsi_esc_rx", imx8mp_mipi_dsi_esc_rx_sels, ccm_base + 0x9200); - hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300, CLK_SET_RATE_PARENT); + hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300); hws[IMX8MP_CLK_IPG_ROOT] = imx_clk_hw_divider2("ipg_root", "ahb_root", ccm_base + 0x9080, 0, 1); @@ -609,7 +609,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) hws[IMX8MP_CLK_USDHC3] = imx8m_clk_hw_composite("usdhc3", imx8mp_usdhc3_sels, ccm_base + 0xbc80); hws[IMX8MP_CLK_MEDIA_CAM1_PIX] = imx8m_clk_hw_composite("media_cam1_pix", imx8mp_media_cam1_pix_sels, ccm_base + 0xbd00); hws[IMX8MP_CLK_MEDIA_MIPI_PHY1_REF] = imx8m_clk_hw_composite("media_mipi_phy1_ref", imx8mp_media_mipi_phy1_ref_sels, ccm_base + 0xbd80); - hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00, CLK_SET_RATE_PARENT); + hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00); hws[IMX8MP_CLK_MEDIA_CAM2_PIX] = imx8m_clk_hw_composite("media_cam2_pix", imx8mp_media_cam2_pix_sels, ccm_base + 0xbe80); hws[IMX8MP_CLK_MEDIA_LDB] = imx8m_clk_hw_composite("media_ldb", imx8mp_media_ldb_sels, ccm_base + 0xbf00); hws[IMX8MP_CLK_MEMREPAIR] = imx8m_clk_hw_composite_critical("mem_repair", imx8mp_memrepair_sels, ccm_base + 0xbf80); diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index aa5202f284f3..adb7ad649a0d 100644 --- a/drivers/clk/imx/clk.h +++ b/drivers/clk/imx/clk.h @@ -442,10 +442,6 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name, _imx8m_clk_hw_composite(name, parent_names, reg, \ IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT) -#define imx8m_clk_hw_composite_bus_flags(name, parent_names, reg, flags) \ - _imx8m_clk_hw_composite(name, parent_names, reg, \ - IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT | flags) - #define imx8m_clk_hw_composite_bus_critical(name, parent_names, reg) \ _imx8m_clk_hw_composite(name, parent_names, reg, \ IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_CRITICAL) From patchwork Thu Nov 14 06:57:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FED3D65C53 for ; Thu, 14 Nov 2024 07:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=30xkgxShCgjwpUU47CWqpAuTdlD6ZjqOuHTYvDzpD0w=; b=CIoIHu1lyLiOgTTkla3PXrcLi2 eLVfijMrfHlyNqCD2XH5YFyDjZr+hR2Q3YDTHk5Md1kBTw2l4bcG42NbA4Bagb+OSOJDIObFaIK5P llzuQyXoevkGMzGLEKcDyz/8CWARl8BgJSnN18TxYotMJUJ03R748XwHZiT9q49gh+uiUi/UbqwVX rutM3tWYeazkiov//GsvhPA2eMQ23O53MtelmNXDcNPYSwbzowCK6lxOyGZBeeLYuvIl6hjfRgixB PYvh6HdUg+HHkJy6Aj6M4BLRXsMJShNZ0FNPnsbyM0d1MjUaHSsRUllZW9x2EVaa6FZKYh740WFt2 dCxpiHtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBTuw-000000091zU-0TfZ; Thu, 14 Nov 2024 07:05:26 +0000 Received: from mail-vi1eur05on20607.outbound.protection.outlook.com ([2a01:111:f403:2613::607] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBTo6-000000090PQ-30Io for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:58:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IrKmu1ae/lyC5JgmwWfqeyDkqz+/OrRGYSBZ6quL6tFJaAITeiOS1ire308TqqqEUC/+Ju+7czq9WpP2CsFdOL/Rhl5OYVG2ANKDlZkXyDJGN1cn4vDlD08ufCiMNO178VxKu1GEVlNtd4RKPgRRzJWHdt+ZKLP5DQR15pgoH77EOa7haLCHmTC5XGvZzePvtH8hz/ok5dHZxj9zyOxUWT7RovQ/X4j39qLde8eG24meqSfyVE2EOKLZjnl5N579FNxUcLq+tIkTsRIJhCO2A0gS1IexjbmqbkEDRREzZQ/iXLlqIR3Rg135kJ3ziGd5rhOg16Q1zVJQAiDW6Ccpiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30xkgxShCgjwpUU47CWqpAuTdlD6ZjqOuHTYvDzpD0w=; b=IZGhqBHBxVTeT6pDa18ELuWxmrxfZ1KUzLwJGQmNL1e0Wy+88/vED/H9drhhBQlntNfiWa6RXmYEC4H21CrcqBMGjURkBbsJB7xcXBOcTGsZPw1PbKdwFHpU/hq3/1mlCVZEiLaM+W6+BxdZp3KSvBvKMCBCdXss2nLc2zXSypfiuk7meAIkDzfe6a8jkY3F1nSjIK/VGurXghCIFh+ET5WriEqHS9hRJNJq9TxH6DOFotgXb6lDA8W4nH0DLIWjPTXrbHY0eps5OA0j31jlc9ZpLd25XYfCasi7gsn7DzzCXX0ybfEEI0nlRclCLEGzm9w8Nt/TbC5uXQXs4FoG/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30xkgxShCgjwpUU47CWqpAuTdlD6ZjqOuHTYvDzpD0w=; b=TQSatUQqDLDqTmYve7vv6ELkAMF/SLIyMycf6BpR+kYE+isIARl2QeI6TrXnB7j/JtgCQDBRt2rkfbxOzkC7+i8NC7T4hnP7LWR3idiCZk61qpw1b3sWFrL5FcLzEIkreTRlK66RhUAD6FaIdwyR9JJC21e1rwCQvH0QyvoA0bBPHkP81eSn+/OiUTV0VxPBhzEbi1AtaY1aWIUEMuKrAGyqvhgQvCWJps37OaAhj1pKK5y7erAHlL8q9WQxwdxSh9EuyWBFRFZhEzNAcrqhuMkCjecShaUs9Iu7APGxJ79EBvQpapgC81TxpZn7xZhFmpdr6Xp3kPgeuEkiaVraEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB9510.eurprd04.prod.outlook.com (2603:10a6:20b:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:58:18 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:58:18 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 3/7] drm/bridge: fsl-ldb: Get the next non-panel bridge Date: Thu, 14 Nov 2024 14:57:55 +0800 Message-Id: <20241114065759.3341908-4-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ced74fa-fd4b-4aad-5b45-08dd0479b804 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: sm/jLtK2/5k6FAO24YD0akC9MZX/qH0ujLuonfikVSdRosGfukYS0/AXk7vRXlOOv1MFlS5ve9rqYvss/SLeCTXPIT+Oh94ROTCEWNyLRF3GXMAEI7HapPgGtkNFjqpS6Ou7ImjmP2D8MiAFTELzHPvAmwH+LguVc7WZn1S9Hh3cfH/hWVovfGfzwI9ggub8jxmYx4UOJoxn/ymCIt6CBYLgdSi8F/2qVh3CfvbN6BkL/EQ/oAx7H385Xo8EmmweZbfdQAR8gEB7Vdpg4nscbKXlQw6rYPsbFU9FgSRljVoUlY1hf31lvZKy0STUVQu/P+C428Fds9XR3V4OdObAxqOQe9ZD5w8zWn+ZIel3Ihf7WpQ9uR6Els6RSdPZ15mZaYAb35Y/Zr6qYco6Jg7nRGD1h8rMRcPpJ+4Rcg4ty5tiq1jPouvmxBph2e9UuuWOAnEeWF1A9a+TwxqBJ9Wzq1FyVUFqeGMT6dT1m/eVLlkSFYQaFMQavUJgksohN0ngmXT2jUsekeu68g3trkEfjhHfkmD3xUPMRwUHa2Fhqhq71uvYQap69KntWC/WKPj13HjCSpZHw6X0vhsQNyXXXthhW1jRLvrekY8Kjf7qDkGNAaHKee1FozHU/bKRg3tfqXYPzjnKn6RF5ZEWNObx/P1AIqstIVjsU9MEjS5ONhloH1tJgty86E3wlfrO6KJ65mD6WNNwMHlpD+wtlQIVgqgtdDzauuq8zTQTjHrfL1QQwBJ8q+7s3dtoCDelReg7eFCWtDAVnJa8Uo+iaVtmTvwJOfo0c5gSYvnhztxTsjozZ1Gf0GgPC4w75xBm/V3usCzO5CKmALtLXDuq/rgD983HLeU42HJvPa/VTGKEV+a8UwnMqqFgfEBZ4iTQD14aCNWH5jpDruJugAqeL8ZVFsQ01dA6vgaSjO6ZmNBHxoF7c9XhKKBK0VR5mMypOoO72XECK1VMBGqfHw6MRI0cuHGrlbGJ1Q9G1BBWafcX8Qi4WEOk+Qk7lDLn+lmr9PqpWfH9bkyHmUle3lo0x5naoHj10+uhcxhS4Z5D6wvKqMVr2/pTJ61kVMyG8l0O8NYRT8GmA2Rx6neYf4LR8V8TEADDu4SahtUAdts6RubkDHkpud1H8CSYvgKEdkktpwW1D9DKlrbXbbN8rAgCI0v6XRmZkOrgkT3gh4TVCdLR8hRqkwcRkONpnt+grebQdZjoNL6TePmobB++MR7BY5d64TOfbrOnebD+V+pSKIygRFQwHCj6pu6k2RYXQzsmO1rFmj1cPr4XIKP6WuB4cEUI/6o8wbhPUF3d11I/IwQwIpqfxTv6O/Z8kKl9YxjwRGfsQc5sz/qjOPHFVOGMfAGDBm6byCKlt4R6hxZqPwqbhfI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zsZfh3bSkUZdtgOEv2j69tH9rgNd5/2ul96JPW+Eh7rcJpogE+GNOHMag2IgnYZN52+m7rPHy2skt6xaLJa0D/o2i5hN9Y3fr8x24yDJJKoa6zPaRL8fLjr6O4lg2/iLwFCa1b56LnTzh3xF5U/xJM7pzuZO5phSM1sw3/vDHQI0Xe+jzoxdwkYifAuqXpkP7yE98RZjbNW6EckBH/7K3VVPFxRpyM+dztmaQ6msVv8oSebhb7hGdjT2JkyK58oc4pteZ4ayQ+AxfU6XcSVW7oOu6PClNsm6taqNzK9QMrDihW/6Of/SMlNHGyYd7eFAvpGJsP/EtclMbzzrPPHp3tBc2OYIHaYwsR7XaCvRJ9Q3Ge8iv9mwXneyKBrBcg4G8w9HNFRJEGSB01ZCGKZKSFBGntVO6RkQbhzrhn5zp78lvPTF4TcKTGMFDVkp7YSaKdo0Iq/vgngS3JaMhOqF9StLA5mD3iU41IYd0T2rKycDzVpD2YifmPmnwUJhOjWhdkiWqqX4DVsgVHQF8zIE+t5qDeiByTTTHsjKK4hag443q5eJjSLUJ3rHqm8jJUZIleD1ryl+GeekA+PRloe9n5Fi5rAa38GAD9QyZ47RFe2h1xZbQBtCSpDCvYpeJZOUNtx7nbri05VUyoL+tHU4AQivYEbqj7IA4TMhW94YoLlMJjLTwrFZ1IHSzHGykeoLaAmB1gaAJx1RRs0ZmJCiB9n9fUG1e1/gy+gDeyJ8Ho55eCv+Jt/QAMo8vDsW6Ecf6YsD7B1Lwho/PT/r+L2gLbIGTvtlz3Ati6W6Fz7MoCFhZkfIt4xJWMYMV3mPHNkj/8VB9WjCScOtKnpdMHFgXHXnI+8MaywkTzGR1Nm08W7mWsHOsOZwVi7q+qBGis3MP6j2I1R8VJZTkxRmMzRNEYzZvwq3cPYKS89fiIlVw/LvrYCyvRh7S6xQ7FhX0zZfvGbn+GUUSTBjzqcbWV2fIrURtwlhSyplMbt+K8tpK5HOamRKuPtNoE6t5cqe7aMuSYPjLlcfCVkXo3gM+G5XxIAgorwTItLVDbIgVZCuXjG8IkrNfFesYoS8j8jB1ipV89s/2EzAGW6p0PPr/k1lBEjYLWrDn/PnLFlZNF7sY6xoVbDER2t7tNHe4VUzN+TTh13anuiQuQekLpLYSe0gY1vN5kMupdptigIOi2YDWeh6lEixO4hueA2FHfifJKSx63O4pjIygo5sKmkTdMOSdMIZGq6mVdFJxlZPr28FUXgMsOIy6igjiwxqPB5NgCqRG4Mc5ocfaUEeQ7LfZVHIp2wrJA5VZQltnJ/m3TP7vF1MEVgK+uuMkFicpnXo38zn55a+vBcbmL8qQV1rNKsdmUSt1C46V0VsKZnCG6sdjmzfukSVQ47WrrHMag/1lxA1fy858xkqiSONZa2VJwAX/KCoVuQfoxHQLvOHkrNRymaZGM/75oRNbOXxjohfPJ3MvQqPh3uRIhlsEmR3NfFyA3OHV2shDFVDuh/9KzY1gUwyiOyzVM2F25nDtalsxQauXK1Q3IN1uXrP6oiYspYg5nYG6pyutLLZiHJS14SovhmNekxZMeF60VtCujCUwb1B X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ced74fa-fd4b-4aad-5b45-08dd0479b804 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:58:18.4359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xfMXY3PsPJkzLZNkyLEC4KlxBq8u7lC6ncaNDdRwUsDkpPKKRZvozaSFYqXq4I9X3r4NRESDxS+khBBqCyy8Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9510 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225822_788717_28DE289E X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The next bridge in bridge chain could be a panel bridge or a non-panel bridge. Use devm_drm_of_get_bridge() to replace the combination function calls of of_drm_find_panel() and devm_drm_panel_bridge_add() to get either a panel bridge or a non-panel bridge, instead of getting a panel bridge only. Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov --- v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * Collect Dmitry' R-b tag. v2: * No change. drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 0e4bac7dd04f..b559f3e0bef6 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -15,7 +15,6 @@ #include #include #include -#include #define LDB_CTRL_CH0_ENABLE BIT(0) #define LDB_CTRL_CH0_DI_SELECT BIT(1) @@ -86,7 +85,7 @@ static const struct fsl_ldb_devdata fsl_ldb_devdata[] = { struct fsl_ldb { struct device *dev; struct drm_bridge bridge; - struct drm_bridge *panel_bridge; + struct drm_bridge *next_bridge; struct clk *clk; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; @@ -117,7 +116,7 @@ static int fsl_ldb_attach(struct drm_bridge *bridge, { struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); - return drm_bridge_attach(bridge->encoder, fsl_ldb->panel_bridge, + return drm_bridge_attach(bridge->encoder, fsl_ldb->next_bridge, bridge, flags); } @@ -292,9 +291,7 @@ static const struct drm_bridge_funcs funcs = { static int fsl_ldb_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *panel_node; struct device_node *remote1, *remote2; - struct drm_panel *panel; struct fsl_ldb *fsl_ldb; int dual_link; @@ -318,33 +315,27 @@ static int fsl_ldb_probe(struct platform_device *pdev) if (IS_ERR(fsl_ldb->regmap)) return PTR_ERR(fsl_ldb->regmap); - /* Locate the remote ports and the panel node */ + /* Locate the remote ports. */ remote1 = of_graph_get_remote_node(dev->of_node, 1, 0); remote2 = of_graph_get_remote_node(dev->of_node, 2, 0); fsl_ldb->ch0_enabled = (remote1 != NULL); fsl_ldb->ch1_enabled = (remote2 != NULL); - panel_node = of_node_get(remote1 ? remote1 : remote2); of_node_put(remote1); of_node_put(remote2); - if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled) { - of_node_put(panel_node); - return dev_err_probe(dev, -ENXIO, "No panel node found"); - } + if (!fsl_ldb->ch0_enabled && !fsl_ldb->ch1_enabled) + return dev_err_probe(dev, -ENXIO, "No next bridge node found"); dev_dbg(dev, "Using %s\n", fsl_ldb_is_dual(fsl_ldb) ? "dual-link mode" : fsl_ldb->ch0_enabled ? "channel 0" : "channel 1"); - panel = of_drm_find_panel(panel_node); - of_node_put(panel_node); - if (IS_ERR(panel)) - return PTR_ERR(panel); - - fsl_ldb->panel_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(fsl_ldb->panel_bridge)) - return PTR_ERR(fsl_ldb->panel_bridge); - + fsl_ldb->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, + fsl_ldb->ch0_enabled ? 1 : 2, + 0); + if (IS_ERR(fsl_ldb->next_bridge)) + return dev_err_probe(dev, PTR_ERR(fsl_ldb->next_bridge), + "failed to get next bridge\n"); if (fsl_ldb_is_dual(fsl_ldb)) { struct device_node *port1, *port2; From patchwork Thu Nov 14 06:57:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E765FD65C57 for ; Thu, 14 Nov 2024 08:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EOvavuMtr3fhljxErEXqpchKljXV3glZ6msFtDr83AY=; b=eB6nGXXdBY46Kx7ZOO5TaM7n7Z dSTvStZp9lqG3TvNryDWP9zKKhayGReQ/JRagtVCus1jt5sof33VqinGvn9Ky9KOX0IRLKZKvZ2rM zopKWT2jlFEFO61H7VaInnpx8PQOlzC7XYVBnz5dZTEoRAVgRTvkXNCgJZY8Y5HGxNYvjqIwUMk9f ghApJh4ufgKxD6Uk/Of7Vhb03SulvWDb4UKjdigHHHVanQi0u0XwSRB4VwlBYCwAUwqBUKjrcKrQz EKiAoiMx/hHhD0X3yHIsyzC37B+eITfE3/QBufn1SVlrsmBTmfrPcZ1829t4ied2Fi7tdWprkz14p CK8nx5/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBV2E-00000009BQ5-44Ek; Thu, 14 Nov 2024 08:17:03 +0000 Received: from mail-vi1eur05on20600.outbound.protection.outlook.com ([2a01:111:f403:2613::600] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBToK-000000090SU-0Ipo for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:58:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=njYxR3d7M6/2Q8ytamd2Y7/9Qy0SVMSBri2L/RASzTi1L+JzuQ22h49mxauWnN9ct71NLRt0ch8nEI98psBcR0QVAmB/yLpn+pzpSUUj4ZGVq7UC2C0GqHVsZJweJvcJh7nTK+2A0EaeSScGU5WqUjmquzDyK9jPMu4aMjsmQ1d+naO7i+1OWXAM/0ZaAxexUNYlg3QNdCogZVISgnaN5Z9vCfl/KIgw7mbxGrhgUKGOEw3EYxiy4ijdtGZhm1RY+uu3x+nMpYcbr25kYvtl+yV7Btb53K3Lw+vaBugFO4Ewm5H01JK9ZboyBiZdjmH6rPMNzYLa7Ukm/O7pN1XU8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EOvavuMtr3fhljxErEXqpchKljXV3glZ6msFtDr83AY=; b=TTIy8TZK967mMAHJXbdU6JbDpdE3hmywIsVdx0SWHX9sIBm0Wnb+RIrrgUzvNXyscugKmCYGEbVOAlxl6YKioaM0ppsIM1OddivjQcs8hj2MCZLFdaVwVVHRJ1T2i7ieRvveWst6evA3sgYOWLKLN2MTh57/308ogPJbcYw13bWGN6S+Bg6sJGqS1zF3/g0Qd+CiuEK1fhwjYnEWhp4Z5HzCfMmDvrdiOqDRL6z0zZyhTWaroMLiQChW7EUUAGA/B1n1+n62vHv2GB5zwOTXf5KYHj/OSlEkb8g/iSQCX3wdB5OlBQm/0vwVK/LeJrIIvcgFW313d6N8qhWMta3IUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOvavuMtr3fhljxErEXqpchKljXV3glZ6msFtDr83AY=; b=lo2fD/b6u54d9pfe6A3Zu3sqHWnC5ArhjAP2o0FH7CmI0U1VKTvCjA92P9IziisQ1FafLlkOprCoRDa3KpgwdDs+ni+IhrmGeVV3EnyKehKKueZ3PYV2W/9I+/or3tUAhzIiaZQm/ciAxUQqcvVv5XoMKaWcx2LGFW0OWJPx7xUHcDpf/IS8yPujiPa1magTG0HvhR+7DzIMs8hixmFoFFS49btn2PfO8ONFHPEK0ub70O2yUXnwPL5q9soLi3IOi28ZAiEj3H84v4aAf66TMyATd2ONMPvPNUYcxpcPGWqaqICmEY4CpNA7YtoQ62vzQ/sbQdb4KxoZ9n7LT6Zs3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS8PR04MB9510.eurprd04.prod.outlook.com (2603:10a6:20b:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:58:30 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:58:30 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 4/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "ldb" clock rate Date: Thu, 14 Nov 2024 14:57:56 +0800 Message-Id: <20241114065759.3341908-5-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS8PR04MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: e271d7ca-b38a-43e3-6668-08dd0479bf36 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: uY8kLeMza7t9htw+1xO8mdBP2tXtHq2nu9RSmjN/4gE6pLaYWafek2dljO+OTVPlBdAtm/XscSwq+NqwGntnmTJUc+Z1Ng4Sy9Eo4o4Ltb+Is9OwxmmAEXEkyjH7+ZB4QAcP33dqu1UC82hsqpqucUnyR7MVtwGo2h1acdDBT0HptkNPHk6hc59ceusp6/MFAh34bI3H4cA2HDJtaXWvQz188BgDK9jSBH4T0BdUo/X/XftLcKAzitSFUiF3Qn2eiR5D0dtUf4Au99f1yxEntWhvz2jyQciiDBV8NKcN+LRnKaPxC2znAR+EQOi5XmDFwba22LRxMvR7P16RFG63bvDlBIHEgXHXRTZRSnUlzFsii/pTQGeej59751C5cTDuigkPV2BdNuWeli7aETnbqmVBQ6SWvHa+YKCbGD403laRJuiaBcWiJTISTe9xJ1QllZlMsdHPV7ztBWz9h8Np4tWB/X1YARHu6GLYYY7AHgxF/2kRhVU0JKrRqMlyWMCnKjHk53pCJfKsh2sBfgAeJkWzzUnLxUV0+O4kYLSWqevRBiVpbdpxQ0NC8AQEy1LAQoNDJwS7Gw5KDDRRpAyhAOsQV8r39zG3AiQCA1fzAUTIzh5lJ64ukmf2ASVyRSOe9IgSLy1yqapE4YD70n1cQEBQbkmrdEHik1709Ug2Gj0EjqJx0UceKtANVqA1fMxxNKrWMG5KJ4VgYqbrmCPbS5l3Rq9B/YIZcSxJYXaXZH9NlHZSrDttcTvYgM70D22yK0WY5bpWhucFzFk2/MtXMhNVACRg1HDifj/h5m4Ob39T+Ld790IofyjHLL7FWPqF/NaEWl+1cw5KMgMTXohivrn6ZBFSGVHu0x0Z98nII9TnsDi18ujCzw4HIYxdE+bejyZSHXfXCxmDgEJds0K+jon/EFPjUXXqI9M+EcjsG50nHPCyE06RKJUd8+4DVC8zniKxVXMXw+GUZYDWsLz9KcG9ipuenqvzURc/gDmb1n/q9IrfTG4MuMlNHR3njx0mwoKeSRVHd6z6FxhiYTT35lzGzO5qV0sru4H45nQbP0CoixuFjA0tjJTiDfGl8VZwEc3EZ/dUYETl+CExV/nKy5XLO7wCbonFwmufebC/EOsdbKop31kFQMIVHjM+hXXXujFaEOiqRNQDukl+Z540tgma9q8PBB/YnGkJz3LZKPPxlKUO0HzKc/n3O6YrsC2cHMsZo2/Yi4GxZ7XRiJ3I4lo7nrDkV9myYTm9ZndTbOyuQambY9+8VX9BRhQNFGeMx3WX2hwLMxUKdCgtpv/NS7Dl0VSTCd5O68gyMHO8elMYxdJee2qa4vokXZpEHjFqgog0h6nG8XT9LMhVwtwtgRkGWErWQzM3+PJDQgFVUu+L+mbQUbs2ErbUGTlrTyQR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4dcNR8YxTAH8uQhjPX3NLdtvBn4DUsOux9gjV4Gjc+d+blZNNsKYY0MwbELFRy7WNajVPA9Dsut/THEjH01iL0HR0gC8jZfztMVCaqA8rNvzRnMXrSrWuxePxO57nn+qfaAn1To1B9YOUJ2o3s0kRvGmCPsbwPzB8sKZUQttFWmqnIyYPVz06JhISv97/SCMbwghBLf9MrAgBDS1D9WH0CyFjuGHzxaoWA0z7QyrMxHZ1mRK6NYYf5LsLVZAEEbMqtaqsv2CFp/JT3UWe0KmvvBJ+BntXfpUtQsEU29wZ8FRyDkAPkNJJlZLuATcW9dKX42v6k3soKFyIKtvFs6kMzzg5fR0ulSX5jbH/qRslMcqB7CthIPbG7YlS2gn56yB8lSFa2Kx4Rbdm0uOeFljsFekMdrgzfquCQl99rNoyupSIPoNaSKixw0X2chaENJYPUS+ZZ4TPErWCMBZABu9cTyt6XmLUfqgB2rO61I8ZceA6SeeAueycj0VwHs4MX82TSXeR5k7oQwfec4eoz7Zh+F48hnw0b+5ak3TSj2RDk5ZPJvbfBk/CDcEKvVeVtvdF/eWHjgEA7pwCDUPMHiApoTnG7HsQLRa7+we5wWst/346Y6F+Bi5kL6oQzFeO21Y7YkOR7ghWcTzB1G5grqRFFpH8I/E6Uq/lo63l5Mv1fRJCUX8xD/ZX5cEpWBOsOf7y/2ZoDAFGHjeHzj8cG1bm+aH+GzX/OhPn6+viC14mCFQ66st3jrDjk8XZU9em+AacHGsveq9K6Azp4UOqM1BzIUjyHuVcjV8GfqHvF/J3o5Y1NtPpn/2O/UPdwFYs6nSmshKHt6Df5/VbaR/2HNeEeQ7Nf85XtKxZ6TVMYEjYN5ojX0khgyl3gf4g/1zgvm8gktbawkJoRKMyfUwSE4UR1d7ddKql4rMCY4z90+ebB7I6TzzEJGh49kszukEFZsuX6FOCHPUUgkaod7HdAm301Y9jcnUh9qT2uoUFzkh/hK7JDXxWeCVUgSRM08mmPf+TrTXjljWMWBaAPSs6EdEOv3XEYLAkVkqQT99KhUrxDGm6ABN9m1Vc3dsYi5LDxVOqpQdeAXJOjOde4kfAB1kbDhQlge86NEdmOaVe9J7hPGqFR2W2fGHs/qjitKufDOoUSDjeLf+0Q1AdiD7iPv/sgf1tJwWvIlLyshdNw9cDsqBWJQBn2upTVL4XMiBNu1B9oqIAkfqGWEp9eSOKkQ6/Me+qZB1JYr1jq/FE9z+X0HPtnbcQHG4LI1J9ZDxOLg8UBFzZXKP3gVjhYBoq6s6LwoHAu5dUS9Kf5hC1uk9gp5H2+UN/xldnSPhbKy0GHd/B/+zqUiWwjMQ7eyDCVyCmbFzJorrvcUhlM2BCNm3RTVIv4W57oG3QdKVfWFfjzLQEtVEa29w66sfx+nSgLfPXZKhAOoKagfJTmIJhI+GoAv5dC1iBoVECgojRsgfMCwTalumihWSRgfI/xIscFeeaZIS5Q3ELzl2TRYFX9oAc19gpIRR1zLkJM+LvhAKe9u8+x8XcNn3AGm6kHa/q3z7CFaN+uspWHYVYvQgDtofDSkBwJBwC2Fsj3pgxUPhQchK X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e271d7ca-b38a-43e3-6668-08dd0479bf36 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:58:30.5281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kUpM4xkFyj219qm6Qvh84yfLL4tzh6289b/EibCQQTZTia+cJwCeAD2XPiW8Mx3CRqiRPrv1aaR6qzJvQ8bhIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9510 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225836_136638_9F71DD84 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Multiple display modes could be read from a display device's EDID. Use clk_round_rate() to validate the "ldb" clock rate for each mode in drm_bridge_funcs::mode_valid() to filter unsupported modes out. Signed-off-by: Liu Ying --- Note that this patch depends on a patch in shawnguo/imx/fixes: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20241017031146.157996-1-marex@denx.de/ v7: * No change. v6: * Drop pixel clock rate validation. v5: * No change. v4: * No change. v3: * No change. v2: * Add more comments in fsl-ldb.c and commit message about pixel clock rate validation. (Maxime) drivers/gpu/drm/bridge/fsl-ldb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index b559f3e0bef6..d9436ff9ccc3 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -270,10 +270,16 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, const struct drm_display_mode *mode) { struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); + unsigned long link_freq; if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 160000 : 80000)) return MODE_CLOCK_HIGH; + /* Validate "ldb" clock rate. */ + link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); + if (link_freq != clk_round_rate(fsl_ldb->clk, link_freq)) + return MODE_NOCLOCK; + return MODE_OK; } From patchwork Thu Nov 14 06:57:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874657 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4FF3D65C52 for ; Thu, 14 Nov 2024 07:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fQZlTSOnck7v/jliz5eiEp/DzHQdtT+j8KFoxuJa2kE=; b=GKArtHfcnN1EYPOyBGe43Sw99g lrxshfKwEUGyQf7aq/UXq3IF0t4z/1HSyRVGtJNae13MMg7y/SuaoxvwEGpVNOniwkOEgEnmx6Qgt Y8rh/f5AYJFWHI13Zr2e9I3AY4t5LAPChsAbITgO4NIU7rQ6SkHfB6TdLbRqErgqFq2cLfbH/W4CP 3lewLFfjdBQ7Cigxa+hkMkiIDHU9Yc3WlDW9ESNyA6QJ3227YgwN6En6fdD9qjtd4DUTwM8Db8aRL l/AiBwu5UwPsbIwBQ4dxpcqOTc7qtJ8xWytyjFeFJFV+jAY0tPc7Y+NrFEX643qDdFS8meVVpfBqT MJJzumdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBTya-000000092ru-20qY; Thu, 14 Nov 2024 07:09:12 +0000 Received: from mail-vi1eur05on2062d.outbound.protection.outlook.com ([2a01:111:f403:2613::62d] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBToV-000000090Vr-0ehE for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:58:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VVng/VFXovRW7fRR+Oo+ijBBb/flLaOlCGs07u8KvhoO2z6U6+XOyDkl+5+a0W834Fuf4YKhV+sv2PwI73XSYkFTeq4++YxfIkuSxP1hfwO++4GwEflM64odkkBQV6vjTxzA8S+3GdPJCivsiuEklYGxQd3tQrZ/QA1Sa6nKrKhLQj/DUhpacjmZNXU/UIxqKKPdzI8RpnwIrLe/AfHQQoiNToJMDftE3F+czgIkNrPUi0p6y8Z5eTEOWgikwtTESfSTY5+ozVcliTfOCSEL6i95y1nYl6bEwApqXm7bLYcFSxXtQD9Fz75RwAVOGioEr23gZ5eJtDdkgJ90rSHzqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQZlTSOnck7v/jliz5eiEp/DzHQdtT+j8KFoxuJa2kE=; b=xSzvXsfDIu3TlZKTeBHy37PsfhBmvDjC0oM5uzgFT7Xjs0NEzF67yV4ZxIlnYFRmW5lhS6OzeTzC5p0F+Dj1q2lo+M77yIBmUut41mF5UZp7bAAoY+G1EdHu7/XpDbF6t+E4qfqZaUOY8gu21LLLZK8BbjJGiu8s5a2xy1cUHZLnN7jv4C4CX0/WWsleH0QQqCNHsBn1VDhWzIgfj61jIs7nTQ1xYguOJGrpk3y2Ppv7rLILCWcD7qYM4EMz3WO3k4EI11B/+gqEt8mhi5PwB9b2Ul5JmO19HWAQroVNbw20TzhLBcZymu3W2msRuVQnBWSKwv2M9ROoX9hmOcTukg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQZlTSOnck7v/jliz5eiEp/DzHQdtT+j8KFoxuJa2kE=; b=HDKNROPTd0Z0cadHECEGUoJGC2lGXEt6ecBTFTCVcAMA3ue65WPGWlGp9t+5gBK3OCZOYkarpW8cgAdOMak/I2RDk3JfYyOmLD9cSYK7Uep8NliO1oqPpJufQrAZ2LKqBACKguFunOvbfbr2Z4EA0QcZDIMIrzuzY2DKi4bXAXtWxsJTASNrMaVSWStXlUPEvXTjB3oBdXkQGnTKAAjPKfLzvzPCcCk8GWtKY+8ga8l8tn+nA57V1nqQK606vbTGk1Qi5sCL3eFd4E594srtDlgJdBjizTqA0PRlKt/+S64E1VCFssmSDznxkv0Sk4tQ01OeZP5EH+dBFbv489U66A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PA2PR04MB10278.eurprd04.prod.outlook.com (2603:10a6:102:408::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:58:43 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:58:43 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 5/7] drm/bridge: fsl-ldb: Use clk_round_rate() to validate "pix" clock rate Date: Thu, 14 Nov 2024 14:57:57 +0800 Message-Id: <20241114065759.3341908-6-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PA2PR04MB10278:EE_ X-MS-Office365-Filtering-Correlation-Id: ad99850b-4a72-49e9-65ad-08dd0479c6bd X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: xeFhgQ4PynevnX3vm4bnjNFLfeU2g+7yXM0ZVULQHMFnL/9cKWHfv0xzecwPWBvzVOkEV6vsj+yn6CHcszEN8qQN6LSYgXD2NUgvbJvBIhos9hpT9PI1/tKBRO38JnmymfGHH4+jw8lg7A7eU8e3rQbsfjAS4LYo/MEyugcuFwdiNvtwS7iEoIlwFcuCvT8Dgj5s32F3It7T9r4AyOjrNBx+KYtMMK3ReG6sumx8xdttqesqlzy7MChqDy9x/+LIpGtiTROf+PyGiy0MBb41cZgxlSafgWrvxwV1wfGwp4+LpbGtvaEAt9j+5Lve6XXgfYCv6a21kfs4Ej57E//hWy9yFJjzU0riy7KCtVvJY8u2OCfYcEgHBQbsbREh6Ul8BEdSWdnwE/NTqZaJT2e66CQsC2L841XOalc1CsSJRy/8QxNAoyYdfqh3DNexkUupUgcKO2LhSJbGkCy016Sx/gPQg/BvDdB7PIW1fDtaZ+RM01JgsRzraI9QqGwm7PC+sn6HUSsFz9YvUEAsXN1m53s2Exazs5Wv5wliRJkBYzpjB2jZLGrQMjZ2/BwVsiCx3c2wlGqldOMf0c0O9Q+5rmCQfrHo18M4tXcAT8nDLuuZFaXqhJ0xIlfLJQAgU8qkC0xTILAktRWddLvljDkCu71bvWDqXLGAl9DmVZSyN9pH7OTeCUmhrXQC4RTeCVqJMtvmGhlFcOUotTfXfNzdreCc1aeBTgDOF4AxZq8AoA35KKM/GGOO1UameJI+2jSAwxSTBqSAmmoQ8lpxNpKdX57WI0KenQN2v65pZdE++1hlq7zTaPFYldVJ1Z97lA0Zf11wb3MaAUGKdKMcqcV39c4CuukYOYVs+IaS95s74yN2pFqzjkCQVYBA0ogZ+5tdmyXiAvgZnvE0+2ztodfnVH+lrxIZ8E/A2rJ2Xb7Um9Zy52xb5zJCZxxOHxA5rl0Z44FqTJq3zfNVpms4c/50obUpSpBk3ynXHYsNQc+042eUUNzgCzrP9NiU7zF1KXuMhtaUzHFlTcz3DjN7wQ9UG75qVKT4HzIJnoEgg0TfYDPaOEJx/vwftxK64SpggW/0QtoelUNqZo+A/uUlYR5flfgfnfQuiAngh1r4d/EKc+BOVMkZ0MbCJIbi8Jcz8/WFuaveT1Jybolb1jTiAV9aFW0j5ki33XZkq84xSa0pTfGwgRCMYP/HTaHlAtVbb3Mnse297yuDkyb3xv74YFyUfnqNQoKxe2HZLp8fa7y7yUWMIpngpJUhkmXA3IR5Fw91p813e3JPMWvPUDLoBYo5q6p+XTQx7WyW2eXq0NFsiQjn8G2KtKP9p93S5cK+KlfrMKbDuP6tmno6NqsmBB0JacHBqUcopTCuaTkFnMCkgqfK/lxIwGOs9MGfwB/+eDoC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VFqWt3C3GiMwn0ienLzXw+WIm/jth3sm6Zkj6QwY6hoZ+VNFyamGnz3FZJPGQ5D1svZ2aYqpAFf/R/VIxKmKRThSAcqd/82a1d+d3VOiL5DE+YyDvp3gSxg/J0HuaJ0Ltk+l3LFYkzeTHeer2MayjZCtAc04A38czXBxOcchQ+F/pedexaK09Vn0bpqUowkoGkNoiUYa0H2eqkwHOTLv0323JDmdwhxl3LmDWinkvglxl4SrORYM37BBpy7BWVKez3F/3LmT87gwIwn5sSisxP6oOc15Ofi4VJ7t5IVQ5xfs/P7bfvEv6BCpqxmgwhIODQQe457T1dm/E6E8bg5BljfqucJ8So1SVhFVkLrUpujY120p6spEWr+r5pyFAxEpNxyShaka5mICuwZdmQU9j69ARfx5MmS2MIX/FmG5isVqiATHQJVMjrhA1DQOJHiF58VtMWMDRpnlho+uHYaSAEhjE+ChOV8dLord6V80Qke5fEgtpkmypkZMYU++797uh1QxmDFKaW5uJkaRPbXTI+YJ3Kl10uBZ+gn3tXqjLj6/+vLLrN+eDCjz/aY/Xa/t7raXfAPtaDsObzAC6ZVEC7+PlW2xTUAM9S2laU2yzbBYbTBwiSZhx7qf24qkap3Mct1BRyHhnl3Y5ZAXBJLcE6JK/3VbBLH+GNAXAOY3JJb7Rl+C/O9QD0xkUIItISeBjc7P+DdYoLunCKTHVEJ55YvxYZAa6hm3gSTpJV3QwM3fQPKLxeI1GbTppGaOK4iIT83C8M6HfITUuAT+s7+nzsPPZLMOs4PfzC6sYMLBSLBBafXt7k5M5oOyOi5/S9oMmp6WILnn96Tago5SbyA+FXDIokE7sMU4NEU3se+X13oltNFT6K2AUclmzuayo9g3gv3CfUljgik9Xlvf9s/Zwf26eTkYlqydEjjUaPBbnr0bCBRmKhr1x7ljFo15t0egimylkN3xnu9a4oV4rVtfAebdu4rTxHhHafgoGW/LsBmyNi037x7TRwb23uJO+rsA1CROY58pig9nesoZWQfg9ttFDEsl3viybPBiyAfzI+xpFSeEaI0Fft6DaRY2fCW8tO3Lvbkb5I6jDw7JGJVWzyvLgaElniVYn8YPrfVspDZv1xl/OtNXLXZQKfdJ5jaBJwK+n1w3IpMCpnLW+rTmHZJ+JLT/RDcw9kr0Fo2t+QaGhny2K7/esFTZ92hwe6+x3clPr63ODxgPY5U1QWHUoC5piaxBmK5Q8BoWfupY24wfx6DasWbJPAR7AxUWtOhv6vj34xkMBoAUO4oBRphsyn6A2U9DBogO3Ak2D5X60wwzoO2ArisCSE5jdo/Y1n2FpdTBPlFv0Sed616FfUKFn8pyTpARpE0R/UXQvSJm6QEF/Zyk6NYIuck1BOzbuUPog87/h0Az0ehcs5WKDdcISs3PLJatb2uNVa9EuyznhUD50kKtzUHAvNfLJqk1ljy4jUX7tsijU/CLPtlavyBktLXnmrxaaevRoasGy/DIJHG/d/jqlCbDonAjuJiTla2KRp9xe5h8symBJ7UgOL1qXDCWndMbTlefzBN6bKao9FBICeLmIbuLTzeKYVYqARJj X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad99850b-4a72-49e9-65ad-08dd0479c6bd X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:58:43.1440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dne4Kxmm1d0adU1G7io9LLLFZLUkENIfXCsHMPdBJf9Qgpen5MNbli2reYLCimDIGIffKvxSorWSpRwMkdw9fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10278 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225847_227057_29D755C3 X-CRM114-Status: GOOD ( 20.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Same to "ldb" clock rate validation, call clk_round_rate() to validate "pix"(pixel clock) rate too. This may filter modes out whose pixel clock rates cannot be supported by the pixel clock tree. For example, when the pixel clock is derived from the i.MX8MP video_pll1_out clock and video_pll1_out clock rate is 1.0395GHz, mode 720x576p@50Hz with 27MHz pixel clock rate will be filtered out in LDB split mode because the PLL clock rate does satisfy the "ldb" clock rate(27MHz * 3.5 = 94.5MHz) with 11 division ratio while it cannot satisfy the "pix" clock rate with 38.5 division ratio(only integer division ratio is supported). Signed-off-by: Liu Ying --- Note that this patch depends on a patch in shawnguo/imx/fixes: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20241017031146.157996-1-marex@denx.de/ Also, this patch depends on patch 2. v7: * Put pixel clock properly by adding a dev managed action in fsl_ldb_probe(). v6: * New patch. drivers/gpu/drm/bridge/fsl-ldb.c | 53 +++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index d9436ff9ccc3..9afd91c30c88 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include @@ -11,6 +12,7 @@ #include #include #include +#include #include #include @@ -86,7 +88,8 @@ struct fsl_ldb { struct device *dev; struct drm_bridge bridge; struct drm_bridge *next_bridge; - struct clk *clk; + struct clk *clk_ldb; + struct clk *clk_pixel; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; bool ch0_enabled; @@ -176,15 +179,15 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, mode = &crtc_state->adjusted_mode; requested_link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); - clk_set_rate(fsl_ldb->clk, requested_link_freq); + clk_set_rate(fsl_ldb->clk_ldb, requested_link_freq); - configured_link_freq = clk_get_rate(fsl_ldb->clk); + configured_link_freq = clk_get_rate(fsl_ldb->clk_ldb); if (configured_link_freq != requested_link_freq) dev_warn(fsl_ldb->dev, "Configured LDB clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n", configured_link_freq, requested_link_freq); - clk_prepare_enable(fsl_ldb->clk); + clk_prepare_enable(fsl_ldb->clk_ldb); /* Program LDB_CTRL */ reg = (fsl_ldb->ch0_enabled ? LDB_CTRL_CH0_ENABLE : 0) | @@ -237,7 +240,7 @@ static void fsl_ldb_atomic_disable(struct drm_bridge *bridge, regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->lvds_ctrl, 0); regmap_write(fsl_ldb->regmap, fsl_ldb->devdata->ldb_ctrl, 0); - clk_disable_unprepare(fsl_ldb->clk); + clk_disable_unprepare(fsl_ldb->clk_ldb); } #define MAX_INPUT_SEL_FORMATS 1 @@ -269,15 +272,21 @@ fsl_ldb_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info, const struct drm_display_mode *mode) { + unsigned long link_freq, pclk_rate, rounded_pclk_rate; struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); - unsigned long link_freq; if (mode->clock > (fsl_ldb_is_dual(fsl_ldb) ? 160000 : 80000)) return MODE_CLOCK_HIGH; /* Validate "ldb" clock rate. */ link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock); - if (link_freq != clk_round_rate(fsl_ldb->clk, link_freq)) + if (link_freq != clk_round_rate(fsl_ldb->clk_ldb, link_freq)) + return MODE_NOCLOCK; + + /* Validate pixel clock rate. */ + pclk_rate = mode->clock * HZ_PER_KHZ; + rounded_pclk_rate = clk_round_rate(fsl_ldb->clk_pixel, pclk_rate); + if (rounded_pclk_rate != pclk_rate) return MODE_NOCLOCK; return MODE_OK; @@ -294,12 +303,20 @@ static const struct drm_bridge_funcs funcs = { .mode_valid = fsl_ldb_mode_valid, }; +static void fsl_ldb_clk_pixel_put(void *data) +{ + struct fsl_ldb *fsl_ldb = data; + + clk_put(fsl_ldb->clk_pixel); +} + static int fsl_ldb_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *remote1, *remote2; + struct device_node *remote0, *remote1, *remote2; struct fsl_ldb *fsl_ldb; int dual_link; + int ret; fsl_ldb = devm_kzalloc(dev, sizeof(*fsl_ldb), GFP_KERNEL); if (!fsl_ldb) @@ -313,9 +330,23 @@ static int fsl_ldb_probe(struct platform_device *pdev) fsl_ldb->bridge.funcs = &funcs; fsl_ldb->bridge.of_node = dev->of_node; - fsl_ldb->clk = devm_clk_get(dev, "ldb"); - if (IS_ERR(fsl_ldb->clk)) - return PTR_ERR(fsl_ldb->clk); + fsl_ldb->clk_ldb = devm_clk_get(dev, "ldb"); + if (IS_ERR(fsl_ldb->clk_ldb)) + return PTR_ERR(fsl_ldb->clk_ldb); + + /* Get pixel clock from display controller's OF node. */ + remote0 = of_graph_get_remote_node(dev->of_node, 0, 0); + fsl_ldb->clk_pixel = of_clk_get_by_name(remote0, "pix"); + of_node_put(remote0); + if (IS_ERR(fsl_ldb->clk_pixel)) + return PTR_ERR(fsl_ldb->clk_pixel); + + ret = devm_add_action_or_reset(dev, fsl_ldb_clk_pixel_put, fsl_ldb); + if (ret) { + dev_err(dev, "Failed to add pixel clock put devm action: %d\n", + ret); + return ret; + } fsl_ldb->regmap = syscon_node_to_regmap(dev->of_node->parent); if (IS_ERR(fsl_ldb->regmap)) From patchwork Thu Nov 14 06:57:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45CE3D65C53 for ; Thu, 14 Nov 2024 07:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sh2mPtEwOgrZGXRnEgtKxUVGiAWQLjMQ1OzcFne4f8Q=; b=yIiLpNM5nUFIP8OfnYrbD4f4Yw zgLkJVLTt2FoGDZAH35ps3WT8UGADuWV2iCRrTH2rtlUG3kpoPTtap8dGPJSX6L5k6pwD+dWQ7rDi chGd0bWh7TVH8CUpIXQ5HW6UwlUKPRaa2AgINlgvziFuI0CN5YRSSuGu8Cocl2ldSKpjnxQaz3aIk ofIZ3+HAamzemdRNa+2jNNQw/s6gR3wO0wMzW0/2Yix5CPVdc/Eh6iK4xYp9vED7x8D6i8cVnbuGc KAkO/E8jb3iL41aePBbNxYAWKM4dOAOX6nA1JFdypi223KAbsr6rDjfa90rTAJcG6qHTAoZvGXX2x TeJrfkaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBU0O-000000093IV-1Kn0; Thu, 14 Nov 2024 07:11:04 +0000 Received: from mail-am7eur03on20603.outbound.protection.outlook.com ([2a01:111:f403:260e::603] helo=EUR03-AM7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBToh-000000090Z9-3Ldk for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:59:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nbbse1Vf1IcdA1RUCPdw9OJUQvmIvEY1Y33XSQv5C2YmcN2LEmUlxNcVR8fzATQlk9EfPRQ4gs/V65s/QpqmfdS8kzCVkBBmYxa1fGkLxqkqnV8oYR6VFMeo309MZCYq4FikoEYnDJQy9vQcPafnaiFzxJETVNXhpsubmGiRyE/88E0w5leZqZjhvD+0kbdmCIhD/4Gv/RG1X3O6/CbDDkQtEbqzaMj3oWGvuZL0dbn6+9KgDN83gmYWrWffGLpSJYt7A46oonAsr5v9V+2Lur4cWtL89zGPzeXcdM4XD3pPWrLNWcNK6uiq22sTWRymVCZ/+h2vTvzcm86sd+h/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sh2mPtEwOgrZGXRnEgtKxUVGiAWQLjMQ1OzcFne4f8Q=; b=xqYFqZalddFTrjL8J1awNiK6iO/ZSVV/XYMcACZhwqQIj+qWNmFjpJHX/iRL1J3HpaVbbrvqpLaBK3vS5vcbaX2PSLN2VbWaCEpV9roj7U2vQH4dhkLcJdlgHdG/BESEwrh97A0y5SLPMt6GJns1Qs+9s4JZ2tBYpThr8anjExzXUngfhEeFbFBsWB3k6pGhNRFDbWl7OHIEVAzLMrefye2BZtvOvbWp7C8FOO/xcuZZThanpQotDWXp9kmy3Ebx1nIOMowWV7dLxcOnoC5k4jl3+nK6xMT42z/A1tmRo/UK/Wid8Pb4OWhF4DKZSzUCBytVb1B2uz8/5WL1e++2fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sh2mPtEwOgrZGXRnEgtKxUVGiAWQLjMQ1OzcFne4f8Q=; b=S7VeXms2FFMDrnw6qJqdt18utE+rsDvOx3504++HHYJNH7390Ac9taiGaZ/8qvpVzNuu5D5wj66izmDzJmkztUkbi01F0TKb/RPQ8lq3e5ZtmaYG4uxvj9J5BETfMZp+g2cQbzvun9rI/wNVrH6wwHIBcNAMWTBVc/DXE3rXqeFkO9hBDc+/Ei07Vg3BTKJJ1WFCdLipnaqHO90xW0129UVkJtAxe4+dllDm1Dqckmdx2XDaDE88UaKqkWMty1jC8m30SMlGJ/R9rrZbD+0cwjFeGKCF1HQ112DBDJrv92VkUXKU/Sp4fb/eWtsGZ0PVD10hB8oh/YW1l8+Kf6LSNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PA2PR04MB10278.eurprd04.prod.outlook.com (2603:10a6:102:408::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:58:56 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:58:56 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de Subject: [PATCH v7 6/7] arm64: dts: imx8mp-evk: Add NXP LVDS to HDMI adapter cards Date: Thu, 14 Nov 2024 14:57:58 +0800 Message-Id: <20241114065759.3341908-7-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PA2PR04MB10278:EE_ X-MS-Office365-Filtering-Correlation-Id: 08ab1ab6-7e25-4349-f767-08dd0479ce52 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: r3vOW70kZcI/KwViHK5ljKobJJg4EFmGbYv9dB+pvmtrkjC8NeoB1WqWxYONHjrsAytsEZ1QtLutetfhQSXIe9judb6qRvp9PnPfu7KPpdnaR7SvRSGNKp6zMLcfYVY8d0semrvkQhbKbnEYlW0pPua9Pk9aXrbPNzZmJp2xOZAi2gowoZWqjb/iqU1dHCMfu9D4Ab8LD4kH7h21jEIqV0qg5eHLEtWNA0FOnUr+578a/wjdF6AXxgXd25jzvmT0GTwWSa5MH3cT7XZ9XnXXWBxG3+Ce84QsHQ3r+kLrLgYXliMNHl/IQ/Qf7Zo+bqxucN4CZ96VbkvI/QiDLgmz3QGa6gbDLJ9sRwSSHKwH1+2lfLVjYYz1/yL39pemAKcBiVfDIuTDfgVDeNhiDwY0H+sFRk0V84f//SZc3whDjcgTzpWDE9aCrRDiC4ljyHfumR3ovdelU33O/XTg7+YWibqguKMTPBdtLxyy6az3qmpm6512L4T/iVxKegvdtxd6DK1ISwsJbeh6zSyCJWJRhxF5/yUpGcQjRg+vbuKaPQX+JT5LzV/mPjOP9GU0hPn+S3HaqCzSF3ZNHfzd2wEaPpCTI2m3rK/d9LciE/7MEwpRjEa2+sm8Tifl7MqXTmyuHqa3aVh5r19TzMxkUNlBVa1IP/GSSWxa4m8AX7+cbbAYXEqiEZU/EV9UPHWpZqObxOcuhJjL+1ve0D/A/C8TVYhn08g+iIEJGXK8uDvkcmbmZpKJK2yUrCIxrE3D4Ox5gMPHPgkh84FHeOUaLH+7c0XPFnZSI4qjs2Asrbh3rxPUr9VkpalQgPI4GRMfwtD388CY/KxRM6o1zCyhwUKlKqkg3o4nBqE344uFvoVBHt5Vf8RvHc6tMVVff92TC0rWGoAq5kTGlulcfCEaC6KoDwBgNWW43so2M9exKAfMUQ+tEz4Fg+3TcmO7Thn1oTkrXieOWii3EpLyJg8hxgUA5iFixLcmgA0Er/Nl38/gSNgo+RpZUkosai+9GWaEPQxRkRAhJpbUiP0PY4Wji55LtPHiJXt+OQkj0hRSgt0RKdjPGUf6yw+4MpB+e5TTWDCcSATHt7eBFQZJ+GSuhPPzibbB2isTNF2FT8vIHpf/vl6Ojb1t0uC4pXvMH+mqIdEDJkIv123ihJpU8XXuuEvLuV3D29LoVgQq7dteW6WCgZOVOkp35VA01M5URszN7JsoQcIwFJgnHAPGZlY8ii44C8LyLKmDqcfiouAdYrPzXIxaGFKy5iESlyLuI+gVylE5wRad3GyclG6lBfJLys8FDZZsRN97xu92GrcpADyeOBAgbhpq9r30rG1ZcSeh8zh7qRJu/RH5m3IKy7YKIl3asmJCfVQ3OXQZ0IuYOKic74Clptkk4SW0bCBQ7C0eDDsf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MgkYIXGuaUU6mqgE+11xmYr/6BeHHNBlJUPx+iLk9NHXTgPfmQKjx0gEkZrTI+9qyKoVKbTjCezpzujh7KtaJyxMqUoXfgDnK5Dd2XSqdWiN+FSCl3b7jCNcVisxX4zSqTIKy7Cz5qS09omU78J0ps7VROe4xbtkpQ2T/eV2jOdtlrNbrFuToclErx1ej1SnJl7E/fPGQBcKvVgndvHTDS1qFMgbBLN4I4pLJQybqRu8DPiFzPL+hlcCnubf45qvdn7yY5R2KOqdc6djNpmwGTaoJuYv7mSTt4rob7PdhClQM7sL7RM93C/fkZNjZrEAxFqryynJl1PLyctEtVs0n1+pU68xfXPNPip+GZcJ5dBVguzyal90hbA2S+QGi2MZocHNEG652vEbVu5m54wApVR0SRcUrsr7hGwZGKExemeiB6NU5Kv1G5nFnxz/eOVecdkrofkZEAmzI1aPQ7AUC2jEz6uUB1oXRPH1pbYiu6HTVclvDDBurb+4IdInK4qOpj8PUAg47Lq2nS9HeMxENb3vmlVjdFUOpTMt4ZLtMRofWZ/b/FaJtEpgaM0W2UaBYjbp0lFapoEPr7M8Ha2rjbZnOo9m+d6Bqhvo1x/Ql/KELElg6iMCguPdKbymavFjXNqV2uGZt31+U8MLNfsoSMUnZfL5bVSYuvL4O+62uXTA9eqUprH7LDYbqXJUrhD6/OpLgAxVRyJxg6pUqleiclbtEY7yKcfKmuFr/lqmXNaJUV3PmhmzcasF2fQm1xKQE8Tg3/pkta5Z0Ye3mDegYXNBQpdGswoS1rP0He3tqw1GZXpytBIxNsz18FAzUn1rI88Ze7mcz2zEZu3u22Bk/ThamxTJsbpL4Ovp5+Jb0iOa3R+ya86q1yaQW/dBMQSLWhfHvLzQFKVFiIKny0aD/gEgpZRE8hviwoeC1ivdxP9Exvsb7YCJ19JW84DLx9RX5aT97LYv8ntDZaR93X3T5waApj9a+lOYacDBpaUQ1n5uTQpfLl9r0sQ3rRgdeH8bBg9rhVf0TO5p7vgwkDwR2QEbcymI0aIhZGAWuNo+uUQUF5AqOlDO1PnC41qIk96Gl7Eq89zfcAg3sFhzKKIvKyleVhWzKZcUGt98r/FIz4LdDHm63LMyQxann4Efc06jVTtJsak/x8gdq52qN9eFDQByfh/81tZvfdWo8Fq+0OLXYSdYeEJYuW6qWekApOvD+4R3cdHiefxDrNPFk94YVYd8D9KOYkuzjFrugt9kuD5lDDGRFTCFEsNhcwNyJ4bBrwpWbQciVG5IW/EFAIfClbVpWz1MDQdSvAGH2BIva2B5biBhqEoQzQXIE+3rgc5Mw1JPRzAzyxzbY9OhU6KTsz+2xNupWPbttzNp3t0ST46dd4u/U+EoFGuzXRwiK+vaFxyfXWppvzFkktYxSY011Zr0uiHhL1lelwY0YaN1R20s3cKa7ZazkFzLY5Z7wbaFjSdrCndM2WxRkgxI3l365nRwm+4jznwBDcz+u0r26MULVnaHRryHmHkz/TY8VGpLM07nI5eRpTJV2sv099dCjCdEcyYx6g1dFtyzRVcOBbHBYBl+rssqTj1ZPjqUv4Bu X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08ab1ab6-7e25-4349-f767-08dd0479ce52 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:58:56.0121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gXTx34OOdfcdkrsiKnz2RPpDXtXsE+AiMueey2gKrtcg4O/hs3rzy+gYSesay5EvhF4wDmuIGJJlhrghl3XIOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10278 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225900_020517_AA80CBED X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org One ITE IT6263 LVDS to HDMI converter is populated on NXP IMX-LVDS-HDMI and IMX-DLVDS-HDMI adapter cards. Card IMX-LVDS-HDMI supports single LVDS link(IT6263 link1). Card IMX-DLVDS-HDMI supports dual LVDS links(IT6263 link1 and link2). Only one card can be enabled with one i.MX8MP EVK. Add dedicated overlays to support the below four connections: 1) imx8mp-evk-lvds0-imx-lvds-hdmi.dtso: i.MX8MP EVK LVDS0 connector <=> LVDS adapter card J6(IT6263 link1) 2) imx8mp-evk-lvds1-imx-lvds-hdmi.dtso: i.MX8MP EVK LVDS1 connector <=> LVDS adapter card J6(IT6263 link1) 3) imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso: i.MX8MP EVK LVDS0 connector <=> DLVDS adapter card channel0(IT6263 link1) i.MX8MP EVK LVDS1 connector <=> DLVDS adapter card channel1(IT6263 link2) 4) imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso: i.MX8MP EVK LVDS1 connector <=> DLVDS adapter card channel0(IT6263 link1) i.MX8MP EVK LVDS0 connector <=> DLVDS adapter card channel1(IT6263 link2) Part links: https://www.nxp.com/part/IMX-LVDS-HDMI https://www.nxp.com/part/IMX-DLVDS-HDMI Signed-off-by: Liu Ying --- v7: * No change. v6: * No change. v5: * No change. v4: * Rebase this patch upon next-20241025 to resolve conflicts when apply. v3: * Use data-mapping DT property instead of ite,lvds-link-num-data-lanes. (Dmitry, Biju) v2: * Add ite,lvds-link-num-data-lanes properties. arch/arm64/boot/dts/freescale/Makefile | 8 ++++ .../imx8mp-evk-imx-lvds-hdmi-common.dtsi | 29 ++++++++++++ ...8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso | 44 +++++++++++++++++++ ...imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi | 43 ++++++++++++++++++ .../imx8mp-evk-lvds0-imx-lvds-hdmi.dtso | 28 ++++++++++++ ...8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso | 44 +++++++++++++++++++ ...imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi | 43 ++++++++++++++++++ .../imx8mp-evk-lvds1-imx-lvds-hdmi.dtso | 28 ++++++++++++ arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 6 +++ 9 files changed, 273 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 42e6482a31cb..e2e828b352e7 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -211,8 +211,16 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-ivy.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-mallow.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-wifi-yavia.dtb +imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtbo +imx8mp-evk-lvds0-imx-lvds-hdmi-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds0-imx-lvds-hdmi.dtbo +imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtbo +imx8mp-evk-lvds1-imx-lvds-hdmi-dtbs += imx8mp-evk.dtb imx8mp-evk-lvds1-imx-lvds-hdmi.dtbo imx8mp-evk-mx8-dlvds-lcd1-dtbs += imx8mp-evk.dtb imx8mp-evk-mx8-dlvds-lcd1.dtbo imx8mp-evk-pcie-ep-dtbs += imx8mp-evk.dtb imx8mp-evk-pcie-ep.dtbo +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds0-imx-lvds-hdmi.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-lvds1-imx-lvds-hdmi.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-mx8-dlvds-lcd1.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-pcie-ep.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..44b30e9b3fde --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,29 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +/dts-v1/; +/plugin/; + +&{/} { + lvds-hdmi-connector { + compatible = "hdmi-connector"; + label = "J2"; + type = "a"; + + port { + lvds2hdmi_connector_in: endpoint { + remote-endpoint = <&it6263_out>; + }; + }; + }; +}; + +&lcdif2 { + status = "okay"; +}; + +&lvds_bridge { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso new file mode 100644 index 000000000000..4008d2fd36d6 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-dlvds-hdmi-channel0.dtso @@ -0,0 +1,44 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + dual-lvds-odd-pixels; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + + port@1 { + reg = <1>; + dual-lvds-even-pixels; + + it6263_lvds_link2: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link2>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..6eae7477abf8 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include +#include "imx8mp-evk-imx-lvds-hdmi-common.dtsi" + +&i2c2 { + #address-cells = <1>; + #size-cells = <0>; + + it6263: hdmi@4c { + compatible = "ite,it6263"; + reg = <0x4c>; + data-mapping = "jeida-24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lvds_en>; + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; + ivdd-supply = <®_buck5>; + ovdd-supply = <®_vext_3v3>; + txavcc18-supply = <®_buck5>; + txavcc33-supply = <®_vext_3v3>; + pvcc1-supply = <®_buck5>; + pvcc2-supply = <®_buck5>; + avcc-supply = <®_vext_3v3>; + anvdd-supply = <®_buck5>; + apvdd-supply = <®_buck5>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@2 { + reg = <2>; + + it6263_out: endpoint { + remote-endpoint = <&lvds2hdmi_connector_in>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso new file mode 100644 index 000000000000..9e11f261ad13 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds0-imx-lvds-hdmi.dtso @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds0-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso new file mode 100644 index 000000000000..af2e73e36a1b --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-dlvds-hdmi-channel0.dtso @@ -0,0 +1,44 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + dual-lvds-even-pixels; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + + port@1 { + reg = <1>; + dual-lvds-odd-pixels; + + it6263_lvds_link2: endpoint { + remote-endpoint = <&ldb_lvds_ch0>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@1 { + ldb_lvds_ch0: endpoint { + remote-endpoint = <&it6263_lvds_link2>; + }; + }; + + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi new file mode 100644 index 000000000000..8cc9d361c2a4 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include +#include "imx8mp-evk-imx-lvds-hdmi-common.dtsi" + +&i2c3 { + #address-cells = <1>; + #size-cells = <0>; + + it6263: hdmi@4c { + compatible = "ite,it6263"; + reg = <0x4c>; + data-mapping = "jeida-24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lvds_en>; + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; + ivdd-supply = <®_buck5>; + ovdd-supply = <®_vext_3v3>; + txavcc18-supply = <®_buck5>; + txavcc33-supply = <®_vext_3v3>; + pvcc1-supply = <®_buck5>; + pvcc2-supply = <®_buck5>; + avcc-supply = <®_vext_3v3>; + anvdd-supply = <®_buck5>; + apvdd-supply = <®_buck5>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@2 { + reg = <2>; + + it6263_out: endpoint { + remote-endpoint = <&lvds2hdmi_connector_in>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso new file mode 100644 index 000000000000..527a893a71b2 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk-lvds1-imx-lvds-hdmi.dtso @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2024 NXP + */ + +#include "imx8mp-evk-lvds1-imx-lvds-hdmi-common.dtsi" + +&it6263 { + ports { + port@0 { + reg = <0>; + + it6263_lvds_link1: endpoint { + remote-endpoint = <&ldb_lvds_ch1>; + }; + }; + }; +}; + +&lvds_bridge { + ports { + port@2 { + ldb_lvds_ch1: endpoint { + remote-endpoint = <&it6263_lvds_link1>; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index d26930f1a9e9..68e12a752edd 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -938,6 +938,12 @@ MX8MP_IOMUXC_SPDIF_TX__I2C5_SCL 0x400001c2 >; }; + pinctrl_lvds_en: lvdsengrp { + fsl,pins = < + MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 0x1c0 + >; + }; + pinctrl_pcie0: pcie0grp { fsl,pins = < MX8MP_IOMUXC_I2C4_SCL__PCIE_CLKREQ_B 0x60 /* open drain, pull up */ From patchwork Thu Nov 14 06:57:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 13874659 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68865D65C53 for ; Thu, 14 Nov 2024 07:13:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9RFAx+eG5slTsR1F0c8qXKsjr+VlAIhrhp3hD/H7tAk=; b=ZvnT4fgNrPCCWrRrMP55EXG9B2 PcqZJUzHhcmPisYyGlRiwPpuHK4YzvTvB7eb06bimWjCNgp6ivBxExacEIZC5oSnAGbXTPD4PSalK 4k2dM27+Q9DDdDT0x2ynsfF2t+MP612MKpJEJ+CgxZA5S3iokWilhdqfJq3bvOcGWa+d6bFfbGt3a RghlXFIQB6WX5i4gWwwtOUptrf7Vrki15WoRc8UyW4XAr4d2VXgPSfULe07ijdNtS03OtA1EHgkKg bnCALMblmh3JZVexlg3sm6o+H9iUpBPclHD98C56OIDPW8vyzcCm3UFNqHySutUl+UAV6obNjuOqD 08iVnA0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBU2A-000000093dm-0dCO; Thu, 14 Nov 2024 07:12:54 +0000 Received: from mail-am6eur05on2060b.outbound.protection.outlook.com ([2a01:111:f403:2612::60b] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBTov-000000090bf-03Bg for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2024 06:59:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HVoov7+TWlTtZ6sAF1gYkdnvaUMAo/kMZlfL8Oa2SDzCqgTqDi03yT4/STORUNCbgpQXFFsyQ7t1Yksd4PIYr34exHiz2KynuHjGB94w0HIhTAK6RSHApP/v7Jdv5PzOCjArh4w2uQqvPq7WJfGnU4d/EzC7YUcK/lE5SARihi3ho5xwXnrIdDT4VhwtJ1lXofjFzlIeOmQnM1QGUIbzRr7xJzAu9qkFSqY2VJOFWLiEXtIBm1Y/PN13cWUR+Q11G4vQg8sAjtOnCio7njlxSO0SYnqbw4SoxJRhEk6PY9Gm/Yda3vf/bfSwUUNvA4oruJqgemOyCsUV+E5pmHuHaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9RFAx+eG5slTsR1F0c8qXKsjr+VlAIhrhp3hD/H7tAk=; b=kMAKZ67ZjmR4HSgQ13EebjnrGkDBCn/T6/KxVcdmU2GJ+1t3Ne2qGsX7Rj9ojug0/i6ooLlx5MYIrpGrgREGu7EjHE02FskAzmfBcZS4sAtDJre3EG8GMTT/1qOP5rF0osMl2FK3lX48Mzxm8wl7GPOhVPWCZ6RW2watOb1vWieW352Dyz2KhzJpuV53Lc5amftXn7wlMkJbpjUnc0/TJYUOtJA7HccQCI/MM9jsHse10xQtMsVQ/YNCaBXFXinJ9NhTYQXRj28TTfwQKC9ScrBAkpFTsLToVMzmE0AxhpBijMGx0x/32avY0H/+4o9WiN90lK3Xs6/xMfSXiKY4ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9RFAx+eG5slTsR1F0c8qXKsjr+VlAIhrhp3hD/H7tAk=; b=i/NYgLAMxMqHSprGf8jgKMlY55VCKrZN8qScdWTew4E+8IibZAel/qKWoEEj5lEoPotqgaBsFqqtl76gXLQLhr1dUEJfN3/7rMnbeI7JQXflbkAnwYZjX8ZgzjKFkZC9KLXsm+07JIVGWPaZqDlZEqAzt/nF6lYZpi9GgWIJGqEcuERQ07n8rBZ6q6+xeVW7Nb9fiNXRYUECx9TvAK33f8TY/f5nBPj7FXvgCkjRJF6IWExAhzPsAR/aUL/3T0p1iwfVg0iWxbVNXmqTmYoFzSXcvpKehKJOSIMI/F2gqjtuzIYkXJjpD8i9tYwtMi6K/s85coUDqg2mfdVa7W0wGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by PA2PR04MB10278.eurprd04.prod.outlook.com (2603:10a6:102:408::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 06:59:08 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%5]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:59:08 +0000 From: Liu Ying To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, quic_bjorande@quicinc.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, arnd@arndb.de, nfraprado@collabora.com, marex@denx.de, Biju Das Subject: [PATCH v7 7/7] arm64: defconfig: Enable ITE IT6263 driver Date: Thu, 14 Nov 2024 14:57:59 +0800 Message-Id: <20241114065759.3341908-8-victor.liu@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114065759.3341908-1-victor.liu@nxp.com> References: <20241114065759.3341908-1-victor.liu@nxp.com> X-ClientProxiedBy: SG2P153CA0048.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::17) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|PA2PR04MB10278:EE_ X-MS-Office365-Filtering-Correlation-Id: 3260269a-3eb3-4795-115a-08dd0479d5a8 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: 5icwBDVgBxeJ/pBB11DRpIHISDptcUh4EKRKhvMrz/P7XzSz5z7w7ZhuoLe8fK9EtzXHUUmPWCEr0vfY6/rCF13PMm8CSCnoC83mfDRv45s1R9zZAOvZi7/IQgrfLg6SaVv8Z/PloveeuooKqSEINVsmVWMXXPUHcWH8b8vfgDKlE1OWkO6ZPOyILwyesfi4vm7THMY6Gp0jN3vDs7CovmblC7l27DfMnxjDwT8NUgJfOeTSMztETTfBgfrmiz99ePDsEpo2Itmui/yDeylqJYBpYTM7S5P0tzcohMrvv5lfhbWQY4BBW5mo8l8EYVqb0HLXJjEJ4QgPmL2+AZy7Dqr4x+LKvvlQ3k59S4I5wVaX/0Fr2lnOrBqv6+i0ahjbiBSY1WpJWlM9aNLjfwtg96fs50eZqnZFmEqbw9c4UpeavVXiOA0KI+IIhNHa/EIT1e4k6Rninr5HUA0J6VKVDTgFKmRqPTZtN6A/guswxjGVH44EghHZJXo4gUYTBFN0F3lJGHYQJxYPOc3U7LZ30FSm9lq5tUAZD6LIaCLSa0PNQuHPMftm/14XxBQaj81NB6rMd4P9cTjzrKEhx6+8ucSC2gJyDt6cyYE47CDxkumRdGSeKJvKtA5m8ILCwIJqtcihFRW0J14y3j+Xccq0pvJTcIpriSvfHr996rb3ygWfbKSyqpsqOxuREbQq69xMvrztMrK0NFnBJC03otO0vlJ1Bta7T6tu4OEPhMQ/tkdfUNMjJF79SjkUAKIDVw609rvCQOW5vLsiklps2h7tIEnn7OqmcOfDtuTjVEW2/Bi3TJHF4hB9J0H6YtJvX6c7RXUJvcMBbX4RSqmhqZzP2jvu8LzzlPCGO1tJOn6zU2uDlNd5z6AKPH0u50i5XtpPp8L6/kFq17EiWoW6zN1JCybnXszobI2EfkdD7WEcYusq+KSDfxcR1ll1Yjoa7WewzGAINLJ/R3/fFKMpGFyNLFHBxkSMN/GG9imPuVCh+ysxDUWYNqHe9DkHx662JJ05VXjaIp/QG54Xyd5vLMGO+7FwI+MOZuwuPAGSexGs8PWyb6EsgeJKJfbIo2XdDcBJI6ENCApnNuJi/fKN1RjdhLGXkitqud27aBpArORGZnacXSv7fHXZuq/N/P1y/+EQVxIQW5LmOZWYDqMOI42O2ygiWYYey+5LIOVbpVI5n5/k/NhsuhbGVGax0FaFs0w6ZnCMg1jmM8yFLbHwIiZStOIpG3jwAOVBioXEQkhZ6PkQjG924GVN6MH6RZXThlecryBy4Q97iirdIT6bDNnpIUweMmUfQPtVS4CL55ii/rR/VO8SaDfa+61DfkVLl/vTBW6ZC1v7zj6woTWb1+ADskSv5FxsH8H2wcVendAsJMA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A2dluw3xWi88DUP8C+8ltfsYw+iuSHap4EHc1/mlwMtr450KNaJQ/yl2W8ZSr3ivvNBOlV5qgpDThFUrWq90AKEhUEFM4a4l5s0t0KS0ev/XNbjQbtE2REFaEZjXOnSVEZbNmFHXG6EmFy0K+9kUJCSUnXWAhGfK1Cqm1ZmAGBZRVmTgIh9s2sG2KuRslhxcw7SPzbZLxY4yuB/3It/aRSJjozxivj9KJm4QIlwW3nkA47Jfw5FE8UmUqxWFVec6nlEpvoyCHx8CC9iwxwMzqNxOL9mMvdp4uljRkxo0GHVbiRF730tTlfcD1Sos1VgasP+7UeLWQ4jsfFyuJah75lu+Bw8IbK8mslbBm6npfaDe3I/xD/4kYpoKlsFvkFVLRqyzNyrZB90BWxBSU2SRyFiQM8BZ/dvRhUWgRyEKizVvUGWzfLGRVap3rknWJk8BzWfylNrNHK9cyLBzovHHMV7W2amwSFHkl8ZKRPWhyo/ESd3Pya6T07/cW72ghNBkTDYgySOv6Uq/vxOn/TI2JcIQnHNGavJZXQ4Ey85cjSSbtGyeiZ2zhJzo/GXynoH2FSfRCLF0HFlMEs1ixFEKuLQKU2U9NZXcJ+GP0HeUs+RIrDEXpS68eS7Ua4aTywrknKdMi50CgspK+3qQ/gsTNEOZs1HIMubpleBJHiuRgTAlYlH4GeA95LmmVafmai+0Hy+yh9Q6ypdW2z3YZQ/Uu4KtyeZnT0vHSZjfG7G9XdgHZ4rjtY/amoPJYmCZnjjnapnUDl8pgkv+uWu9b8ox1H1nz8YeB4rTjbTjBR2uTgohUoEWrGP3wRryEei4n1jfJR1HRl7mEo8wTtoXPiUl4uHPoouSsv5sv+xL6egaXL0DwNWFdQ8da4+Oy9mTGyIDcwQYrDSPPghtpUv6F5BzaO0LdsuZlrC5ViIwBkze8/RGVRnt7ZcvMGS8zsjvq/QQyScFg2S144wzRtqQNIWtZe+qjGJ+lE42SGW7nVNna7uJ4yypMtftOY7a+gk4rCDpj/TbCXMmDzal5U7vmpHPddss2Sdmxu3Hs7UOpcG849CcBq9QsdM0R9SWUPy5MvkK0lz0a8O5VnK++UnUpCh1PfNhffZIu1wyq2gucttH6hpV/6KO2pcwIO0AeDPJ9LnpdTv4dkDq9r5mUHp3xr6YSD0iMs3QgLtg5n3u+MkowBWHeaf4nYy2N20v38Imw1JePFUCYa0PgnK6FKwTEaND/+j+FaQzh0wDFGQa7eMmLGLr8CNt56XzdXQO4Si5Ygh//0Fe56FBXrW0djDz9VwkZzux1bp8UZ2T/xwuNGQUR87r1KlUG940sb4aLwC0tCpdTr+HmePPgc3u1wUkI2vCOOi/xdS0oKGNjM2+fDOSigb8JWqCD0b7lfbHNjZmCPX/t5kB7pQWum2BEgcaxiHShpOVd6QjV0ikcXljqO/kg97nFARSfFzUrVKQqIhHrNNZ7Kjh7qp3rz9EFurTrCJ4gwhKK337gVTX232zWg3nZwCmHsfM4jgjcKJuQ3vfHkvhTu1avDJrbgat4reFoSsSVT/GjjwNZSDyhY/n3JJwzWuKPeZwyZCq62AugC5C+rTu X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3260269a-3eb3-4795-115a-08dd0479d5a8 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:59:08.1895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kG93EY2GycZKPraTnuTEUWKGZ9XCMBrirFaHeXI2A3m03RVh+aiaANSUI83waa2JbwjpemqRw0SIgHCC2ZRJYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10278 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_225913_076683_71BA4D56 X-CRM114-Status: UNSURE ( 7.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ITE IT6263 LVDS to HDMI converter is populated on NXP IMX-LVDS-HDMI and IMX-DLVDS-HDMI adapter cards. The adapter cards can connect to i.MX8MP EVK base board to support video output through HDMI connectors. Build the ITE IT6263 driver as a module. Signed-off-by: Liu Ying Reviewed-by: Biju Das --- v7: * Collect Biju's R-b tag. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * No change. arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d13218d0c30f..9b20b75f82e2 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -901,6 +901,7 @@ CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m CONFIG_DRM_FSL_LDB=m +CONFIG_DRM_ITE_IT6263=m CONFIG_DRM_LONTIUM_LT8912B=m CONFIG_DRM_LONTIUM_LT9611=m CONFIG_DRM_LONTIUM_LT9611UXC=m