From patchwork Sun Nov 17 00:18:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 13877752 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C3A23AD for ; Sun, 17 Nov 2024 00:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802709; cv=none; b=JwQ5Q5MGcDEE8MuZBTODwyrOiaWiA3vXJ21iSU1/LjT3/EIiiVazJ7NmdfUWYNMF9PHmDImxc/qGAtszJKdO+PU2Mej0CxtwYADARTK5+kIlssJSo1SvNFTWjlQM5iMUjzV/j4Z0hTEAZpo7A4DmDQoktkZ0I10PFcEZvZw8XX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802709; c=relaxed/simple; bh=U8DLua6anqV8E/w4GKAvhQBIU61SH5TpOR6c2dKggLM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bcx6lw562sZlXwgHG59+ygiTauL01L9NaTle7tMLDrZ5zuEvBkPsGaDjJLLSZ3VS3Pz8EU03e0blM2iQ72BqFx6cN1D0TJJ45laNigC40bQ63jSe2Gzqafxuhr+zDer9uKLTdYtsgfPtsHiacw1GkiT8ELlNBFu0R3JBAjPBHaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RfabsiwD; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RfabsiwD" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3823cae4be1so425651f8f.3 for ; Sat, 16 Nov 2024 16:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731802706; x=1732407506; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gHAZXxDkM9wkQuJM13tdvIAHznsexaLn0Zv9nH84Vks=; b=RfabsiwDuOWcADBScO7dbpc7FLnpDayOC5l5T+aWGG/ZWiPmpHgk/gK2RkI5dDtuhp C0Y0Jm4P+KvXf8xsHiD0vuXxCTOu84iXHlo6L6yBr+DPxm3a30TJ8KEkJg6+imNRE9PA N2mvzs3MhJ9gDou6mrTabrA0AGADePr2DqP5yjWCaRRaHT2hQPIk3ak5/5sPfjvRLdPI IkcdfA7t+dY5VjDIB9jm0rxaUo+Aaddm3bRqlNHc1yz5Pxlsq7i3ePNPp7CwksuyV+Ar x3aOqGGuTvF+Lj35RV3lDu6i8rZg8UriZnBMKV2sDja3soSb1rRRZ7fP+r5ZNvhXc71u q1Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731802706; x=1732407506; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gHAZXxDkM9wkQuJM13tdvIAHznsexaLn0Zv9nH84Vks=; b=VEj9KuANp6/KcZkjFc//ZtVvxrRqmqpdbHGb5HYT1ymrtGpZGqbWF8etf2ZLq4RqH+ sTQDGpZ9+reeOa5/BDwR5GErbD1ZiIDpEcIFoQ2gQ16+SuwxGkHZATCl7N5lsewm/RWt E2X0fJv+32IPfnGbRTnjklCjhrfoYmcX5ITgw/SvYCXVR5PIHqOtdBfKlePExFD6K+ix lgd6zHJaIyiXb+B9sgjNOu8ozLobzVbbVyaksghI809gLSJtFhZpZw7jYHMoc3OdyqQw 9DaD9hCyHFWcIhml1Qi0kSBjK1UAXZwwc3hmsS2Lz3VDBcghGBTJjZNq+JjUag8NoOSw 9G3Q== X-Gm-Message-State: AOJu0YwBM2m+BL/BoTuH2M0W1lnjFbP7qpoczd1+BnBPKxiItXU2PHGh qUxWM0J86zmLsv3FVaIl0WKmF3EmHGiUDSHnNsfQ6fDD2hcU5o2T X-Google-Smtp-Source: AGHT+IH9tbJ5yDwxdJX3zTIjHXnGPJBg8xsORO1mFfcCSWEmgrwBkqCAcEKtYdRZwGKmSsN/2wgQ7w== X-Received: by 2002:a5d:6482:0:b0:37d:501f:483f with SMTP id ffacd0b85a97d-38225acd40bmr5609900f8f.44.1731802705632; Sat, 16 Nov 2024 16:18:25 -0800 (PST) Received: from nz.home ([2a00:23c8:a613:101:729c:d1ff:fe4f:94a3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3824259dda3sm357041f8f.77.2024.11.16.16.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 16:18:24 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 3E6F524A077F14; Sun, 17 Nov 2024 00:18:23 +0000 (GMT) From: Sergei Trofimovich To: ell@lists.linux.dev Cc: Sergei Trofimovich Subject: [PATCH 1/4] settings: fix -std=c23 build failure Date: Sun, 17 Nov 2024 00:18:11 +0000 Message-ID: <20241117001814.2149181-1-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: ell@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 gcc-15 switched to -std=c23 by default: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 As a result `ell` fails the build as: ell/settings.c: In function 'l_settings_get_embedded_value': ell/settings.c:1521:24: error: incompatible types when returning type '_Bool' but 'const char *' was expected 1521 | return false; | ^~~~~ The change uses poiter instead of a bool to return the zero value. --- ell/settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ell/settings.c b/ell/settings.c index a5f17d1..b46d00b 100644 --- a/ell/settings.c +++ b/ell/settings.c @@ -1518,7 +1518,7 @@ LIB_EXPORT const char *l_settings_get_embedded_value( struct embedded_group_data *group; if (unlikely(!settings)) - return false; + return NULL; group = l_queue_find(settings->embedded_groups, embedded_group_match, group_name); From patchwork Sun Nov 17 00:18:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 13877753 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A895D256E for ; Sun, 17 Nov 2024 00:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802709; cv=none; b=YuW7NJZdiFaZSlViQDEzdblVLmVeYbLh88vmVYRqaRY/IgHBMx5hFl/caZHvlusdXeA17YRgLWdj11U5A09JpVUNIfLceCyHAoM+X7ffUfEbptuWiZ6zb7G/ONs6wadQyP4EnwM3I/C2rznlibnCd7ZkcJXPepyVdSeKLPJfQ0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802709; c=relaxed/simple; bh=S7NAR9oCFBVG8QQwn1NWUioPmm01w4WJdkOG9Mpjplo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jhw0SZ1LqEk0LT7tZM1fjvHXQMHR6G3hqgdU/v4j3PS8G1fOWswTrVS/vxXijQ6leGJ6PhOI7KhvCzQGZAwC5a896Cw6wOfpkZtQvwW+QgaFuXPP9Z0IjIm0LFLvSiNzL+kcEdgRNdzziCDEjPiIaSV1SQB54IPPYEg+nGvi/rc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KVUypC+D; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KVUypC+D" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-431688d5127so24709115e9.0 for ; Sat, 16 Nov 2024 16:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731802706; x=1732407506; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AW1Spj5c1lIwPknle3i4B7rPj8NocNmpJtbThGG+56A=; b=KVUypC+DyJVZBUcxRQnZeHPgS3vtITSPt39OTjYOrcQ9e4CGEovXiDsCibKCg30AM1 4SF+8hC/4cSQuuYwv3rBflByatMSOi7BrJVcvjEi1CGdC88hfkl7s9+zh8MZAPz25qSo K9ryRGe7vj5+cHTKHK46hf9tmD0+u1d5LUCn+CJlfJF/5BRPh+V6cguYruIvBwGcGP3W l5zl1FCOmU1nf9+7yyFOcNjRzUloyDzf9VhCcY733yi0I0rVHnRfJs87XT5XToby6kN7 oevlP8xCVeKx9iFTFUaa4k6c/1cS77Bod2gNszKUNQq5LTFOrLWXs587JyV2J3u/PR2L RvKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731802706; x=1732407506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AW1Spj5c1lIwPknle3i4B7rPj8NocNmpJtbThGG+56A=; b=cYfq7ed2hJ3hqJ2ssqNQnYVKK0fT/dXdHBhF6SlN+qXW8QYitXY65AnTDqtS44Zx6W Q4iVBxnZX8JwYD4zGGWtLrJ9sGNgu3BhxQUX4F+F7EaPmwz1p3Z44PBYOU0liXdeluuG niUU7pkc5TmJsS1Hw/KPEOI6rg787rotWW/A2JfwfcbkMJRjzUrMIstiGKRCv5tekILH 5KDyOPezYUnLXuMsDWLGKkOETLUPvvNPZtyXwuJ6Gi4pfTUCxWQXXtXD59ZWfybl0LoN mf9EDvyoPuaZc8jpuWIOW/aEwdt6SWhegkORt7IsuIxCYy+N05UZv2uEcY9SjmqGvCGg Gohw== X-Gm-Message-State: AOJu0YxXs/jTCT1F67nV/7s4E0krmzeBtL4KZhqKL2fkKHrWK8wk4O4o snMKQfT6l7gZHI0oGcFTan1xUyR0/91Ygfxi25O2xE8/mQJmGHmU1Q/F1A== X-Google-Smtp-Source: AGHT+IH7sUluecTgLkKsybYCbGpCn4O6ETe7YZrWPaC8VIQYQssF9f6T/VjAmQ0dMIwsBHqJTcQTjw== X-Received: by 2002:a5d:5e8c:0:b0:381:dff2:cf08 with SMTP id ffacd0b85a97d-382258ed508mr5714730f8f.2.1731802705865; Sat, 16 Nov 2024 16:18:25 -0800 (PST) Received: from nz.home (host109-156-56-74.range109-156.btcentralplus.com. [109.156.56.74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3821ae2f67fsm8629843f8f.89.2024.11.16.16.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 16:18:24 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 4090324A077F16; Sun, 17 Nov 2024 00:18:23 +0000 (GMT) From: Sergei Trofimovich To: ell@lists.linux.dev Cc: Sergei Trofimovich Subject: [PATCH 2/4] cert: fix -std=c23 build failure Date: Sun, 17 Nov 2024 00:18:12 +0000 Message-ID: <20241117001814.2149181-2-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241117001814.2149181-1-slyich@gmail.com> References: <20241117001814.2149181-1-slyich@gmail.com> Precedence: bulk X-Mailing-List: ell@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 gcc-15 switched to -std=c23 by default: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff 259b06c212 As a result `ell` fails the build as: ell/cert.c:390:32: error: incompatible types when returning type '_Bool' but 'const uint8_t *' {aka 'const unsigned char *'} was expected 390 | return false; | ^~~~~ --- ell/cert.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ell/cert.c b/ell/cert.c index 38bb01a..19a6556 100644 --- a/ell/cert.c +++ b/ell/cert.c @@ -387,13 +387,13 @@ const uint8_t *cert_get_extension(struct l_cert *cert, seq = asn1_der_find_elem(ext, end - ext, 0, &tag, &len); if (unlikely(!seq || tag != ASN1_ID_SEQUENCE)) - return false; + return NULL; ext = seq + len; oid = asn1_der_find_elem(seq, len, 0, &tag, &oid_len); if (unlikely(!oid || tag != ASN1_ID_OID)) - return false; + return NULL; if (!asn1_oid_eq(ext_id, oid_len, oid)) continue; @@ -403,7 +403,7 @@ const uint8_t *cert_get_extension(struct l_cert *cert, if (data && tag == ASN1_ID_BOOLEAN) { if (data_len != 1) - return false; + return NULL; critical = *data != 0; /* Tolerate BER booleans */ @@ -411,7 +411,7 @@ const uint8_t *cert_get_extension(struct l_cert *cert, } if (unlikely(!data || tag != ASN1_ID_OCTET_STRING)) - return false; + return NULL; if (out_critical) *out_critical = critical; From patchwork Sun Nov 17 00:18:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 13877750 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4540B1392 for ; Sun, 17 Nov 2024 00:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802707; cv=none; b=sEI98HIoTeDemLsVwZnvR69mi3zgFKDviG85PqsQMGR6W7GB9xePBCV3xyu1mrof4cVb3gtY9++xZTMRrb5WQodCikyuerypUJj2BZWi3W55k01ZmhxpSJMaeonbwlaYC9MZP6xAK4BDyMT157XG0Rf4TqbzV0uJg9ujpH2k2Rc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802707; c=relaxed/simple; bh=vsR21quUTOJLW464jrRoGiPe9Hs3o6bh9dyjkgqdQXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G0ELB7ngf0+P7jJ80N192YcP5R5jpwetT5q8X5XZ7xtIkcUIpYIoLaYHBJF5B0Gyl8SS1CMI6ESBW7so85t/lbYw/TW1jEhgm57axXgxMlV7YH8v8FMXEAw6WhELGr2IxuVY51wQd+ZIGIWekxjKrygvYt1ykdEApJDLR/FAar8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QVuPh1ub; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVuPh1ub" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4315baa51d8so16620475e9.0 for ; Sat, 16 Nov 2024 16:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731802704; x=1732407504; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1HNksHPS/PVzynqLjSZAhH4fgavacgEjSKFz97rob00=; b=QVuPh1ubRUHvST+/4aD3JC8vwBU5HS6aKMIGl9JH3H9+NFc2yF3j3P6YEiSv/sZ39Y JSI2CX+y3SgocV7z9S4Vx/qpN9jqm5bLPEa6ULskUblmkypu5gyEQaujooQt3H8QKiPU hkgaI3VP63v4LY/zaernutjFGqtlb3DvnBDCus/sRVpIccl09QAJIjDovSReqYQHn01+ p9ITQvDdQJyXWCHMjskN74p7+Pp397Q+sm7St+TNsvtbGrKts0j1HqBqKgdQg87hDo+N wUXB8x3qsdDwxpuJcT36XRLNMiACAOKzz/zpbZliwV16W9ecFpMhkwvyEBmwvHn4fzmW v3xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731802704; x=1732407504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1HNksHPS/PVzynqLjSZAhH4fgavacgEjSKFz97rob00=; b=M5ZUDJa/iruwOpLK1SExcJAgXsYz2Gp3P07jbNQ/sFQAoDco/Qnzo7ymfxNA12/4Yr xWU9PyxqAOm5d+1PHqPvKO68tA+9dLivLZFGWm6Z9ghFMJXnEWzE8HYX/epiQ7i/noL7 zWXaYPCaDg06qPP1pmSMMVnZCcXZpHyLNURt+yCdGZA/HlDGOI77rtR7k44h9I4AGDlB Z/pCxHfrfcL9NdxMVmDYIWO5Lwmg3Z+pS69EbzOqumY6gXRdHkyjD9sHVdTxozEYMCC8 vgL1zCklPCRYfg4J5E4KYTuMi+qJQUZ3+qmnbG8rV4JPQ2UrNIi2vEhQEXpQQTYkamhQ 30YQ== X-Gm-Message-State: AOJu0Yww55lkYvQ5xdBGHcYR+Qe32hx7SZlR3VysdlOuluCRCVupfMn2 bJ+0EosQc3KBTr/4O9D8DwY3hWzP3RoMkjYm6Kw61wWR7GvMCKFi X-Google-Smtp-Source: AGHT+IFEHZds+Km+CoGuImOx4m5jjis0NwvJ5nI+5lySOqP80nidbhAO+6csAK6HxiVd7/yhpKRBag== X-Received: by 2002:a05:600c:46c8:b0:431:58cd:b259 with SMTP id 5b1f17b1804b1-432df790731mr64906095e9.31.1731802704362; Sat, 16 Nov 2024 16:18:24 -0800 (PST) Received: from nz.home (host109-156-56-74.range109-156.btcentralplus.com. [109.156.56.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da27fbd2sm106719105e9.19.2024.11.16.16.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 16:18:23 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 42F2524A077F18; Sun, 17 Nov 2024 00:18:23 +0000 (GMT) From: Sergei Trofimovich To: ell@lists.linux.dev Cc: Sergei Trofimovich Subject: [PATCH 3/4] dbus: fix -std=c23 build failure Date: Sun, 17 Nov 2024 00:18:13 +0000 Message-ID: <20241117001814.2149181-3-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241117001814.2149181-1-slyich@gmail.com> References: <20241117001814.2149181-1-slyich@gmail.com> Precedence: bulk X-Mailing-List: ell@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 gcc-15 switched to -std=c23 by default: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 As a result `ell` fails the build as: ell/dbus.c:1700:24: error: incompatible types when returning type '_Bool' but 'void *' was expected 1700 | return false; | ^~~~~ --- ell/dbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ell/dbus.c b/ell/dbus.c index bd6e1b8..1ab4ded 100644 --- a/ell/dbus.c +++ b/ell/dbus.c @@ -1697,10 +1697,10 @@ LIB_EXPORT void *l_dbus_object_get_data(struct l_dbus *dbus, const char *object, const char *interface) { if (unlikely(!dbus)) - return false; + return NULL; if (unlikely(!dbus->tree)) - return false; + return NULL; return _dbus_object_tree_get_interface_data(dbus->tree, object, interface); From patchwork Sun Nov 17 00:18:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 13877751 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9971C36 for ; Sun, 17 Nov 2024 00:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802708; cv=none; b=qKwvwGXBjgEAJ1ocz7ephRCwytcvBI78PA0c36NxX1oI8sYsXfonMqRaD2AfyYHkOfhYRkN2l56xrykqjNO1lNSkEpG+Y4JrgB+6K5QsOfIw2i9+mrFjNMs9wHdJ0RUNHnz1hQTEsncr9en1TPXa9/IHJ3dXvAYOh3l/W92y/8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731802708; c=relaxed/simple; bh=L8+uXtEZdpuJMzyr8qlEUABAVpdDOdjmo1m2KJvzub4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NwWwCa8btCeWAZVkeDNcyxI823hXrlEz8AF8/37Job+9RigWsBMPGhiJcE2y01QHaNn/cWJdkALeL4rUXOW8mzkJcvGbn6+oUgsXp5wXvTTaZCKP3E/Qz92tNJtzqalDLcoQRkueRGi+Xk2/sdzz/KGxsi2gepXXGO8ldx4EB7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GtmSuPgC; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GtmSuPgC" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38207c86695so2197353f8f.2 for ; Sat, 16 Nov 2024 16:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731802705; x=1732407505; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vfTtmxzuWsu6T7VtMVn4At/DamS5g05WGCBXuZ72XR4=; b=GtmSuPgC2VH7i+VYSFolmMA38fFGgQcEZJ20Us+sEeNPV0x+nCFZ6GM/bbg2cFUx5C T3F0ZfuvQJiXaWmhL3TNV1dNJtENUO12KFj50Ws4JPaVoPnjvCnvYWLbxbDtOVVyCL1S BFIlPKbUXnU5aduk6KtWevICVHXfsqmnht16E+XhxNsEj9UPigWtSWEBmAWvtu+mnC1+ 0iwvrmV2rfK+4G98kG1y6gs99B5bPSP09HasmFLjC8zs+YFM7LKw4zflUNrNpb15ASsL jzey4J6MBfs7ZBSIR411lp/H2j9g/ZtPZ5MxeRDe0S9AEkSmeT+CDARGc8AIhMFZxrKz H0XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731802705; x=1732407505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vfTtmxzuWsu6T7VtMVn4At/DamS5g05WGCBXuZ72XR4=; b=Y50V5+UTbnEjRr82YGbXt0AmlPNb5417rGKYN3hGq5q0xTABcpR7Fe261H8GP0Jla5 UzfEaW51ft6n8yEgJiDfpQz/wqbGcV9lgOiDErmqkVeyeNJkcatrAeQu/SSMUnfDftas lv/eu7WaZQ3ltXIolVfHorxzoVY5DTV8kF92r2G7aA3ghO25UeiQmJDZseOejxJauw0n YnEj2F1Yz0ccJz1DLvqOdSEiEUfFZp3NXR177WcrMs4jFKrF9+BCBHBEdBcygjoKxLul cvTUApLMJhGtRHPS1kVBChW3LmTxA1dyWE6ABpurizzRIM4HqvNhxZQRsKhhBLWpXMV/ LUtg== X-Gm-Message-State: AOJu0Yzg3oZwDoadmGOZxcPv6gKJe7Jhayth/zerLOvpbnorfHTVI+bA 15rz3tseS/ZKS4v7NCGQ/eu1h3zEsXCf1XnSSDeOcVjG/SGC0R+s X-Google-Smtp-Source: AGHT+IEJmesw+pBWgNdZDo9tp4c1tq0WKGFgnNOyj+vB4ks5d3y3PkyZM1dCqxej3BZAhQuibrwSCg== X-Received: by 2002:adf:e191:0:b0:382:531:536d with SMTP id ffacd0b85a97d-38225906ba5mr6385171f8f.21.1731802705410; Sat, 16 Nov 2024 16:18:25 -0800 (PST) Received: from nz.home ([2a00:23c8:a613:101:729c:d1ff:fe4f:94a3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-382224253f6sm7113497f8f.111.2024.11.16.16.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 16:18:24 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 45C9524A077F1A; Sun, 17 Nov 2024 00:18:23 +0000 (GMT) From: Sergei Trofimovich To: ell@lists.linux.dev Cc: Sergei Trofimovich Subject: [PATCH 4/4] test-rtnl: fix -std=c23 build failure Date: Sun, 17 Nov 2024 00:18:14 +0000 Message-ID: <20241117001814.2149181-4-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241117001814.2149181-1-slyich@gmail.com> References: <20241117001814.2149181-1-slyich@gmail.com> Precedence: bulk X-Mailing-List: ell@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 gcc-15 switched to -std=c23 by default: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 As a result `ell` fails the build as: unit/test-rtnl.c: In function 'test_run': unit/test-rtnl.c:501:24: error: passing argument 1 of 'l_idle_oneshot' from incompatible pointer type [-Wincompatible-pointer-types] 501 | l_idle_oneshot(test_next, NULL, NULL); | ^~~~~~~~~ | | | void (*)(void) --- unit/test-rtnl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/unit/test-rtnl.c b/unit/test-rtnl.c index 59d8492..6fbac9e 100644 --- a/unit/test-rtnl.c +++ b/unit/test-rtnl.c @@ -358,6 +358,12 @@ static void test_next() test->start(rtnl, test->data); } +static void test_next_cb(void * unused) +{ + (void)unused; + test_next(); +} + #define test_assert(cond) \ do { \ if (!(cond)) { \ @@ -498,7 +504,7 @@ static void test_run(void) { success = false; - l_idle_oneshot(test_next, NULL, NULL); + l_idle_oneshot(test_next_cb, NULL, NULL); l_main_run_with_signal(signal_handler, NULL); }