From patchwork Wed Mar 13 15:07:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10851337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B78371575 for ; Wed, 13 Mar 2019 15:07:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A39BE2877E for ; Wed, 13 Mar 2019 15:07:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97E8E29276; Wed, 13 Mar 2019 15:07:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E3482877E for ; Wed, 13 Mar 2019 15:07:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbfCMPHt (ORCPT ); Wed, 13 Mar 2019 11:07:49 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34341 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfCMPHt (ORCPT ); Wed, 13 Mar 2019 11:07:49 -0400 Received: by mail-wm1-f66.google.com with SMTP id o10so4670443wmc.1 for ; Wed, 13 Mar 2019 08:07:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vEMKkG3s/JUgNbpBXoysD3tEBH/BFsvtW/Te48muOrc=; b=jTYqkSKrlWvpdRChuC/fl+IytTK2P1MRmLHWNfWQihneQt/kAx+LolcgYyNDG6mayB J0yGV7p5noGMjaesOPQEy0a4iMo+g8BwRxx2MrzLM3Cw7mmlYVx+Qh5AmICLI4WdMd/6 6x9kmn8HFhn1/4OVOKrObAqR0P9Anyqcfk16GV6zum+WZbIL3wqUbBa1RmL9khjKv7Io MlLto0vjOJKjRzwel6wxKo21fMIzl2FvL0BIVS3dtqFFTLBC8fawGSyAOkzoeDLgPk7m pkAjFoauEniGymkX+GpddX5K0wnGeVGLc8iDfWb0u6YLKwUxiV+Kx32Ioh9MG328Sk1G Nl8g== X-Gm-Message-State: APjAAAVdvYb3ifVvHxN7Lm9JksMP3pXGVTE/5T2lx/vPwLhsbokT6DHS iJtK431FkRrLxHyyVqA+I22eMu4z3k4= X-Google-Smtp-Source: APXvYqyzi+Swt6NC5qK/f/UVu/5HG4OiVkuku9b8pJK8qFl4tgpUrCGNIZVZ6M064U2JG9iXZJBRWw== X-Received: by 2002:a1c:7903:: with SMTP id l3mr2801560wme.22.1552489667586; Wed, 13 Mar 2019 08:07:47 -0700 (PDT) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id f6sm22515103wrs.45.2019.03.13.08.07.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 08:07:47 -0700 (PDT) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 1/4] kernel-shark: Define addPlugins method for KsPluginManager Date: Wed, 13 Mar 2019 17:07:14 +0200 Message-Id: <20190313150717.21345-2-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190313150717.21345-1-ykaradzhov@vmware.com> References: <20190313150717.21345-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The method can be used to register and load user-defined plugins. All other previously loaded plugins will be reinitialized and the data will be reloaded. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsUtils.cpp | 23 +++++++++++++++++++++++ kernel-shark/src/KsUtils.hpp | 3 +++ 2 files changed, 26 insertions(+) diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp index 3585cca..6af0c66 100644 --- a/kernel-shark/src/KsUtils.cpp +++ b/kernel-shark/src/KsUtils.cpp @@ -596,6 +596,29 @@ void KsPluginManager::unregisterPlugin(const QString &plugin) } } +/** @brief Add to the list and initialize user-provided plugins. All other + * previously loaded plugins will be reinitialized and the data will be + * reloaded. + * + * @param fileNames: the library files (.so) of the plugins. +*/ +void KsPluginManager::addPlugins(const QStringList &fileNames) +{ + kshark_context *kshark_ctx(nullptr); + + if (!kshark_instance(&kshark_ctx)) + return; + + kshark_handle_plugins(kshark_ctx, KSHARK_PLUGIN_CLOSE); + + for (auto const &p: fileNames) + registerPlugin(p); + + kshark_handle_plugins(kshark_ctx, KSHARK_PLUGIN_INIT); + + emit dataReload(); +} + /** Unload all plugins. */ void KsPluginManager::unloadAll() { diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp index cb95b4f..c8b5e88 100644 --- a/kernel-shark/src/KsUtils.hpp +++ b/kernel-shark/src/KsUtils.hpp @@ -210,6 +210,9 @@ public: void registerPlugin(const QString &plugin); void unregisterPlugin(const QString &plugin); + + void addPlugins(const QStringList &fileNames); + void unloadAll(); void updatePlugins(QVector pluginId); From patchwork Wed Mar 13 15:07:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10851339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DD861575 for ; Wed, 13 Mar 2019 15:07:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A3582877E for ; Wed, 13 Mar 2019 15:07:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E03F29276; Wed, 13 Mar 2019 15:07:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23BE62877E for ; Wed, 13 Mar 2019 15:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725907AbfCMPHv (ORCPT ); Wed, 13 Mar 2019 11:07:51 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51787 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfCMPHu (ORCPT ); Wed, 13 Mar 2019 11:07:50 -0400 Received: by mail-wm1-f66.google.com with SMTP id n19so2443006wmi.1 for ; Wed, 13 Mar 2019 08:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c0h2OYd+4fDOGzkfYdDN2PpY5KS+qCoACIVlWKMD3rI=; b=elSxK4CMGD/pHqJ/QaXnKZ80ktkXX/t9lwXJ1uZ69BhlLU8Oy1LgIk2gNhuUe7zzgd mw3P72elm9OAaMPyM4dLcmoO7HDuVpwjWHVgGP9eTCXlavGA2yo65UnVfC3TDepr+r9E 5sTJs+6JbF4aS4GQOXz/sK/lnbJDmI9l+WS/jxP0iNvQmegQXgtmzn0eE7Ft00cqX0IY NJqMYIN8+jHbWCokBANrV+RGrmXg5in669qlXNIcEbRl75EyfMk2tVlWVFQElFl/iQsB u2qXYmcP5ZHmT2r8k0wcFbGuO7SN9GxFREUHxqcYIPGjDZ3NZsbTmatpexfGyX0kSox7 9gww== X-Gm-Message-State: APjAAAU9W86RC8DM8Y5RqJ+y22oRVETtZukjzz7mOueP4qBVlf7FT68z AkkstjifUBlMaqMN4X5GdEM= X-Google-Smtp-Source: APXvYqyLhOxJ80B9g/0NMKYt6qHeEtXBJrJCesSAzF5fbrzgL7hVKwxD5xB4zZPuZwmsJ5WCM47XMA== X-Received: by 2002:a1c:3c02:: with SMTP id j2mr2731286wma.72.1552489669077; Wed, 13 Mar 2019 08:07:49 -0700 (PDT) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id f6sm22515103wrs.45.2019.03.13.08.07.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 08:07:48 -0700 (PDT) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 2/4] kernel-shark: Add dialog for user-defined plugins to the Tools menu Date: Wed, 13 Mar 2019 17:07:15 +0200 Message-Id: <20190313150717.21345-3-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190313150717.21345-1-ykaradzhov@vmware.com> References: <20190313150717.21345-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dialog allows the user to find and load the plugin's lobrary (.so file). Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 22 ++++++++++++++++++++++ kernel-shark/src/KsMainWindow.hpp | 4 ++++ 2 files changed, 26 insertions(+) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 362b955..6428d4d 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -59,6 +59,7 @@ KsMainWindow::KsMainWindow(QWidget *parent) _cpuSelectAction("CPUs", this), _taskSelectAction("Tasks", this), _pluginsAction("Plugins", this), + _addPluginsAction("Add plugins", this), _captureAction("Record", this), _colorAction(this), _colSlider(this), @@ -233,6 +234,11 @@ void KsMainWindow::_createActions() connect(&_pluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); + _addPluginsAction.setStatusTip("Add plugins"); + + connect(&_addPluginsAction, &QAction::triggered, + this, &KsMainWindow::_pluginAdd); + _captureAction.setIcon(QIcon::fromTheme("media-record")); _captureAction.setShortcut(tr("Ctrl+R")); _captureAction.setStatusTip("Capture trace data"); @@ -336,6 +342,7 @@ void KsMainWindow::_createMenus() /* Tools menu */ tools = menuBar()->addMenu("Tools"); tools->addAction(&_pluginsAction); + tools->addAction(&_addPluginsAction); tools->addAction(&_captureAction); tools->addSeparator(); tools->addAction(&_colorAction); @@ -796,6 +803,21 @@ void KsMainWindow::_pluginSelect() dialog->show(); } +void KsMainWindow::_pluginAdd() +{ + QStringList fileNames; + + fileNames = + QFileDialog::getOpenFileNames(this, "Add KernelShark plugins", + KS_DIR, + "KernelShark Plugins (*.so);;"); + + if (fileNames.isEmpty()) + return; + + _plugins.addPlugins(fileNames); +} + void KsMainWindow::_record() { #ifndef DO_AS_ROOT diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp index 969b603..1e6d619 100644 --- a/kernel-shark/src/KsMainWindow.hpp +++ b/kernel-shark/src/KsMainWindow.hpp @@ -132,6 +132,8 @@ private: // Tools menu. QAction _pluginsAction; + QAction _addPluginsAction; + QAction _captureAction; QWidgetAction _colorAction; @@ -185,6 +187,8 @@ private: void _pluginSelect(); + void _pluginAdd(); + void _record(); void _setColorPhase(int); From patchwork Wed Mar 13 15:07:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10851341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6005A1515 for ; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 490BA2877E for ; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A41B29276; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D38DA2877E for ; Wed, 13 Mar 2019 15:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726167AbfCMPHw (ORCPT ); Wed, 13 Mar 2019 11:07:52 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35518 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfCMPHw (ORCPT ); Wed, 13 Mar 2019 11:07:52 -0400 Received: by mail-wm1-f66.google.com with SMTP id y15so2271225wma.0 for ; Wed, 13 Mar 2019 08:07:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e2+ML2lpSIwhj2QPgw+Z9SlnkrCwUyUcM+MPXVLqLo8=; b=L2/6lW0tni2rOgl3PCjI+chrPuNYCriqfQCBKFJkZP0wiEKMjScpK/0YmbjxgJMSQC u4s+bVrW0cFw/nLGxAhOzKEt4ugUgHCclr7NVHwWRNz8wa0bC4mtgngck5RwNI7EG4pk hJS8kLyEDh4+lvNiuvXjJ2W0+EUkj8gW79En2ko5i0+gYWbfAfud0Hpfsh4+LHiSi2Vb ZyAmSP4jQCClavrrwOJja8MN3hNDmpkw3bBYaBU26VA81oRq8gq/rTqyJ4gtMYnGZR8Q 2S5xyuzt+hu0gFTm1BcaKABYoy15mIIGtgWu6diSeBqsiN96t6nErKnrQaOokyHB5Ev4 dkWg== X-Gm-Message-State: APjAAAUJsDz7ADq1kh0maRd1zpFAN4ZwK7i7zXa4A0C0hMqbmD7okcJr zBjhKZvGe5P1qHTvNsCVwqc= X-Google-Smtp-Source: APXvYqzHUxeJtAABbkiYEynSPwbWWePrNNNrIlrT8uAerRe+WrgSAgxBboqBAh3TiptJQjG2KdJ4Uw== X-Received: by 2002:a7b:c413:: with SMTP id k19mr2713426wmi.75.1552489670342; Wed, 13 Mar 2019 08:07:50 -0700 (PDT) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id f6sm22515103wrs.45.2019.03.13.08.07.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 08:07:49 -0700 (PDT) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 3/4] kernel-shark: Rename the manu action for managing registered plugins Date: Wed, 13 Mar 2019 17:07:16 +0200 Message-Id: <20190313150717.21345-4-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190313150717.21345-1-ykaradzhov@vmware.com> References: <20190313150717.21345-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The menu action in Tools that is used to manage all registered plugins is renamed in order to avoid confusion with the "Add plugins" menu action, implemented in the previous patch. Signed-off-by: Yordan Karadzhov Reviewed-by: Slavomir Kaslev --- kernel-shark/src/KsMainWindow.cpp | 10 +++++----- kernel-shark/src/KsMainWindow.hpp | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 6428d4d..f165797 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -58,7 +58,7 @@ KsMainWindow::KsMainWindow(QWidget *parent) _clearAllFilters("Clear all filters", this), _cpuSelectAction("CPUs", this), _taskSelectAction("Tasks", this), - _pluginsAction("Plugins", this), + _managePluginsAction("Manage plugins", this), _addPluginsAction("Add plugins", this), _captureAction("Record", this), _colorAction(this), @@ -228,10 +228,10 @@ void KsMainWindow::_createActions() this, &KsMainWindow::_taskSelect); /* Tools menu */ - _pluginsAction.setShortcut(tr("Ctrl+P")); - _pluginsAction.setStatusTip("Manage plugins"); + _managePluginsAction.setShortcut(tr("Ctrl+P")); + _managePluginsAction.setStatusTip("Manage plugins"); - connect(&_pluginsAction, &QAction::triggered, + connect(&_managePluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); _addPluginsAction.setStatusTip("Add plugins"); @@ -341,7 +341,7 @@ void KsMainWindow::_createMenus() /* Tools menu */ tools = menuBar()->addMenu("Tools"); - tools->addAction(&_pluginsAction); + tools->addAction(&_managePluginsAction); tools->addAction(&_addPluginsAction); tools->addAction(&_captureAction); tools->addSeparator(); diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp index 1e6d619..a93382a 100644 --- a/kernel-shark/src/KsMainWindow.hpp +++ b/kernel-shark/src/KsMainWindow.hpp @@ -130,7 +130,7 @@ private: QAction _taskSelectAction; // Tools menu. - QAction _pluginsAction; + QAction _managePluginsAction; QAction _addPluginsAction; From patchwork Wed Mar 13 15:07:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10851343 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB65A1850 for ; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3CC92877E for ; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A798B291B6; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D90B292D0 for ; Wed, 13 Mar 2019 15:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725832AbfCMPHx (ORCPT ); Wed, 13 Mar 2019 11:07:53 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55719 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfCMPHx (ORCPT ); Wed, 13 Mar 2019 11:07:53 -0400 Received: by mail-wm1-f67.google.com with SMTP id 4so2421890wmf.5 for ; Wed, 13 Mar 2019 08:07:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zM4/cniex0RPub+n6nwDE8Ty05i3cXHEeJjGDBMBfRw=; b=CuxXH8smCWA+WTHsj5nYMazRqdN6R6K93tDbVbPLZGxkHXZgJC6Sam3+CJ7zhuCdde Ka5ndSDgNEYwVJdkUkXWUXq8/aH13n54MlEp4RTttwXpnI15YuZVHofhPUfe2kUubA9k ac9XpiGAzXbLdRoOhBhQ2edVGSxcIUyxpVKxOXHXDOE42F2NIyR5Sr0FIVFU4B+6zbI8 vfJXgk0ebXTSLKaIZwnviZPn4eAnlpPJglWbEbG8cPMw5UD3/ztPd+ufVQcToIsP5bZ7 8iL4PGFXdmaFh1Rg3nk0xAJIZkRG0V7MkFDHNTM1gU+N0QfcEW+qv59MW0Ha6J22gY2i 0YxQ== X-Gm-Message-State: APjAAAVdBUu1G4tSoxdz0mf1Ex8/YVBcybYSZQPM5HoaaRkET9AHunSG 6DCnSDz/YccuOPMpsg6et6Y= X-Google-Smtp-Source: APXvYqxCunxlufyu1lVshWy0bz7siukYUAf6xUZLmIJsMpqP3D37/YQiqK0P1BViDvId8hqVg8DYcg== X-Received: by 2002:a7b:cbd1:: with SMTP id n17mr2558290wmi.21.1552489671614; Wed, 13 Mar 2019 08:07:51 -0700 (PDT) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id f6sm22515103wrs.45.2019.03.13.08.07.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 08:07:51 -0700 (PDT) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH v2 4/4] kernel-shark: Add icons for "Add plugins" and "Manage plugins" Date: Wed, 13 Mar 2019 17:07:17 +0200 Message-Id: <20190313150717.21345-5-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190313150717.21345-1-ykaradzhov@vmware.com> References: <20190313150717.21345-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Just a small cosmetic improvement. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index f165797..8ac19a7 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -229,11 +229,13 @@ void KsMainWindow::_createActions() /* Tools menu */ _managePluginsAction.setShortcut(tr("Ctrl+P")); + _managePluginsAction.setIcon(QIcon::fromTheme("preferences-system")); _managePluginsAction.setStatusTip("Manage plugins"); connect(&_managePluginsAction, &QAction::triggered, this, &KsMainWindow::_pluginSelect); + _addPluginsAction.setIcon(QIcon::fromTheme("applications-engineering")); _addPluginsAction.setStatusTip("Add plugins"); connect(&_addPluginsAction, &QAction::triggered,