From patchwork Wed Nov 27 10:30:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Picej X-Patchwork-Id: 13887403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91C2D6D247 for ; Wed, 27 Nov 2024 22:47:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1A0D10E052; Wed, 27 Nov 2024 22:47:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=norik.com header.i=@norik.com header.b="FIyOGmrP"; dkim-atps=neutral Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id F017910E22C for ; Wed, 27 Nov 2024 11:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YDXSwxdQFKqF1c/3avYtLd4G9gMBk0YXaL0G1r3dLXc=; b=FIyOGmrPJwNmk5+OJm7laIa2/Z ir0dwoYtdw7FyovDD18pnqGkgveT4ngssKEaznw/AGRyt+LREHf0z5UBb1V+3EsyHAN2juTv4u/xu uu0MecOyXO1CFWjKrMQ9hei7Rb25PtLZ0ApM/wJ0umLEL62wjYp0/RyCuGLQIOj8t1Fe8/oWMnU2k 8g67j2E8ybW8KjwylpZZSfPjfo+XrFdN4BudENEusn255TSLZ2mU4ASs4/jypJeMDENSWRvtcQS4t I82wv6s+TrMVO1vfLInB8TaGgZ9BCTZ4zCPomzcN/4nBikuz/XMmvYXu6+w79bZFqmOxilm/RsGVw 7hsrZklA==; Received: from [89.212.21.243] (port=49750 helo=and-HP-Z4..) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tGFK3-007Rx6-2G; Wed, 27 Nov 2024 11:31:03 +0100 From: Andrej Picej To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti, lvds-vcom Date: Wed, 27 Nov 2024 11:30:29 +0100 Message-Id: <20241127103031.1007893-2-andrej.picej@norik.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241127103031.1007893-1-andrej.picej@norik.com> References: <20241127103031.1007893-1-andrej.picej@norik.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.freedesktop.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-Mailman-Approved-At: Wed, 27 Nov 2024 22:47:27 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Janine Hagemann Add an optional property to change LVDS output voltage. This depends on the connected display specifications. With this property we directly set the LVDS_VCOM (0x19) register. Better register property mapping would be quite tricky. Please check bridge's datasheet for details on how register values set the LVDS data lines and LVDS clock output voltage. Signed-off-by: Janine Hagemann Signed-off-by: Andrej Picej --- .../bindings/display/bridge/ti,sn65dsi83.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index 48a97bb3e2e0..5b2c0c281824 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -58,6 +58,12 @@ properties: - const: 2 - const: 3 - const: 4 + ti,lvds-vcom: + $ref: /schemas/types.yaml#/definitions/uint32 + description: LVDS output voltage configuration. This defines + LVDS_VCOM (0x19) register value. Check bridge's datasheet for + details on how register values set the LVDS data lines and + LVDS clock output voltage. port@1: $ref: /schemas/graph.yaml#/$defs/port-base @@ -78,6 +84,12 @@ properties: - const: 2 - const: 3 - const: 4 + ti,lvds-vcom: + $ref: /schemas/types.yaml#/definitions/uint32 + description: LVDS output voltage configuration. This defines + LVDS_VCOM (0x19) register value. Check bridge's datasheet for + details on how register values set the LVDS data lines and + LVDS clock output voltage. port@2: $ref: /schemas/graph.yaml#/properties/port @@ -120,7 +132,7 @@ allOf: properties: port@1: false -additionalProperties: false +additionalProperties: true examples: - | From patchwork Wed Nov 27 10:30:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Picej X-Patchwork-Id: 13887408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A72FDD6D247 for ; Wed, 27 Nov 2024 22:47:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F00D610E302; Wed, 27 Nov 2024 22:47:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=norik.com header.i=@norik.com header.b="aASOeJoy"; dkim-atps=neutral Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4430510EA93 for ; Wed, 27 Nov 2024 11:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HDovDaEOFR4qUZaygP6Mpx2tbmWwjmnzTWmEO3UiYwo=; b=aASOeJoywklCeOh/F6TjHzBMJD mTL5Ymn8eus4irgeCOC5ll4doPl5wfve0rmQDmsf+9muLv/b1Avq/si6cQ1Ehj8t/6fKN05k10sc5 yAnF7gaZpRoUElF+y3i9I0tk6y5V6kV4Dh/KBWzM/wxkB/HQwSwMBH+NN59+A2IEMuhCGCuMbt5IG /NvPtHinS3ioDY8ZXWLHW0tkP6S7Q8SUftXXxSN6PI4RcDhyeXZdo1yBzHUnb9OvvNYsZbi5/1orP PFDEmzwMcNnukb6MYWPA3p7jN68U2Cis/X9SoW/SBpnHN9e7DePeZcu5SnLoggNsltqhkIWd5gKkw UreS43aw==; Received: from [89.212.21.243] (port=49750 helo=and-HP-Z4..) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tGFK8-007Rx6-32; Wed, 27 Nov 2024 11:31:08 +0100 From: Andrej Picej To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] drm/bridge: ti-sn65dsi83: Add ti, lvds-vcom as optional property Date: Wed, 27 Nov 2024 11:30:30 +0100 Message-Id: <20241127103031.1007893-3-andrej.picej@norik.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241127103031.1007893-1-andrej.picej@norik.com> References: <20241127103031.1007893-1-andrej.picej@norik.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.freedesktop.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-Mailman-Approved-At: Wed, 27 Nov 2024 22:47:27 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Janine Hagemann Add a optional property to change LVDS output voltage. This should not be static as this depends mainly on the connected display voltage requirement. If the property is not present, the default value of 0x05 is used. Signed-off-by: Janine Hagemann Signed-off-by: Andrej Picej --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 57a7ed13f996..d6824f6501b6 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -147,6 +147,7 @@ struct sn65dsi83 { struct regulator *vcc; bool lvds_dual_link; bool lvds_dual_link_even_odd_swap; + u32 lvds_vcom; }; static const struct regmap_range sn65dsi83_readable_ranges[] = { @@ -435,7 +436,7 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge, val |= REG_LVDS_FMT_LVDS_LINK_CFG; regmap_write(ctx->regmap, REG_LVDS_FMT, val); - regmap_write(ctx->regmap, REG_LVDS_VCOM, 0x05); + regmap_write(ctx->regmap, REG_LVDS_VCOM, ctx->lvds_vcom); regmap_write(ctx->regmap, REG_LVDS_LANE, (ctx->lvds_dual_link_even_odd_swap ? REG_LVDS_LANE_EVEN_ODD_SWAP : 0) | @@ -580,6 +581,13 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model) { struct drm_bridge *panel_bridge; struct device *dev = ctx->dev; + struct device_node *endpoint; + + ctx->lvds_vcom = 0x05; + + endpoint = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); + of_property_read_u32(endpoint, "ti,lvds-vcom", &ctx->lvds_vcom); + of_node_put(endpoint); ctx->lvds_dual_link = false; ctx->lvds_dual_link_even_odd_swap = false; From patchwork Wed Nov 27 10:30:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Picej X-Patchwork-Id: 13887405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F326D6D248 for ; Wed, 27 Nov 2024 22:47:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1E9A10EBF8; Wed, 27 Nov 2024 22:47:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=norik.com header.i=@norik.com header.b="ApVr8M+K"; dkim-atps=neutral Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 39C4510E227 for ; Wed, 27 Nov 2024 11:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rpRTZD3rQ6fcXSI3x3w5V3GlJGBpXq/aq88YWpZoftc=; b=ApVr8M+KE8vU+gn1q1aC7Yityx sc2dSDSVljqDpPiLxEuKKjC56nYdwV+6qQEr77t98vVZDzEMonvqIViilqBtQ7SPHE+R5qA/4aGn1 FCz2gvHkJPXDbhhz3O1mjgBZVKTByGb/Lsyk5vheI/OZlMFxMP2slbvwgAG2icK7io4ZmQJKVjCt2 9jpkHkEhbYTkueW9W0aZLCuZQFbXaHtm1EJds5gVT+66khGh8PLc/BHaG79e0LcCuVwQy3wFzMM+s raW1Kme0Yw+IKP3nCRg5VMcmOxsncUJH3kg2J41NtT0VZKFztl3VqZMP9e1OW2794Y/opJTmNk+cT OuW3tWDw==; Received: from [89.212.21.243] (port=49750 helo=and-HP-Z4..) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tGFK9-007Rx6-0K; Wed, 27 Nov 2024 11:31:08 +0100 From: Andrej Picej To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] arm64: dts: imx8mm-phyboard-polis-peb-av-10: Set custom lvds_vcom Date: Wed, 27 Nov 2024 11:30:31 +0100 Message-Id: <20241127103031.1007893-4-andrej.picej@norik.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241127103031.1007893-1-andrej.picej@norik.com> References: <20241127103031.1007893-1-andrej.picej@norik.com> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.freedesktop.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-Mailman-Approved-At: Wed, 27 Nov 2024 22:47:27 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Set custom differential output voltage for LVDS, to fulfill requirements of the connected display. LVDS diferential voltage for data-lanes and clock output has to be between 200 mV and 600 mV. Driver sets 200 Ohm near-end termination by default and since LVDS_VCOM_CHA_LVDS_VOD_SWING (0x19) [3:2] sets both data-lane and clock output voltage we have to set the register to the value of 0x0C (0b11 << 2): - Steady-state differential output voltage for LVDS data-lanes: min: 300 mV, typ: 402 mV, max: 511 mV - Steady-state differential output voltage for LVDS clock lane: min: 234 mV, typ: 314 mV, max: 399 mV Signed-off-by: Andrej Picej --- .../boot/dts/freescale/imx8mm-phyboard-polis-peb-av-10.dtso | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-peb-av-10.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-peb-av-10.dtso index a9de42cf14be..709b555ca753 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-peb-av-10.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-peb-av-10.dtso @@ -179,6 +179,7 @@ port@0 { bridge_in: endpoint { remote-endpoint = <&dsi_out>; data-lanes = <1 2 3 4>; + ti,lvds-vcom = <0x0C>; }; };