From patchwork Fri Aug 17 13:00:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 10568729 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C64A9139B for ; Fri, 17 Aug 2018 13:01:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5D5C2B707 for ; Fri, 17 Aug 2018 13:01:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B411F2B758; Fri, 17 Aug 2018 13:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94BC32B841 for ; Fri, 17 Aug 2018 13:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbeHQQEW (ORCPT ); Fri, 17 Aug 2018 12:04:22 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:40117 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726649AbeHQQEW (ORCPT ); Fri, 17 Aug 2018 12:04:22 -0400 Received: by mail-pl0-f65.google.com with SMTP id s17-v6so3703762plp.7; Fri, 17 Aug 2018 06:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=VNCkgJ9itB8TQC6SbBaxgHvFVYuf+um7lOzVMExziKM=; b=Lfb7DIgR3E1Lp1wolMAQZAJBlX2dO3ciWUEnl1yt6yenZPnlu9MWpXXBRD02+jqhja s/1unrumVzSo1qTAOKQDlv33ncRyNvNKPwtIX6fgmlREvE6JM5ZALv3i4pRFlTg7bGbj 6Wtql/Ad/Sm04p9eWQItTkGxgQwmlNuBq32Qd7cA1f7e30x2Xiv91Bn2AeY2578UPzkE qaCUAa2/34w2ZiuX6wl//ozOTsZaVXFmS6/9lb6WIKZRmqqscIu/3Mb3fQbgbk8cC2yi KCnPCR/4U1ErEcR+aA8jYPjpEJX6lMTF8+d753brZlpY71xSQL9XPIeV/5rlQdHlKijH e7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VNCkgJ9itB8TQC6SbBaxgHvFVYuf+um7lOzVMExziKM=; b=nIJ7djiIHlA133aYyzGgPuU/iM2i9GZa+dWTab8fEW1wSM5pki1GCT5R4jMyHIH85q q6ajhGhZMfS6TPc2PNNrNHajtadO0+G/baGmlvIsRWcVi8j3DvhqG+5qM6qzXKpVEhQ0 Kq5IJ7aTtgcFPVzNxG6MF5mGZEPNTiOi5vy7Cf+BX3lOaZXmuq9Rf2w9N9uUDIUC1r4m s65zi3N1JOGUoMLVfb075gbEbWYuR9GOpdt52Lg7M6VVMuX0/alY3IiwFPErkWPRczrh VDkqK+xIMbf2hXOcg+ZFNwjk2aDIjrTK5PGJSMdlPu77gaxALjewW6txQhnXwMrxx6eM QQBg== X-Gm-Message-State: AOUpUlHL3XhMjKgHtvgH10kucKqBwckrgHWbf7a+7BxX8iaE+ya0ybTP 7Ev8CFE8/jlkpm1LevFzjWI= X-Google-Smtp-Source: AA+uWPyBcjybpU3eEeKhLvTV77TWiUiEfWAltWVMhp8BXtz/Rdc+k89+hZT1/h+6RwdcOULgRR5LZQ== X-Received: by 2002:a17:902:44a4:: with SMTP id l33-v6mr33487121pld.134.1534510862087; Fri, 17 Aug 2018 06:01:02 -0700 (PDT) Received: from localhost.localdomain ([47.88.150.209]) by smtp.gmail.com with ESMTPSA id g5-v6sm2398301pfh.63.2018.08.17.06.00.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Aug 2018 06:01:00 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: leoyang.li@nxp.com, zw@zh-kernel.org, dan.j.williams@intel.com, vkoul@kernel.org, linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Barry Song <21cnbao@gmail.com> Subject: [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet Date: Fri, 17 Aug 2018 06:00:26 -0700 Message-Id: <1534510826-7603-1-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP as you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: Barry Song <21cnbao@gmail.com> --- drivers/dma/fsldma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 1117b51..9d360a3 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -987,7 +987,7 @@ static void dma_do_tasklet(unsigned long data) chan_dbg(chan, "tasklet entry\n"); - spin_lock_bh(&chan->desc_lock); + spin_lock(&chan->desc_lock); /* the hardware is now idle and ready for more */ chan->idle = true; @@ -995,7 +995,7 @@ static void dma_do_tasklet(unsigned long data) /* Run all cleanup for descriptors which have been completed */ fsldma_cleanup_descriptors(chan); - spin_unlock_bh(&chan->desc_lock); + spin_unlock(&chan->desc_lock); chan_dbg(chan, "tasklet exit\n"); } From patchwork Fri Aug 17 13:02:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 10568731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5FE9515E2 for ; Fri, 17 Aug 2018 13:02:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50AA82B5DE for ; Fri, 17 Aug 2018 13:02:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 453782B5FF; Fri, 17 Aug 2018 13:02:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E36312B5DE for ; Fri, 17 Aug 2018 13:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbeHQQF6 (ORCPT ); Fri, 17 Aug 2018 12:05:58 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43540 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726376AbeHQQF6 (ORCPT ); Fri, 17 Aug 2018 12:05:58 -0400 Received: by mail-pg1-f196.google.com with SMTP id v66-v6so2242401pgb.10; Fri, 17 Aug 2018 06:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tnV+BGPIPlSKgGQZ5260CLaewCxmsyLkhl/SNKkqrJU=; b=DTRbJOUBf2dfjtWWKq3FmPHZnfB4Vdc8hqlxuzkMpjIU8kMXIiaH6RmSfOaoSbS7TM Wr3Cdj81ehPcOsz1TBKZKzEvkrvoLcwW+Zf69um8qnE7GKgRNOPgBiXfkhYf8nwqEvh3 ZQYsJIW57sisqiqHq5zWqveOS/7SbTzHMb4JN/Riv+J/p0vOXO+9K8VQo7f3kvbUZbqf 9l0+8ZZ+7COh5qMxPCEplPegCwR34aat9cmtIwmoTWxC25sYgPVW3yyYuiXfoRqJafx+ FVu16fh5rK6BeUiTjAkv1p/KcAEr9rkp9UsmwglFtSCW68cYjnJch/FA06D7BYguynxu ZTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tnV+BGPIPlSKgGQZ5260CLaewCxmsyLkhl/SNKkqrJU=; b=WOk+dSv7KGS4i/Cl/ROXqTwHznBaPwXA+XCgXVtyERcqJuEMkYLvZO9HvaIVbZ2pW5 /puWMF365LoJl7TqEVg35hLWSFpAKfbxEDwqzD+SY+Ja+9b5/CsXRGr2H9xz1x/7Q6hN 3UymV5W4igcwSKnDFIQq5mlJwaH+EQSvxOmeA8TdOAjWKY1E+HWrG76j5OtrByW2JTQY mkYKB6vMC297eTQ89cpGT3RPGWhCCkjnmQq9L7UGCfrl3rNKIl4r6b52GImULmdOlq0m NPMpmgBudPevy58jhOZsGx0SAaNAPVHtW5r/CHzB4ZwRn7IE+Wt88p5A2Bc17nWWE8PY MB3Q== X-Gm-Message-State: AOUpUlEN/ms1N9rjvbqUxlZY8ZAS/P8IHFh4i4KG9ptmHKGKlgdHQpBK qvbmgpszBLaOndrPLvKRU2Q= X-Google-Smtp-Source: AA+uWPzNaHqwdxya8hLMuomJQivERgsqcMNeW7UtxHh2eR86vZUp109Kh7HZGm9W9yRCHnm2nLPATA== X-Received: by 2002:a63:dd49:: with SMTP id g9-v6mr32560723pgj.356.1534510957936; Fri, 17 Aug 2018 06:02:37 -0700 (PDT) Received: from localhost.localdomain ([47.88.150.209]) by smtp.gmail.com with ESMTPSA id w13-v6sm2138223pgs.89.2018.08.17.06.02.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Aug 2018 06:02:36 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: dan.j.williams@intel.com, vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Barry Song <21cnbao@gmail.com> Subject: [PATCH 2/3] dmaengine: mv_xor: move spin_lock_bh to spin_lock in tasklet Date: Fri, 17 Aug 2018 06:02:02 -0700 Message-Id: <1534510922-7735-1-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP as you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: Barry Song <21cnbao@gmail.com> --- drivers/dma/mv_xor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 969534c..7f59535 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -348,9 +348,9 @@ static void mv_xor_tasklet(unsigned long data) { struct mv_xor_chan *chan = (struct mv_xor_chan *) data; - spin_lock_bh(&chan->lock); + spin_lock(&chan->lock); mv_chan_slot_cleanup(chan); - spin_unlock_bh(&chan->lock); + spin_unlock(&chan->lock); } static struct mv_xor_desc_slot * From patchwork Fri Aug 17 13:03:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 10568733 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A6DCF14BD for ; Fri, 17 Aug 2018 13:04:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9729D2B5FF for ; Fri, 17 Aug 2018 13:04:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A8B72B636; Fri, 17 Aug 2018 13:04:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43BF92B5FF for ; Fri, 17 Aug 2018 13:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbeHQQHj (ORCPT ); Fri, 17 Aug 2018 12:07:39 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45933 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeHQQHj (ORCPT ); Fri, 17 Aug 2018 12:07:39 -0400 Received: by mail-pg1-f195.google.com with SMTP id f1-v6so3565832pgq.12; Fri, 17 Aug 2018 06:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yWkr/muWaoqI7jxiu1oc1AyXYkxFpaFuIWx2owlEthM=; b=RT8kncuNF4hnabEwDpgnuH6/UIzRRFJQpMo4ru3bwmRCAfejPSd6WsxHYfVRCPKZd4 BmU8UjxWOS3uHiYPH3ucGTELQZwb2EylgBVleswbBHRKc9p0Qm8ga9IHaSuYP8Ml8PeA CaQGZG8q+l3gY0xhFPcuv+oqXrguFmfbdysnHADj53Bur/wc1C6hR297qmW8j7Mwrwru 4fJlDIr2eYempXGaDOZswWtsk7lpayouEZbJQaWzr3CYH81ROqlvYVYIVO4m4sc37NG4 75HDnrWYMumT4HIVBp1gekusM6vLEimG+2Fxo3Wdu99TNQd6nIIx+5Sd9lsjNbyTY0+K wo4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yWkr/muWaoqI7jxiu1oc1AyXYkxFpaFuIWx2owlEthM=; b=qReBnZ6X+ygxTSLPA13Pu7tnzxIDN+u9M3fh7KmwWOAFsl70JtC8OOcoQ8o9F2obQZ hcmBYUMr71LaQWr2nffzK0iOyY1+AJwEEwd6iDj9PCvr3B7qYUZ09/u2Kay2I6BQqlxJ GgfXLz3JYuN5epD+Wnfaq6+WP1G9uBkbdnktP04OI2zCYnGXlPyXYRkQqAf/r8bBGw7V HAA6Tb4IZA/Yr7VwgwihkO27d3oa5jCmOkjXZWDQ/BoOc2P1JcX0z35MrLGbgoCcEENH CqPxLkXXP9ZEgNVWRgfk9TW2glwsaMA9uBE4rVS6n6Ob4ChW+YP3gukRu9Dw38gCCy/I TkVA== X-Gm-Message-State: AOUpUlFkmIPtEsh5SfeSJhB1FzZV/SV1T9S1c+9v+WMEvmJRE+0oQfIq f1Qcv6+bbIWGphhujBRwODI= X-Google-Smtp-Source: AA+uWPy2Um6mLrPVvLYaJhXvjSSqhKUPf59kdjqn38Yz2XtQRtyvzKXxxTTfJoSe6fYQkSenS7aeXw== X-Received: by 2002:a62:21cc:: with SMTP id o73-v6mr36835751pfj.21.1534511058901; Fri, 17 Aug 2018 06:04:18 -0700 (PDT) Received: from localhost.localdomain ([47.88.150.209]) by smtp.gmail.com with ESMTPSA id b1-v6sm4288053pgi.91.2018.08.17.06.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Aug 2018 06:04:17 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: ludovic.desroches@microchip.com, vkoul@kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Barry Song <21cnbao@gmail.com> Subject: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet Date: Fri, 17 Aug 2018 06:03:43 -0700 Message-Id: <1534511023-7871-1-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP as you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: Barry Song <21cnbao@gmail.com> Acked-by: Ludovic Desroches --- drivers/dma/at_xdmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4bf7256..4e55768 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data) if (atchan->status & AT_XDMAC_CIS_ROIS) dev_err(chan2dev(&atchan->chan), "request overflow error!!!"); - spin_lock_bh(&atchan->lock); + spin_lock(&atchan->lock); desc = list_first_entry(&atchan->xfers_list, struct at_xdmac_desc, xfer_node); @@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data) txd = &desc->tx_dma_desc; at_xdmac_remove_xfer(atchan, desc); - spin_unlock_bh(&atchan->lock); + spin_unlock(&atchan->lock); if (!at_xdmac_chan_is_cyclic(atchan)) { dma_cookie_complete(txd);