From patchwork Tue Dec 3 22:16:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 13893037 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842221D79A0; Tue, 3 Dec 2024 22:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733264210; cv=none; b=aBBIkOhhgmgHUp53fu45MOBF2BLD6U7zfXVGUv1ZZbLxEFxz1K4D3vkiOnLqBw2cKVWxIECLyzYlvJDSw2Zv5VIUKuEMfGCmeyzaDTVVoqqxZdxpfkFizzpUbG6YeGJ6KBYAUS4wowAXTHnuMcsg6H7fFI8fD/zWbeav9UMyZus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733264210; c=relaxed/simple; bh=WetT4KCWoqobKHA1jyiEvTHpEHivM3duZhF3iopc4mQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lUj795u6wRAFAugGxsM9U0wMI/Q7VYzgC7mIsb+2dBZ6tC+YtVb9jigA/qlq/ss5Uv8OrfnAFcYxC8tD64UOfrC8T2vXYJGiY3RLNH1EN30wwe7Z/Vwyg7eJN3AF6QhGP5MLeie9azPPBBEypL8GQFxgjTzUYhitWz6jeAuZlz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAagXLXV; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAagXLXV" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-724f74d6457so6031545b3a.0; Tue, 03 Dec 2024 14:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733264208; x=1733869008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Xlv6opsF0xbu6Gw4XKogPA2B7SDuqsnkMJ1U4QmmKM=; b=iAagXLXVWc4KXnFffG6aozy/szUoJ3YJKAZ+wJ/9oH5R1MiA9xPdxo/DOpHJM5bp0G rv09MMRDPNM7XWvhAkrVMhKbusIHN1TchnyjMg5vxToXK7KMCIrvB6HCz5dgLodeJPUy TqhfwbC4/Y6LbhEmiWDtBeqvfdJPmGkw6JSgnTXoT1ei1YgwTW/po8h+z43Jc1u6MkW0 t83bMvb6t3vE1J1M4t6WRPCCFKhU4oeAHWww1E/CTG4bvzy1/iDwIhJo51HzVk0QuQFV yK1Bovu3kEpF3S0hjPdhxKCPen9VK8lgOIbk8g+akUpEuU2P/LloXcwwAhb6iQrsRSgB 8GPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733264208; x=1733869008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Xlv6opsF0xbu6Gw4XKogPA2B7SDuqsnkMJ1U4QmmKM=; b=nHYRWps7SHoo5GzkS2o9x5+kEE9ywCoE9/hpCFqnxHASYRyJ/+bwjvBDE1hoWQHFBB rBLFCAhfSElqgivuk0bjfvz4GuD0TwSYcEFD1rutDMg8PF1TpDDqP1JRYzvYD6EDltpb wLW7Z9HoKV4M1wDwRkaa9DqxAHfbEZfljB3JO0RI0XrRIbclqQUYqrdaOYiCcZBbo1EX TAIhlyaYHCwhqXSSr+x4v0bprS9fgnFhbzuXd0BEE5ZWpmAkW6resXsNaGIoaBtLnuTz yN7vexfNBlTQkvj0QgBouRfVAziOR2YHJH+8+GQ1H8Og1/uOzBFTKsy15jPnGqTDqbqD 9ilg== X-Forwarded-Encrypted: i=1; AJvYcCUSmLJMETYAWJv6uWqh4Vi3tbQLdxMQ1sgvFmyZxBbK+EtuUtwUcJZkmczTDAoHr3/5gunmf6ycYsql0mo=@vger.kernel.org X-Gm-Message-State: AOJu0YyUs9/NeK7VKEmTDnLRPqlbuJ4S9O1zemDxI56w2Vrirbiyc5vt 54jONlPFo8TEI5DMZ+KPn5uSlm4w30q56b3LZct2xybdX9YtCagi07upIE8B X-Gm-Gg: ASbGncsnL08diHiNMmpVLW8HIjd4hJxlhG0rqdj/k1tUuTxYdtwDowOmq6LcFNp5XhI /QouqdI/aa2PiKpSWiB/wTtSQH4+MufK5d7Wj4vyHELRIcKLbteRQiGfKanT2d8hInOWlYQTTBh 7H+CvVPsyx3AHecpHswaEbjxsHJes1AUktMTVCG8N0xub7/zCCaPenLzlSOg7dma1MO5DmWi4af dxqmfDikD3TdbCv2Beuf07V9Q== X-Google-Smtp-Source: AGHT+IHROhV5htb2QLt95N99yUx2PVs0JHDFrSRIHgnSYs0N+C/zFeBOT+RpRc3p5H7US/OaJlgLCQ== X-Received: by 2002:a17:903:1790:b0:215:853d:38 with SMTP id d9443c01a7336-215bd200b3emr55713325ad.25.1733264208593; Tue, 03 Dec 2024 14:16:48 -0800 (PST) Received: from ryzen.lan ([2601:644:8200:dab8::a86]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21521904caasm99779045ad.60.2024.12.03.14.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 14:16:48 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , ansuelsmth@gmail.com, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 1/2] net: mdio-ipq8064: use platform_get_resource Date: Tue, 3 Dec 2024 14:16:43 -0800 Message-ID: <20241203221644.136104-2-rosenp@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241203221644.136104-1-rosenp@gmail.com> References: <20241203221644.136104-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org There's no need to get the of_node explicitly. platform_get_resource already does this. Signed-off-by: Rosen Penev --- drivers/net/mdio/mdio-ipq8064.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mdio/mdio-ipq8064.c b/drivers/net/mdio/mdio-ipq8064.c index 6253a9ab8b69..e3d311ce3810 100644 --- a/drivers/net/mdio/mdio-ipq8064.c +++ b/drivers/net/mdio/mdio-ipq8064.c @@ -111,15 +111,16 @@ ipq8064_mdio_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct ipq8064_mdio *priv; - struct resource res; + struct resource *res; struct mii_bus *bus; void __iomem *base; int ret; - if (of_address_to_resource(np, 0, &res)) + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) return -ENOMEM; - base = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); + base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!base) return -ENOMEM; From patchwork Tue Dec 3 22:16:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 13893038 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2996420A5E7; Tue, 3 Dec 2024 22:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733264212; cv=none; b=ZNDJl49efNBLPw65EEjwjLZ2Tm3BCfuRu82aHwdUask0QiZ9VsHBfIb/ECheO8ZqdoCar+TyAsYzZVyxl4IsE7s9FoeWktQRDnf9n2zXu+q+m97hEH9SjWKjTChvVeeCwNO0c24UaTCLzobOyVTxtjemKSA4FgyZfOTmmgjXMds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733264212; c=relaxed/simple; bh=ozRvIq+5MLZjFrIsB9dsL65UNaZZtxTlG8giMAmKx58=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DVzF0JWlNsm16HdD3Z+q4GX2gVOSn2FxQ6LkVappWyBo4KurQ2xouy+eW0tKAwDfqPljeoHdGMNxS9/CDcuq9OQvTB5yCBOMAZn+WdksgEaAMeDJI0BIbsvf6uvdDnAKKGBazx1vPpGHskVelpzm90yj3uZJM5YVzMNhcUJMsOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S02K4VsF; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S02K4VsF" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2155312884fso44723175ad.0; Tue, 03 Dec 2024 14:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733264210; x=1733869010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iook0iJ9F0LvdQG0CTeBdy7oSyhdF855HqAsvOcFkV4=; b=S02K4VsFAcP05962F005ZDSpj2CwYGlzAivJvjH/BipmH3g5b0Wr8VEX6cp7Swcg0x 2/XBgZH3efol1nJF1iFBNyhpM9EuijaVp/B5vWtKek6+zUQiCx07ublo89M/VraKScUa clWk95gUQktcx+J4Q+jtjzQtgIIabjRXbrHkQNjUOb4Qluphu6bH+XP0hY0d+hyd4/cW FD58YcxNp4eafIpfJMyS95GfU8xJaXv7qhrqZ/G/Os3WllgcDxvkhLF29yPhW3aEwWEM ros7HONUvVSOGJZMrZj3o+mywTPgivhy9oShRhWe6OgaCJZLAFjrp1E+8BdY7nLhcL9X Kurw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733264210; x=1733869010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iook0iJ9F0LvdQG0CTeBdy7oSyhdF855HqAsvOcFkV4=; b=W3NHc+kr11Iuu5sDqdL0r48JyRSsTF2pRAB7Nu86BZk/KWJhhqy7fweJceqEHauWtH CAq7Q3IWqLGF94k62eIYy919z1+V3dqIslMlMv32c/i2naAqf18BmFjUe9PWMS3Lk1ge qf2L7ilK0X7panUJgRtCVBwLt2Dhyy50Ej9+j0xEQjLXXFg9PRtJThB8MiRt3eD+/yXf RRN69f6mk+kBj8jJr7tizPCTs+l/Yiz5o544mI0poGUDOn9/FOIsKR70cIa+cDuJ/Ltp UcIzL7LyJgTYlnidHim+U67LcQceFWsgk/NZF0CzDW6VrtyogSyGULlnxCpDKFS9UFpM f4Aw== X-Forwarded-Encrypted: i=1; AJvYcCU6QptN76iPyU8FRzTWqUeaAuwkGwqWTxaZvEYHnrtDBZrzWATQyvDsWJOQwQAhbkx6YggYnb72EECrfRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxlhwXMzDIZc0d6pL/fmsLWjOglA+YIa+omIqInxj2aIuF0x+F/ LFTUDRMogeFwflj0KY/kgL4HCdVMXFMjRoQZvCCR0czgMQuOnmiYxuU2m/qJ X-Gm-Gg: ASbGncuGxALw+Dddago9ebg8KyrSYyb4pnOZ013xmwx+dvSewIaOa8ioj45DOTeU9WJ Lm6MezJtdOST3V6nFKk5dfUsOxusTbddZVUdQozaCj+cQcOhebDdUlL8KF0W0QupW91mtiBkynH OozU05wPeXPLmucXJb5ajhN1DgJSSUQHJbcBiy6AQn2OXco6ogJy4BRo8fM00fQvpHyrcQjdSx5 Frfyk9pFOTab2LST8OrN4wL5g== X-Google-Smtp-Source: AGHT+IFd7GY0XIIVva9Ld8S7Wr/DyeFJs64AJ22tF1yAfTjDvoEVMKtixlKdmf+HJ1dIP4Hdt0p1rA== X-Received: by 2002:a17:902:ce08:b0:212:e29:3b2f with SMTP id d9443c01a7336-215bd250316mr49565195ad.44.1733264210034; Tue, 03 Dec 2024 14:16:50 -0800 (PST) Received: from ryzen.lan ([2601:644:8200:dab8::a86]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21521904caasm99779045ad.60.2024.12.03.14.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 14:16:49 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , ansuelsmth@gmail.com, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 2/2] net: mdio-ipq8064: remove _remove function Date: Tue, 3 Dec 2024 14:16:44 -0800 Message-ID: <20241203221644.136104-3-rosenp@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241203221644.136104-1-rosenp@gmail.com> References: <20241203221644.136104-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Change of_mdiobus_register to devm_mdiobus_register as devm allows removing the _remove function as well as slightly cleaning up the probe function. Regular mdiobus_register is fine here as the platform device's of_node is used. Removes two variables from _probe. Signed-off-by: Rosen Penev --- drivers/net/mdio/mdio-ipq8064.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/net/mdio/mdio-ipq8064.c b/drivers/net/mdio/mdio-ipq8064.c index e3d311ce3810..9f13e16edb17 100644 --- a/drivers/net/mdio/mdio-ipq8064.c +++ b/drivers/net/mdio/mdio-ipq8064.c @@ -109,12 +109,10 @@ static const struct regmap_config ipq8064_mdio_regmap_config = { static int ipq8064_mdio_probe(struct platform_device *pdev) { - struct device_node *np = pdev->dev.of_node; struct ipq8064_mdio *priv; struct resource *res; struct mii_bus *bus; void __iomem *base; - int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) @@ -140,19 +138,7 @@ ipq8064_mdio_probe(struct platform_device *pdev) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - ret = of_mdiobus_register(bus, np); - if (ret) - return ret; - - platform_set_drvdata(pdev, bus); - return 0; -} - -static void ipq8064_mdio_remove(struct platform_device *pdev) -{ - struct mii_bus *bus = platform_get_drvdata(pdev); - - mdiobus_unregister(bus); + return devm_mdiobus_register(&pdev->dev, bus); } static const struct of_device_id ipq8064_mdio_dt_ids[] = { @@ -163,7 +149,6 @@ MODULE_DEVICE_TABLE(of, ipq8064_mdio_dt_ids); static struct platform_driver ipq8064_mdio_driver = { .probe = ipq8064_mdio_probe, - .remove = ipq8064_mdio_remove, .driver = { .name = "ipq8064-mdio", .of_match_table = ipq8064_mdio_dt_ids,