From patchwork Mon Dec 9 12:01:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 13899427 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16533221DA9 for ; Mon, 9 Dec 2024 12:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745673; cv=none; b=icKWvQcZk53vBrWoB8dAHGdh8nifjUtAr/UGuyiRhb1xOs1sOs+aAT7Y+z0GER0vPBz5rTemwDWuWDFo1i8RuO3sz+YA5J/NmfCzSjXrjNEWUQSKH2XkEguKJbjuDd2zUMkiRgpMSoPPkxTf2GPnot6y6E9ldkFjCgJgx4Nyye8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745673; c=relaxed/simple; bh=EayO3poauy5/rht+2wdYMwLDBTRR4tdjIRay8qW3Xeo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rQQvDuyj2gmgAONXKi+dcDj/kcj63mBrtRrSgWXjbmPSqqTx8GXg+0C63tRp9UzW5gA0ye/lpZ6bhwcfGAB/ox0B3++4S5L5vQ3IaP03pxdssUpD7j1PfoWn9QiWPBYe8awtQpY2ATDsg5kBuH1fren2TIUGNJr7zXU9Dv+NGLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=HAsTprHA; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="HAsTprHA" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aa69107179cso111839066b.0 for ; Mon, 09 Dec 2024 04:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1733745669; x=1734350469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cJN+RDGJvasm5eLSW6rewyUE2UnqBa7DZC8SLRN3C/Y=; b=HAsTprHANCgQ+t3XVQLmEIFv9nDGiALvmFL0chTgKcWI+RRMsHBd87QM6Im4Kqmift 04JmHuNbhIGlekInf8WTVifv+0UIEd4/seYle0hhYFD8BgTuU6+vwf6fAFEasOwE15qu eyIt4U7OI/DCffAgYdEzlTTA9lw9Y7TCMVEx1uESynmdTNASKfXx9unmiMqZj4x9VAdP 6+R1F5a2SHu7HWvHD/ml9+YxFgHMDnJobDlT80EQl4NMhlGaYW+SIER0NA2Fb+DsUYRM AyEagYDDE7Jf8vu5o1s8ejOH2Maw0IJ/ZY/KkUIVmOEbcER4Ef+/zQVVbkF5hLovcz1A 4x9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733745669; x=1734350469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cJN+RDGJvasm5eLSW6rewyUE2UnqBa7DZC8SLRN3C/Y=; b=JNhQ81MdQaP7OrhEpPsBE2EcD1tBZIE7HVJ/asWg4ecbX/bVYtwJoWjrFsOFe0Y+Jy mCdqrNxt3mQ0+ZCmSdV/sXkBB76uzyWsapzeAgH6Xf7cC7aTYeZVRttL5byZRFEIstny ismwlDEMBZChinaHhBO5MdbngrFmfL2FRgaOuQed+mFLrgPj0U8WXkl5EkGzarM6HQDE zG/hhz/RAPW9xLFx3LWaNY7t/QJxoqwEQS7CTDvSzTMuR1frTImGUpu4j1sqNGR3vqVi rUVutZhxfNLNAizbn2m+3faM+cXeOjN6xlMpIK5ZE6iMmZAmA9zIQoSUOY6NWsHZB9ME nOEw== X-Forwarded-Encrypted: i=1; AJvYcCVSFgqTx8CrOucWHhRA1x0YXK3uU+C/8/02UAJHvjhqyvwXlNRiSt0ifl6SHX+/Ad8/n6ydRiZUAnKD9Q==@vger.kernel.org X-Gm-Message-State: AOJu0Yxky+9c9j1dQ85U+omgb6qYk8a1qRSPIvhqYi0pQaVDvAZN3YmH tPcPmknK+fSuRdpes+MEYK7cR9cWKoDL9OXQSDSNXD8PYdunfXEgU+Ae9PbOZ4k= X-Gm-Gg: ASbGncszVtRrobUuD4vFvtEiqopLI5C5Xq/O30qDutgVQjitxVAWH/UP3jAQu7/PKLm I9kcPJ7sVU6xas0ndJt207QSFm2t7jy7+YLhOOR8QkXpNx4oeg2IDN4GQ+s81p7nvf/swl8Mp1J JZ4F7/oPq0D7g2yplhETdQqZmYh3bm3TDyyqZlSWFHejAVYBarjWn7uqMssgwHErLryiwbMxNBn AgkwQlyDnx8iaaBOLumB9rw8Zl4JLzLnTMs8M4+PYUDIJlgGdAxdq5hEGOv7V7dlyWrn2Z4nD1p DSLYP0jfem6FK8Ep3d/r37zQWGpKNHMY63aJoS6lylEVKFbsvqPoNoosWGZ1kQwxFg== X-Google-Smtp-Source: AGHT+IF+p9gVWhFaOEldkR3XDKLXXb1rK4KX30ftSf7RjwBOAfR7BnsNTeQR8MNatD02QvNHIJdwOw== X-Received: by 2002:a17:907:770c:b0:aa6:8160:8495 with SMTP id a640c23a62f3a-aa69ce00080mr4712666b.42.1733745669239; Mon, 09 Dec 2024 04:01:09 -0800 (PST) Received: from [100.64.0.4] (2a02-8388-6584-6400-d322-7350-96d2-429d.cable.dynamic.v6.surfer.at. [2a02:8388:6584:6400:d322:7350:96d2:429d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa69afa395csm22555066b.71.2024.12.09.04.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 04:01:08 -0800 (PST) From: Luca Weiss Date: Mon, 09 Dec 2024 13:01:05 +0100 Subject: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241209-camss-dphy-v1-1-5f1b6f25ed92@fairphone.com> References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> In-Reply-To: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not any others so restrict the bus-type property describing this to the supported values. The only exception here is MSM8916 which only supports D-PHY. C-PHY was introduced with newer SoCs. Do note, that currently the Linux driver only supports D-PHY. Signed-off-by: Luca Weiss Reviewed-by: Bryan O'Donoghue Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/qcom,msm8916-camss.yaml | 8 ++++++ .../bindings/media/qcom,msm8953-camss.yaml | 15 +++++++++++ .../bindings/media/qcom,msm8996-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sc8280xp-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sdm660-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sdm845-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sm8250-camss.yaml | 30 ++++++++++++++++++++++ 7 files changed, 133 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml index 9cc0a968a401836814560c1af3ee84d946500b4f..3de2a3d2b5b761106975aab65ff614b2ef579ef5 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml @@ -94,6 +94,10 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -113,6 +117,10 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml index 8856fba385b1123d748199b46c5009c97700ad9b..6d776b0ca71140c0816b246dbaf41ef376205bba 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml @@ -112,6 +112,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -131,6 +136,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -150,6 +160,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml index 5cb0e337ea6e4274dbb75b7b25a9b4ac44069cfd..cae4c4f19574be30e8a9f8ca08f26d67be1e455c 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml @@ -116,6 +116,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -135,6 +140,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -154,6 +164,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -173,6 +188,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml index c0bc31709873c20b63c011148394f10b45c1655e..f9e3f514c61bf6fd48e15904b62b59c390e63b20 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml @@ -143,6 +143,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -166,6 +171,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -189,6 +199,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -212,6 +227,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml index 584106e275f67aca814de5dd70563d395305399c..a3e2ee7f643d2a8c1490b4d02e16e509cf85f85f 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml @@ -122,6 +122,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -141,6 +146,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -160,6 +170,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -179,6 +194,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml index ec4380a0a03f7dce2539085e24d9d9ec7205e825..98cd0df4570ed168fc1495619c408c4fbaac66fa 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml @@ -109,6 +109,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -128,6 +133,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -147,6 +157,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes @@ -166,6 +181,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml index fa5073c0fd1efaa94f171e4ec26b918d8a5261d6..c95533ac92002c70efe7ef56ab2712565a5a7297 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml @@ -129,6 +129,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -152,6 +157,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -175,6 +185,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -198,6 +213,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -221,6 +241,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -244,6 +269,11 @@ properties: minItems: 1 maxItems: 4 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes From patchwork Mon Dec 9 12:01:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 13899429 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17D1A221DBB for ; Mon, 9 Dec 2024 12:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745674; cv=none; b=GomCI9/ZP5nDKjZN6J58KGgS/MsOkoN+6gLejHk86OS5fL9hrOJ72njUm1OQVLGXoTNK1iO5pvVUWXZwqH2hJNwSDUoqKnIh26lywizvINm7dJqdrFdK+lMpktKmFNQPhROUzJrL8/+9IF4AK629KFXvBPZS+hAe/0kq+SXqI9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745674; c=relaxed/simple; bh=8pFX+27nmjk/7KfdfuKsPNR83Jiahya68QV//JkHJU8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fi49lMOkOKsBZzMhFONlNJHmY0xEPghGVR9aUdjV67TCqscIbCdL6VM+M3QzSrKy9RcDZuRRdhEYIH5KVdfmxDACBUrlGeLw3mt7idL5r9v9dSRR/83yeCgrDFLSpfmbCC7ZSoPhFvqoTOQJ0ly/VNRmwnzvSMITeIKOzdcUZ9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=BndbPVXi; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="BndbPVXi" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a9f1c590ecdso758538866b.1 for ; Mon, 09 Dec 2024 04:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1733745670; x=1734350470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0tR6QupvutEPi+0B6/genbHIfRkFvdzSANWIhNibRjA=; b=BndbPVXiWkZ2Hymlx4djmvk3gopkES+g2ciCMtH9KuwLm8K+AKenJwUnTmlB/GOHGS wMonUq50IRzSn65wKpPNKm98Aq/INhm9tZQp9EMohv2B/OYFNPS6tpm/m0rGXSMckI3l 6QvvheUI4ft+hvwcntSi7r/aOghQMpsNiQdcUwGVNSbM1YM8a5SErFyLN5cNCcntNJmb U8OM2ROcxY1oFdHvdXVxMBNbeoAgV0vi0B3gkYrrqhxxa3PzJOps2TF0xE25omtiNzRY R4XD658MZRpjGFdtaRVlxnfoNX2ApzbIHHKesmRu7Xg//cK7epW8/LhBUnjftgwoMW5C xRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733745670; x=1734350470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0tR6QupvutEPi+0B6/genbHIfRkFvdzSANWIhNibRjA=; b=T4jiAoSxaolvxNMavRdnyrMNycNHQa4i9NQn4rykWdYWuFlkqDBcVwn5feZNA3/zX1 WRCSr9S1MlaBmLI3T7Cu7/gR0x/uKgGKx8z+sF3SwnIdyCHMj3Qgr5VfE/DPJ7OWGZBa vZKfFf5nTfFJpuE4p2DrFCRSRqY1DDly0qMpi4ISPJlODGsq/nKPllXEH56phwCdQmzP y4pzveat6ClSzNJo2fc/dteDNSBYwCxpIvzcIbY8iKdx7KYXhm/G2vsA3WNIPyx9QMXf HFRYTTSeSsHE6AW3vvbdNBEB+4iqdWPWnXhJcRuI23KgRyrzpsyJvQJoVCCOyKXinvjz qNEg== X-Forwarded-Encrypted: i=1; AJvYcCUyX4g3LmgWq1roFFtHDVci9lJiBbXjivCjd00uFApsI1i0O4KWfU4Y1I3ZEK88m7q2gtLZLmLX9lalNA==@vger.kernel.org X-Gm-Message-State: AOJu0YxiLMNh+YVXPTrs+sNRod6MOZSy2cZPsPlpoeOq+2/6rqtVygzG wWyKXnDA/IXeJO+d826wEj3uPlDDgljamMgjI+Z/sfTMMnqOeW5/53MMxLyBoyM= X-Gm-Gg: ASbGncuYYiuerEVidkgseOLCmVxAdSO/XEE4+1mUWW9dDwd9Hg2rsV4VEOsBx5GWnCP EzCKkT3h/f91jyH+6iXO9vzRSMVzMHeieCuc23QBv5h1gfh1FJh9OfhwXoEiB8DygR/INvunUkm ijpE9ra6bkiqPih9yIxv9IXRcQlDlvy+IRv4IEdKTaWPAdh+rTBYt2cj+rbkHloTwQ1Ct1xKKOd zQu8avqQQ4VOO1X2fXfi7gzwEG3M3z7DmHs9lPYnk7TMdD4liN3pd8dbDEcLxr9GMvCmIBfRhsP X7Kxm8l3fD0kpu0InTqnu7n65kKJ0S1A58EdqYkm//RZl5uxcjPo2HMCaUHWBTETKg== X-Google-Smtp-Source: AGHT+IGCASHop4+PMr/ElwoRqpZmRPYooFBqBNoyvG1DRpnbL890d/4qkOvn0rbSSu4AIgl1YOMZNg== X-Received: by 2002:a17:907:aa6:b0:aa6:945c:453d with SMTP id a640c23a62f3a-aa69cda0d94mr5001966b.27.1733745670385; Mon, 09 Dec 2024 04:01:10 -0800 (PST) Received: from [100.64.0.4] (2a02-8388-6584-6400-d322-7350-96d2-429d.cable.dynamic.v6.surfer.at. [2a02:8388:6584:6400:d322:7350:96d2:429d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa69afa395csm22555066b.71.2024.12.09.04.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 04:01:10 -0800 (PST) From: Luca Weiss Date: Mon, 09 Dec 2024 13:01:06 +0100 Subject: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241209-camss-dphy-v1-2-5f1b6f25ed92@fairphone.com> References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> In-Reply-To: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-off-by: Luca Weiss Reviewed-by: Bryan O'Donoghue Tested-by: Vladimir Zapolskiy Reviewed-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 9fb31f4c18adee886cd0bcf84438a8f27635e07f..b99af35074cdf6fa794a0d2f0d54ecf12ac354d9 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1855,6 +1855,15 @@ static int camss_of_parse_endpoint_node(struct device *dev, if (ret) return ret; + /* + * Most SoCs support both D-PHY and C-PHY standards, but currently only + * D-PHY is supported in the driver. + */ + if (vep.bus_type != V4L2_MBUS_CSI2_DPHY) { + dev_err(dev, "Unsupported bus type %d\n", vep.bus_type); + return -EINVAL; + } + csd->interface.csiphy_id = vep.base.port; mipi_csi2 = &vep.bus.mipi_csi2;