From patchwork Tue Dec 10 04:15:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Ge X-Patchwork-Id: 13900850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C814E7717F for ; Tue, 10 Dec 2024 04:15:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5FD8D0008; Mon, 9 Dec 2024 23:15:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA57A8D0007; Mon, 9 Dec 2024 23:15:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CE38D0008; Mon, 9 Dec 2024 23:15:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A49AB8D0007 for ; Mon, 9 Dec 2024 23:15:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1D84F1402C9 for ; Tue, 10 Dec 2024 04:15:28 +0000 (UTC) X-FDA: 82877734422.21.CC71380 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 8836D1C0004 for ; Tue, 10 Dec 2024 04:15:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=F0mTF8kV; spf=pass (imf18.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=hao.ge@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733804110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=jvB6EzRbD16SkG58oiYpRiJHJAIgPKUq3a5VWnlP/Zw=; b=Dw1g4q4be8YiKSAMv+wu1JuWyHRzjUA43QIVDpBGTxJcpuhVeKJJD+okp/AtpPLLA+4SLJ njqbuwrnMjZVefQbT3YOEgzEd7LjXbzY4xXINAyIecucsfF1FkKmzs7sMsmjE82OAUxEWf X1m0WwD/MUdNgiZtCVXnlYZNBQ/wsi4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=F0mTF8kV; spf=pass (imf18.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=hao.ge@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733804110; a=rsa-sha256; cv=none; b=bW7zW7iCrJf8fvYUsL4+txqJZuGSFKW+ziwIYKhUHm2JUVugi9wiM+VEu6qLRELv4rb5KQ rsgVR7/sGlSnVtMLeThMJKdx0KldXuUvhgdSFDbRBgL3jFYZYv6lcwiY7rL9o2grJrGzRS E025EUhiJFGtgJWaBDaDq0EXJ5Mw4Ao= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733804124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jvB6EzRbD16SkG58oiYpRiJHJAIgPKUq3a5VWnlP/Zw=; b=F0mTF8kV0SH73PaVUbuhfhvdwQXCv/rb0RTtK54YqGRPilqq/P+TBGPBh7g4OIfrZWQYxn Qn1ZIKvHicftZy3Y4qKYy/FH0Be4JjKPTFJzlNJiIC2WCPV7Wvi2tsC/d+Kms0+HJawUfb JZdJO6NMVIUAQLEn35BJEOHqWT4rD/8= From: Hao Ge To: surenb@google.com, kent.overstreet@linux.dev, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hao.ge@linux.dev, Hao Ge , Ben Greear Subject: [PATCH] mm/alloc_tag: Add kasan_alloc_module_shadow when CONFIS_KASAN_VMALLOC disabled Date: Tue, 10 Dec 2024 12:15:15 +0800 Message-Id: <20241210041515.765569-1-hao.ge@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8836D1C0004 X-Rspamd-Server: rspam12 X-Stat-Signature: awnpr3ktwijt3at7gkuhqqaqbwipxa1u X-Rspam-User: X-HE-Tag: 1733804116-827667 X-HE-Meta: U2FsdGVkX19aJvbMcWk3eHKUmcUiWscsYFPnSAlYEYI+QIIch4uL2OySOGksiZO8aOswu4TrZN2yv7ib7dwuDZSnCkRrWBnHr84iS0rEdtQwCPP3v1ctgrIteu69IW8xwCP6iA1O9ZUkt8+jBGb3pZt4MoM6EZ295958reP/uCTAl/GUV2IocOl2OUyjGz5g5x9ZfAEbtid3cLSyAniam1icRrb8VTz+gMEKMGuIcS9mb5kTfymBTy+FxToi8CqJLFQRTOo0RPcH13XFsiNpPM4tcxeK5VX7/kVvqwJ65RvH4uuObyqgWFsQ5a0p6Ud+/14lueY7+P2ivcSPhxodHqENKmxirrGHseD/CODjjbkg5xQ15PtWGwpaQqZPWm4IF1++zF3CdMMZMYkb4wJhfRGQ8VgT0qvzo4qYINGYkNLVdTyL9J5Xty6vNMyu3OuqUSCajcN3hq0tvcHYBafXQKnp3QbifBnBte9AsaHhcvuw8iqPUAWwZou7xqY0ze+/gXjhBYmbuHn9gYdroM004ZAsz1vewgOqpyPWrCX8hHf4R50td7er6qn267rVPwQsKvMH8AkOhFswT4jTwm74EbJtvlA/2D8y2CCpHEI1Xdv2437sxhh6lssHQ8sYfdXVwDgNaiI1w2iltW5NN9kp8wZqYK7fnsHthSTwpTl5gnhjfxZkJC1TR93lIA2UQajzFH/BRZ40n8fECxgHXd3F6AKpMKHTuBGHAupo2cqNw7cWOY7F74LgYqJEhuzyXrPAeNX93V3gnTuHebH4so0A2po4Mni9JXBXpRIEY4bmTj/Py0K3eAa0dJCfE3l4k1jaD2MT1pBqxtonPOSHaI2IZw/02SzaMPPJPOEzqSPwf4z6voPhgKdkKkINvz6gIWz+iJUXZbEQUl1BkJR2UDzVkZdP0OTZ5vwDrYo9iQslF7/uysCqdEyDFk/w2MDsPMgEYNpx0r0DSEcP268OGCS 0LgLTecm 9NMXuDbtuZCe54CdOmfU5wb4Rz5WIrqU16+JWYJzq2qcMZKXb4YNi4uGoZ+l3t5Y36F6QRNDrjKawPw8kZdr1HhXeo30/2oPaQUGyeXSmbuv7bMAdnr8SW+lvuCXaNzPtCuecSSjh67OhUWIpLXQPkdz7Qci+zWoLq5Z5fp7LQyCIgC2FxBwMQNFhI7WlTsYAafuW7y3Ebr2ZMADspTTRKxlyQC+K7yB5v5hIFX2U32SY+xMpwff1lTPk2yU0HoxnIUesWRLMDWj22T5ZK0w/+GguxKFLqR5LN3kxo+mp8fVSrCgi7h83F6/YS+FaV5wk7nPuUnveXabqI40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge When CONFIG_KASAN is enabled but CONFIG_KASAN_VMALLOC is not enabled, we may encounter a panic during system boot. Because we haven't allocated pages and created mappings for the shadow memory corresponding to module_tags region, similar to how it is done for execmem_vmalloc. The difference is that our module_tags are allocated on demand, so similarly,we also need to allocate shadow memory regions on demand. However, we still need to adhere to the MODULE_ALIGN principle. Here is the log for panic: [ 18.349421] BUG: unable to handle page fault for address: fffffbfff8092000 [ 18.350016] #PF: supervisor read access in kernel mode [ 18.350459] #PF: error_code(0x0000) - not-present page [ 18.350904] PGD 20fe52067 P4D 219dc8067 PUD 219dc4067 PMD 102495067 PTE 0 [ 18.351484] Oops: Oops: 0000 [#1] PREEMPT SMP KASAN NOPTI [ 18.351961] CPU: 5 UID: 0 PID: 1 Comm: systemd Not tainted 6.13.0-rc1+ #3 [ 18.352533] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014 [ 18.353494] RIP: 0010:kasan_check_range+0xba/0x1b0 [ 18.353931] Code: 8d 5a 07 4c 0f 49 da 49 c1 fb 03 45 85 db 0f 84 dd 00 00 00 45 89 db 4a 8d 14 d8 eb 0d 48 83 c0 08 48 39 c2 0f 84 c1 00 00 00 <48> 83 38 00 74 ed 48 8d 50 08 eb 0d 48 83 c0 01 48 39 d0 0f 84 90 [ 18.355484] RSP: 0018:ff11000101877958 EFLAGS: 00010206 [ 18.355937] RAX: fffffbfff8092000 RBX: fffffbfff809201e RCX: ffffffff82a7ceac [ 18.356542] RDX: fffffbfff8092018 RSI: 00000000000000f0 RDI: ffffffffc0490000 [ 18.357153] RBP: fffffbfff8092000 R08: 0000000000000001 R09: fffffbfff809201d [ 18.357756] R10: ffffffffc04900ef R11: 0000000000000003 R12: ffffffffc0490000 [ 18.358365] R13: ff11000101877b48 R14: ffffffffc0490000 R15: 000000000000002c [ 18.358968] FS: 00007f9bd13c5940(0000) GS:ff110001eb480000(0000) knlGS:0000000000000000 [ 18.359648] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 18.360178] CR2: fffffbfff8092000 CR3: 0000000109214004 CR4: 0000000000771ef0 [ 18.360790] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 18.361404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 18.362020] PKRU: 55555554 [ 18.362261] Call Trace: [ 18.362481] [ 18.362671] ? __die+0x23/0x70 [ 18.362964] ? page_fault_oops+0xc2/0x160 [ 18.363318] ? exc_page_fault+0xad/0xc0 [ 18.363680] ? asm_exc_page_fault+0x26/0x30 [ 18.364056] ? move_module+0x3cc/0x8a0 [ 18.364398] ? kasan_check_range+0xba/0x1b0 [ 18.364755] __asan_memcpy+0x3c/0x60 [ 18.365074] move_module+0x3cc/0x8a0 [ 18.365386] layout_and_allocate.constprop.0+0x3d5/0x720 [ 18.365841] ? early_mod_check+0x3dc/0x510 [ 18.366195] load_module+0x72/0x1850 [ 18.366509] ? __pfx_kernel_read_file+0x10/0x10 [ 18.366918] ? vm_mmap_pgoff+0x21c/0x2d0 [ 18.367262] init_module_from_file+0xd1/0x130 [ 18.367638] ? __pfx_init_module_from_file+0x10/0x10 [ 18.368073] ? __pfx__raw_spin_lock+0x10/0x10 [ 18.368456] ? __pfx_cred_has_capability.isra.0+0x10/0x10 [ 18.368938] idempotent_init_module+0x22c/0x790 [ 18.369332] ? simple_getattr+0x6f/0x120 [ 18.369676] ? __pfx_idempotent_init_module+0x10/0x10 [ 18.370110] ? fdget+0x58/0x3a0 [ 18.370393] ? security_capable+0x64/0xf0 [ 18.370745] __x64_sys_finit_module+0xc2/0x140 [ 18.371136] do_syscall_64+0x7d/0x160 [ 18.371459] ? fdget_pos+0x1c8/0x4c0 [ 18.371784] ? ksys_read+0xfd/0x1d0 [ 18.372106] ? syscall_exit_to_user_mode+0x10/0x1f0 [ 18.372525] ? do_syscall_64+0x89/0x160 [ 18.372860] ? do_syscall_64+0x89/0x160 [ 18.373194] ? do_syscall_64+0x89/0x160 [ 18.373527] ? syscall_exit_to_user_mode+0x10/0x1f0 [ 18.373952] ? do_syscall_64+0x89/0x160 [ 18.374283] ? syscall_exit_to_user_mode+0x10/0x1f0 [ 18.374701] ? do_syscall_64+0x89/0x160 [ 18.375037] ? do_user_addr_fault+0x4a8/0xa40 [ 18.375416] ? clear_bhb_loop+0x25/0x80 [ 18.375748] ? clear_bhb_loop+0x25/0x80 [ 18.376119] ? clear_bhb_loop+0x25/0x80 [ 18.376450] entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: 233e89322cbe ("alloc_tag: fix module allocation tags populated area calculation") Reported-by: Ben Greear Closes: https://lore.kernel.org/all/1ba0cc57-e2ed-caa2-1241-aa5615bee01f@candelatech.com/ Signed-off-by: Hao Ge --- commit 233e89322cbe ("alloc_tag: fix module allocation tags populated area calculation") is currently in the mm-hotfixes-unstable branch, so this patch is developed based on the mm-hotfixes-unstable branch. --- lib/alloc_tag.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index f942408b53ef..88c1fc512ae0 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -422,6 +422,9 @@ static int vm_module_tags_populate(void) return -ENOMEM; } vm_module_tags->nr_pages += nr; + + if ((phys_end & (MODULE_ALIGN - 1)) == 0) + kasan_alloc_module_shadow((void *)phys_end, nr << PAGE_SHIFT, GFP_KERNEL); } /*