From patchwork Tue Dec 10 14:16:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13901484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EED3E77180 for ; Tue, 10 Dec 2024 14:16:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8370610E3BF; Tue, 10 Dec 2024 14:16:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jNlecyOw"; dkim-atps=neutral Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD3F510E3B0 for ; Tue, 10 Dec 2024 14:16:54 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso5700569a12.1 for ; Tue, 10 Dec 2024 06:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840213; x=1734445013; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YDx6hbMot9hPe7Zgw4rNyld1Z3a4kDtP9bTMjfYhMss=; b=jNlecyOwjF5RigDWInf11PF4eylyEYylrYxaEwlHV2+ua0X6VbOXDS+KlWc0+tTcyM OUS0vH5cnRuYbV2DJLSGfgkLFAYyLu5xXHg8tiI4ISAZA+mNpsoJdJL+o23xk3uMpxJn cahR3/BZ214qiKlBsI0dnKhxyR+Ht7dv1kEJr07wZxgu0DDFv/F5eGl8MjVXs+I4lIVN OxAHJ7+2ZWsSvHVenSFoSO0C/xbyQf0jvnm96j/W7Z54ZbSvMMqMm1Q8JqYR5OTIJTyb GxXCE12E2zThAgNm7In0X3eheZCJMJBKw0zWZqUh688RVNmR7Nw+9Gd72LmCsJbgwhf5 ye8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840213; x=1734445013; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YDx6hbMot9hPe7Zgw4rNyld1Z3a4kDtP9bTMjfYhMss=; b=GaXypxA23de3H6zijCbgmARYORnFbrqotsoIRJHv0MOhK2RoEs46X9Bt4zVQchUlE3 BriEYYwBCaaO0erSsV8bHInNAtpG9Imq/nv2urUB06GVT02zSQ4oAcUuRWqHY5t9fQwi pLPd/KF34EJnE1CPQlYQC3D+WgLgJZKrTUU/VFo1/F0s2Gm+6Aq1I68Zw8PwNkkB07Ml LVjOp2GVo8iL6YHpCjlOG3szknxECFr+JM4lXbL9MRWcAWupK3J7i2/hyKi/sVHulg3e /i25Ynol71CtwcmWm4LW5OSuUZURZQPjswezNMvJFVwukD5BsPXZzKABPCyMZE8pwYNi +IAg== X-Gm-Message-State: AOJu0YzlmjlXp+cZC9qVg+4An2ccriONplStYv2Hnrtra3mn7sl3SMyS T8tZpnm+OUROS800Ecp0UrJvV/8nsv4GZUT2rzVkzzORUFW/Uid1s+ZxSQ95zMs= X-Gm-Gg: ASbGncuMbkA8VEfMBm2UDnvABzkr4/fSPe3qP0d1a6pGFuwy1iY68Ag+KCXv4pI10yb ByU9u9Pgt4n12RnHpUgEZR9SJnlooVSyfcnNVrP1tZKAXb1cqJd4ad+OIAZt09q9oHfi868NHho WWydw/jvx7TkFwLsuWdE2Uqq6X/K9UyJ7bO5u+wJ1cCrvb9lKPaODDrHbUJoBA9AJZasCmQTiLq Slo6aixpzXQIH0DNk+SAhfEv73C9QfzMISUAt+StRwlIy5jUY6Qi5Qbz2FRGQ== X-Google-Smtp-Source: AGHT+IGWT8mMHqxsdN4hdP58Pe8rJU3Stb8+4FvxSrZ3iQfKkTBWo2xyAfZGSkKZNrpT0n9roYgJVA== X-Received: by 2002:a05:6402:5212:b0:5d0:b1c4:7081 with SMTP id 4fb4d7f45d1cf-5d41e163a48mr3441285a12.4.1733840213072; Tue, 10 Dec 2024 06:16:53 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:52 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:47 +0200 Subject: [PATCH 1/4] drm/display: bridge_connector: provide atomic_check for HDMI bridges MIME-Version: 1.0 Message-Id: <20241210-bridge_hdmi_check-v1-1-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=w8Xw25H9E0EowRWue4E3JonkkP8YUynIV0Mvq3TC5nw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1R5NPKL4rqV+jR0KPOXn80x27rRanZM+VQ5 Q4r9GgPzaKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUQAKCRCLPIo+Aiko 1atnB/9dz6pBR9aU669+5H2pdnKug29xlZBRPLZmzo+E5oJewM3cZD09he4jEBfGB6H63phwgKT PCpN6NcXKee8q0yILHUXjqQPoq0+AETXNH6uHzI0+4meAAff39OFtOxfONhTOBikdBNVu1/L126 34Smslj0Au4U5ptSosFI37VyPtgVeA3YkXyr762Thi+gFQikGCujFrG4rmoYiMn7YiCtGjO2kHo bAYnERIBIUqUoLvx/uC1WeTp2w3aS+e4u4SjSuB5yGIiPaOyqOw5Fwn0eyiotVWCwsbb0E6Oc6E XV7eLYsE+JEFYPpHPhaLSGyysWCYM1XeqIHTJMgcP4HrwECy X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The bridges using HDMI connector framework have a call to drm_atomic_helper_connector_hdmi_check() in their atomic_check() callback. In order to reduce boilerplate and make simplify bridge's code, use drm_atomic_helper_connector_hdmi_check() to implement drm_connector.atomic_check() for HDMI bridges. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_bridge_connector.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c index 512ced87ea18c74e182a558a686ddd83de891814..f6e0b6f1ffdd392ee15ddfd9ec85452a88122d42 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -313,11 +313,24 @@ drm_bridge_connector_mode_valid(struct drm_connector *connector, return MODE_OK; } +static int drm_bridge_connector_atomic_check(struct drm_connector *connector, + struct drm_atomic_state *state) +{ + struct drm_bridge_connector *bridge_connector = + to_drm_bridge_connector(connector); + + if (bridge_connector->bridge_hdmi) + return drm_atomic_helper_connector_hdmi_check(connector, state); + + return 0; +} + static const struct drm_connector_helper_funcs drm_bridge_connector_helper_funcs = { .get_modes = drm_bridge_connector_get_modes, .mode_valid = drm_bridge_connector_mode_valid, .enable_hpd = drm_bridge_connector_enable_hpd, .disable_hpd = drm_bridge_connector_disable_hpd, + .atomic_check = drm_bridge_connector_atomic_check, }; static enum drm_mode_status From patchwork Tue Dec 10 14:16:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13901487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D833E7717F for ; Tue, 10 Dec 2024 14:17:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 995BE10E8E5; Tue, 10 Dec 2024 14:17:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="YSJtlOXP"; dkim-atps=neutral Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id E607710E3BF for ; Tue, 10 Dec 2024 14:16:55 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5d3f65844deso3709556a12.0 for ; Tue, 10 Dec 2024 06:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840214; x=1734445014; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6+crVXPu3DLH2LlYuBMFmzZfW/018nLXCNXzwVqSUhk=; b=YSJtlOXP32U9VJw5bB9qznHxI1ub2I8Clckmt+/C/+h17J/SHJNKGVKH4ziXGAGNRX S5hSuxOQq9p+pCcQeo4UEXmfsqkZhyR/h8VxCfACDoAqFWt42jAUo04lDskO+NbRF2te cIi29sMP7NeHFdegWzVHG9i/hfmG1/jOQtGtxzFFTy5KGFq53Uqv6hKSo0j+H+PvNhOM BoAlaaTns6jjmimU9DfuaGXvRQP94itl5vi760ZfuygwyrlG/aIjuZ0qWedW0Kb3pRFY Z59CCV8Ge1KeZmM2uz2MTOF9VjVHr77DecJTyshOTqkyFuvCaEsj8Seixv/AdEkOt2/h b7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840214; x=1734445014; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+crVXPu3DLH2LlYuBMFmzZfW/018nLXCNXzwVqSUhk=; b=iFe+R3sBr0FLcJ0vaVqeTc2UvMPSSJgrnzkt34eYaP57nQFwZ0eRbfDDt0E9lWDGE7 V5Ldan4sWhqZ7hpwQuqopS3kVHilK64/qAFu4QArtVTd0jsIjCxuxWhpvKl8t5SjYBpQ zsv1TCvwPuvhoMuAqHYEScv5mGBBiGv8kRvOwAUAFU8P9rfKUrZTlsmS6/McmXHy4QDr hRF59ZYd1/YJJfc1BGaCwE2TCKsr0A+UirYfRES6h/pyk0yj8MuHRTprpk5cEbuLt8tn PQU5InAnHf78n2W3EhzjKNO/TJtLB7pAjVw9qItB9wr3I6Cfd5VI5TVmVz7ifFKRvBv9 WCDg== X-Gm-Message-State: AOJu0Ywh3cLZyyoyG33BfNhaNClSDt98SojsOOZWffZsLy+hX+APF5H+ bWWmcOUM8nFLdeDyS3LX4IhkZAkQa7RH2xXxOJPIQ91vgOBKAl+dJqjt4qcQVgQ= X-Gm-Gg: ASbGncsMjbPtSs9gCKmOrVChjVAqzjZeO8lAHMSzhdhYrA8IaqgjzHokbkqgFDFHeqi +ygLjRIoRRqFCGFXY/S52mZQz54o1GY/pGSjfA5nnWEHTf99HGrHaFIiVB1SZEq9mxCSwrPIdsA 5GrENXOr5fbkx36dnA5HltWzi5a9LXyGlx0Y0PwsUhBzeF7j3hbNKl3cFRw71zxWW9qyvkfxSOB 5gSwbali5B51bHRZ/OGiCXNiJNuVhVtfnhYKlMZbVftKC2fZxBpbZYqyfMi3g== X-Google-Smtp-Source: AGHT+IGxZHjKR5SCMI0IfbjDGhMhOA5BIzHnQ1eSiwRBGeabz2+uUXHR8Rsyhp3v0sQ66agXWWUdHA== X-Received: by 2002:a05:6402:1f11:b0:5d1:226e:e3bb with SMTP id 4fb4d7f45d1cf-5d3be715252mr15513178a12.19.1733840214182; Tue, 10 Dec 2024 06:16:54 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:53 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:48 +0200 Subject: [PATCH 2/4] drm/bridge: ite-it6263: drop atomic_check() callback MIME-Version: 1.0 Message-Id: <20241210-bridge_hdmi_check-v1-2-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1627; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=rB/0Gsa/+27l3uQdwPdG65mhrhs66t5UJhoR+oY4WrY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1SrdHcDpzN/kkXAE+ciWoTZRgyac4hMJI58 4e4awoizfWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1c0XB/4wCdakY+iL+5vJu8w6sDWGCs1YreJcnbtzjAEPWnpXIXQe9AtTgrQ7y8qGSCkS94VMf34 WPn9zTT1BAhvOBqitBey1l0Z/m45w/2OirgOn8X/LJGqXRqGtK0mhvauVdMdfMZszXABfn/BQwh A8nuYp6UNxSTdqSudtixSGD8jZmgwOuGHd5ynNstJuhuW9e6S4sRlkC22M2ERLr7WNSFNukqNRE KFZ+CW76ORQdCjyTPmRe9ZE3nwpYwf9XQ/z+KfHgK664N6wg53/Nf/f8VkeDILhC68jlJApptwi lwG3uuOZwuujl2LZAyWkFqNu2qDVp6b6pOccFcxzDOKBDJ0h X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov Reviewed-by: Liu Ying --- drivers/gpu/drm/bridge/ite-it6263.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c index cbabd4e20d3ebbe632a60f7cac73302815fab7d8..902444317d67e7a65ab05568fbe6f4571c500585 100644 --- a/drivers/gpu/drm/bridge/ite-it6263.c +++ b/drivers/gpu/drm/bridge/ite-it6263.c @@ -550,15 +550,6 @@ static int it6263_read_edid(void *data, u8 *buf, unsigned int block, size_t len) return 0; } -static int it6263_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - return drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); -} - static void it6263_bridge_atomic_disable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) @@ -793,7 +784,6 @@ static const struct drm_bridge_funcs it6263_bridge_funcs = { .mode_valid = it6263_bridge_mode_valid, .atomic_disable = it6263_bridge_atomic_disable, .atomic_enable = it6263_bridge_atomic_enable, - .atomic_check = it6263_bridge_atomic_check, .detect = it6263_bridge_detect, .edid_read = it6263_bridge_edid_read, .atomic_get_input_bus_fmts = it6263_bridge_atomic_get_input_bus_fmts, From patchwork Tue Dec 10 14:16:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13901485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F75EE77182 for ; Tue, 10 Dec 2024 14:17:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90E2E10E3C0; Tue, 10 Dec 2024 14:16:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cdruB5Nw"; dkim-atps=neutral Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1ABFB10E3BF for ; Tue, 10 Dec 2024 14:16:57 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso5700647a12.1 for ; Tue, 10 Dec 2024 06:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840215; x=1734445015; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KG04n3jH1DFELR10HVCrrQfC/3zE3v8nOQLbFlHi9xk=; b=cdruB5NwNdLp6xuJr+5Q0vlDSG5nskQFFuX/N/8ZiruZ1D9TReUKJl+UW0L5hN3eSI GFTI8CcxVV1aswGyDvZ1GviS1GQnVNstnLV468BtZuLna77Hm5c1WP2+yd7NdOom500O bThyruAHHJSDx0g2RaasTfNYP7xd1GQlEDWIeVCioVBKwrzmPegJXESqy77tC2IN1JS5 umAF8/XW7OIdXr9EH7z64inMc0fC1qhG8rifHaBQtqyFcql1RGF4u+vp7ps9QbnCkFIa Aj/U0ApXrnpJkH035gchx9cOCgW7qQZo2RD9xcaS9fLjokiBeAo1sfMH0tby+NCthjfd L/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840215; x=1734445015; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KG04n3jH1DFELR10HVCrrQfC/3zE3v8nOQLbFlHi9xk=; b=fjloQO2Hgkbd6+NM38nH14nSZDv4pOUfT71zuQNGHDN4jzbkW1f1pzEUhXM1IL14+c 9ugqiGN23UATjinkH0RVVRPRje6lgNxPsjLZDb1SJEtONk8n/g8aURkQpae9PFUXAu39 J8w4J9GBYd+Zlh35AC1FKCipUyD013uFhEzJNoV3MIobpbke1PX6Mk7T1kpyzytblHvo vECgliJ1IAnBWTTP9Y/J0AHWGJYwx+2jvy1+XGCooENGYAM+RVnyii9p5SfEnR6z6u04 +S1BE+o+a+IfyZxXftkYaZgvbb3vOtrpp3pPk0frzUagHYOu8wiVX5u2TfK7BJ73sQ3z 9O+w== X-Gm-Message-State: AOJu0Yyi6gzAEbJ6+DsSOBFwNU8jY77JI/K0CmP08JvOTGJIEvSvFzBj PZG4gXJ2sF8UTHoQ5ai4eI4H98FAKIsGdWA9h62LK3Pg1p9AC/tDyR7Ia5+P1EM= X-Gm-Gg: ASbGncurcqSe9op5qKkzC+6uPryYrFVzW77ehnA+y/i29fRQixqM66Sm+rgeqgHG+xT JmBOTtY9x3emyOKlJnrbSFzTundig7ynL3l7yaNvquQl0qNbR85HOt3RM2J8chmjT/279CVc704 ppixL/X/TmdGkI2Axu+/786dMRBG87tLrd3OPW/lWDQYU4e4lrEJtWWfVH5vtAS07OxMyer8uXQ 8hoIkQoXL+M0X+gbJG2JQX5wcAUXdXNNmZ05KHBUh2f4jBhlC+sZ46JSmPyWQ== X-Google-Smtp-Source: AGHT+IF8sFjqWDAeeHbyCT42Lo9bApykjgIi669+j87CMogHug4+toN6HpTcfoP9+THi9qi2bknF3A== X-Received: by 2002:a05:6402:1d4e:b0:5d3:cd9a:d05e with SMTP id 4fb4d7f45d1cf-5d41e2a7ce6mr3458173a12.9.1733840215431; Tue, 10 Dec 2024 06:16:55 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:55 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:49 +0200 Subject: [PATCH 3/4] drm/bridge: lontium-lt9611: drop atomic_check() callback MIME-Version: 1.0 Message-Id: <20241210-bridge_hdmi_check-v1-3-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1610; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Dv9z5EQ6QS4Oh3NjXL0UPCIboG/Nxyen1A1+0E3853U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1S/0Nn6akcX1McXx0ZVZ1AI/dMr6QkkQx/u U7fii/uAsiJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1Ws5B/9oZ0/B7Eid9JGphPr14wDxOw29qknjLVHN5U7NEDQ8dTTi/dtbyoKPzfPnFFN9dIwGtem prJkHHRdfpP7LhRqHneiVD36zQCzdQLIgqZVBLaov/fZF6zWQ6hDKZn2LmAB7lDzbqm6QBuBPt0 Mm06Ike4H+6d3galuqrXSJz9a747j81Lc1142qL1UGobmHzTb4gLlhLPab8l++29FWXY60kMImn 0DKEX5nwYTHM0g+J8Zb+tRum977h8CXvl5yCLQJ/aOM7o0o32N59NziNqXFoN0ePdWDYXxdrqa2 m7FfIhlygeUX6aIyYBkpvoM51yk+ZRB67f6CRUpo61LW/I7r X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 1ffbe473e4103dfc315a8cd3571e9407bf518797..71edb2b659de374c88b453a90a7cae902b97d91b 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -767,15 +767,6 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge, return MODE_OK; } -static int lt9611_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - return drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); -} - static void lt9611_bridge_atomic_pre_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) { @@ -947,7 +938,6 @@ static const struct drm_bridge_funcs lt9611_bridge_funcs = { .edid_read = lt9611_bridge_edid_read, .hpd_enable = lt9611_bridge_hpd_enable, - .atomic_check = lt9611_bridge_atomic_check, .atomic_pre_enable = lt9611_bridge_atomic_pre_enable, .atomic_enable = lt9611_bridge_atomic_enable, .atomic_disable = lt9611_bridge_atomic_disable, From patchwork Tue Dec 10 14:16:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13901486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 215F3E7717F for ; Tue, 10 Dec 2024 14:17:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CABC010E8E0; Tue, 10 Dec 2024 14:16:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="aUnRjnS7"; dkim-atps=neutral Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70F4C10E3C0 for ; Tue, 10 Dec 2024 14:16:58 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aa679ad4265so445613466b.0 for ; Tue, 10 Dec 2024 06:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840217; x=1734445017; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8VieodBk7g9+NNIIq8wzqsxrxxT4oOk+FbtOuCNcBAU=; b=aUnRjnS7qv8YeTZl1kEfcO26yz0ZIkLJfBQWF7qv8YpIHCQI9gSsLnDKYmLrvpd2p1 spsBLam8CcKhk8YtsyNMN1eDKr6lcmsU9PMWR54MoIwUUNx6hqXtHr71wvZpdz0S1MEu VwxUt+eSNOWnOPonLuElJczefSjZqDb6yJEoOPLQLjcBtBiz1AEIq8+NnaeL7taqKuDR oBbZf0nRHxycpcukgVc/5OZKdm+PyXhhz9HqPTUekLk7Kgt2V9IwJzxapOj6oUMX8Zo5 CjtZUFxEW/Lj5smbK9zz+0XVnY1Rj2/f4NWv7wFCvYQDfpXI7LDt0xtvUGM8OkrrCCKp MnQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840217; x=1734445017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8VieodBk7g9+NNIIq8wzqsxrxxT4oOk+FbtOuCNcBAU=; b=DFCKebqDHlSmtlNncrMct0pZiotRMvt0wIp2ZlLzkFoigrXeabAENPt1uu8YkI5/5w MiZYPO7JcSLO88D8mDCyv/Kmivw+XQ+F4bpcchFsjWh5KLj3oxDOe+TGf3VfwVs8WLEd p635oxtDaGNphzilMmICxZAbCkQnRkp0rjhIO9YJ4Q7wUxC8b1HVhOTZPTZOHTtZMBTy q7FYM2xIYhyujNAck9ENG6jpDnOjt8lrfmdNomUbXb62TNjNMkXfcuD3LFHcx1Vqownf 6PfyDE0AIs/RYhMoKU/3HCUkmMES7Y4nsW6LSOz0E86a0CgGHzjXRfxDGX61yM1J+eyX 3wJg== X-Gm-Message-State: AOJu0YymdbN0wg9CNQbsrPsAcIDJucqBbPN3KD1USiDst2phI/ClWT7t Oo+/pJNSjfItQdvHB3nyyfB5weRywqQwNf3FIjgJawO/2+Kn0I4nR9bs3OPUX0U= X-Gm-Gg: ASbGncsNCCEeUMNtM4LBbyPi54S8nyQPx51wPM+uxxW5Efp2bduy+BViJP+1Fb2FP2M azLXMBdFnTajEMgIqH8ZDXYNKiNaz3868EOOgeXJxbrkzN6Co9rojZi1SlgnAxx3YU/l+u2reBQ 3O4UdKsFk/YCr1wOaBasohKCqm9ImVAstuIGxcHeQ68NPcKJx4RxM4d0EM77t3codO2z1GyJOWC g3IIwuaHXzebfYjt5FuZmaX/Uhlb8JOjILe8g64VcPQ/f9mLzqvi/hacEzRFA== X-Google-Smtp-Source: AGHT+IFqj9fbpUiNnMEmvJaqOFp6heSbFuzVSyMydyTzS2DZeEIE3lH+oK4BSZlyPgf81n83uN7jJA== X-Received: by 2002:a17:907:3da1:b0:a9a:6c41:50a8 with SMTP id a640c23a62f3a-aa6a01bebf7mr370929466b.17.1733840216571; Tue, 10 Dec 2024 06:16:56 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:56 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:50 +0200 Subject: [PATCH 4/4] drm/bridge: dw-hdmi-qp: drop atomic_check() callback MIME-Version: 1.0 Message-Id: <20241210-bridge_hdmi_check-v1-4-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=iFbekFcbElRUJbcXMzK8ElBDVWKjAytyCvWyk7X8SUk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1SaxHLSu0OtwBtkIyYbWi0IxmjxvAGhmxU9 sS13D1+OkKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1UE2CACOGOQdt26+zxC6axMeEn4OWtbasMLCfvKvA1gR4JdDpUaq+snGJvhcXNFOjtt9wRZiyoU NwA3TsTrw7jLPoeMiTgDTbOnpOJlfU3jUM9O20cerZqKPELyWcgL0Ozi9WvwOjqW32T4OtS4Zzu eT5+/7pHAGGBIlrWyq9PH8QhXjJUM5eYBYhnzLpQZLL/zCcrLilrQ52M7x+1VuQoDN5lvLOum3T UvoHF6rMV6yb0s5T+lzBPB19mjwLfKlKxyTk/lnLHPY63nsf0XvL7vlimDibnc5inXoiN1pwu1n CD7wjE1v3Qm5jgejFH8SAgaghLW1R19Q6YdkyRRyZ0TtCWX1 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index c686671e4850a1af75b82995185ffc3cbb22a447..b281cabfe992eff88a4ba7bc903758bb119281f2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -361,22 +361,6 @@ static int dw_hdmi_qp_config_drm_infoframe(struct dw_hdmi_qp *hdmi, return 0; } -static int dw_hdmi_qp_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - struct dw_hdmi_qp *hdmi = bridge->driver_private; - int ret; - - ret = drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); - if (ret) - dev_dbg(hdmi->dev, "%s failed: %d\n", __func__, ret); - - return ret; -} - static void dw_hdmi_qp_bridge_atomic_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_state) { @@ -503,7 +487,6 @@ static const struct drm_bridge_funcs dw_hdmi_qp_bridge_funcs = { .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, - .atomic_check = dw_hdmi_qp_bridge_atomic_check, .atomic_enable = dw_hdmi_qp_bridge_atomic_enable, .atomic_disable = dw_hdmi_qp_bridge_atomic_disable, .detect = dw_hdmi_qp_bridge_detect,