From patchwork Tue Dec 10 13:42:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Moysan X-Patchwork-Id: 13903019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82FECE77180 for ; Wed, 11 Dec 2024 06:58:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB14F10EA6D; Wed, 11 Dec 2024 06:58:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="VTij4G94"; dkim-atps=neutral X-Greylist: delayed 1185 seconds by postgrey-1.36 at gabe; Tue, 10 Dec 2024 14:06:36 UTC Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7D3210E8E0 for ; Tue, 10 Dec 2024 14:06:36 +0000 (UTC) Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BAA1ErD020594; Tue, 10 Dec 2024 14:46:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= B88LI0a9Jttf2T4vTgk1R/W8xNzBmhzuueRUVJ5fXx8=; b=VTij4G94oiwG6nVs kAOhyaddTScvF0XJY6Owefa8LEB0JtyABva6XNVZlRrDA7mFQjbFr/5xhO8Q1Wgv MABJhtVAV1GsZPCrORnP17UsBLwTW6/A4qye+a586WqtsI62ydPo47XKvOU99tws qMkIh4o86OReclYJKD8KUig49P4B3tNDHegejsf8kp+YB0u8MXC3rcig9dN+YKWz sxT9QgBwEgRtV193dK+0ZV1C4/DTDdUYbAqHS4X4VBpc07oPP9K4SdQjH6WjrViS dty40BRrRlGJ3zfNbFFzOhhY32XfbgY52mI0D43M/A9XECl7jBEiHVxsMh/m34zG WrMiRQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43d0t5aq79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:46:35 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3FAB040049; Tue, 10 Dec 2024 14:45:07 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 62071258555; Tue, 10 Dec 2024 14:44:08 +0100 (CET) Received: from localhost (10.252.12.81) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Dec 2024 14:44:08 +0100 From: Olivier Moysan To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Olivier Moysan , , Subject: [PATCH 1/3] drm: bridge: adv7511: fill i2s stream capabilities Date: Tue, 10 Dec 2024 14:42:52 +0100 Message-ID: <20241210134254.2967524-2-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241210134254.2967524-1-olivier.moysan@foss.st.com> References: <20241210134254.2967524-1-olivier.moysan@foss.st.com> MIME-Version: 1.0 X-Originating-IP: [10.252.12.81] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Mailman-Approved-At: Wed, 11 Dec 2024 06:58:14 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Set no_i2s_capture flag in hdmi_codec_pdata structure to report that the ADV7511 HDMI bridge does not support i2s audio capture. Signed-off-by: Olivier Moysan --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c index 61f4a38e7d2b..28ae81ca3651 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data = { .ops = &adv7511_codec_ops, .max_i2s_channels = 2, .i2s = 1, + .no_i2s_capture = 1, .spdif = 1, }; From patchwork Tue Dec 10 13:42:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Moysan X-Patchwork-Id: 13903013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19ACFE7717D for ; Wed, 11 Dec 2024 06:58:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2A0C10E3D1; Wed, 11 Dec 2024 06:58:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="q6bh+dZK"; dkim-atps=neutral Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6387110E3BF for ; Tue, 10 Dec 2024 14:16:30 +0000 (UTC) Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BAAbOaF025829; Tue, 10 Dec 2024 14:46:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= oAn87QHJepSxFgirg8GRxK9W/hXFqtjZBsb7YLbCrvk=; b=q6bh+dZKfuIAAHvX if+YpWF2HMiPOZcERvVA4rG8dV6NP0qd4fqzIVRi0lTt3BM4Br8F2d0Y3GkNjyP2 FcHRd9XrOHOSZx5bmmODTlNsahtGsmmgwHOYajL3tPKZbZL9GH6A9FF+13/EOrK9 t8lJ32/8Tro7jqrxo0hSkjtJ66Ap/cNcMgIGkdS+CpHaSx20mQsoblHwB8ybaByl Hy+sVpZOSKg8Fjlxnv37wbbL++Qy+74Wlo3wGXkPhoTLB6ksTApUHAVwt1g5djHH gq3TIsFV0dcq/zDNgylSUQ7msaE06uhnphMb+kkRYFL0sl97EIZ65wjH4vWWP5Cr KZ1Daw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43d0t5aq7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:46:38 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3FBA74004A; Tue, 10 Dec 2024 14:45:07 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6FC9C24A15B; Tue, 10 Dec 2024 14:44:09 +0100 (CET) Received: from localhost (10.252.12.81) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Dec 2024 14:44:09 +0100 From: Olivier Moysan To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Olivier Moysan , , Subject: [PATCH 2/3] drm: bridge: adv7511: remove s32 format from i2s capabilities Date: Tue, 10 Dec 2024 14:42:53 +0100 Message-ID: <20241210134254.2967524-3-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241210134254.2967524-1-olivier.moysan@foss.st.com> References: <20241210134254.2967524-1-olivier.moysan@foss.st.com> MIME-Version: 1.0 X-Originating-IP: [10.252.12.81] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Mailman-Approved-At: Wed, 11 Dec 2024 06:58:14 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format). However the HDMI codec exposes S32_LE format as supported. Adapt ADV7511 HDMI I2S format list to expose formats actually supported. Signed-off-by: Olivier Moysan --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c index 28ae81ca3651..ce6eda87bfe0 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -232,6 +232,9 @@ static const struct hdmi_codec_ops adv7511_codec_ops = { static const struct hdmi_codec_pdata codec_data = { .ops = &adv7511_codec_ops, + .i2s_formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | + SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE | + SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE), .max_i2s_channels = 2, .i2s = 1, .no_i2s_capture = 1,