From patchwork Wed Dec 11 13:36:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marcel Hamer X-Patchwork-Id: 13903485 X-Patchwork-Delegate: kvalo@adurom.com Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFD82368F1 for ; Wed, 11 Dec 2024 13:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733924199; cv=fail; b=exVht3Om8EB0GVx0rvofcmN5c8DOzjcFcIb7s7dUIXIPBynR1RlbZu8RTGikaeSiawpoFXhGoY9m6Po6ewacexqccgE/RBT47EUAy6XrcR3rHOuKdpMqLLWFlghjbojm83n6DEoJ0QPdP48CVWo7NnhZXevjfMAnAAfUPkAF7AA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733924199; c=relaxed/simple; bh=bPSVGupmZtFx1GHvcAF1SRvlLUGEe5wZwxtqNQhuo/s=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=Q9jckFKykAegcoQAmGzT54B8SfVWinj20JAT1p3E6J7RvepAK+9L+Lf1MxVRBzTqZPQDxTyC+xP47oQp0q5KUtoScG51KWltycyh81yg/eY/3rrJ3N0BInh9hWB7Th6z5bg6NcrZ8Xw4W7OJRNgCZXV3k0myggUO2Yi+9x7OS7c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BBBl3Qq006283; Wed, 11 Dec 2024 05:36:33 -0800 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2168.outbound.protection.outlook.com [104.47.73.168]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 43cx1u46sy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Dec 2024 05:36:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E2Hlcli5w7Y5v1+Rc1bhMaUfppiG+FIe3xkwMVwV7pmqLVII41D7RUfgT6LR7mkxGa47Ti9NX3fDJ/LNKAcIK4oVY02oY7oNyGkIVIw1j9bo5LJRKif9uNroV8KtAzYof/rjmlKv7Noxsxc80zuwPiBivyzBsSSIOZLPkaMzUffQXPtRkJ97S9Wq31VZENrwD5HpVSGoQ13yMpBIQH+PIv5XEGmYwpq/lNQEw20Cp1LYDmYRLcETgcL05oMP8qfhdDALP4au/oTMAS+hE1jI2S5/i4fd8HvUOiZxpkKeQaDI8/h2QqzEC0CAFobbykIwjPG3hFBiXHfJhGu9yscwXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0krIsjMVumSy8hnJj/X2xJEJVKCWo7xNVh/qw6w/nw=; b=J+9yJ82CtZ106w4+L6qc+wDVPkt0qZslw66/RdNnBLPfSvhJtJcg+GXA7IPvhYkK6zRi9PKZZORdHptNeOYG7eJbx2wjUt/44ou9PTxOexEiCRDS/jB8d5/tFz/vXRkjGrfMHkEJHZZI+sE4jV/KNiw1JKXRGaTVxGCZnIu+BataMQcpIpvzbCpoa7K7FURSYXKwslUUwzbAEzfcK57LTL4FZdRzqzohyd8j9sATx3g4mQj4tsV+8rsv2Ziqskvtl8P1ujMew9eSE5IutymLgowy7Eax9itvRXehmGaccMvsxXLDjRU870xbhteD3+zo7rNQDE7wvdDc8dG6+fnoFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from CO6PR11MB5617.namprd11.prod.outlook.com (2603:10b6:5:35c::14) by SA1PR11MB5804.namprd11.prod.outlook.com (2603:10b6:806:237::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Wed, 11 Dec 2024 13:36:30 +0000 Received: from CO6PR11MB5617.namprd11.prod.outlook.com ([fe80::9629:5ec0:f779:4bd]) by CO6PR11MB5617.namprd11.prod.outlook.com ([fe80::9629:5ec0:f779:4bd%4]) with mapi id 15.20.8230.016; Wed, 11 Dec 2024 13:36:30 +0000 From: Marcel Hamer To: Arend van Spriel Cc: Kalle Valo , linux-wireless@vger.kernel.org, Marcel Hamer Subject: [PATCH] brcmfmac: add missing header include for brcmf_dbg Date: Wed, 11 Dec 2024 14:36:18 +0100 Message-Id: <20241211133618.2014083-1-marcel.hamer@windriver.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: FR2P281CA0170.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::19) To CO6PR11MB5617.namprd11.prod.outlook.com (2603:10b6:5:35c::14) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR11MB5617:EE_|SA1PR11MB5804:EE_ X-MS-Office365-Filtering-Correlation-Id: c148498d-510d-4b4f-4436-08dd19e8d1c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?b28Jn28PlmG8IIg0+B7PZAOl8XLVhqr?= =?utf-8?q?3IdXZD5qCttVixumP/ESblSOk7HfVuoiZ5isRC554FheDHYtDlT6IOHnMQfOs7Lcv?= =?utf-8?q?qknhipccpYdGgjtmj4/Mni+2UqCHVDHvt2ZxO6aZdsbPsN6O16keVJ9pa13eGuzPp?= =?utf-8?q?/vYo5ETUNbaxvb82L3TLm8A4l5IK3phBvDl4PMy0vxmGSKtzzP6m95ZYr9zlgvNg5?= =?utf-8?q?aQJYhiEISzp+KhjQ6lT1pZ+RUldhWoyfd42bT617q/ruCUNx4oVHIY8oUkXlj5MbT?= =?utf-8?q?5lYPMo6AlrLpk2nvfRabjVi6GK7hSQx7iS/QI7hVPvSuWuvLYsdmZbepUUc5xvwJ2?= =?utf-8?q?H7KY0Hv0DZvgp1Pb0aU0P+lmETWYirPhVT32Grnm0dPeL7wnUCsRhnoriFxYlvIN0?= =?utf-8?q?TjhtS8jRzEAn0ibLkhbIAsn6Skf5N8er/x/P55CpKZDihR0R0k0bFtO/60i8VqhoK?= =?utf-8?q?46zw+ydnMR7piAYb1MmtOkjjS2W4mMS0hcKAIJmZEJS7u3aMH9ZBnoO09sJj1Tt3a?= =?utf-8?q?n64R+NWius/mIioPm31VYINqZLVnb2YeCXfuvKaWJ+43oH5WOm4y5PHBbW961Yjyx?= =?utf-8?q?oHdzYlKx1kCjS82aX15eieCNHAMCHQzi6uXzmElUoijVjqHZMBRct5iNpSFUbY7ES?= =?utf-8?q?z7U4Q6a+kdCnrWxn2mnpVzMKsGip6u7yc+aEq/7yoORIBUnGEDzGtStbDebYCtyHc?= =?utf-8?q?j61O4vfPBpz3nfmggJSqrLJo4B8s3eTKFLBhCDL81WTTHSGnXJIy1owTr1WrxOTTq?= =?utf-8?q?whu9Br/3VgN0cLJUBNwu5SM7jO4iKM7Zp9KkvVx8KA7zxDftoZS/ZIbfjQ7iwHA5Y?= =?utf-8?q?XjZ2+qopAQciO7u2vYWnFADfpjLSrmJ7HshK0HgCAgrVS77k31J6YWDcNnU0zPtwG?= =?utf-8?q?99LT5zHMMGBJEkgDQKGnumsCLkG+NccAmJe3MqhBWjbA2FgfZ+9A3U4sQoWypIeIs?= =?utf-8?q?eOZ1rjf4yrFGcZruMoB0XZzf49dJKGHm1/iUAgNRcnAJAoFuhdPLSDArY55B8AY2H?= =?utf-8?q?1IODR0NaaqJtoVLGSk5Jsyro2IV+AqWO0J2rHoyVqhpyyRmTwLOM2JWdSO0qt8rNw?= =?utf-8?q?bzKzqQPvH6aiiRa2lWbGGZoUPx3xB0qEWZgKFnos90U9GyuPrI+lexBN2WJzxXBfW?= =?utf-8?q?g7tsjnMbjDG+hvRcvI4buiRU0qkJbVB17YEHMv/hK5g8jvq4ShmhdqiwEFH9JVkNJ?= =?utf-8?q?DhA+0n4b20c5hAxa0bD5AVuWxPo3AVJHwammo6NvLhiH85WCRt3UwsAzALHikp2Rr?= =?utf-8?q?6a1MMKs7bx0VZjd/cnynt1qpcczJhulgo8Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5617.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(10070799003)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?epuereeyBcXjlHS43hCBpBCHwGzj?= =?utf-8?q?+v4zVna5Ijr8FqdTuVAjVjZYzF5rB2tLvcuNof/SKxBOKT5XguLkJ2jXJgy9yZVqo?= =?utf-8?q?mtzKqHS7fQASNhRL6ImkbDyK3gylMXd9iZmg5O5xByoOHIhy/WMUtAk02GiWzscl8?= =?utf-8?q?kCIHg16oYGPfopEy1vL0jUg+agiYLZrzbkkhItCFQXfhWSTc+AehdxfODPaCwDV9L?= =?utf-8?q?60DeucP09H62UDETT1w8EVtorCIVS619gwwK04C8y+AILsA2MDbaawjSCrDgzdWW2?= =?utf-8?q?AD7flKysMQH9M4foFPZx5Srl0CXA7sO9yS7I5QAwyHbiPwgJDrXXG+tjgY9cbSfmV?= =?utf-8?q?P0HhezVuQC+a+FbeUv+QS2XLW0+86AqluKtM/dOG3ryv/znMhkMFFUFWh2mEYXVdI?= =?utf-8?q?5GjKxhg3b7e8rvEMqYU3zGUZVQ6pdzHB2Q6+uCZ/s+J1IHq5gyP4ZtHz0fH0sE1cb?= =?utf-8?q?2852mA00rM0cF9bHJNHZOa+zUagmFxOTzDfIulkjhI+phgBHCrPFX0fnD9wNHxcuO?= =?utf-8?q?+NgDJluQ76587iAjnNhayAjcQS2Lju7r+SvbFlbo2pank1Aa5pQJgr9VdIMSBINEC?= =?utf-8?q?7SkIasuwBRnc5MWL60y8CvNRZ0lla/MA3kJBHEjc1QuWnZoFpa4xvu2aXfe9NGJ7G?= =?utf-8?q?ISRFSwGKYrVEoD68+Q5ddGyUyrxEIOZNL0hB2ChFFG2DYrmIdUiNtdymC4hO8xvBL?= =?utf-8?q?vfpvVue+jsG0aV5WFgkYWsu+ZdKQBrzVsNd9wMaSqE8D7mL+PuoKAVL6mRosXVK6w?= =?utf-8?q?jLmWAQYR8ADIMgLRZqrcs0urYVhQBTuWk1oobWSY1l5t4TjS0Iezl6ExUZsWP9+o3?= =?utf-8?q?AmrEUw9Hgx/TEcfrWwNJp8e108ZgzuzO1VaILnjP6GZNPz0mIQ0OmcEOQjpVGMwja?= =?utf-8?q?TYKrfrEn1Iipreg5e/Z9ZhSc5xocdPgpV5YZ6Vedm5crTFbT/QnfB2KTPd16mZpwF?= =?utf-8?q?aW/qZM43/H9ei0/Wmtl56xX6na+XmJ7znrp8xDqlJK75zeOt20F3TpXyZYEZTNLzs?= =?utf-8?q?4cIQ+dC3CA+Gz9gs5TFdH4e6dZm+LN7jc5I65mfrucEaVw/jtOPAVImDR1ZPIuI3X?= =?utf-8?q?76d7wvGFrwuVzcgzGL5huRsn2j+ekDmslcfjEBhK01mRTpUbKgTfSLPInKTOpVhjO?= =?utf-8?q?gGM6Gjt9hOy5p9egDMwNIyR4PGaeJpKY+bHlFxaxjX+SqpZ9Y8I4OBrtUKiu8owoq?= =?utf-8?q?zgyriZ+4F90X6yJ7htoiRV6Q/7VBNSrtVqxviyizRC2HfcAX+X6RKyskyB0RwLJKm?= =?utf-8?q?guZQGsUZVSZR1fHFcLs8Vxt3cDAqpXhaNNdiA1fMhjs0OuxYHC9QVhQVkVjnslaKr?= =?utf-8?q?+p9TtDq33i1Bfe0RH9aXNGAabwax/vqqoajtDUSEGz366AM832buZkWsqnr5MMowT?= =?utf-8?q?B77V6V3kJde0YAV0/JrqnYpWAP9sH+XxFoaurTOKC1SWBaY5q1ZSEaE5k+WPoxrc3?= =?utf-8?q?RIM+VLmLBOyLtMoMxlmeuHO9CfV828o6lUtzN9j9cXxJ/HvtRnmXmC5CD0UO95J4z?= =?utf-8?q?M33X3MbHFwppTLHrUAYD78aJAV5cSSGojxuQOTT8qYARvJLt0rwESzY7LF0aQkZ92?= =?utf-8?q?vak7ekbHu5pfw9H8DYasv4pfDntnrx/pA=3D=3D?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: c148498d-510d-4b4f-4436-08dd19e8d1c8 X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5617.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2024 13:36:30.1699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C+lXv/esdF9kqV69o8KCDb2TodVFxk0betPU8JGAZjr/M1AYz1euRZNCJBHuklrQ1KGFxQIO/nUu+ieOpeSA5RccTUzCGN3yjEns5CmhOjM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5804 X-Authority-Analysis: v=2.4 cv=H/shw/Yi c=1 sm=1 tr=0 ts=67599561 cx=c_pps a=WGTt6C9BqyZsVnlRayY6PA==:117 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RZcAm9yDv7YA:10 a=bRTqI5nwn0kA:10 a=t7CeM3EgAAAA:8 a=xJcuyeIl4yQisyzVulMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-ORIG-GUID: 8EewXVJjU_2IQKqyNN7a1c7RiYl1ZSCu X-Proofpoint-GUID: 8EewXVJjU_2IQKqyNN7a1c7RiYl1ZSCu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-11_10,2024-12-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=728 suspectscore=0 spamscore=0 clxscore=1011 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.21.0-2411120000 definitions=main-2412110099 Including the fwil.h header file can lead to a build error: drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \ In function ‘brcmf_fil_cmd_int_set’: drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \ declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration] 90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data); | ^~~~~~~~~ The error is often avoided because the debug.h header file is included before the fwil.h header file. This makes sure the header include order is irrelevant by explicitly adding the debug.h header. Fixes: 31343230abb1 ("wifi: brcmfmac: export firmware interface functions") Signed-off-by: Marcel Hamer Acked-by: Arend van Spriel --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h index 31e080e4da66..ab3d6cfcb02b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h @@ -6,6 +6,8 @@ #ifndef _fwil_h_ #define _fwil_h_ +#include "debug.h" + /******************************************************************************* * Dongle command codes that are interpreted by firmware ******************************************************************************/