From patchwork Thu Dec 12 00:31:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 13904550 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F859CA5B for ; Thu, 12 Dec 2024 00:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963532; cv=none; b=TAoQtvwDXn+nRjBDF6VKFxUNdZQDqxePNihKq9+Jdcy91n8vho3TwuCN8yTCQewTcc9gp1ZNjm+blU5+PiW0TS0EwQ7sRXSW4k7RdvUJ4KBLLZk0jOpsLe+2/m4p93syqv8h5wepqc0vLnzqMKZdaT+ohTlqDzy9AQ50JvJ+G1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963532; c=relaxed/simple; bh=Kd6noYu5kKaYuzY2in9AHzWwTWDE6GDZOmHXqRdwZq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S4amkMXsXfgMqxTJHq0zOk8soGWKik5/mVCJ5IQpFyK173T7IDWuHbpIcq/sas3iGA9CQyUXC2y3RJpz/D+CLebvv9IO90vszaN5jOxsSFO+T55f3z8nNdDsSMCHmKA1nyXOPcKp3UYRi0KhQcoBmh0Zg2QSuHPFFbiA38CMQhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Pp9QeeFR; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Pp9QeeFR" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-216426b0865so372415ad.0 for ; Wed, 11 Dec 2024 16:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963529; x=1734568329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=Pp9QeeFRfnoMlCiiurrzdJkSvsudEVGzZvOCuEawQ413F15UbpFsEzWHAww5e5YBX5 fzCWEP/KFSJ7RgviBE8CpnHpjfbV+sw+1ub8DhqAACBAn4fWZ+CAKp7aZeRXNGOvM20T DtB+S+i+IszUzirH0wpt7FPHHPGK8XgUO9eLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963529; x=1734568329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=tYME3BrjKpdAI/iFNH0QOTsag0ejxnfVU+AmFP0oia1bj3PffPkZr5deallnlrxXps BZKbcaOlcXd4IP2tIm6odc+e19EPsBfDiFTHFdTZvy0U6G/ytRwKl9zOoUeUSkpHqkOw J0OkEZZrL0XYBYMB//qItubUHgPUsgRp/zoKaAfngMIQ0Ih82L4zDu3sQBhiuQyo1wRI SkOdfVBn+b1gRFX9CcDoTQE5sj7KmpOQM8bC0syNS1a8aCKgzFHC0Cq6R1qWJJ62To88 9kqIRwauVoTRVQBwZNwe6fe5ugDwLNKL7EE8vMkZa1q+3wUw6EbeBjXmP0VRgEUsBNG+ L2ew== X-Gm-Message-State: AOJu0YzKX1Ob3Q+sjmAuXpPf4/zIveERQmIoSw2Ujqp2ZSrGh9VYCWxl ea3eWhSerKM2RHY02gQxF4izoQqsNz40630f9rF2M1PFBCbPmxWpXmzjsG40p6UwfD1X4pdccqQ = X-Gm-Gg: ASbGncu8J//BVw/d2VSBasLxYNixjnTe+yX0GBSP3LgIdQvs/dhyZhYOcoCQC2Rqb4p qgVsiX0ofcKn4hpV9A65PaDHfQ6E+1Fom3kP3nO/sZ+ikXMn/dPqRMCXlEL3JFczrxIsE326nS6 BC1W9g0OvALXUGAUr3g+sxLwxtx+SUqCE+OlWjQLxqnaGAcTKjoldVv9op2qMFun3iNwYDoucrw WPnDOPO50tOA/omeiV6rDPlUIubnLC7e5SioZkGxWh0YlanjjKcqoUEXFuQzoBfzqf6gJJzSZ7Q y7VsIdEX/NqksXVWeIw= X-Google-Smtp-Source: AGHT+IFSuT2+ENL2AFZJMBD75mM9b3DCrYPiGx2+DNGXuCjKQhYTfFJJzw1Pi1HU4HlUFrZS1ojuOQ== X-Received: by 2002:a17:902:ce92:b0:215:e685:fa25 with SMTP id d9443c01a7336-217783b7a08mr70313815ad.20.1733963529631; Wed, 11 Dec 2024 16:32:09 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21680814d6bsm25853825ad.157.2024.12.11.16.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:08 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Date: Wed, 11 Dec 2024 16:31:39 -0800 Message-ID: <20241212003201.2098123-2-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, and the source of a few bugs, such as the one fixed by commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). It's hard to imagine a good reason that these device_match_*() APIs should return 'true' for a NULL argument. Augment these to return 0 (false). Signed-off-by: Brian Norris Reviewed-by: Rob Herring (Arm) --- Changes in v2: * Add Rob's Reviewed-by drivers/base/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 94865c9d8adc..2b7b13fc36d7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5246,13 +5246,13 @@ EXPORT_SYMBOL_GPL(device_match_name); int device_match_of_node(struct device *dev, const void *np) { - return dev->of_node == np; + return np && dev->of_node == np; } EXPORT_SYMBOL_GPL(device_match_of_node); int device_match_fwnode(struct device *dev, const void *fwnode) { - return dev_fwnode(dev) == fwnode; + return fwnode && dev_fwnode(dev) == fwnode; } EXPORT_SYMBOL_GPL(device_match_fwnode); @@ -5264,13 +5264,13 @@ EXPORT_SYMBOL_GPL(device_match_devt); int device_match_acpi_dev(struct device *dev, const void *adev) { - return ACPI_COMPANION(dev) == adev; + return adev && ACPI_COMPANION(dev) == adev; } EXPORT_SYMBOL(device_match_acpi_dev); int device_match_acpi_handle(struct device *dev, const void *handle) { - return ACPI_HANDLE(dev) == handle; + return handle && ACPI_HANDLE(dev) == handle; } EXPORT_SYMBOL(device_match_acpi_handle); From patchwork Thu Dec 12 00:31:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 13904551 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2FE18AEA for ; Thu, 12 Dec 2024 00:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963533; cv=none; b=NfICjszwaAL9iniIJRXelGA/P+aYWkuA7j0R88p6CA/+ovf1rF55uBbEC11CMAz94bSN515fOn4SyWfkrWqrG5KgLItGsHQaaQ3B29mWUZ+wBvLd7b4VupA5UcmSe7WJxxefks6MLUPz6z4JKgf0V37gWgWfUGFhlIV7+atxYJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963533; c=relaxed/simple; bh=D4wKzLL6P8kjio2DoNo6T3LLiJX47WeOUYHZv/B1uik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k9rSjSkzGbm7IGpxQ39COCGJUeh2QpuK/XqokunIE9BgXA5eACMMxXv/DrTC9FNVjtPn4yOTw9VUFkEPUKdW3qokXvsIPelPYP97SZ/SE/B9cW5+6vYrTC6uHrwjwwks/60I/pJEZ7QNU/XsQ1gXtTturIswZ2zjpBEiDJ8al8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZQPYGCPB; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZQPYGCPB" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2166022c5caso292105ad.2 for ; Wed, 11 Dec 2024 16:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963531; x=1734568331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q8D6ygKlZnTqTfL4YWEBFZxFC5MoNr1XcjZ+M09PQhc=; b=ZQPYGCPBoxvFCCUqXwtUATpD2ZE5Fnq9gKIsBoOlyDyuGTGijm2XYpDMgoaOlejtHX G1Tv3i598PxbLDaFpIQllPCCNTjQXRFUnHn8Kj9kCaIwG0UVByNeI//mj6JnlLhRwmho Xxno8fw2kcbHhsktG7mlsoQyRFX+Fa3RCs2iY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963531; x=1734568331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q8D6ygKlZnTqTfL4YWEBFZxFC5MoNr1XcjZ+M09PQhc=; b=uKuTy2mcL7cVdVQ4cYONJP7w4Nzss42ZyaAkmWr+Ugu+XddCk5Q5UQ0dAmyKNoXlJa 0ajKZHKQpWtr9LHeJsTNG5CFJuIwQ2J3qdBCgo31OU3QKiZVFkUtTDwW8WIamKbxUqwa quzeBncRrvvigk3hvY1VaX4oYbaix/Xqjc0yZTspZWmX/r2PPicoW8k2E9FvDAphy/m9 +VVvEaOyyUM3uEOrijWWgozu+y/11FtRoR9WV5MKedbMwNIZ0dUf8iAQDTU4CDAMr4uw yw5m+yFBDRlrGmLVITwqRZxKsIW7z4rnB0kJ0sF/fEGDQnPfbwSzLiRuYWFlBYh4s/ZI gHLg== X-Gm-Message-State: AOJu0YzojZYfHjCAmHdI39ZtBxMIYjUYBFBZLPdCy9K8X0hehsMnSjcb DRFePR2S1tK74glqlRDQyuVBhb1HoNogiSczTEBzAKmxYBWpmiotMTySn6cSBA== X-Gm-Gg: ASbGncvOiS5bcBSSfpzi1hSro8It4oLl9KMmNBtheFxYsApgASsOqepCWKozeMpnW3p fdhQWhzpzR4o1Uv9OhGuVstrElR/saflYmwkNgBfkpUi0hK4kpQodH7IQiTludNlzxNw4Fpggf7 5i4VZPSCv2jOOEmDzpWRvP4O3aNSLvB66aKFF6z+6MT0ljTy27eX7YFN0NuFeGifrDA2aG0f3dV pTLRrmsi0paLgc+YrdqS217Hf4n05mn4dX8KLeKUI1HusSoeW6sfwmgVumtRlzFpkMtf8UvaLVB MU7bZtEofjMrkJHpwzw= X-Google-Smtp-Source: AGHT+IHkPbKs3MqtSv9QsOis9HgYSk80Xsrurh11pKn4Z3ghlcVU8XnfyIU14vl7WdQ/uQmhi+CZqw== X-Received: by 2002:a17:902:d48c:b0:215:b9a6:5cb9 with SMTP id d9443c01a7336-2178ae4c25dmr25271915ad.5.1733963531278; Wed, 11 Dec 2024 16:32:11 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2163724c42bsm70938605ad.174.2024.12.11.16.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:11 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 2/3] drivers: base: test: Enable device model tests with KUNIT_ALL_TESTS Date: Wed, 11 Dec 2024 16:31:40 -0800 Message-ID: <20241212003201.2098123-3-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS. This enables these platform_device tests for common configurations, such as with: ./tools/testing/kunit/kunit.py run Signed-off-by: Brian Norris --- (no changes since v1) drivers/base/test/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig index 5c7fac80611c..2756870615cc 100644 --- a/drivers/base/test/Kconfig +++ b/drivers/base/test/Kconfig @@ -12,6 +12,7 @@ config TEST_ASYNC_DRIVER_PROBE config DM_KUNIT_TEST tristate "KUnit Tests for the device model" if !KUNIT_ALL_TESTS depends on KUNIT + default KUNIT_ALL_TESTS config DRIVER_PE_KUNIT_TEST tristate "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS From patchwork Thu Dec 12 00:31:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 13904552 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 705DA2A1B8 for ; Thu, 12 Dec 2024 00:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963535; cv=none; b=qhWkZs5WC8OHHAW4hX7tb51RhOP6x8k6qY/ZmDyU2N7l3eUQoNFIJar1ezO3MOsXdaWkTZbrTepQPJE9GpJc1QGmScxSCIKVldbMMvHyDlxtvQdaJuZB+FOVP+hrBQRMJv88OP4IerW7+ihmR2D4auGBVibLBJ5AbwESowMdzSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963535; c=relaxed/simple; bh=y5nwWgTVBI2UXYuNENiRQFzqncmPN23qxZLRHMtG29c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XJnkizfZXg6XZnOPJxPn67RhdAkw1HFhRPGx85SDa2RHlpJaIrQvRyKOjDjQjgcQR+QmEZsxWSJj8R793zkOJZvRjRs+1/OBprZm+8QUqTIFOMjsqixhFEU8Xrk1cgQzcYe779S9YNxKEPuA2IKRaL9GBtWxnhLua5ulXsrLBog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FCm8BLgy; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FCm8BLgy" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-216634dd574so210465ad.2 for ; Wed, 11 Dec 2024 16:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963533; x=1734568333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3AVQu3QWop0H0c+IcZ6mMGnn73hEqL5BKjdosgsTiGA=; b=FCm8BLgyqZ79CS2uNCVdS/VBz04o89PGFfnlwXzBFac9Yb0nn6pKl4+cz+yP2qthbo TrVe2jYTHdVLDSH2VyerbPlA39oUCqOU35A/TkrNIOZy6/CRZTtR36vrCMqkzdFHRiSW Lo6JXXHTA0XlgC/kjG2a5d9O6t29PGw08nxKQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963533; x=1734568333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3AVQu3QWop0H0c+IcZ6mMGnn73hEqL5BKjdosgsTiGA=; b=wPicOciSenj6xW6cYIKBlM9+Tep3SvqFiW7RMTRQw8PgkmOfXbjhSnid3nQpV+MHVD 2EEWuodWkoWU2xbZZ48ndt+uzw9WBI9iObu1ghtNTZFL7UGqdmZlnEoiJMUDVkEYauOE uxGMf0uH3HJicKELLHheiZUZo4prkQcW1LGiImtguBYDb6gUm1tuQx99FiysemaRp2fN PsdAQUIrwd4Sjmr1SJj4Jhw3MRj4L/iUKDiTVP+5t2P5R215MqP9NtEWv+TfBz6oMMy8 Pzc0F8xoydT2/R0y7laMeQaHW/8zxMl5ayooWhHhJ8kx9vM8xgNX6h/kXVDI8flOsHB5 RMtQ== X-Gm-Message-State: AOJu0YxtaPumyYlRji8byHFyG/1DY8u5HkbbCh+TO0ncF2IRYZz5IRru 6R8PVFB5i3qLetZeq1zu9E6VFHeZAdkTVS+fJIN/jwawUcR/q5rS7cRZj3KSNA== X-Gm-Gg: ASbGnctWP7+5HBT/w25C450jvNgVb/LnwW256V2zcq5+fGA1ezo7ViyJIUKOVPBCyqO pW2VpKFCtPsXhJ3svcH4j1RgHQtTi6mTw7DvgB4x6A1LNT79e3gbqLzkngrTaJkVFYjYYxGooVs KkkhjXJWdaNhPCuPqMQGh3e/g5Y9YykYnc1FQFJTvfVujDkIqIDwg/eRg9KyiTFxFfnoKnp8dXh 3ShtaVOdLt8Wf0EeHy2pfUsPjQKRh1MvB+YPU5eyTh7q46/ZFUHF4UQDqOYqZ/EnytepbE/SQCr 689qlyfpOjh3VjICUQk= X-Google-Smtp-Source: AGHT+IEGLgadsxVUtkYmrldWfxFt3dO7ayUdfAi8DTpzJjhNb3S1+xd9gbNu33I+qMnncuaz+9QyRQ== X-Received: by 2002:a17:902:cecc:b0:215:a3e4:d251 with SMTP id d9443c01a7336-21778395944mr84017305ad.6.1733963532911; Wed, 11 Dec 2024 16:32:12 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-216338fee40sm75395405ad.94.2024.12.11.16.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:12 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests Date: Wed, 11 Dec 2024 16:31:41 -0800 Message-ID: <20241212003201.2098123-4-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 We recently updated these device_match*() (and therefore, various *find_device_by*()) functions to return a consistent 'false' value when trying to match a NULL handle. Add tests for this. This provides regression-testing coverage for the sorts of bugs that underly commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). Signed-off-by: Brian Norris --- Changes in v2: * Keep "devm" and "match" tests in separate suites drivers/base/test/platform-device-test.c | 42 +++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/platform-device-test.c index ea05b8785743..c8d4b0a385f2 100644 --- a/drivers/base/test/platform-device-test.c +++ b/drivers/base/test/platform-device-test.c @@ -3,6 +3,8 @@ #include #include +#include +#include #include #define DEVICE_NAME "test" @@ -217,7 +219,45 @@ static struct kunit_suite platform_device_devm_test_suite = { .test_cases = platform_device_devm_tests, }; -kunit_test_suite(platform_device_devm_test_suite); +static void platform_device_find_by_null_test(struct kunit *test) +{ + struct platform_device *pdev; + int ret; + + pdev = platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret = platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + KUNIT_EXPECT_PTR_EQ(test, of_find_device_by_node(NULL), NULL); + + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_of_node(&platform_bus_type, NULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_fwnode(&platform_bus_type, NULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_acpi_dev(&platform_bus_type, NULL), NULL); + + KUNIT_EXPECT_FALSE(test, device_match_of_node(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_fwnode(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_dev(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_handle(&pdev->dev, NULL)); + + platform_device_unregister(pdev); +} + +static struct kunit_case platform_device_match_tests[] = { + KUNIT_CASE(platform_device_find_by_null_test), + {} +}; + +static struct kunit_suite platform_device_match_test_suite = { + .name = "platform-device-match", + .test_cases = platform_device_match_tests, +}; + +kunit_test_suites( + &platform_device_devm_test_suite, + &platform_device_match_test_suite, +); MODULE_DESCRIPTION("Test module for platform devices"); MODULE_AUTHOR("Maxime Ripard ");