From patchwork Tue Jan 7 21:41:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Daley X-Patchwork-Id: 13929627 X-Patchwork-Delegate: kuba@kernel.org Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DC5F1E0084 for ; Tue, 7 Jan 2025 21:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286128; cv=none; b=jIyjI5h78pkoSVLLihBnvFFAnOlod67qhqZEHVNt+Sq5lravimJ21TaruOqYhhf3U74Y+6aYHCPEBYCTFiofp1uzwHs+5bhda2hXF2tD7gsnqVs4PVQqkkQPgxJGwrHoRPk6HCw8FuHGJFWxEqe9m7LrqwL1F4J66JuFQeSYH0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286128; c=relaxed/simple; bh=kj3XAeBVudwD3vo/0EEH75kWe1rcErK6eALotHsNWn4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t5BGdvzHhtgKlrXVV47X1Dc/6X0GYwxjePntml4N0Fmuydkxspf14x6FYt/RWhflPjoBRtjktjs9ZT9OzcLKQAKlt7bn2EuUjV++Jy5CNa+LuRA2tAu74d70kQvAp8KcHzAvZr1JpnHU+BLdzakA3RtcWoRwuZ6QM3pOffCpjSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b=Ei6Y3Qc7; arc=none smtp.client-ip=173.37.142.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="Ei6Y3Qc7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=3131; q=dns/txt; s=iport; t=1736286126; x=1737495726; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VPokXnowB9WV2FbOa7AooedmIXf8/hgdXZkkQ7irUCc=; b=Ei6Y3Qc7g2K6XwpnVfe5hp8jjklNG/ZhHRlLj30xH4/lm7L0fHH+79UO OayN7oxWi149lgcVYf1/y8MYH4CuotP8kUyWVyNDVYP1VJZL/YwvyxmQB OL0qVKvWuKkcEX25RiNSdBYJaI+gRsvV1HXk+y4yNvSNhur9zJ+G85x/r 8=; X-CSE-ConnectionGUID: mYhYkXiqSdWbpfhhTh4pfg== X-CSE-MsgGUID: ZG8JkHBPRLaFskoY2TEa9Q== X-IPAS-Result: A0AeAACVnn1nj5AQJK1aHQEBAQEJARIBBQUBggAHAQsBhBlDSI1Rpw2BJQNWDwEBAQ9EBAEBhQcCinQCJjUIDgECBAEBAQEDAgMBAQEBAQEBAQEBAQsBAQUBAQECAQcFFAEBAQEBATkFSYYIhlsCAQMnCwFGEFErKwcSgwGCZQOxQoF5M4EB3jOBbYFIAYVqh19whHcnG4FJRIEVgTuCLYsHBIIzhTaGZocfkARIgSEDWSwBVRMNCgsHBYE5OgMiCwsMCxQcFQIVHxIGEQRuRDeCRmlLNwINAjWCHiRYgiuEXIRHhFiCS1WCSIIXfIEdgkFVQAMLGA1IESw3Bg4bBj5uB5p1PINuAYEOfJUVkh+LcpURhCWBY59jGjOEBJQGkkmYfCKCNqFvhGaBaAE4gVszGggbFYMiUhkPji0NCbknJTI8AgcLAQEDCZFVAQE IronPort-Data: A9a23:xUKm4agoAEWwiO9LiuDXT/M2X161uhAKZh0ujC45NGQN5FlHY01je htvCmyFa/6INjf2c4sgaYvipxxXupLRyINlT1Zr/nwxFXljpJueD7x1DKtf0wB+jyHnZBg6h ynLQoCYdKjYdleF+FH1dOCn9SQkvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYcAbeKRW2thg vus5ZSFULOZ82QsaD9Msvrc8EkHUMna4Vv0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL 87fzKu093/u5BwkDNWoiN7TKiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JAAatjsAhlqvgqo Dl7WTNcfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQqflO0q8iCAn3aMqUdy+ZGAlFP7 McUFzoVYBCDu+Lq2Ly0H7wEasQLdKEHPasWvnVmiDWcBvE8TNWbHOPB5MRT23E7gcUm8fT2P pVCL2ExKk2eJUQTZj/7C7pm9Ausrnv4cztUoVaYjaE2+GPUigd21dABNfKJIozbFJ4IwBnwS mTuzUupIBI6HuSl7TOr6XGrt7XzsCqqYddHfFG/3qU32ALInDN75ActfVeyv/S8okK3Rd9aL 0sa5mwooLRa3EGnU9z0TRCkiHGDuREYVpxbFOhSwAKQwKP84AuDAGUACDlbZ7QOvck6XzE1l VmEg9/kGxRrrbuTD3mdnp+MpDm/Pyk9N2IOZSYYCwAC5rHLpowvgh/RZshsHbTzjdDvHzz0h TeQo0ADa647hMoP0eC/uFvAmT/p/sePRQ8u7QKRVWWghu9kWGK7T4mZ6WnY3fdZF4qmREGPv Hg4m5SG4u9bWPlhixexaOkKGbio4dOMPzvdnUNjEvEdG9KFpSfLkWd4vm0WGat5DvvobwMFd 6M6hO+w2HOxFCbyBUOUS9vtYyjP8UQGPY+8PhwzRoEVCqWdjCfdoElTibe4hggBanQEn6AlI ou8es2xF3scAqkP5GPpHLlEge9wnnhhlT+7qXXHI/KPjOT2iJm9FOZtDbdyRrpihE95iFyPq o8Ba5viJ+t3D72mPnO/HXEvwaAidiVjWsus9KS7h8aIIxFtHyk6GuTNzLY6M41jlOI9qws71 i/VZ6Os83Km3SevAVzTMhhLMeq/Nb4h9ihTFXJ3Yj6VN40LPd3HAFE3K8BvJeFPGS0K5aIcc sTpjO3ZW6sREmqbqmp1gFuUhNUKSSlHTDmmZ0KNCAXTtbY5L+AV0rcIpjfSyRQ= IronPort-HdrOrdr: A9a23:+g8sQ6vmM+NS+kU0JeSp33cb7skDcdV00zEX/kB9WHVpmwKj+P xG+85rsiMc5wxxZJhNo7290ey7MBHhHP1OkO0s1MmZPDUO0VHAROoJ0WKh+UyEJ8SUzIBgPM lbH5SWcOeAbmSTSa3BkXCF+xFK+qjgzJyV X-Talos-CUID: 9a23:vt8ClG8JAyz19XkMZAOVv0slGvEmQnzE93vvKVe2CWZVSOGNR1DFrQ== X-Talos-MUID: 9a23:2Iwx6wUdrWAHl9Dq/A3D1BNhFO1Q2YCnJlsOlqRch+SNZBUlbg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.12,296,1728950400"; d="scan'208";a="408993567" Received: from alln-l-core-07.cisco.com ([173.36.16.144]) by alln-iport-6.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 07 Jan 2025 21:42:05 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-l-core-07.cisco.com (Postfix) with ESMTP id 5AC2D180001D1; Tue, 7 Jan 2025 21:42:05 +0000 (GMT) Received: by cisco.com (Postfix, from userid 392789) id 31A3220F2004; Tue, 7 Jan 2025 13:42:05 -0800 (PST) From: John Daley To: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Cc: John Daley , Nelson Escobar Subject: [PATCH net-next v2 1/3] enic: Move RX coalescing set function Date: Tue, 7 Jan 2025 13:41:57 -0800 Message-Id: <20250107214159.18807-2-johndale@cisco.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20250107214159.18807-1-johndale@cisco.com> References: <20250107214159.18807-1-johndale@cisco.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-l-core-07.cisco.com X-Patchwork-Delegate: kuba@kernel.org Move the function used for setting the RX coalescing range to before the function that checks the link status. It needs to be called from there instead of from the probe function. There is no functional change. Co-developed-by: Nelson Escobar Signed-off-by: Nelson Escobar Co-developed-by: Satish Kharat Signed-off-by: Satish Kharat Signed-off-by: John Daley --- drivers/net/ethernet/cisco/enic/enic_main.c | 60 ++++++++++----------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 9913952ccb42..957efe73e41a 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -428,6 +428,36 @@ static void enic_mtu_check(struct enic *enic) } } +static void enic_set_rx_coal_setting(struct enic *enic) +{ + unsigned int speed; + int index = -1; + struct enic_rx_coal *rx_coal = &enic->rx_coalesce_setting; + + /* 1. Read the link speed from fw + * 2. Pick the default range for the speed + * 3. Update it in enic->rx_coalesce_setting + */ + speed = vnic_dev_port_speed(enic->vdev); + if (speed > ENIC_LINK_SPEED_10G) + index = ENIC_LINK_40G_INDEX; + else if (speed > ENIC_LINK_SPEED_4G) + index = ENIC_LINK_10G_INDEX; + else + index = ENIC_LINK_4G_INDEX; + + rx_coal->small_pkt_range_start = mod_range[index].small_pkt_range_start; + rx_coal->large_pkt_range_start = mod_range[index].large_pkt_range_start; + rx_coal->range_end = ENIC_RX_COALESCE_RANGE_END; + + /* Start with the value provided by UCSM */ + for (index = 0; index < enic->rq_count; index++) + enic->cq[index].cur_rx_coal_timeval = + enic->config.intr_timer_usec; + + rx_coal->use_adaptive_rx_coalesce = 1; +} + static void enic_link_check(struct enic *enic) { int link_status = vnic_dev_link_status(enic->vdev); @@ -1901,36 +1931,6 @@ static void enic_synchronize_irqs(struct enic *enic) } } -static void enic_set_rx_coal_setting(struct enic *enic) -{ - unsigned int speed; - int index = -1; - struct enic_rx_coal *rx_coal = &enic->rx_coalesce_setting; - - /* 1. Read the link speed from fw - * 2. Pick the default range for the speed - * 3. Update it in enic->rx_coalesce_setting - */ - speed = vnic_dev_port_speed(enic->vdev); - if (ENIC_LINK_SPEED_10G < speed) - index = ENIC_LINK_40G_INDEX; - else if (ENIC_LINK_SPEED_4G < speed) - index = ENIC_LINK_10G_INDEX; - else - index = ENIC_LINK_4G_INDEX; - - rx_coal->small_pkt_range_start = mod_range[index].small_pkt_range_start; - rx_coal->large_pkt_range_start = mod_range[index].large_pkt_range_start; - rx_coal->range_end = ENIC_RX_COALESCE_RANGE_END; - - /* Start with the value provided by UCSM */ - for (index = 0; index < enic->rq_count; index++) - enic->cq[index].cur_rx_coal_timeval = - enic->config.intr_timer_usec; - - rx_coal->use_adaptive_rx_coalesce = 1; -} - static int enic_dev_notify_set(struct enic *enic) { int err; From patchwork Tue Jan 7 21:41:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Daley X-Patchwork-Id: 13929628 X-Patchwork-Delegate: kuba@kernel.org Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1351E04B8 for ; Tue, 7 Jan 2025 21:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286128; cv=none; b=ID3V5dDZ7l4hxcm6UoOPIgTNzQB9yKTWs8Usgy70mrDmRI9HdhUCd+BxBk3sEPE+GrUBq7s4Te1ScvNg09IL9zkLzAmYZWZh5yGpEJonlWHUmbapXELGdSx1O998tmbSJ+livgJD+ZZkR+EUkBcfroExhOgxNP29bvt/bnMbdQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286128; c=relaxed/simple; bh=5sVRjmx+NkyHd1IX9h15MHb85uCWuVplGXvapP2GtJQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=E6F1x8amvwknfrFXE9qm1DzJInL/nSYBUfTKQl9ng9xGKEjfSCShZzp2cU2xjYFdlolMSuYpGV93/8zFllsBiKjpnJwavMfcbK/e4vd3aV8mPBx3baUuJcbYZH/VJhWZo7Ll0eBdnkSgZZ8RknSKyVapwBzlUbljErGVdLcCw/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b=cSxYcAgd; arc=none smtp.client-ip=173.37.142.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="cSxYcAgd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=1731; q=dns/txt; s=iport; t=1736286126; x=1737495726; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pPrpfxg0BcN3JWGtlnUVMZeSSERKEUWnLhK9TVY3w/Q=; b=cSxYcAgdNal7XFb0IkyozvNsC0eUu6UJHcatlRZDLyaRvLiolIYSZG/9 ver2rGG9crKERycYO/5iJDv59c5D1K33sjOzCban2pE27Fimq6MevFGZ/ CK04h5durLNwCCrvgxhuopig9+zSllUNsG14AA0+mMIWtw28jEnHReJmd Q=; X-CSE-ConnectionGUID: QzrBSbgXQcK8AE0JITnWew== X-CSE-MsgGUID: Is2Ef0EASdyEyxwBVEq1RQ== X-IPAS-Result: A0BaAACVnn1n/5QQJK1aHAEBAQEBAQcBARIBAQQEAQGCAQUBAQsBgkqBT0NIjVGIcp4bFIERA1YPAQEBD0QEAQGFBwKKdAImNgcOAQIEAQEBAQMCAwEBAQEBAQEBAQEBCwEBBQEBAQIBBwWBDhOGCIZbAgEDJwsBNBIQUSsrBxKDAYJlA7FCgXkzgQHeM4FtgUgBhWqHX3CEdycbgUlEhA5vhAogZoV3BIdpnglIgSEDWSwBVRMNCgsHBYE5OgMiCwsMCxQcFQIVHgESBhEEbkQ3gkZpSzcCDQI1gh4kWIIrhFyER4RYgktVgkiCF3yBHYMWQAMLGA1IESw3Bg4bBj5uB5p1PINuAYEONUc1pn+hA4QlgWOfYxozqlOYfCKkJYRmgW4BNIFZMxoIGxWDIlIZD44tFrknJTI8AgcLAQEDCY9YgX0BAQ IronPort-Data: A9a23:Q3nYf69twATn7qW7TQX+DrUDo3+TJUtcMsCJ2f8bNWPcYEJGY0x3m zFKUWqDbPaJYzD0f9gjOtjl8khTvJ+BxtAyQQBqpXxEQiMRo6IpJzg2wmQcns+2BpeeJK6yx 5xGMrEsFOhtEDmE4E/rauW5xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOdRbrRA2bBVOCvT/ 4qoyyHjEAX9gWMsazpLs/jrRC5H5ZwehhtJ5jTSWtgT1LPuvyF9JI4SI6i3M0z5TuF8dsamR /zOxa2O5WjQ+REgELuNyt4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5nXBYoUnq7vh3S9zxHJ HqhgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/wmWeG0YAzcmCA2kPL5cywex4MVhF1 qwxBWgvTyyFuO+plefTpulE3qzPLeHiOIcZ/3UlxjbDALN/GNbIQr7B4plT2zJYasJmRKmFI ZFHL2MxKk2cM3WjOX9PYH46tOWvhn/zejlVgFmUvqEwpWPUyWSd1ZCxaoaJJITaFZQ9ckCwh 3mc0mqhLzghOM2y2Cqa2EyBn7b1pHauMG4VPPjinhJwu3Wfz3IeDTUaXEW2pP2+hFL4Xd9DQ 2QZ9jcrpLo/6GSkSd7yWxD+q3mB1jYfRtBZO+438geAzuzT+QnxLmECQiRMd58gudM6SCIC0 kKPmZXiBVRHqLSfRHSc3q2ZoTO7JW4eKmpqTSkJUQcI/fH9r4wpyBHCVNBuFOiylNKdJN3r6 zmOqC57g/AYitQGkvziu1vGmDmr4JPOS2bZ+znqY45s1SshDKbNWmBiwQOzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:POdhsa0vP3vVfTLgLg4x8gqjBLUkLtp133Aq2lEZdPWaSKOlfq eV7ZMmPHDP6Qr5NEtMpTnEAtjjfZq+z+8Q3WBuB9eftWDd0QPCRr2Kr7GSpgEIcBeRygcy78 tdmtBFeb7N5ZwQt7eC3OF+eOxQpuW6zA== X-Talos-CUID: 9a23:W4CaxG6Xf3Mlc+F5P9sszVwOMPsvfU3kx1SACmLgK0dVToKYVgrF X-Talos-MUID: 9a23:1gbVlQh687N21haFqxQY9cMpFdwyzqr2JWk2nYQrqtmbHxJdIm6ntWHi X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.12,296,1728950400"; d="scan'208";a="424460889" Received: from alln-l-core-11.cisco.com ([173.36.16.148]) by alln-iport-3.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 07 Jan 2025 21:42:05 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-l-core-11.cisco.com (Postfix) with ESMTP id 60753180001E5; Tue, 7 Jan 2025 21:42:05 +0000 (GMT) Received: by cisco.com (Postfix, from userid 392789) id 386D920F2005; Tue, 7 Jan 2025 13:42:05 -0800 (PST) From: John Daley To: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Cc: John Daley , Nelson Escobar Subject: [PATCH net-next v2 2/3] enic: Obtain the Link speed only after the link comes up Date: Tue, 7 Jan 2025 13:41:58 -0800 Message-Id: <20250107214159.18807-3-johndale@cisco.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20250107214159.18807-1-johndale@cisco.com> References: <20250107214159.18807-1-johndale@cisco.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-l-core-11.cisco.com X-Patchwork-Delegate: kuba@kernel.org The link speed is obtained in the RX adaptive coalescing function. It was being called at probe time when the link may not be up. Change the call to run after the Link comes up. The impact of not getting the correct link speed was that the low end of the adaptive interrupt range was always being set to 0 which could have caused a slight increase in the number of RX interrupts. Co-developed-by: Nelson Escobar Signed-off-by: Nelson Escobar Co-developed-by: Satish Kharat Signed-off-by: Satish Kharat Signed-off-by: John Daley Reviewed-by: Kalesh AP --- drivers/net/ethernet/cisco/enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 957efe73e41a..8109e9c484f6 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -466,6 +466,7 @@ static void enic_link_check(struct enic *enic) if (link_status && !carrier_ok) { netdev_info(enic->netdev, "Link UP\n"); netif_carrier_on(enic->netdev); + enic_set_rx_coal_setting(enic); } else if (!link_status && carrier_ok) { netdev_info(enic->netdev, "Link DOWN\n"); netif_carrier_off(enic->netdev); @@ -3063,7 +3064,6 @@ static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) timer_setup(&enic->notify_timer, enic_notify_timer, 0); enic_rfs_flw_tbl_init(enic); - enic_set_rx_coal_setting(enic); INIT_WORK(&enic->reset, enic_reset); INIT_WORK(&enic->tx_hang_reset, enic_tx_hang_reset); INIT_WORK(&enic->change_mtu_work, enic_change_mtu_work); From patchwork Tue Jan 7 21:41:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Daley X-Patchwork-Id: 13929629 X-Patchwork-Delegate: kuba@kernel.org Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78C8C1F669F for ; Tue, 7 Jan 2025 21:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286130; cv=none; b=D3J9TNlRfus3WaEk3IR2/U6Aw8hF5eKBd9fwhFL1XZ1EsOtdw9069cS8ZfoT959u8RW9JnXwHFIxrhRP+P3BQ7FkZO30wv8bjTtNUA7EElRCL2XJU0+OQo66nDzBWkLD/oe8qbsEoD6w0sf7ShEmOmw8N8R+ZfPm0MnMW4Z9/xA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736286130; c=relaxed/simple; bh=iUoY58RIZOVQIqAdegml532MWvAllJjGVn9/uqyXzIA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X2nBTBqcmAUdFAlgMch2X43LvAggCRUlOV07Yy7DgGp/nwZc3yf6zSP3Lik2htHDUOWawhkKscj6RKDfVAOKutQh5Ao7rSCkpHab0FAX/ItBcXgm6cHaiM6OCqBrpnm2P/JN5FiaB00e3k6E7Ddi7WXFgWlreybNSOMdeZSM7zs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b=VBChtz52; arc=none smtp.client-ip=173.37.142.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="VBChtz52" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=1327; q=dns/txt; s=iport; t=1736286128; x=1737495728; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GMtPWGchlyzSh7QvtH9Gz7IG8sSoEu3RpF2lBteCrX4=; b=VBChtz52OUfpzihVuwunGRQUVL5v5i7hZevESRXxJSvU05H8uItJBfMW R0PfQdW3vswiY/WqgCzkcJ0wgPeWF4ZupvbP6GrwweN0LxFa/EdHHntLN oR+nX2oNMrKsA1eZ+zpETnh34UMH4qIrn9JsBRjaAQWQQVtGSLLgGnHv5 k=; X-CSE-ConnectionGUID: Fg90ojD6QYuLsE5NYHjrdg== X-CSE-MsgGUID: /3/rTzHRQC+9cY9d6q1bOA== X-IPAS-Result: A0CDAACVnn1n/4oQJK1aHQEBAQEJARIBBQUBggEGAQsBgkqBT0NIjVGnDYElA1YPAQEBD0QEAQGFBwKKdAImNgcOAQIEAQEBAQMCAwEBAQEBAQEBAQEBCwEBBQEBAQIBBwWBDhOGCIZbAgEDMgFGEFErKwcSgwGCZQOxQoIsgQHeM4FtgUgBhWqHX3CEdycbgUlEglCBPm+ECoEGhXcEh2meCUiBIQNZLAFVEw0KCwcFgTk6AyILCwwLFBwVAhUeARIGEQRuRDeCRmlLNwINAjWCHiRYgiuEXIRHhFiCS1WCSIIXfIEdgxZAAwsYDUgRLDcGDhsGPm4HmnU8g2+BDnynNKEDhCWBY59jGjOqU5h8IqQlhGaBbgUwgVkzGggbFYMiUhkPji0WuSclMjwCBwsBAQMJj1iBfQEB IronPort-Data: A9a23:nz476qiXBbgb8/ctkZJGPShqX161QxEKZh0ujC45NGQN5FlHY01je htvCGqOa/ncMWX2Lo92bo+w8R8BusPUxtcyS1A6pX8wQyljpJueD7x1DKtf0wB+jyHnZBg6h ynLQoCYdKjYdleF+FH1dOCn9SQkvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYcAbeKRW2thg vus5ZSFULOZ82QsaD9Msvrc8EkHUMna4Vv0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL 87fzKu093/u5BwkDNWoiN7TKiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JAAatjsAhlqvgqo Dl7WTNcfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQqflO0q8iCAn3aMqU29bcvBmNiq 8UpNRQWQ02ltsK02r60H7wEasQLdKEHPasWvnVmiDWcBvE8TNWbGuPB5MRT23E7gcUm8fT2P pVCL2ExKk2eJUQUaj/7C7pm9Ausrnv4cztUoVaYjaE2+GPUigd21dABNfKJIIDWG50Fzx7wS mTuuD++GC0IFOam4nnU+UP9irHWxCnccddHfFG/3rsw6LGJ/UQfAQMbUHO3qOe0j0q5Vc4ZL UEIkgIjobU3/V6mUvHyWBq3pHPCtRkZM/JTDuczwAKA0KzZ50CeHGdsZjdHZMYrq4wwSCAm2 0Ghm87vA3pksNW9UXuX+7GVhSm/NSgcMSkJYipsZQ0I/9XuvqktgR/VCNVuCqi4ipvyAz6Y/ tyRhCE6g7NWiYsA0L+2uAiexTmtvZPOCAUy4207Q16Y0++wX6b9D6TA1LQRxaoowFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:57rYEavWoTr4tt/ibOSGMtYM7skDcdV00zEX/kB9WHVpmwKj+P xG+85rsiMc5wxxZJhNo7290ey7MBHhHP1OkO0s1MmZPDUO0VHAROoJ0WKh+UyEJ8SUzIBgPM lbH5SWcOeAbmSTSa3BkXCF+xFK+qjgzJyV X-Talos-CUID: 9a23:EzMwDG1urXytoR+2a2nzsLxfNM90Knrf4CnpElKcEks0boy1S0Wc9/Yx X-Talos-MUID: 9a23:6RYvRATW/v9J9kFHRXSr33Z4CNVI2Z2FSxEGoMQK5dDdPwtZbmI= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.12,296,1728950400"; d="scan'208";a="424460890" Received: from alln-l-core-01.cisco.com ([173.36.16.138]) by alln-iport-3.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 07 Jan 2025 21:42:05 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-l-core-01.cisco.com (Postfix) with ESMTP id 6666C1800019A; Tue, 7 Jan 2025 21:42:05 +0000 (GMT) Received: by cisco.com (Postfix, from userid 392789) id 3EC8B20F2006; Tue, 7 Jan 2025 13:42:05 -0800 (PST) From: John Daley To: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Cc: John Daley , Nelson Escobar Subject: [PATCH net-next v2 3/3] enic: Fix typo in comment in table indexed by link speed Date: Tue, 7 Jan 2025 13:41:59 -0800 Message-Id: <20250107214159.18807-4-johndale@cisco.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20250107214159.18807-1-johndale@cisco.com> References: <20250107214159.18807-1-johndale@cisco.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Outbound-SMTP-Client: 10.193.184.48, savbu-usnic-a.cisco.com X-Outbound-Node: alln-l-core-01.cisco.com X-Patchwork-Delegate: kuba@kernel.org The RX adaptive interrupt moderation table is indexed by link speed range, where the last row of the table is the catch-all for all link speeds greater than 10Gbps. The comment said 10 - 40Gbps, but since there are now adapters with link speeds than 40Gbps, the comment is now wrong and should indicate it applies to all speeds greater than 10Gbps. Co-developed-by: Nelson Escobar Signed-off-by: Nelson Escobar Co-developed-by: Satish Kharat Signed-off-by: Satish Kharat Signed-off-by: John Daley Reviewed-by: Kalesh AP --- drivers/net/ethernet/cisco/enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 8109e9c484f6..49f6cab01ed5 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -109,7 +109,7 @@ static struct enic_intr_mod_table mod_table[ENIC_MAX_COALESCE_TIMERS + 1] = { static struct enic_intr_mod_range mod_range[ENIC_MAX_LINK_SPEEDS] = { {0, 0}, /* 0 - 4 Gbps */ {0, 3}, /* 4 - 10 Gbps */ - {3, 6}, /* 10 - 40 Gbps */ + {3, 6}, /* 10+ Gbps */ }; static void enic_init_affinity_hint(struct enic *enic)