From patchwork Sun Feb 2 02:11:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 13956411 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A26935942 for ; Sun, 2 Feb 2025 02:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738462319; cv=none; b=QIkFrACFH2u0lH0MsW+FvfS7Ck2U9Oad6rgvOd47tzgT8O2E2mQpUegMvSWm6BNmhIKzwXAdSPmT4rg+mTJ3WqCegsGs8420OPEmQ04pXQ+/ddkdPWl/uUPoy5Wqm1LSR2BQMCEYfV9u5X3rNokKk39zB8HFvysJDT04LM0xg3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738462319; c=relaxed/simple; bh=sqpizqivSNnNKmL7hLRDe0WOca36ulcM0XxJmt0Q+bQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N83jaH1uDPce6LrZaW1h/mFnaG1wT/h0eyM5qE4nK97ZB5iGjynd7iutQZZ0d7+BHs6KRaqgywZ01L2IGQ7cFMhab3FfeeY/C/SoER42FIl/JfNg0Lqx+Kq/DXsFROjxDPrDiNmW520WnYHsXy+2Y+UU6FDEwfjOV88LlHiecls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n/HVkuG0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n/HVkuG0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46EFAC4CED3; Sun, 2 Feb 2025 02:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738462318; bh=sqpizqivSNnNKmL7hLRDe0WOca36ulcM0XxJmt0Q+bQ=; h=From:To:Cc:Subject:Date:From; b=n/HVkuG0az7q9OYVTbNbbQgjpz9zArOBFRbA2uyqU6D5DX5JDdZmWJy8PjEFbszCC VeyvuSLbgGopnXRIY8WyVWKLeSdi58R98bERJJQG+lQJmqxjnBO4l7BZSPbVXTsyCL QJygXwopSVmnL4DZax4omPTS9NffEnyYDiRMT1fCCJIKTcEvhe0VJssLpwBoXQXA7o 2hvtO45DbqNuJHXuBlX+iND2sHZ3T4TC7u/O2ZiLn9OvI5nFKMYYfEo/opnWfIn9mi 5PSFuorgufkHcFURXdBpYpXmsC/gyUBtyyVS7C6balDLptCrlk6VsyMf+dCpokXjDp rV0n2nmvr8Jqw== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, Jakub Kicinski , Michal Kubecek Subject: [PATCH net 1/2] MAINTAINERS: add entry for ethtool Date: Sat, 1 Feb 2025 18:11:54 -0800 Message-ID: <20250202021155.1019222-1-kuba@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Michal did an amazing job converting ethtool to Netlink, but never added an entry to MAINTAINERS for himself. Create a formal entry so that we can delegate (portions) of this code to folks. Over the last 3 years majority of the reviews have been done by Andrew and I. I suppose Michal didn't want to be on the receiving end of the flood of patches. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- CC: Michal Kubecek I emailed Michal a few days ago and didn't hear back. Michal, please LMK if you'd like to be added as well! --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ce92c8a3e3ce..4e701b9a57e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16459,6 +16459,16 @@ F: include/net/dsa.h F: net/dsa/ F: tools/testing/selftests/drivers/net/dsa/ +NETWORKING [ETHTOOL] +M: Andrew Lunn +M: Jakub Kicinski +F: Documentation/netlink/specs/ethtool.yaml +F: Documentation/networking/ethtool-netlink.rst +F: include/linux/ethtool* +F: include/uapi/linux/ethtool* +F: net/ethtool/ +F: tools/testing/selftests/drivers/net/*/ethtool* + NETWORKING [GENERAL] M: "David S. Miller" M: Eric Dumazet From patchwork Sun Feb 2 02:11:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 13956412 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A49013AF2 for ; Sun, 2 Feb 2025 02:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738462319; cv=none; b=b+6iDSnBNnrWVpHW+vyqUCDfPbNaaAbMPGY/gamLo1kkemNEDBrPwzTmTFyItiaOZQpPzzH5DOuwXgCsLIu2UvImm2qkpm+AI+TTDrOlFI26t9qN08kelPAhW9B7vA13iz7S7/G33BKJKXvgWQ3RMww1gGQmZUh2woGxHqz0Dfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738462319; c=relaxed/simple; bh=DTSiIJ2XZjL1OjTPQKuFZ6eL9+GSCYb3zVNf86aycyo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hWO7/Uwl2XDv4IvS6S4fdSuZ1kWxEn5/0VAvrffkpMlFSG1s7zi2uVfbN7N3j4jbVoQRfi+VQQWWws16fjC5rXKbWdOGg9wKUFW12h7VU6F9YCDQqmt8j21f687l4Fp/Z7BWHCTrqdR2A/gTSGv+ov3YTEs9VuVWsd/B5WtINKc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gBdfMnq1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBdfMnq1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA665C4CEE3; Sun, 2 Feb 2025 02:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738462319; bh=DTSiIJ2XZjL1OjTPQKuFZ6eL9+GSCYb3zVNf86aycyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gBdfMnq1IfxOKF+Q5Yq3ymw7uH0xXRgSPHZN4EhP9IiGIQnH/EwdgQIA3kulFiuOt ZBy7Ka8VCjIGFgKGjk4rD+foQ9gE1xrA2fbVHgdEzQSZa12K4VPIaPoI+tPSkdyx9K ZuamVdESOY8ZOLjIng20p1UcyE1UM94hPedxJs2Hk/sIZ/9d1D1xgVb0vIUlnp6BMQ J4hADsbCY1v7eaWc1p389+KrtppvA8sGENahZpDdBH7IWLWm9tuAKG2wa+bF5/u89k UnAWaheDVFjml6vG25NYYbOMxBP3hRhG8dRizLCCPOULSSmbIzGGCk6hIuhsSP/pmb +boESHyaYkGBg== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, Jakub Kicinski Subject: [PATCH net 2/2] MAINTAINERS: add a sample ethtool section entry Date: Sat, 1 Feb 2025 18:11:55 -0800 Message-ID: <20250202021155.1019222-2-kuba@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250202021155.1019222-1-kuba@kernel.org> References: <20250202021155.1019222-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org I feel like we don't do a good enough keeping authors of driver APIs around. The ethtool code base was very nicely compartmentalized by Michal. Establish a precedent of creating MAINTAINERS entries for "sections" of the ethtool API. Use Andrew and cable test as a sample entry. The entry should ideally cover 3 elements: a core file, test(s), and keywords. The last one is important because we intend the entries to cover core code *and* reviews of drivers implementing given API! Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- This patch is a nop from process perspective, since Andrew already is a maintainer and reviews all this code. Let's focus on discussing merits of the "section entries" in abstract? --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4e701b9a57e4..9bf31ba720b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16469,6 +16469,12 @@ F: include/uapi/linux/ethtool* F: net/ethtool/ F: tools/testing/selftests/drivers/net/*/ethtool* +NETWORKING [ETHTOOL CABLE TEST] +M: Andrew Lunn +F: net/ethtool/cabletest.c +F: tools/testing/selftests/drivers/net/*/ethtool* +K: start_cable_test + NETWORKING [GENERAL] M: "David S. Miller" M: Eric Dumazet