From patchwork Thu Feb 6 04:30:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Hendry X-Patchwork-Id: 13962173 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDEC165F1E; Thu, 6 Feb 2025 04:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816291; cv=none; b=bjFKT0A6+J95gWeqmJVG7Ept4+ZJSa3q/klGjFzt64q9DGbtpV0GFkrtT055RgnyOzJTs518ArwkkJTidv2dBXgs+W7UsVw4eBiYvNKwXz5GirjhQfsPVl/mEZro0/mN9VJrcspEmevGSgiprR5EShHR/PiFxJ4pYnzp78G+vps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816291; c=relaxed/simple; bh=s/p50GMdkJD/uK8tT7seihpuPufOSshH1O9kS0ZIigI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c/nZUNPgmmaxsgwKo//LuO9EGgmQAH7al/elwsU4WjQi3hkb9Qf2wbmeX8aw/h+QMls56I1GaBttLvH3Q+gRZ25KWPiJK9+CEBzqCd9x2Ts3zJwF6NAmI/0sguakI356tJ58dWd5RDgVz6iWuD7HqLmFl37n1NaOtb2XZcZVdT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gRdpF9k4; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gRdpF9k4" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2f9f5caa37cso1552056a91.0; Wed, 05 Feb 2025 20:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738816289; x=1739421089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k0SAvsOTRWQXRI9Em9YHS8hKkjTqRpY3I22VfT0ZvIM=; b=gRdpF9k4WRfDbq3+PlugwATm8Rgyn+tiijYz/OFE96KAFlbgGcMUW7xLUZOaxvfahb HTeWcrhGBLP1jXFICkMqY9BHnOoMBSEMOzOnyfTh9eN+ON7l7PRKX3WRPDFLGZktopVb lfUnjYBJCvcUAfXVH5VOzz3Rl6RxuNJgop3v1KnxfHJdLMmIaXsAEu7W88a0r8K09R2l 7KseSqSdGwBz8att5JFcxYkxzWVFFrETocJsWcJSUBcB/MuUY2ec/FTEQCgsqY+ya5ty YMkJJacA5aOVFJ2vEW80hydR9bWvZmHughL8Wu+HhHpdNAsqexkdWTA2nApnWZK93GKE 1pCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738816289; x=1739421089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k0SAvsOTRWQXRI9Em9YHS8hKkjTqRpY3I22VfT0ZvIM=; b=g6LrLt+6MJl0V/8LYXcaltdpPkJBkF64AhlCQ/XDQnjSm9Ocoio82tLLDu9IyVUA87 SzZn4FuXPJRUVDtQrfrpRFzmB11kz5soawFYQL6v6kR+zdiFUdZvdnQ4LXWxddrGbRyZ ZR3K8CvFNv5ldjLfjnavgjHatd7pCkHLYSJl6YbdxdS5KF17ItAts+6FRz2zFIa6x2Gq eYG9VSzl+6EVPZZiwwAdWTWh9vR/5vTXXMoERgcXHlVupVEWDWnMnDjeve8sRfhruIoF 9pBRatBKPtrjhBVwJK3xZLXdYLpKl1iSyQLjHL9AR4noaE1s6Mv/I8a84YRm555PnniV SpYw== X-Forwarded-Encrypted: i=1; AJvYcCUM9K58bPXbOUYPHLagvB9eOjE0oG1dNBjhkapv58PzUePmiBOdgLzrKZp7h5IoMUCop+2IIiLe@vger.kernel.org, AJvYcCV3/A9YTFZ36bK5iDgS7zadpGK7NxPt909jdjyVtikbR9SOiJ1RmU+erBGIJ2VvogBj+V3aTtMqkq/7MPo=@vger.kernel.org X-Gm-Message-State: AOJu0YxzHQkvupOYfh0tvljWhTqV8NKtUykymtkFMeDElvwqXCEItwlI Gsvg6qo8g4JYiZS678PIdfb1FLSVVJuAMxAAFEgn4jC73ASHserm X-Gm-Gg: ASbGncvWh9jQVZWAEyzD+jXMNjHyDCooQHI+q+9OZVTU3L0NeWwnd7okaSpj0p0z5Vc Dw7DyzhHQgt6cseCfY8dGy/WEb7auBXVGV3cNyiT7RATJ59ZpatJH2kIpT3QD/tWCZFwrbAWwhV SS//JcdDNqDsiJ4jHSoLbVx1B4Cz98MDGLD2hCm6Jolc3y9KgjaSXEZu0gsaMIAK/vQw/OYBZaZ iplMpSODySkH8ChYMx0HM94vYDM82itd8OOwYJ9U2AM8grlb0uCjCnowiqfjKbNlRAd6xmqwgfi NOHbpWrDfbTKUU2Eb+5WRl+YhSNZksL7WJc= X-Google-Smtp-Source: AGHT+IFUUoWJFIWRIXusIa1oi7pVPGN40EKshfRy08gExMPI9Mo0nnrJY1V/K1BSAZ+kq2+F7+B9JA== X-Received: by 2002:a05:6a00:4c81:b0:725:de58:b2ea with SMTP id d2e1a72fcca58-73042a6ee1dmr3855687b3a.6.1738816289103; Wed, 05 Feb 2025 20:31:29 -0800 (PST) Received: from localhost.localdomain ([205.250.172.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048c162f6sm305013b3a.143.2025.02.05.20.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 20:31:28 -0800 (PST) From: Kyle Hendry To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: Kyle Hendry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] net: dsa: b53: Indicate which BCM63268 port is GPHY Date: Wed, 5 Feb 2025 20:30:45 -0800 Message-ID: <20250206043055.177004-2-kylehendrydev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206043055.177004-1-kylehendrydev@gmail.com> References: <20250206043055.177004-1-kylehendrydev@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Add a gphy mask member and initialize for BCM63268. Signed-off-by: Kyle Hendry --- drivers/net/dsa/b53/b53_common.c | 3 +++ drivers/net/dsa/b53/b53_priv.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 79dc77835681..06739aea328d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2319,6 +2319,7 @@ struct b53_chip_data { const char *dev_name; u16 vlans; u16 enabled_ports; + u16 internal_gphy_mask; u8 imp_port; u8 cpu_port; u8 vta_regs[3]; @@ -2466,6 +2467,7 @@ static const struct b53_chip_data b53_switch_chips[] = { .dev_name = "BCM63268", .vlans = 4096, .enabled_ports = 0, /* pdata must provide them */ + .internal_gphy_mask = BIT(3), .arl_bins = 4, .arl_buckets = 1024, .imp_port = 8, @@ -2642,6 +2644,7 @@ static int b53_switch_init(struct b53_device *dev) dev->num_vlans = chip->vlans; dev->num_arl_bins = chip->arl_bins; dev->num_arl_buckets = chip->arl_buckets; + dev->internal_gphy_mask = chip->internal_gphy_mask; break; } } diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h index 9e9b5bc0c5d6..cd565efbdec2 100644 --- a/drivers/net/dsa/b53/b53_priv.h +++ b/drivers/net/dsa/b53/b53_priv.h @@ -128,6 +128,7 @@ struct b53_device { /* used ports mask */ u16 enabled_ports; + u16 internal_gphy_mask; unsigned int imp_port; /* connect specific data */ From patchwork Thu Feb 6 04:30:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Hendry X-Patchwork-Id: 13962174 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60C291862BD; Thu, 6 Feb 2025 04:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816293; cv=none; b=GIJaY7zPEMFwphWJ7THtC2qjWzjahAnJnSSBMCNsML1Fw2WJYw34IegVlRjy2Sq8ls1eWqel8dWx6BwvyFMQJJYTCSf+KuCsATKwPJXq/zw1a5HDvB3hY4oZ/r+aD92i5iDORoVn+AjyZ062vh5S4Jqhpx8xRI6KgB+6XU9ag2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816293; c=relaxed/simple; bh=B/54zHisFFydosnnsHrYfaMylY07fnwwe1l9UqL1r8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KOYuaYHU4pU/m+5B3oIhhIMQjQeTk36mK+7BcVg22Ycuiuzof//2BbpHzNplv3LBGrlmzEhk07doS155hZnTITnm1+kn3Xgyz3u2lRnVxjpo1A0aprXcszkXXAoPYugMMPGl4LOCd0/0d/1qlWHKKcL8oLTFj77a3FSX6NOlwaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AQl5bccX; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AQl5bccX" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2f9d3d0f55dso631444a91.1; Wed, 05 Feb 2025 20:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738816291; x=1739421091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GmrgzTuzxI4DkOliZxCFpnbS2H5tkr7sWJ12HUTrkek=; b=AQl5bccXGGK2B3twIrR95ymObr+sQguECsjr+rXfnlHYCT//MVvBUKqEhcKpEMfumz YrkcL/UqueqdV5HvdRMuOyybDqyM3GQziTgLSlkPw0SqvJBaimON8XA6EavPzwQlVNQC KMl8Ia5aczJocSsS6o8F0xksW4GAu7JT8EbNnea4JyiKhPeJqNOh/m9d/8rd7aCD7/J1 9Sx5jb5eaZbaGp29ZJQnx1FoGYDnpCgcEa6gbP6BfY00cnPFzqLCWl+GD5wHdWKNZdAw 495qdjkhOTVIL3HDSi2MKi9LSMbAwDLbWUN6OupaJ9FfmmBTR61k56h3tiRlHcD4ttsA yCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738816291; x=1739421091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmrgzTuzxI4DkOliZxCFpnbS2H5tkr7sWJ12HUTrkek=; b=YUlv9W47hYxlewQZ+LghecyijTkifVKQCGLee86PF5vGhAgLB4mf5UsjrTiWNK1r72 h6TtcjqJAPwd1mGHUciV/x7OsE+aK+KK19nrxmN61fn+j9X9ynlczuG2AygPxX/YazRX fV+xrJYckqzNe7YGC+ZB6Ir/clvpa2CYz8KtxJxNeWm9RvGvVsoz8UBjAdotnzpcq3Se 8ozD+lBrc/j42MOupEJU7QirlW1iothdydHey0gzXD6RfUD78+3osHya3HH72WECv1eW sEi9Vs8LFRQQLN7ARGobBTNHaXi8fwLBwfRsIvEno+8I883Wk1WeYNhM2UOrchjpgaHW cT9w== X-Forwarded-Encrypted: i=1; AJvYcCXWqrTDMRgydrDEmmpWPwCxEvg3Crz1EbWatI7Jt+BgYCD+5CmUawj0uBN114jI4LXT8DjZR/UZ@vger.kernel.org, AJvYcCXl1a53vbBcE5KsR6pbYdnr1KTMLSnTuEZx0fsQS9mXzWj8739MxacDD/nTRE+tXmmTmbkpZqJ6+wu7zMY=@vger.kernel.org X-Gm-Message-State: AOJu0YxIvW1lbSksw3wsVOlDnf+SFJsBTn2FK9P+KVu8PRiKexX4UjHc 4jJVneajdqK+g4mV80Xm64D+nr/8oib0hLXhqX+yvoVi+qMTnLbK X-Gm-Gg: ASbGncvRnnOie3wfR78lQ4hPObH/yvyLqex2GVuUyBRCCWR1CA/lV24diD4YGIgWt63 4R/aby52p3qrO4LWfDyv8ullF0mhxiCmOuyN19CW5kstYxB6N0CvlP6X0RZ752kLwXZ05htYhgR 1evLsiyEMV4RZZelTJf1hpwmftMVVPER+wwrHSmMTs8bUlIlYngrS53HjbpNq+uU8v6SuhE5ASL 5WQzwrUWWoCACzHKF+TwngRAuhlujHPhWuP74M4sYhyp0S0sjRRSWNnD+6qRafvc372AU77zgKG 6Cs+IDDrgFQLYl+Fad6TfbCm/60ON23EbTE= X-Google-Smtp-Source: AGHT+IFPaZen2nMZZqplQOVhlWKjL7qWYOlES5pIYgvdbjFcB92j9+0qa2y53nOssJRgqz6zeR5xbg== X-Received: by 2002:a05:6a00:6018:b0:724:bf30:3030 with SMTP id d2e1a72fcca58-73034fbc86bmr9507529b3a.0.1738816291568; Wed, 05 Feb 2025 20:31:31 -0800 (PST) Received: from localhost.localdomain ([205.250.172.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048c162f6sm305013b3a.143.2025.02.05.20.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 20:31:31 -0800 (PST) From: Kyle Hendry To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: Kyle Hendry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] net: dsa: b53: mmap: Add gphy control register as a resource Date: Wed, 5 Feb 2025 20:30:46 -0800 Message-ID: <20250206043055.177004-3-kylehendrydev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206043055.177004-1-kylehendrydev@gmail.com> References: <20250206043055.177004-1-kylehendrydev@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Give b53 driver access to the gphy control register by passing it in as an optional second reg in the device tree. Signed-off-by: Kyle Hendry --- drivers/net/dsa/b53/b53_mmap.c | 8 +++++++- include/linux/platform_data/b53.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index c687360a5b7f..8157f9871133 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -28,6 +28,7 @@ struct b53_mmap_priv { void __iomem *regs; + void __iomem *gphy_ctrl; }; static int b53_mmap_read8(struct b53_device *dev, u8 page, u8 reg, u8 *val) @@ -251,7 +252,7 @@ static int b53_mmap_probe_of(struct platform_device *pdev, struct device_node *of_ports, *of_port; struct device *dev = &pdev->dev; struct b53_platform_data *pdata; - void __iomem *mem; + void __iomem *mem, *gphy_ctrl; mem = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mem)) @@ -266,6 +267,10 @@ static int b53_mmap_probe_of(struct platform_device *pdev, pdata->chip_id = (u32)(unsigned long)device_get_match_data(dev); pdata->big_endian = of_property_read_bool(np, "big-endian"); + gphy_ctrl = devm_platform_ioremap_resource(pdev, 1); + if (!IS_ERR(gphy_ctrl)) + pdata->gphy_ctrl = gphy_ctrl; + of_ports = of_get_child_by_name(np, "ports"); if (!of_ports) { dev_err(dev, "no ports child node found\n"); @@ -312,6 +317,7 @@ static int b53_mmap_probe(struct platform_device *pdev) return -ENOMEM; priv->regs = pdata->regs; + priv->gphy_ctrl = pdata->gphy_ctrl; dev = b53_switch_alloc(&pdev->dev, &b53_mmap_ops, priv); if (!dev) diff --git a/include/linux/platform_data/b53.h b/include/linux/platform_data/b53.h index 6f6fed2b171d..ed73287e8ac5 100644 --- a/include/linux/platform_data/b53.h +++ b/include/linux/platform_data/b53.h @@ -32,6 +32,7 @@ struct b53_platform_data { /* only used by MMAP'd driver */ unsigned big_endian:1; void __iomem *regs; + void __iomem *gphy_ctrl; }; #endif From patchwork Thu Feb 6 04:30:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Hendry X-Patchwork-Id: 13962175 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060D318BBB9; Thu, 6 Feb 2025 04:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816296; cv=none; b=kkRfr3X/ZB/FHCIC/BOaMOcRgqxQ4a7OHK+LD73qUjHiJxrV49O2x0WtY8vFpHpv/U+1Fs0YybwMdpLBFfP7k1dFn79LXXq8ADNAyeRwXS55P85JJ8SAWVR2gXXM20udyCiZG0kbPIWor9V7F4jWGW5Q3kF3p3SKIoJBLa/BVvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816296; c=relaxed/simple; bh=GwiQox4X1/Qh/TsPzO4xW5aZruZo+Lu3RYka/ChKLKA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M++BoeDV6ty26wb0Por8vAoFJ7ND2Y6JFykFvONMVPg3ujWYTpLLAiTBnSc8w/m5YOYnj1DQvjRHUTUC4znYMzKPqrNMAay6Um2hxHb7xKSIBPJ1z6f9ieS+LwjXcaZWzOilXdYJeYUSBDT5VzGa8FiIHw2yzp0X39oxF7Ra9ho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HR8I47Pl; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HR8I47Pl" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2f9d17ac130so589972a91.3; Wed, 05 Feb 2025 20:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738816294; x=1739421094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/iia6e3VwJ3mqPG8y4gzge3wzg5w4QmfPYSP+uThGj0=; b=HR8I47Pli9BtB6bS9Z9NmRb8gt7LCiTHdvzFW3L+EnD6KeRDVHTV6uoBZgGom+V6j2 lRLN6jzpSLdVGoBm/Mj1LfZhFeHX9W626TGDLS4cew8aaQFCv4Fda9azxLhtlPBR8kR0 buFeYR4kQDNLgkyyR9AjKBQI+gDQhcVzYCeqSvfvDSIBqkaHoVdim0/3eVXOBMaB485I MuZaMD1t0KlYiYh8IIr6NZ7MlV466P/LSHNPLGBswFNl/OuB2vy/WHYkXibi+x/p0SsK ogwALu5X65ftVBua72eAUj4KKNkTICm82g8tpe3BIH3tVzGaIIOL4mDYCZeEglVWsXef 6++g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738816294; x=1739421094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/iia6e3VwJ3mqPG8y4gzge3wzg5w4QmfPYSP+uThGj0=; b=TTY16pgBYYoCcVqsmhUJcM97sAueVMvQtl73tAviH0HZYZ1pxBzknISkKZfH2U5pY6 WOZr9FRghSWccjJrHyEdGBgU2jaafWmvooyYKUjfEZUNdUeK2csAS8oxY/Ba6vt5fmXE A1QUNj9JD09CadejmTRN2NGZztlfa/RTxhesSn3AzQT6FJehQSdeu86Mko/ggjK2RqWT ZNlqVJUSvPBH9ddHQovRb6OtfvOKOg4R7cX2NiZipyn0zsDD4ieDxITKjgj+PkPsbpD2 jpoogOK0tcZLH5chaBe8HaUIi46mmjqv8sk/E7vLYS2XVePai1NyxMamqqxnHgrqIk5R FvTQ== X-Forwarded-Encrypted: i=1; AJvYcCV/ohy6ZuS8NgIkqGIdxz5zQMtIF3RGrrHzPCTilhQtp4IObSBRheaH2I078x4OqSYMOubdWHiseGQWwG4=@vger.kernel.org, AJvYcCWok51m0/mIygztogtzttOs6ewDml3Kx4q2m2I7zZl1gK6a6/EUPlKtxvzTZM7S4Gc6Hqu0SC9r@vger.kernel.org X-Gm-Message-State: AOJu0Yx5d7dG6837qE1exC2oCHUFvRcNHFQYXZVZ+XMjxm2kxhE+Z/8n VL6IKTm81TUK0CqtXzsFpKTdS2cbWp9fp0Uham4/Ig8rOYRXUtw13RqJoQ== X-Gm-Gg: ASbGncuZGVDqUH3wo+9xqjhfJabDGMPjTX4zrIy9O+flhKXX5ITa9Y/7vLphc7Bq5tM noyjIWpfVTdwtkNTB2eyh5j0Pinezeb9wStgJbwC56eYhZ8st0KKEMB51mxG5lBTppb9CDxSGq0 JBgOPugSXxzskKLxaImqRleAN63ya0yaD565iVFWX07Xp2SCytW96GadEx7Xlt/g5GZVO5pWZJF s+n9WJxFF50EiHVb3MI3WLYn6lBZzC+p6T+eTtv761Djlxqk9u64W4IwitxCCn9YcO/SNlmQSnK 0nq+biuY44QXXwlKmCoepKnrRGBA6KPHecg= X-Google-Smtp-Source: AGHT+IEQQWXdGY3dj26CTU+BJ/b+rl48jApZed7wrVj+Yx28wDTuhlJAtBX6E0cVOIvlSscWCeVQwA== X-Received: by 2002:a05:6a00:28cc:b0:725:f1b1:cbc5 with SMTP id d2e1a72fcca58-730350f96demr11011802b3a.3.1738816294110; Wed, 05 Feb 2025 20:31:34 -0800 (PST) Received: from localhost.localdomain ([205.250.172.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048c162f6sm305013b3a.143.2025.02.05.20.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 20:31:33 -0800 (PST) From: Kyle Hendry To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: Kyle Hendry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] net: dsa: b53: Add phy_enable(), phy_disable() methods Date: Wed, 5 Feb 2025 20:30:47 -0800 Message-ID: <20250206043055.177004-4-kylehendrydev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206043055.177004-1-kylehendrydev@gmail.com> References: <20250206043055.177004-1-kylehendrydev@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Add phy enable/disable to b53 ops to be called when enabling/disabling ports. Signed-off-by: Kyle Hendry --- drivers/net/dsa/b53/b53_common.c | 6 ++++++ drivers/net/dsa/b53/b53_priv.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 06739aea328d..e5b0cc3428e5 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -592,6 +592,9 @@ int b53_enable_port(struct dsa_switch *ds, int port, struct phy_device *phy) b53_port_set_mcast_flood(dev, port, true); b53_port_set_learning(dev, port, false); + if (dev->ops->phy_enable) + dev->ops->phy_enable(dev, port); + if (dev->ops->irq_enable) ret = dev->ops->irq_enable(dev, port); if (ret) @@ -630,6 +633,9 @@ void b53_disable_port(struct dsa_switch *ds, int port) reg |= PORT_CTRL_RX_DISABLE | PORT_CTRL_TX_DISABLE; b53_write8(dev, B53_CTRL_PAGE, B53_PORT_CTRL(port), reg); + if (dev->ops->phy_disable) + dev->ops->phy_disable(dev, port); + if (dev->ops->irq_disable) dev->ops->irq_disable(dev, port); } diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h index cd565efbdec2..6ffc36c1b2c3 100644 --- a/drivers/net/dsa/b53/b53_priv.h +++ b/drivers/net/dsa/b53/b53_priv.h @@ -45,6 +45,8 @@ struct b53_io_ops { int (*phy_write16)(struct b53_device *dev, int addr, int reg, u16 value); int (*irq_enable)(struct b53_device *dev, int port); void (*irq_disable)(struct b53_device *dev, int port); + void (*phy_enable)(struct b53_device *dev, int port); + void (*phy_disable)(struct b53_device *dev, int port); void (*phylink_get_caps)(struct b53_device *dev, int port, struct phylink_config *config); struct phylink_pcs *(*phylink_mac_select_pcs)(struct b53_device *dev, From patchwork Thu Feb 6 04:30:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Hendry X-Patchwork-Id: 13962176 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8EA18D64B; Thu, 6 Feb 2025 04:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816298; cv=none; b=RmFe/yH/DWgFIEbDS37D9kH4wClPH8HLj+95vx7cFbSK+r7h/TzNpM4R0vuQuOEJNBgnF+78pf17apdXsqocAwLU+hUcqSQi87QJJ6afebMgm7yeucI9805OYh6cK28/+ZocRqjrSL5ksUfqiLsZEBP3q+YkaydUj0ap4RSXGKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738816298; c=relaxed/simple; bh=rj4KTu+ajX31NqJii1zEbjLyc6O2Tmwr2E2PL4eQIOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zb4nI1hizMQ49XDYXC2NTxCNjuEfiaHsUilyP0D0JucoYNlRlP+ORsJ6qOhSIxBUURZRT/UJ2ca8OJvUjcZgW9ej84PkN3ng0rSp2tsQocbK++qpw4UUzW65PXfDhiUZn5NVRCLukLfh8SS4livyQ/PHdyvS/thc3G9J5Mj9f8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y2yUmz0Q; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y2yUmz0Q" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21c2f1b610dso12827525ad.0; Wed, 05 Feb 2025 20:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738816297; x=1739421097; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i8acatil421MCBC0+THYc5jeXrL2jSB73N/GynhEtSU=; b=Y2yUmz0Qk2U7hh/PR9/fJHZ48Ag0KLSs0axXBkVSy7NoNkgKRMtJdWhuyCb9sUTRuk gFNGoDot8sMuiM5uSa2iWtdrj2MeCYfjHSF7wFf6qfjZESvw3AW5FusDQA6527py+0sP v42s22ZQKlOp4I0tPRH0YscFgzCOJ+dPwENunW7p1/ESGqilWDlaE+Z48vIBt16XXgSU g9ZNKEslN20N0ZeP6w4kbrqZFk2assfaRsJiLA/E8UTllCQ1CoDzavJMs9SfcogYdhbJ lPOQ86u64WWXGFi4ichfUPnezehS8+j6HpLVFBUNOvJPwrTqJEIEkeX7MkEvEP7pfc/M 6Z9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738816297; x=1739421097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i8acatil421MCBC0+THYc5jeXrL2jSB73N/GynhEtSU=; b=sjSkzVQaKjMojCccLCcqQ3W3+4I0mJmXtI8BRMJC4nxbn7o5OEE9LTG/gzKO2QHdnD f17qn8Su5A1YuZFynZnWLZLrY53Nw4UF7ti1dJVs/wVHTkulF+GOnP/ks9q33RED1kWJ 0w6VwvYFvyJRG3ZvSuDAPKxfv9N/CGG6iul6D/7PIIbLM8RwHj5pwkIaU+BNlfQi23jj yT7c6yZfiaY7z+p+IKVUxEaH7p+1LyApIWbOi5W1ka2qIOBXzNb2ZrawSXW/JcFfa+tz S2e14D45mYzQvLS7u1/lsXleRRlUKZ0MdIdw5AtnjRmdcmihQYGpdymkz+2H6hYvL0HG 0JjQ== X-Forwarded-Encrypted: i=1; AJvYcCV6M0582jpSGCeSWZ1VI0BhgbVdt+l6drjeBDE1z5aib40g7Y8ap6s9wkog6mxrBRV3IwgaE37J@vger.kernel.org, AJvYcCVkJ1WKgEEb53ju/11ACOgawuQfvG1kqWA/KoxK1QiWVCQ1KK129tx1rx0rCiNGXv8dZofgmQU25Fa6iD8=@vger.kernel.org X-Gm-Message-State: AOJu0YzX5V8ELFeOMHBrbZLgxHB3yfAernDwRc70b9V2TRAYQf+5Fz+h OxUeLUifbC43IRjVuenha0sdGP+2hbSvEAhTNQ0/zNguLaCqDzFx X-Gm-Gg: ASbGncvrozjfKj10nKkfflycoAC1JIzKdflI2a+uJVF9f4uZFdA6XyO8gFpMdKD5sXc mbK/u6Ml0HxoBw9DZktUDPIQSV5wBX1vC5sI3ub31IpXQZEMsJmo+tMKEmlM97Mcf1C6fQYBysq GJtZ6VW4UfiCUhALAPwa17Hv8ZE8T+DwIWYBg+XjHdNkIAPU0oTX4qu+g14lY6gFIGowGRQ+SuQ qTyC+3bzhyyHheR7weZf1PouS+qM7ApSkxvp5skSwSee7iV3fRu0yF6DhrfbrFXGRu03q/mZ0Jm pMVAuURuKWtvyOobLJBuo4Z77rBFMQmqkcY= X-Google-Smtp-Source: AGHT+IFsQCx7hTEyC1asY8FfHU2EeavKDY8jVYJWsImpFHBJCSDZLokex67ydvog+IZqnQ5VouNCtg== X-Received: by 2002:a05:6a20:c909:b0:1e0:c1d5:f3ac with SMTP id adf61e73a8af0-1ede88a6a01mr11293939637.32.1738816296656; Wed, 05 Feb 2025 20:31:36 -0800 (PST) Received: from localhost.localdomain ([205.250.172.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048c162f6sm305013b3a.143.2025.02.05.20.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 20:31:36 -0800 (PST) From: Kyle Hendry To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: Kyle Hendry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] net: dsa: b53: mmap: Implement phy_enable for BCM63268 gphy Date: Wed, 5 Feb 2025 20:30:48 -0800 Message-ID: <20250206043055.177004-5-kylehendrydev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206043055.177004-1-kylehendrydev@gmail.com> References: <20250206043055.177004-1-kylehendrydev@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Add register defines for gphy control register. When gphy is enabled, disable low power mode. Signed-off-by: Kyle Hendry --- drivers/net/dsa/b53/b53_mmap.c | 34 ++++++++++++++++++++++++++++++++++ drivers/net/dsa/b53/b53_regs.h | 7 +++++++ 2 files changed, 41 insertions(+) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index 8157f9871133..ac0b8fc7eb4e 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -230,6 +230,38 @@ static int b53_mmap_phy_write16(struct b53_device *dev, int addr, int reg, return -EIO; } +static void bcm63268_gphy_set(struct b53_device *dev, bool enable) +{ + struct b53_mmap_priv *priv = dev->priv; + void __iomem *gphy_ctrl = priv->gphy_ctrl; + u32 val; + + val = ioread32be(gphy_ctrl); + + if (enable) + val &= ~(GPHY_CTRL_IDDQ_BIAS | GPHY_CTRL_LOW_PWR); + else + val |= GPHY_CTRL_IDDQ_BIAS | GPHY_CTRL_LOW_PWR; + + iowrite32be(val, gphy_ctrl); +} + +static void b53_mmap_phy_enable(struct b53_device *dev, int port) +{ + struct b53_mmap_priv *priv = dev->priv; + + if ((dev->internal_gphy_mask & BIT(port)) && priv->gphy_ctrl) + bcm63268_gphy_set(dev, true); +} + +static void b53_mmap_phy_disable(struct b53_device *dev, int port) +{ + struct b53_mmap_priv *priv = dev->priv; + + if ((dev->internal_gphy_mask & BIT(port)) && priv->gphy_ctrl) + bcm63268_gphy_set(dev, false); +} + static const struct b53_io_ops b53_mmap_ops = { .read8 = b53_mmap_read8, .read16 = b53_mmap_read16, @@ -243,6 +275,8 @@ static const struct b53_io_ops b53_mmap_ops = { .write64 = b53_mmap_write64, .phy_read16 = b53_mmap_phy_read16, .phy_write16 = b53_mmap_phy_write16, + .phy_enable = b53_mmap_phy_enable, + .phy_disable = b53_mmap_phy_disable, }; static int b53_mmap_probe_of(struct platform_device *pdev, diff --git a/drivers/net/dsa/b53/b53_regs.h b/drivers/net/dsa/b53/b53_regs.h index bfbcb66bef66..9607b28bbb86 100644 --- a/drivers/net/dsa/b53/b53_regs.h +++ b/drivers/net/dsa/b53/b53_regs.h @@ -525,4 +525,11 @@ /* CFP Control Register with ports map (8 bit) */ #define B53_CFP_CTRL 0x00 +/************************************************************************* + * Gigabit PHY Control Register + *************************************************************************/ + +#define GPHY_CTRL_IDDQ_BIAS BIT(0) +#define GPHY_CTRL_LOW_PWR BIT(3) + #endif /* !__B53_REGS_H */