From patchwork Thu Feb 6 12:06:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uwe Kleine-Konig X-Patchwork-Id: 13962965 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73915C02196 for ; Thu, 6 Feb 2025 12:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NReF8zJPQ2mkoOGGZ8LIj6uOL+cpVio09VFK6cVJRwA=; b=rSUtO/2AVTgE6fS4k0vEN2Epc8 mxwf37na6Vs+a6ovk7Kbwprdy7I6niviSEjvI1CASY+9WYGWHmRF0WP0MPRx2fZ0TRcawiCB39QZ9 iaAdhsyG/spbg5wGaWBfiWkItvlKF9ogt2nbVxIruc4QoXH2aF5TDplHvJ1bwNru0JjUCfeFZwlzq oDBq7AcBbTcGl2CtmlZg4GShlQ377ozXZqWCCJIIvRlt0bv9H+/QBka4tfr8YSLbvTTgnN2bEytz0 vyR1X9RmILQ7n/LbJ++rPJ/JV+Hw0GbCusXgjbuAzbc+ibgZ9+aWcmtrculw80/t4H/CBCJbw1jFR xErOjryg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tg0ng-00000006Em5-1pHy; Thu, 06 Feb 2025 12:16:08 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tg0ee-00000006ECM-1R64 for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2025 12:06:49 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dce3763140so1867542a12.3 for ; Thu, 06 Feb 2025 04:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738843607; x=1739448407; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NReF8zJPQ2mkoOGGZ8LIj6uOL+cpVio09VFK6cVJRwA=; b=IiihIA+yiyLcl8oNkSyUNrMWwWG2YBd/2d4GU8rYn0GTloF0NjzAqUsBbTiTpBl2EF pJaAp+3QN+2d9NKfhIVMujTS26lJwnSaFZQUtrrYwXSCfT76UBSTV4edBtJR1rRTFZel /3EmxLr8HgZq/WLN2CyT2Lg7eg073tkWU7Wa/3wOTrvHxl/IFARv7PZqdB/gfYwWk7bP o2z6hwsugh4u5t3Qj1CebvRkQBbCgIJslPnCQNWUu/1w5s9S9BY4vet377QF7R25TpfK 9U+aeExdVOePzAWdv+wTZ3lXskuDCUXCtdP5HvJx7+iE7T97f+5JAUJaSuyeuPRCWQXt Dnng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738843607; x=1739448407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NReF8zJPQ2mkoOGGZ8LIj6uOL+cpVio09VFK6cVJRwA=; b=Ggg4UwElQcNc1tPTQ0Rj1RzvgaAAoSRjzo76QWWlFm8XDBNZG5pjdsTYbeZonSYVyN EmX3iIJHeTonwlhrumo/pcjvGetxstJhyBrLP23sPpTx5qlM+BqWSEpAHBHZbt13QwGp JrtZS5ko1JPIKzGpwNsgwSYOJq5UWvv4QMMhkCOQOAnQRjP+y37zgO6PLdWLE/t+W8V9 pEPnJMGIZRCM9tXkxLgKBZ4N4+fVAs3Kl0LwNj7NaYn0WigliU7krcrPzbeKsl+Mdffu 0vJrFtNq5VLBpJxTogabQgpWXGcfOTf2UQkrZuQoDWopXY3N8ZYMrI/58ifimOZDrQO+ GSKQ== X-Forwarded-Encrypted: i=1; AJvYcCW3vu0zqBoGYE4cPpXoSVZ5zrdhiGgw4W3vsgOSu7r6k1ua/y+ogrlsSJmiDyLQ8Bb7zOdDC6vhhwTptWZ71XA+@lists.infradead.org X-Gm-Message-State: AOJu0YyUWByIu6cWOh51TmYIvCHMHwtzSX7Yp3eton9huT8JZhPH8IoO DbBoPLWLEBG16wMMkzwgF1q5THShXJMgY9WHwr0mSuS3QLKagobplOkFDHV2Xig= X-Gm-Gg: ASbGncsTDDkyXSJWnzDQWqxXvwdnxwWD2YdYRfNbj+ZQxO94miYbmBmncfZNeycce3q TxQJpLqFMsq7sP4OjwRzD9kdcKNKoVESRlgc8i4CD2gIfKxAIWFDW3cQl5XwpJ1YtVUK4ap6aMW fl93RNGqStqIfeZ/pFFP24qF0UtMkWtCFgvfQ/5G5uWFQLTaxHl6VHcOOVilrGAXBu7rxvx7z3U ZoZS0MDIibNeXclMgkeO6YbpQGx6Jqv/W/n8S4bNJfXoetsj89QJyWz4555+AnHZCc8wKFYIGqx DJmW3QonMeLAXbMcKMO7IvrtCGp6y/xA3iDL2psyouLXaC5ZfsNLrTH4+Q== X-Google-Smtp-Source: AGHT+IGQ1DA0hZwXcuSSWYUM+Nwt3fhgw1zzCRs+JlqWF6tyiwu3NKdw87WAG8YCeJ02lh0EqQN6Ug== X-Received: by 2002:a17:907:1c29:b0:aa6:b473:8500 with SMTP id a640c23a62f3a-ab75e2f35d6mr665775566b.42.1738843606248; Thu, 06 Feb 2025 04:06:46 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7733399b7sm88700766b.158.2025.02.06.04.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 04:06:45 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/3] pwm: Add upgrade path to #pwm-cells = <3> for users of of_pwm_single_xlate() Date: Thu, 6 Feb 2025 13:06:25 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2213; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=hB4Y/PN8/M4xgeiRJgl1lhme90Lz9h74cogcmW6hNbs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBnpKXDTGJARL1cSvb+WvKKbPpN9O1N3KQQQTDB3 QWnCB5cXhSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ6SlwwAKCRCPgPtYfRL+ Tv9kB/4k1C64n/wjXyMEl2YAPPWhoTmdH82Ps93+wOk3K4f0TLrMY/v3IE/7doFskqR4mprAuUS 7ho/c3R44ScCD3492ffliwGypxz6Hve2qbgzjCOdIpiExgUY7CbTNNbns6kPQEXKQcruOYMSJeW 2ktRsj66bLtA8UIEuNqVC5sBXQ+hS1oSZXyB9v6bc8Q13RTFvMK8f1eVuyPT5/3oLVnySTMEy+8 0IdEKIGXZk5gPm/kmEaPuYgE9cYlDTAZpg+gn3fTA3u3LY3Kskedyfwe6rW5iD9kwwVW5Fgb1SC aFz3p+GzT/LuUpu2kMYs1J2mETTHLnBRQ5J+T8F+F38FwIfG X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_040648_379411_A1645DF6 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PWM chip on PXA only has a single output. Back when the device tree binding was defined it was considered a good idea to not pass the PWM line index as is done for all other PWM types as it would be always zero anyhow and so doesn't add any value. However for consistency reasons it is nice when all PWMs use the same binding. For that reason let of_pwm_single_xlate() (i.e. the function that implements the PXA behaviour) behave in the same way as of_pwm_xlate_with_flags() for 3 (or more) parameters. With that in place, the pxa-pwm binding can be updated to #pwm-cells = <3> without breaking old device trees that stick to #pwm-cells = <1>. Reviewed-by: Herve Codina Tested-by: Duje Mihanović Reviewed-by: Daniel Mack Signed-off-by: Uwe Kleine-König --- drivers/pwm/core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ccd54c089bab..bc05818fa370 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1000,11 +1000,27 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg } EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags); +/* + * This callback is used for PXA PWM chips that only have a single PWM line. + * For such chips you could argue that passing the line number (i.e. the first + * parameter in the common case) is useless as it's always zero. So compared to + * the default xlate function of_pwm_xlate_with_flags() the first parameter is + * the default period and the second are flags. + * + * Note that if #pwm-cells = <3>, the semantic is the same as for + * of_pwm_xlate_with_flags() to allow converting the affected driver to + * #pwm-cells = <3> without breaking the legacy binding. + * + * Don't use for new drivers. + */ struct pwm_device * of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) { struct pwm_device *pwm; + if (args->args_count >= 3) + return of_pwm_xlate_with_flags(chip, args); + pwm = pwm_request_from_chip(chip, 0, NULL); if (IS_ERR(pwm)) return pwm; From patchwork Thu Feb 6 12:06:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uwe Kleine-Konig X-Patchwork-Id: 13962963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1545EC0219C for ; Thu, 6 Feb 2025 12:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JzeO14o/pXr8ezTGYZalXSXV/Bh7c/D19pERNYYPjQ8=; b=XO0hjybrmkMU8wOUO23ZEUq2Se YRuyZYqUvWNtVnqmTE99K/+RoxjIvIcOjwN7f+vuQ2v0+GRLbc9FyVmjHu1LKDRsB0Aw4fWpzydTm BSBdiR+yfz8XFjhG0/iSxOgZJfo7FIXQ+uRzQMjWYltSjJmi+r3g1xp3dUpfMTX/LQLMq6e5ye19L hIluBnhHFzTzxaCP4D4QtaLyFtAVMCHhVyLrI22xO6Xw9JfZeGkccrPfzdjQtQLBB6cRRqZzQYMEr DOFA81SOco2PFe4tEaoQGUPOcxV9rxl2FQDMVwjCIXi9xs8ocbvDFvHlQqmIEUcaEKFrW6WOlxWcb f1myg+nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tg0nh-00000006En3-1Lel; Thu, 06 Feb 2025 12:16:09 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tg0ef-00000006ECd-2CO9 for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2025 12:06:50 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5de38c3d2acso184430a12.1 for ; Thu, 06 Feb 2025 04:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738843608; x=1739448408; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JzeO14o/pXr8ezTGYZalXSXV/Bh7c/D19pERNYYPjQ8=; b=T9yuPwUdr9aJ6c43VndIPsZ9D62SGI4EYCDrNJux7iMeVBDuUH/kUIjc/u7yXVTmc+ mtOB3GC6IHz+ICEk7vUFkGkyEHiXCgARU4QA/jQ9zqkVgWGdHve5mwFDtJIKrsg7Ds9m UZXDUzseAy9UD99WADMBWgJsZIXlUjbgHA2h2eGOfzhlxZEZ6pw8L04u9+OCuPGqBIWg /90I/qOlWW7+BPl3448yDiuM37yOqCktadaHDp5TcnFTXX/hijPNuXq/WjP3ASTbJ7bR VTgMJahVVNMLUEtSfYxIwu6ZqZry9DaKdOBpoDzXfw6DWKMle1t1XbkCfKmsH2edmUmO TvGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738843608; x=1739448408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JzeO14o/pXr8ezTGYZalXSXV/Bh7c/D19pERNYYPjQ8=; b=KqfkbnNRtxjSGsAksEy61hHMAm5406v/ohtRyIGKJC6z5HwpspKCHUX3VQMdK/7YmX zR+OcUIEvLC/QjDIRs2yS/WXjT/ZmtkEjpxUhekWLFqGgvICoAbi4p8Q4swqa1a5XlVj RwkNQKA2P+X1UeG0fmoWw2wxHPaJLBvfID9ze9xF/VV2Pf7XSslybuej/l19FphpQkjx owe7t+8wb9hTH1G0BeDj2vl0lpnJxrniOFLc7/rcdwxA2vHm/NFnR3oYunR6/gff96yw iIkLSRg5tPrjhf067WumbRHlgaJAWKO/WqPqqJ909im7UocPJ3VVuU5wGoisLEljGePE 5C+A== X-Forwarded-Encrypted: i=1; AJvYcCUSL/WsrknEIY90u10IJkahulU59jnCvAUFM6FAIOA/DHp2xmfN6XLHZKfWI0NBH2QsfBdCIl2wsAwJIsb71rUF@lists.infradead.org X-Gm-Message-State: AOJu0YwquqZ4nAs04SjI+qWVogfKJ5tEPSw6o1BZYT7tAxww3J/85i1N xXK6IFSZ7t4PddFbr/BeEPrZxx/nzf9G/OzuZQV4ZQZCUa7xr0KCEuPgc/6odtQ= X-Gm-Gg: ASbGnctmIM47Xo96Ij/Ru78CtRLnMikczoC3NYtbPgb3igkWYC7NBZX7JoBLjLDloKO LPl9gq+7uexas3b/g4nLmsUULVAOGbENjF/wJOaS+/5KIerUHRVNyVW3roMpzbZzbYt0q1CEhCb nBmKV8LdhCexQIwT0cdHDgGsH8FsojVj0NL8bKaSCozYaj4lCQohyRcF5/Z6hpO04CXvDTqMYrd 0aKMdOQIlFkqU3TplY+3NCeW5wqveaowdvykdMZ5pXNrm5T3y5vALekKIMzsxjTU2RJaS3HED0n K3eD3eEJ0VF0BaZvqfPHLxboZ+uOoleHPFWabMOWyHDc8qCwmueXvUP4Og== X-Google-Smtp-Source: AGHT+IFI71F4BsOEuE5LOsmA6xvcL/sHCHHEInIj/bQ3b2TPDGHazfEmK+Cl66ACwGBnNwW8wYr3HA== X-Received: by 2002:a17:906:6a11:b0:ab7:5b58:f467 with SMTP id a640c23a62f3a-ab75e345e29mr775388066b.40.1738843607801; Thu, 06 Feb 2025 04:06:47 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab772fdb84esm87896166b.80.2025.02.06.04.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 04:06:47 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley Subject: [PATCH v2 2/3] dt-bindings: pwm: marvell,pxa-pwm: Update to use #pwm-cells = <3> Date: Thu, 6 Feb 2025 13:06:26 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1472; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=mzzlOW4s4XFlnUNQki2gOaCCsd4YELQmA5LEb/HxHuc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBnpKXFkdfzIMqsUtFwSC7Ld/W0uHO72JRAcmq1S vHKqGCjSruJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ6SlxQAKCRCPgPtYfRL+ TllnCACpIZYHCIIgQPnWJ7NTPt7U9cHpdvBcYDh7PLjBCpqtcQkZicOtQI7NV/JICkQU8Isjs19 CPCh/yYAFydLFCGOv/MN4EnlEkJlFwahKCN7rpXFy6pdkS03oXiTeIYqky8YGxIX14ZNCyXQeZb XKJaAZXe5awZ+y6mk9uPJObdxRIr7Z2zC8aXD2ZU6RE1U4KrvAi31L8royEpMX2S/AmySoP4Aij GOrngzrp9VRJMt8MRh7BFoP9UuTlSKOKluK7EM4m+3v7ilSS14oiyc5eLn90WvCII5GKsV8cPnF H/vGOgRL8LVRoUBdBrvojRriw6CopeMcUJc8xs4a5tOoZdeV X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_040649_561547_F7FA4F27 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PXA PWM binding is the only one that doesn't pass the PWM line index as first parameter of the parameter cells. However this can be upgraded to the mandatory binding for all new PWM drivers without breaking compatibility for old device trees using #pwm-cells = <1>. So bump #pwm-cells to 3 with the (undocumented) promise to keep the old behaviour for #pwm-cells = <1>. Acked-by: Conor Dooley Tested-by: Duje Mihanović Reviewed-by: Daniel Mack Signed-off-by: Uwe Kleine-König --- Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml index 9ee1946dc2e1..74f2d5964742 100644 --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml @@ -25,8 +25,7 @@ properties: maxItems: 1 "#pwm-cells": - # Used for specifying the period length in nanoseconds - const: 1 + const: 3 clocks: maxItems: 1 @@ -45,6 +44,6 @@ examples: pwm0: pwm@40b00000 { compatible = "marvell,pxa250-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; From patchwork Thu Feb 6 12:06:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uwe Kleine-Konig X-Patchwork-Id: 13962966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3581C02194 for ; Thu, 6 Feb 2025 12:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=azgIPPvnb3xo8w6FQBxsN5Kr8m/w1ZbCcc3sgLdo0JI=; b=AP59EoX1oosDgLwvgk+sBthKSh NkXGatiJMCoy/I2Djmrj7vEAfvbtZ4h/qjBM39gumJjwDCgjVC1CJjc//3FpqkrTtBRyKsqH8TbDD QVc8zyYOD7Us6Qck3BKc3YwenOkEzlVvJOj7p/99af4KyFZWRGFJCQajTBmPruRP1xJrf2iitr2/A Z1vZlG23WSYaSHOze4hS64Y+AwcCCBxWeOaSndvkwnM1kRdF9Kmr/tPc/H9+bZY6ZdcyVxGJszpDa IPZYViZpBJPmSrycHEzECU3BhpkfeWND9TdjlsovHQkDy2a9P3lRQtzFRkQl/qFCx/rjbFFUjj5LF ig35wjRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tg0ni-00000006Eo3-0CFx; Thu, 06 Feb 2025 12:16:10 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tg0eh-00000006ED3-0MWz for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2025 12:06:52 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5dcf0de81ebso1230004a12.1 for ; Thu, 06 Feb 2025 04:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738843609; x=1739448409; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=azgIPPvnb3xo8w6FQBxsN5Kr8m/w1ZbCcc3sgLdo0JI=; b=ZbNmhT2iHjrVcdkSetNsgdF80FugOMIzWLswUAMFBXX0VtrZuMx8RZOpFv7O72vF51 BnxUIExGYp7tL7LH+LXYhHXQkjtGsD3IqMl2ACS7Y137jZuKtKNrl36bfs+qXMr6KO8W ikHlKDeqmDRUXi4OBu1C6VtCpOc+YmIcfENzN9xHAPKE+cqedZwBpgzNbNXYzNWD5g1k mnFfxY11TLzcnwQqqhrOKr6zQE+8gO0Vp+XGDfilI37/V1tHqH834lwwiPi05dkPesCM 3u9nkG1ZMf46LDl2y8+JAc0mj9+BzvP/6OTkiV/6gArdkca271kcP+KGo8rjboA8Svh+ pFwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738843609; x=1739448409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azgIPPvnb3xo8w6FQBxsN5Kr8m/w1ZbCcc3sgLdo0JI=; b=WAN7DdeQgkGH80ihIiIxCLFXTrj4FthzTfkiZUENIM6PQeAvv31WY26Zy/ece+qXXx yyPgmnKqiEhXTwxzBmWJfZXrb/w0mC/xSvOcdWIc9X17YoOjP3b8Jpqf30iEGvo4kDDa WX73Aa5WfNfS7ctQlgHpknC3jXWQ0ANnwzV+QKkGRCo/9uPelEEfFbFZhHCJaaww2EEV 3+7FkX6DlrGEaRvYb44hJiwrCJm5ihpqWKX7OHCT0sgl7DrLMp3fV20UyfjoHsEA7QYQ JXHbDoiqvXsYkmSp+TPCRjwRWf9uNncbibBXYAdmWInGbw+ZmeoSEXAg8Nrq0TBtPAdC 6YOw== X-Forwarded-Encrypted: i=1; AJvYcCXbqu1vRow5dA9zLsm2Xoh42jeTH+/kP5W0k223dXSsOjmfDHDytGjWXlF2CHiyBWdyVbOhUdmdnPSF5zqUS8t4@lists.infradead.org X-Gm-Message-State: AOJu0Yy1gV4dN1rmjqTbSwM/YzxvsU2UdxRcIbtqC8MSPC71dVBDz48G MCtW/7eNcqtyxhD0CfslCbOyqdDER8vV8NPFE12vl/gjS0EPhdIp5CNb1hlU30Y= X-Gm-Gg: ASbGncsx1N5KrTLMt5jg52p7mUY2SS6H5WQsk6JECyKWhil0ufh+RPci0uOoA+gtJ9Q FAHVMI3Vx7m9tfPe2Uvxq7/bdZGqj9nvrtKFl5r27eIZ5TK0tMHE96OJ7uTaW8LOdJQUsm4psUB w1ppcb77/OJb3XeGKklJ8lAHsJniFMjg3KeqKQNrgk78rMh1KBeZX4GnLsDh+moRDSaRrFTwFR5 yCERj3dE30sf8986g76+0LShRV2bTJbkM2f/3cf9wxkzh642IdpKx325bDAbxXgJpwIOX3jjjb1 ucWSv8PCF9VI6TWENorvUUTAklIxyDtg4YrHR8vZlvxIF2qG3FSOaTJkLQ== X-Google-Smtp-Source: AGHT+IG5uqRw3jqoLLEGSCIgSLFJdBnS0MRDiPp24UX/D9Hd8p8T334IFdUKb4jPzFuoHC/yaN/s3Q== X-Received: by 2002:a17:907:268a:b0:ab6:eec6:7cab with SMTP id a640c23a62f3a-ab75e2f1177mr683407366b.38.1738843609230; Thu, 06 Feb 2025 04:06:49 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7732e718asm89556366b.99.2025.02.06.04.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 04:06:48 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH v2 3/3] ARM: dts: pxa: Use #pwm-cells = <3> for marvell,pxa-pwm devices Date: Thu, 6 Feb 2025 13:06:27 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4137; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=5+DEXbonSTYjkcktKvLdRgdRfeSdfMjc1Rj9POliA3E=; b=owGbwMvMwMXY3/A7olbonx/jabUkhvQlS08kl1+fkjvrR20le+KLGfPtNzVIvF8ubbQmX9Rg3 dS99mKvOhmNWRgYuRhkxRRZ7BvXZFpVyUV2rv13GWYQKxPIFAYuTgGYiLERB8PuL+kbPlhfvGFy i/Wx3hkrtivr1Br69n0J/R5/dE+63wWPkxINYWw8Mn0LMl6uyrbQkknJK/FOvCUiv17X+cLclL0 7lB6tuhezekLJaYfmR4ov128xeOtfyyas4WgXEsidJ59x0++nmOurMyv3pV9++MfKgcff5tJWto VSJ/qtelbpruIU5I28Vp/Q9u3/7JWPkkJy9ywNkzK667dZfjeXzcMz7dGaJfs0unOD2xR5MmWV3 r8RdFw9pfZp9Ho1s2+eft4v8kMsmxtLO6bG85a4h/X4Rl6se6IseODqyVixF5sDqnw1bVxZi8WP i88XXqTUVKIwq0DV5Yv+vCJ7efM32/NEru65mZ5RFqYHAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_040651_123152_C63362C6 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For consistency with most other pwm bindings, also use 3 cells for phandles to PWM devices. Tested-by: Duje Mihanović Reviewed-by: Daniel Mack Signed-off-by: Uwe Kleine-König --- arch/arm/boot/dts/intel/pxa/pxa25x.dtsi | 4 ++-- arch/arm/boot/dts/intel/pxa/pxa27x.dtsi | 8 ++++---- .../arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts | 2 +- arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi | 8 ++++---- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi b/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi index 5f8300e356ad..d25065caeebc 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi @@ -67,14 +67,14 @@ gpio: gpio@40e00000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa250-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm1: pwm@40b00010 { compatible = "marvell,pxa250-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; diff --git a/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi b/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi index a2cbfb3be609..ed07b65cc362 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi @@ -49,28 +49,28 @@ usb0: usb@4c000000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm1: pwm@40b00010 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; pwm2: pwm@40c00000 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40c00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm3: pwm@40c00010 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40c00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; diff --git a/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts b/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts index 12b15945ac6d..9094ec422577 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts +++ b/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts @@ -56,7 +56,7 @@ backlight-controller-pwm { compatible = "pwm-backlight"; pinctrl-names = "default"; pinctrl-0 = <&pwm0_pins>; - pwms = <&pwm0 10000>; + pwms = <&pwm0 0 10000 0>; power-supply = <®_vbatt>; status = "disabled"; diff --git a/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi b/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi index f9c216f91865..4e69b4da0ba6 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi @@ -224,7 +224,7 @@ usb0: usb@4c000000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa270-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; status = "disabled"; }; @@ -232,7 +232,7 @@ pwm0: pwm@40b00000 { pwm1: pwm@40b00010 { compatible = "marvell,pxa270-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; status = "disabled"; }; @@ -240,7 +240,7 @@ pwm1: pwm@40b00010 { pwm2: pwm@40c00000 { compatible = "marvell,pxa270-pwm"; reg = <0x40c00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; status = "disabled"; }; @@ -248,7 +248,7 @@ pwm2: pwm@40c00000 { pwm3: pwm@40c00010 { compatible = "marvell,pxa270-pwm"; reg = <0x40c00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; status = "disabled"; };