From patchwork Mon Feb 10 22:33:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AC98C0219D for ; Mon, 10 Feb 2025 22:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AkMa7JhGWHPwakvgRFAtnnbbmqbf9yGcCHBduJ4EjNk=; b=rBDpdhXV89j46+ wjRoavB5MWXJV+IIU4KJBu+lVSNO14ieD6jo6N4O9STb9G8q8iubM2t9qWa6UVJMWQ4nMj3Ik4mH8 SbxBxftHzT7gq3d5UOqhEfewklesyAjo6dFRtWnX5VJrZfccFFweTxPP6rKPebFJwK+nlIMpEv/eQ UZfWZwWD4ZxhSO6CC2WU4q6uzx4h6T2O+zB+Ggs7k7fSGYeXMkDS8HYqIZuc1K/1zrtIIPnVllD4O ncWTYWEzVp7ybgOb0mCh/fsJyj77W2aZNLkvLs8rAt/ir+WNy13ddvFavIcUJ9rBPST3N+nIoYgqL 0wwHlgq4h0az7wqeFOfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgl-00000001kRc-1G7m; Mon, 10 Feb 2025 22:55:39 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPL-00000001gJ4-0FLU for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=pYkqXDmBjhBzEtIKSbulfbTimn CGDjssY9lHkBYuhiOjRoJ1FditakDKMdoalmgqKyG5xbRsI674sFd2leuXWV+PvujOfRGfS1YugiD 4Iv8e0aGfB/LbcuyI+SetUnofW91gc6tolfA5xWPSEtX5CWONbeHcTrUx0HqNhy5utV3GYak1Jemh kA7owFWEuyFYtrWlitdOmdI535K3zWLn/HTl7cgRvOnhDSCCK2X8La7VyFhm1mo4ObfS0ZBA5Rg8z OwmXvZ4uFfcWgwVmeQeB3gHcS4PZbgkouxnDGuryhKeef51m+DOxoyJUXRlDc+cYuTjiATK0sfLVt ioU9ZkHA==; Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPH-00000000KMk-3zQL for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:37 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3f3ac0c8053so877238b6e.1 for ; Mon, 10 Feb 2025 14:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227053; x=1739831853; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=SyoV48dWK4TCcWjW1GQyz9ve9Qa/GSTQhmY9A3LnoNFn2pfUHWbjGTqTcJHcyWsPh/ 1BGlPrSMyePrWojeiG9Zh+MwpneEv5ITWoOxXz9VzbODdDRfGiHDrbMOSCc68ovLPsQr Ug7MBpFHCG/IivtsbGcoCHtAgFlgb35Hm+k+BKCX8jpZhfJHy4W9AuoxW0HvYKOg2k88 iVogHS5yASlSgRCYevCM7K+ztRQev47axsi8ym/CEDfNlC04nPf5tMNVzZ17Y7v1WCRx Mh5SCQVu5yZQ/cmAjJpWl5gOYDXMEbQnemXoAwNJzcmC2cRRWvQAOKjMxxE3JBC39I8j nWRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227053; x=1739831853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=XXnURrlAEvkajbCOlS4i2IG3Gtk2C/RV/7uJ7jMNueyqoMKC7wM7M+/yrjh1nkh14P ENriIFGXqWFhWKt4Y7J/UMa3GTWeG5JCpRXxBz135b6mM5IChHrwoS37TbT84Sbhm5ap 4PR/BocTvMyKo+XG1PzB1DQ08ogbiow2no1Wga7CLBdnM09pkyyWb4xt+Md5eC99n8L1 a9UA+mUaS5cT/mfSxUu9YwtMcPWf15KpHj10itirHOy41sTP7iZL3xJTWcs5g5QphE+x bJinKCldiAM4Rd7/Iv+O4hy/96ItuRol+JFEiqxl5Zwvem0jQ7dQ+fn1ut693OxMaGz9 kBTQ== X-Forwarded-Encrypted: i=1; AJvYcCU3t2xnp1Af2x0r0Fyq944Etu/Pt96j+WZhTyI5x5qbQ/KoJb6iac/uAEMgEfs4Nwj1ZFWe116Z9hw=@lists.infradead.org X-Gm-Message-State: AOJu0YwSvMAmv+i0SwoVpjm8cKN/hGC3Xk5na8N0tXGa1Rrup/+GSWb7 PbGEJD9C02vQidoZgki0P/VUDzRVAS+MlazsIOpH3tldFKVuuXYfb4bAcfBFcbE= X-Gm-Gg: ASbGncvvHkhxzxGr9T6ZQ1Tz4JeUktmGHBGMxNf0BhnkbsqYWIAtLFgNAdSdDmFQnxz myapMdrIouzi5NGTkCyE+K/ULuuAKR6ZWhSk5SQ0qHtNgOoOCcn8jaV4DAgbv4TCfocA7gxiUY4 i7yLsmDt5NTmMwR/LpGu+gKbmMG4sAadgfmccQGnvNuqLSeqiOaymutoGvbu5VioBdmzW0kKiWz Un21fTEjixtaQEhs6GwUHveYrCGpbfZia4qrWXVSRGGyPErLxhoz7LLVOATlBjxoCtDPOsf+pUs QruwIx/jkuXQqRrNbxDE3UqvC2rCnpM9dg+LaGx8qI6vFAU= X-Google-Smtp-Source: AGHT+IHsM3QlE/6UGVvIOu1IlhPnETs+gBtT/fIeOJD2BqtDOh052hlxzN8ugWj1HusAxyIKgoI2uA== X-Received: by 2002:a05:6808:1590:b0:3f3:b8c5:4ff9 with SMTP id 5614622812f47-3f3b8c55799mr3309849b6e.28.1739227052973; Mon, 10 Feb 2025 14:37:32 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:31 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:27 -0600 Subject: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep() MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-1-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223736_218627_5F17B2A4 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add a new gpiod_multi_set_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner Reviewed-by: Geert Uytterhoeven Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij --- FYI, I dropped Linus' Reviewed-by: tag since adding the IS_ERR_OR_NULL() check isn't exactly trivial. --- include/linux/gpio/consumer.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..5cbd4afd78625367a761e224acc3f7336d310dd0 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -3,6 +3,7 @@ #define __LINUX_GPIO_CONSUMER_H #include +#include #include struct acpi_device; @@ -655,4 +656,14 @@ static inline void gpiod_unexport(struct gpio_desc *desc) #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiod_multi_set_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + if (IS_ERR_OR_NULL(descs)) + return PTR_ERR_OR_ZERO(descs); + + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif From patchwork Mon Feb 10 22:33:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968692 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1FDBC021A2 for ; Mon, 10 Feb 2025 22:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKkKlPFb9y6f1Z6qlPIVNmhLf2w5r0h+tQM7vMElSyA=; b=dS5Rf0sxkxI4o3 xZaRjdDUIbpNZI9jAhgdemx1TrOKCNvlpBZ/xxRNSi0pW8jsd+0Avt4uuc/fk7VfUxYZmG1Gk6sEE xGopW1wR+CDrizmwwHJUHq3QvEfZez+VWGVg2GYPbroxHQ+OdBPN2ZXUZw/UTlJYJg4jCRIcTwJ67 gcH69aMh6mW2LomE6cC5Nfd9jOu4M01gXLuMd5f5DNNMb+RhrO7aeuRIldLJxCXzOMi85RJZoklDl iwcqNIiY/wsbu6ipAgRtqR3T6633jLJeKRoFYSP0Hi0Xta2KEHtRPEJDHY/mfYcFb8fcqz0OPycJg Q5YNdT+WyljVJPf4d07g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgl-00000001kS6-2Msr; Mon, 10 Feb 2025 22:55:39 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPP-00000001gJz-4Bh3 for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=O/XXKVwqbDAeCvG2MhHGxrqs0C aAuMTci/GNG9QoyCctisk9FWrBrcwXkYKMElFepXcLX8IC3nCvV7LCKIvNah8udjdUo6iQdmYRrjw kom5A1bWlHJ+hPl41P/Kn6DfO/eHVZ5BUzEOHIESyfBlaiZBD4ugGtfADQn6tBqiIJBEoj1UrwZiS zHnf2d9127smJ7FdWxol2n5uXLlMJMbefnb4MFRJ9OxumlT6rABj5t4sMzUxJ53LUhhW8ijtVdooh vkwPddgBMKRBv7i7GOqIt/eYukcDU64FLMoU3Jw7ZVkwjvilZy/4in6oXMrvHiw7w1YDu39+KWggX /Y1ODtKQ==; Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPL-00000000KNE-0rxB for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:42 +0000 Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3f3b8f6ff68so698241b6e.3 for ; Mon, 10 Feb 2025 14:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227056; x=1739831856; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=X1dCkdClgZ29Vcl+9Mm7QHQTEzb02XHJhpN0sQn7w6EPdei+6wzoOhxYwg30eLUypN EXeoclWIU34RP+7eI0pburIyfOq8pKfwZijDflIKNbvUxAwiep/CfizwkQSCBzNR8L6b k29LDGAwVOBUXZ+4fUslSPkdDUcrTmlLE9VEdoVa52opR3RnQePe3avy6Spbxm4v1gJK BvZmGDLCYRNvM4sHGzSQ8TnYwgspxBphgwW6q5CU1QlHndy+oVuBezDn4rAxw+OyrfR8 RAcJ51mBHosjqFNC5zHQx6sAuvhcmK/X418SlcvbqfX4P7TNfXU63Psvvswc4z3cDH7l T9dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227056; x=1739831856; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=WAsXAT8MhpxSy0s/HwLSrEhWCz6lSdGa+NIrXzJFyB2MtogEQk67J3/oz4yWSofNlp dn8zaJYD0YI0CzQscqR1ZNC4h5gpu2r7O7cKh9tburtWQFupbZv/apAMmC7V6/UNVKnM +4LiopwiccifU9rWWAgS+FUzdAvYQfDb+BebZZwgCijPlgpZ4pBs1/trVPHEVNPQc3Ja kU8z3H+kE3UL7gIKAAyWadMucz3TfRzS+DN5CYL0T/LPV7oRRl8v20yJaegcm2WUIRhD nlDlMxkVkPr54whM4eKariUleFyB2yhNdXC9dL6QuZkh6CR4O6N/3ZJXeH5aVXl9dnlc e7fQ== X-Forwarded-Encrypted: i=1; AJvYcCU30W/ScPdc/Cq7DGsr5ALROn3lAWvrYGnJobyj+HRv5hr4QZFl0++m/ZEbFyr6SvoW7xwJG4FAGxc=@lists.infradead.org X-Gm-Message-State: AOJu0YztyFFEaQHh0uBGaCTVHS6y+Nx4D61BeJy7TZFK5zybLRG7GOwW AFV+5IBnSU5JQbFEkGWAgw75VayYXjq5m1mF8Ejq0J4nQzRe2aHbX95PzmvfDP0w8rdzNwvQ2WG d X-Gm-Gg: ASbGncs5CGBVnEtxtulFdlyU19LGCHAbLMxsio7NF3g9MydeZDSe42LZSjl93rXM6jE zWNx9/MyBjyAZ0uImFtTm3EeTQ6Y+87h4mQYKBtKXUmc7Y97+1RaQ5LdEIh1/BQ6MtEeKrZXR8Z L3R62GkPJL8Fah/43WjlNhX1jQEPByeTpWFwC4Srlxft4y9J9wXmEk/BZUaE/oltXe6y13wztP2 GAD2LMLPsJDtz1eKQCUuvkN2PVfPFmCxLZeGGXWEM3pEdKbgQMLsb7JQ8/CbQGa24NfUunWcRQ3 rJpvxyADJiyUoskgXgN9U/F9EGxyGHbvuywYMeA0EZD13OM= X-Google-Smtp-Source: AGHT+IEaS15Bntym3mAt6zrku3a2Uko68yjmwMRgXiq6dPbA7MZZB8Aa64yOncDet1fFdEO8/9GX1g== X-Received: by 2002:a05:6808:198f:b0:3f3:b6c2:a29 with SMTP id 5614622812f47-3f3b6c2115dmr3804142b6e.7.1739227056176; Mon, 10 Feb 2025 14:37:36 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:34 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:28 -0600 Subject: [PATCH v3 02/15] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-2-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223739_611351_576BB740 X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Geert Uytterhoeven Signed-off-by: David Lechner --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..dfb62e9ce9b407fe356c3a7d2d25319b91a11a75 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiod_multi_set_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) From patchwork Mon Feb 10 22:33:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968693 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AC4BC0219E for ; Mon, 10 Feb 2025 22:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jQ7iqIk+fniulshAjGckHGzsHnSk+9Cy8L+cxrN/WlA=; b=CnaFT6kHoXqJkv /busKvbjHoDt3tNOvqDQRiOBUQGn7CZ36nO9YNAFkUvQ/j5gCsLUOAWYrMePck2sBxDwg0V4TwLrm GxJayog4hkqkN/8rPx7Ai3Zf6P3E+7OjDBZ9mWRzez5ffWcbTchQb6+E29LhoiI8FcH676tvQpi32 Ri0YJcqMdHS+ABQveN0jl8L7AUuTA/lp3NMc5KJbqyhUhhqeVw/yYZdXOIU6z39scUF3U9m7sHCnS MlFco+CNO6jXIZ1x97DKC1IYmgxGwR8dIhUvQzkXyApMvpm4IPz/X+oJ/Ov8vVwdFYFNBmauJrgix AzYDcPj26GHvCvl9jo/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgl-00000001kSc-3jQt; Mon, 10 Feb 2025 22:55:39 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPR-00000001gKC-3Pxl for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=Mv+aKgVcZkUgGPajbF6VzM8jGk Eb4PSw2Q2nwdf8u8oqSL+jagkuWGBRTBCT/3yg+K5KM0KDIAPyYvDUDBcyxlZdFNZ5yFW+XvUuA2l j2YZGrbDwe/DyWT8p+OScP85GxMdOVqaleYvQy9436e0QHbejjVAPT/M+nNmvWNSMPaYECyCRzDBU o7JKh1C2k7TZRNrQSHDg4c7KScyry7U8Nly7lSazxyS1RG+JfhOtH8afHeqqpe6iYXXW6Ykl6j5WD R4W2RUyn+zYIwM9QB1Q2QjsIaApoaJK0vNQKEAWbvCYY2u5pl+k1VNmvhL5scAB8pqlMGbYwHtMSy eUt5eIDA==; Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPO-00000000KNa-3v0O for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:44 +0000 Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3f3a6ee569cso483968b6e.0 for ; Mon, 10 Feb 2025 14:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227059; x=1739831859; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=0Rqcay4ojEzq0OjASFQryFmbx3V3rmJmvCj3cKyo38wNxt9uQFvZck8M+NmrYwI8yO J9YH1LHs+e/kufnp3WP0mYiZ87t3/xQlo/iQ1EQMdxymFg1SpLFp8Q4M61N4QBvhL4zb h5fbGNuhtn9dsVTz2p5RIH77u7hRP3dNBj6nOyvbu4l8boCrt0dj/cY5N8YNPRgkYOiM uTH8B4baOSMFGKjLDC0YpU/QAswjEdR2ukOgMgdnt/WF3qV//wsL2cbRNrHhSSKgJMCI qWwHbgEVmDm4l/nM9WPUsj++9HCDXhqOXsWOT9Ekdfj+O9fH4Z7f4IARJlpRxzaR6y/Q RI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227059; x=1739831859; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=rilxEHTgOmqs9GiZNECxDX0Kraq79GTyFfiEm3NT+J4CLU8l2P79twvgnuZDcgWrsB e8Ub7tASkr7v+Nzp9Xs+tq4ypiv/dXXvKlCOKBaTPtFj+vu+1qWhMWg6Pi7GvRrv7W0O rKByRig+Hc+Vfa5Au5h8yQclj/3ElQsxP16fspI2stTYcRqo/fe5rtITGlYHgvPQULLQ wJddUSYOeneQyKn9XKtwPQm2pH/4W5dkxHdIS71wiHlJ+2kknI/4pg+60UKZx5uhnm7g 9EPARNOZxLyDLtNIlZDv65cNtpdI0liEtEwS6T+DjHLYiZ8Eh+hJm33+q12ptx8mjrgG A5Ag== X-Forwarded-Encrypted: i=1; AJvYcCXfOix7YiXvRm+HCfpxFZWX9viEZfddv4HEq5WCgTG677xMun5JGW1d7/hZkLp5axAaZzv2R3P6e9w=@lists.infradead.org X-Gm-Message-State: AOJu0Yz1DYd3ILQq3TEjcGlvwz2HMSKrFjsQaO0RX24u4QT9GdOtXH/P Vi4zBqjnj/qPbRt+r22P31p518RiiOdYlNKU9SYWjLdOQUEhC1HXMB1o2GyJT4Q= X-Gm-Gg: ASbGnctegoASdSX4fYmIE4N3+iWbQy8FTwd5huE8suAPRQAIC67gaovy9jJ/gAMAtz5 Z+XsxK25pB7EgcUhVwxhQ/szjVLfoJXNoPOKm8g46Fzp9GWorbFFjr+Cm+ToNlqAQUqBxqnDWKN VRYsesusO09g7YXflEnsUcoPhBOqEWLqNAK5UFgIGrQIZ/KbcWzy2Xr9WPb8yoZXkJU88Tb5B55 kQjNKkp9oD0rZNvaX9xsEENpPhUUEtmXxDQf9OJcnlwJn7sm1StN+ui7tddUh1gnqc0fiCyI2Mg HPraT4i/3O7vvidugDOB7lqafH+a9670/NgYrYPNsqUQrHQ= X-Google-Smtp-Source: AGHT+IFW6c/bCwKZFJx1mUCSPW7GBmt4Y2h9+oGTyfDUlc4EaqeUGtPptBQHkkXiE7A01fG2q4Y7jw== X-Received: by 2002:a05:6808:3095:b0:3f3:c370:4d65 with SMTP id 5614622812f47-3f3c3704f3cmr548358b6e.20.1739227059360; Mon, 10 Feb 2025 14:37:39 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:37 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:29 -0600 Subject: [PATCH v3 03/15] bus: ts-nbus: validate ts,data-gpios array size MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-3-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223743_090049_2C91DCA7 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Mon Feb 10 22:33:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ED70C021A3 for ; Mon, 10 Feb 2025 22:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QhGyYlyJFHPBMAtEONy4IAmtd0xYnk+nRHIVISMuykM=; b=B9Qa0ROdn80jYu WCl7vbGQwt9YgVawRi6Amx3zbxxpxOetPTFAEXrkVmhp+rB8cdABMy/Z2r6/amRv4NNhf37uPNXOb k6URF8QPnEF3NLbEGIbxUrP1y/v5Ipk0ZW3OokuLs7RB3mh0q1qhlFuKK8LiVydSULROxeUIQx0fK EOObPzbL7euqK3UNdMzOL04fkUBPAtAo3SBwBlkATkmC8YL3ameAwfUYd1WdVpJgG4354MqfhnAxk 289g9TEDi4UlfnfJU6fEoBUYJu9aYM1h3dBLFMhVUUREfI+1xW12KtSJZL6wL5fzJh9fE9RAq6OjW MA4UNtm9XPCiyXinpMwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgm-00000001kTL-0qwf; Mon, 10 Feb 2025 22:55:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPU-00000001gKu-2Q5v for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=GnprzL996I6vPkCtdeUPLgsPCn s+DUXt3TiU5VgJNCYPTgUuThTWDy+vNRa8Mt1pkkrPrMHgbpmzbHS6eT9QWTl/gB42Bc1yjujqYBt aVlDpbV4/eDVWdH2ne564NgEybN2ftQvSp8RHFEvFOHZ2usE3Z6AfYR7oJ0bK30My0Hkyh8FqArGs HCf8FaQf9SxqOx9qY93BknphlIcGO6HsBMvhDR1/o+u28/JqdwmBtciwqi0h1QPrrjq5tRTGTE3kf Q3CrN/yECtgfaFSuaKROy2nX39lSQHbFOCCrr8DRVZkzcJZ/vZxg6n5APRfCBJ+npk1jSM7hnrbQy sbJaK7Dw==; Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPR-00000000KO9-2Ud1 for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:47 +0000 Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3f3bac262f9so586898b6e.1 for ; Mon, 10 Feb 2025 14:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227062; x=1739831862; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=X48alOK8ERiPzI2HKuVpyzctFGTitNejp83FrKCh46Zr/TCrSeDO8suoHd65Pqr8JD gs22HbG3AWv2JpBUOhJjrTQga8Mxk4wsfJOqYdxCPF60HLMGEus63fY3e3VCsEL96+eM 56OChKB10taqAyfkECdrZOc94jT+r08HH16MSnDdKt6MlPgOjhqAl6UdYpENOwlLGt/r xtScRVDEPeOhWmD3BCaahGoeOshKrz83QALbsRvEqJ8Lm+e98eyP6QDAxgOyBVmbwwVf VdJIdyI/b0kwD4+O01P3cTXCfC9k2jSmWEaPTneEAAdgqbQnmC1CgRh9QMHFDy0iL2Nv 4/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227062; x=1739831862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=TXyXn1RaOKcsGtQRWHnx5rxYVTNFUTeG5guBR7AP9USxfATpxQ9IBbyf05ebKzZSTz Sj73mHaVqdgv9tDZ+OkQhnZgvFCK7Kx45L5flne2C2N2OTpEDGOUdqQIbO6ydj5TtEJ5 9Uss/Z8fqAn7hSHzWew7ESStJT5wwZ2h99HAVQwJv27sfApmCEhEesAXwkylA+w4kbKR HyDL5EtQr4CNS4jKzov7nixgNH6Ag9dPcPfYy6y3VWR+s94q0ql4T/8zaSZFcRYmRUbW QvD/BlQAtyQa9nx0KPD5rNhgUT1OsEmkiLqtK07B+cDRs7QFKXoBFf0OnHDgwZJwO+gP O+Bg== X-Forwarded-Encrypted: i=1; AJvYcCVfshuIhfCjy49VHpTbdBs5IxV9MSLY6zGS9gyllrAdsxRf7mR/CUlof2Lzh7njuMs/mdeQjL/sEwU=@lists.infradead.org X-Gm-Message-State: AOJu0Yyj7kCZgiw/w0jrtcjqlK2J1MwdRA0ae/XrZGMsfPQ49XAopgo/ sKwYMy1hnRmsNHjJepo4UQyg/5ZVybCTNx5SMj6GA78SuFiIg1iKZdYsVAFdl9E= X-Gm-Gg: ASbGncsOuN9+mUb3VFIzf9jP3EgkVbzxLILr+9cTcJUIjIKK4yAg/EJo0i1w6Z2udvV jzadAJ9jDkV/XbPPKu3LCXfZfXP0ZoXCvg4LAzRfSspkfUt2VgEdfI+CP4eogLJtzZWedZ8zwQE h3edXRU3GDJ9b4JqrwsMmRAJF5BtvgS6QdAlAfzH4HdrdPtPzF7MZZNY6ZXw0ulBy+PQkeOD7H7 7bUONP6p2pF0olpXeSghZIlulYC3K2JT+uoaTxNY0BJacW2H25IV5bWHooT39OqyjBgPJfrnXns RgwdLWS0T8O/qBNzuHHSD6Hz+MzkbSvrhN/+Rte3qHLKSLE= X-Google-Smtp-Source: AGHT+IGCum5h1AQwvUJNh3Kk51lVy6xq7QJ+B7z8EkY33CFant2nucCBaXwDqcXBpkDagMClSCsXTA== X-Received: by 2002:a05:6808:4099:b0:3f3:b0ae:7998 with SMTP id 5614622812f47-3f3b0ae7b3fmr3901508b6e.17.1739227062548; Mon, 10 Feb 2025 14:37:42 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:41 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:30 -0600 Subject: [PATCH v3 04/15] bus: ts-nbus: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-4-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223745_819792_32225DD0 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } /* From patchwork Mon Feb 10 22:33:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968694 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8969C021A4 for ; Mon, 10 Feb 2025 22:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ApVu+RwpLFG6ftf6bDWwHHlAFrRtvuLIr9bJqJ9k7H4=; b=PKixu6SrPwbWXh sk+A0atUl7560vnlvPPaWngKYV3Zi9yViNhbAHkSNhho8eRh9gFKe1iqMcv2x4qeH0cuZWLSHQWH0 pHXpgdx8v4kqbGR6XrU9Ei/jR3U/1YVzeC6IQZggmczgTxKkAbndgFrPAA8tsXMbVlSE9aiDiu8wV 1WyvRWsYqDZY/dhTM2Zgcg5qWYGusi2OiRLxh/MauQ6+vRTXLQx77MTvY23y9oXeLrS5VhOAGCcPe MTSzOZEl+aHttR6bcvuma3Tm8HsRwfiaw0MvGjKMdPh8KlyGQmmnH3+65Hz6XoJA0mPAfHdDnJdRs Kc6pBkbPT0XQT1xthDWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgm-00000001kU6-2IZS; Mon, 10 Feb 2025 22:55:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPW-00000001gLP-3QNi for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=lQsaI1EqyVAzWxeQH283/GxsQm mZbQxJtCAyw2aVUqOeR7LtXGvpdsk04U/Y1ujIMLvm6TBOV8pJLQR4PjcN881HmTlrwLyp8/apSmo xGKuZNm+m79j6IIHs42Nb1bjuuiYLuFF1jQTWfxCGRZv7zCdjRCqCSplTIty3UhDBgqNyAtQtJ4yr SYDFyIiZJ+J9rHy3aJRL+T8216B6HC6++YQ7ze23rc53UYItbM1cvHrn0bK0wgH2tltMvnwiAAfbl xuGgRxYIgx0tp3AdU+sQAYVxNYkJwTPDmHjFMj7jN43ubb7kvZNa1WgPBqKBXpukFXBhwp8asnzgU xuqAvAqg==; Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPT-00000000KOU-3I8m for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:49 +0000 Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3f3b93f4845so720536b6e.2 for ; Mon, 10 Feb 2025 14:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227065; x=1739831865; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=Ah8MiWhNmEXh7iV1CkTeLs2cHcN36yS92gXo19Ij1t636b/OXW+klGqVNvLQKO2jSz eGNhr2gaqnrua2mnRQwLRuhx9KCTQP2QM0f0qq97xMGJBBYOcSPmD0kGm2i+rMNQKLwr MGLUJbODzhKJcEQFTMHs+p+4gqSK/XIWOtAsSIH+HC/sP9QvweWPeV/3vJSwuAIx4eTL vGqXGSiV7gFt3PHVN7gbXiajC+0bxWUN/+CKTz8WlBDRMBcydGlxUfLQE0zmHEuZv93E CLAGcjeAKWzE3Lt93oNUk9hmuD6/1jvbzaT7F0Y9PYMGNihlKeRMnT6Bfuar7qabxIwt 5KBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227065; x=1739831865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=dn14C3ex0sVIMbWla469ODGxJCakwMTiBbkRcIFzw4gs5Xz6yB6DpUWhloqZPNxAC/ U/QSA3CNGhm6yhZ0H0ecBtGtvLGT+WfNqmWA/fbiHQZI6nVN52LfkKZnf0aiojf7ycr6 FxW+9Kw2+z5wN1jUcnewHZM/BZuK40112xtxvoPKoa2xBKVcPhgJO9lDuLUO4GBJfK9q 3atvg/BzTbMi3+pacmaYAfbn92LVrym04Dah/NkubeUz64QR/9Q9wT8UV8YcQPhcxpEb aOXhOTtmkjwnMnYYL56rzroiGzeqfj7Yf/FP1ZerA05A6P3zOPIGcsdgA9YWXRTUWv51 /GMg== X-Forwarded-Encrypted: i=1; AJvYcCXq1JR/RuuzSpn8DrIAXSeVyb0h4FFrSDeA35bMhHoW1+eaPicGHLyS4w+sFj0Yqogg2+bn+sJFwE8=@lists.infradead.org X-Gm-Message-State: AOJu0YzHKtsIKWst/j1p9PdI8L9tgtIVd2xFig3meEZoXYIAJAr2c6Fz vOyKI+GnSgUDlpuWbfwdXDzr2cdP7Mi0qNp2+hjYCGl40pu2GQ/nXY91WtE4Yeg= X-Gm-Gg: ASbGncuhABBECRxSVrCwCgJU6cIF7srZJXgB2OAzOgGKirBTO9FaS+vMDEZUZAEVQc1 67P9JhA0nMJZGh3cqHjyDXkQUpMhEoTaeGr7JVH1OJYv6ndih0nuqMOX1iaHfJmXw0msyZEXIGM u1UC+wk5fGGO3ew0UNQcLUBaJlv0BPMgJZ8vcZvdxsnR8kGGdWbpcYf6qZQ0C0dt+MPm/Rl+Vbi I5EkeYj0ZqMGFB8Ot9tvzDBFGY4oG/Y60ixiok/ty+BCyA7rjo3tWp/4ZEKs48UfEDpn95zSBnH PvUrV8uYKof4O2gH729+7WcCUT3aDdD0UiSxb0BhshZ3Lg4= X-Google-Smtp-Source: AGHT+IHioMIxu9VGnzXizdV46F3qMiFjs48WUo2oHZz5JGkXBH5C7gXq210bMR9McIstDGpa5KGthg== X-Received: by 2002:a05:6808:319a:b0:3f3:c1e0:c466 with SMTP id 5614622812f47-3f3c1e0c4edmr1094523b6e.5.1739227064928; Mon, 10 Feb 2025 14:37:44 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:43 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:31 -0600 Subject: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Andy Shevchenko , David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223747_975922_B1CB1C94 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Use bitmap_get_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. Suggested-by: Andy Shevchenko Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index b4c9308caf0647a3261071d9527fffce77784af2..beac67f3b820377f8bb1fc4f4ee77e15ee240834 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -10,6 +10,7 @@ * TS-4600 SoM. */ +#include #include #include #include @@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) { DECLARE_BITMAP(values, 8); - values[0] = 0; + bitmap_set_value8(values, byte, 0); gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); @@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { DECLARE_BITMAP(values, 8); - values[0] = byte; + bitmap_set_value8(values, byte, 8); gpiod_multi_set_value_cansleep(ts_nbus->data, values); } From patchwork Mon Feb 10 22:33:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C8F0C021A5 for ; Mon, 10 Feb 2025 22:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CHa02Y/k9SWiDcpgPJ9kK6JzeITo5EMgsDnFKMZNSJ8=; b=kR1JA5o6+KyCVv P+pNAGqLJKirhXHzLEuBh2AZFYldohJLp4aiiLoNBsgBX2L+mHzbeINT0Y5aurX6r9HKUscuzEEub IQiwOkJO2GmTdHTxa/G3bW8ajpZ9pkmguo09cfqTPyXVDvP/AEEHWBS7JxkWshmHdf4ETPyGjJILj JaXQAAUnu9H/HvyI0US785vItJNXXCgmWQhoreTQiYhRrVPfNN487oa8yiE1XfU2TJOm0o0ZgE1Pq ZTyss7hAOhxXDHio7TBNpi2FphPA/rAoStvCJcQp/Z0rL2Y2eV6JzYYDiwqfkXZFfn9lAg09PmKdD kS3ZIGAWrLnKeq0R9mmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgm-00000001kUU-3VIz; Mon, 10 Feb 2025 22:55:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPZ-00000001gME-1tcA for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=aLvHUaXJ81mmUgbbYqpF78/0Wn WXFf7/9qCp5eoFpnMQ5LDpluXX2k+xO2ovZWy8Ds9hgDdc+IO4I7o+K6koRGcbPVyB6bT2rOWtHqU /+15aId3S3Lz+EJe4Gvo4MfDvVZYGDT7WuAoY6OcwNO/zym12DZy0ZPHUVmarMqU/0rzayWI8nVLq W/ADE6JjN6twfEOiBXyoLA8q12G62znz64hF056QVAKQVmVmNgxpqFaLnKkJh7Q1l555/BgqG79+N NZyDlgV3iGLVbxj6Lgojz9TJFNasdbaERmB5icukEyhrUJgyZkkrRiTl8sqk5Yknf+csU/ZRr02ng G3mj+tdg==; Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPV-00000000KPa-1VMw for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:51 +0000 Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3f3b8f6ff68so698336b6e.3 for ; Mon, 10 Feb 2025 14:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227068; x=1739831868; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=FdDghCATlBq9FwXkNhFMozMgbf/tiGLKmndRsHE6kNcuyUM4ZFTbm3gdtHXaO1OaIb cPh1UDaG3XfTyIhTftXdq5dsJbv2k4edIiRpgaKutIcL8/hSNFdb9rNTWASg7sGc8QT6 VcpL9M94otaVdQZFGjRQgfQyl1EcEJQrZNyHzPOpaQDTxqQ+LYfl83km06A9GL+52OeF GhSopgFZppdpzmqZBr8QJ1VE6sJQLgV1PGBL/RMT3C1785psJSAJEWlITX0LNKDDhDNv 8TebdfKSrdkY5mDA9o8/ivJsy7HvcNt9uhfO8ehmMLSjhn2cI9QOP0ZCU7+2QiU1xXr/ nrbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227068; x=1739831868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=D5Zcci9Crlvx6/HCtYid5lo2qTvIl9NwYbZIpyGRlBVqJA0PGUlanx5dCkcCEIjdnB 2hEwxgj2qGI7B5gS6pIa2ymqL7tg1yi47LKn+xWn247Pp0/j9NmIVVIb02dtlTCNVlzf YNczIozJY0ydDbux1Wcm1MF5io6kJdPQBH1b65vupY+nH5Cgh/e9ikPuDH8ZAAtwOdqy kiQQC3zw3jtbpqDEgu2iC3YpV5MBOLkiB2FAY2F0ciUcr97pbVMwQpC01mGp14iVFQxP 2HwZ3Obtwx3JcI4nz4CigKpYrkYWTDvCj39PchUajmqU9i6MRPnQdd5LXCY6hjh5Dy3c 0MNA== X-Forwarded-Encrypted: i=1; AJvYcCWPqWhwqIH71HYrPcRExgjOVKoedZQe5otUXMCvPSHl0IoolMrYPpQglafYEkdlbu0ZE1Z2qysPzNA=@lists.infradead.org X-Gm-Message-State: AOJu0YwGJZDTtAytIPg14JUsXTUjDDJDibsmexBfFEBxHresZCQfHeg0 WC1absQVdhNQciwPu0K2vYAnuqaIWh50KsU23YJ9bdAI9tJMaj9KWDLdPGhviiE= X-Gm-Gg: ASbGncugLyxbmOk2uY0RQ1hMEEbsH/ZBoM2o0OxAZQya417bMtiHXrpwThSV6nl+jhC 7rpwMXUnBhbyCYWQ7G81AM2CwCkZ0zYejvkHg58lbbxaZqA70jFyWBcCjKJjWsG1aVzttDGRLWD /mYPEsT0hosvtkgS7FtRW9a3KbUbLcX3v2RSXq7k6OYwE1LgEgBRq22GWlZ51tqCdjhnJHbpBie mQhyHnO96rSLww7mT4oGLMikVdjxFytZGpd1HMv3koE30FLVsq5XXoOBi75NMjiD7rrOBxYaN9b jT/oztav6fHluWoMZ19R46tA2/6vTIjuyEcjOm4jAd/eF2Q= X-Google-Smtp-Source: AGHT+IFehF7HNx0K+6D6lVInKbCaf1fMxaCHCpkyg1GkxvFsa7pSUfnDQ2Sc+6Hc2oSsp+PH8uo0Jg== X-Received: by 2002:a05:6808:2f13:b0:3eb:8d22:b6ef with SMTP id 5614622812f47-3f3923b0208mr10855482b6e.37.1739227068102; Mon, 10 Feb 2025 14:37:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:46 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:32 -0600 Subject: [PATCH v3 06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-6-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223749_496820_A0067BD6 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Also add max3191x_ namespace prefix to the driver's helper function since we are changing the function signature anyway. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fc0708ab5192bd518bb0e6362f737bacbd549d61 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset, return 0; } -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void max3191x_gpiod_multi_set_single_value(struct gpio_descs *descs, int value) { unsigned long *values; - values = bitmap_alloc(ndescs, GFP_KERNEL); + values = bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiod_multi_set_value_cansleep(descs, values); bitmap_free(values); } @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode = device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + max3191x_gpiod_multi_set_single_value(max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv = device_property_read_bool(dev, "maxim,ignore-undervoltage"); From patchwork Mon Feb 10 22:33:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77630C021A8 for ; Mon, 10 Feb 2025 22:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TOL0d1teaJ9V2Z4nFrmfO4cYI6/Dl51lQDfYBZF08Eg=; b=ctbFtD6a/gG+wc RCWyyjI0YN/pSBENHH8cSWvyZkWMjcc/bCkN3antoh2eYf3SxhFp5VJiDU8vLOWZsXujsTecGYOxZ 1xufGP3m+Ox9azMgfKOOJ7pPyNAWGVA/MObli9ciBkXk68EgM4Ws0FszATONB3wBjm60aSIiT4R+/ 163oNqzQbPGb7riyPrH6IKFRfMKBpaUhZ9oUQZG2UDWs3kjfPXPm54Cs0WurPVRryKrOgP2zg4DZX vXgYNdJBf0Vfqn5ea78Ti1zn8hjJo4so014p/jCy+UaMSjTs/VbGvUcM0Y+ItSgS0jewNqm3wSGJr N4I703WTD/Z+Qmy0dsCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgn-00000001kUo-0kk1; Mon, 10 Feb 2025 22:55:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPb-00000001gMS-1nRy for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=E8M7k6A0n2rYBcWFSkOWzHeIQm AehN+F5rRh/WRmXTUj4bk1vbPHNBOVJ2MHlvA2BWz56zTfuysv5M7M3MkH1Xz8odyZaoKP+SIEa8b 3I7uhpvkEM3ZBahB9PxWvmMW6L6Dvc+q3MliDw5tn4qyJFAvEtUva5Cza7E6aFtdcSLgfij4Vh/C/ 1Yj1QEc5SsEn+c4dmTSvYu11GcDmcBJiRGmeJLrfDdb0Mr3+EeoTMUQQfYURh/eV7OjWg2sLcDrYQ /7jYjceAW/qyK23t9sf3tYZ8T69beDHD6Yz+UgJZnTwwDB2iIY/TL0hguTdOMboAz4dRgQqJeTg15 ebxvhSHA==; Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPY-00000000KQ1-2Rzj for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:54 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3f3bc69c8c6so548312b6e.3 for ; Mon, 10 Feb 2025 14:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227071; x=1739831871; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=QsSeuO2P9kScXI6IQqONW/1zdIFhTtmt5jtIVAbJYomvzZWfhr6Bq0PRhk/VeGqaNz mxUfgmovyr2yVNr5vocUO+ZXXqBis0DS3zI5BaWNd64xI75DfT5pcyW487TC3PYN1Mxa CXIJKZM//Pf5C/i9VAIPa4a6lbJpWGMP7YBfYRB6yfW1UcFmd7zFjIOdLm2RA1Y4WZPR CDhJI882lRxcs3Loq2Q6ZJDbqc/bu4NLbvfFJF6Jf4tsPnqEkZlDuT2IQakmmvgYTija BasJltxjtwKczDRCMJOowiHWuQUBess91RitwTow+wfkZVCr2LjBDXHyLHwjUuXLgR40 +mYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227071; x=1739831871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=QAOlY6xEuoeRgiBSDxUNoWQZ1sHK3POJJoU695ZHCuYW9AdW5i0h++S1ciSGSjqHQb cR5viVMfJsj86KkvVxt9X6AT45o4O0g8Clv2IftqOTlifbguXzjr2kuuI6qfC37mTP3b J4+rmF9Mws2sSOY5YSOxVTQdc22I4bgbM44T2Ny22PNowOqQMSwsHiMUSMjS/cA5iSSd bARiHCJlyaN+gCjdwKYEZPIbyR1ULc3GeStIdFaxjOcSd6EIzzKF8eqZ5BA3RDbqgZeG jDvQ5X+9p3D52EChkIbaKPCQoYpi8xGiW5VxCx2KQa+xQQKjETsr7U5jUEFtMjL7DDkr W5jw== X-Forwarded-Encrypted: i=1; AJvYcCVQtLr8XIPDdCZsAqZfxGdv4PXVJCIFnPcirPza4jrGQstgW04uTOXXyd/hBti6zDpCNTLwl/Lv7D0=@lists.infradead.org X-Gm-Message-State: AOJu0Yw1KXU1k9Z9eOwZ7gPaKjkntpXDOLZXrLY1ztegrNA7re1FPmUB acwbl2cNNL4R6yuOtcZ1xPvqegH7VcfLqVJJVrZ5rXypNRloIV5aSJWuw7toaVBpHbJGuQyAjOr F X-Gm-Gg: ASbGncsNR58Dab6dO9HMK45OZfaCKqY30lxFoTr1SXRWL+RTl1PTJQ1180h62QoxsFt KeOv51tHLY1z5ShMKxvSGmNcfivL65Rb+au4LVeyWIvS9iI53OEkV/ZaiFNgq8ocB3+gnGTu260 5Qhh3IFkqQECt9P2BexJdMkKhAsDQ7JNpMggYg4qo33xgnJDZpNltlO3rCDi3RqecWuwlcpSz4i EUlY9KrbyuxM1U98fE1tsDWOGspW8FfgrncFWeO4cioouNF5w3DnVSwlQhHGcMADdnaz4ETsEjk jyq/5aB1xCeTD7eK1PS2gZLZCncPB3PjLZRCjbvr6LyMUcU= X-Google-Smtp-Source: AGHT+IEqlKxdcHtWmpci4BLtxbDP+p3ZildeCHTAvguDG8QvB4Ez48M4koY5bUOldTogYj+eiwGfHw== X-Received: by 2002:a05:6808:250a:b0:3f3:ba60:f889 with SMTP id 5614622812f47-3f3c2696ddbmr691568b6e.28.1739227071302; Mon, 10 Feb 2025 14:37:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:49 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:33 -0600 Subject: [PATCH v3 07/15] iio: adc: ad7606: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-7-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223752_712671_9EA0315F X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Also drop unnecessary braces while we are at it. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..9a124139924e4a4fbbbd234a8514eb77024442b3 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0] = val & GENMASK(2, 0); - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiod_multi_set_value_cansleep(st->gpio_os, values); /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..091f31edb6604da3a8ec4d2d5328ac6550faa22c 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -296,10 +296,9 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev) * in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ - if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); - } + if (st->gpio_os) + gpiod_multi_set_value_cansleep(st->gpio_os, os); + /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; st->num_os_ratios = ARRAY_SIZE(ad7606B_oversampling_avail); From patchwork Mon Feb 10 22:33:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE61EC021AA for ; Mon, 10 Feb 2025 22:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AK1nkh4qo8qTUWK+u8UhSwt4K9BZh2SPbUhsHw9omWo=; b=gKsZQXhGDqnz0D 9uwN3CsD4l4N2So3TzdDtLvFLp6FII7nblO5n8tXdjVljTLGaBeqLsehjLuGVOqYBZ3NHDUnfqoQ/ DNINuLZ3bTH3OFkj0P/vv6631c1VFmrrkJCtKnrWeOCg7WKytPUu4A5bKEV1PVsVOjhonm607y0us g2AmUOqVL8LWOxHiRjgA1Br8wPk9VzqaWa25PBZZkFoVBAmEYRpkhl2en6gdR0enTvtCyK11CMEfl Bv+SpIlSSZTwCLLb9gY3/Z3h4nXmaFMfnpbji2NNKURBQGG6ahFv4Y2gKE/qaPZhcVl67TYzWehtH uY8T2XAOwQ4Hz4d7H4lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgn-00000001kVL-2BAY; Mon, 10 Feb 2025 22:55:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPe-00000001gNC-37tp for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:37:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=qMGSwdwRowxZShuFK8ALW8hiTL UHPgAgqetv4SKaeobhYiwM3tgEkVEJcmrL4YRYjRHt0u/X2uwpEmHiUJwYNG5VKuwolJAe//MYGU5 WN97cu1EANqtOhBpz7LsdrS4PLtX+IRns45EGrjrj/cW6FX6T42S1zabw8O3bYnoBQrLq5X6xovZQ H25yyxXOqTiZ4l2To8w13gB3bt/s8N90uRUWm8nDN5z9jUcAQFOwVe8fQyG10NCLSITYSqPkeWSpu KjQSXR1MlO/zDDxyy0/6lBkpXcV1uGKvwLz6vFXOakFns3J2KB3JIHHFhnjfx01LGptYwRdYUJ3n2 rxhNt3xg==; Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPb-00000000KRQ-3aIj for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:37:57 +0000 Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3f3ac204922so1247838b6e.3 for ; Mon, 10 Feb 2025 14:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227074; x=1739831874; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=jyw1sW2OqYciQh5a7Zn6hSgwIpbmmijTbNu+CrBttyhAKRynsbVZUu9jFT4Yw3pRip NJ1hB5N/GUVwejkK5l80Gd393ex1o+kvL9gEMJH9PdFNd/jHeSlcwdL+CFS8juRNcrhF fMUrZfl4aO48SyQAcX0NCf75osYHNuGD9VyOjON74B8iSWlg6EhRDwBkvHUaTJvlTfDJ QlaxU78XsHob5nCOvTnuA+JhI2pVt9IEpFcGbyr1hk27B2uyoP2o52zDNpYpA/UqqL7q JLsxFnTOXpiWrtpA6LO4HK/QGShJRv74a6+3FdjPOnIImgrU5ftgEbihLkuO7lnqgCVe fxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227074; x=1739831874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=HhMDNwdUccw9+atZCWNfD3AsvPP9rwOJxyLkXXD4MBt5B1qK5T2cMp1rIGI51Rr4fK v4SJV9SvsoLcu2yJt/IH6ybIq5N/qgQWVoTAAhVFGtktuoSYYZPXcAmZ0ltnLSmdzjpW y8sPMvIAUQDLmK0eyUF1JY3A1rZjz0BtljwScoJu/FwwCVz6JxtLmf7aDynqRwrspeAx 9IoEKAOOsbM0amPuBxI7Zm1IswDUOI9OSPfOzE/l7/3+I1kzJujMI0kFLi5kfOR8zrT0 6VkSRKPo8Hhue+VJbUxoU9aubfLtSCcWTy519jk55zrHvjEDANTzbEzH07NwfNT4mz8g BbQg== X-Forwarded-Encrypted: i=1; AJvYcCXz7EUc5SxFqe7bHNsGgkhme7wynHvqLXF1nrX2pMM13i+wGvEI5NyDA+9R7dZ7M6m8Bb5tG017Ev0=@lists.infradead.org X-Gm-Message-State: AOJu0Yxn3x8Y3jBSNhOHtUcc6L1btlmEc7EhqNnCKl+Egn8KLcycQaZ8 XVT8OPL/Yavna+epWbdBR63xw9PTsFK5v+Y4JZlSKjBSfTjp2HM5mxCdwUvlcqw= X-Gm-Gg: ASbGncv5PA+4fnMT52sxWBf8+fd4GLbvisjL/Wr5/fv7jb0Vgeb9NtTgR6KWKayqNQo IEzCZBM9UC5/aMOpHn56018yDiLeNG21xTJEeH3o7FgszCGB4rRV7XkM7oQyeUF2ZLr7G8q/9W2 jrGISqET1A7dwCgdZ4wzWnOHcQDQJCVSh2ZQ1AbWmmT+4GmZHxQ1zv3aEbLX/8x5GImybk0KvEu S/kdQSSuYC3brR1zupqZAkXSclhXVOWHffh0raz1yNxElh6zmO1OPBXJIB/PHhKGJ3aww+3q0e+ 8Nikr221vM/WKDcppY+I2HLsirGaen9zgQv2bn4b22+f6ds= X-Google-Smtp-Source: AGHT+IHpQCMO/UtYCFM9csSv77tlAPoKshLmX0/bTL0+YDtp28Q6Z4e9EVZz3B9NbqVlL1P+vOnPrw== X-Received: by 2002:a05:6808:1a19:b0:3eb:39f5:de8b with SMTP id 5614622812f47-3f392362d24mr10975894b6e.32.1739227074492; Mon, 10 Feb 2025 14:37:54 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:53 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:34 -0600 Subject: [PATCH v3 08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-8-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223756_066646_E0793A31 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..d9a359e1388a0f3eb5909bf668ff82102286542b 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiod_multi_set_value_cansleep(st->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E4FC021AB for ; Mon, 10 Feb 2025 22:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rN53qPRX6m8hHEesF+w1afNHB5HoeaqePnKQ+8oSsfM=; b=YzyfWlSJfPj1Rm zP6aLDS6yZ9/KH6tEO7GBfS5Y5y250JpZX0MmZJ5zBKvdsgiC/67KxdnACeK1ikIQOoRDSvlVuL3I 5lAkOo7jv4pkTmGDUZ7hMm3EjPhWriiG/p0jc56F320wtNsEgFW4o9egXg8wpWkdKoQcv3+5RrR4+ aYy+yqnIP8jYcKil30y+IPjfdoQZ3hl9k+SDDgWjCY1HIiF/PAPk6114+uQOQ0t/I1izpmqnamT3e qjajRZWanSWh58HJqsFFvNAy6ZxHAuANouqFkWXLfbe+7YUQYZD1tgPq1lfY3YzLCfvemjFu+AvHy SdyIigwLRGcAmPzgD6og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgn-00000001kVz-3SD4; Mon, 10 Feb 2025 22:55:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPj-00000001gOU-2jw7 for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:38:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=YbArmSs1thBnuU1LsIEXSMDUx2 ZRi4wjBWwFtRPvBk96VT6n6klMBVeQTKprYxLSfH66X9HQuyA6c8SFBbpY91iKg8SERKXWV96baAX U5bXNp3xGuytqzYHcU/RfUwtBP1D402oggTWyTwnoW471OjZq+y4Z6rawNi/2qa9EnJ2PhpZB/Yq4 HD29t69W+GZoXFj5IB7GEVIXR04QL9COFYSDpZPZKt3cp6VMNXnLh7l1BUA/vZHZbGM0by9dYv2K5 DHaT0q20cHNircJ5aAQNeZN0KU6WbfXY8rYePW0uzOHQmI4/BK3YTrRGD7BM3nVd6wgnjIJwmm1g2 ma/AQkTA==; Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPg-00000000KRv-2B4X for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:02 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3f3b46db87eso881306b6e.0 for ; Mon, 10 Feb 2025 14:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227078; x=1739831878; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=RyMVqfXW20TXfmKALd9qW4l+gbMCss5HzempNlDcq5+oHJHMmhJL33fvSqaRdYQ+Fn SjqmO3sS4k7y8shiuaHqzITWJQZNOejgEDEQHc8FmhJUeLx6Q7JZ/zOwiG941wZgr5W4 x7rDctBNjwQE0UD81XVHu5OqOfgPp67ThoYVY9ephvF6TE4yXWJzsm03buvnl0V/Nn5o BcVRtwhheEi6SRhvjDluYy+m0hoV26+2xr9I8sx3fhS14j0V1Gc1wQj0MX9yDDuWeF// rIkwgroIRAClmXw28UMEPlRKEyeq7deTKSK3wXxQwbGEY5ckOj5bYfGVmdJHwFnuwnHS 2BUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227078; x=1739831878; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=FgapfMVyKHj09qhmsOEC6mNr1ER2Dsa7KMITLkCmWlN/p392MC98MmBQWx4pIppsdN ognNHHa+klz5eDhFHVCr6U7F4eTI+Oe7T4tXGyvNR3dPtiHYYcSvOaLzlqPnGePGeiCm 7If0BaucdW0/RWiP7yzzG+78OZONVlerIFkzw+i7KKlnJX4tWSUpmOMPmCr2SoJ7ZRWM P0QDedRvi303bVW/QDjVr1HB191YOzcWBRCEzx/YJZfXw9JrOmHjeC6yt6w7Ft2CJrJN iPJNFW1sPg/UkMYJ5jChQK70CoAlPNUOhTDVJ5odb96KSoPKbDArZbOckO3TVJVphW5u fF0g== X-Forwarded-Encrypted: i=1; AJvYcCU7+UGAZVQWVWfGpyNd6Z2J0wdy5VIDF5vNPmfYrBVx/tq+OUudhffZPTxK+DMktGCAjcmgFsGgcHU=@lists.infradead.org X-Gm-Message-State: AOJu0Yz6u1RKlFjQ4aKjhfDE0NiQiqj4c1lhqENe1Xz5aiFRVpg30dkW JlKma/ZwRlUQ/au/c4cD67bDIzYuSMcKt8wUOE1tZZ6hPkRCTbZq5zKWfyQzHqA= X-Gm-Gg: ASbGncsZiL/QIqfkWor49BYMqkUobOQbarcptJDrIxb/pdQshxIHhTcaPpwEitoujGN AnK5qviEcK9918eMjrzkwB72eS0Vil90vJTN1qndLUbkWCyHXj5baFV7FIPHO06hZz25JzlNuLU yerdkKwG7jVu2nXip5QRkCmwk8bC9kLdw3EaLX6OEIE7jRssizFYdTpOVwWzWoV+pI5wLOZkXjR cunvSffLBq0lL4GsjOY8sYVfmlHKxNZ8F30s6po8f1YO9XmnsJoX6lTP1Io/k3lFBMzoBqN0TpP kHPgauVxB8O9czOThojAA7lERCpQ5vjpRg8llwXvFi/nViY= X-Google-Smtp-Source: AGHT+IG3DTzAWvVW4SJ21A/SRgFk31074gXMN9+oGlJqzs/MtMc8XsiOogFgKzSWDZ9AZ40PkdjrRg== X-Received: by 2002:a05:6808:3c8e:b0:3f3:bda5:5739 with SMTP id 5614622812f47-3f3bda570bamr2064722b6e.17.1739227077726; Mon, 10 Feb 2025 14:37:57 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:56 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:35 -0600 Subject: [PATCH v3 09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-9-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223800_781248_DCB28573 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193a49f0677c999f 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiod_multi_set_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); From patchwork Mon Feb 10 22:33:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F842C021AC for ; Mon, 10 Feb 2025 22:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oWBgm6XWELtmmC3GJnBGNBu+cYcbF128atT1HQ/4A3E=; b=YmAw7BkKorxSGP ozzzyGqOECQhCzjCITmVj2gXYyrCNYAaeC5sva5mUynPjOb2R7RZ+zOmEotHchbscCpI6CBFz3YWi XY2PflmIzgDZNZc6SMOhx7MbLnAirucpjS0ekxx0SYVtYX3ObxGvvZEJd19Tnbj1Vdz9HQlF6aqR8 qMH0wNnO7zFJgePJBGno86a3sDBK7mkFX/DpgrgO+5KLr/eZxsmWkrGn3/fsVGoSmq6PQtKjmfJ52 VTzkPm8RgAZOYnYbbFWEZDDbWwmVdU/DccryMX9KrVwJzKzu/0FIfn3we8xNb0QBa1aohEVy6fIoM NE+uujBst9w9lYhXyrGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgo-00000001kWX-0d4V; Mon, 10 Feb 2025 22:55:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPm-00000001gP2-34Pw for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:38:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=akekMo+rxAWaXDg5XiyLl/53Dv XGERwnc5SSy32wp0UM2fclLZW7LssXjNg+z7oRKjSDTCPhqyTAWDVtWps5p0M0C0IxEprTLnTenAB Pe7qP756J5c7wyX/tKD9m+FOoOrM3ocLA/LT63SSB3puzTUka/K/70GJPTtDPy7rLBqSHvA7cG65R 3GNpFOukps7uRSdIQI6TKPOlRDNIHKIPYOCCVpCIC5C6lTnGA6vI9Gvxsa/ErCyEJQu8c8khvyBzB 9NiY1DDAyCJtD+L9tls7tgrshsQ14nJsBaCj7NdhUJVexLgqc53zW9PDUzZdNF3Cp23fcnbMVoabA qhOTdwzw==; Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPj-00000000KSk-3K0J for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:05 +0000 Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3f3ba3d0433so594290b6e.2 for ; Mon, 10 Feb 2025 14:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227081; x=1739831881; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=W01KMqw5+S6CfUwWUYNdl+7GO4CqZEZuNvE6zBg95OIFTdFEdG70G5YWz2cU/qR+0S oYvxLWUxZnx3j/S7CGj4LDIqG394fDq2YywF0G1bdBWpLgZqVYAGodbWSI1O+XWtQ/bv kB5k3IgI8LJ7uuL91B01lGBepMzEtsJMlx4cz/xZOki1GdLqQP7gRmbORNz8hyfOzL1i nnydDqykk/E8vXjxIdEKPDRHnDR/aC8eyttz3MAcco8iaDtl2zdND+BBwJJ3RVN8qlnI gLnSaDrboRUHQVllxlFP/65UqU3bLvu6tZU75ot6apKyJwQXbzBJT1JpYZqon8DhvBS6 ZSGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227081; x=1739831881; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=Pf3EySmRdId2t/SjvWhZmNY/2QRMp3/ZpmNZJb4TyjJaUnD96CKaqWdY+eMpBNOYLn QZnPvw4N1IlEwwo57GTY9Aherun2AkPahCV3uAeocm0TyVpkD9N/6jxJaHzI4c/VXyoH /COBbbp16FHn1Tth4UlhCR4BH1h2+8WeuwHpS5m+HekFQydOl/SN7WPB4+Qp2v+w8tsE ea7gUrgLop7TYbqFJcZgKQozCp7JMucIB+fCso8Sa2rmq1kjgFZSFjzP6DFZ/tzSoFOX 9viBJE4NlOWu8U971Hb5+Vwe0NsDo69LNQlSMj5BbnSYFnjXPCOsR4L4Pq7xffzjqtwM z4PA== X-Forwarded-Encrypted: i=1; AJvYcCUEe90gcLiGjtzMT3ERLU0wb73YQJF9h8q4yE4JjMN+9hKQQuLIRokDkgLQI7ezmow+DF9aSb6Ip00=@lists.infradead.org X-Gm-Message-State: AOJu0YxPtzjRsVRvxgNNK1KrF3NashHYxJgo82V8xHH6yiiECNig4v1t H71YZN+U4Kr7rmo2cpj/oCpwN2FkMT6poBgGTrk/g6/7TMhmN4mYPOJ10wbneyY= X-Gm-Gg: ASbGncsuh4QvNHEj1Jdf338lNbaV3IMbCsxjZp3pM0fHn/CYjgxeqkT3ym4PJKVuZrn KOkOP7hdi+Xk9t6psC+v68v5QHYdN9OElEJiJ1vaXzJmnzq4IUeAJ3J2gZOTNDv65ChEOTfesr6 rvGd24Ko60ZRuH0ZwWkbcb0/LdeUQC2UfRpj/5PEY9WIxzUqtMJ7HyMZvDXTqdkSv5iIf4/GmN2 E1BTmbU35abnHNDJw04LmbICD5ObVJicruao/jdasRiCPV+iPF+GiJdt5615oLIodc5s8KyC9VC JS/+4Gibq7mXVuXB64tl0OlPBUCDGWtvthEYgre6ToJ7pxU= X-Google-Smtp-Source: AGHT+IGzPPZHWL9nm38yMUud0RRSbV/Ra+QmKEWIgQuJSF5KnPaRf3ayet85Wv9392Tvxy5qCKs2yQ== X-Received: by 2002:a05:6808:3c8a:b0:3eb:4681:a895 with SMTP id 5614622812f47-3f3921f0b9cmr10552910b6e.7.1739227080875; Mon, 10 Feb 2025 14:38:00 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:59 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:36 -0600 Subject: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-10-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223804_035234_489AFE8B X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Replace bitmap array access with bitmap_write. Accessing the bitmap array directly is not recommended and now there is a helper function that can be used. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index 7f18df790157f1e411fb70de193a49f0677c999f..04879e6d538bce664469c5f6759d8b1cedea16e9 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -46,6 +46,7 @@ */ #include +#include #include #include #include @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) if (!gpios) return mode == st->fixed_mode ? 0 : -EOPNOTSUPP; - bitmap[0] = mode; + bitmap_write(bitmap, mode, 0, 2); return gpiod_multi_set_value_cansleep(gpios, bitmap); } @@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) return dev_err_probe(dev, -EINVAL, "requires exactly 2 resolution-gpios\n"); - bitmap[0] = st->resolution; + bitmap_write(bitmap, st->resolution, 0, 2); ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) From patchwork Mon Feb 10 22:33:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0F6EC021A7 for ; Mon, 10 Feb 2025 22:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iMkHR476oMdYSvp6v8ZsQOT5MNrVHOBoslWMHDv69AQ=; b=1L84OOw0hpor4i Ru2qZavKxiH2Ebcgo1P9H89mgZIFcbp25wfNl8adsUbIvkkoj3j2iJ/sHsPTuKEuaV8DqjOVndYd1 CfilRsVM8Ft31K1nxi0KACAiAlBRRHmWtXAcODbxMHQ17n2iyOLieKPngk/vXKmBfpFGevMwu1sIy X1UtmginMv3i4jFkoe2bq1VYjtMNbX9MwO8e3WRrK9K1WvPYQ/A8zvV6G1ZuRHK0HJN/uDglxJ+U8 DKcxObIMC99ul4gmZI07Trmygo5U7w2ZKkByeOC/aDJcbQcpjeV2xcOAVN19SZVJYRHZb7eTLUxV7 nshrZgSBdp6uNo82BXgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgo-00000001kX3-1p6l; Mon, 10 Feb 2025 22:55:42 +0000 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPl-00000001gOf-2UXH for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:07 +0000 Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3f34101f68eso984234b6e.0 for ; Mon, 10 Feb 2025 14:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227084; x=1739831884; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=mk0hXkOyX5jtC7lDs39VgcJvN7kSnQhGk4/pnRySTNdG4j+F5KgieMhYweDzoBtvkd RKoUbykNPcW0M9y1XNeBT78XGXUiMdvnCSeBtJnIIcwRhOdJoQakzTXIEaa2wMl6E5p4 tmMCaimBQdNPMQd2dw1xJOpAsU0GS5vXGxgwv8N/eCyhLjDjUeiDX/Z+js40//GdMbvt jHnVesI04LVDzQz0NnazX9/v7GLeGNPO6vxd7VSA2aLytTWZbw1wx8dvd5IDQnbUUH3d 8+FV8UAQNGqQTUvgzKdWMKIm1c2fcsPeJtOQOEqDDHdKx3Lrxcvoys4C5ifjwvm9HtsM E8CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227084; x=1739831884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=b2E2R99nQ05fUntEdA7Y66IzlOoMi2XBpPC1TmnjHUEcM1gIJm8gcUNjafzoiSACIt RUZC9/h8Jhw/06J5vqmv1zKGyRT781BeX8Za3maXs9PxZlxHN/qf5ztw5uolMueB3jBw zNhodNzv5f21rpbHBUSIYdif5UBBPHpwRmG8B8ccDaVbf8t9EsBm7U+TpBJJfv8MvFOU QqOzKhGwAS5N95ZPWu8/YVVeSKxj41Wsypov93jLGAZIWU4pclmU09ymH7j1RU8lv1tb 2vmkgGqqjrvgOstlHVnWZ1lrQ8vodiQ3pb9ExiGAJf5L+dkNvRRD0EqLLOjK3lj4/Y01 c6lg== X-Forwarded-Encrypted: i=1; AJvYcCVZq8337By1v6c6iyv7jigYYl9aQmLiHdVxsT3XysOBba9HEIzTgRG2AO/F/D/P3cqxM278EllLKzI=@lists.infradead.org X-Gm-Message-State: AOJu0YwMUOfmOnTf1++BQjl+V9v8P4vzeKzMoIA+yWm1UPuwU+Y2ZcMi mjlgNl5BmH44nDiBmAiKsY6V9sTeV++my0+Yt5Dw/XyoeEJToF8QU/N8EjW7ADE= X-Gm-Gg: ASbGncus1mOLkWmqtnve0UaNw2v57cnqpm1bjas7DV+9URk+HO92OFq0KYiHQnsAr5x +gL/L9Rx/zKWPD/luyijnW+I627aWUZxecwmL0zgS1c4Ri7bOmM6jI/bjYyPvdHhDwpryxshaEX vh3gQ/zD1L2T06Y37YxKsttn5YNX+5pSCvrE5+ndLWTtY8s9wRTsaNiYok3rf0PTEHjDL0ohvZ+ ZR5xNFHu4evl3hYQepEeBAdhrc79Vy612r2vcYBhFTf4xIYhTH21cJCQmSzXzbr2hbFSF7YpBPl iYuO/bu3qtWipE6S+KaJw3UGZZhlL9ChcCBnvT4d+gW0S28= X-Google-Smtp-Source: AGHT+IHyCAwDYiRcWVzrn7K/Vx60yNjdpFZhmlXwDMeVTAgENeKIRtjDdhXHEsiUOrCJ2abC/Ga6Zw== X-Received: by 2002:a05:6808:2209:b0:3f3:ba53:1e11 with SMTP id 5614622812f47-3f3ba53229amr2521701b6e.6.1739227084078; Mon, 10 Feb 2025 14:38:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:02 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:37 -0600 Subject: [PATCH v3 11/15] mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-11-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_143805_634956_2E5481F7 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Ulf Hansson Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..4b47e6c3b04b99dc328a8b063665a76340a8e0d0 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiod_multi_set_value_cansleep(reset_gpios, values); bitmap_free(values); } From patchwork Mon Feb 10 22:33:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0978BC021AE for ; Mon, 10 Feb 2025 22:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/k5FPH38Hnp+a2048IsfzuL4hym2p2gsbtH7VmoZ5Tk=; b=EXYo6yZJdd4fFF t5gCxUufKvLaspSGgfUklgmrruvSW1Kqk5xUj/TN4K/7rbjuQrAR5ISjvSKFEE6PDJDwhzyTYqgfg /QWQEWil1dFVJYOC5KSQ2NmrskqrIpTQq+5ZUdghRZcIqgWny3opZHQmgtIg/LDW+h1Kb2ruhwi2V Q5/p3cHugcL70IJC499PEgiUyybQp6o5rjmizqkqXLz6Yx97VXT4m6xNjif1BAzqrvaBj9hhm2rtu 8x25J9KU+SeyURDrzapvZXc2MJrBRlHQ50kJrO1NNZeSkwG+4FpWpJ1GSq/AoNlm2lk9x2IAPai/p 5+pIdZKBKa4NAInoJdZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgo-00000001kXZ-38D5; Mon, 10 Feb 2025 22:55:42 +0000 Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPo-00000001gPr-17aG for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:09 +0000 Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3f3bc69c8c6so548451b6e.3 for ; Mon, 10 Feb 2025 14:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227087; x=1739831887; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=0NCBk+2pbC68rn7irpjlH+wAObOooUpuixwSK0LkMje6pWFrPomc9r0GnD+o4eL4/B OHbBP84/LjHmQ8qb93z4RjiCFU+cSJsgmEpjPJPXXNod+w0gO0vOmj0O6HT9YvzC7LPM EGhp3M2SM09d079uauN43UKSViAaz4G23SCjhpVkFqhJY6R1Fg38Y8mAcHbxDGtKPV7J LhVLN1Ue7qCFL6iar/OeQhOUluB5tdPt3APMGMQrWp+IXTV2uqKmM/E10Scuu2Sjo3QE V8rXdHlowKtF3x2HC2c6n6vZyBVjRShm9sTDbF0CQ6clqvSb0QnUrUltkHkm/tNFTRM2 TgOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227087; x=1739831887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=ZcrORATw70hT6F+8aOVhhHBK4zrHw9pVE5tmK8fYo2q2kobgIR+FCsgHMcvkh5Ggu9 RaVfXEB3pOo+48YQJ3Yc6D9J16oHj0qtM3cmYECq8MZFccONA5pD9V5FwGGUM63nkNDc WWRpkcO+akVodvxLA/54IvrnPFEf5Y+Rnd3WcDWE0bHrn9LI0q56sf6Ew+fv4zmR3RpD NMuAhEBUPJCnOvSHJJ7jN4JEqdDktTfbZE2W0ZPL+NnUASZRzZosZRTPynqeNlr4noD/ JUiKRn5+pTT7aLWvmekb5VjdvpQNYMwTqsBbSr4jPk/2S0RtEl7tHS/7055P4E5evvPZ Q6sw== X-Forwarded-Encrypted: i=1; AJvYcCV2UiJHMR2WWJMXEq7Et12NgIPl4hKdJGA+4DRJ0n+xjhcUZV6GyW6F4RXJgGnKrmWaavmwZs4tmzk=@lists.infradead.org X-Gm-Message-State: AOJu0YxxU1F3vcIkWUZWX4EdZouBHWYqXQlp0+JAHUro0rJi7O77k+c7 YviuX5bFGHsHOTnJrTn4DGyhqSlwysP8vy54ISN4udTq27DSObEF8lhMMJj6AHw= X-Gm-Gg: ASbGncujVvPcZDvaEUcwOLAtC65AuGSH8tinSeD6dJfYGp3y8W5l9jGGvyC6SJZyTwq Z6biKgIDcpP2V0uUrh8Z6F0l7cgaerFfWWX1gwneQtRDlad2a0IytRntqWCS4tDnKVaM4w/8jlW dO5IgVpBRIYMCT5Sw0/t4Ksbi8KFJfJK5N+nXiofmSN8tFtO0VIUz9ytpAuE7TMoRy8qxN8siLL FjMNogcJmVTzzC5rfKNfv6BtHF8zhM/lGS9OZkVP0BzY4kmX3UE3ZszGyXRlmJ07G48YYMlGTO5 2kO7WA9i74DzafFbhr+fZ2OaJP+HUY+5hSJCQU0V2vlqdYY= X-Google-Smtp-Source: AGHT+IFodsa1xU/+j9iOyHK4zd5srfGLBws68RU1hOd0Hvn3EqSmNLjWe0xJTDgUwSiCbolk4Lse1g== X-Received: by 2002:a05:6808:23cb:b0:3eb:5f1a:d083 with SMTP id 5614622812f47-3f3c2633408mr767124b6e.20.1739227087286; Mon, 10 Feb 2025 14:38:07 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:05 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:38 -0600 Subject: [PATCH v3 12/15] mux: gpio: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-12-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_143808_306216_E3D4F3D8 X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Peter Rosin Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..5710879cd47f89b6ef4458d6b4419a1fe9ad349f 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state) bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiod_multi_set_value_cansleep(mux_gpio->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43AFDC021AF for ; Mon, 10 Feb 2025 22:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0tAvXx9N/0PdLKCFUMbf7rVpPTIxlczjmFSu1d/8Oi4=; b=Y/kxhgzU4JkAdc /M2BQpXuv8ODfTvBQwef2pmyuW8tSCHwai00SoZSp8U7UD/EVcKzWgaEGPhTTs9cXOkK7TGqK4y1/ lkuIzICPe9ZejuTyzn0/S/Usoa/H7U1snudw5FIMU6ne8OY3d8655oQTC1mo98FxldGU+7nsNqgCZ 6pzVF2CzjmTW2dDKT7ZjKaSQj525BCOwGjp2eFsB8nB1VXo3pHmoO/0pA0j5TVLbl5lpwg8pZH0Dc MJMN5pat5wQLlWcz0wcWKJJGd4oRKcSVEk/bDqBVLWa+RHoFBql9RhUqNiDJ/zioCn4keN4CATAZ+ u77FRjUt05gkkqjpUBdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgp-00000001kY0-01eY; Mon, 10 Feb 2025 22:55:43 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPu-00000001gSC-3ZMR for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:38:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=aesMUnoucWiUVaR2AQk2tnzR8p Hga7tQrVgQpSQ+sXLXkI+Sxo/ibt9u+U5ZSzHuI7Q1pZ4szhOTaB18fZCW2l0pAiIwHxS2X3KyWOS YYwZVV7/xKc0EWy3KZF8KBKPMDSr8qYn9tMjI5wrOAO6AsXVsTS87u419RbUYcopq7ECOiQ897nzB a4WH9xyUeRiqJbb9Dtf8cYnRo4Dw0/DLDqtHFp2ChpToWz8KmQ60ndxOGvRw8MGNA5pF/cNJeskol SJdUBPzoTT5J1cQmWAwcxfGXK2FVyPz/Kb+zwendm7jr1nOiujhjjItzvL5f7qUuEHS9Jr6CvaaUz ImyD7V9w==; Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPr-00000000KTY-3rce for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:13 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3f3b93e4e32so650351b6e.0 for ; Mon, 10 Feb 2025 14:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227090; x=1739831890; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=l4XnQ4lnMroQLfe2CWEAA5fSRDmqEXawcdu3hGDP/n2qOEwyTuHw8t97NDKUUUg/hQ n37gur9pFbC7qZblepe3vBrITHrvrlGUnrW8HVCeUow/CXK/hAcfPfC46hT162CWTjBf eEmFTwHqvJU7dqtdWYkrmHCG8ObOTnqQjUjWCLMUyx6BStKy5Nn++2TvI+tP1SMqR/eV MQLRH7gUDie/TpvAcwJ2kdslM50uHrgYkFB5x4EUNraQoE4FkUkqDAxyoriJVrjS6BwF KAkMkBLsWzcIdkr4kss4xsIjd6snccTytvR0UP1BCt8wOurNCAV4A11aa1i+0RulKqF4 6atQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227090; x=1739831890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=U36ay3SCu+Mi0+qGHzmEXS3TnWzIgvsx3svENv1FujAIbgDxyjsSWzEvkP4/QKC1e4 PhVZQx06idiGIoWvgjdhzRl26WC2VDBOXS+gy/06eyKIpsV1mNII/S2nhg591mwraJHd 2Slj4B434rCQ/ZmN6AsZ0k9e3lmUFhhBEJ9YNzftTV2JQAdMvqvp/4Y5Qpd3fQiIVCEC mCnCu+h1n62T6AAea+X1T2HM5w3nrjPVqeLrq4BvkEKW3fpdZbDBzocsVeU0IzgzbUzp 8wUS8ufXN2z5QlJAM44PvhMNgyNI10uLnLr3fXCLtdqdJWgvBRV5KxXt2UXaf7U58/8h /lnA== X-Forwarded-Encrypted: i=1; AJvYcCWNHd/mnytIhmsX/JCLrHe5qRdyTFgok1S0U1G203kz1LUSpXCo80XYltAi+xkhQlhc0HotdV5Ze7Q=@lists.infradead.org X-Gm-Message-State: AOJu0Yx94E51hMLdIUd7+6m1oaat8xgLCr4rXMsEU+6prUHfoveyeoAE ttlTnibnpZP/ghedC0kIueJxBGk8/oi0OL3oeuxLR7s84pIpp2y/De/V3G96uDc= X-Gm-Gg: ASbGncs9FuiPHFpS9RKR/UxVTbpbNshI6Jc3wddiXZFe9vl7hOOMdv2mMInP9rKdqB3 QMNubpiUKkbE/XX5LaO7SksJ8nr1PaT5D4qFo2BCO9YXpKLqLnxNtgXXgjTiOFW9W9IE6GgnNCb FZbi1wg1o+0AW8dnMGy+pV8XgwVvN3EQ7gByoHL2ezzboV9EhlDNmIjPUe690Ajz5KepuG9v2zP FA26UT2pItN79JneYF3figqVs+QMHOJeqkkbHSTqvCWP05uOVr32GcflJXQw5iWn7utR8p73ijE pgLs/oRaTV1Is8Du+A18d+2yoyXmfOw4Yjotkd+LFiAgbZ0= X-Google-Smtp-Source: AGHT+IExgIdSlhgQSDcOsxwx6WPuocJhwApgTGH7w9m44PNZh2BZdc/bphIdIFYjyr15eu6B7MhSQQ== X-Received: by 2002:a05:6808:308e:b0:3e6:54c8:fad3 with SMTP id 5614622812f47-3f3c2abf6c3mr690448b6e.19.1739227090579; Mon, 10 Feb 2025 14:38:10 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:09 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:39 -0600 Subject: [PATCH v3 13/15] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-13-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223812_134736_6F5C8BB5 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..fefa40ea5227c5a35d89ec2c6f95c6668a2470f6 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0] = desired_child; - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiod_multi_set_value_cansleep(s->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968704 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8B98C021B0 for ; Mon, 10 Feb 2025 22:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J2GMJRVXUlJ6uxL+2YFdZuz7FQgT7AmzR8OsNGToXLM=; b=2j196h7Foga4fN 2b7xZ+qxEGx2W0CgFNohiQNF924YK990xLnITNMG4piAgNnNTyrIVGXa2DQzItR46K6+2+PU6pOhf 6MdASIDboQZaHSG2lzWVp9VuBrbshhVrF5VGngKFs1hhCViTXHR5SGOUuw8sA73FUqNhO6yKTfqy7 cimzCmHrAsKFaR5Epv1OjHgp2lFT3HpZ/XwvSjF0AjnNdDH7Ibh+12suCPzuCYtfC+PUhoZ2iz+wE iP/Do4VyUG2Mp8NeDrJ/CsLvRKJzKDwEQFGkyynjufj19EwdcIPR59m11ngGv4YXkKLDRhEhAfWBv 5dx/2ev7AJBHWqeIRLQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgq-00000001kZc-2LzP; Mon, 10 Feb 2025 22:55:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPz-00000001gUD-2we6 for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=RM15PzPojE1Y5ynmThVQsq04Mo XO4O2p493Nja9NcR+K/bOAn9V5x5TaRn+HCNNWq+4vqA75Xm+ETwaAOlaQ78bWcz5YV9ae3nKAD61 hqTmxvT2vWSn6SSuNpTXzfuqAWKHhcvhjS3MzYXDQwJ++vlDFpm7+1GZPsa3rO5hejrDZoEz4wFxh M1ywSsv6xtqKGMeehiC0/cpQlRLMy6XjNVpOfjZ8+YQPPLUsmMo2uMptU4L4o86kvx3kjdizIyX52 ZIKW23jO7kTov5O4jOSRGWGNBAvkY/QUNEGMNgFsWOxHQodwGQf7AeY1seFtCaOdc0sxeep3VPne8 wc2FC1mg==; Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPw-00000000KU9-2kcy for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:18 +0000 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3f3a6ee569cso484187b6e.0 for ; Mon, 10 Feb 2025 14:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227094; x=1739831894; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=KCno6SoPLXIjJf+kdmHw8rLawrfQKoTx1Pn4mp2hlRjF7H/XUMuq3VaWnnL6JtSgro FHTrKmDKzBhrmYzv9Cwla9DHJBqKuH2CB9hzyLNICOrblGewsmT3pk0mnm7pO5ZmTCWJ 9T+d22aHFdmsgvgb/SvN2IN8HsObd0tE4TZ0YeQvwuNOntxNEtNMEL2g+Pa5pGxFfpXC z/8K0QnLukXNvem6KpBFU9MXmovt3Axs5pP9rmasCUovAPTj3HVlAYWtV722KP6qP5rK V7wtytKs7wpl+NQYkfKPMOCDeGcsiTYMQFgGcBpfZD1pVyrEsx4DB5barJH6dL2NlngM Dnqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227094; x=1739831894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=EIbDWaA5LyX185dbNnzj37k9OAfRo+WK/tOOoOzIodgrToCasQ42eNfsm2BAQ7Z5KC yUN9jeVhU5EZClxguMbZ8rvweh9Pf1OT74RJemDMgGAI7EDWcOkhDPwQXBYtM5EQOGll JGwAg6ZmQPKAO6mGYq3pPubU/MjklvrAaD3qtiW3+GwTvmhO5kWdiwSgfAZqAlnaAmL4 bX6R3jya0b4WRK5DUOGN5v+pLSvsxCumh5mBC1y96zHLPK7tqYs9SIEvTLWsSZqWbiH9 5nok+R5NEhO8J7+HRci+nqXimsJTdN1Cs6+Mb3i9o+eifXGAKcAJbN5bPTBlrH/ctsXQ eQLA== X-Forwarded-Encrypted: i=1; AJvYcCU987+dgZLcLX9MbNsSPzFah0LUOwnxT6hqcc3ak4SWUkCUK7PapF0vfB5+/W+oyy5FVBI1PK8nb+A=@lists.infradead.org X-Gm-Message-State: AOJu0YxKcWN0uGTr3mbpudSG39RFpNVWaagk2Nccmr/fJ2chmESH9nhN ThESUt8AlShuQcy5eeGpVwUCFWY6b9NfgtQxuG8rOK9UaQHT+9viHVHgZMUfj8M= X-Gm-Gg: ASbGncstJMfYdmxMf0+5vUXfBRHd7JIQFMH9FlzuJvSdXUrEiPyf0488EhbCQw7h6k5 iAjARwAlE51CfH9bYOwUmiodgJv2Fyi74NEPgvN0LIVRiS3jq5y4XabvQP1KJJBqKTG6sE7IHN3 ziB2neDa/b3BfH3umgCgXDwO09XRBHNE6ky6gSnFz3F+8DfMIbk7PR7SGJqsDWMP4ibrnn1C4Bg ecLpEh9Ch+Gm/qEeuZ4Uv2uzbHsKntEIFuX3oSGKHDXg4tI8yE81vjXJiVdCgUM4yjX6g/buaM4 3YVje6tSn+W2bbur37TdujgIQpdUqSwoC7nRp7V+T46/gTU= X-Google-Smtp-Source: AGHT+IEVAt15PQdS8DVNqyeJacSiAcXpbNeOp6OkG5/0y5b43SqHZC4XrUJm46YNpLSsnE3NWRVPBQ== X-Received: by 2002:a05:6808:150e:b0:3ea:519e:cc71 with SMTP id 5614622812f47-3f39242c9d0mr8056705b6e.39.1739227093792; Mon, 10 Feb 2025 14:38:13 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:12 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:40 -0600 Subject: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-14-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223817_004694_60333677 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Vinod Koul --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } /** From patchwork Mon Feb 10 22:33:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968705 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81123C021B1 for ; Mon, 10 Feb 2025 22:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4pYHTh0GgHhmzhCgd6Ki2KjaS7jWnCpqpAbL/+di8zI=; b=mMAkZTpORHk7s/ 7rjGM4XYsIDOnipwCwKTMWh8nkkeV4qdatVSxlp67YL4/33NY/H/zktfRy4guIorsA/+4XcVFph4p hmkQnszNTAhN8pG2Xmxf2QhTlZX8Y/Fh9VIasbDkbOnBUlP7qzgDI1Emp8WBcTf3XKO63QC0wm/84 UM/e+u3ZvLcWnyXJixlt8af1PLbx7qQ8a4Oyyt7jv4yvtVgrsrDGXBTuKr1hYNatG0NbwXP31tghq v+AxuUVnvGDUAUM/bV+q7I4w4ormKiPcUk6LfIgufdZee0+Ho6HHQReOCUsLg4hluvAakAdTjuvHs xpV8r4W9WvQpJl981bYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgp-00000001kYI-1B3e; Mon, 10 Feb 2025 22:55:44 +0000 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPy-00000001gT4-06eC for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:19 +0000 Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3f3b96246bdso697781b6e.0 for ; Mon, 10 Feb 2025 14:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227097; x=1739831897; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=P6IwoSZt5vxc1NGfHNpAM4grX4J5FetS9zmg3GU6frdv2ur+R88ZVFtYC6ImXZjjAn a6GdDsDsF2MGH7r3+WbNxHN5tFbd1ABLOJtLxvyFyhK42fR9LuZTddY5d7ADWOWcd3lS KR3eYHFyJdUxKYZ3Xlweppn6JMgUjgty3UTgtzi7zFz1DJO9krd9URRZ1VkuTM00BlWu a+rk5bbuQGmFWARq6gd9xOVc+PSNOLcFuCTpCdgEwsPqfY8zXTom8wZySRzG3RvBorv0 Fsb+uAtQFSdXB9cagi8x91mqYUvJXshFS4t85Jmc8jnTFJonOOXeWvKaw8uVayf/oJUv ygNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227097; x=1739831897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=sc6DIJf8CCM18iZINRXEslQGG9FtCta0T77OuAICjRycb6wBIsH/CtFxDvFSm+JqmE NGo61M/iO3KiUmLskMmxNagoiKQgw9BGTfQ8/AOLevS0IjoJLL7h64SBUcHgFRueM5bQ RhtfXI0jSmcCEkHhryhiqSvGC4QrnqC2O2DE5YwTBhXVQ3pRJjach/g1+d5CVhvBh4cr XITZkR7XepvpdZ6n6aLkZj2yS76h+f0PBq4ISf1NrQGOFJCJV7f3On2ShMfu34I0TDmE 2+lsDLesQovtqwe9oJBo1/RZQM2h80HOcZwB1n8PaauIH3JxRWGT1Zq0m6pwUxhzR0Xc nt6g== X-Forwarded-Encrypted: i=1; AJvYcCWpOz6ujCw88fYioHxMXbE+FbqqRlXFZ66C8zTqTj1ij2PtHpJ4OL26/xpxSOv/W26SXJLXnfph6Kk=@lists.infradead.org X-Gm-Message-State: AOJu0YyprXW2Mgz4MEILw2sfMfxYZJKafEx1B0KBavgqDwyQEFGRlw1H Ir5+AgawwUKQjaq/sBavRZqgsXG9HtJZP9Szg6thdoMalZr8jQa9D0U7brelipo= X-Gm-Gg: ASbGnctfAeyjgTyo6ahc7/P0GkgvkthlDMBWmkZMLe6Eu6fUv2zFJJ2qtG1de/IVQc6 3XxVnIk5vG8wpf1hcAWTXuuO2D/qvN9rfeoZL6v64TBp4hjWIEIetf6U0DnuuFXMuE7I7KQHHCg UkOUDM9FX4LuNAFLakog6UznuZI3fIKwxXvE/yWmuNis1jZtg/U4vk4fmNfyC77iSWkBJ139T6i gCosmYUqTCazCkp5sIkf11cv1qXl+bCzu8/4kfDPCapF5yVRdYGb69d8dPz0ZMWPGpJiEh8gAXj QdIDeXw7raVTgCgOToNcl4v93rOydSeWIxpW0rEpoQX5DlE= X-Google-Smtp-Source: AGHT+IENohB4+Vdl15nvUdajyBJJbaG44s39TfMb4Zf97z1Hi7JTuCyMgAhZEnJb83znOkXtS3I7Kg== X-Received: by 2002:a05:6808:10c7:b0:3f3:be50:2a69 with SMTP id 5614622812f47-3f3be502d24mr1971166b6e.17.1739227097004; Mon, 10 Feb 2025 14:38:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:15 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:41 -0600 Subject: [PATCH v3 15/15] ASoC: adau1701: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-15-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_143818_066316_FC561D27 X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Mark Brown Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..6876462d8bdbb41d551f776c2d7fe6ed46115fa1 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiod_multi_set_value_cansleep(adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;