From patchwork Mon Feb 10 21:29:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CD66C0219D for ; Mon, 10 Feb 2025 21:31:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbLd-0003cX-Ap; Mon, 10 Feb 2025 16:29:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbLb-0003bS-Cw for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:43 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLY-000297-EC for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:42 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43618283dedso48374565e9.3 for ; Mon, 10 Feb 2025 13:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739222978; x=1739827778; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GbaUDoQaM/zAo+qrfvJYguOp2M5t31jnNdamnbAQszo=; b=e3RqM9itkZxTSNVYo3Jy1KP2YnTcCNlp+a2alvfq+VobM1FYUJ+QQEGnD8bBJbCq9C fVXi4ZqxKLvLjzp1MX2cYG1DNHdNyosmr1GdvuWA9OpyE7ooEqVj2IzBhnA1d0iRIE7S LzTaNlyo8EjlL5xoFUCQQky83nEfxyIKF/OOFoN+XhsyqaK6AfDVI2XaIWPWfHTsCR3d urUHW8ZRkPilMG+XcVcSd5XFHOeX052CcqkoKfVqcl4V7Ouhx9ddpsALvAAOxMGXxrTi 90MuBMapFC0npOIvOG4WAbckV3uf1Hcd1u4OZvPGzSVTUSuuiLaq71edCMCBNHCKCfwR quJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739222978; x=1739827778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GbaUDoQaM/zAo+qrfvJYguOp2M5t31jnNdamnbAQszo=; b=E77clRE4VXDv8vg002p9VJlCzYSKh6ChUsdurWx90mFupTktK+yEtshZR4eLQFNpyU ofCkphxDPvii1IaqOFzKdosVQZPlD285sRzsZSPbAPUvyi3943qOcOUIThGTot+R4Xes Yg4eU5khTwl6OZGR2uQoJ7wtiQ6JKO8NTKf0gu65ycd1b6lWglPkV4QVtAAZHGK03s4c k/myoAZLU9i0mKwEtAwKEqxDA0B0R37qqWEosT2JpBWxuSjLMCntimuyxR0kTM6bLdLt w2awiMn1zE4F0bW+yb/xLaXQFkcOAhzfPc6BpB+FBOHgYFRUszm6rKd8kJjsaF4XmN/Y tY7A== X-Gm-Message-State: AOJu0YyfJ6+m+4npNqigyVBAuQD+18LO6FYrQ3Vipppdyugl42zOLbns JG4G++znqYh8N1Lhd3KTV21BWu7hNdCBB0CLROhRVJcT8pXQK/xaq1cTo7wy0RtzAmCm9bfFJl8 3fBQ= X-Gm-Gg: ASbGncsj0kNjfV20PeucblJDSXfmA5Uugo3/sidCBa9N7V2hDUhYwX0IU8LIV0xyYiM 07wUQMpQZk+YMZ9f4GeVFuxV6kxpbikIJu9Gu5OFeQehQkuQ9n3XSH3nxhFcGjPeDdysj9zZmfX UINI+Mwzj76Ba2NQt7PtG81r4+OOLB37CUq6odzU8dFN7LaKHG7jS9+jKgCFHVsfPq6ObJ2yKJ+ VQ6e0pyA3TLh83aRSs0ZN0pBJRTUKX1D4NksEz603+dJZfjKRedEUz/QxsbAhZ/iflFZgM9Oot3 W8qP1Jy6zWuEhpBLBkyF9W+uKbE4V3aap25faa4WfsSLB3D3YRp9OUEqYvXwNENx9g== X-Google-Smtp-Source: AGHT+IE0Hxlr2j2T0COB4Ytpqrf/hooslm0jt0SBlSMdVj167GVhwBHP6MMKCMn4ByjwZGiUfzq6lg== X-Received: by 2002:a05:600c:1da8:b0:434:a75b:5f59 with SMTP id 5b1f17b1804b1-43924971286mr122015855e9.3.1739222978557; Mon, 10 Feb 2025 13:29:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394dc1c56asm457605e9.0.2025.02.10.13.29.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:29:38 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 01/10] target: Set disassemble_info::endian value for little-endian targets Date: Mon, 10 Feb 2025 22:29:21 +0100 Message-ID: <20250210212931.62401-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field for little-endian targets. Note, there was no disas_set_info() handler registered for the TriCore target, so we implement one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/alpha/cpu.c | 1 + target/avr/cpu.c | 1 + target/hexagon/cpu.c | 1 + target/i386/cpu.c | 1 + target/loongarch/cpu.c | 1 + target/rx/cpu.c | 1 + target/tricore/cpu.c | 6 ++++++ 7 files changed, 12 insertions(+) diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index da21f99a6ac..acf81fda371 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -85,6 +85,7 @@ static int alpha_cpu_mmu_index(CPUState *cs, bool ifetch) static void alpha_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { + info->endian = BFD_ENDIAN_LITTLE; info->mach = bfd_mach_alpha_ev6; info->print_insn = print_insn_alpha; } diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 5a0e21465e5..2871d30540a 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -102,6 +102,7 @@ static void avr_cpu_reset_hold(Object *obj, ResetType type) static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { + info->endian = BFD_ENDIAN_LITTLE; info->mach = bfd_arch_avr; info->print_insn = avr_print_insn; } diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 238e63bcea4..a9beb9a1757 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -293,6 +293,7 @@ static void hexagon_cpu_reset_hold(Object *obj, ResetType type) static void hexagon_cpu_disas_set_info(CPUState *s, disassemble_info *info) { info->print_insn = print_insn_hexagon; + info->endian = BFD_ENDIAN_LITTLE; } static void hexagon_cpu_realize(DeviceState *dev, Error **errp) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b5dd60d2812..85815c0805d 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -8497,6 +8497,7 @@ static void x86_disas_set_info(CPUState *cs, disassemble_info *info) X86CPU *cpu = X86_CPU(cs); CPUX86State *env = &cpu->env; + info->endian = BFD_ENDIAN_LITTLE; info->mach = (env->hflags & HF_CS64_MASK ? bfd_mach_x86_64 : env->hflags & HF_CS32_MASK ? bfd_mach_i386_i386 : bfd_mach_i386_i8086); diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 227870e2856..cb9b9f909f3 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -617,6 +617,7 @@ static void loongarch_cpu_reset_hold(Object *obj, ResetType type) static void loongarch_cpu_disas_set_info(CPUState *s, disassemble_info *info) { + info->endian = BFD_ENDIAN_LITTLE; info->print_insn = print_insn_loongarch; } diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 154906ef5f4..acd5a6e12da 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -160,6 +160,7 @@ static void rx_cpu_set_irq(void *opaque, int no, int request) static void rx_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { + info->endian = BFD_ENDIAN_LITTLE; info->mach = bfd_mach_rx; info->print_insn = print_insn_rx; } diff --git a/target/tricore/cpu.c b/target/tricore/cpu.c index eb794674c8d..49c18a0cd92 100644 --- a/target/tricore/cpu.c +++ b/target/tricore/cpu.c @@ -35,6 +35,11 @@ static const gchar *tricore_gdb_arch_name(CPUState *cs) return "tricore"; } +static void tricore_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) +{ + info->endian = BFD_ENDIAN_LITTLE; +} + static void tricore_cpu_set_pc(CPUState *cs, vaddr value) { cpu_env(cs)->PC = value & ~(target_ulong)1; @@ -201,6 +206,7 @@ static void tricore_cpu_class_init(ObjectClass *c, void *data) cc->gdb_num_core_regs = 44; cc->gdb_arch_name = tricore_gdb_arch_name; + cc->disas_set_info = tricore_cpu_disas_set_info; cc->dump_state = tricore_cpu_dump_state; cc->set_pc = tricore_cpu_set_pc; cc->get_pc = tricore_cpu_get_pc; From patchwork Mon Feb 10 21:29:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A84ADC02198 for ; Mon, 10 Feb 2025 21:31:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbLh-0003gH-8B; Mon, 10 Feb 2025 16:29:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbLg-0003eG-01 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:48 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLd-0002AI-4u for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:47 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-38dd0dc21b2so1745692f8f.2 for ; Mon, 10 Feb 2025 13:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739222983; x=1739827783; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qcxWKPPyBgEMSe447dc/9VeQiSKl/TYrx71q+3sl0Qs=; b=YGCGHjw1oU8pzBHCsyn13IzV3jCBNcFtL9Bh9SEMEqiNn2gjcVqhCw+gPAYzMyw8+8 9Hzc461zgTADb3ny9xFsZHLKteDQWXI3jdXgoWQRTjipIt5FVd3MFhdxqMPKN2N3ua4Q TvLzEeefOUB77jz+FtM7fN7t6PvOf8vTz11g7oBV9m2fMwVVYPhYycapxrogtL1vLIOj pjwaKKkPAQFnmf83ZndZ7a5Yi80/9lqQBp0tR7SGu//oPGJ0mksnJR7Isq16i2xKYBRE i5qwvWOZVpTa+R4Hpsb/FRrtuBxzlg8ZJzns+SH0aIIivvDFNJetmq2aTONrKFFUsXoR ww4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739222983; x=1739827783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qcxWKPPyBgEMSe447dc/9VeQiSKl/TYrx71q+3sl0Qs=; b=ctg5TWhWd8B84bpUyAiGG5VEJ8ueTn8WFtN5Eib13ksv/gRZXe/Z/ChJYMXVx+Gwy/ goDdnibM/bb/YISTw9/uniIfLGyRZVeK6RE0hS4cHl3a4hKaC6q8POnRmohtb4pZT8ra VEuSJT7l3WEy1L5/LR1zwzPZ869KA4xrltDHyB6xLJ1MKPhfuGrytjzRbokeWPLnIg+d DrG7WGo7GorX975EcoARnHU/NMFv43U31zP1aAGh/g8nbby/ImxREKXHZHbV08jCcUFH PcSXCttgIh2sUi/jCDy9yxgxo4OIdcUNhXV+GlV1gfXOSyRM4tH9U+eOMmLsqToM7ctC v6vA== X-Gm-Message-State: AOJu0YzoQTUxZrIQ0suXvWyI6DEKTNr/e0yT9BAIK/U62Wn974tNmdIx pch9hSDTGGVU9HoG7RTosinO3WS2mBDjiEd6XtylCcFSP0BW1Uvh/FhpEmWB2WlQ20qomDU5KLk nbp8= X-Gm-Gg: ASbGncuCVc5ysfWP68+be/punZtuaezmWj9WOl5Xxkrr04SOwUIVKeEkv5LcZy3rLWy UbMuHLOAhV1EjYDZ2TMaIQnhRrdIo3BnApDG84R74dvv7w2vpW4mV/tAanBMbqwzPJVHOy4GCqe 6yst95sZ9y0yXr7GL3uV/WHKY6xJwK0UAm4V8WG7pLKqd2uG7Kr9dpxqo9J38NSa98ecLIvvJb4 jJIey1QyBNe2BWj7HCLncLfAhIeiKfdLKIr0cJOL4Dr7miZcSd14r56wFj/X2Gv0v0Pl53gZB9y TvXKkrncBTeSjd5F7p802becdfdUWiGWBMpB3rifZqAQXJX5U0I3nmalgFU6KneV1Q== X-Google-Smtp-Source: AGHT+IG9sOCggVsyvCCWYgOg/TYuduXm7u+D50RbCiZfn7Hgcp79cdnO+6SaHHoTlwbTEbixjTyADw== X-Received: by 2002:a5d:670a:0:b0:38b:f44b:8663 with SMTP id ffacd0b85a97d-38dc93623b2mr8575658f8f.55.1739222983333; Mon, 10 Feb 2025 13:29:43 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd8dee385sm6091870f8f.61.2025.02.10.13.29.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:29:42 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 02/10] target: Set disassemble_info::endian value for big-endian targets Date: Mon, 10 Feb 2025 22:29:22 +0100 Message-ID: <20250210212931.62401-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field for big-endian targets. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/hppa/cpu.c | 1 + target/m68k/cpu.c | 1 + target/openrisc/cpu.c | 1 + target/s390x/cpu.c | 1 + target/sparc/cpu.c | 1 + 5 files changed, 5 insertions(+) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 4bb5cff624e..d15f8c9c217 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -150,6 +150,7 @@ static int hppa_cpu_mmu_index(CPUState *cs, bool ifetch) static void hppa_cpu_disas_set_info(CPUState *cs, disassemble_info *info) { info->mach = bfd_mach_hppa20; + info->endian = BFD_ENDIAN_BIG; info->print_insn = print_insn_hppa; } diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 5eac4a38c62..ff167aaea71 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -122,6 +122,7 @@ static void m68k_cpu_reset_hold(Object *obj, ResetType type) static void m68k_cpu_disas_set_info(CPUState *s, disassemble_info *info) { info->print_insn = print_insn_m68k; + info->endian = BFD_ENDIAN_BIG; info->mach = 0; } diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c index a74fab43a91..33c81928370 100644 --- a/target/openrisc/cpu.c +++ b/target/openrisc/cpu.c @@ -83,6 +83,7 @@ static int openrisc_cpu_mmu_index(CPUState *cs, bool ifetch) static void openrisc_disas_set_info(CPUState *cpu, disassemble_info *info) { + info->endian = BFD_ENDIAN_BIG; info->print_insn = print_insn_or1k; } diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 3bea014f9ee..972d265478d 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -243,6 +243,7 @@ static void s390_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { info->mach = bfd_mach_s390_64; info->cap_arch = CS_ARCH_SYSZ; + info->endian = BFD_ENDIAN_BIG; info->cap_insn_unit = 2; info->cap_insn_split = 6; } diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index e3b46137178..9fd222e4c82 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -106,6 +106,7 @@ static bool sparc_cpu_exec_interrupt(CPUState *cs, int interrupt_request) static void cpu_sparc_disas_set_info(CPUState *cpu, disassemble_info *info) { info->print_insn = print_insn_sparc; + info->endian = BFD_ENDIAN_BIG; #ifdef TARGET_SPARC64 info->mach = bfd_mach_sparc_v9b; #endif From patchwork Mon Feb 10 21:29:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E4CCC0219D for ; Mon, 10 Feb 2025 21:32:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbLl-0003lq-Q4; Mon, 10 Feb 2025 16:29:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbLj-0003k0-P3 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:52 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLi-0002BT-28 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:51 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-38dd14c99d3so2418298f8f.3 for ; Mon, 10 Feb 2025 13:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739222988; x=1739827788; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TudiBAwlV8vL/G6pFMlMl4VlW+7MiYN30xZzToiA+nQ=; b=EFjD8NxEaGNJvciygwu9UEZnn2oEHK/pFGr8aOrdlXpMIbh9AZ9PAck2WeIeSQe7QG SJnUlnGdUhpxCbVMHqYhzMWtlLDSgilIN5Hx75iJRVGRaNxcxwX7xKwA5IBP+4bUi7FI 3wPq0YmG3RsOs0fEKs2oF/GXlribAEDJngj56h7JVvVTiOLr9ydr1SL5wTwJZSUnw/Es bqPNKuAZ0dJvfzHCOldSZRo5bmqnzKMISNC//SjINw4xgzgqGnkI4lFYQ1u2cvMKGY3x IkpxGFZFWQDK5wFchIIzQRDTrO+7b1eQQFZ8OpgpFbUUq3F+YDLvtfXdikRDpd3DO9xV ZlHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739222988; x=1739827788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TudiBAwlV8vL/G6pFMlMl4VlW+7MiYN30xZzToiA+nQ=; b=DYg06mUab8JLU3+y19gjkHihUOtImb1VawEhZU3GDUcSy0F4kv3kiB0xZYY7r2Aa5G vRe6vojpo87RHY9s5KT3D7fdafXm02kxK2/iuGLoFYRQONkY5Z3cS2qdLG8mRv0K+uze pnLoRgL1wgr+wn8hQQTpDGAGyupN7it8YjdmszDtEos7tQ8Tgu7MBf2sDCJN/B4amv5P jZ3mzD4sVsFi6svll7Rc18QtcBYSlULVdAd4XzmKmiwoKG/FkKVHqh1KYTuCiZYzyHDa g/Mgg5eflNSaAGDHoWnOsAtkcbaocYPRbmPwEcIh2RzZxcpU6RCkY2jphdnZh2MT5k+O WqbA== X-Gm-Message-State: AOJu0YyFdAfVPBsc5EKW31gT9UMiRkuPnyrEt29SI9tbEQp+FUas9OWi Y3yOXiDxHY5be/3sar20sridPh9gM+Zg6+aeU93UYZ5nn7S9R6vyjEILQs8iVJ+BDtXS2myYfHl zwiw= X-Gm-Gg: ASbGncv0BoMX+TXj6O31HVQKFj047vEUt4lBpfJ6d8GiiPWFdmdUFtnnUwP11OWcYyu Dy3DmahHKte9e04jmQnnv9aJ4PU7/ZqiV/Yzgi7FsDGAvNIXH+wyEIVEPDp6czBjhAwjhhVqTmA KvlsjIRGpf+Cxb7l4yUEVz6OwHMQ/zdc8QCpzzXb5JmdtDgS3IRiKB8NLpGU/a7u6M+KIsJIoiO Rb8CQCBrXRIskqyQPREmCtRBmmxYgkyA3lzy9qq0PvZmrDwjJ6eVFe39o6Q1K1Xtql74GPQUNnz JVZLxolUsfkBXL+6zsLEHoIfDgOL8CXQjDFpbZJj3yVWrwzs3BgF09Pb4F29hiYz1g== X-Google-Smtp-Source: AGHT+IGmaDBBExT7J5zsHTCH2rhWX1/1u/wLH4tCRmX+nD6OUANrS0KoZ2gRSKj4eG4pxRRAGniucA== X-Received: by 2002:a5d:5887:0:b0:38d:d92e:5f7a with SMTP id ffacd0b85a97d-38dd92e627dmr7006882f8f.28.1739222988204; Mon, 10 Feb 2025 13:29:48 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd0d3120fsm8787916f8f.70.2025.02.10.13.29.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:29:47 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 03/10] target/arm: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:23 +0100 Message-ID: <20250210212931.62401-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/cpu.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 94f1c55622b..68b3a9d3ab0 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1188,7 +1188,7 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info) { ARMCPU *ac = ARM_CPU(cpu); CPUARMState *env = &ac->env; - bool sctlr_b; + bool sctlr_b = arm_sctlr_b(env); if (is_a64(env)) { info->cap_arch = CS_ARCH_ARM64; @@ -1215,13 +1215,9 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info) info->cap_mode = cap_mode; } - sctlr_b = arm_sctlr_b(env); + info->endian = BFD_ENDIAN_LITTLE; if (bswap_code(sctlr_b)) { -#if TARGET_BIG_ENDIAN - info->endian = BFD_ENDIAN_LITTLE; -#else - info->endian = BFD_ENDIAN_BIG; -#endif + info->endian = TARGET_BIG_ENDIAN ? BFD_ENDIAN_LITTLE : BFD_ENDIAN_BIG; } info->flags &= ~INSN_ARM_BE32; #ifndef CONFIG_USER_ONLY From patchwork Mon Feb 10 21:29:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88ECBC0219D for ; Mon, 10 Feb 2025 21:33:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbLs-0003tI-GZ; Mon, 10 Feb 2025 16:30:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbLq-0003qM-0A for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:58 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLn-0002CW-Pb for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:29:57 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-436249df846so32976955e9.3 for ; Mon, 10 Feb 2025 13:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739222994; x=1739827794; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYUvy3QtP2AUaa/B3tYEfM+4wz3nraBak2/IB4Et0u8=; b=p7c2ZfKEaw7BHeh9NI3aSVmSaAcF7a9uO0jfbqq1x1TgRJj+RIxZjw2PygrYrldIN7 NEL5ky2g0M9h62p9VxNqradG4hkp62dRMbL/+qQEAQigmNZhx/36ReFAglKz6zE3QMuB P1BR7IAS/SeNeFQb752163//guDXn8mv6qdP/tCGPiiehETN1mMoXXdsWmlyA5Yn/EhY Cgwq6nsH/nkwEBw8jptLcwge/RaybAPHahSqQkrK8ufqVYA4FDiwF0lfWbPuX2R2HWTl UxgF5R2nfAddHCch81MUtKcNBY8vhabo+uliXz5y/m/1jW5sJgxgX7iHi8iZyfkbOT1S vCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739222994; x=1739827794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WYUvy3QtP2AUaa/B3tYEfM+4wz3nraBak2/IB4Et0u8=; b=V9fSZUi5eQRojaGB0yVvgqsqpyHC7RzAMPbRnDVxfgYplTgzrHBw1eFLbR0/ZydDfX zWS/5xok6AyHtdM0av6TnX9woY7Oz8pc5Zp/71QuNRPZ7UGVcO14azPpfAixa0YoedQE QFmaPZeOQujVz5umrcqoUGxCuJUIIKIJJEAWRIuz0AgX4TXtRrF6YHW3sPLQ89TrQRaI cPy9ZOJ6Mq9sMIyio+UgtW9UTQkWgRl9UWohOKnRQE3ihy6rFlSXCWzUYg38B9K2mNV/ FtRfK6OfObVC4B3nhGtw6bCGLyTLacAQVfAPk70OisLxESq9zMy4V8ILd5yqVi7dwpNy yqdw== X-Gm-Message-State: AOJu0YweOXZKM+A0t3HSmhdIZGVJfwLnmD03NJlIeIEwwZjJdc0YzmqV aWEp9zImF3SKBt/6KXaFGICwKJJ1dO3Vm32JAdq3AcEfp6pZhMmD/J+vENwxKq+qpVICe4WASyh uWrA= X-Gm-Gg: ASbGnctb8MReyhrNxYc+/AMbGAqAeoyVzJUAWDO6stuFvDCn/BeVPVD+1GZsDp+RmBG EgRG/fgycb5FamsYytj3dPy+GhYh2tjueR4ObWNYVsE8BkIi/qfFNxY0rH4V4vylYHQIALaBIOV lAFPfsVRUgDMcbRiMwI8tnkNZbsWpPYrm/UvGVVPVpx28KMjtqGlUmwp8oiZcQiqGTsJ5YpxdBE DZupiXWOItjpBq2qLJQqoQbDb9O9gblKQeTsz1HE8jI3QPPapH07y1r4yjFAWyYvObEHMMFKQm2 yjQI7sNfN1TyOCaQjxPkQYKTfHi8zkp3fB/IPWkR9oA+tHiemT4u1pta5B3+rsfBZw== X-Google-Smtp-Source: AGHT+IH5ALwlP0ZhR95HyQVBvnS8MJtDL7W5CgyoPSeFI6KEQ6xyhOKDOoEX36s9PG1YHLS/YuDzOQ== X-Received: by 2002:a05:6000:1886:b0:38d:d99d:d221 with SMTP id ffacd0b85a97d-38dd99dd4e6mr5021186f8f.1.1739222993757; Mon, 10 Feb 2025 13:29:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394127afcbsm54084965e9.23.2025.02.10.13.29.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:29:52 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 04/10] target/microblaze: Set disassemble_info::endian value in disas_set_info Date: Mon, 10 Feb 2025 22:29:24 +0100 Message-ID: <20250210212931.62401-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 13d194cef88..27089e3c579 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -224,6 +224,7 @@ static void mb_disas_set_info(CPUState *cpu, disassemble_info *info) { info->mach = bfd_arch_microblaze; info->print_insn = print_insn_microblaze; + info->endian = TARGET_BIG_ENDIAN ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE; } static void mb_cpu_realizefn(DeviceState *dev, Error **errp) From patchwork Mon Feb 10 21:29:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C943BC0219E for ; Mon, 10 Feb 2025 21:31:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbLw-00042O-Vc; Mon, 10 Feb 2025 16:30:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbLv-00040g-MX for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:03 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLs-0002DU-Hx for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:02 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43934d41730so22239505e9.2 for ; Mon, 10 Feb 2025 13:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739222998; x=1739827798; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+JtBiYKMI/Sj3oIOkec3F7FVIT/FlOHh9WNs4yErZgw=; b=Ddd0eL4vR2q1s62vhOZtVtmwLGOyQ7MO7Ajn56hWS+XC+3CjlsK9JEZeCPpuxO0h2c H08NMxioC1ovSmVlbMw2Ad7Hyy8anAEDzgXGD4jxS4Wrz4pJ9xZgCNeLtzNAMJniemXu UGN2SnVPGAA2zakOmGFIZ4FwQMx8p4PeXOk/06MXQ0akIRM2ayxkZ02CJzKmfA8AaWgY 0q1UxL53hoesNbEA6um3YSypyBIiVph/RmpemNmWOxrVVQAq2Okcd0a4AhS13lj1n27q DZ1a532DskpAkcZw4ParpHdsp8w7viaCCxzj9fabjpGAy5LhcWv3FbzsZRQEI61eW++b k7mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739222998; x=1739827798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+JtBiYKMI/Sj3oIOkec3F7FVIT/FlOHh9WNs4yErZgw=; b=rJtfZ1q6784nLJu5DWnwGlae0OQXEKUnnGm1GVATMysK/6lU00AgMPtdhX166JzzZL lwsqwRRnVPuDQK4qNRe2Vm1ObezxmFD44/ZGfwwXwamyQZy7WP45KNZcJJn94AOr0n9i TKll1I61HGBvRcy38odzpDe0eNgicIDE+HzAssNnGxyl60XyzTOMQTtQ8WIi5rTlaOkB sKTsGHLNZCWKlCdrtoJdwUe9N5jMx2o+RsMg8VJJKkkAOeF9R93/8vOWXnQX0HoibHCO aSRMFfa8hdK2d7KIPeTCMITMspzCxbsGP/MOaxz1nMVq8IaZMvT6Xr7RjAxustyIscf0 brEw== X-Gm-Message-State: AOJu0YzpSJyI59uNWTGZ7s/gChqiADjzAonxofDdNsmnchfcpyLglN2q A6zDpBzwF0ZpuJyIHbm+SapTUhTYHJPzCtRbnkPcxBZzbtetNBt8gBopk38IIYKMRynSZrOfq8V IndA= X-Gm-Gg: ASbGncuavaZKvtXRY7wEhDZKFwAkpiNnH3ZMrt0y9JubXvy6MobGXYUJx8Tgt2f7yej SUfkpQwzOUpN5PdlQ2Z7YgFGV5H/P3otxxqev7D6MLv02R8HdoBWPItalDK0o49cQ1B7Xjs1KHy T+dB8y4OddZRYvo73wHlfrzL8ySgo7psGA9OlK8zfWT3SvI7BH/Ny8kDboH1gmOjmdZHuEKSeFu Cn9PNVU6CI98wR6IUF7vt1irr9gLtmNZGKAZPkiiAZL5fWenYMfMUkkNpZJJl2jj5Aa8ZeRx3gb 1cx9LLWX5jn9QQEwcrLUAinFl6eE5R+JGOVM2Urq2shCiQ5BHUenNPdz0uSU+a3+OQ== X-Google-Smtp-Source: AGHT+IGr8OUYB9880DlObnMvvs+8i+cskVdQN+xrT7lWCClHQUhHpiYsf8lCpjnOKQW6o7RU+fsAiQ== X-Received: by 2002:a05:600c:1e02:b0:434:fa73:a907 with SMTP id 5b1f17b1804b1-43924992054mr128935005e9.13.1739222998589; Mon, 10 Feb 2025 13:29:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dccc1f531sm9947450f8f.87.2025.02.10.13.29.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:29:58 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 05/10] target/mips: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:25 +0100 Message-ID: <20250210212931.62401-6-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/mips/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 0b267d2e507..f6d247b530f 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -429,12 +429,15 @@ static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info) { if (!(cpu_env(s)->insn_flags & ISA_NANOMIPS32)) { #if TARGET_BIG_ENDIAN + info->endian = BFD_ENDIAN_BIG; info->print_insn = print_insn_big_mips; #else + info->endian = BFD_ENDIAN_LITTLE; info->print_insn = print_insn_little_mips; #endif } else { info->print_insn = print_insn_nanomips; + info->endian = BFD_ENDIAN_LITTLE; } } From patchwork Mon Feb 10 21:29:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D706C0219E for ; Mon, 10 Feb 2025 21:33:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbM2-0004AT-UA; Mon, 10 Feb 2025 16:30:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbM0-00046I-JQ for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:08 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbLy-0002Qn-45 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:08 -0500 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-38dd9b3419cso1044653f8f.0 for ; Mon, 10 Feb 2025 13:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739223004; x=1739827804; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6TcZHkuWys2mgVq8GL0a6AId6axol/O+ywSBYt05fm4=; b=x3rQpBQ0c+TrEIT7+Hy0zDViNuJ7ynH5fMQEwrLIfl5D1yMS/wtOcifDbxaItyj91b GWdvbAe//aV6WJATfyo2O9rBraL9as/S24IaherGCX0Xiw7sXjVcNpsHcISYjlYcBd11 qYYifXc3lIV9ASC5LO95TmCvRqWp8cAiBqAvzHihEsvEDwOLlf4diizljBLOnAfZwJhp VTgCWVI/d2L1+X186O/NkAgYcLABFDo0Pssy41B6tgq+UCEN8vo+HmUY/bwO/UcD0m2o 7j03OFIWmtg2RblczMAr8bmm3uFNwX9pAOkojEqiYvEbg8Z69znErj94JnY0wsQHvec6 6rYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223004; x=1739827804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TcZHkuWys2mgVq8GL0a6AId6axol/O+ywSBYt05fm4=; b=utm6Rsn7Xv4gFAksqpw4jq9sBQGUikJGj52FdMSffpF/RUBzuJqRyRCZyKm2AQ0984 0ubAY53QEFjSZhQ8gGgbgCzVaOvqvsCQIs8XBqSbamidJBDQgkOeSase+BIn4ixP8DJd aHNAnrwvlgcfCXmFGkIMQtBiOl0d5jh/fWbIvmXXHQpxF03em7K9YNMm7I7crytAzd8i p014SIgqTRtDFGM1FKe0eoR/h1OlSGxUsOtOWhboxuWmhVQESxsVF70wiGhYC9/VjmGl pZLvtPCBjSYOPCAFD+bDEnEv+7c0MaedeVADeN11PD78jbZvWCw9CuqSQ5du96LKTGe0 4T5g== X-Gm-Message-State: AOJu0Yw7+x3C5F1whj34wQbhTpOhz5Lyxk8EF8mUcEJDJKcqASXhJTsD aj6V3YFRRuBKs8alZmsSuEWbrzHkCqf5c3C1OVGvNKk8C8gVT6tZ7/2ppvSXSGbn6EgEqKg9W6Q brAg= X-Gm-Gg: ASbGncv9v6cemt3v4oWP/GWGWeXGsEXDjY1FSd9283OeGEkpkHFMqaw0LwqPy/H1GSx UfLejrMDs/UKHumW9nJ5Z+BsQvz4VFjdwSD+2mZgYMsupJc489bxP84weVMtNcyEKepy9HVYGTL 346cerMgxIxJWAFuxt+CpBpSJqWSdjoFQiHNSIsZGno9Qn6iqS4ERrVbk024I61JY2ZK8d4pM9e KzkPRL4ZUzA31uwdqjxoe3wuE5kfJBoH3ukizy+rr8XaD67v+uxjoOkKYK3MU8Qxu7zcyzBXd6j UsTtnsisrqW6fI00xl0LRvVJEK6W1l01DAnUBe2jjEjPWqHWEjDpHrm2yBakMznWsg== X-Google-Smtp-Source: AGHT+IEybuJN0iVC0lvUnYblFezq2sKDkEo6bIIrzo35HIr8jogIOE/wSfSGM77kq46sdHxBW6II2Q== X-Received: by 2002:a5d:64a9:0:b0:385:ef39:6cd5 with SMTP id ffacd0b85a97d-38de416d70fmr1012371f8f.1.1739223004112; Mon, 10 Feb 2025 13:30:04 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dcd34a39esm10092759f8f.30.2025.02.10.13.30.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:30:02 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 06/10] target/ppc: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:26 +0100 Message-ID: <20250210212931.62401-7-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback always set\ the disassemble_info::endian field. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/ppc/cpu_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 25e835d65e7..e816d30114b 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7398,6 +7398,8 @@ static void ppc_disas_set_info(CPUState *cs, disassemble_info *info) if ((env->hflags >> MSR_LE) & 1) { info->endian = BFD_ENDIAN_LITTLE; + } else { + info->endian = BFD_ENDIAN_BIG; } info->mach = env->bfd_mach; if (!env->bfd_mach) { From patchwork Mon Feb 10 21:29:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E26EFC021A2 for ; Mon, 10 Feb 2025 21:31:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbM8-0004Ky-Th; Mon, 10 Feb 2025 16:30:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbM6-0004Gc-HB for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:14 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbM4-0002S6-8x for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:14 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-38ddfee3ba9so1140146f8f.2 for ; Mon, 10 Feb 2025 13:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739223010; x=1739827810; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cigMHRTzJ2sIEBBFkwClq9YrVsopCKNGdfUt+g5JjJY=; b=gQusJsGigF140dOEv869CDYT9nfDLic+3WLr/zWWxdUdrzAp/oWkA8hQ3CGaLhz4gF wkIt4y5S+HlDOu03BXxpaY0bkbyTpuZgawFjVvBYKmrECwy1vgbe04P4KU/hLw6lwuRK aBYWN8OfcgEWy/Hn2LWakm0VYx4U4S4hQcLtT9b0td46xXQRGYccFBjh9wZ09jO4oqV/ ur9AgqCSvRI50lAi2HujBkCIrGQtwSdlg7UjCwbiJ9yznR6xGY8GaCAcgqzwjJSPC0bZ N0w4QA1WA/28mV1TLpPmXU2RX2o0KT7FcNbkgQ03VWKSEHe7vxfi7dkmsNX5XwsbGgyf glGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223010; x=1739827810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cigMHRTzJ2sIEBBFkwClq9YrVsopCKNGdfUt+g5JjJY=; b=xGr9+IwgMWB+lnc8+jVvbT57UpPC7WkIlit+lgalwvPnDJvNaxvtGKSmQ+w4AenGhn sj66Wr70g86EUqnLDf0Th+iXOgsac6T5CKgfgVbML3jP6CEQX46YA9h/AOxikHcIik/G JcaUETL+U8O1cyJGVCHXp8yyQpC52LeUfwgQDNybuzdaqMwFSW5n98QO/EZjl5r5Wnbp vysyWJpLefWzxnEiVfJ5WjvG8Urz0S5nzZas4abUWK3ZCjNmJJOzAo5+0BlxBpD+g8HB VOsdLdZ1/QhUWIOOCQs1xMnceknw4qkIe29II8KzxEgAMEUrsiCTyDqyXep2tN8cYwKt 3U/Q== X-Gm-Message-State: AOJu0YzQT2Wa8vorxk+vO7dOwEC8hxZkMnIGc8ms2PU3H8jxktP6z0UI d26b7fSXPi0isB3l//flt5tJ/86FcpNcRahy3LRKbH3sq4Zri8cF7yiV68rejspmlLeWVQt66A1 E24Q= X-Gm-Gg: ASbGncvKUR150NBbFt8MHuz7KecX2F26mQkzq2wjNbVroqJuL5XcNFqtKKd5ENqsRla gJ8uIMsIVSXypWo0qYEDUtMOXq53skZQRWHOiimUfHRNFEVUf/YVrOCt7fguF0O2hZXhIFxFjGu yBX6alqisvFln7n0fLkbVJHXrPsKpxqktSK/F+BsviPa8HWK/z+Sjn3+Dhk0o+C3hAKzV2IFol+ 8FSupr6iOgkyxk6EbABEeBZARwtAu2thxly0rouKSjkSL0xc/ahYOYQpqyepbKyl9dmUvFem33H ge1drGC+kp02oV9Y4c7P5s7nQ6I39q2bCDT0tjR+KFUOhrUk/Hu/vuglOWPcWwuSKw== X-Google-Smtp-Source: AGHT+IF77csdHIKpywxhM0vLTN5FONXb+r8Ze95eQdhiFDTiauuc7utYlvEYaSgoDbnJH56IYQpzmg== X-Received: by 2002:a5d:64c2:0:b0:38d:df2d:7ac8 with SMTP id ffacd0b85a97d-38ddf2d7d5dmr5239443f8f.25.1739223010306; Mon, 10 Feb 2025 13:30:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc33939f3sm12377912f8f.17.2025.02.10.13.30.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:30:09 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 07/10] target/riscv: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:27 +0100 Message-ID: <20250210212931.62401-8-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/riscv/cpu.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 3d4bd157d2c..b39a701d751 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1156,6 +1156,15 @@ static void riscv_cpu_disas_set_info(CPUState *s, disassemble_info *info) CPURISCVState *env = &cpu->env; info->target_info = &cpu->cfg; + /* + * A couple of bits in MSTATUS set the endianness: + * - MSTATUS_UBE (User-mode), + * - MSTATUS_SBE (Supervisor-mode), + * - MSTATUS_MBE (Machine-mode) + * but we don't implement that yet. + */ + info->endian = BFD_ENDIAN_LITTLE; + switch (env->xl) { case MXL_RV32: info->print_insn = print_insn_riscv32; From patchwork Mon Feb 10 21:29:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C448C02198 for ; Mon, 10 Feb 2025 21:31:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbMY-0004e0-Pd; Mon, 10 Feb 2025 16:30:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbMD-0004QX-64 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:22 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbMA-0002Te-Eb for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:20 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-436ce2ab251so33523655e9.1 for ; Mon, 10 Feb 2025 13:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739223016; x=1739827816; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W3TRvMCsTOKayhPJBtpLWMZ5XRU7il83OMKb5CXGBDk=; b=P1sgswSz2ikAXuhcR2LUP38G+wLbQC9CkkWKTbI7/0SyRE/bFYPN6MccULfnc0XME8 uD5s993mLhaoFhKSowp+J0PBStq01snVkN+XMLRnguAlWnX63V6m0wLxnJ92j3tx/10k FmvgCmsKzcml524EB7AC5l6g1AUHHoPYG+tOPhjzep/iBcuI46YkGJCNdjTIxP3ePExe 1AIiaES+Yz39ydlG4OEkPUKyrYsukyWQMuAkzLPblOLX0oS7ZY8tGjvisvHctN0RDnY5 CmYc4GVYanW/49TU+VYbZZG1f+KZNay0pPlpO0sMPKz30oly9vqhuoAPRKwMJFwmcVfb JlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223016; x=1739827816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3TRvMCsTOKayhPJBtpLWMZ5XRU7il83OMKb5CXGBDk=; b=vgWA5cR6MHZ2aVbVJQrM0kDU1l4Jx3tulEzKh62ntQ3UzORImroeVGzfSvb0Ks0rHi lRB42xevzFHhlwOQLrTeoe03VdWu6diJW0x5uoOx9MH9gp338hMEAb6zfodzYSWNlEgq fdhEdgxO77zvaceeeBv12ktgpMIQJCjDQLWeBPpJ+XeKhP4kRnyDiEND93VVNeg/rzwD LPm84uiBgeEqCNfLoUjvvwkJRJynFVJ8ipttfS8jPuYQ3PaQdAt8uNzpWAuzXW8ctBn7 UQFDOeWRpR5ftOvKQrNuXbIrxtDy7wlnSH4kM4GgpDZDvtvRkQhFTPlWEzGrBucZdqbw jDYA== X-Gm-Message-State: AOJu0YxVZdaCNiVVEENXIiLBkWjKMT7rCzQtnBP1iPF1Eq8jn3pUNMdv hCf3UBAjZeE5+b3Oki2dF56TlZkQdSqs1Qk8MjkAJKYqqqYsq2SSg/tuJSqYN1zlgqgONEp2UvO 7g/8= X-Gm-Gg: ASbGnctT/N99LC5SZcWFtNmkq8vYVPAWiZWSJW1VjiRvGPtoMEeXMOOqhUORe3FOVBN fv12I4bhxqKEoPHnw1DLvRclkqKFdCadcJrBhBO7xkURepKPgs78Gxef334Odn5mUCRtDJYOTcR RvFwFg3ADrPYDxEa1SvRb84UFLEj9z58uuR9Wc1Q4ZWv7oDfy97sGI05H6AAHcpV0xDuGLmzWt/ /cniZH/BFoUeEmlz+a37JnjAaNynPTTRm9sHFtL+tFdgLHpe2tu5EiucEbzVajTaI6sUg6ywWse L30wGEA0iB+h5X+ESuEpgRCvD2GEVJM0ByROALUER+cJbEBayUz4cjr5050wABVa6A== X-Google-Smtp-Source: AGHT+IGKmr59/tETcQOVTqSTYfTjeM0bqbgNNsd0GvkQv9Zm/O9W9rQwPIVCSLj+At+cQl2W9x0KRg== X-Received: by 2002:a05:6000:1f83:b0:38d:de92:adab with SMTP id ffacd0b85a97d-38dde92ae55mr5311247f8f.29.1739223015904; Mon, 10 Feb 2025 13:30:15 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dcb22f737sm10243442f8f.24.2025.02.10.13.30.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:30:14 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 08/10] target/sh4: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:28 +0100 Message-ID: <20250210212931.62401-9-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/sh4/cpu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index e3c2aea1a64..9d3e6cb2fd7 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -134,6 +134,11 @@ static void superh_cpu_reset_hold(Object *obj, ResetType type) static void superh_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { +#if TARGET_BIG_ENDIAN + info->endian = BFD_ENDIAN_BIG; +#else + info->endian = BFD_ENDIAN_LITTLE; +#endif info->mach = bfd_mach_sh4; info->print_insn = print_insn_sh; } From patchwork Mon Feb 10 21:29:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DCA9C021A2 for ; Mon, 10 Feb 2025 21:33:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbMZ-0004jz-Sm; Mon, 10 Feb 2025 16:30:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbMI-0004RA-7N for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:40 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbMF-0002V1-W0 for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:25 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-38dd14c99d3so2418589f8f.3 for ; Mon, 10 Feb 2025 13:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739223022; x=1739827822; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LstW3Dp8wkhRDMPLlcZPAPERKl2k3gDe4YnYzMJVkXE=; b=AHuujSzT/vIc03J7vcPjIbWL5sK+jSW/DyV/WXxknilZ/ltsSpWanjW8c9zmu0k6rr A5tptiAOhQA+NTc6adnBnGXQjfbX6T1Qxpo3NxTTCvi3vZZ5RYEb5+7OLNPjeoifoR9x /tmPaUg9GL7iDodVE2aK/xCS9FvOVOIJnvseb27QQg0GNEaT6nIfnMpR8mtC9Y8cp4uK 0hwAPkwX/Gi+VZmJ7OCC70vOkjCJ836+McK03aoOkuk8qjjdYb/d+bjLp45Oo6/v3z3n yKtqbG9ensAnuc0nZ7INbPCmImFYJ5juXL+uFcdXQtRIJxF+F8PHGnvsB0f83CgcWu7C A3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223022; x=1739827822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LstW3Dp8wkhRDMPLlcZPAPERKl2k3gDe4YnYzMJVkXE=; b=MBC5dOUGatMQS+5yua/O6iTKUctu3YJB2QDK6Bwv4jElcajeG4VvI5aHh96ydVpYol JNHNANBm40s6yzXe59l2A9FCepc+v33yukG/x/5+5zbvOZfCbf+uF+a7pSr9xyb+uLLo Yek3ieu5OBCk242HtYGahrbKluscsyzAzRX4HuKzAWsSlLP/xKRuwL868Osb1sg7Nw88 vw4jw8PzoWYwTUzRZVlBjHiNU1s5F47yCuBvKPNPxE4N4zQjMijOKXBMZ79ZxwdjEBa5 ozt97gDMhRKJaES5Pfw3v7C3rZtRszNpvJHIPc3WNKdvN0lHw4BwcQN/C6o7PxkM4XSU Brdg== X-Gm-Message-State: AOJu0YyaG1/59zwq0CJDJuapClNKjk8WLBIH67eklUPqXgNex7rGGiEi ew5Yg91/nYp8ef3yxecBkg563xyOXnTs53WdcBSfustTfZiZHietTQ7eEk0n9uiD8Uzj5Q01kgx boRw= X-Gm-Gg: ASbGnct5+fWgLnYJw15k1p5wEmEQhrClPBURv+Xr6r7If9/F79RAWUL5egB/YJkawFm zApUKxt+70zgmh9cCK9JOeWYu/Ulcd7QUM3k+yrHauKXUHodaOM7aDMZ5GHJo+pdjrdnGUwdXA7 mm733rfRc9eiTFCT/PFYg8B1TRDAwRniw48wNIaIPHLRiiHmaVgbXkLZSOAqaPZm393gs2KunHx fgxnsEnxVfaUOz3ijEGmYxe7yiluhI2rHvAQpzwdbw2ZZ4aUwUg+nFNqL4Ys/xQRFaFlNFEmNLs qy/vRHtquokyVV9Fo6UCDdCg18NQNwMDfPn7l36WyN6Y6pUaBSe75w/osYv6o2DT6Q== X-Google-Smtp-Source: AGHT+IEzTJ44VsNwmKpxj/vB9wEUjYCYpZ/i3rUv4ZNFDQKr/78ZUuyADGycQZ/O10oaiL3ZlWS2BA== X-Received: by 2002:a5d:47a6:0:b0:38d:d9e4:9ba6 with SMTP id ffacd0b85a97d-38dd9e49c91mr6523185f8f.3.1739223021731; Mon, 10 Feb 2025 13:30:21 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390daf7dbcsm193931685e9.30.2025.02.10.13.30.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:30:21 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 09/10] target/xtensa: Set disassemble_info::endian value in disas_set_info() Date: Mon, 10 Feb 2025 22:29:29 +0100 Message-ID: <20250210212931.62401-10-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Have the CPUClass::disas_set_info() callback set the disassemble_info::endian field. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- target/xtensa/cpu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index efbfe73fcfb..bc170dbb5cc 100644 --- a/target/xtensa/cpu.c +++ b/target/xtensa/cpu.c @@ -159,6 +159,11 @@ static void xtensa_cpu_disas_set_info(CPUState *cs, disassemble_info *info) info->private_data = cpu->env.config->isa; info->print_insn = print_insn_xtensa; +#if TARGET_BIG_ENDIAN + info->endian = BFD_ENDIAN_BIG; +#else + info->endian = BFD_ENDIAN_LITTLE; +#endif } static void xtensa_cpu_realizefn(DeviceState *dev, Error **errp) From patchwork Mon Feb 10 21:29:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 13968787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41138C02198 for ; Mon, 10 Feb 2025 21:33:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thbMa-0004mc-QL; Mon, 10 Feb 2025 16:30:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thbMO-0004Rj-2v for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:40 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thbMK-0002WC-TH for qemu-devel@nongnu.org; Mon, 10 Feb 2025 16:30:31 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-38dc5764fc0so3562413f8f.3 for ; Mon, 10 Feb 2025 13:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739223027; x=1739827827; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EXKigwduHuX/BpQHRjwL+FaxSAFhm5Nedm/bXWe5Qys=; b=qtawM0MH95wYhPMDrMP+DL76ltL0xVQJQVp8NcrP6CATAwKS9J2eAfUECtUnKVqryH +Z9ZgH0U/iLUDAy9QwJiRev9x6LcyUSlwl0Tur0IFmhQbLNboXCkv61PMw9xG+BW414U 2YiTWabswueN+iLvxAHRvQkO93h2y/HBgDv4aqpn1rtK24oMNEsPvmFU99bz9V97Dt5h Q5Irjfx/557teDqAOmlr9vxDG3sQvDk1q73QkEXUjO+YgrwJZdp1q4wry/qiVr56ZXPe 9leJsWlqR8dWjvPYVYMdrU+a6/J/73dXuA7FajeL11xNPMdKBG1jQs+aw5Ou/+zTkR7E /Pmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223027; x=1739827827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EXKigwduHuX/BpQHRjwL+FaxSAFhm5Nedm/bXWe5Qys=; b=Uqn1DCZZIsRs2WVIUiFZgZz+PERRXC7OKISC7nKR4M6NZT/bXQzoVIzoTORlMpQ6IL PJ0/65Es3WXECRLomgkJOScHMZdwzEw1Osx3d8z2MOg88FXgcli1iVJvjrnGy6nIqvV0 lZ9aaKs4L6kNHIcMmjXzSJYUEoKYhfuicZ7CwsYSYjlq4Hu8apCPUkHtlNr5PI+9KaTc BiQZr+xBsUglamg5T/NPZqC6LCLNyGbpSfEEdGsZLpAPLugjtb8+ekVRxRUYPphPN1jH I/5vQewjZHKlcGrsbMgjZXoQHyHAr3rYMR1PKPPJU64WdL4qYq3L/No3TXdoteb6lNaO cHoA== X-Gm-Message-State: AOJu0YxcKT5W7+s8otUZJIEFOqRkSar+fquQ8E/RP1NgbUxeWPa3h8vj O4J9G07qTM6hKvwiGZbu7hrIMPxAAHdK9ARU/oTvmt3eF/jpYKSy1/SHCJ/RWisYBFtz9kkVXaS 1Tzg= X-Gm-Gg: ASbGncvaZoEd6UniGDAzLOP5d3RZVoUVq3Rar8GNXNWFv0JXMu3OsiH4iviCxJ1y1Ee Ws/NnABbZY8sdtnFG5XMQ/abCOcrZHDwSHjZIZFFzjNMpPbXB1GpK7j8vhmNkkC5/0ORTbWkslM v3GWlKAG/pyIHq0q9YB/nI76mcFwmX9RLalZwjWLbUexcUWby04kCV0Q/jpKCQjsgKXLxmOujA5 ZsbtGsY8kg1n6bXTPovXjVPdOxvuw+cj8yxkZRoRSdQl30YFX9ykWahxcuQwuVnfRhwnJllvJSf WIDzv4m0TN8V5+5oJwln/928AB9MGj7G0mycs/nUts2O4d18cw6gyjBomDvpjp/C5A== X-Google-Smtp-Source: AGHT+IEx5Gj2xA6G+Wr9ca7PMtqoCPy2W+JgDwQjVq9PD3gbXs4ERtepo0Iq9y2OXOa4zcUHlBMJoQ== X-Received: by 2002:a5d:64ab:0:b0:38d:e16f:fa97 with SMTP id ffacd0b85a97d-38de16ffb3dmr3315465f8f.24.1739223026672; Mon, 10 Feb 2025 13:30:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390d933523sm194697495e9.1.2025.02.10.13.30.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Feb 2025 13:30:26 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Thomas Huth , qemu-s390x@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 10/10] disas: Remove target_words_bigendian() call in initialize_debug_target() Date: Mon, 10 Feb 2025 22:29:30 +0100 Message-ID: <20250210212931.62401-11-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250210212931.62401-1-philmd@linaro.org> References: <20250210212931.62401-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org All CPUClass implementations must implement disas_set_info() which sets the disassemble_info::endian value. Ensure that by: 1/ assert disas_set_info() handler is not NULL 2/ set %endian to BFD_ENDIAN_UNKNOWN before calling the CPUClass::disas_set_info() handler, then assert %endian is not BFD_ENDIAN_UNKNOWN after the call. This allows removing the target_words_bigendian() call in disas/. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- disas/disas-common.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/disas/disas-common.c b/disas/disas-common.c index 57505823cb7..42e911e36be 100644 --- a/disas/disas-common.c +++ b/disas/disas-common.c @@ -7,7 +7,6 @@ #include "disas/disas.h" #include "disas/capstone.h" #include "hw/core/cpu.h" -#include "exec/tswap.h" #include "disas-internal.h" @@ -61,15 +60,11 @@ void disas_initialize_debug_target(CPUDebug *s, CPUState *cpu) s->cpu = cpu; s->info.print_address_func = print_address; - if (target_words_bigendian()) { - s->info.endian = BFD_ENDIAN_BIG; - } else { - s->info.endian = BFD_ENDIAN_LITTLE; - } + s->info.endian = BFD_ENDIAN_UNKNOWN; - if (cpu->cc->disas_set_info) { - cpu->cc->disas_set_info(cpu, &s->info); - } + g_assert(cpu->cc->disas_set_info); + cpu->cc->disas_set_info(cpu, &s->info); + g_assert(s->info.endian != BFD_ENDIAN_UNKNOWN); } int disas_gstring_printf(FILE *stream, const char *fmt, ...)