From patchwork Thu Feb 13 04:21:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvarasu Ganesan X-Patchwork-Id: 13972821 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044BF1FBE80 for ; Thu, 13 Feb 2025 04:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739422388; cv=none; b=Wvqg4PnaRa2WSzq6RB6EnLEO6CLfNs+OwfOHVzOIrPlxIzGFQloP6ZaHn+hYd5qvYcXDAQkH7cWYbDzdVsBaudQF8yr3C01zUHXTFNz4G1tsnF7CR6oBOHsAB0l0MNXXgzpVADmCO8WrUaf0pGTMltU6CGAKHVgqFHgTgHRjw8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739422388; c=relaxed/simple; bh=dficntmdLBv88Uvc4N5XgHBbu1lCoeFFI/9KziADYdk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:MIME-Version: Content-Type:References; b=dsMCW1KtpIS/kJxsaxc3m1nsxp/GNzVH1DN9xJfDEOPpBwtnoz8OPzM7CoTsX99ziMqBKfYioXrfdD9i0VehsECvzUSO5dWgswUS5I7kAZRm83xCT+7X2Y4DjA/vL/Y5D45LEEsByWtD48fty+44pP6E8o897PWXCpTCR6zZGz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=ryBbWOHb; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="ryBbWOHb" Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250213045304epoutp0350d589627766f266d2ec48ffa3262360~jq3FF-51J2435124351epoutp03Y for ; Thu, 13 Feb 2025 04:53:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250213045304epoutp0350d589627766f266d2ec48ffa3262360~jq3FF-51J2435124351epoutp03Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1739422384; bh=3HLbLMPJmzSucOlsqmhUhAS8S4GVvP2o0xrz+vP8sis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ryBbWOHbrvcBhp8YrAHqsLoPSkKQT+D8KCbSNBUDcRWLT/zjyaiwqKxIxqX9NpfLR vuWBl2LOwv/iKxSO7wx+15Dr56qTUTI6NODUIsvFX3C6+VzikonTMty5zzLRXJiuUC moo9hUaAodMgPo6DwuuqQx9CCUny19kb/JGelUlE= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20250213045303epcas5p1552f1b30bdd4d34992df8b75296555fb~jq3EI6ECs2466024660epcas5p12; Thu, 13 Feb 2025 04:53:03 +0000 (GMT) Received: from epcpadp2new (unknown [182.195.40.142]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4YtjVR08WMz4x9QF; Thu, 13 Feb 2025 04:53:03 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPA id 20250213042229epcas5p1a3080b21423a43f2e71ab7f631604b1d~jqcY4hMzT1614116141epcas5p1j; Thu, 13 Feb 2025 04:22:29 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250213042229epsmtrp19e2f1b217faee08df2e182fbb84372a3~jqcY3fIXs0967509675epsmtrp1J; Thu, 13 Feb 2025 04:22:29 +0000 (GMT) X-AuditID: b6c32a29-63df970000004929-13-67ad7385f598 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 39.A5.18729.5837DA76; Thu, 13 Feb 2025 13:22:29 +0900 (KST) Received: from INBRO002811.samsungds.net (unknown [107.122.5.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250213042227epsmtip19447e7ac3e84c7c4f39138bbe3015dc5~jqcWPA9Oe3205632056epsmtip1h; Thu, 13 Feb 2025 04:22:26 +0000 (GMT) From: Selvarasu Ganesan To: mathias.nyman@intel.com, gregkh@linuxfoundation.org, WeitaoWang-oc@zhaoxin.com, Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jh0801.jung@samsung.com, dh10.jung@samsung.com, naushad@samsung.com, akash.m5@samsung.com, h10.kim@samsung.com, eomji.oh@samsung.com, alim.akhtar@samsung.com, thiagu.r@samsung.com, muhammed.ali@samsung.com, pritam.sutar@samsung.com, cpgs@samsung.com, Selvarasu Ganesan , stable@vger.kernel.org Subject: [PATCH v2 1/2] usb: xhci: Fix unassigned variable 'tmp_minor_revision' in xhci_add_in_port() Date: Thu, 13 Feb 2025 09:51:25 +0530 Message-ID: <1931444790.41739422383013.JavaMail.epsvc@epcpadp2new> X-Mailer: git-send-email 2.46.0.windows.1 In-Reply-To: <20250213042130.858-1-selvarasu.g@samsung.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42LZdlhJTre1eG26wbs/ehZvrq5itXgwbxub xctDmhZ3Fkxjsji1fCGTRfPi9WwWf29fZLW4+/AHi8XlXXPYLBYta2W2aN40hdXi/IsuVotP R/+zWjy7t4LN4sjyj0wWCzY+YrRY0QxUsmrBAXaLRz/nMjkIeyze85LJY//cNewefVtWMXps 2f+Z0ePzJjmPX7dusQSwRXHZpKTmZJalFunbJXBl3P9zlK3gAnvF/mtHWBsYj7N1MXJwSAiY SOy7Xt/FyMUhJLCbUeLA3r1AcU6guLTE61ldjBC2sMTKf8/ZIYq+MkrcuboDrJlNwFDi2Qkb kLiIwAZGiatnZrOCOMwCt5gkDv79wAzSLSyQKnFtzQMwm0VAVWLd04vsIDavgJXE622/WSE2 aEqs3buHCcTmFLCWuNh5AaxGCKimf+tqRoh6QYmTM5+wgNjMAvISzVtnM09gFJiFJDULSWoB I9MqRsnUguLc9NxiwwLDvNRyveLE3OLSvHS95PzcTYzguNLS3MG4fdUHvUOMTByMhxglOJiV RHglpq1JF+JNSaysSi3Kjy8qzUktPsQozcGiJM4r/qI3RUggPbEkNTs1tSC1CCbLxMEp1cBk Vzb/6Onrs9J7v3v0ykuo3Vx+IPB2/de8dcI3f2/nWHmL9/WD60J1jIwftnAaPfv4cRrPrz/2 sz/61q5JnGB/a9ZhfcaCjpUs9ibb/y7zOKT/g1HeVMzJm6Oo3n31qo6fNewBE5KZEvWFZuyc ztElznmk7X2AEZubcnnPsS1CVtyS96e4LSl0qU+ZZZkQP3ETs84jz8TConN93M90jew2/O5U eVX0QcE8+mxAw07Na039PwXDitzqdilx8kSy31RS2pxzr5yPqd6j/Omkzd3b1k4y+XrO3sD9 ac6s9kPrqxa7Lf6VdWRJeNV3F82FV4+2zFb/nbUt+d+xp5sUr0ybfvX35P8fd9TGVe0KOtGo xFKckWioxVxUnAgAY8kW/BoDAAA= X-CMS-MailID: 20250213042229epcas5p1a3080b21423a43f2e71ab7f631604b1d X-Msg-Generator: CA CMS-TYPE: 105P X-CPGSPASS: Y X-Hop-Count: 3 X-CMS-RootMailID: 20250213042229epcas5p1a3080b21423a43f2e71ab7f631604b1d References: <20250213042130.858-1-selvarasu.g@samsung.com> Fix the following smatch error: drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision' Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly") Cc: stable@vger.kernel.org Signed-off-by: Selvarasu Ganesan --- drivers/usb/host/xhci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 92703efda1f7..8665893df894 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1980,7 +1980,7 @@ static void xhci_add_in_port(struct xhci_hcd *xhci, unsigned int num_ports, { u32 temp, port_offset, port_count; int i; - u8 major_revision, minor_revision, tmp_minor_revision; + u8 major_revision, minor_revision, tmp_minor_revision = 0; struct xhci_hub *rhub; struct device *dev = xhci_to_hcd(xhci)->self.sysdev; struct xhci_port_cap *port_cap; From patchwork Thu Feb 13 04:21:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvarasu Ganesan X-Patchwork-Id: 13972820 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9108A126F0A for ; Thu, 13 Feb 2025 04:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739422387; cv=none; b=nLp/6IVkZXXhfJbPxcwlyMPc1zlQk6jJ04R8pKyh0Wvcdtvynn9P5I6++Pdg2frCkBtJWaxEBhl5SdU5WiMt2Nl02cbxQzFsi163E6FMs3lxcDvTRqSFhD2Wm7Ntpl91B25ly1JxBYsBE5l1HvFAWdqrFrc1zRidDpUWwc0EpJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739422387; c=relaxed/simple; bh=btuuGAHN0yAwnIydrz9luogYPZ/niqFXv+Dh58AVsiA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:MIME-Version: Content-Type:References; b=FvhMNv36kUd1lAfEDaQYWDhp+ltYJGQ+dsoLjdu6z5YlmQS/W1xhji1N78ev7AJmvn155ExXHX6AEKOxA0JKo8ox/O/T6DU1mNMCTvlzQDZjPsB81pO9PmlvxMWtWcxjyzdymDWq0wmSxzCqIXg+WgjsgDJ5O0+oHjDZ161EJCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=QYaM+0B3; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="QYaM+0B3" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250213045303epoutp01715de6bb61db461f792e145fceda9610~jq3ErCugj1787417874epoutp01a for ; Thu, 13 Feb 2025 04:53:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250213045303epoutp01715de6bb61db461f792e145fceda9610~jq3ErCugj1787417874epoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1739422383; bh=xYvadG4L9+uv4OCgstcXZU5FpbGiAZUr3Y8c/BN7ytA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QYaM+0B3j9pjY1TchDSszmCugRCkRiXQwm5wy3XOQifa1U+f5EuYFZON/x+IbH6UP EC8tRPtMHM05s0b3x5o+yqShojCi7Zd/rIbFesI8sRnAoCWFaK/r0NDNKnreHxkI9Q LBHnp6fGUCwOiVw6aavtMjtvOlbVYvGLsRWqbKbI= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20250213045303epcas5p19913f8bc0828c7d50bca0a2cd6c5c8fa~jq3ETvyCN2465924659epcas5p1E; Thu, 13 Feb 2025 04:53:03 +0000 (GMT) Received: from epcpadp2new (unknown [182.195.40.142]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4YtjVR1cyBz4x9QN; Thu, 13 Feb 2025 04:53:03 +0000 (GMT) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250213042240epcas5p3c1ac4f97ebf36054abdccc962329273d~jqciYgmG22763127631epcas5p3Q; Thu, 13 Feb 2025 04:22:40 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250213042240epsmtrp1b8af1613244bed48759d265c9aeff182~jqciXf9BW0967609676epsmtrp1E; Thu, 13 Feb 2025 04:22:40 +0000 (GMT) X-AuditID: b6c32a28-9a4e470000005bc0-f0-67ad738f2189 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id BA.C6.23488.F837DA76; Thu, 13 Feb 2025 13:22:39 +0900 (KST) Received: from INBRO002811.samsungds.net (unknown [107.122.5.126]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250213042237epsmtip16ed2c89451a5e8a08fdec56d33b3a3b1~jqcftTghr3115331153epsmtip1M; Thu, 13 Feb 2025 04:22:37 +0000 (GMT) From: Selvarasu Ganesan To: mathias.nyman@intel.com, gregkh@linuxfoundation.org, WeitaoWang-oc@zhaoxin.com, Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jh0801.jung@samsung.com, dh10.jung@samsung.com, naushad@samsung.com, akash.m5@samsung.com, h10.kim@samsung.com, eomji.oh@samsung.com, alim.akhtar@samsung.com, thiagu.r@samsung.com, muhammed.ali@samsung.com, pritam.sutar@samsung.com, cpgs@samsung.com, Selvarasu Ganesan , stable@vger.kernel.org Subject: [PATCH v2 2/2] usb: xhci: Fix unassigned variable 'bcdUSB' in xhci_create_usb3x_bos_desc() Date: Thu, 13 Feb 2025 09:51:26 +0530 Message-ID: <158453976.61739422383216.JavaMail.epsvc@epcpadp2new> X-Mailer: git-send-email 2.46.0.windows.1 In-Reply-To: <20250213042130.858-1-selvarasu.g@samsung.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42LZdlhJTre/eG26wef3NhZvrq5itXgwbxub xctDmhZ3Fkxjsji1fCGTRfPi9WwWf29fZLW4+/AHi8XlXXPYLBYta2W2aN40hdXi/IsuVotP R/+zWjy7t4LN4sjyj0wWCzY+YrRY0QxUsmrBAXaLRz/nMjkIeyze85LJY//cNewefVtWMXps 2f+Z0ePzJjmPX7dusQSwRXHZpKTmZJalFunbJXBlXL/+mLWgib3ix82VTA2MH1i7GDk5JARM JJbMmsjUxcjFISSwm1HiyJU9UAlpidezuhghbGGJlf+es4PYQgJfGSXWrDbsYuTgYBMwlHh2 wgakV0RgA6PE1TOzWUEcZoFbTBIH/35gBmkQFkiWWPf9FhuIzSKgKjFvwgYmEJtXwEpi++sz UMs0Jdbu3QMW5xSwlrjYeQFqmZVE/9bVjBD1ghInZz5hAbGZBeQlmrfOZp7AKDALSWoWktQC RqZVjJKpBcW56bnJhgWGeanlesWJucWleel6yfm5mxjBcaWlsYPx3bcm/UOMTByMhxglOJiV RHglpq1JF+JNSaysSi3Kjy8qzUktPsQozcGiJM670jAiXUggPbEkNTs1tSC1CCbLxMEp1cA0 cQvPtUoVDuMHs9VrBGt++7+YYX7YeO2Rzlrn89HyF+ZWV1l4Pjw36UZffqfNcwW2m7dU9R5a Ns7q03wyn8PUmfusp+hPletK+qzO/luU15zneKlxa73mb+6XzjLOgjfeVboa7DYVerorMdvP MWDBvlV8tkLrLwZ6C2somMprmm82mML859BW8XmJUus/XObqmcQ8IcqlWbG08MN3uzIHabm5 j4/m/Yy1O3Qv7PzF3Nz3AUde2O6asyDTy7n4cOgyvpmTHjOJhiewip4Knrz13s/96gZ6uV6P g31W1hjWNJ++1B+Z5+rEMrXjbv7xVMaitZHHPmx6v6nvXEDhd9O7RcVNm3MZVBdHGNUf6FVi Kc5INNRiLipOBADwarM9GgMAAA== X-CMS-MailID: 20250213042240epcas5p3c1ac4f97ebf36054abdccc962329273d X-Msg-Generator: CA CMS-TYPE: 105P X-CPGSPASS: Y X-Hop-Count: 3 X-CMS-RootMailID: 20250213042240epcas5p3c1ac4f97ebf36054abdccc962329273d References: <20250213042130.858-1-selvarasu.g@samsung.com> Fix the following smatch error: drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB' Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()") Cc: stable@vger.kernel.org Signed-off-by: Selvarasu Ganesan --- drivers/usb/host/xhci-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 9693464c0520..5715a8bdda7f 100644 --- a/drivers/usb/host/xhci-hub.c +++ b/drivers/usb/host/xhci-hub.c @@ -39,7 +39,7 @@ static int xhci_create_usb3x_bos_desc(struct xhci_hcd *xhci, char *buf, struct usb_ss_cap_descriptor *ss_cap; struct usb_ssp_cap_descriptor *ssp_cap; struct xhci_port_cap *port_cap = NULL; - u16 bcdUSB; + u16 bcdUSB = 0; u32 reg; u32 min_rate = 0; u8 min_ssid;