From patchwork Sun Feb 16 19:58:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976716 X-Patchwork-Delegate: daniel.lezcano@linaro.org Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32DF819A288; Sun, 16 Feb 2025 19:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735957; cv=none; b=swQdS4aW9iq2CFOCtRMDeAVQPFKQxIgVWXV7ZZPZocnXnyfkZFSXS1PJapJPdikqKmplcIk4VY5Ho4WPDbftY32DwfQwoFPtp9iB/t2yjT6hd/Ohwx2WPUHh26BrCRKMwzZNn5sRPSB6RxQEwbYQ8u8pCMYDzmvfvMqRwvA1qe4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735957; c=relaxed/simple; bh=u9+wjtzAj/ec4p1ybslaMQR+8HQzN/GJAMqyl2xc7CE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OXJRYXdNzFiv3Iw4LfGD/YmmGRwhY1HLkmKcPFlhFerDATvV1U7K5Luc/uyJzybMfA2rZYbhoZvB/QNWEIAwf2ZCiLw34sFRSdYqBbQsQVBWvcks7SbiLOp0NbnANF4tPpiJpzt9aTvWD8TUufL9tSMOImTKr0LrC0MFC+cHmDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJqjEqAa; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJqjEqAa" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22104c4de96so19265575ad.3; Sun, 16 Feb 2025 11:59:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735954; x=1740340754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C3vOplXPBv9vPD9lBSm7Gge48LGWl9qyZ2ygjv1+YJc=; b=hJqjEqAawtKyDD5oMYQrugDAlFbj6seoiMTnDKvqVMKb7xoOPOAUq4586a9f9y+7bg Y5zFRth4gdVB7fbWt6FkE2GYt3cmyNa4hUl5nHD2YEIXaSh9MkA0MwhrMYwf40dajGmX dhrFzLFngmszuZ1xgUAWjqdEOoUxyFOJZDvRTExUpK4OCZyqn+2arfr7syOIIZkCkXR8 tOghdSSXYnPGjjbP320ovNjobQFJHa5+905iiYzYAXKGQ2xzxzrzc0kwtwmS7+Ru+sJq ohAronbENuTL8kYu3k1wgsKysrc9HQl9tDU6LRUAxImoHITHEkbIgcKh/rfkVQBQK85j bq/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735954; x=1740340754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C3vOplXPBv9vPD9lBSm7Gge48LGWl9qyZ2ygjv1+YJc=; b=wyH2SVja4ziI5jglunIBVtkAQgSoRKwF2stZ94L+KFp/M6OXOFSkeKCfnA8OqoxnVo wgv6UlPQEZBfWgwt7RrKMoLLaIKjdd6FmvsQvT85VXbUU+GxRs9MAsgQj2+veVUPkqEo nXMRbtzDnshbtbvw/a4nurmMaAStBd25PSPh+GsodwH1JgxxgeYg9ZZRP3oEe3S1cNXO LrEy1abRRxUbM2pZBsP+2QNnKSHP1Ga0uQbgO49JpmO6VjgFwUAA0FnqHiYlAZyXIu3M hNJ+oKKhOons499VIoGO+CCLVH/FV43xPtNgxoXIX/gODoeD8HHcg7vBPAze+nCnBAIe cy5Q== X-Forwarded-Encrypted: i=1; AJvYcCUTCBNvVRlXdsAL9wtto+wi08mFjSIgyOGAd/Ez1Qh44JcIhGhofSlO+RWlRE+6wRePyngVw520OIVlnbE=@vger.kernel.org, AJvYcCVYxoPKWiSSc8aOsm9wQuHvsVOvVTI9/zt44otNgC2sbNpIN3J4ToO3099hNOLnj/hOyxxmiA8doXZteMNUDaEmLvc=@vger.kernel.org, AJvYcCVi2rIr61HJafHzdcvuiJCC4Wzx9pIydh68ew9C+E+KaD1bW+9YkQ3nSvOAEdk+zG6lj+l2t8pOh6s=@vger.kernel.org X-Gm-Message-State: AOJu0YyFQLFSfW8PijA2IYGX9414/a2jq/txSyXQZj5oQrZmMae4oEKJ F3FraMlcmfKdeayWrAFFJ44Pz4+LCx1usLDyL7nvr92rFE+JE/+Q X-Gm-Gg: ASbGnctlwA8Y4wG+siqLH1Bs15suC9K1HZ1fXtx+9omLdbS+mkKU9AwSPaJ4GC1miPw 0dKliTK9+Sic+dem2ihkCF+nB69IMDYp6yp9IgA/24CYrQzYIxlV9I8pBkvPMQZPChBhUkgfKCK N+8VfgOTHcxraViYlSxxoxMm4y7jCIHnF0LwBMUrXjvvvvXQfJCdcAYGpYZt7AswUnyvaVONvaH 6jc6qaNG6NgWpZR4anMxB17QszSZvXJrjApg6AuH5muJrOqHhdb+bGG7NziRivAOF7iEMvB3/Ei eKw1ORwn7tVbNdbQ/Xu1S6ZbALpmJA== X-Google-Smtp-Source: AGHT+IFGbwIDWIhyF8K5CcWFvD31AIlgT3bB8i3xIlYwtNFzuT2rTMPreGlTXLOnQJiYl5U3hxxNmQ== X-Received: by 2002:a05:6a20:6a1e:b0:1e1:b727:1801 with SMTP id adf61e73a8af0-1ee8cbc1aeamr12185284637.27.1739735954530; Sun, 16 Feb 2025 11:59:14 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:12 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 1/4] drivers/thermal/exynos: Refactor clk_sec initialization inside SOC-specific case Date: Mon, 17 Feb 2025 01:28:34 +0530 Message-ID: <20250216195850.5352-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor the initialization of the clk_sec clock to be inside the SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock is only initialized for the specified SOC and not for other SOCs, thereby simplifying the code. Signed-off-by: Anand Moon --- v3: improve the commit message --- drivers/thermal/samsung/exynos_tmu.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 47a99b3c5395..9c138772d380 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1040,19 +1040,6 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (IS_ERR(data->clk)) return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); - if (IS_ERR(data->clk_sec)) { - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) - return dev_err_probe(dev, PTR_ERR(data->clk_sec), - "Failed to get triminfo clock\n"); - } else { - ret = clk_prepare(data->clk_sec); - if (ret) { - dev_err(dev, "Failed to get clock\n"); - return ret; - } - } - ret = clk_prepare(data->clk); if (ret) { dev_err(dev, "Failed to get clock\n"); @@ -1060,6 +1047,19 @@ static int exynos_tmu_probe(struct platform_device *pdev) } switch (data->soc) { + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); + if (IS_ERR(data->clk_sec)) { + return dev_err_probe(dev, PTR_ERR(data->clk_sec), + "Failed to get triminfo clock\n"); + } else { + ret = clk_prepare(data->clk_sec); + if (ret) { + dev_err(dev, "Failed to get clock\n"); + return ret; + } + } + break; case SOC_ARCH_EXYNOS5433: case SOC_ARCH_EXYNOS7: data->sclk = devm_clk_get(dev, "tmu_sclk"); From patchwork Sun Feb 16 19:58:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976717 X-Patchwork-Delegate: daniel.lezcano@linaro.org Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E095619A288; Sun, 16 Feb 2025 19:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735965; cv=none; b=Ds7kyJCUtd4mF4mTaF4fqykQKXYOytFfCj9SbnyauBRTbhpG9XEMY9qaegyTQAH8KjAwyHoVjL8DQkzde4ZYgy1Xur9CrfKMpQrORqEgY/CL4eioyPdDxiarQ02ir4j9v7zgifxFykIzH13Og4RK/N1VJCaYhvDVNv0marvdYeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735965; c=relaxed/simple; bh=RJ55YcNZT5UFYMjXuIJJsv5D4yu6W+siHI8/lmurhoY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OlzQZ7DyxpMBfJWJDMZbIzD3+NScvWP1prZ06J2Nx0tZSZMpbWjPZcjLQ/+ThoYbvBdXcFP77zZ8H6XxH7489sN4oRaY/vbCibQRrImj+ROJfRr8GgkG81PJR0We9pi+x5IjlwoXJ55z1nux4yXUI6QuZDQDBo6kkpE+439jTVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P+Bj92uC; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P+Bj92uC" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-219f8263ae0so64030285ad.0; Sun, 16 Feb 2025 11:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735963; x=1740340763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xNDUgkHOvW2TQ9tKHoRawdYQbA3LIUTfvAXYbhOHBfQ=; b=P+Bj92uCfecI4LGriY6t2N/emwypIfZnCWa+qgwMUqpfKoQglOt8+vTzFT97CJ2uo/ gePFJVpb6IY3mFfKCQu4civfmlr6OXkE723ej1gpSl/UPScNjRGKqM3ZtVkrcJg+tx25 CXYzeEEAZSs5ibecsBavMJXG/yG6jPIMJnj1Ez56/YiVGQH4f07OnD+HJVY/AIlbnhON WzKdfSuHR2g8I3eC/JoeRUR4nKzYvqCPrY5r4oKTdx2c88cxT6VpN92iqjSma32e9gWI +9rjt3tD7Bwv+iM1XQS+oQy+afiO9cZN2firm9HyXlfs3p6f8xSBXslVfaZH4ehEXxIP +i8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735963; x=1740340763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNDUgkHOvW2TQ9tKHoRawdYQbA3LIUTfvAXYbhOHBfQ=; b=p68yv8KRrSGvQ44Us1WfpFaS8XUTgeB7OXmIuDGI2WlCVeO8o1lj1Pl+udM2BO/Nja 9YxB0nKnB69OIwMjzbciXENyqaUEamm3HXwNN2K+OfhHR9jQRir+j9OJI1K2lg5B+Y1U NxH/4gA07TA70XndQKqBxmdOtz5S8KNXVer/vvZkiEkt+XrOroVdoDGW3zYLsyMzKQw4 6XVE2CPq6q2eijpc0/tv9642nztfz2LSk5JeN3BprWgsDQINJqBgpGpkpCk7cTwDaYO9 I3DcjlZy67DZeVUOwjaEPqEM95W5TEMSzMf+Arz1WCiALLNdUHfT0gyMAIbGp2xYVF73 UrGw== X-Forwarded-Encrypted: i=1; AJvYcCUl5uGAn0J8xQXmYscSmEZg24WVxtok/m8ibOx6RBSSCYi/a2AjZQAHE+4T0fJOJqGdI+1CzPHIP/yk4QM=@vger.kernel.org, AJvYcCWwEKXOs913FrHty8p95bCoh4PtAsGeOLFkRnYkc7jL6jbCDNJE6o9juKAjyT87/1I6Dk1oZZYPz+0=@vger.kernel.org, AJvYcCXVdU4p8K8JJS48xm1hoCod6Vsny6byOgke875Ku3TNUnh6Ksb6LPOolDdWdFrzf+Pp09JiZQ0fx67PesQsqZdtRpA=@vger.kernel.org X-Gm-Message-State: AOJu0YzF07CiL8v339ur4DpXYgjzsn8+5pa0Z45Ji0d2n6pcvUVwFjL/ KrYtfxqMK94FbbktPchqZtKVvY1vSbYFtAHGOFe6VOY6VFeUu0HX X-Gm-Gg: ASbGncsLgIM3Y3+BCS/yBFm40b9EYrMUMDMX13m06P4pyvRnqfJfeF9m0pg4qKlZ+Q/ ozy18ApKoAfgsdy8N4KzJzDqUfjtUFCStcbTxMYjVSBOn95tNtzuSTWCXEvifnk+e3FT9usbiqn vYaEFUUm5usRUadJ8U+LgC8Xt/fSPJsGoL/RLiYp+Pe5Xvw/PWQjT+gXN0r4AtmmjcXV/351opp 3QE5yGo1VtlggVRBqtMX9Um0ge46SVn26F51kXsvIrXMlC/UZ6cwUTmq03Hwkq4Hy1wKY/5gaoy 47Ls2Lp6VqqC6MKcXkOeyxyhcu6MWg== X-Google-Smtp-Source: AGHT+IEUSK/sL4gi2aLg69L2RvsgLCz1QQ9HQlsi/sHzB48lrdXXIwILZrddPrIHBAHT6tkw84447w== X-Received: by 2002:a05:6a00:2d95:b0:730:7600:aeab with SMTP id d2e1a72fcca58-732617dfc60mr9838175b3a.13.1739735963046; Sun, 16 Feb 2025 11:59:23 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:21 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 2/4] drivers/thermal/exymos: Remove redundant IS_ERR() checks for clk_sec clock Date: Mon, 17 Feb 2025 01:28:35 +0530 Message-ID: <20250216195850.5352-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Signed-off-by: Anand Moon --- v3: improve the commit message --- drivers/thermal/samsung/exynos_tmu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 9c138772d380..8d26000c73aa 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock); @@ -1115,8 +1113,7 @@ static int exynos_tmu_probe(struct platform_device *pdev) err_clk: clk_unprepare(data->clk); err_clk_sec: - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); return ret; } @@ -1128,8 +1125,7 @@ static void exynos_tmu_remove(struct platform_device *pdev) clk_disable_unprepare(data->sclk); clk_unprepare(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); } #ifdef CONFIG_PM_SLEEP From patchwork Sun Feb 16 19:58:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976718 X-Patchwork-Delegate: daniel.lezcano@linaro.org Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FC31A239A; Sun, 16 Feb 2025 19:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735971; cv=none; b=HCF5nXMAJlp9oCp0EKigDV42dme1zTYYVkA1hwqxGMG6YxNIQFV4FlKtDugp6HoCj3llD2nV5WF+xyGRaJxgOv6XF8YFIUisHY6EJJBBec/GrHrdM2zpm4r1t4jVEYXMSQ+bh3eQrwI/2Ki5mOPRipTEq6kqCQ70IxwKKhA349I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735971; c=relaxed/simple; bh=dvfBmclEY5NMi4uT22TQeDgcdw5WxDAB63id8ISXwWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BErZmjE7hz1XBoinKokDbujNgQqApfpscIzhMI0Fc32DxeEyjI1mBgc35Le72byi2O8n9YIVT0zZiAjEiU0dYFzhcbpWwwC+UZp/bxMPu5pFPUC7eLvxU42/DouUEPgaD7zZ/aPTQMdGmvi1jFx4kXXKq3AiJTB+OXCEa7D/Ib0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bKv13VV+; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bKv13VV+" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21f61b01630so73303265ad.1; Sun, 16 Feb 2025 11:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735969; x=1740340769; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3fU2o4X95qtgokOtXyuTuOjB5JSG2sKXAjoLOfp+pRM=; b=bKv13VV+TBYRKjKiedWHi5kt8ARIdBZn/mFMrHYW5iKrgKUrPJ/aav4nFY83JhdvXx ZMGTYz9INEee720aZ6evugofd83Aucm2VAQ019SKFZaOCJPE63plXU+KpqCBcoNNu0UL DzepZVxYWEA/JWrRozDqquViCz4v0WE0Xh7XkFw3K5n61jwEUY0MOp5hDEiH3bWQ20Lw +m8luWiaN6cobWeNNmDo1Fgf8JbmK4cn0V02STbiMhWrxqivGXPCFQNcHNyeG2MlfrPB Z5UHN9uRTS8fPoeKZmunwCG1AskAQHVWQWDMWktgs/pOqU1tQex5Cb0iieCsQnL+YlAM QKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735969; x=1740340769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3fU2o4X95qtgokOtXyuTuOjB5JSG2sKXAjoLOfp+pRM=; b=cih6jkfCQN/DDqXlXfFNpmdZx4tMDm/OEF5OiGslBDTvgJBilZflA2eMXKin8QaAKJ EbtpZsnBl8oHpk/OdhgJi7wDlGn3QiKrKRAuYBNYkS/h87bjlblOs03+2GUCXYNzle5P 14uZ6HnYIciUIgjegmJD8X7Khfezd88I9eHJTOeNAozN3T1sNeJgOQJphAMpr3JhNOmb Q9HMN/qq+EoMpM1yjsdGxJaiITZciG5aTqH0ka8UM8jkzVfcYPVkYTRCKTjFo5Oi3Hbn 3bDLgila83vv2/ZrLJlWJdnFh2qv2Av1Ed3+6aovTt7nMrvIxbxMyAnP5jB3z0H6zMaM mJWw== X-Forwarded-Encrypted: i=1; AJvYcCU5IfpWJAmgVT4FKG67hu3wFZFIXdS/VYj5T+U4xm24GBjfxFaDzfmaEmbHaVhgp+c89aYJiI4xM8bqBv+UrVpIEwM=@vger.kernel.org, AJvYcCXMa5FOwyRDd/pd36miSPq8d+qEvEi1eBtA+n4O/FXHnpCB4lABZFV6RvcfAjQIQto4dw/wAg0JQJw=@vger.kernel.org, AJvYcCXu8VBNYOtAO/7/5mRCPreCD8nVAkljhAuEMAEHQig34BaENQH1f9Aflqjbxeygm0+0OAW5rxNLD6q/e2U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Z/cMUXSqa2rRwQ8lBM/AFD0sq+Yd86+wyIbK27NuVdaqkaps V+Q6YYf10TSWEvCgaUOFyEZssopLdAinWQGxhYYPCxb6G8kfDcjHUaPe1g== X-Gm-Gg: ASbGncscWbS/l9rrB1/J/pRjXB3qX8T9Yb+yllMZKZYyZXXxjgvcC5GPho+ejQnF+7u Ajid09tfgX8j3nQ1KsEXHdxsfvhbqZ8XH9PwahIWprnPpJrpBzBmnfPqcq4S53ftfRPJ69X3E8l Sdr7RzBhyXwaN6a/yd54GzssA1twxcTJrZtwsmdX+hvnOyc/pJM9IoXN4hiaVjTRFZr4C4GOurX I2CE7TdS9M6aI+0FTVG0E2Oj1tw4b4/7ODOLTbrSnFQcDtLk8wC2ihq3f7ADhQY195p+PwRkIqN Gwur87S1YQ92fWyOGGMlzHtTd/00KQ== X-Google-Smtp-Source: AGHT+IF7AzoUr1XgA1+Ea19Qvyb6/a9hAQAMMD8i2pvWMA2A5gLxhj2+OjivqU0UpmUYjnEdPJhzfg== X-Received: by 2002:a05:6a00:4643:b0:725:f1e9:5334 with SMTP id d2e1a72fcca58-7323c751ab9mr30761565b3a.8.1739735969416; Sun, 16 Feb 2025 11:59:29 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:28 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 3/4] drivers/thermal/exymos: Fixed the efuse min max value for exynos5422 Date: Mon, 17 Feb 2025 01:28:36 +0530 Message-ID: <20250216195850.5352-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As per Exynos5422 user manual e-Fuse range min~max range is 16~76. if e-Fuse value is out of this range, then thermal sensor may not sense thermal data properly. Refactors the efuse value initialization logic within exynos_map_dt_data function by replacing the nested if-else statements with a switch statement. Ensures proper initialization of efuse values based on the SOC type. Signed-off-by: Anand Moon --- v3: improve the commit message, fixing the warning wtth W=1 --- drivers/thermal/samsung/exynos_tmu.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 8d26000c73aa..fe090c1a93ab 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -899,12 +899,23 @@ static int exynos_map_dt_data(struct platform_device *pdev) data->gain = 8; data->reference_voltage = 16; data->efuse_value = 55; - if (data->soc != SOC_ARCH_EXYNOS5420 && - data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) + data->max_efuse_value = 100; + switch (data->soc) { + case SOC_ARCH_EXYNOS3250: + case SOC_ARCH_EXYNOS4412: + case SOC_ARCH_EXYNOS5250: + case SOC_ARCH_EXYNOS5260: data->min_efuse_value = 40; - else + break; + case SOC_ARCH_EXYNOS5420: + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->min_efuse_value = 16; + data->max_efuse_value = 76; + break; + default: data->min_efuse_value = 0; - data->max_efuse_value = 100; + break; + } break; case SOC_ARCH_EXYNOS5433: data->tmu_set_low_temp = exynos5433_tmu_set_low_temp; From patchwork Sun Feb 16 19:58:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976719 X-Patchwork-Delegate: daniel.lezcano@linaro.org Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A60901A316C; Sun, 16 Feb 2025 19:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735978; cv=none; b=u52piIa9XyFKvMoYnkA9SaxANtIThkFeqtxxP12xBep1X/RzJ3+gZ1NmtpsttVNF+I2tVQLn+VRY9DXtBLP61cls8fF/4/5N1t22JJZpZM5G0EBnKrTyOy2QSepZD6YbXPRYkuqMfkEthostDRJ0q7TDednskqGMo/XoLaJ7Kts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739735978; c=relaxed/simple; bh=rFYxO4KAK6OwMLCt9qwk8e3vWgD+XTOr5kF7g0ZxShA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sLT4VVsxgOZBldMSsW/rIWHVosleVGPC/P5d52wMLEtJrTH56pUAPmzgJtccnP8M0kDmYrR7NkN5lMzaeU/gx1G1kOrvAsvAan16WEATNG0FBWPBQQ7WJMjiyRWNOeBF+mqbLqLGYKddZ7LMmY5P9B+R/IO7WSASEzYSrQH6jKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dF1VzXQJ; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dF1VzXQJ" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2fa8ada6662so6958095a91.1; Sun, 16 Feb 2025 11:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735976; x=1740340776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vHP5M3yeaCi7IF7vXp1agOw6DIq9vLMPFGh0uk4OOmc=; b=dF1VzXQJ/5wWW2/r+0zvhnm2N3NnaKAg3MtLKms0SP9T0n2u9qp37Fjnfjrc5edyee xl13KqLyqylPDHLCf5OrA1Xyq6BTYLeOe4sIrW4aQ6ikw0gjuDz4tc/f2/BNvD2v24rP GKZJLIHDaCuCqXOrZ5nywK0PssGD3kt88E4O598RQwe040KmSnXu23w2mSK2x6OBulKn lvq37bvqGlWyHZURNv+NfZBQ4LOGjpSxkAqfdPv+23AZVJw2B6EHH29D+u2PpmgCPIEv HxvWYibA2GcQw25Ln9IMR1VQF1dMO7p0Qo1EWaSlCzufS12Miw2OP1DSMVvplOo1ZhYm 3REQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735976; x=1740340776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vHP5M3yeaCi7IF7vXp1agOw6DIq9vLMPFGh0uk4OOmc=; b=UVsUVkEHVG9EUwAOIab23GRzVsSIG/DghjMLahJdIvZIcTO6R6lYLiDzFlZiy1Dg0G Sk9C3cK0ASlYEke0eWCdEkGT856SLQulQLaikPCpNDptcwl+MDS8tVYZeDo8PNCoEqgy b6KlxmEivS6xrz+Wi/SC2V08/FAPyVZRb4fbEymtzyseYL8agiH1SQDCywHdsPddqD4O sfvX6OvGv033MTy1EiJbUAEDK5tuLGGfGf8vxFGIgvwzR7sAcJ1LKP6dXigjGrOCNPZ8 xuVqou5vkEVFWuTk3EF0p/MLJq97u5uPUip7n8CnYgjokXURN/WglQZGDH71vhEpGXGv XFHQ== X-Forwarded-Encrypted: i=1; AJvYcCVl6mxlRg9yVAemGlRfRbVK/aZqe1LqX+kOQ6NbSiFhIcunZ6ukYu4Oyl+OJFCQgRnaOROdZmhA81tVpIO5gT5Xcjw=@vger.kernel.org, AJvYcCWzNcsTiYYSIy+rCaZMS00I4lv6EhyYU4rLiRNCnclhlZQgtopGS6MiYIwBpwJWfPDOKEmmF1p+GSM=@vger.kernel.org, AJvYcCXYFaXS7smMtPQuTqbqPnUBHBGPLSHVLgbo8KJT4wZsQWbHl99qGijo7KhjcTYlUEHAx9bYF29b2pVWH3A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8z2l6hzFMHHh8tufyRiF7AMTiUKFvw3+U5Pq6PmaR9qya5mhA Shji/0m/QnOtjIqynGc8rkQN7zc2SYd+6mM1xBqPNswg2f3Zn6In X-Gm-Gg: ASbGncv3or75baG8rqh8wkiqsCcVlL/GhSGrewdYBwgbfOMVqMN6FXphI+ybqYBu5ZW rYfpxFFhVSVzL7xLpPxhym48LR8i8octUIUSMzG5t6LsJqhX2g9vZiVeJbsdtkC7bBeQxIr3KUA VAEG3SOYMUXuyJl6BgH/iU/5I05jqwBWQ2NjiJp2lpln/6cXgFtQlF8cNLW582QnKniQWVNeHnV Ob1OkMEq8TJlPRduuejXPbKhBdtEKJNr/xgHeD9RjtqyasiNvC9EEgP1KJGDJrybD0JPaRPj7NO pTjpj7MYvqxZA/oldi3hDLm8AwD9fw== X-Google-Smtp-Source: AGHT+IHBlw/ULOY6wy1JfyENVCkx1GmwQZMDVZZdLPpzLlvKhW8EBtZbG/71OUMbBtVJDDU3RGHmAA== X-Received: by 2002:a05:6a00:2d0b:b0:72a:9ddf:55ab with SMTP id d2e1a72fcca58-732617b5545mr9505891b3a.10.1739735975841; Sun, 16 Feb 2025 11:59:35 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:35 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex Date: Mon, 17 Feb 2025 01:28:37 +0530 Message-ID: <20250216195850.5352-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Using guard notation makes the code more compact and error handling more robust by ensuring that mutexes are released in all code paths when control leaves critical section. Signed-off-by: Anand Moon --- v3: new patch --- drivers/thermal/samsung/exynos_tmu.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fe090c1a93ab..a34ba3858d64 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -256,7 +256,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) unsigned int status; int ret = 0; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); clk_enable(data->clk_sec); @@ -270,7 +270,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev) clk_disable(data->clk_sec); clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -292,13 +291,12 @@ static int exynos_thermal_zone_configure(struct platform_device *pdev) return ret; } - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_crit_temp(data, temp / MCELSIUS); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; } @@ -325,12 +323,11 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) { struct exynos_tmu_data *data = platform_get_drvdata(pdev); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_control(pdev, on); data->enabled = on; clk_disable(data->clk); - mutex_unlock(&data->lock); } static void exynos_tmu_update_bit(struct exynos_tmu_data *data, int reg_off, @@ -645,7 +642,7 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) */ return -EAGAIN; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); value = data->tmu_read(data); @@ -655,7 +652,6 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) *temp = code_to_temp(data, value) * MCELSIUS; clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -720,11 +716,10 @@ static int exynos_tmu_set_emulation(struct thermal_zone_device *tz, int temp) if (temp && temp < MCELSIUS) goto out; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_emulation(data, temp); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; out: return ret; @@ -760,14 +755,13 @@ static irqreturn_t exynos_tmu_threaded_irq(int irq, void *id) thermal_zone_device_update(data->tzd, THERMAL_EVENT_UNSPECIFIED); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); /* TODO: take action based on particular interrupt */ data->tmu_clear_irqs(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return IRQ_HANDLED; } @@ -987,7 +981,7 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) { struct exynos_tmu_data *data = thermal_zone_device_priv(tz); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); if (low > INT_MIN) @@ -1000,7 +994,6 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) data->tmu_disable_high(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; }