From patchwork Sun Feb 16 19:58:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E442C02198 for ; Sun, 16 Feb 2025 20:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C3vOplXPBv9vPD9lBSm7Gge48LGWl9qyZ2ygjv1+YJc=; b=Yx8qsRypn0iBWP0tPkOzFFjHTW SwFWmM7wQxJb7p+R2Y1mHiAHVAFLn0I7o3xskfao9Ecyme+YAgWAXrJzLl/AYqYlADkLCVrAQPUDq dZH8T1841naZ9nvGZdE2RnbQZoREsJpOWpApr1O1MLU7/XjhCo3eIbhu7MjggUFlsUmqE820lkuLG EGJdKp8HB/Y6rqRxcGey0rVS8wjAAmLUDBwBSCNc3aDReNWKizVy3Pd3UWdeQ/GPicXqTh5eNjXU4 zFMbiXwXnUmiw+uYcEXBDQQripPm9tDLZa4v41F0XqRW+8Mgt5fMWuIpUjUFIOub1qk56Elz/auaY 4iKVEXOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tjkq8-00000002VyH-22yV; Sun, 16 Feb 2025 20:02:08 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tjknL-00000002VUO-1mBP for linux-arm-kernel@lists.infradead.org; Sun, 16 Feb 2025 19:59:16 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-220d28c215eso50975095ad.1 for ; Sun, 16 Feb 2025 11:59:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735954; x=1740340754; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C3vOplXPBv9vPD9lBSm7Gge48LGWl9qyZ2ygjv1+YJc=; b=Xa67GPUcyUcDwCCoFDA+yKQq3LZGYd3COInnac3I+hhdjz37jWL46XPXBXIoL/Tsmx PDq54gTbpoCPUV9aw511iwuI4TjegNZsnb54pvsYEX7zJUuiOIlbcbMZCfM1izP5nTB1 oXRixbXmeGlaYlMoiTvDj/RD1p9i/ea0oM1m6UfZQojan4LvC58ozsig1UZSMZxnE63f D+wIY0Zcuaogalfpl0VUK0JmYJd5pl0UtyqeWn5ujq3DLYjCGjQ9/ci/5O/j+QRXZDvJ KLvX7rM3IewaNgow6HDETnRoVmEugVP9ZrR2czll6C91v1hNNvTiPoG0FeNwWSGqn35i ptFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735954; x=1740340754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C3vOplXPBv9vPD9lBSm7Gge48LGWl9qyZ2ygjv1+YJc=; b=e4NuxK7uZwRdGfhr9fGES12sBZwezvuHEbhokMkB+We0NIOE8OuIz2vdkooceNpMdH KEQ4qKECUcxm+LdPZyzAKQmEyiIBMob9UmYxhqpg3BU12Z961BfLYsy2Sg/zNVVHMgNK U4ZqlwL1w9wyAFQIKQda9vQB6Oja8SZ84zbKa21Wzbkzm+O9ezaxvsrQgyIEvJEHDDFz XnQrsF8NY5Ph9aNcKNiFfJn++4FG7gBXEFGFX1KfLjtGczCGJymk2jtP4uKvaMwWwq0q MN9Fo/qvRMWa5RqF2+orF/tEnkjtEQXDB6Le5WjMECNd9V5rqmKpm2PvRR3uHh6mcZ5Y 0WqQ== X-Forwarded-Encrypted: i=1; AJvYcCVM57ALXqEhp7ISDzhjADvB136dwfe4K94txcei6k9crVqxLjpMBLApe9oUMRd9vyY/RX+KL7BKlFCH6foXgNO6@lists.infradead.org X-Gm-Message-State: AOJu0Yzju/YlwVOlDQi42vW5JcCRm7z4ZD4uLsfPRyIkY0/yXL2aiHyU flj6pAj52bkWOcP+jxf5LbpgMD06mVDRWANjh4Ro6SU4g63p/mnK X-Gm-Gg: ASbGncsGyQfzyppRhNPMBeDH/eNo8EQ+6KpU9pqtJpVaTclHcgp/eja/XZc62a+yfkp WfwVZPdzsuIwDWxLtl6O0P8NKUFIv2fTeip+8URja7KbD9FK79EXIx0EZ/rYfuZPmbI95kuliSR mCArG5uiiY3K6p5Br4JLXtJkUUYyTFgxCq34Q8KaIBumEGPlYhCEDOlG96xi+NmE6uZv3+NtOF4 CNLvWjNjOgxA+din9JSLumd43uoe16C3sVzmx/nVkTtd3ly0uuMNQ+UMrRhGnjVhvPo0q45G1Jz /jWFGOo6Y/4GZOqV3sRc9sPFhliy7Q== X-Google-Smtp-Source: AGHT+IFGbwIDWIhyF8K5CcWFvD31AIlgT3bB8i3xIlYwtNFzuT2rTMPreGlTXLOnQJiYl5U3hxxNmQ== X-Received: by 2002:a05:6a20:6a1e:b0:1e1:b727:1801 with SMTP id adf61e73a8af0-1ee8cbc1aeamr12185284637.27.1739735954530; Sun, 16 Feb 2025 11:59:14 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:12 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 1/4] drivers/thermal/exynos: Refactor clk_sec initialization inside SOC-specific case Date: Mon, 17 Feb 2025 01:28:34 +0530 Message-ID: <20250216195850.5352-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250216_115915_464038_CD29E451 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactor the initialization of the clk_sec clock to be inside the SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock is only initialized for the specified SOC and not for other SOCs, thereby simplifying the code. Signed-off-by: Anand Moon --- v3: improve the commit message --- drivers/thermal/samsung/exynos_tmu.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 47a99b3c5395..9c138772d380 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1040,19 +1040,6 @@ static int exynos_tmu_probe(struct platform_device *pdev) if (IS_ERR(data->clk)) return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); - if (IS_ERR(data->clk_sec)) { - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) - return dev_err_probe(dev, PTR_ERR(data->clk_sec), - "Failed to get triminfo clock\n"); - } else { - ret = clk_prepare(data->clk_sec); - if (ret) { - dev_err(dev, "Failed to get clock\n"); - return ret; - } - } - ret = clk_prepare(data->clk); if (ret) { dev_err(dev, "Failed to get clock\n"); @@ -1060,6 +1047,19 @@ static int exynos_tmu_probe(struct platform_device *pdev) } switch (data->soc) { + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); + if (IS_ERR(data->clk_sec)) { + return dev_err_probe(dev, PTR_ERR(data->clk_sec), + "Failed to get triminfo clock\n"); + } else { + ret = clk_prepare(data->clk_sec); + if (ret) { + dev_err(dev, "Failed to get clock\n"); + return ret; + } + } + break; case SOC_ARCH_EXYNOS5433: case SOC_ARCH_EXYNOS7: data->sclk = devm_clk_get(dev, "tmu_sclk"); From patchwork Sun Feb 16 19:58:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6323C02198 for ; Sun, 16 Feb 2025 20:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xNDUgkHOvW2TQ9tKHoRawdYQbA3LIUTfvAXYbhOHBfQ=; b=C246E0qUauu5txkKBo00EXa8pp 6DiN3k4h71C8qeYiL9rqoooESLHKcw4jSXz+oUrwKu3CwiSK3lr0mMWjd1eP52YbJ1Xgo3axS0/RK LZOTiFfVw4yymPJrvtg6m/PwpM/tR7/mg8teGmnRnWD4eEALoaPm4ZrrB8A6aKRiE2HRWiQefk6Ze CrixtQVfibcZaPHrqdYkfqIhtd7mc+lrjQXMJi6zNBirdZuPVF8JrzhT2xZfQBgdkyogA6gCL33Qf 62/7JCcYMatFhJcdvBoECobmLKME34ppvDtf6cpXQimxwDsN8RkvgApWfu8okmfnOLifGng5zMe6f ySDo6pAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tjkrY-00000002W91-0eWK; Sun, 16 Feb 2025 20:03:36 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tjknT-00000002VWF-3qOe for linux-arm-kernel@lists.infradead.org; Sun, 16 Feb 2025 19:59:25 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-219f8263ae0so64030275ad.0 for ; Sun, 16 Feb 2025 11:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735963; x=1740340763; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xNDUgkHOvW2TQ9tKHoRawdYQbA3LIUTfvAXYbhOHBfQ=; b=Lesjuj/8zoxx0SETHLgynbQ7Q0Ir+IXDHnpsIUu/YE0JPGfSj89TgHthG6dUvVfz0h q6cwzLykdxflpDM4TKs/UaZBbf02LKL4NrYDEFG2rk2m5JI6w7SagmjA0iJTkspzdknb IZ9TRjQ7PRDxsZffWmXAXU/JGT8A1qXYaMORs4Zyx7sP/8ktjVBpE8ryzC50CgCvC8/5 4AVk8SBwSkrXCP4F8kvRSpKdN2PiH3xzNA0invcZPeRbTs0GclulCmY1SwVJw6mDDR5Y cGHJXSWSTzjUaR/ECJeJicSh2PxZNhHqgSnqygNqxg67KOe9F3pu4oBLEetF9naLXOpR Na0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735963; x=1740340763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xNDUgkHOvW2TQ9tKHoRawdYQbA3LIUTfvAXYbhOHBfQ=; b=ZKCUWliEYeg2k8jzQ3SevKlo6t15QK1yE7jDtCiXEMjpG3IwZi2qC0qJCRa+Na1P82 smbYyhfTk8Wacf8o5EM/qSTZkP46tPyzwxda0nCzM0kYQKAe3NOAQOZbCf9Rx3WgyeAd tAh4McLW1o0kjVcY9HjU65dhVZ3N1XxYqZYI7qvgxA0NsNeRKdR4zHzKPfm4Pndum0hF onHRIvJfeqwJyajFfSH+u7xOAdntdpLKnZc5kC6fiFrdvXqwm+mYVI2+4wD8mo3J87pn 8KTITpCc4aIzcKYNSKNdrna4a4NklPtzuhUv89f2NpfCkMHLITCAAA/CN4OLez20ku8v gO9A== X-Forwarded-Encrypted: i=1; AJvYcCUA0cJEyE8IPfF0HzLxu7+ZQoVx/BKuOx5WauJC415ggJ5hsQlTtRbpo//lL8dHnvzg3qxyK1IYAzUmDEF4lnzS@lists.infradead.org X-Gm-Message-State: AOJu0YxJF+KJgCyITtnRJYTuArucdQR2zl/z2eBtM39uJuxOpwtBhAP+ 9AmKqyzg+/5ixMTzOxhk472BA+HvzjNk/f4wjExsMP5Lcl7hWrJ4 X-Gm-Gg: ASbGnctF73un8/jKXDIAKP7YnnQw1k/5gxVWrtSchHODlfVWqwBE+dzecHoSN+Bv92E zDIV8PYhghvZzVPaTpSSq5PMA08hblWkz+Vo8UmD7PtIReAuhAG/C4y6eqX+QWw6X3dyzY3jshJ ZWq5xfkamO7xE9NsW9UDXzf4oLHkxwCf2rmaZoS6fPkGEluoJPuR4pnouMh962Uy0jnmiLmxq9l lyyNAHPQhMRDDjWf3hS6CCfWoIs8ywHApmrReKlfbrCDYdNojV0adCNsW+YQGx4JNJQDPh1vTEy vS6lsm+6N1eI/y9emkoBlrbhpebF3Q== X-Google-Smtp-Source: AGHT+IEUSK/sL4gi2aLg69L2RvsgLCz1QQ9HQlsi/sHzB48lrdXXIwILZrddPrIHBAHT6tkw84447w== X-Received: by 2002:a05:6a00:2d95:b0:730:7600:aeab with SMTP id d2e1a72fcca58-732617dfc60mr9838175b3a.13.1739735963046; Sun, 16 Feb 2025 11:59:23 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:21 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 2/4] drivers/thermal/exymos: Remove redundant IS_ERR() checks for clk_sec clock Date: Mon, 17 Feb 2025 01:28:35 +0530 Message-ID: <20250216195850.5352-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250216_115923_951244_B6CFB4E0 X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Signed-off-by: Anand Moon --- v3: improve the commit message --- drivers/thermal/samsung/exynos_tmu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 9c138772d380..8d26000c73aa 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock); @@ -1115,8 +1113,7 @@ static int exynos_tmu_probe(struct platform_device *pdev) err_clk: clk_unprepare(data->clk); err_clk_sec: - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); return ret; } @@ -1128,8 +1125,7 @@ static void exynos_tmu_remove(struct platform_device *pdev) clk_disable_unprepare(data->sclk); clk_unprepare(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); } #ifdef CONFIG_PM_SLEEP From patchwork Sun Feb 16 19:58:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98095C02198 for ; Sun, 16 Feb 2025 20:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3fU2o4X95qtgokOtXyuTuOjB5JSG2sKXAjoLOfp+pRM=; b=Ta68F1KBSeW5zn5974Wo+GHJh3 95FLxpVee9+nubjNwew+zLmWY+pYJxKIDQA9feYRSsf9QrQ+Ih7b3vA1Rd+ob5a701Ccw83YD+gGb R0k9779BoisWq88jRdOXSTK3tl1G2WQeQIHiIVlTK4PL1NFDGp5qsuuW0No8WyA4KDDTO2a7L37J2 u6hK9xB7aOQmfdBIwwooRb/8litjSu+QgLmCRcOnbStJdqIuorsZeBa81PbYDnw6+/ackudVKOvmk pkRuOYUH5gaitgcIjwXBPukBeCOr1f0bv78nrBYJXliLWEt2z7wOLSapKF/IY3uxynw/Cx3xj7OQr 9JIt4GYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tjksy-00000002WHs-3GAj; Sun, 16 Feb 2025 20:05:04 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tjkna-00000002VYO-1DTt for linux-arm-kernel@lists.infradead.org; Sun, 16 Feb 2025 19:59:31 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2fc1f410186so4807245a91.0 for ; Sun, 16 Feb 2025 11:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735969; x=1740340769; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3fU2o4X95qtgokOtXyuTuOjB5JSG2sKXAjoLOfp+pRM=; b=SDtUZz4gG/6fmnizcH0ocZgEMnlIXVrezzF/W8ydh5bp/jFPKKxVRC8e2PLRNc4W6p XEudktGVdmriV/mHXzwUuIkB1bHgZEiNgIczylhdoLj9l80hI0Y5pGBsasfgI+Uyfn8M SSYKvhkIwDQZXos+jdz6fy/il3uCZB7GWxakoHteSwcbX4oN/ONefHHtNBT81SCvZmhr qom/0jWgqD89qsEXW6/Y/pxzUKy88BVI2ouygCvqiDGmVs7dzkwDFS/R3BQVmsy3Wjp5 Lr0kHbPrBTeV3n3YeiEadwdwQNqC0cvH4clp06oFaOzpJMc4YryeAd3l7upSurq1sSTW 6QmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735969; x=1740340769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3fU2o4X95qtgokOtXyuTuOjB5JSG2sKXAjoLOfp+pRM=; b=XvmzcEkMM0tIHF19+I4gh1GQyrw9HpJ7xxMH1F788MTao322bNp8kkeZgVoNjo1gDj 8+G8TPT+vwIwKoOiVi8+kSS/BDC2M10lIqFnZlKDg9vzfx5zZTRH04AWn2904x4pPLFs CXZoVeKyFKBVT6CPOZ0WvJ1BcAO4pluiHv3RF2KHoidjkRzEMgVTEFMmd6cYTkv5P0cg 3Awlt3UHrQhMuIdrqRGnJQwBNRe5JNkc42/x0h93NBsfL71/bzbBK3Cr0X3j0/z2TrwX q5zLaNl1N+bacnNHi/w4JLGeS1/SjhvSpjKTzq7aR1YNi7fqhVjW7jIsziUWOLjG1cQk HECw== X-Forwarded-Encrypted: i=1; AJvYcCXYLh2wuxfPmefeDxl/Px68cLOmbcDHlzeqaiw+zvkWsqpOARXh4Km2SSPehgrfeOOCsOKXpC/7B2mV/5YH70ba@lists.infradead.org X-Gm-Message-State: AOJu0YyMQ7SybtCmx6oOznZI062peuK/vpF8qNWW/xCxagYFav3waMFu 7MYwmaqFe7u/ouoswzL3Kso3k4E5oGZE75Pjr/m+SLHGYtLaCgDb X-Gm-Gg: ASbGncuRPvUvXfQlNjs7+A6zDMHsZOhH1scNjtjSL4KEu5cC6iGSst52hm52fw0BqWq ffcQMj5xlAerhR6zNMdCndNI4NET38aJ2lgJJBJ85qVU0iC2ALABCGVSFn0dpsvb1VDTFyJZUIk sFoQEYEmbVTUL7JnF+gobDFqQEKsbjVDAjncgA9t3syy4GmpRR6jVCKndwKIP6GDgfw65omh7FY XWGu9Eru4XrpR5i0coOhEnrecKlPbzL7Wizqr6HqkHd23hqtMQ7kmpfSarQCUHbC2y4kFEFTzv2 BmkqzC91i7UQ9r5riOwkX8qbwAHBPw== X-Google-Smtp-Source: AGHT+IF7AzoUr1XgA1+Ea19Qvyb6/a9hAQAMMD8i2pvWMA2A5gLxhj2+OjivqU0UpmUYjnEdPJhzfg== X-Received: by 2002:a05:6a00:4643:b0:725:f1e9:5334 with SMTP id d2e1a72fcca58-7323c751ab9mr30761565b3a.8.1739735969416; Sun, 16 Feb 2025 11:59:29 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:28 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 3/4] drivers/thermal/exymos: Fixed the efuse min max value for exynos5422 Date: Mon, 17 Feb 2025 01:28:36 +0530 Message-ID: <20250216195850.5352-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250216_115930_328456_78760C38 X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As per Exynos5422 user manual e-Fuse range min~max range is 16~76. if e-Fuse value is out of this range, then thermal sensor may not sense thermal data properly. Refactors the efuse value initialization logic within exynos_map_dt_data function by replacing the nested if-else statements with a switch statement. Ensures proper initialization of efuse values based on the SOC type. Signed-off-by: Anand Moon --- v3: improve the commit message, fixing the warning wtth W=1 --- drivers/thermal/samsung/exynos_tmu.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 8d26000c73aa..fe090c1a93ab 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -899,12 +899,23 @@ static int exynos_map_dt_data(struct platform_device *pdev) data->gain = 8; data->reference_voltage = 16; data->efuse_value = 55; - if (data->soc != SOC_ARCH_EXYNOS5420 && - data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) + data->max_efuse_value = 100; + switch (data->soc) { + case SOC_ARCH_EXYNOS3250: + case SOC_ARCH_EXYNOS4412: + case SOC_ARCH_EXYNOS5250: + case SOC_ARCH_EXYNOS5260: data->min_efuse_value = 40; - else + break; + case SOC_ARCH_EXYNOS5420: + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->min_efuse_value = 16; + data->max_efuse_value = 76; + break; + default: data->min_efuse_value = 0; - data->max_efuse_value = 100; + break; + } break; case SOC_ARCH_EXYNOS5433: data->tmu_set_low_temp = exynos5433_tmu_set_low_temp; From patchwork Sun Feb 16 19:58:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13976729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B551C02198 for ; Sun, 16 Feb 2025 20:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vHP5M3yeaCi7IF7vXp1agOw6DIq9vLMPFGh0uk4OOmc=; b=lkI7l0Ai/JutbMz45sL0JD1LUL ElotBLEttHGRJHGuOBbwExAgHCqp/DFLuDbJ2HLFf2F8E1VLigTgG26GD7pYRKAs3+f6yrkVPCGvq 0mAs9LeLqKCrfvJw+DqTzKqFpUj5XnDF+SlJk/BGbKVBjA5lCbZQpbM8D3MA6rxAqtApv3H/12jRV SRrhdo6B2lZRbm+eZ7+91Wtp3YUnNoIcesa0sYTA1CbtYnD3LeRQg0YM6p24tAZO6rCHq4ROs8xVS x+PE68d7ScBsD9ErzWpJUI9DVnce5YA0lmf049dHH+XOM5IbBzjG/loXNjC6vFPe70X/rzBowo2HO MWVh6XHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tjkuO-00000002WRJ-25zp; Sun, 16 Feb 2025 20:06:32 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tjkng-00000002VZD-3CEM for linux-arm-kernel@lists.infradead.org; Sun, 16 Feb 2025 19:59:37 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2fbfa8c73a6so6942786a91.2 for ; Sun, 16 Feb 2025 11:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739735976; x=1740340776; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vHP5M3yeaCi7IF7vXp1agOw6DIq9vLMPFGh0uk4OOmc=; b=lhBSQiBBYBQWzatCAgadxW7XmR0U14U57/ar4PuO33TSQOMZUT2BySOolcjmWZR7vu lGe14nflLL8SPr+sVwDYQtLE3TjsUb7HwZRFUpVK8j7VIVBS+m0vKVktIaNsQLpsKTjv rFM4EJgDYfzp1oDy6fPvjhGWTxW+de2nNrb723jBxtEY3oa0o6O/bJ5KbuoWg/Ok/zpS Hp0r1rAWKI5rWdohqOOYn9KHggzp8a73LvnkfV8sJ3IK1COlmzhWukc/5Uxs0YvNnbmD kOi/DeITfQRPI8Nc2cYfqsxi+58CM/0LcvDVnXrfFQw8vzFEKMquLUXIrCAJPA7FlPjh XARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739735976; x=1740340776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vHP5M3yeaCi7IF7vXp1agOw6DIq9vLMPFGh0uk4OOmc=; b=SqvCxPZ3DVluX2UAc00ysycTkicp/782Nzqn/j4oAR/W0Xx5JMpBpi7aWsdl7+9J7v fSFgUkN53lTS1eeFxmVc4zXTn/r0oSVq4yenyig/dUCzYKwuHf8rrPAW1RRdSStJ1Rkz e1DQaPO949tv2xk1shtXOCxBt1Ph8/fqB9tzr+28SoxZk6VHeeiyG7Th36qk7HjP0Y59 G6S49NsaP74VA3iyoINcL9qwCDrDh4DECcYsqKQnwulBgOZW+TpPmyzaxqG8nuCLkPD3 0VDvqbc7kRJIJyLqIGh6Av73j0rHHaUobQur/te/ksYSUa1CCHXkJjkCFyPdBUSWwdNL vsCQ== X-Forwarded-Encrypted: i=1; AJvYcCVZDfgqQxPIG8Oe8Oi2SGBJ8/07+z5MLUCq6sLMs3j8cRlRvd7KhijEy4IL1co86qS/TzX8BAt8xFWhTFK2BETx@lists.infradead.org X-Gm-Message-State: AOJu0YyZyCH4BNdhxnQb9SjPSX2EOWUBYTtDO76a0dCUOaHWXmvcdbaR Ijy0FsfZrAncjhfzVP7Z2xvynzzp1ZaikKHIxTVGbh7RVVgqr1LH X-Gm-Gg: ASbGnctz2/9HMPe0nyq+/13ilrDPbyFWxWdJUPOjx1DPjy1RcSryQH3tQd1leMqcCAV 6Q7egjciG2riEiARiwt0LfkeeSEpIGC0zmNatkTckn2h0O904gs0Cm5INVof+7hEumgrQPdGBmh 4xR109prD3cvROq3XBPu8XeVDOH167PBUdXAcP6vUTccHZd2UrL49fm84XuE0+f185sIdHNdjWZ RhJco5xXgE03wKD7xt4+4ew9gU9Y7kPzpZgCLjDouONc73XlD61ajR4GtFg16tas65tC2WqjY73 G1oe8iu24mp924oHG47ZR3RQuvzJaw== X-Google-Smtp-Source: AGHT+IHBlw/ULOY6wy1JfyENVCkx1GmwQZMDVZZdLPpzLlvKhW8EBtZbG/71OUMbBtVJDDU3RGHmAA== X-Received: by 2002:a05:6a00:2d0b:b0:72a:9ddf:55ab with SMTP id d2e1a72fcca58-732617b5545mr9505891b3a.10.1739735975841; Sun, 16 Feb 2025 11:59:35 -0800 (PST) Received: from localhost.localdomain ([110.44.101.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73265098570sm3023559b3a.22.2025.02.16.11.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 11:59:35 -0800 (PST) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v3 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex Date: Mon, 17 Feb 2025 01:28:37 +0530 Message-ID: <20250216195850.5352-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250216195850.5352-1-linux.amoon@gmail.com> References: <20250216195850.5352-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250216_115936_799024_1A97AA97 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using guard notation makes the code more compact and error handling more robust by ensuring that mutexes are released in all code paths when control leaves critical section. Signed-off-by: Anand Moon --- v3: new patch --- drivers/thermal/samsung/exynos_tmu.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fe090c1a93ab..a34ba3858d64 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -256,7 +256,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) unsigned int status; int ret = 0; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); clk_enable(data->clk_sec); @@ -270,7 +270,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev) clk_disable(data->clk_sec); clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -292,13 +291,12 @@ static int exynos_thermal_zone_configure(struct platform_device *pdev) return ret; } - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_crit_temp(data, temp / MCELSIUS); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; } @@ -325,12 +323,11 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) { struct exynos_tmu_data *data = platform_get_drvdata(pdev); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_control(pdev, on); data->enabled = on; clk_disable(data->clk); - mutex_unlock(&data->lock); } static void exynos_tmu_update_bit(struct exynos_tmu_data *data, int reg_off, @@ -645,7 +642,7 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) */ return -EAGAIN; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); value = data->tmu_read(data); @@ -655,7 +652,6 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) *temp = code_to_temp(data, value) * MCELSIUS; clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -720,11 +716,10 @@ static int exynos_tmu_set_emulation(struct thermal_zone_device *tz, int temp) if (temp && temp < MCELSIUS) goto out; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_emulation(data, temp); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; out: return ret; @@ -760,14 +755,13 @@ static irqreturn_t exynos_tmu_threaded_irq(int irq, void *id) thermal_zone_device_update(data->tzd, THERMAL_EVENT_UNSPECIFIED); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); /* TODO: take action based on particular interrupt */ data->tmu_clear_irqs(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return IRQ_HANDLED; } @@ -987,7 +981,7 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) { struct exynos_tmu_data *data = thermal_zone_device_priv(tz); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); if (low > INT_MIN) @@ -1000,7 +994,6 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) data->tmu_disable_high(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; }