From patchwork Mon Feb 17 07:33:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13977232 X-Patchwork-Delegate: cel@kernel.org Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EC419ABAC for ; Mon, 17 Feb 2025 07:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739777618; cv=none; b=A2ax4jtUgjQ21t/YaRDyYMJ6UWWX50FLsh2k1JikqzCBRrrx57gXmTGJs4ATG5n7DGe1t056sQhGfALjhOJMBeDWKKBmm1eCxeyD/F9uZ50N1qJisATH9SdJTY5aZRRdae2likUkT+C9OWo1xzOu+UFQC8P7nH7+bQayeYZE1oA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739777618; c=relaxed/simple; bh=zcM0c0V1GS3TZJGed3LcwXT+koAZctVBP1JWt1wC7bs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=G6u48Dc656R6matR9VISJbdaBooraRuO6z1+J9hc4TAmF6brdxBH3VpXSfBxaywTx8GO5sEGVX6wKbFnqFXYTi0uO9SdSj0+q2VpBtuZNOTh9ZvlUdQ2M6s5HR47yqlCpga364SSb0+XpWc0/e29ITQBFO4SeXRVuIwIznaeWg4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DAIbeN7y; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAIbeN7y" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-abb8045c3f3so165396666b.2 for ; Sun, 16 Feb 2025 23:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739777615; x=1740382415; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=d4LcgUMXB/Wz2DoEL+bbrP94KZi1QyVcM8jrNwIU/TI=; b=DAIbeN7yi3FYa7O7TITI1BtUZEFdMsSqQR7IT8S3AuisRtxSU6zkig4Rh9LsplObPi fsJ8qNAltGfR0KqX0P56PX8aBqBh17uhah8GcPd3JSuLVvbRnBaG/CMsHFTUYThZAtGj kWEjb0FTaqcUBd8nEHSEck3dP8ZpMU+gPrEoFinQWt5Vnx8mn6f+1rB5O+Zv9g7jLDlD Y+EzHiOqBU2eQ+SMl8S7jBAUyBK6rfPAcC96G90bvh+Yy/Yy0aWc8yqTOwVMIMEP9yjx neKrFb3d5+nGNBG2CReMURnD0w2BPWmVG00dDbc5ZG0MVm96ur2NcmAUWXSny6QCQs4v 9WPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739777615; x=1740382415; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d4LcgUMXB/Wz2DoEL+bbrP94KZi1QyVcM8jrNwIU/TI=; b=iUPnNup8HKDaGqjYC9nll2+wDf1vTHaKPUrLirJcfMh9kidUCjymlelVXtvUTXJyk6 A6dqTjb/SpHx23rBPvRMLigXAwcCVWjwHxW7es6MouGVBe9J1MQ745/yUo5ZFCyj32ea EuPulkRnVxqKSl5dtXW73P77aaM98FOCxogLTv3KkzTXB79SUlSK0gyS8rjbOtTmXdBk NDfBQWYlSNVBwIVYJ2Gw1PENdDMoSzgAkDE1A2ErUs5OSo3ZSGVdtRoWZC6crfCNXmgm L5B8s3b6wQr2chEphRp8WztgORzxwLX3hqtTLwxBZPNhv2tf7v9db5wbW6gDzIpOZfwB N5LQ== X-Forwarded-Encrypted: i=1; AJvYcCU+MDEq2i7j8hxIezVDJJXOz7ZH8+vBZVeMS9pazK++SeQwnAUDc1ISfL+6vpJ9fHEFy+2jLV414uc=@vger.kernel.org X-Gm-Message-State: AOJu0YydXPXXe7kGSBNkdlAwpKUIJ9iT0bpdzz/YV3k4K1RXrPolIZWb PbGPel0be2fL2Bs0CfNwceccepWPUsZrLdz88/2sbcB85u4Ht20K7skC3PRM5eQ= X-Gm-Gg: ASbGncvJwhwBeQwQfgzZSx7eN6tL7ht+BNw0aKwNNVRWv1cgnjgIoTY3K/nssJMlGr4 RPEVzxKCak2Mhvgs3vGVjuhvF6UPVjjsJ0ShrE0/JwMMAd4ZtvoNVEUVGNByi2wZcR5LSV3/H/V Qg20DHs/od5s6zQakmVZKIc0vKNMCjnPwyBa1BPKHijvndVLwqaEZpHQwNEt/SfVYV8cz/dkaP7 c1FuR87I/mXlgIEL/gLZljbUVYSwVC44iPrut5WKSNV96mBCks+8JbLmk3rU5wEPZPAdgL3XNO2 fO/MJdv2Ti+uIfLtpa6Q X-Google-Smtp-Source: AGHT+IF7SQDPhS34NSoyAyl0oz3XF6hgO/dLFCbg4PL3cGhqcXdyTG7Koy72X0FHVW9/sFD79dcHNA== X-Received: by 2002:a17:907:9802:b0:ab7:bcc0:9067 with SMTP id a640c23a62f3a-abb70dd72f8mr973363966b.40.1739777615128; Sun, 16 Feb 2025 23:33:35 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-abba9657249sm41281166b.38.2025.02.16.23.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 23:33:34 -0800 (PST) Date: Mon, 17 Feb 2025 10:33:31 +0300 From: Dan Carpenter To: Olga Kornievskaia Cc: Chuck Lever , Jeff Layton , Neil Brown , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] nfsd: Fix a WARN_ONCE() message Message-ID: <39691ae0-124e-48ea-8a1a-1a7f26423236@stanley.mountain> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding The first parameter of WARN_ONCE() is supposed to be the condition but it's missing here. This WARN_ONCE() will only print the "xcl_name". Fixes: 61b490d48618 ("nfsd: fix management of listener transports") Signed-off-by: Dan Carpenter Reviewed-by: Jeff Layton --- fs/nfsd/nfsctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 2cd540b26965..ac265d6fde35 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -2027,7 +2027,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info) xprt = svc_find_listener(serv, xcl_name, net, sa); if (xprt) { if (delete) - WARN_ONCE("Transport type=%s already exists\n", + WARN_ONCE(1, "Transport type=%s already exists\n", xcl_name); svc_xprt_put(xprt); continue;