From patchwork Mon Feb 17 17:09:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Colin King (gmail)" X-Patchwork-Id: 13978365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066D0C021A9 for ; Mon, 17 Feb 2025 17:10:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EACB280077; Mon, 17 Feb 2025 12:10:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49AF4280076; Mon, 17 Feb 2025 12:10:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36269280077; Mon, 17 Feb 2025 12:10:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 18356280076 for ; Mon, 17 Feb 2025 12:10:07 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 71B451605E7 for ; Mon, 17 Feb 2025 17:10:06 +0000 (UTC) X-FDA: 83130074412.01.B59A167 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf21.hostedemail.com (Postfix) with ESMTP id 9590B1C0018 for ; Mon, 17 Feb 2025 17:10:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="KcH1d+h/"; spf=pass (imf21.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739812204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=st4+9SuOYSXi/BL8qizMsgfbdxZRW4vboBrM8JIcEZM=; b=uP4rOCwH0gbSSLmBLF5xkuHsQmbgxoq3WlapSnpF/JTKcVrkYIWmEK1MYJh1Y6py7gzVX8 rKQE5JMOL/jf3hayb2PbgpsnQFyMafPf5EkqLRb1GGqS0NqS6LrhRmVacLo6T+3LUgacsz 4f3qYNOC9jiwsYt7NyIghpMi5tGv8Mk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="KcH1d+h/"; spf=pass (imf21.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739812204; a=rsa-sha256; cv=none; b=EKJp1O+5Bbm1a1NlOXLV64GVDoudT5eB1G9b5XMwPPTkKGMI7CARFslcD9n7054qCZ++xv gxmnwQuAZ50/7c22kY3gpU1YblWZom9eM3cNN0rHG9WOx4OZbkAcqOYI3Ncsqw52l10zvi o6IAzEgTAVCX3TXaVJQkYb2qAs7P0rc= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43948021a45so47673405e9.1 for ; Mon, 17 Feb 2025 09:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812203; x=1740417003; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=st4+9SuOYSXi/BL8qizMsgfbdxZRW4vboBrM8JIcEZM=; b=KcH1d+h/RoOxgf4aI9xYyS94+ZLGAG6SX8ykOQHeN3P3yIoqKH5BtVik+9oUw3iUkV ZchW799yGVXi8SniOTpn3+LT2pQBcRdxs+epwzOH8eqGQyjfIktuV9unD7cdkmGO8jLL 7IbdB5QfB5cXRD1oK5c7fMZH05DCavnWnoNgzjzIgHXyrHexS3YkcUit1CpCIgI5/gZG AtsfzDZbcJYH3O06+7eEF2K2jd6st4/cltCn/+FG8fikZiO5BC6x44eKCtHxn3rvMeMR asJBEQ0w7PmrBDCw28ceInTk3YBLnJPB6ZUK2w6ixsPGWZg+0Ntrv09HPTJpmEIfnu1G alkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812203; x=1740417003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=st4+9SuOYSXi/BL8qizMsgfbdxZRW4vboBrM8JIcEZM=; b=HJvvQdN4Izo0CYEmY1tzpHxhPYmEHmj/X+SLqnqbG2dC0zbQmzz7R218gmx31gqzkt cb+9ot7Ux4rWmhEE9CZO1orWfoTYormNl+4nuxCWI/CDwi2rjOPJJOAslDmiWdrSyt42 1D0zhCGidDHyGbTqbRguhonHQriy6GJp9T07qEDMcq0zmn+vlKNJMFBSCKTS03++Vq4J HdMiPWcYqF0KmhC6NQ0lniQz15NqcsNArpG6i/gXKsKONcO1n5SWX+t0Rtmjl3Mb4Xbb JzekPzj2ZIXKM0EOSY40UEFmQ1jCSlrpDr5e1kzzA8l5t73nlc7IsGqCp1ztQ43srNls J+Ag== X-Forwarded-Encrypted: i=1; AJvYcCWEo+GA6tuPe730KIOIlye6WlXrPNpEhA3zZmWzFnzbj2OI/4qXAVvMBwu5M7FyrENlenX0UP/44A==@kvack.org X-Gm-Message-State: AOJu0Yw9SKV8VARTbSq36lrJQ5/Q54F7GorxRo+4J/SPr1R+wLkeHWzU klAzlv231iwqtqqPFLtuub3CpseOd4bwlwa02dkUwbkvLaAdT/Ke X-Gm-Gg: ASbGncsMeilPdgg4RLladNBWh0jLIdlxWol6V66sUuO2WwQ3wcaWH1ZgNKd4cQAyzEx sXIsKNvK1oTRVifLC2/5W45fYdRgx6c1Mk302C7Wu1reHl6LcBg+dVzuN2KhuQ0PNMxqH4pCND8 jn6OIEeAFpaz75gCS96d0MOxFBsdeUIRv6iJZ7RC9jskgicDzQrFucdVtSRanc/b7UB6JYw7F4L /bAjVEaazJhPWe65v3JQHGgZGJtuWKvozqU3nxURDs15dNnBUv7bbm43DZMVSVVWVxmFcA/4dU2 jxAssjIAX6Ao9pzb X-Google-Smtp-Source: AGHT+IFR8wIX5kzLKdIN4OP3fmjkfv73Yd4uUXOuq7Mpy4RCDvMHb9zJ6sCjSSKf8UjQNxFMmKSGoA== X-Received: by 2002:a05:600c:154e:b0:439:8bb1:14b1 with SMTP id 5b1f17b1804b1-4398bb117e6mr31066175e9.11.1739812202821; Mon, 17 Feb 2025 09:10:02 -0800 (PST) Received: from localhost ([194.120.133.72]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4395a1b84bcsm163583295e9.40.2025.02.17.09.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:10:02 -0800 (PST) From: Colin Ian King To: Andrew Morton , linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] mm/mincore: improve performance by adding an unlikely hint Date: Mon, 17 Feb 2025 17:09:34 +0000 Message-ID: <20250217170934.457266-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9590B1C0018 X-Stat-Signature: 7dn4a3an4qeud759knqkhqzpxppiirg6 X-Rspam-User: X-HE-Tag: 1739812204-29660 X-HE-Meta: U2FsdGVkX199Uvlh6QLpudseyElFLKQiweBd1OOjYxC5L+HjksSDZLqpOOxlNirPKrcO+jMS6pFSJqBDIXVXHihSkyB8UjAlo7EmlqhjIzWwDS11VmilHzfh0JdnBN0+MynVMbWV3gTaM1rWUNk3nObiyAdbVg0OvUyErnEjPgnz4KAzkECL/eGBkbRu+X8mlpmY6VsANYvrUERrsLdOdAo4IyMJjwTd0aBVdWkmXbt68Rbm0iGimRn//8zLZZRx/z80VJSNhaJrchpjAYAVkcEH3ODAJzd+Nuj+RxqrdaJidDWgedi3NJpMh9HEDpz1DF0PGivoTwIR6zPKby90VDLNqgMG0oozoR0o0d6vz3ZbOe+afhwQmCXLawU/8jS06iqR7tEsAJ+cmMFpyPQXWoBjj6jVFVoi7708FFS/Uoq7lpIsBL0rUiLykVtI9w0V2g/30p/QGcgTOg1JU+55CgBge5wYBqHpq26iB5UztNVCkFKmJgO0tI/SFUjfmCFgpaOCMR4F+EKiPPMyGSZedObYk24JW7/qsqdzRoYJ0zU6uPwk/xMU+7YtAuvn/LepAkCgXvTvskFmS02zhf1xxuNsCowAMskwkqfRx783abz44tRjV9mvuNBvXjO6oxY8KgXfLfuOQgGdN2+4NfUKqpQ3q6BQK9LaA0AuoABZpwVAaWWdH6LaWBPIroIhnNfqXJ5hBU3Vk7vL9R87wPRhyONjtUA+mTvN0VFyoGhTBCf2zKWpT1vBm5zve9xmuiAEHVVfJjWkAvKZA1v8sL/Flz5z3KMT795tlqntpvOOhpEVzE/hcvq0u5MxtQTDhIyQgtGsiW8k6f2s9fJdWg1ht0WqRi6dnVZ4kXJ+EwF92QQgKil0UOHhqeF/s3H15A0rbjoCI8SdAe8PzJfxryDKFKcHw366xyXLufHWUEYpRYtclVNIJmkI72eT1gJRrh6xXMYWQRESrJaPFArL54d iaiBZ3ZI V0cciip2sFvO3Gv3CkwcjGUvXsw1FHS6CbPlxipWISi+2Fe/ll0eUSdQ+5qUPRqL4kBSs4WsY5zm3FQizk9OcQjDgwLDZ9O8Lq1ZzT3p/l3JRGLDxB/ztq2pB1Uajxr2dqZbhpoJnx5gsFGXSg78gE0k8tujVh2xOnLlSSE4xIpB1Ff1T9r0aGYPtPZRzz+fh7zlusdM0raWwpNQ0rVyG/BqsP0xb7CFHlJdHT/7ZMie3KKnVG5WhK1ZnbetiT0y2DJf+Ynki+5DtpYYUxPb/0pIUXeQqoMeiwNhrLgwdJcCEbeB1I1Mfec+7GrMOQ6el1d0RmmGR+pjLfyqbg09aXU/tI1ObxqVunHhrG4Omfu5nWMa3SGx79hUxPCRH9UG+NudVmUbCnO+oaU1pwE+9HFTBtZ+zfLd6LX8pHtRFu9D0PqA/Dl9YCqJjldWNHX7XJb4OZqopIeZMWJgA+amTqGAc3ksbRZ/aUFLCeDSLbdWr4FXbqJg6rrt1fr21McPXvegJbPAnM0aJW1E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Adding an unlikely() hint on the masked start comparison error return path improves run-time performance of the mincore system call. Benchmarking on an i9-12900 shows an improvement of 7ns on mincore calls on a 256KB mmap'd region where 50% of the pages we resident. Results based on running 20 tests with turbo disabled (to reduce clock freq turbo changes), with 10 second run per test and comparing the number of mincores calls per second. The % standard deviation of the 20 tests was ~0.10%, so results are reliable. Signed-off-by: Colin Ian King --- mm/mincore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mincore.c b/mm/mincore.c index d6bd19e520fc..832f29f46767 100644 --- a/mm/mincore.c +++ b/mm/mincore.c @@ -239,7 +239,7 @@ SYSCALL_DEFINE3(mincore, unsigned long, start, size_t, len, start = untagged_addr(start); /* Check the start address: needs to be page-aligned.. */ - if (start & ~PAGE_MASK) + if (unlikely(start & ~PAGE_MASK)) return -EINVAL; /* ..and we need to be passed a valid user-space range */