From patchwork Wed Feb 19 01:56:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: gaoxu X-Patchwork-Id: 13981421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB7FC021AA for ; Wed, 19 Feb 2025 01:56:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5F952801CB; Tue, 18 Feb 2025 20:56:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0F562801CA; Tue, 18 Feb 2025 20:56:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7962801CB; Tue, 18 Feb 2025 20:56:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9CDCE2801CA for ; Tue, 18 Feb 2025 20:56:36 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 55DC31409EA for ; Wed, 19 Feb 2025 01:56:36 +0000 (UTC) X-FDA: 83135029992.22.E4C1FEA Received: from mta21.hihonor.com (mta21.hihonor.com [81.70.160.142]) by imf21.hostedemail.com (Postfix) with ESMTP id 4B6C91C0003 for ; Wed, 19 Feb 2025 01:56:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=honor.com; spf=pass (imf21.hostedemail.com: domain of gaoxu2@honor.com designates 81.70.160.142 as permitted sender) smtp.mailfrom=gaoxu2@honor.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739930194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=Mc+kH8GEon/PVfC0HKf5NV/vmITYzF+FwowKOyfCJMk=; b=jsHnpO16ujAzNLQhnmuD0pdi/lEK8bsdvVB3TWE9GJTbYIPzVY4y7JX+VLPUSzA9LD7/sw Hs/RWWV7dlWTsbiO49Odg3v91RXf/FfpRFvUmEE5mywk1FiYrB+VqQhAcS015/EYXoIVZh VZ5QCnKdt5Q9oEWOctl0AV2VauoEmDY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=honor.com; spf=pass (imf21.hostedemail.com: domain of gaoxu2@honor.com designates 81.70.160.142 as permitted sender) smtp.mailfrom=gaoxu2@honor.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739930194; a=rsa-sha256; cv=none; b=CNVHZ76CflLv39XweEbIZUQMzLDC3OteQRNcSpbJbx7pOCZtlkoa45KlH7t6DkHI84wS2o r1MuMSK+cx6K+ljauBUvaa8QTpZf/oFFnvYyU2x9lIPGOBvQ2TaDfI3i6VmYKyeztUKSzV y3Ci3xHGXpECy2DaG9Euu+sPaCKOKiw= Received: from w011.hihonor.com (unknown [10.68.20.122]) by mta21.hihonor.com (SkyGuard) with ESMTPS id 4YyKGw4XmzzYky7j; Wed, 19 Feb 2025 09:55:36 +0800 (CST) Received: from a005.hihonor.com (10.68.18.24) by w011.hihonor.com (10.68.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 19 Feb 2025 09:56:29 +0800 Received: from a007.hihonor.com (10.68.22.31) by a005.hihonor.com (10.68.18.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 19 Feb 2025 09:56:28 +0800 Received: from a007.hihonor.com ([fe80::e866:83ac:f23b:c25c]) by a007.hihonor.com ([fe80::e866:83ac:f23b:c25c%10]) with mapi id 15.02.1544.011; Wed, 19 Feb 2025 09:56:28 +0800 From: gaoxu To: Andrew Morton , "linux-mm@kvack.org" CC: "linux-kernel@vger.kernel.org" , "Suren Baghdasaryan" , Barry Song <21cnbao@gmail.com>, "Yosry Ahmed" , Yosry Ahmed Subject: [PATCH v4] mm: Fix possible NULL pointer dereference in __swap_duplicate Thread-Topic: [PATCH v4] mm: Fix possible NULL pointer dereference in __swap_duplicate Thread-Index: AduCcQRTKSEr86o5RfKgi/48SSQ2Jw== Date: Wed, 19 Feb 2025 01:56:28 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.164.11.140] MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 5wgcnf6qefapnoyazi1hsfefrq65zihk X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B6C91C0003 X-HE-Tag: 1739930192-797794 X-HE-Meta: U2FsdGVkX1+1K5VL1OOW0m7iq5cZgYRhEQ8DcUpUz3hSSgt4YBdI8WL83FwPeUtghWLzdCRhmGNuO2iI48GE8Eubj016NZCW0e+31QD+qt/Jf7QWPDGGHfvKgugoHr05CZKzrDtqIQlckbfa5yw+MyMY+cjmx5gQojnA+eNZ+8NkSu6TaQ4yftjSMkPnT+wR8oLQYX0gSLSjymMA9t90r6KhRwitkPQ0B+4JLi56CoCgNuySKPR9p/RYRLHStpLLmeWs+IWgNIbAfHhHUl+12oZ2VjQRiDlTxPZo8bNiYsBRvcCU1iztOSrwLUIjOCeetufb+lfJo49IdDv5D5oy7nMmuKVUGFSqSjmQwGMG3Cg2SVScPN4982RSU9oq3QUYadAIKpO1kr1h5ZPPGQsmKlpWDf/Px4vPBL8WstH0bpLflLBRuNB77DK7g881nKpGWeuNL8HTsngM71UrF3HlYOIgypblS8VljLGZpMa0tdc04j2kPU84tg2h1WvIh+408LIkCKRtADELELYbJlYfrYRGY8sd8O2AqJ7mFEeumsX6gWzb1cWCVVprng/4gaqoq6gBduU3PMyaNoeW23YGrRyCrUmqCsyv8g/cGtjHpewJAJPzMnLWjIhrwtxtPl8MXd6ZOr++37Q0+FxnjoeRdOj3S4T5hK6vtnXNheXmEEdxIy8GgVJbAASk5dbNSASW4+NFQfV7JQz+3y+j305SKZRjecyM8jJv0tLhzfSNmTQ+4/kEq8b8ZBg0a0w0G0rLWXUXIyZV7CqX4tVEjS5Btyq0FY7lkauxKfbl4aTaVQyN0qqpU0zWfkIGNP5vNwJl0Mez90fAQBBfGfTgEMEeMd96JJ5GMTkOVaYEOG4CqhWLi2TXf3bnpwdKscuuK/XG37lb1bLN4AC1dQb7mBdh1+EYUTpqDNBADJc+2Wx6B48jE3kK67FND321pjctXUPqA84RXruB0fad6bIWgsD qndl/NZd IL5wgYPbpkJjOVC9xKz229tcio2PoNjjY4jx9FZHhUkXsYzZBMnj5Y9fZkzjxYKxS3hiGPNS4wXFLNTVwrFfvaxPEaUWcIlBfJb1yD36V6hfT1/50JwI2fVgIqVyURg9X0qPK2zPBRP8nUyvJNkSGACo7OTHtkkBRGvEBvjhNV4LSbBGb/kUhiua4EhoWYIlkD46cjkAVJbJg7jnWTxAvRYfNO7ATnAp4tXP2bMZoLJqCfjXV65/rKq1GzEi/YOL7MZOnwptJLEvEHHYs0X4i7dbnumRrx/YSgS9/D7jl0SgSqbgtGnQlpl3gAOC8bZP6To96e0fw5Kw81xmZznmY3aJVCfklC+EQ0V6P3/3nlIrtYt4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a NULL check on the return value of swp_swap_info in __swap_duplicate to prevent crashes caused by NULL pointer dereference. The reason why swp_swap_info() returns NULL is unclear; it may be due to CPU cache issues or DDR bit flips. The probability of this issue is very small, and the stack info we encountered is as follows： Unable to handle kernel NULL pointer dereference at virtual address 0000000000000058 [RB/E]rb_sreason_str_set: sreason_str set null_pointer Mem abort info: ESR = 0x0000000096000005 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x05: level 1 translation fault Data abort info: ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 user pgtable: 4k pages, 39-bit VAs, pgdp=00000008a80e5000 [0000000000000058] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000 Internal error: Oops: 0000000096000005 [#1] PREEMPT SMP Skip md ftrace buffer dump for: 0x1609e0 ... pc : swap_duplicate+0x44/0x164 lr : copy_page_range+0x508/0x1e78 sp : ffffffc0f2a699e0 x29: ffffffc0f2a699e0 x28: ffffff8a5b28d388 x27: ffffff8b06603388 x26: ffffffdf7291fe70 x25: 0000000000000006 x24: 0000000000100073 x23: 00000000002d2d2f x22: 0000000000000008 x21: 0000000000000000 x20: 00000000002d2d2f x19: 18000000002d2d2f x18: ffffffdf726faec0 x17: 0000000000000000 x16: 0010000000000001 x15: 0040000000000001 x14: 0400000000000001 x13: ff7ffffffffffb7f x12: ffeffffffffffbff x11: ffffff8a5c7e1898 x10: 0000000000000018 x9 : 0000000000000006 x8 : 1800000000000000 x7 : 0000000000000000 x6 : ffffff8057c01f10 x5 : 000000000000a318 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000006daf200000 x1 : 0000000000000001 x0 : 18000000002d2d2f Call trace: swap_duplicate+0x44/0x164 copy_page_range+0x508/0x1e78 copy_process+0x1278/0x21cc kernel_clone+0x90/0x438 __arm64_sys_clone+0x5c/0x8c invoke_syscall+0x58/0x110 do_el0_svc+0x8c/0xe0 el0_svc+0x38/0x9c el0t_64_sync_handler+0x44/0xec el0t_64_sync+0x1a8/0x1ac Code: 9139c35a 71006f3f 54000568 f8797b55 (f9402ea8) ---[ end trace 0000000000000000 ]--- Kernel panic - not syncing: Oops: Fatal exception SMP: stopping secondary CPUs The patch seems to only provide a workaround, but there are no more effective software solutions to handle the bit flips problem. This path will change the issue from a system crash to a process exception, thereby reducing the impact on the entire machine. Signed-off-by: gao xu Reviewed-by: Barry Song --- v1 -> v2: - Add WARN_ON_ONCE. - update the commit info. v2 -> v3: Delete the review tags (This is my issue, and I apologize). V3 -> v4: Add swap entry logging per Barry Song's suggestion. --- mm/swapfile.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/swapfile.c b/mm/swapfile.c index 7448a3876..403df1817 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3521,6 +3521,10 @@ static int __swap_duplicate(swp_entry_t entry, unsigned char usage, int nr) int err, i; si = swp_swap_info(entry); + if (WARN_ON_ONCE(!si)) { + pr_err("%s%08lx\n", Bad_file, entry.val); + return -EINVAL; + } offset = swp_offset(entry); VM_WARN_ON(nr > SWAPFILE_CLUSTER - offset % SWAPFILE_CLUSTER);