From patchwork Wed Feb 19 09:33:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 13981883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F993C021AA for ; Wed, 19 Feb 2025 10:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HexgnrxPn2qKkj+wjVirH1193IFF9aDEtFQ3Wztu3ZY=; b=hEhm6eI/FHVP/n oClRNTTgHFjwQFr9QTx8MJxGgB9te6+6ukEMpWVhOCSMcN4lIm/7uaA26NUs0UKUSwWP5XzHFGfyk uB61tGa/Z7N/wEa78Tj4fy6cn8OTPpconBUAXp4L33Cm80WaB1e+nRj0xtMDwocI1xi7LCdZxHvU1 Y1zkgHUVPMpN/NCt/U0juWFtPN0hcxiqpChE/Be6S42tllOFfisBf3bMwMFqgPgoVuUq3Zw83WoFL Q3hZ45I/pdQ42H+kGDBClBPNRkG84+mhyHLJb6tAkGbNLkDkqKHJ2orVKxzUbpqTUmLVHa8L0CVYs peUFPkFcJ8/DXndR3B8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tkgxi-0000000C363-3ewj; Wed, 19 Feb 2025 10:05:50 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tkgSS-0000000BtWC-2EGx; Wed, 19 Feb 2025 09:33:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MCzguZ2VgyYgHmOIRQ6dYHRDQlMI99iWe+pm1t5HaZc=; b=ZMxTfHK3LL/374MHiPUzZPlx2F barGkQnwynwgyHGyPaj4UB5v+4Rl0RtTPzjh0uqUFZsfjlo9Pu6Ym3yQmKFyBQMmddcGRFnRAT9Vm 145fXiC3iPRUsoDS2AN/6pgfpBO5WpdSRKhYXmtSjHmgVqnkAuU1v8D7hepw7pAfOoSRG1afZTIQA IaNdimQxhxP25KxKaEIUd0xTzj35xKKlPVN+0WdC+FfaEpExyr3zOy6CPcCuibnOO35Nue//zmLS6 ZzD21JwJQuNm8TNgg2b1HGP+SX/Faf1/Y8XUEVOio63b8fwW4YgQL+cIQAhCwvGmINCsSDMScBnPq qgQr7Y7w==; Received: from i53875bc0.versanet.de ([83.135.91.192] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tkgSQ-0007nl-Qz; Wed, 19 Feb 2025 10:33:30 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, lukasz.czechowski@thaumatec.com, Heiko Stuebner Subject: [PATCH 1/2] arm64: dts: rockchip: remove supports-cqe from rk3588 jaguar Date: Wed, 19 Feb 2025 10:33:02 +0100 Message-ID: <20250219093303.2320517-1-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250219_013332_595321_41FBD845 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Heiko Stuebner The sdhci controller supports cqe it seems and necessary code also is in place - in theory. At this point Jaguar and Tiger are the only boards enabling cqe support on the rk3588 and we are seeing reliability issues under load. This can be caused by either a controller-, hw- or driver-issue and definitly needs more investigation to work properly it seems. So disable cqe support on Jaguar for now. Fixes: d1b8b36a2cc5 ("arm64: dts: rockchip: add Theobroma Jaguar SBC") Signed-off-by: Heiko Stuebner Reviewed-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts index 7e8f0a452ca0..be5426b61cac 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts @@ -613,7 +613,6 @@ &sdhci { non-removable; pinctrl-names = "default"; pinctrl-0 = <&emmc_bus8 &emmc_cmd &emmc_clk &emmc_data_strobe>; - supports-cqe; vmmc-supply = <&vcc_3v3_s3>; vqmmc-supply = <&vcc_1v8_s3>; status = "okay"; From patchwork Wed Feb 19 09:33:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Heiko_St=C3=BCbner?= X-Patchwork-Id: 13981871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41B9BC021B0 for ; Wed, 19 Feb 2025 10:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p3gkK7FX+RwYM/7JaHqLYUuFqHz5JtmLUuXcxrtKEVY=; b=xygiHYC+FxtUb1 hOGqqw8Rf/KWkAFQ5AWF8EFmSgSAy8zo1RMDlyzMDft97kPWFAQRLlVL0XIRCd6Mrgdo9m7aOxYwJ mRVdyi85zOCCE1EjH/XfJFhV1BJrtfgOaysdQlDPyd1T6tGUIeWCg416HwFODkXSLFPTqo+Sl4hLI sqb5XP9R7HembKYC2Jm/7WoH5R02k1uV8QPzc35b2WRDNlRffswvwxB/P5r90NwO4cRgKPVnCTqLw puXeoYlHduUnTlHo4OL4tQrJ1TFIWyxYMHzMQbWMCPeFaHHC1LAs8K1KFbac+3c1sBsOZYnBnljVJ WDAxtWdRyvZKDZvMxM8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tkgwG-0000000C2fd-3nkf; Wed, 19 Feb 2025 10:04:20 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tkgSS-0000000BtWH-2End; Wed, 19 Feb 2025 09:33:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vH4/0sUG9+QNhK0ITVG/OSD+cVU4w2SoCvst46XTGXE=; b=ve2MFcP1J/odujnY4NdczgJVYx mvdQZ3zKNbbPE3rFTjV9C5v1HIhUFl/YGA6+PfOLerbEkCq0Tm5qwnONnRnb0TzkFXmKmNzmGnrZo BOJ6XqxKAsttnzwj7sVsagH63laEILi+DpuuU147tJaK+UN7DXitbDlEu2e3PQp5NIXd6MQe/ai75 exDndkfzaCXFw6XNQGEA78lhNBdSK9zfrZZR7AwdP0gMjf6oaCU0WEc/7pZyz6Vf+11CrMGOVdSpP 5S4SVAEpREWplQEh9509gYVIH5FGndixuStJpblJzomENRDt4hb2hKbKuB6gk0AVcayjJDwuscada ej56tdkg==; Received: from i53875bc0.versanet.de ([83.135.91.192] helo=localhost.localdomain) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tkgSR-0007nl-74; Wed, 19 Feb 2025 10:33:31 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, lukasz.czechowski@thaumatec.com, Heiko Stuebner Subject: [PATCH 2/2] arm64: dts: rockchip: remove supports-cqe from rk3588 tiger Date: Wed, 19 Feb 2025 10:33:03 +0100 Message-ID: <20250219093303.2320517-2-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250219093303.2320517-1-heiko@sntech.de> References: <20250219093303.2320517-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250219_013332_591561_0C4A6903 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Heiko Stuebner The sdhci controller supports cqe it seems and necessary code also is in place - in theory. At this point Jaguar and Tiger are the only boards enabling cqe support on the rk3588 and we are seeing reliability issues under load. This can be caused by either a controller-, hw- or driver-issue and definitly needs more investigation to work properly it seems. So disable cqe support on Tiger for now. Fixes: 6173ef24b35b ("arm64: dts: rockchip: add RK3588-Q7 (Tiger) SoM") Signed-off-by: Heiko Stuebner Reviewed-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi index 81a6a05ce13b..e8fa449517c2 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi @@ -386,7 +386,6 @@ &sdhci { non-removable; pinctrl-names = "default"; pinctrl-0 = <&emmc_bus8 &emmc_cmd &emmc_clk &emmc_data_strobe>; - supports-cqe; vmmc-supply = <&vcc_3v3_s3>; vqmmc-supply = <&vcc_1v8_s3>; status = "okay";