From patchwork Wed Feb 19 10:15:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 13981894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D374C021AA for ; Wed, 19 Feb 2025 10:16:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 122D5280221; Wed, 19 Feb 2025 05:16:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D4A3280220; Wed, 19 Feb 2025 05:16:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68F9280221; Wed, 19 Feb 2025 05:16:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BDC77280220 for ; Wed, 19 Feb 2025 05:16:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 73509A0487 for ; Wed, 19 Feb 2025 10:16:32 +0000 (UTC) X-FDA: 83136289824.01.924736D Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 1512540013 for ; Wed, 19 Feb 2025 10:16:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=xF7Woykr; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf17.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739960189; a=rsa-sha256; cv=pass; b=fMHurZILiLM8T1eV5IwYWbySO76GAdCVvlwHi4gW/kfZ8LrH+RtI5rjd3STxBBe6WshLZC CLPQdDOlgVqSko+R+R6PYCGWT/9BKvkA9vukXAumogEDD0IimaTt1KLnVJUp41q8sAMvlj w6JKoGCB6rmF9V33UbyH5bxWPsBnqFM= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=xF7Woykr; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf17.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739960189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6vivwxVzhYXSXRbnUtlPS3+5iB8vM+0LkXpFumT7W7o=; b=K6hLqfAypgNGg1QWh1zw1HIkPJ74uPPTUat6gEv7Asad2yTGCKr7/RfYn4yb7S0k1IxVVw LScQwwCT5TVA1XYqS+GE/ORAwXYdDT7P2xOdKxXDllRDzF8NcAUX81JIV2OpHdg2I5iXDe fPH2Ft66c4TQVlxxNMdhlxFC9FoNQoA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zo6PUXBPJQFdfh6o6UJdDqPVpA2CFG2YhEnVKvQbEGBmR4BcYFDcOOU9+a7PkH62XL5dUTP+8ihRyGNZKMENBhpxZwfjdiCoN5sEKtcfYR/LKNquX8vO9y015SvPhcZlMxiYyLjOqUsSGXQjURytZihvBy69BtpsnT/2P6f/d0Z9dD8sLC6GxetDxigiFqF3QqeKhxgeIUi5kCawcN8jIRwbT8Qpd6E1Nj5dkgBl6jCyKpiZ1qKf8RTT5lgnVLePdS9IaByYeyH2HCRnBHRvRGjN2huu08qTcWbdsZdiDjy6UoY96Pz/j7gvSZyObGvqB6HTaVnSZ47uj93x/P2lLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6vivwxVzhYXSXRbnUtlPS3+5iB8vM+0LkXpFumT7W7o=; b=SmJ6uiEMQnNgZ54GDW0e3JORcvh5uG5F9K3PotzX0o8pRlOxjUBjesfltjcyBSmjzsf6+86KGXt/6dE142Q33VsIou3vUP/Z9BrcAKSdwnRC/8WhRSua3Ag5rsrTkgKdnMRDKmVhRk4g9DvOdXnKMn+9OWKKlfZ+wG8M+lAbuHg26ngEriuyGP2IpJ8os7mi8WHVrUib09q2Z6PFbaH0uFqgaBBPs1YWP3VnFDmLFtw8aHZp77pUUlvZg6PPLKWpIZAm4UbRHbuwJ0cEgfyC3ovGTh7ZI4O1Poj9VWHWwvN3EPmbLlaQIGvL41S5RM1LNmHw39xLl6kNmV9VgJDMPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vivwxVzhYXSXRbnUtlPS3+5iB8vM+0LkXpFumT7W7o=; b=xF7WoykrT5QzJbXj+l4p262d3UV2DG94VfbL0voKY91OabKTqXHFgbjpgIuun9USHcIycJ7/bI5ynifPygcfe9NNSnOnCmNjQqldYJppyLio/2/RVAHq1hXNi/TNc+5GLtw5Bxnb04oMZVC/WE4Vv+VlRi17YJg4BG6we7Ic0S0= Received: from DS0PR17CA0016.namprd17.prod.outlook.com (2603:10b6:8:191::7) by SN7PR12MB7450.namprd12.prod.outlook.com (2603:10b6:806:29a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.18; Wed, 19 Feb 2025 10:16:25 +0000 Received: from DS1PEPF00017099.namprd05.prod.outlook.com (2603:10b6:8:191:cafe::b1) by DS0PR17CA0016.outlook.office365.com (2603:10b6:8:191::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.14 via Frontend Transport; Wed, 19 Feb 2025 10:16:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017099.mail.protection.outlook.com (10.167.18.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8466.11 via Frontend Transport; Wed, 19 Feb 2025 10:16:25 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Feb 2025 04:16:19 -0600 From: Shivank Garg To: , , CC: , , , , , , , , , , , , , , , , Subject: [RFC PATCH v5 1/4] mm/filemap: add mempolicy support to the filemap layer Date: Wed, 19 Feb 2025 10:15:56 +0000 Message-ID: <20250219101559.414878-2-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219101559.414878-1-shivankg@amd.com> References: <20250219101559.414878-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017099:EE_|SN7PR12MB7450:EE_ X-MS-Office365-Filtering-Correlation-Id: 32794388-6786-449d-117a-08dd50ce7748 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: c3ykNuiF2ds+phpf2vqF3WHpnZZlMYGM8d4c2f36yLSZ3RNYXA3BXD/uOCaHRIBHfIFiAu28NSoBprTyn1cDfewY6cA1eOiNgYWuJwPO7erNWql0/lNO46YGrzSZ/e09IM+PN+1ax9Sq0PPRS1HmgDRvsYEHkz3Sd8iweLmcQyZZ7GzpCoCJJISUkp6Q31dk8xyporGCnsjNwDlRC+Hus5uuI86bXQpUa1uzYt/HrxvLBWkZGsgQMqjTcjIx63ryf1W/bX5FnpvaRXetngTJWCZjIi9SfEf2aEFcDhL9PlKh61Z3HoM6l60COxhMx3kpIawaPFruJgVinG/rEFAO2mnBFeyP6QEBzSoY252ph/wBIXxp3UdyLo0wIBRwoxmRZmUQvubYi0UPqy+z3RgzPPexZBPwOsziu45mhLuX/a7ZkJPYTf47uEwwNsi54GEfDO6zcT869sybxVq3GibqzbLmcdLIdo3antMozra9+0/oVkI2Eu0fFDLlQAiJG7RWnS8u03f3FhSFmdLhssrLHxLKw4zx38PQXEWYcoGkE9yVgoqLvTQaxEGBDnc3FSqCnAMnMYijUJ9xn+cGiE0AyXRTOZRekTVRSpcqRMo3BniBflJJWgPHggMDh29+rHQIkpjE9iJ6CxNUlnjsgTNeXiXeG4Zd2HA36LYUXNSdo2HfEy0q6pACqUWmj513HglLq5xW+dhkeM937C8nc+o22e8PWM/qudxGupSyVzt0QdPqUssEzDty5SIvQG3KkRiFrCr1Acn3R7qifcRZDPJWZoloYaji4aBkShCPc1WUuKHZTpNmfUHqpl8XRf4D3SCf1e8y/iIksCVipLEtphQY9iTcxJN0hiLALFR4qN5aTsmWHxG8ppaUuJbjmqdqhezW9kwlNBZc74Ja3D29iKzEiHdRmBh+81FhJUDsdiQqJ3g2xJ0ji20SkxqF3jV2JEQ6h7fPVWypN5abLpHAya4SiEJaDh5UT3hCPC51lV2Zzza43Ga4uIx5bl499LB2ty/vLrzE8MWaKf0wbUYa+5d4mpmJBF6QfpRVpZMiRh7IE3xdT5Od7RkjxxTyOASj/d6Orh94FpQ4XJMLw8o6i+PnFq+rSZh4axb5pv5vNHhqcNCgYrYu/bPhMI2u5bf6bfQVrSDAVs6xmYyGPK87KzSMnZjLh+qc8Wb4fJTlJR/7EQGwUMhyFJuqJT599j/MTcTLwkSMujNElrWi5Zcl43g2Xm2YeKK01qqSypys0gXOrLTB38lbZhjYGVIar+QwSWdG2Ppd+us9MGIpNF9mqnN9iKqhQ6Ass/XwZFfQFgPK6ZVRiY2C+dGdDgC4YiUL1d+Jp4T9bn59NLqq3vja8nyodfIdUkihE9ClPWfWfb6JHpHei+t0V55wFfL4LiZiPADfZ1Dfoq7LrnHiak4Ivm7yo1NwSSWdlDHxvyUCaXUpw67V+YoZs/F/i/AK7JuEHhRUoW1U0I1P8N3VxckwIXt1MhPLFdLQdID/P9ymfLhdwyU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2025 10:16:25.0237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32794388-6786-449d-117a-08dd50ce7748 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017099.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7450 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1512540013 X-Stat-Signature: zwcok5n5zkmgppx1x6e9z4miaw9f1cdj X-Rspam-User: X-HE-Tag: 1739960188-291476 X-HE-Meta: U2FsdGVkX18pcgCPqpU0tEukNIV/POC5pQ9rSoqi8gxkR4qCiF/XfDL86t8OOgs/P9aQdSmhqFcsUVa3CP6JEdSP7vkGZluHwCaq8L79cAage7v3mLVe9WgLhWS7OPfwUBWN5mHo+cJehgsQ1+uGQazwMvI4efaHGTRyOgf//Hn+Y3LWCBXS7WiX70tmc6N5/84PfIVevFV+FjvJI8Q9MTRuPmZCngQY6LtjDcjHDXEE4jPAvhyzebh2slXeh3SokDEK6mRR4EVCvTK/X4xci8pFxMmyoVW3ImD8Wg91i/vO7/H6uwn5D/whCRZqjzLgNn6XB+BdaSvxvVhzv12ecqdAIUBbhTck3GIVEsGXv6F4LmvZyZE0+ymGbbnl4XtyR/XVHkVXonz5kbD7JlKN/VI00Hm2wNtzjJ2acpDoJ6e9B9iSi+225ZZnWpthbjV3t/df/9GoY4ly/7AzaJnk0gJ/j/dQ4ewLfDHoHXAWF2ba1cJEKZkeW5/uAM2GZgOy7FfW6UnsWqEMSZ0O+qWfooNQpDESNivIE2p4Bunx4Nt/AawhuUSGeWUNYYdzB4R6mo12UYxDcTlwEa9O1xK7kUQn4fowPVVB0PVYdmmv9eapi6VludGLtNs1fJBaaBjwGfKK3aukgsKGjRtalCswnv1Wq6Ts0OR804T2HxLTh8HQTwwtEOp6Grrw2vlnYgun9DZB66IcDGeHSDCJzMnmgZY3Zlh25nox5+zTFdiTN9AnOOU9TBH+FV38xTGV4EG1vh5yuqMBB6AR36tjZVQne6Yq3ZGJW/difNcUkF8iLT1LYl/y3ehvy4S0+ILV5gClRH8aVqXm0IHRw1yfuadYfE/Fr/UaapTpp0VG3IxIQYQuvHcwRBWnhDUwtXcTI/X6zNuRYnN5HY6PedM4spNHxLphmVQWmYfYnzJu7o6RskeOsph5br17fxvRAFH/7FXZ7ni2d+P7vEGOTyWWDiB pB6TvjhK 13j5LiePEqhFVSQ1si4R8vMvQt7o0FyIM06O58ysdMH/JEWDt92YSfPayEs3qThA9u3Fx/x7wtzuZmQmEQgTOE71JlbkjK7FJQ8sIYI7+I7muWNkPE5+YXYTwOAkag7wDdDS/V1M7rYGsFBWfaQyBhvhAGdvl76v4xQb8I6EykGgpsvj59A4eNai17WnsjcMTh7/9jbFGGjnQpvOfTtb9Ueeeuqucxe+a1WpyUbv6ql0dO3BxqsiCQZ75XJGUNEH+5hTH/q5NI14pPOaX2uHbIWsKcWxz7rTICCYthMgkNFjb0ux1K5Xym4trigmM27dBTUUkTI8KYVCb9swl4SsXswub58L4ljBeqjX1EWybwQf9aNqDTqx9fgClRiirsCMbppJkW54FbbVgf+tWr0Qt2bG/D9Zk62SNY1YX/pm5xcPUTC2zhbdpD1FaVBi48ks3knL4ncnIqkGHBYIAsYFPk3Rh2nI7VF+v2hX+6qAfh4nt5G+yfnIOCgmNfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shivansh Dhiman Add NUMA mempolicy support to the filemap allocation path by introducing new APIs that take a mempolicy argument: - filemap_grab_folio_mpol() - filemap_alloc_folio_mpol() - __filemap_get_folio_mpol() These APIs allow callers to specify a NUMA policy during page cache allocations, enabling fine-grained control over memory placement. This is particularly needed by KVM when using guest-memfd memory backends, where the guest memory needs to be allocated according to the NUMA policy specified by VMM. The existing non-mempolicy APIs remain unchanged and continue to use the default allocation behavior. Signed-off-by: Shivansh Dhiman Signed-off-by: Shivank Garg --- include/linux/pagemap.h | 39 +++++++++++++++++++++++++++++++++++++++ mm/filemap.c | 30 +++++++++++++++++++++++++----- 2 files changed, 64 insertions(+), 5 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 47bfc6b1b632..f480b3b29113 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -662,15 +662,24 @@ static inline void *detach_page_private(struct page *page) #ifdef CONFIG_NUMA struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order); +struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, unsigned int order, + struct mempolicy *mpol); #else static inline struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) { return folio_alloc_noprof(gfp, order); } +static inline struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, + unsigned int order, struct mempolicy *mpol) +{ + return filemap_alloc_folio_noprof(gfp, order); +} #endif #define filemap_alloc_folio(...) \ alloc_hooks(filemap_alloc_folio_noprof(__VA_ARGS__)) +#define filemap_alloc_folio_mpol(...) \ + alloc_hooks(filemap_alloc_folio_mpol_noprof(__VA_ARGS__)) static inline struct page *__page_cache_alloc(gfp_t gfp) { @@ -762,6 +771,8 @@ static inline fgf_t fgf_set_order(size_t size) void *filemap_get_entry(struct address_space *mapping, pgoff_t index); struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, fgf_t fgp_flags, gfp_t gfp); +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol); struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, fgf_t fgp_flags, gfp_t gfp); @@ -820,6 +831,34 @@ static inline struct folio *filemap_grab_folio(struct address_space *mapping, mapping_gfp_mask(mapping)); } +/** + * filemap_grab_folio_mpol - grab a folio from the page cache. + * @mapping: The address space to search. + * @index: The page index. + * @mpol: The mempolicy to apply when allocating a new folio. + * + * Same as filemap_grab_folio(), except that it allocates the folio using + * given memory policy. + * + * Return: A found or created folio. ERR_PTR(-ENOMEM) if no folio is found + * and failed to create a folio. + */ +#ifdef CONFIG_NUMA +static inline struct folio *filemap_grab_folio_mpol(struct address_space *mapping, + pgoff_t index, struct mempolicy *mpol) +{ + return __filemap_get_folio_mpol(mapping, index, + FGP_LOCK | FGP_ACCESSED | FGP_CREAT, + mapping_gfp_mask(mapping), mpol); +} +#else +static inline struct folio *filemap_grab_folio_mpol(struct address_space *mapping, + pgoff_t index, struct mempolicy *mpol) +{ + return filemap_grab_folio(mapping, index); +} +#endif /* CONFIG_NUMA */ + /** * find_get_page - find and get a page reference * @mapping: the address_space to search diff --git a/mm/filemap.c b/mm/filemap.c index 804d7365680c..9abb20c4d705 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1001,11 +1001,17 @@ int filemap_add_folio(struct address_space *mapping, struct folio *folio, EXPORT_SYMBOL_GPL(filemap_add_folio); #ifdef CONFIG_NUMA -struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) +struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, unsigned int order, + struct mempolicy *mpol) { int n; struct folio *folio; + if (mpol) + return folio_alloc_mpol_noprof(gfp, order, mpol, + NO_INTERLEAVE_INDEX, + numa_node_id()); + if (cpuset_do_page_mem_spread()) { unsigned int cpuset_mems_cookie; do { @@ -1018,6 +1024,12 @@ struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) } return folio_alloc_noprof(gfp, order); } +EXPORT_SYMBOL(filemap_alloc_folio_mpol_noprof); + +struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) +{ + return filemap_alloc_folio_mpol_noprof(gfp, order, NULL); +} EXPORT_SYMBOL(filemap_alloc_folio_noprof); #endif @@ -1881,11 +1893,12 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) } /** - * __filemap_get_folio - Find and get a reference to a folio. + * __filemap_get_folio_mpol - Find and get a reference to a folio. * @mapping: The address_space to search. * @index: The page index. * @fgp_flags: %FGP flags modify how the folio is returned. * @gfp: Memory allocation flags to use if %FGP_CREAT is specified. + * @mpol: The mempolicy to apply when allocating a new folio. * * Looks up the page cache entry at @mapping & @index. * @@ -1896,8 +1909,8 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) * * Return: The found folio or an ERR_PTR() otherwise. */ -struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, - fgf_t fgp_flags, gfp_t gfp) +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, pgoff_t index, + fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol) { struct folio *folio; @@ -1967,7 +1980,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, err = -ENOMEM; if (order > min_order) alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; - folio = filemap_alloc_folio(alloc_gfp, order); + folio = filemap_alloc_folio_mpol(alloc_gfp, order, mpol); if (!folio) continue; @@ -2003,6 +2016,13 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, folio_clear_dropbehind(folio); return folio; } +EXPORT_SYMBOL(__filemap_get_folio_mpol); + +struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, + fgf_t fgp_flags, gfp_t gfp) +{ + return __filemap_get_folio_mpol(mapping, index, fgp_flags, gfp, NULL); +} EXPORT_SYMBOL(__filemap_get_folio); static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max, From patchwork Wed Feb 19 10:15:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 13981895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86AD7C021AA for ; Wed, 19 Feb 2025 10:16:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E674280222; Wed, 19 Feb 2025 05:16:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16FBA280220; Wed, 19 Feb 2025 05:16:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010B1280222; Wed, 19 Feb 2025 05:16:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D61F6280220 for ; Wed, 19 Feb 2025 05:16:37 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D18116155C for ; Wed, 19 Feb 2025 10:16:37 +0000 (UTC) X-FDA: 83136290034.06.ADC95BE Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by imf05.hostedemail.com (Postfix) with ESMTP id A3C92100012 for ; Wed, 19 Feb 2025 10:16:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aVdx9rNz; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of shivankg@amd.com designates 40.107.243.55 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739960194; a=rsa-sha256; cv=pass; b=HNdvdekrKsNeIDqDqdUHRAKUiLgI4WQHggkpr14Vr9m60H58t8qCYkkJJf/XxCfxiKF/cZ gHQCp8kM8IjaWQHcxy473P0ijkUbljiergm2IEjqIovZGlDsE91plAphUZh4TQl6Dpkd0U 5RrijtTcpBuvQw1ofQtQ1//lQPnIJgk= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aVdx9rNz; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of shivankg@amd.com designates 40.107.243.55 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739960194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nqb0jtY+YBE8UTi1L4MtyrkH6UifbjkFhzWBlcaw9g8=; b=Wc+MNKIGiLRRVFiI3g5TCKNtOnwf8sxtUgU48XSwwtQwHZJDYSGIUNqxv+9+oclJ7NS5vW cdgDagGId8IhI1FTtAFWeaA4x3/ecJ3DofV98SlQI01KGBY4C4Vbs/zxr/+jxlxU77RfSn Va+HGPzK0CWVkmGZ7dsgyiuTvLndYLE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CSFzALFh6Ex71sAGv5+rsSmyT9Nl2KQcTp+/BfcfFE0yro7xjMW8Tw5BAgtqP5SmoOiDsWwfRKCIZSWPXCFGRA5bEMPavkQBorNi4eMUU/tqLGewDsK7F9ZdcchRv6REBwD3VtfS220rwOzw6eAiIDS9r9spR+2pDnXQ8C1K0dkRSde5lLPk+Hiawh1CJJchj3VJTZhdGk4vEOjMDhPaAdoVjJfj1/3vNpqtqeZ2fst+0+tkL5HzjOLVXYI5BMO8p9EBb8b/nblsJXvbtqYVOcX0psMdImv25M/RvggVfn2oVrV2s9VdO/P1zdYUTzcdK22PHiPPqlZk+B97/A6CNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nqb0jtY+YBE8UTi1L4MtyrkH6UifbjkFhzWBlcaw9g8=; b=bDPx8Sz46mZ9zuSe7193iaOUtjR6X5FOgwM+NV59WSqO6vZA+CXdG9BUf43q5JmnpO0j3/24bOu/FwbttW2Cr8xbXgoz36kC5HEzs6G/AAflKGmhDhY8GeBHjJecLFh1t6CjBTYAj5ngAwnBI7CEjDCF6UCWSsDpQsJxAfcF+qGw7B2GfvO1N05Eu0G1qM6OD+Em71ecd12u17ien1kwAqGkSFgbQgKtSH//qxwd4Fx3FtUkjNnYG9fW24pQX1+Qksgynnjj6cOljqO3Qji4MX0h4gy5mkv8gV+vUOzP1qSqWuWQ7RvF26NXtfvsOoD+/+sNsR8BCJC+e94GUo7z9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nqb0jtY+YBE8UTi1L4MtyrkH6UifbjkFhzWBlcaw9g8=; b=aVdx9rNzJhDUfYXOvAwwY5fkt8Mma19xs8AkqRqCHCsj2GkGZ6KYEgfck1HPRu+VDwdyC/o4XsWbAbrw2LkQAOS0ZcSbuauL+iJ8sEuw1ES+2zMDHhhoGqcxR27DlDgY7NHFFVZY4qTa3CMOzBNt9AiAOSqOT6qm/yyomGQBzow= Received: from DS7PR03CA0354.namprd03.prod.outlook.com (2603:10b6:8:55::12) by MN2PR12MB4392.namprd12.prod.outlook.com (2603:10b6:208:264::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Wed, 19 Feb 2025 10:16:31 +0000 Received: from DS1PEPF00017097.namprd05.prod.outlook.com (2603:10b6:8:55:cafe::94) by DS7PR03CA0354.outlook.office365.com (2603:10b6:8:55::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.15 via Frontend Transport; Wed, 19 Feb 2025 10:16:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017097.mail.protection.outlook.com (10.167.18.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8466.11 via Frontend Transport; Wed, 19 Feb 2025 10:16:30 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Feb 2025 04:16:24 -0600 From: Shivank Garg To: , , CC: , , , , , , , , , , , , , , , , Subject: [RFC PATCH v5 2/4] mm/mempolicy: export memory policy symbols Date: Wed, 19 Feb 2025 10:15:57 +0000 Message-ID: <20250219101559.414878-3-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219101559.414878-1-shivankg@amd.com> References: <20250219101559.414878-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017097:EE_|MN2PR12MB4392:EE_ X-MS-Office365-Filtering-Correlation-Id: 58eca7c8-cff4-4fd5-44a4-08dd50ce7ab8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: xSmjFw0gylpVL3+Fpk7+LmQDjEwN+BIv98+/UBtZ3beMKHMgYQXP9/YX8VETgm7qn2RgWa/eoHnAboaf+TWaRyr0QHThoxM+zQAWuMfR8MZfGyctVBr26qbZ2zB/+A7pJWSBOWHLx+kYhGR2iEzBa8l1dgAojaSpCr/LAj5JbfCnIiGWJra1O3wJUt9q6K/INUG67Pdh2ZkDrYEZ86BrnfIqCa0CTK07c5KYts2n1aX4/AQUh0vr3uBPkWvEhbiQ3yCGnoENHVQy01PRxua0CVAnkrxGd7vL8QY3lNT9U4ksjbds3XellA2gahlrt7VGcGQ6xIdkSyfzE+1yl50+4a4rlUTwQNuiYyZuYk9GXDRzTPqbnkPLmglKjwur6Mif0Tp3hPqooEuu3Ku+r4ly1fUTS2jVo5aupwCaQ0gVD+Xa/ocLV3D/Lp7e1olQ+mLyA1lz6e3JtR26MWqII00lda8y6//tEIWwIuScSADA3z/+Ukd7h6wYmVfT5FUeixdGXZqeHx7yrJGbWxby1wAskqCcVVwXDLU3LQ6nFwjezlUYqJgoapKTDMAEGOWA0urHdHcHG5VynTAAS+AsWVfoaSAvgVxvCExEXxBDUAGJsJQ2cGKLN+vnzvHv7HnDaMgBWhp3I4xdVdu1kcrABLQLgDxU/MeS8AoTD/gXLP26Sukf6jeScGEs3JPIH0oO5aWQ2sFVhH5F70f43UvyghbNogtZfLtkE+n4fyp4OKzQBao+kv/2WuH1M9x+m1DaiXX1VJ46ZLQJm88RvBY4uMPmm/a4x4oyvVkmWLSeGm/mWGYPDIPim0KtZRkwWUaKSfSunhWlVKWvgjhvF98qq4IUA4Jar/8/zJ68y0g4OGnPiMN5BAtSFxNKi/5kyYM80IE6Za09yUgWl0nKwrwX2W5YaaSqJz0Vs86kMnI63eFudv2UkcPZZtJtmiQj6JpO5rxolu4NT5or8hja6wOR5DDjHR6iaotpv3KzPDnNnuXg95DYvUyb/kQVgb5Pi+WMAmSzWDnZI9CywZORa/2S32J59+gfPtlOSldegzJa9ULg+i/Np8SB6w8FIWPf554RiQig8SPG6+4Al25nJdzNm8K8riQ+kchRkMeCuGViLm0nCdnYeQ7jzHTTQxUJZzM8lWvyNokB/Ut0OCHfm7BuBEyKsMZ/CspP1zr3y31CIMKDHhbtQdubXm3XpY0JStZh06k29lfav7IUeYlc7828dhq0ptBFIUeZ5hBzVOuaOekZhX+TQ7RnttR3at9bPnRFtaa85WQC1ZLCZfx8qOQ3zi3XVhupFfPUzG20fkxZ8yxCuMPmswslLNVKFNbNVrDkRV0jaNE+qOkM2lcVlaaS1x0h3krdyaIt0+3QYlGAinKYVFSs/SaM3MYgdmzcKzv9Yp2vOIA3bmeNDXFT1GnJnTmUtmG1b5aLmrLYoBN02f4koXTwsRIzRBO2fcYFFnzYqxP4fPLw9JlY5Z334hYVg/zA/W48OWna5aeSTjYGt/Q5nwQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2025 10:16:30.7922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58eca7c8-cff4-4fd5-44a4-08dd50ce7ab8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017097.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4392 X-Rspam-User: X-Rspamd-Queue-Id: A3C92100012 X-Rspamd-Server: rspam12 X-Stat-Signature: njg8wa6s1e7gx6ie16qbmh7zywgk4jkz X-HE-Tag: 1739960194-550961 X-HE-Meta: U2FsdGVkX1+L5pHruVc+jj19wQxQ3K49kboWJojFdHtGA71KagzxJpy9KkqZLS+eOwIb7AdhaFccERHc1gm9e0FZ4gPVpgkWlF7CfxryYiFtnYz0da7lnfkqdo1IhJvyqbWMvQ/AQQzB0W9Az2L+dOtHafJjs9sZegqh/HHF2f2IEY9i1PKiQdLWFGhLZUjCqRz8jK1ST16xNSyHbF6tWALZJbsFJBc0bC0988kIG7yAh9GrZy9YF0NYGanFt775HR/Sd2VwRzYTVvL+u9O3FL3N3X8NSWuSSSzPi+IoCZ2zukkk1Db2Qt4CUD2wlHpJnq9Kod4LklQb1O9SI6e5V+jgZRvRZ76lqIeBGOYiYt+WoVo/IPR9lCano38nAGFkvgAMJ1pvjTCQrRfGjIjlWTZaaNALX6pwukRB/6ed2GDYErulpbGXACfb3ZQH0jEW1Ll3HJA2gXN+IYMI2a9jLUKzwhXognT/MfJeegtpv6O+MAs3vRZqiEPPDEE204+0hx2Ptagj8F3Uqmcdt9Z9VoTAkrIk8x5hpYb9hBprVIHVcGF3ngHYmJ5I0J/sfYegGgnD53zdo2YicYPzELUjRJgmmw6ytJjMQNE0Ed5/PHAwUbhZ8RIqWj7rhzohwU/NrIiJv+pKgRgSMdK6wekUm3UghymjKLj0oolnAAbtKM3MOxhffP+lCXKPd9siAFkiHlgWaGO1bOzWB/S1CJ445us0RZ5w5pHfKrq5FstpDAwxx1VH1SwUedd2z2k8KjBINbjJbE8PEqApTW8ElQfGOhtWdFLWjYaCZDEL46rD8bAUkPyt2GyhZDj6mbg9QdGJKuFLZBQnc84WteJw+u7a7faBK2ERmUeY7Q3QNTqQukAzhhumvJHY3LLpP2KI9g8FMhtKmgqcz/obAofrICQHasJDpucQx0pYzJnkhbcNwWu2WcunLTXMywNeocBB2WD3eIHtLxbM5q9/x0s+1lS sBxn9TkH nIoruTlLlREcDyA8hMuvEE9rtfum0UfBXaLnLE7I+x4QCidxI19uFuyihUk5OChrsdTUKksGNt4Xh5nGdBO9h1yMnT5PZOOlR/Gm4RM1MQ/mDBEeuBP4li7qz0w5iNivhI/y4uJq1K6i5FyQGWrZiH+7Nl1HrWqjE62Hl3vnD7AjoA7cOqqD8NBWiMk0C4rc9C/sxPhY8jUkgQ9I9B+nRxBDaCg/k1RV6cRUh7s4tVWUGj6O2kidtyi9Tvar5EVqbMw9OLlZlnFvDBQd5ByhREiTS6FJ0f/WLNesZTaese6hqHfrKVNWAEeBOZKVUheucL3ZDDxpkt0gYdLCBUXPoMrya8xcBpBq1P3uFhhftxZJDAOdU1sbdKeDwV55hGvS1obdso2n5YZGwqVRgID5mDfjkjjd5bdR3Sqo1IkRIHSUWZhq0DwKTRe6UlIyOWASJADzQBt1oyX2u1RF3J/W6fozO6xHZKZoVeoS4dywwiOTg7JZxSjsIPo3QLjzUSQjzrRczaT8tyhONs70= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: KVM guest_memfd wants to implement support for NUMA policies just like shmem already does using the shared policy infrastructure. As guest_memfd currently resides in KVM module code, we have to export the relevant symbols. In the future, guest_memfd might be moved to core-mm, at which point the symbols no longer would have to be exported. When/if that happens is still unclear. Acked-by: David Hildenbrand Signed-off-by: Shivank Garg --- mm/mempolicy.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index bbaadbeeb291..d9c5dcdadcd0 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -214,6 +214,7 @@ struct mempolicy *get_task_policy(struct task_struct *p) return &default_policy; } +EXPORT_SYMBOL_GPL(get_task_policy); static const struct mempolicy_operations { int (*create)(struct mempolicy *pol, const nodemask_t *nodes); @@ -347,6 +348,7 @@ void __mpol_put(struct mempolicy *pol) return; kmem_cache_free(policy_cache, pol); } +EXPORT_SYMBOL_GPL(__mpol_put); static void mpol_rebind_default(struct mempolicy *pol, const nodemask_t *nodes) { @@ -2736,6 +2738,7 @@ struct mempolicy *mpol_shared_policy_lookup(struct shared_policy *sp, read_unlock(&sp->lock); return pol; } +EXPORT_SYMBOL_GPL(mpol_shared_policy_lookup); static void sp_free(struct sp_node *n) { @@ -3021,6 +3024,7 @@ void mpol_shared_policy_init(struct shared_policy *sp, struct mempolicy *mpol) mpol_put(mpol); /* drop our incoming ref on sb mpol */ } } +EXPORT_SYMBOL_GPL(mpol_shared_policy_init); int mpol_set_shared_policy(struct shared_policy *sp, struct vm_area_struct *vma, struct mempolicy *pol) @@ -3039,6 +3043,7 @@ int mpol_set_shared_policy(struct shared_policy *sp, sp_free(new); return err; } +EXPORT_SYMBOL_GPL(mpol_set_shared_policy); /* Free a backing policy store on inode delete. */ void mpol_free_shared_policy(struct shared_policy *sp) @@ -3057,6 +3062,7 @@ void mpol_free_shared_policy(struct shared_policy *sp) } write_unlock(&sp->lock); } +EXPORT_SYMBOL_GPL(mpol_free_shared_policy); #ifdef CONFIG_NUMA_BALANCING static int __initdata numabalancing_override; From patchwork Wed Feb 19 10:15:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 13981896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4162BC021AA for ; Wed, 19 Feb 2025 10:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE48A280223; Wed, 19 Feb 2025 05:16:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C5F280220; Wed, 19 Feb 2025 05:16:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE528280223; Wed, 19 Feb 2025 05:16:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 90337280220 for ; Wed, 19 Feb 2025 05:16:43 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 35C40814B3 for ; Wed, 19 Feb 2025 10:16:43 +0000 (UTC) X-FDA: 83136290286.19.771F135 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 2A084100009 for ; Wed, 19 Feb 2025 10:16:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=tRaCNERl; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 40.107.243.50 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739960200; a=rsa-sha256; cv=pass; b=M1wlqcEhTMpa1tO/MwWVgRUy7BbAlostgt+biR2EMDNZWd8Ul+8w88BXjwAdIVeS6SuzQL QYJPcz9xL3bdShvvVv93CcH9LTGrh5Oog9fbg9cTGBupKIC1/H/tdYpuMijKi0k9E825ej etPLJ35uVTNJVA1np6Fh854Peo8r9wo= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=tRaCNERl; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 40.107.243.50 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739960200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1WyTv0vp4UZ22UKY0LFCu3N2m2jNLLIInwMWjCShJ00=; b=ORmcr3r8ukyPZgRDRB3ahNXziCVIHUk44kWPNoEX3jucKRxubGgoTqA1O2fVUSmETQoJMB b1XhCmBcCE69j4oZZkw5KOos8zLCKw7ETKx4IbLnfRcyIjuK8lpwP85B1I7fb/yORzsWwR jvR4WsHYAlNlM/vWohBQ+O7+Nu9L/Eg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pZu4RMNBuUD6NwXXR9tLNji8/5/tdcPRiv9wd+Tt3G8o7O00OmsvKRnLYMoSF+QTZcUE+nxV2fT5spXs7CZOUVHp1GvbogGKqUrAIOLJZSddIxZnwMOJKdncokeCHPM15O7uHCyaAMmV2A8KXHs01fxAV6Aj+vOu/Wk4lsC1ap/yxTnOqiwCKgs7C0i48SBcJOxKGdyr3M0KV2d6p0cvUxUjRta4l2hVC22Q2cTNJ7Fft07XNSY8JbcXXoHC5vFVJxEz3Jjzvb38HYHbtinr+/Y7qkPYhRy5jroUfYNayN/+BHseTQLxB0IQpuOmSd52ZGSEVyrqTPABC2ZaR6Tcqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1WyTv0vp4UZ22UKY0LFCu3N2m2jNLLIInwMWjCShJ00=; b=lbbxSgO6LER6RbrQUY6sCI9gInJfA4IUGnqbVQSmqxyo3/DZC73uc7MM92Fy0DbdVIWAos12MJbEHPsRBlCch01r6lz8Ntfm+DvIRaNSLLbfcAmIZgpXUTGY9USk0x6NPYCYXqhs1tWuIpBf7E5HfaSYtTI3oGWlsqUYGTK1YuwlaCYCRRJAWXFEgRs1EnNvxkiFxVDdJUqE8A3lgmLVVWephMKu6Sqx8Ou8huGiYqhFTVrDAMYDqKEokuJNAUbwM5P8fR0QEDL6rAPkXpSuEakIt1yR9QE6o2YK3dZIdnKt58uoHp17E4pcR2XlFofk1K5VSmAo1YSAVL6dplI9Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1WyTv0vp4UZ22UKY0LFCu3N2m2jNLLIInwMWjCShJ00=; b=tRaCNERl6PJGFoz+AvDT2BG/FqlEYMlAQWGWGpw/pAnVmylMYZNNoPOjznpW59+ZfO8AYhoVGkokYhBZ54nz3InWS28mp/jNuyie3rLUxQiIGCRRVhbRzsbzmde+NriGo9Rj2wJKK/5bChwlE4jaVTM/h+XMmxw/qVxtAOveKb4= Received: from DS0PR17CA0008.namprd17.prod.outlook.com (2603:10b6:8:191::15) by PH7PR12MB5877.namprd12.prod.outlook.com (2603:10b6:510:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Wed, 19 Feb 2025 10:16:36 +0000 Received: from DS1PEPF00017099.namprd05.prod.outlook.com (2603:10b6:8:191:cafe::6f) by DS0PR17CA0008.outlook.office365.com (2603:10b6:8:191::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.20 via Frontend Transport; Wed, 19 Feb 2025 10:16:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017099.mail.protection.outlook.com (10.167.18.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8466.11 via Frontend Transport; Wed, 19 Feb 2025 10:16:36 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Feb 2025 04:16:30 -0600 From: Shivank Garg To: , , CC: , , , , , , , , , , , , , , , , Subject: [RFC PATCH v5 3/4] KVM: guest_memfd: Pass file pointer instead of inode pointer Date: Wed, 19 Feb 2025 10:15:58 +0000 Message-ID: <20250219101559.414878-4-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219101559.414878-1-shivankg@amd.com> References: <20250219101559.414878-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017099:EE_|PH7PR12MB5877:EE_ X-MS-Office365-Filtering-Correlation-Id: e8d5f815-cbe4-45f7-9b35-08dd50ce7e08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: ls0u47DTMM5IsiIQhpqIAzQDRdsu5ndFmQNJnkyhjHXUDJrzASRi5WLkf/4pSA7n5RAh4x6hiUxRL0J4PhB1rmCnocv8v3RfVQOf+sBHLClGS8bJErQvgz9M4wz9OsOmuoHpodjY897XcuqBMLuBMXaCV92W3SHAo/SMb2bjIndq5hmRmmjRDGAziFzwtPzhXtZEz2259Ykg825orpK++i1bhuGNtzOa5xy90bBEF3pjBAdmRKhJRmAc7vMsFvxX6cS6e34VwrHP49NcqB9lURmj4b0zGaJ5tHbdDcwZqNQPouWuzqAnw6uMRyhJZtecZZg8A5FRgm1r8T8F13d/l2DxxYTt+mdNyRPa8YtKmG61Xw9K2TWXstIDsUF9kxpj3nOiPpLm/2oM31pE/UlU2qaPPGIxP9OqplM7EXPbyVxASV4gvrVRBPkFMmeCDC6//Bax04lcXUXR2dAQzUIPjqU8zO7kuBZtjFBddxqMr4BfK+LHZZwVbNRK5Iw1lHHvaBALLt1g0z6p5/19hh4dnLRT3b+XwOhNKcYTUs+pl6u5OP2Lqjmy8gxp3ktUe5c/Z2HrrRBZ1/P6/VqTOdlncgx/Nl9sxScxKS+ZuHwpaXJrKbLgIrFvDubvRbnVkXDB1QN7HxpEc3OaR4obnyQCdJp8L3xxa07vynS1UyU0XPLz0ZjW3ZFxzPA2MLxXNU0Rs4rFH6vZmpLDB9tpPUSfPzN7iJcYxVYDdThVGZpilYDLGQt8FreT1yKu4fKAz1LCu1jmExyd8hQjje5UYkZjqGIvXQIR7GnMCBaMzGyXbFMJYnUC+JiY+zB/yct0Bn+gvc95RM7UCl46kS9VJYRv+/gCwymXstZinD+g6rNRpUwO9z4EjFleoFVtiXt0jxx9ekDr+W3ORzYG5RQ7SUdQrtTka/XEG1gnUiVdfzlW6zhMEvpSIClr9tILe/d5juQ+Aa6CzHmxQmqHyM156lvMg22i1zVxNW/kyQMy7zkmYgYrrcoQB+miNRXGcQ5fZb6ZsuU6WgskU6j49Oq/Hzgz99m7HiwQ2vx1BIKw8uuhZ/OCDxu/rItczewpJkvHZ6qZqmhCIsRvbxzlarJ5oBgNY7HnIdl0fzHZbACEo+Hi1dEALXv9GGtwUsuAz49gD03vgNqZDX3bkdkpIkVQZLdDfebPQjoTnFT7KCcPvGEFRZ+u/189U1ucDOIoIWV4pyvLOxRjttl7VLyl5UUlezeUOZz4m4MizIvO8HMskdhtrfmqiVnU/S2dnlqGMNRM1MdVVWWsS9JgiKkJ4RzUaR+PVl7aA0luVXt5aBxvry0bvH9Y3dNACmvuFKR84K5e5IHQfXMFx93j1eXKIS7YOndxEoqYj4iTQc3i5I88YOifHklcql4Dvz3rIiz1D6FvxuRqi2EW4bzwmcqmNATdhu6SHEmlLHysEx6/zDLebEX32ii2y8fhAgjyCbTx5dXHiEnfK061Y4MOqRkLVFSIMKIN175n8oaJh5PjjSBcHl331Mo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2025 10:16:36.3519 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8d5f815-cbe4-45f7-9b35-08dd50ce7e08 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017099.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5877 X-Rspamd-Queue-Id: 2A084100009 X-Stat-Signature: df9erby6foxxgeb91s1ctcguab8k911a X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739960199-210055 X-HE-Meta: U2FsdGVkX19KymApuUxq4ogY3YtW4fTImGcp3pHAykKW+sSY/8ZsT39bYNNLGpWpGXyb8G2XV1yRphjyeJxVP+d9ibSF0QW5R3MNr8f+Iy5isNO7fot0rhZHc2Y04cIelaVYFesO9so6dD0W4rPT3xEk8S/Xn1JEV0HTkm1d2HZ3Cx3xkrtNOESiuHF4dQUqH8LEpIfaRbfDpEJEzibE/91Qv5gVZOmOnbKwY77M17pyhPZKZqPJVdM3kTrMm+wWv67EsXmB4L8lPkQYx3f95EK82+YlxjU/M4ErV0f6+pAyVKjRt7MdVMEeNj93ZDQSMO/xnYOzZPbz6GPnYTNX8pvNlppjKya0XJvbPaPOygBETKyebUMNKA7n6fthyREvsVT52G/lnRBJt4ow3pDjaCpWXi59lHZKDUd9JI+3+YwIEp9TGfpqKcsScXVaEZSItTqeFrMFPwdjJqcoy2nmLV0mmOwUaIwcrwXkHIrTR58g9DcQI+Gf0S53LFYlYMmQQe3ZeQRa9VgincfeNzTjxg/ZT29cLbKIMT4+DH2y/Wh8YDXc/Lu3RqgMscGjUJ3LSS3DELc3MXVbAZZv8DvVk5cPsSS2zJqz31rS++pK1SKDTtUMBRx1FEvuQODqvu5YUP4pG5Q90cZX8p1TjTjtVF2CN9S67j2JxWH1DGGmA5FChnn8F7t/VkI0TWwXLNqqhznq0VHVT+dT3ZKSQK5UjdMNAf+/q6CZ3tPpySn8uGp2ts4aslA3WB/UiEevYj8z0d2DZou7A7TklqwjmgYJSRj7qu1vVi9YIA38TYsgXqmdAOje7gzyY3iBPI4jfwGIU0AQbj/ZRq82TSZOP+R96Z8PhzwMD0ysa9FaZ6oOqJses6T+uQlE8WAgLEsBjeySA58mQPQvbzMNjgEe5wGwmlmyFbntu9dE5uRrJ/VKTgNOGa6kf6NXltTeopTCjyTi8v+lLTBA7AoR9Cb8B0v fzSlk4u6 mWCHEPYGBANV0ON+gEY0gI1OPTf3rPJJG/LwbQKy/DRDASZEtCTC6Ywb7J15cVQuAwfhF95sTLJ2o5TutKXBbx0/A8TsnBpJ2Jyyyx3w2YumZuuoJ/blnwNVN/8OBxK91KpAHqEOI08eFM0UUvL7PVeASyh60ppVUU/2nTY+kUMT5ZJN17Z+jbzUUGg+GF16lL6seo/RJn0bFkd+V83Em6YjrE0t4U4nHwIWXmu/XU80W1uNjiIhN5Vo6G1TgXVHPWdnANC8An8r8fd+vhF/AdQ70UTZIDGTbb7V/O3jdbPudrAzg+aJKmu8gwQLHqlXEOizP46VhFnpD2FYVx2Jm4hXLM2acu4BKbL5m6edfVuMCGL3BJ2bbYAzXOKm1J8Rj6+jfdWPZoFFDplnXO8pJomcts44cIlc2m8e+BuzdOyeF3w/4Ra1GteKUmJKtANOfxKLPKwYPF8I/bAgXa0lC7exmMTFy8jc+LINIhSnHb6q2Mqytv7G/VTBa3ihV0rvMsYT1WAKVUjnR5KYE/foDZ3zSK8OVa4Hs1e9FBeAKss2QJlc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Pass file pointer instead of inode pointer to access struct kvm_gmem stored in file->private_data. This change is needed to access NUMA policy when allocating memory for guest_memfd, which will be added in a following patch. The following functions are modified to use file pointers: - kvm_gmem_get_folio() - kvm_gmem_allocate() Preparatory patch and no functional changes. Signed-off-by: Shivank Garg --- virt/kvm/guest_memfd.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index b2aa6bf24d3a..f18176976ae3 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -96,10 +96,10 @@ static int kvm_gmem_prepare_folio(struct kvm *kvm, struct kvm_memory_slot *slot, * Ignore accessed, referenced, and dirty flags. The memory is * unevictable and there is no storage to write back to. */ -static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t index) +static struct folio *kvm_gmem_get_folio(struct file *file, pgoff_t index) { /* TODO: Support huge pages. */ - return filemap_grab_folio(inode->i_mapping, index); + return filemap_grab_folio(file_inode(file)->i_mapping, index); } static void kvm_gmem_invalidate_begin(struct kvm_gmem *gmem, pgoff_t start, @@ -177,8 +177,9 @@ static long kvm_gmem_punch_hole(struct inode *inode, loff_t offset, loff_t len) return 0; } -static long kvm_gmem_allocate(struct inode *inode, loff_t offset, loff_t len) +static long kvm_gmem_allocate(struct file *file, loff_t offset, loff_t len) { + struct inode *inode = file_inode(file); struct address_space *mapping = inode->i_mapping; pgoff_t start, index, end; int r; @@ -201,7 +202,7 @@ static long kvm_gmem_allocate(struct inode *inode, loff_t offset, loff_t len) break; } - folio = kvm_gmem_get_folio(inode, index); + folio = kvm_gmem_get_folio(file, index); if (IS_ERR(folio)) { r = PTR_ERR(folio); break; @@ -241,7 +242,7 @@ static long kvm_gmem_fallocate(struct file *file, int mode, loff_t offset, if (mode & FALLOC_FL_PUNCH_HOLE) ret = kvm_gmem_punch_hole(file_inode(file), offset, len); else - ret = kvm_gmem_allocate(file_inode(file), offset, len); + ret = kvm_gmem_allocate(file, offset, len); if (!ret) file_modified(file); @@ -585,7 +586,7 @@ static struct folio *__kvm_gmem_get_pfn(struct file *file, return ERR_PTR(-EIO); } - folio = kvm_gmem_get_folio(file_inode(file), index); + folio = kvm_gmem_get_folio(file, index); if (IS_ERR(folio)) return folio; From patchwork Wed Feb 19 10:15:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 13981897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6A2C021B0 for ; Wed, 19 Feb 2025 10:16:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149B0280224; Wed, 19 Feb 2025 05:16:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB1C280220; Wed, 19 Feb 2025 05:16:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8F82280224; Wed, 19 Feb 2025 05:16:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C86CE280220 for ; Wed, 19 Feb 2025 05:16:51 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8E1BA14160A for ; Wed, 19 Feb 2025 10:16:51 +0000 (UTC) X-FDA: 83136290622.01.D3D3466 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48]) by imf03.hostedemail.com (Postfix) with ESMTP id 8133E20004 for ; Wed, 19 Feb 2025 10:16:48 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=bQ+iQtCi; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf03.hostedemail.com: domain of shivankg@amd.com designates 40.107.94.48 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739960208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZradmVSI1c/lwUMCGwWhjOQwoPNyHTXQz6PDS/1+2YM=; b=sFB12AS1dm3adtPlqgaYIQj6u9tZgWuhhlS53uvzhSLT/Awe54E2V8d+WzqxtUwlY+qVPu 1JLeAKKrgNNgZa4xPoyucy3HA7KS/iUo1D8VF9Y168V8nup5R0Y9yrqAYAr8PG+exbm+Qa bIonBEGuPAdI7yrfQPPe0Oa93/QX2x8= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=bQ+iQtCi; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf03.hostedemail.com: domain of shivankg@amd.com designates 40.107.94.48 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739960208; a=rsa-sha256; cv=pass; b=QXTBg6cHajplp5h9lX4S95uK7Q8HP+Ft5NfJcsDpTD0jQssFbSWw10MeSeCkbJll2rcdVr qkcSo5yRGBdJkFyMooF6UW7FwDzhMjkR33o6jk2sBBa+vRUl0fOSYnc4yiyCeH/lbZnH9w UrhxLbhuZprdFz8B1/q+Qux695i0T5s= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OD/yPLGAf78CV7Vz+QblO4DHdxtGMV6l9cXaRk59ENXIvpcvKUf2kCV4fJ7P0/Dmvmj1CdSWDO3UPS+qMV4fS881dcOVvrV9j5mpOM43x74MYLbz7eCA3ok7Spn5GI16Kr46U6qyKmFW+tcwkt21UQJXuc9KGu5pYasasAWD6Lkxlq0YFFJ68N1oG0+NzLCfHVjTF904e6vga6b5D8VPavvC+GPRVmMpxpf2coGaoBvloySdUIaFJ15df6XXFma7WwHHDjmvzYxfRWBzzoaoGCJ8jPcFqQr0T1qZMXfHHsuh95xdlUVaViEoPyU7rBDq84Hj+ZBuqYsiP3AFGrj9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZradmVSI1c/lwUMCGwWhjOQwoPNyHTXQz6PDS/1+2YM=; b=izyhdWPM4VXFOceTMQ7nU4PsebwhGf/65B7wVzwLzndMjGGgVDX7uODm2a/Eur26gEyYEWZJZKgxMbolTs0OXRvB7GxVnnO2TWdpbvBVXreLLlIy4LQ7OHMPUvGw+4Zg9DU7JLWYKMoGOzef4Bi7YEM+a4iUOeonVRsfLaCMB3OJCtXe5uYhracB/LcKxhNM3C6917ke+0pFmXH4ukRwkFfSSW/8zsi6wTTudxnAHKIIEj40jhNV1dOlcmLBD3jwff9nE79xhmaegv/EvzjwVL6PWElm1TIoP5n7lsvBd2lPf8GpKUN1Pm4qEwLCwg57pF6DwbtAjuxGEJ9YVhLjGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZradmVSI1c/lwUMCGwWhjOQwoPNyHTXQz6PDS/1+2YM=; b=bQ+iQtCiAcD/niKBwByKDlMG6wQF+mMARuA2QOF+ou65Qt4DYmDUw5gZV82+Bt5TWavELNKjV/Iqaz5/2qkNH+HXxHV/w/gARFWK9jIeQSqpZN2a/0RhdZ2rYDI3guZ7SeZWbwBUdmytcTokp3rZGBXW/yY/8gc9RZcwtUCUD8Q= Received: from DS7PR03CA0335.namprd03.prod.outlook.com (2603:10b6:8:55::34) by IA1PR12MB7591.namprd12.prod.outlook.com (2603:10b6:208:429::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Wed, 19 Feb 2025 10:16:42 +0000 Received: from DS1PEPF00017097.namprd05.prod.outlook.com (2603:10b6:8:55:cafe::55) by DS7PR03CA0335.outlook.office365.com (2603:10b6:8:55::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.14 via Frontend Transport; Wed, 19 Feb 2025 10:16:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017097.mail.protection.outlook.com (10.167.18.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8466.11 via Frontend Transport; Wed, 19 Feb 2025 10:16:41 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Feb 2025 04:16:36 -0600 From: Shivank Garg To: , , CC: , , , , , , , , , , , , , , , , Subject: [RFC PATCH v5 4/4] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy Date: Wed, 19 Feb 2025 10:15:59 +0000 Message-ID: <20250219101559.414878-5-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219101559.414878-1-shivankg@amd.com> References: <20250219101559.414878-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017097:EE_|IA1PR12MB7591:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b332aca-a3ae-4fad-f87e-08dd50ce8160 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|82310400026|376014|1800799024; X-Microsoft-Antispam-Message-Info: u9bxdLOcqOqJA9Y5VtAJNtbQuH8lsZEJWscBxLK7GWdTi3Zu1nsEIMKIYV0EfveLsYdNWbICj1AQNKE61XroPyGlydlHPCjMI7cyjZ0HNzpjBWTSfR8wv8zwBW6LQvPZWgB6UmIUJfxUCL86wDoaiWmpTomK3AnjJMd24cUdmTiDKfD8p+ptwZQ/gc2yfnLGwDzhezDbBMklh2bwnxh8JoFtCQTbI8p6K92oNFX19U+8KXm7GmjIW3DXEqGjaWo7T60FDrMu3rKObp0Sy00EfbxcPkCcRru98ThPsnzKai1W6TpyuznU+FlIuSCf/mW/eWGgeuzTWVRGIvHKefp+SOAwiDtiHjmbj8qFIPiM3ODyyP1X/hr9m6DZ4KDLq7VffI5qCYNsSRBXWch/4UjSRlpzcUK482TnzUDK/tR4HXieXhe19bnhNEKnhgOMAk42rC4QRMqdmPVpIyHDhqxfG4sO081bDg0t3pCe73FAebVaqLb3aWSNiHzNs8ozpD0iZgHLqj55K1XxwYjgWJ+TykRLbkQOxdv5Qs2M1tXxbJQz5a73VM+PHYJRCDRHoxP8E/sqZ5BEMMPUFUfuIntvO0u5OkJG9BOjrSyM4t+c/nbASn/dBlt4LcYipd2HxX2mMVFuS/sgBqGSgQjcJYCNeD6byOBBOc5PgtUKrekwrnOL7COMyFrcEcg78mFXDctQfe+5JI0BgQidisC+K/L7A764cfrdKiDY3s/ehwlMA06VtPwHlb73+QnJYybnQ9Xbpscx/bdC84GNkGBwCdxBpIH8k3FRGQZ+JgLtkg8ex0eoKJ+yzvkmuGGT6y2YndyRqnwyjayIM0aNViMu7LACSVKpnrhS1juwUPN3lCCA9WG9cdMvSbV4nh28/AlIsefmBKs7kD4+4IlLvBDFfxw02I2bgibU2L1ubSbmUekl5qW1+ruBfYxS7GFW8LSja2nmokMzbgdnS6RIaZ6D33I+qzJGOhlfa8LE1+fihCePvFjbLtSWj8M5TR1pwIdOOEA6Kz4q5b3/ZsWeWrFfIJLnRfwgvAG/cev36/aj50LTPszR+aabA0w/3MivRMH7I7st9Bc34yuPFSQWlx9JuKt13T2cQx2pH/irEHuu35HM8EvKtq4KoGcNTCwkb8myi+Nnjx0jNVAtCAtBPdMq+XzZ+roGrVGf0s6pxiLVrAHSSfpKAfKy9C8lNbWBr7zgihStUn1XW+/FewHQTFcvQwVTZR+j5D10FrTe1+bllBxxL4wUZKo1tMjl4ZtjkiUhLANGcIQ53+2YyGFuO+vcpECgTNJz09+bGl9Eds5iqpqWqAJBRVTbLttWCn5nAf6BtJ79WZt3/T0vO0q6GMUYgDvzmYzEhi+GbT5yERjVrNjfy/WYScwJ/eCBKPfvPJAF/ld4icX0ur9uFkJxrIfRRges4ds/YjyaJpxPbOkeUOGZ1djwia7LzeVopgdARjIGhSZ3WBz2TK9B9QZFia/adhRLWsosmyYkyAsyVFzH5pJnPfE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(82310400026)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2025 10:16:41.9641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b332aca-a3ae-4fad-f87e-08dd50ce8160 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017097.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7591 X-Rspam-User: X-Stat-Signature: ekc5iujzpy41u787jabkmqwncaac4feo X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8133E20004 X-HE-Tag: 1739960208-328413 X-HE-Meta: U2FsdGVkX1+Ch5jjm7PH3wbEBNexUSYEzh0m49c0RX3OtAaGsNkhrRbCmiW6HxyTZoLf3KFUWg6PoSfjzhUar7qI4tGb66lewDprDCKQ/DNUyvMZH0phrlfx7CpkqYO6HApMn/JeEO/yXYfHH4H8fsJrhIWEjge2sGn0sUTDfhnLwYBlahSQ2aLVdra9mertbHt+VryRl93VQiciAgSpXZIQGsPFub8H3Itu6dNPXSsUsltaPZSHowz4dxn1qCn1fhoCa0bMVMQlfs18boZgZsp4UIVCSf1ABK15up2g67fIUQG11EEP2GLZLNai9rmfWa7YzcJS1JAA8VJ2T6iVg2se13mxDWYlKcD7wWwUGZ6RVA31uLCiBknxWUPGOgcvj/QbJyqVVjGA0Xh+VX/i0laHsz9B43m1TxWoc5956cHto2oTtM4W6xGEDoVdNYmrOBDOx0c8k/Ffu/1xuLdHl3meVaVqliyalxTVjFHfvD9PfVj4JmbpMweziQ8AxGVGyPmyUmu5A3on34g1IbRFMS6yjcqYkgL4fTBYE6LoK0/aSxZwfbZBoAKomdiOn3okaYwgjPO9LQnWVjYp9WmaxkGDo5zvjbhS4ONPtvzqlawOR+zWJmRerQEaxhbS4hRDsEvMRJDyFjU1uvozvBOfKTQTT4cM0/xlMh654DBiTUgVHKJQ0AQOuqgMe5piORWF3yxf3uwgCARj5gXbeIgScJ6Y1k84j3FGSQcfaVB5GZUuXsQzBR3xeQBslx60ttTaKPN3L+YiFVAPtGnMeDPf7pjtnZUQe+wN6PJ8VI0+x5bdnJsAOmKvoZvZ9P53JjdyEsc4x/BdAQpObegpfZCpYneav30a11yyxBan97983fRgUzSHtjw10E/rluUGxrDXz0v0xFTyJMl1QQ6Dl+zBncR+wTRwOE3r7+bO/j/Nq9AVv4n6JLAEk0uuRzZWVQUbZ+fGCheWgspSN9wC7SW RMjClH/n xjDXbDz1xCdafIAdrPC30hIBZkGSoK843YKcBZ1blzgyxfjWNbT5feGP0YJuubFKlduPiO+gK1ycMymotnVpm2XTrsC13zHXz38AfvTa8NCnVF2T3fBWELNoG9cIdazZ/XLAxcbI+WKphaDRPTrfiu9UC6MTjWZyQLv9nGsI9vz7tHEHfZfFgBAuIvyptDm7QKjae6NJp2HpC3mdb7n0+BF2HLImF4UH8ZbH/ZR/5YX3VjGtO+QQ2RRNbmUlU/Ek8u5RolmM7kZZvV318uhGxlrkNBK+cEaGnpeR6vM5CtSFeSqV/wZcpF/HgWnVvVoXv21TfyuCDprgH9nr9KF/JMblHnRzFo4AkAQW4GiSpumIEGt2GA/8t3wtL0BqWH1i8rzJtkRguC6h8WW5DFkVUnFjoeLFA22dp22wq4N9TnxjYFVi0qi8KDyDXE+11Gk+PcGUeTk40g43a9mBf/vdD+922x++pti5R9Z53W/YBsuQbywwZIffepR2qfY32Jh0mEXt10cDYsMN2u0gDxxf7X5efG318Xia5vojc9ZgEA+bLoiTXxGZ9a9TmiQ1r0klWKcqr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Previously, guest-memfd allocations were following local NUMA node id in absence of process mempolicy, resulting in random memory allocation. Moreover, mbind() couldn't be used since memory wasn't mapped to userspace in VMM. Enable NUMA policy support by implementing vm_ops for guest-memfd mmap operation. This allows VMM to map the memory and use mbind() to set the desired NUMA policy. The policy is then retrieved via mpol_shared_policy_lookup() and passed to filemap_grab_folio_mpol() to ensure that allocations follow the specified memory policy. This enables VMM to control guest memory NUMA placement by calling mbind() on the mapped memory regions, providing fine-grained control over guest memory allocation across NUMA nodes. Suggested-by: David Hildenbrand Signed-off-by: Shivank Garg --- virt/kvm/guest_memfd.c | 76 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index f18176976ae3..8d1dfce5d3dc 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include @@ -11,8 +12,12 @@ struct kvm_gmem { struct kvm *kvm; struct xarray bindings; struct list_head entry; + struct shared_policy policy; }; +static struct mempolicy *kvm_gmem_get_pgoff_policy(struct kvm_gmem *gmem, + pgoff_t index); + /** * folio_file_pfn - like folio_file_page, but return a pfn. * @folio: The folio which contains this index. @@ -99,7 +104,25 @@ static int kvm_gmem_prepare_folio(struct kvm *kvm, struct kvm_memory_slot *slot, static struct folio *kvm_gmem_get_folio(struct file *file, pgoff_t index) { /* TODO: Support huge pages. */ - return filemap_grab_folio(file_inode(file)->i_mapping, index); + struct kvm_gmem *gmem = file->private_data; + struct inode *inode = file_inode(file); + struct mempolicy *policy; + struct folio *folio; + + /* + * Fast-path: See if folio is already present in mapping to avoid + * policy_lookup. + */ + folio = __filemap_get_folio(inode->i_mapping, index, + FGP_LOCK | FGP_ACCESSED, 0); + if (!IS_ERR(folio)) + return folio; + + policy = kvm_gmem_get_pgoff_policy(gmem, index); + folio = filemap_grab_folio_mpol(inode->i_mapping, index, policy); + mpol_cond_put(policy); + + return folio; } static void kvm_gmem_invalidate_begin(struct kvm_gmem *gmem, pgoff_t start, @@ -291,6 +314,7 @@ static int kvm_gmem_release(struct inode *inode, struct file *file) mutex_unlock(&kvm->slots_lock); xa_destroy(&gmem->bindings); + mpol_free_shared_policy(&gmem->policy); kfree(gmem); kvm_put_kvm(kvm); @@ -312,8 +336,57 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) { return gfn - slot->base_gfn + slot->gmem.pgoff; } +#ifdef CONFIG_NUMA +static int kvm_gmem_set_policy(struct vm_area_struct *vma, struct mempolicy *new) +{ + struct file *file = vma->vm_file; + struct kvm_gmem *gmem = file->private_data; + + return mpol_set_shared_policy(&gmem->policy, vma, new); +} + +static struct mempolicy *kvm_gmem_get_policy(struct vm_area_struct *vma, + unsigned long addr, pgoff_t *pgoff) +{ + struct file *file = vma->vm_file; + struct kvm_gmem *gmem = file->private_data; + + *pgoff = vma->vm_pgoff + ((addr - vma->vm_start) >> PAGE_SHIFT); + return mpol_shared_policy_lookup(&gmem->policy, *pgoff); +} + +static struct mempolicy *kvm_gmem_get_pgoff_policy(struct kvm_gmem *gmem, + pgoff_t index) +{ + struct mempolicy *mpol; + + mpol = mpol_shared_policy_lookup(&gmem->policy, index); + return mpol ? mpol : get_task_policy(current); +} +#else +static struct mempolicy *kvm_gmem_get_pgoff_policy(struct kvm_gmem *gmem, + pgoff_t index) +{ + return NULL; +} +#endif /* CONFIG_NUMA */ + +static const struct vm_operations_struct kvm_gmem_vm_ops = { +#ifdef CONFIG_NUMA + .get_policy = kvm_gmem_get_policy, + .set_policy = kvm_gmem_set_policy, +#endif +}; + +static int kvm_gmem_mmap(struct file *file, struct vm_area_struct *vma) +{ + file_accessed(file); + vma->vm_ops = &kvm_gmem_vm_ops; + return 0; +} static struct file_operations kvm_gmem_fops = { + .mmap = kvm_gmem_mmap, .open = generic_file_open, .release = kvm_gmem_release, .fallocate = kvm_gmem_fallocate, @@ -446,6 +519,7 @@ static int __kvm_gmem_create(struct kvm *kvm, loff_t size, u64 flags) kvm_get_kvm(kvm); gmem->kvm = kvm; xa_init(&gmem->bindings); + mpol_shared_policy_init(&gmem->policy, NULL); list_add(&gmem->entry, &inode->i_mapping->i_private_list); fd_install(fd, file);