From patchwork Thu Feb 20 15:03:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80449C021B2 for ; Thu, 20 Feb 2025 15:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149A62802F0; Thu, 20 Feb 2025 10:09:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FA6D2802ED; Thu, 20 Feb 2025 10:09:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDC502802F0; Thu, 20 Feb 2025 10:09:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D00D42802ED for ; Thu, 20 Feb 2025 10:09:28 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 47E1E1CC431 for ; Thu, 20 Feb 2025 15:09:28 +0000 (UTC) X-FDA: 83140656816.08.1CB6B3B Received: from mail-lf1-f74.google.com (mail-lf1-f74.google.com [209.85.167.74]) by imf27.hostedemail.com (Postfix) with ESMTP id 3AE5540017 for ; Thu, 20 Feb 2025 15:09:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H3BRI9uf; spf=pass (imf27.hostedemail.com: domain of 3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com designates 209.85.167.74 as permitted sender) smtp.mailfrom=3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740064166; a=rsa-sha256; cv=none; b=52nLgmAn1NG143FT79Xzd/k+CmurnxERnixLwopRezr46hxjyuOHEUH84IzWXrYUh7b2Ai X+nWvgn+NMXlnU0IJYfq39duVithPW/9so02+FdaMfIpCkRKxEiJz6CN+lm0lYHl6+4HEF QjnYzIrhD0qdwJKu9ZtOn0pec9NXvhs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H3BRI9uf; spf=pass (imf27.hostedemail.com: domain of 3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com designates 209.85.167.74 as permitted sender) smtp.mailfrom=3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740064166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=aROtFKothclMkprPFjFsyQKn4s7EECLt+q0ulcYRm8X847nogfvFj8nGw00magseQVQloN eXGjwk7mxFhTT/Iqkxf3+MstgvsQp6Jc3HkLM4DGdhu7WtGLicWHeSq0SRKreluhMho13+ TXbOZp+9ytKc3FO7iwCwtS6eUBSXhgc= Received: by mail-lf1-f74.google.com with SMTP id 2adb3069b0e04-5461901d470so1112450e87.1 for ; Thu, 20 Feb 2025 07:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740064164; x=1740668964; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=H3BRI9ufo+GTkf2ORZLB92JWSkvJqqH4ccLGFI8GtbJqT+x2f0IeCT8+H4C/xCWfOV T3nEX4s0nrIGiI5qEUCBj8Odl6gxgCnGPzhD1UYvexw9D5o3/F0CCSgxuekuLWm9w5D2 cUewar6Xp9EHHv4FGsIU16a6/XktE6ECNE7TyW8RgySiHQk+CwNBzSBLUjQRStL3hVP3 8z5mcQaykPCJAwDt83wOGKKXQ4ocewoggk61bFLKIfnclFZS5vDo0cPUKBBIO0jieac+ Jz/1IJf4VvO73AzZqEiE5A+XtSimpTVVjVWDPhwh7ETf+PUooNNhf4/Hc0rumEYN0QTR /tJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740064164; x=1740668964; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=N4V3u1klESiQPBKVKBuItIx87quFJ9BfiQvnTJVL4D4O+e2DE0bJmjjpY7nGizub5O Eweauk2d5N0n5/R1NNHEfNDgHSyJWsnTNGTFxKEzA2+24zkXwundBFC2vi0ZNStVBCJa nuBktuVcMVTjzfwouvSFLm1EQ5NU0T43KdmVomodqxRX9uV3KYKBxL1mNhK88CJgRDY5 EJOP3ItvBcdsYyeHIwSTyhvPTZtxGbBBk7tcM5XuikvkVyeaXFwGrN9oyAyzafJvuz2Z FBr2B3utR0bRbrIx1dF1frp9xlluX1uR+PloNlf+0zkkSmw+/YU4b5poa3/tRIgy0BNU db2Q== X-Forwarded-Encrypted: i=1; AJvYcCWBcuMQa1nOrOHyGvGXqCE480MrD5fUO/isDTXXf9tRtR1WkXNcfRZEitehF5J6p4Z6gjPL3VQybA==@kvack.org X-Gm-Message-State: AOJu0YxNIsB9l7iK83wW2Cb4DI7PeU0AIfjRskyNl14t6xrHNLVCpYUK SxTXLvvGeWDPVwk5lsJrz0+OmZO7f5gpFYtOPUB/AwpaCcUNGcSaKgWijjXtMr35p8W7sRHP9NB dbiTXoY+QVg== X-Google-Smtp-Source: AGHT+IFOliTpraR15CWTkacKeBSUqf8FbRBDdkQpsEi0GIcWjSpwR0EViFfPxP8qN/+qIjSryFofPr/PtV4xXg== X-Received: from wmbhc12.prod.google.com ([2002:a05:600c:870c:b0:439:98ca:e39d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b26:b0:439:31e0:d9a5 with SMTP id 5b1f17b1804b1-43999dd1e1cmr69699445e9.22.1740063820541; Thu, 20 Feb 2025 07:03:40 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:13 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-1-9bbf57d64463@google.com> Subject: [PATCH 1/6] selftests/mm: Report errno when things fail From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 3AE5540017 X-Stat-Signature: uj9yordz6kyrueujdxyrakighsky56nc X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740064165-923922 X-HE-Meta: U2FsdGVkX19f/AMseJrOmPsp+2sAbjC1ZsKjoNLoxtXaAzDGJQ8sjsp0Izbo9BjcDw0lZm+SNkr0SizraQf67noiFegDzwzkXCGQZpub9oQNNH6zZYqV8maH34J2jUKs9BIfeKWj41mLiuYqwFF/XlKqzpGEOCFajVdE2Zg2jfsz0qi60587cTnXglg+9ywZRaWjotURLlTVIFItQqRcOsuf7YFJG4YiDgNo07RwN6OgAF946fVGxhqrj5iSqA9xkj7U7czfGrHwunppEJY1XwJfi0+XxM5+yvhkWQ1xoBIXi8+mSSzrKKppcikLe8GFB5sBJC7RB2bVBmgrM+NIfVICxrbKUjZGNRon2U3PUuMlmXkafSltKXKYEiL2mFaY9Wav4pkJOL3lwt/qIyJxERRIFKOEjj/6iazO7uoCgD7+sAsiHUEONs0xNMtxH8YCvAIR16qaSMxX40146zLV2sIz0ojTR5iWOCV1ckJYJHkqYadopoWOP2pKczVwj+YOdSFpglAYhoOqWLwwJHWIs07Yd69qaxF2sq9RegH4eksgFnQF+tqBjeDUOLgbkcAguWw25PZANCN39Fz0I//WVxq71UmtbkA/sa5TMf3ulP97dFJtP5RVdYaDfN46GTIycwK4Lb3UX1o2Wwp+VDrxflrDPOiwiNyem6lDqRQKrNgTvn+w4CwyaN+cSq6eACNvnXUhAjXoL8Y/eG2Pv2tY2IMdR55wOP7wOpu6KAHOgah3Y1kMVaNPNBODXJ70Ko1qwsHu1YWWwmEYd7MfLKvaXaSuXHtVeI6by7uADnUhjBXrqAc2IhPBArTPTx0LxVwleYMfLiYkK7u267aRhB1zL91Nwbeept0/BiRY6/GAERUxzLz3CZh+iMvD6JbyD6L+KGlMP4QfJ/CkAqv1kLiAVkJPYNgW3HAsq7iGkYp3PH8fH94lnAyqFkVrRNdIp24zjMZNf6eTNYsPEDrGJmz S3Q2Ulmz bYDQM2z2+fJcOsGPud3iVYpd82hNeh6hUhIKFY+520Ok1x0MoylujjWJayB3L1K5xNV0Cb22u3JCUWlJxApdPDbdWLoP5ZPufHWOa4P/Spr0X8WWmPSwNWnls/3AFREIsV+/VFyFrQ+2NiyxpKFcLW/8ySHDP5znC5dc7ZBgujHCNsiAWGlxUYrgKKu3eISAA1BMj2iIR6hhRMnPtPZZa2z1Ln0Wc7H84rfx/U6fN1Dxqvm9V/eeD12Ha91ZBiGE2Ihvv88IGI5l8mwK2kXqMYV9T7BaBvEFjTuJqL8JB5ST7bPOhPyAGHP6UBNbZgCDDE64VEqR4P2eyYQpOoEyNzlmJdtA0+PrWYiegFwFdjO0PrOEBjLIedlcOKu3Zh6+ceRiXx6wiNA31lWz/Qr6Jb9m2UMwRF3zoKjGcx85qauFdLNtgIXoFfkmuv4zzAHKosTxvk14d4e8bIk43SZ8bGxiB+BdDoQppaGdB3OZEP5wCAV+3K3p3KttMKSyne0KRRHk8goTiXCbqgFcERnHlz6Qm6TxMI50suvNXC99ZjghzWUbaa9STPzV58g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001403, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 32 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..46a2139b3a646f6c050eb031a770f615be76c433 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%d)\n", errno); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%d)\n", errno); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,18 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%d)\n", errno); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%d)\n", errno); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +202,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%d)\n", errno); break; } /* @@ -215,13 +215,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%d)\n", errno); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%d)\n", errno); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +249,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%d)\n", errno); return; } @@ -266,13 +266,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%d)\n", errno); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%d)\n", errno); goto close; } @@ -290,12 +290,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%d)\n", errno); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%d)\n", errno); goto close; } @@ -317,7 +317,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%d)\n", errno); return; } From patchwork Thu Feb 20 15:03:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984116 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD2BC021B2 for ; Thu, 20 Feb 2025 15:03:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898E32802EB; Thu, 20 Feb 2025 10:03:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 848F82802E7; Thu, 20 Feb 2025 10:03:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA7B2802EB; Thu, 20 Feb 2025 10:03:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F0AE2802E7 for ; Thu, 20 Feb 2025 10:03:46 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0CC10B7DDD for ; Thu, 20 Feb 2025 15:03:46 +0000 (UTC) X-FDA: 83140642452.12.ECA8958 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf14.hostedemail.com (Postfix) with ESMTP id 29BA4100009 for ; Thu, 20 Feb 2025 15:03:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fym9CAOj; spf=pass (imf14.hostedemail.com: domain of 3TkS3ZwgKCPciZbjlZmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3TkS3ZwgKCPciZbjlZmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=OoPauNYmcOrNCJbHDISKqFTnUyYZeYm46U7dA9p0Nzdiqh8a70v/rv6krdZPjxJPMDWY3Q xALAsZ8aj6e7LV7nl3w+vKTxMPBf0fG1QHgXBzHOXpPs2ipLX72HwHKbwleqnufi25IstQ VCudROy99X+hzmA95jMFUr5yMm+iCNo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fym9CAOj; spf=pass (imf14.hostedemail.com: domain of 3TkS3ZwgKCPciZbjlZmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3TkS3ZwgKCPciZbjlZmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063824; a=rsa-sha256; cv=none; b=OpXtc3yfl0vR4OlbfbRzRWXCEv8btLZRbEOIlv5nEUsU5/IBaorMn2j8VpbhHnMDFW5LTB YZ32KySVNkoCSO183zrVeU/V4cbjG2vSFoqvzEAPKsqSzR8Gmfo32ld2ONEGtKxFc+nmCo M+PjdOz/IskWHMytbFzokh/XRHFxevY= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43988b9ecfbso5561075e9.0 for ; Thu, 20 Feb 2025 07:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063823; x=1740668623; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=fym9CAOjqpwkRWGL7cVOPNs5jH8FLIZjg7X4lKUywgcTvWKXWONfnJOybc+G54mzuO E1yT98yQJ2T8HQoDa/QVQdTIeAJMYYfc4p8/mPL2QcQgkJ6YA8tfoxuEVFmZpzeBaQp+ +vGQkIzJ+gL2RPY+F7Y5U+S+35XRu2kJWNZ6tjhoGeyADJ0OvvIPqWK+gNeK2g0vH9A/ yB1NZqI52dBDjgdWgc4G+RE7W2xkqnYqGJPVhMJDSd/sAVtrj64+tZuimdf7p0gqGKzu AR0MlHgUSGJcSNOO0aBl7Rvm5E77hM7yr6wrzGnpiHWGdt+0fcPGFbGhl0cZFXk3YkiZ foGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063823; x=1740668623; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=aZ5IeOkqYTfTGnhn9VIS1aolCNBFmatJMy51a5W5rPmh4WDqKSAyD6uCcR8lpta6g2 prdQiJyA9sL4qsQKW1GOEZgTN+9f0OcEyBvy83PiP9G7/MEO0GyEabi9YgJXX2wrdBwI b7YgTSMMrAFgZlWuGbE0DESRPxsd2ZAPsXjkxcX5S/UyXoofBTkDfCev6F//ZSdLWNcK bMpfdYRQYEdxDi7zRVvdJNAJ6EABF9Lx+wqYn6vKTESqw4pgGBbsDP7MXoKMoxJxehAr YjdY1Q7Dx/uSgXEN/fPQ5TdC7PaYjd1QAU8WqLEbIxwEBuHqrQX2/nwvlDP9kLfsEnyC z6OQ== X-Forwarded-Encrypted: i=1; AJvYcCU17NVs/sZg3epOTQUNbS6Jv65PbvaOcxECCPlfQOZMAI3jqqI5PM2xFy67Gmpm5pS0L2RE6DLGsA==@kvack.org X-Gm-Message-State: AOJu0YxKf7gXX/ALyTyxZ7SKsYddAHRIbG7JSV50mm9QeRkbF1709Tks yrkMClvJnfYVZDkrQR8O7iNRe01J9Xc1fnnoR3AppFOSTMcpV98HLMLZUUUn1B3eseYMbwGMdta fwhvIAQkbsQ== X-Google-Smtp-Source: AGHT+IGMX6sUMZFB6kcF1FLDPNy7JKgv9mVpVnHmQkgAM/qSvu5gFbpVA6vpmtah98EUgiAhA5SqxJEjJc185A== X-Received: from wmbg23.prod.google.com ([2002:a05:600c:a417:b0:439:95b9:9200]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:450b:b0:439:9225:2f50 with SMTP id 5b1f17b1804b1-43999db0139mr80231185e9.16.1740063822867; Thu, 20 Feb 2025 07:03:42 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:14 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-2-9bbf57d64463@google.com> Subject: [PATCH 2/6] selftests/mm: Fix assumption that sudo is present From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 29BA4100009 X-Stat-Signature: ca69adwipdh5c944zymyxndujdjrawqh X-HE-Tag: 1740063823-42585 X-HE-Meta: U2FsdGVkX19Xkx3PmsklF+0gMD85GusAvTTlZEF4d855mHB2IaKZH7Rp5gqbKZkd8FbDoC7bNvNYRzs0Ep6OABC3EtsDUhTOAnOq51d797cLi0XwlMiE+lmx1t7VzUQ6sGmfA3vKKIehQEv4CW68CfkNLP7vKiYu9ckqzcr7A0+dy1A0Q4z8arhHk/H6Hx0xaMgcqpDvAz54ML/MG4OU98EFidQA1lNmpEfoZwIO0OiOSaCciTrmOlLlgR+Q8X1lxDs+jbo3w3iYXTobXFW3dRDrhHAEBURXWhmIKxwfI2LA96DS07ELMp5McK9yGlvTXi5aTblzx14lwWN3V7Ydwh6FdihZhHrXrk5fYh6sinUt21R24Jk8VxWPjTgd9cF+F/fNiOiNAOxtTiwqIq12tgt1q0+oWcl/B9O/1L5aUyZdvZrKi42OxweK2KToPX466p4L1zNNN/swSfWTxLh4T6OMslnOJy6CmPXkHKNC4dP6qYRlXcvqvoxzRgmKZi2Kfua6/QeFMoPDrVzmPOdUq0s94IDsHPWuXZmRo17xfHMvLMK+9EA6Y7mgIBfliix0wV0+KB/X2lYxa29TrJ78IRhZ736GyeaJsp2tEqw63X+bM+pumYMcIkO7apNOxV8uEfNPU0aEI/I80wFdIsxCzOfRfyJ68Wlq2/mviYOj8otfuwwDNEsollEI3cwQVxyT8qNhF8tkZBgsphukELXhewxGSSNplABsQV6Z28btMLwmGqDHW+v4gW53iepNEiJ3+ZPTcD7qkxrpu1YYglrNEMroE/lx98Pm8T+xSepyQTn7vSvpLmL6WP6xMO/5Ht0eIubdHm6OpJPb/1frqLWM98unUvdbo32u610Ea2vBdoTFWMl1h+1AxsKmWKWZWayvHwJrM5duYtsyd3ZPRxlY7eE4rDnPi+kagig4Tio9Pld23BvhhnaB8USiXUNh97r4LkcIofzkCrhC0+I2lF8 VuOyQTAv EuL7qBOmv9753ReP0209YnDYKAi5O0c9Kmv5hjfirTfMhhKJkDlVoJW3z09d89u9Fhg9zmyivYsQ3bJ2bPAxRIaxBFPHeAxqdCrqk+4peJ0pMsftbMa5eurKW73VX6bFnzPSZK95XMwhV/h4KYwbpXYDs/ENUraPxute0NMJ8XTheigw5WQDLCUY61x/GcZhP64nOZi35IA7FsXnuOsWIwmxzchJHBgyiHYxegGBBKXH1ECuDDfYxOuxhvk+8/pGdzIJdLFoFds0MF1ReE1u9AVxIXtBRUDPiJsep5aEtIi/kl2urz1ibAF8FGRpDgFLFU04b4g72R5TiOA4OwLQNSrbihKzFbq5K6rN1Ks+ycWlnuqy8j2tpnCS4/QQYhAse/eQOPG3FeF7NlFUWdarqC5heY7tC6jOJ1ge9pnPqRIXlbaHB2mSZzWlhMbxR4ajR7r52B/ABBttypjFggJZ7+Alsj0nhjkZfxjagGsTpL+VQhs47OPVY9leVo47JDu6iaBY1GNvco49R+lOY+HAs2nnE1mFDOVSLT6yabRk3CTTT+yLLK/q0mZA1fQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.026742, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we are root, sudo isn't needed. If we are not root, we need sudo, so skip the test if it isn't present. We already do this for on-fault-limit, but this uses separate infrastructure since that is specifically for sudo-ing to the nobody user. Note this ptrace_skip configuration still fails if that file doesn't exist, but in that case the test is still fine, so this just prints an error but doesn't break anything. I suspect that's probably deliberate. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..9c963f50927ab2b10c3f942cedd087087d4d0def 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -89,6 +89,17 @@ RUN_ALL=false RUN_DESTRUCTIVE=false TAP_PREFIX="# " +# We can do stuff as root either if we are already root, or if sudo exists. +if [ "$(id -u)" == 0 ]; then + HAVE_SUDO_ROOT=true + SUDO_ROOT= +elif command -v sudo >/dev/null 2>&1; then + HAVE_SUDO_ROOT=true + SUDO_ROOT=sudo +else + HAVE_SUDO_ROOT=false +fi + while getopts "aht:n" OPT; do case ${OPT} in "a") RUN_ALL=true ;; @@ -384,10 +395,13 @@ CATEGORY="madv_guard" run_test ./guard-pages # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests CATEGORY="madv_populate" run_test ./madv_populate -if [ -x ./memfd_secret ] -then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix -CATEGORY="memfd_secret" run_test ./memfd_secret +if [ -x ./memfd_secret ]; then + if $HAVE_SUDO_ROOT; then + (echo 0 | $SUDO_ROOT tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix + CATEGORY="memfd_secret" run_test ./memfd_secret + else + echo "# SKIP ./memfd_secret" + fi fi # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100 From patchwork Thu Feb 20 15:03:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DE9C021B1 for ; Thu, 20 Feb 2025 15:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA60F2802EC; Thu, 20 Feb 2025 10:03:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE2782802E7; Thu, 20 Feb 2025 10:03:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7DBA2802EC; Thu, 20 Feb 2025 10:03:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9B6FD2802E7 for ; Thu, 20 Feb 2025 10:03:48 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2F1DAC1E0C for ; Thu, 20 Feb 2025 15:03:48 +0000 (UTC) X-FDA: 83140642536.01.4BAE11D Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf16.hostedemail.com (Postfix) with ESMTP id 4F9FF180002 for ; Thu, 20 Feb 2025 15:03:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="X1/VjCVr"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3UES3ZwgKCPkkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3UES3ZwgKCPkkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063826; a=rsa-sha256; cv=none; b=Xy/ufBD45dTRODiP4JobM82qRlRxWB+n4NRpIzuuunRsvkYcQ2eTM1fhKCWVRSMtIeRU0I fjmsUIdv/f7NtDlDaXn6x0wRArYNyLLI88BcqIVIbbd//68Ct1uNVKVgzZmg0Z3rKQgeLX 0DlkrDOeTUGbYXQ8XfZh08nKu/9Lgas= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="X1/VjCVr"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3UES3ZwgKCPkkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3UES3ZwgKCPkkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pfnk8jRZQRXvEGJgMo7kX45MXuk74eHKcJOVD1/hcv8=; b=qmNyaK52J9W8wiAHdcnkY5uDhqNxmWaN8oQJNLAfJzwvUCtuWyiERylTixgcsPgz6mGi8D 2SPdCDGX1glHXQyV+mGbSDufI6OvjNL+wRjDw0grfh1u2zJDqLQz4h/Gx5ZSRuoUqlhC3C S1+3j5xLE4W02s9e8abe13BQJthpA3g= Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-38f42f21f54so481904f8f.1 for ; Thu, 20 Feb 2025 07:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063824; x=1740668624; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Pfnk8jRZQRXvEGJgMo7kX45MXuk74eHKcJOVD1/hcv8=; b=X1/VjCVrdECgMhH9z0KbVuUUW41A+o4WjuvWzZNO0W+y5X1j4qtF8qu/PgoqwBV+UG 9zre3V0w4J4CEm5M4hmnal79etlJcULyjGSPirtQIWIjRJUUXDzs3Qs3ltj/3WPMkkgN UxLcWPvOHZz18A3SU/rBPGHaFiF9+AdeKqy72y2wmdpGqJV/K55DM1AnxfFchNWrgoUT 5A6PQdTnNExYNZIUc3CQ5oa+y5pbzIZN3TjqAi9GTVG+st+5aiU22iqeYSNzXpoi1l0+ uOC6IrjrFaaAQhSK/zOfSEFgnvBbJNNC+pmbB5OnPsSWoT5IpY02/E9k36t48rAWy8xH V/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063824; x=1740668624; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pfnk8jRZQRXvEGJgMo7kX45MXuk74eHKcJOVD1/hcv8=; b=jqG67FJyBIR4NatNq1T+Ap8O8QEr+kbIeKfmL1nPl2hpvbkIiLc7UdpMwq0qWl1B0/ 1Ft62fqObeemCLbPx2RVPEvY7cORY1paZUxHu4RhpmlsXDvmgYV0TTkl/gW4S7QtPXuI Jr3qKI6SGL8Xwau6jWP1YjV412Cq1G8mhjybPr2qzWyu19LgNP2WOHgRnvwlNQ5TwedB 9JxT1YloMwmPCN9qVWRoG8JEaCHWZedQMvbB4THxzV05z6fvKWTERRWBkncgvLSZ6+6k XaidbpLOGFq7yKhKN3wGlpxgB3XpU/feiyVKdCwYyQ4hZIBgMXJmA3+PzZXHN4fPSGCq flDg== X-Forwarded-Encrypted: i=1; AJvYcCUNtKZiEPvsSRH6R5HLRofqqT2NyH47mygxD9JDhDaXA/s8HiOLTQed1eAgBBosdgfpH+uOQfcDIg==@kvack.org X-Gm-Message-State: AOJu0YwL/Ifn3qZO5lmGY9AK+dTfDd+TL9O4fCjPdmqLN2Hvh84blMT7 Hoc8TNQgAMV2gvlnmgRvYLvJpH+bJoeG3r9EC/7xr47J3iGrBWn6BsFSWJsi+4uMeFB1CIBuAvK cDqPu47vuKg== X-Google-Smtp-Source: AGHT+IEZkoGqvABvYTvvXiRtV+S/mpL0J7HYkw5xP36OjVJpS+4DgqAiy+8j1WNNFXzaMG5CNB+I1Lj8O+cs0A== X-Received: from wrbfu21.prod.google.com ([2002:a05:6000:25f5:b0:38f:3cf0:aac7]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2c6:b0:38f:3344:361e with SMTP id ffacd0b85a97d-38f33f2e954mr20711279f8f.23.1740063824704; Thu, 20 Feb 2025 07:03:44 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:15 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-3-9bbf57d64463@google.com> Subject: [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: 4F9FF180002 X-Rspamd-Server: rspam12 X-Stat-Signature: 8rm3xx9uge633i5opdapq68ajiynf9ds X-HE-Tag: 1740063826-926243 X-HE-Meta: U2FsdGVkX19NkA7MPLE/vohYMKwmJO0i05BYCIrrkur2wCj/NBmAF8//3l+KCgdDu9Rkzp1i4VCMa6ikWfCpbQEpRCzSYcN9UMTFrMLG1QYyPn9LcS83eFZSRUzF96lXBsG8t2lhgyXyH0szesiCkDVf25eiMjcuwGvXA9XQik/L4OrcBz3O33dxDKkCZOrZqo1wBd70N4Sgl9N+KYS3goFJiWaQcuLiOUk4JOYNgPpNCyZZD5WlR9Ipc2hRqXyL0sne3Bzmk9Lmzex04n5cW5EVVXQ9I4OC9ru44LCVc3Q+qreJ336w+dmAlDria4J0tmstC6eEHwSd9Bd992Qm0L8745uljHnjEakMHBJNUkglVBBThFPP/WBuyBJkOBWlO/5+EzDBdb38g6/ooEzWaEozUZeDdWvjOxd4WNPIX5/IEBjVXzqUMopKshaC29i3f0Mi4vOV7yt7URW9KVAtQ/CMT4j0aF9bq5EpHgCHPo9kzx1aBnqXvm7gUeFYDu2YAVszhU2e0FrOcLzhhTiBMz0DxSq3ZqCnbNuQAR+WZAcPGVH37sCeuXmF8+mHqbDxga0CwjEe4HAvorVfI8M+qEgS4v1eDUa56d3o+0PxDt6h1Avmsdig0LKE8Gp6hAicZNcIXPG5Sc8KiGl3Gj7cW/9K5fWbDfI20glcaO3s+uuWHpr4jZFxQGtIWqmAqc5wgwvl6kbnV1SnpMpUkmheVs30FVflRyBcaYX2wYCe6jt5RbBXEbDkclWZCHpz0i/vk0NQNdkbsap1NJG3ko6hvR4CgY69PHLKfvuDxUIabbhJ8su+rcGqB92si2gHWt3d1LAjuv/OpcmNwWpAd2nyhRIhl4Grz96xBPy+UWxpsgsDj0eUgIWzwQc63ynnOsVqSG50Ag2fDGpsgGM69LvdA8n4/44NVRqBoKoQDwYjAdLiUiZpStxW74gbpVnUX1dWz9PgqMZDIXyO370EzQ4 TwPUPRAO ebgVL7Br+0v2SN3haSWk2JhMqKjL8pZp2T82ftC8xZamWHRwJ7w/4KlMf1Ia85Gl6M3WricdzcJbtaRIl3wW5hJaEARqF8v+J38bmulO7+z6wcyR0eYnvrp7fCUWFk7isPB7erRe5six5+G7dQkNY4PJKSBU0uNB5exRJt+rCia1EkL7MX+7659Qx3XbzYUnYMoloBJjdKggJlx0UnFLAZQqoVRqfEdp70U0CWxje7bFqxOIoTldQfG9zuIOny7h1ScHMxoFvBKqyn9c8crCpO3WvOXgK4SMiGSwBkiE/5WkLX5/Aa03kFl4bzPEJP29Ew/VArVDl+8y9Yrsn1m3aLBGoYCBxatsLX8e7qVoCITx79ykeGr3errTPkklPgJiza865aAVVMXYIL/j0ahwfVzTBupdJvv6FZNC1tEPBE3wrQGLgW/DOysgB3iuvaVIcs4jc18kHq9h5KRbD8zMqDtTNKSz31P7kCTponDOHc51lbFY5txEXwZOHXfpWO1jZ/JrkatWwaOiUziwT9WF+5I6kZYBQck8AAcs/UehNVjMYsiNOkL8nt/uaRGLWr03+pKqv0UnKmzbCv2LgLNUBPKfbAyeE4vYAGX5a8RFdS7cxz2R0jeJdewRImQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.227495, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..db5366b4766e5bfa2d1150d2f3c2d32469a6e28b 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno == ENOENT) + ksft_exit_skip("failed to get avialable features (%d)\n", errno); test_uffdio_wp = test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); From patchwork Thu Feb 20 15:03:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3341C021B1 for ; Thu, 20 Feb 2025 15:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1A85280004; Thu, 20 Feb 2025 10:03:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7ED280001; Thu, 20 Feb 2025 10:03:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C41C1280004; Thu, 20 Feb 2025 10:03:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A5629280001 for ; Thu, 20 Feb 2025 10:03:50 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E70725293D for ; Thu, 20 Feb 2025 15:03:49 +0000 (UTC) X-FDA: 83140642578.07.186E263 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf21.hostedemail.com (Postfix) with ESMTP id 1B3481C001B for ; Thu, 20 Feb 2025 15:03:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pyguurqo; spf=pass (imf21.hostedemail.com: domain of 3UkS3ZwgKCPsmdfnpdqejrrjoh.frpolqx0-ppnydfn.ruj@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3UkS3ZwgKCPsmdfnpdqejrrjoh.frpolqx0-ppnydfn.ruj@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=ScKcZ51QUzoLBMcUwg+5tlz6fs+W+/lBKVGFryivsTT94olAPniTm6SSttFzGAheFW+CNO 5IjLecLiaShy7C8jsVPdcEMbbLADC9EKGUE6wRDfXMIU3BTwLmaEIb4D6H7mNYX1umQHlD bh7ZaZnLA65WQ1q0mrWuvGGeMYgvBRw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pyguurqo; spf=pass (imf21.hostedemail.com: domain of 3UkS3ZwgKCPsmdfnpdqejrrjoh.frpolqx0-ppnydfn.ruj@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3UkS3ZwgKCPsmdfnpdqejrrjoh.frpolqx0-ppnydfn.ruj@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063828; a=rsa-sha256; cv=none; b=AMz3uNr8ts2rGg4+p3Ut4CprPuU0PI5gMjjf9y8tSGsOtVMGV891nXTSMY2UzewCKVZtQu 37aC0flyqdy5TDG4E6lflb5Ler4yMsnokk2XIqOxoWe0/ljF/mVLKmVIr9bsu0Nw6WJDlO OwseGEaBjZUrshqgqZf2R+3r8yc/Fhs= Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-38f20b530dfso945579f8f.3 for ; Thu, 20 Feb 2025 07:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063826; x=1740668626; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=pyguurqoBM7NZVE0g1qjxC3V0/A2ZUQBchUvkDl4yFQStVFvJhn36torU7j6Gn4zkB aTWyBPm+dzHDc2a6BOlIXHrmVtHb+dEXLWkrAi5cEgHD152jsqCX1Q4R1Zl/HaF1Tojp BveS3GCAlDWu84BiIMzszhg9ms7NBAV9Uu22onBB7xhKv5x4EXzvT7fo0Vlztog1Wk+x 7NGuLlpavSiOLafyHcUpLW6MFrSCsM7Kcpwn/mOxkqpYE2w6d0kX0G3EmQHK9KX/cVxj lUfz79JOaWpv/sWgeT1b/20Xcqa9GBa5uyK0u3zyA+2O9sEznX8qljRvVnEB8E6sqNkn 5Iow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063826; x=1740668626; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=a/tLii5sQLeTWmFuuK8P3EMd0h9H1wGI1+UgOpimYnolQzz88QGSmPOGQyYa6kAzs0 Demy4kGeYFEBRg9TZtovj+Wng7wqvm054MG6qG7j1Py1BC1Ut2iFBIbiwQXSK3e9limo R+7SQTQzWOwQWADWDgnXbHWBNAbS7qyy0U8gYfLxi9I5+MXm8YMMxumY/Lf7GrOhWtrZ 1TX8vnTVMA9sFXYaRT8edX3juMyxXj93sJLrOYHuyB8Gu8sF2xWfQuu7NRrBFEicZ+3B iAg6+5Ey2dwZQgsQh5FfGburmwhP1XaGmEOQ3bK1ocusaoOCGHpAR+uLFitQb3gllykY xDnw== X-Forwarded-Encrypted: i=1; AJvYcCWg+DMpScknZ+4vyLI4pxHreUqydmtDb2C0zUfu8OL797Y6DID3bN6daAFYcuHT6yP54Y8IrQyNBg==@kvack.org X-Gm-Message-State: AOJu0YwmbWFm4kQSO92RCSnwwXoT2c1eiqG5P3V5D3X0joWwZj/dUtFp juwK0w4TpYM7+EU6Z7ed395byMsgp0vxPxY1Rmr8bOd2VUMjsBldeAn7j/jPJRQkRmr/853QYrh 8WWBm56/A5g== X-Google-Smtp-Source: AGHT+IFsGg82gKlzl8tWzntDHJFghDx2t08uXQ7P5idCDRgaVqvqc920eCUSioT9wAdKGGY50Zw9lE7MF0GKww== X-Received: from wmbez7.prod.google.com ([2002:a05:600c:83c7:b0:439:67c6:5642]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:47a7:0:b0:38f:4b15:32fc with SMTP id ffacd0b85a97d-38f4b153521mr12347926f8f.8.1740063826684; Thu, 20 Feb 2025 07:03:46 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:16 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-4-9bbf57d64463@google.com> Subject: [PATCH 4/6] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 1B3481C001B X-Stat-Signature: 16or6gumrxff6b44juztdwi4t4td8p4h X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740063827-207857 X-HE-Meta: U2FsdGVkX19cV9Y06Jtz4ZwFSjLYsc1hFZK8KksHxBJpZax66b5YXvLiNFwhWwGfs41SDKR0r3SJUxkn9sjj5+i5ns9jeeCj+mO9eZ/Lty95RpRFiHpE3BlTTic8c9iQ2u3V0cGqyxsPbCCPkxv4EWrXU63oQNkIuII7tfEjwAy6YLEIOlBYNIKSUJmWXA9jo/mtCKoT7xFbamS3EQkYU3P68VwG6v8QySzJW+iCeeEyyLIhdxn4jRi2cW7WX0FADoO1KYJ7OXziaZAT7Rq6wtoSjrYp908i3DddfwQ55UChJRm++KZ/Z/zR25MuZXa5i5Ky9SygIJP2Iu/y+zQFl32C058Jkru+qKhuaimGG1DrcoQBstAip6g9eKagHgowfdhxQSL8z5p0ImLY8mimRcyPqU12/vr+HN7L2bF+RWCeehVHxTh/X+KcS5tg1BxUCmDLmVbXYN3tgWa5n3LN98b4C/ZJs31QdB9Tn4tOAfWZj89I3e8ISdAF+idRswnsS6jk5d10nSJRDFl1NOQyS18gUXLJ4UgUvkPXRnE8culYhWqX6+oChfb3hMZrnTJJQL0NQW6DPGxENZjTWdoi7nKjnxQXyzlE6tPAN73V0hdYdgVSdkIHnoHjaAyFG+dutgYk8Elv6sjt63e9BNF7LLmqtImalH73DAaeVdG++kOm6mkSDgJrzU1PftFnfwbAZRI7lYScY9z42ysav5pP960tInNSTSbBfO4K0KFLgwemn4ySSsXhNPMLqfe07nD5weN0tS3bsBq+mIohQh7bBobbcJsELex/5iRpqTfiQkbcH1KmR3KDobnNhVNOe4QyQ+c79574ppR0k/3N0j71ny2UZOnA2H+8Go30fpFkyYICJLfAprAEB+ZhX7pEdF2FGfttTNJbZP5WzfDsRoxWZgXlk47D2cp/+XWSapvn51e8j7bqZYIKRA+nWyjg0nULv9r/6i5tmBAljrPf9LP ynmlgWqj 0IlIkdHQ7lgMXDsXG6JiU2RiXUDzCatxe5veqpOm5bAqzrSfjr6p4Sx/2bKb7+Qau+PgGzqe+oooV9GAAPtXz0iu6jI5iG2OgUe3uhdoDAiEFOV1op94NBEbdfcw9pTzECX/R+eAvE3Qw/fHEbMUd0N0wBbbGRJU9Y1C7oAY8jPI4GS06tGwFq8VMEs69Id8edNYXxcjUAEI0qgD4ZuS/tyq5vHpkqJT6nNruCX1OHo6DLxL2abZQ0rK2XovdY2T2C1159iT6e3zDUojexj9soxtdGUnJCfJ3TEZrb22a2RfFGkftBiSDMuP/1pzvQxQp5CegkWmn2UTE1sa+3I93HrMpYgdqnCFVueSqAQoAcsTic1Z51MHV/3KZTjaUuXIS4V9zjv13pRuXBX5Nz/1Y0vb35+d2yFPoRRCBo+M3MemY0uljVTQBev2Gg42iK33R5ekyIFQvUTZ0xTUBErPlc9QnhHkGb91HG+7tQ3G/Gr+NyA/4rjPklkwze8qjRT5+CNjlWQO1hIzuz4Un5s1VJe0a+QKpzTq3qPbPvoUjV1JmTzbGwAb6vTZM7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.423701, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, bool swapout, bool hugetlb /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno == ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { From patchwork Thu Feb 20 15:03:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FC4C021B1 for ; Thu, 20 Feb 2025 15:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6F0B280005; Thu, 20 Feb 2025 10:03:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2191280001; Thu, 20 Feb 2025 10:03:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8720D280005; Thu, 20 Feb 2025 10:03:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6165E280001 for ; Thu, 20 Feb 2025 10:03:52 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD4C614202E for ; Thu, 20 Feb 2025 15:03:51 +0000 (UTC) X-FDA: 83140642662.18.D83C0CF Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf08.hostedemail.com (Postfix) with ESMTP id D4015160004 for ; Thu, 20 Feb 2025 15:03:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vxm4j+X2; spf=pass (imf08.hostedemail.com: domain of 3VES3ZwgKCP0ofhprfsglttlqj.htrqnsz2-rrp0fhp.twl@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3VES3ZwgKCP0ofhprfsglttlqj.htrqnsz2-rrp0fhp.twl@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n5anIIX08DH7I1Pe1I+Cw11KP1w7s/U6PELcC7zyacQ=; b=iu+zxHOtocyzX9Ln6ZNR/ujVJQXsUnKTakRBqc/6IDQEwFFneQidUQnwRU9J4hJYxVABtp ld/ydxVzXY5M3idlHRjlMbVDOkBqEolnjLrmI8ah3qKriFKXY5lkF7SHIkau5P4sQF0NXZ SxE/U5zHuVxu/CDkTgKXULjfhoOVIeY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vxm4j+X2; spf=pass (imf08.hostedemail.com: domain of 3VES3ZwgKCP0ofhprfsglttlqj.htrqnsz2-rrp0fhp.twl@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3VES3ZwgKCP0ofhprfsglttlqj.htrqnsz2-rrp0fhp.twl@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063829; a=rsa-sha256; cv=none; b=D27I4HNFd1riBTt2JrRIp2w7DX7Ygr5uK3t1e7pfmmBexyBssNgpdrMIDdPyKJGodaf5ES aDcs4/GnY+F+yhq7V2Tdek36cWhF+ZxMXYsL489kMybDe5d///IT1TstKxCF6mKoS/xpgX L70DASe58UQlxM9qBWDK1h1qHei5HyE= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43942e82719so6800905e9.2 for ; Thu, 20 Feb 2025 07:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063828; x=1740668628; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=n5anIIX08DH7I1Pe1I+Cw11KP1w7s/U6PELcC7zyacQ=; b=vxm4j+X2eVLAs9H75Gu/SoJBDtdsO1hXPCz4GUcvGQf+McJhCUIlUdZZJdvSK7lHXB NATvVF/UZguK01cd3mk0nLlQufaIRPs0Ol0mKOdrgwEgIqUuZ/1EqjGCa1xLtmhSUA18 PRczRF/PciHqUAE21TxodYYK97A3//huvZIG6a9aN1ZqKtl/yr5Ul06QRFqoj04UWQni XPtxEdkO6VXQ/IO3cDfT4NwbCnE3G09ubn1f9sk3k/LMDMbwG6TJq3Tze6xIIeRWF/K2 QogP54uvNVkflt3nNRthXatb+4rwo3Nx4bGIY6PpGtFYLAAz3uqZTJOYQQGlg8nJwZjL eKAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063828; x=1740668628; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n5anIIX08DH7I1Pe1I+Cw11KP1w7s/U6PELcC7zyacQ=; b=vF+tVoVnyGp57F/xN05eP4AbEnClJ5SiCl2PLBO3ONQb1qpKQ2Nf74GjHCvlc5SHZb Wn4R67a/LpRpxvhw/1Pm265N6SrzrBo2IsoG++msaiN0zz6u1OYFpjMwQDdfMgq2AEk/ dpQUASaMUNo0jSCMO0IFoS9yCpadOwpamtBCunyiHmAL6uyVXd1K/Fho1GgP/Kkpk0DO wKxYrDMuFxpRcZ1o7AHs3j71q+j59hVL7+q2gDouXP+F7GH0sVuyKkhskhTdT7SUasnB QxTAqjKVvKjC8o+h98zvUwCCp5iZch0reUTHGOYHyq8PuiCh1ubPppzL6ZrlzQK+Ls3E fmFQ== X-Forwarded-Encrypted: i=1; AJvYcCWfoL2k4Wuqcbo22ZbwOOJfyobufCr0xf83OM1Ey6W15sAX2s3xQ6GKuk3s8ML/bi2bUaQA5aPaGA==@kvack.org X-Gm-Message-State: AOJu0Yw1mPgNlmkzd5PkbeWKkq8a6rvXhvskaFgcVLzbTDSz1O28Ifsd NWB1hPuopwINjSigok3lavvKZQoIQ7uTA6W1Pxo5svBS9ZjfGPhQ8NVF4He/8Wx3vFRGOjJnw9t jGcDsBhuZUQ== X-Google-Smtp-Source: AGHT+IGIpi/Y/94IOaJbe0uGO6m//Yh2Wsky4Ip3Q/V6kyqLVCBH3J882rU0thH0J4Ub/her4q4G/B/xr6R6VQ== X-Received: from wmbfk5.prod.google.com ([2002:a05:600c:cc5:b0:439:89d1:bf88]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b26:b0:439:985b:17d6 with SMTP id 5b1f17b1804b1-43999ddaa0bmr75459345e9.27.1740063828632; Thu, 20 Feb 2025 07:03:48 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:17 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-5-9bbf57d64463@google.com> Subject: [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D4015160004 X-Stat-Signature: 1hyw9nt4oetga1ykeowcf549o4fmqxai X-HE-Tag: 1740063829-787941 X-HE-Meta: U2FsdGVkX1/ZDH2ihmK8KQfbPsTXIDf6rAfSRZnddHML8Fm+UA5VxVHQDCh4Bgc/+l5YldN1JAI0B4KaHb8SRh3QreKZr0Gea0HvZ4/pPkY/VdOK/DmgEdoPKFu3g5EKYgzlwgGh91xCqwsc7dUAbTJlxzcLsoZ1JonooNjokFST3fbFwWCFhWrv/ua8kASubeDObRb3XIJz0EQ9vOgoO/Sf7SR2XgVkae9eJMOmPdp7FBZJvYMPMvfQB75FbkFCX00HDJVJURDBN92UWYbw4xt4frjiOyHBshjCUqDUusJjWLvUHP9qkNo+/A14tlaAmm1RxtsA88psjWzwLAd2cDzRP5WXVhwqhtiae5Zx5DAJi53Aq2bSGzjixYUHMA+uwc3L3cD7+kbzhnf+GknEM2gUx1o3/j9Ma69YxKIjPVf34DLy7hvXBNSJW01bqMmJu1x1w6WbjFlFE6jXh8e/A3N+2O/T7Z+HTCJoLOmKCtarlFazDGejA5UtmOor+9oRUCEx5xG6voR9fQiBUe3qN4vox6qP9OE/RM/7+mEc/q+2CN0nvcQqx2QvMRQnPARyOjdHuvIaUepk8yG/ZKiEea13f6Jb+weaMGCnE8j8s+cngyU9ZPYabqsvJ4loL6USBVIgNxeydGDiZtYeR9eF8NZ2oZFDKSyNhsEPtZIDeHChiicuFBVhu7rs9XMOufDPaFLdngyt+7gAUrjmKKXWZO6FlYpvrc+7eta2FT2ohERcwJ4RicgtMiLAUlVIwowBPKwDVb3Pf3xKNUaq8ph/emsjC4Tr4pHc+bEKeowjHAV/+lldyiwhi490v55ePg4P4mLAnD0uD41JCPcz2b4jKr7FsiiHQRNH4Y+6+hV6I/9VagW3YbbTqQs1aX/l14H7MvbdoFkCT4PSrk2PwM2xdWULuIxiWgTe+nuDUTkg8VWgtS1O575jFDALRSebg9xoPLB3Hwljgb0AF8bQK1l F1ksB4hx KVMTqPnUroP5KqbAfYzJZgsGWWg77x2jDsvFlF8v6Ljdku2TEv3m+9lKAL0qz79XTQMNgo0ZTPVpFAgKCykyBRXVsMX2bpRuztWb9ylS0LI5hagnQyR/zK5AeVsF7FHjrt9kdM7AxhiEMjUItoeW72inaw0VXZc6AZuT46GFsxx/Sro8TAp+jgSvcyaUjEDx6Ok2iZy+XunbTzH9BFIm2+Ef18BqMu9N1s34JY2lYNqbl8zCOHLuzkU8fD5GngnZ9Ndh+reiMnuty0/xzl7hhbdqgk3H7cNGpM34PRXS0wotkPCou0ZmWGx2zCRSouCDSGcIldHW+nNTklc2a4DcXVEPnMeMnblaKm6C6GQe+Uz4WuSEE+/xDPINXl7Voqb1rbfZetbeejuwDYo5O7YiAUegEWVFzfZa+l2XSRlYEkVUnWQ4Ha5hhzR36eLCLHlEBZcf9XenNWyw4+AVPhjKxw1poDv1Uo9PvjZT9EMYl0amgrmOaH8PM7rrL5rXYQ5brNx1r607V882gSWd/AiVD3PHwqw8JAvYbMfa4/iJyoR4vyFemfrUpczo7gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.413680, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index db5366b4766e5bfa2d1150d2f3c2d32469a6e28b..1facfb79e09aa4113e344d7d90dec06a37264058 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -456,7 +456,8 @@ int main(int argc, char **argv) nr_pages_per_cpu = bytes / page_size / nr_cpus; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("invalid MiB %lu (%lu / %lu / %lu)", + nr_pages_per_cpu, bytes, page_size, nr_cpus); usage(); } From patchwork Thu Feb 20 15:03:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1760C021B1 for ; Thu, 20 Feb 2025 15:03:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E900280006; Thu, 20 Feb 2025 10:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8997A280001; Thu, 20 Feb 2025 10:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73B00280006; Thu, 20 Feb 2025 10:03:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4CD68280001 for ; Thu, 20 Feb 2025 10:03:54 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F1E1B52933 for ; Thu, 20 Feb 2025 15:03:53 +0000 (UTC) X-FDA: 83140642746.13.8AA366F Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf04.hostedemail.com (Postfix) with ESMTP id 1C7294000D for ; Thu, 20 Feb 2025 15:03:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=blpM0Zqk; spf=pass (imf04.hostedemail.com: domain of 3VkS3ZwgKCAEkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3VkS3ZwgKCAEkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740063832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xbBII2vXo7U0fvcYEVnofRQGig0kHut1fyAo0nfwDbE=; b=Ttaqs481H9PT1Ryvuu9ff5OTNUSWkEPYI13ivxVVF0PWeogRFgDQfXgqqxCbQacD8kgLbF gSUcCBpnT/7Jv/ffoXzreb47cVt+H0hHdjW4Maf5rKP+9IA8LgX+z3Juer09FTV6cnehQW JlVUXfp7Fj9OfsXvTQxA1Ma64pmJfuU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=blpM0Zqk; spf=pass (imf04.hostedemail.com: domain of 3VkS3ZwgKCAEkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3VkS3ZwgKCAEkbdlnbochpphmf.dpnmjovy-nnlwbdl.psh@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740063832; a=rsa-sha256; cv=none; b=JWl/Se7u8oLTVdlte3brDxHEyuwTLZwUTgfd+pm9YpX6Gw/TRkMPGHlbwfmAlTY/e8+q4f njvgLx3wjpSPVC+vIRyIkpIPr8Or+W1xFlWP4tgGz2Mx6d1f371QwCouylVqaKhQ8mz5qy wDpXslbGKW69Fu22OsEcMHARwO/mkzs= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4399c32efb4so8962475e9.1 for ; Thu, 20 Feb 2025 07:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063831; x=1740668631; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xbBII2vXo7U0fvcYEVnofRQGig0kHut1fyAo0nfwDbE=; b=blpM0ZqkVaRQKJODNCrvIBf3m/fHxPJfl6Niacp6YM/FN/IBuijkpvQkMfhyfvANGl UhzUKQFuV5Bzyedgo4/5D1hcVOPLfclFGRBYVgLYpz9dtdj0NxyUNA2kmwH9OygIqEsY tpFpt++tZWlgfqulVZ4kbb39Ub4aFfpYJ3+bOLYd4lrXPl+EhZVf4Q6nlY6AvbYmUmjA iKHAsyd1iGfOm/QGRR58flQ0SQE6ZRkI5J8Jb7H1sOXdDfmWJDw4BJwr4+CloSDqEtdW Kt/ItVsaL0wGFxTQY0URMCkGISJtsWodJ1cwD9MPxn2Jr69PJOBLCExHsvy8oUkCelAx LGgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063831; x=1740668631; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xbBII2vXo7U0fvcYEVnofRQGig0kHut1fyAo0nfwDbE=; b=vlUNGkfK4QSNmE7mIjqhhfPZwAaZsPb5Iwg/6kECbyW7/+AxYbnSZvAqeS6dDe5pKy RcUyRlTbHcgBkhXGanKh34TjhQd1HVkg6/z9DxgZVax0WKElga+KMw0DdWgU0ELcSEOD JXF5mxQEzK1vMJFmwJvPCj6yWk2sDx6fBz+0BFcK+CVbqbgLpeQdiWONNI1BjYi94Na6 qNYg8tYqOXbpdfn57BBhUFqwm5fzpi8N+EY1+N+94ziRHJSczyCrlDSjHSaHP04pAUSJ x1JoFpw21ZzTobMv+oWYZ/jeXDeDUuppZ/9oegqTa9dJnGVJHO8764dnxLLmZmNfnAZr 7GSw== X-Forwarded-Encrypted: i=1; AJvYcCVG//LqgE5USdIe2HQEi0epP/v3c+SymHYACUTmVZqdSiyRvTxkGrAnWiicybu3IOpD6XXcXGrxQw==@kvack.org X-Gm-Message-State: AOJu0YzKtS3mpfUsTpDAZSPzpx3lbymJc+e0WuvQoHTWF8NKoYMM77zv 4tG4ZAKJCJ8DSeawTBEUUU/bmcOkXnZKGpxRr+UI5RfoVTOR3D5nzpt/GS+CLgMCZJunE/t7fCS Vakk5LrszXg== X-Google-Smtp-Source: AGHT+IE7Haql4kRMGhVIrFouZcnUmxPrPTorpBWL1U181AADTVynYOoCOjR/I6BHdrXJEH2hvn+bGdgYYdY0eQ== X-Received: from wmbay10.prod.google.com ([2002:a05:600c:1e0a:b0:439:8715:690e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:1f8f:b0:38d:b8fd:591f with SMTP id ffacd0b85a97d-38f614991e7mr3002810f8f.5.1740063830609; Thu, 20 Feb 2025 07:03:50 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:18 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-6-9bbf57d64463@google.com> Subject: [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1C7294000D X-Stat-Signature: bs4ngf1cdogg45sgpq9mkbsda6wbn5ni X-HE-Tag: 1740063831-781591 X-HE-Meta: U2FsdGVkX18xvKG3IXjHMEUFaD9Ru04Fa5dSVB9JiViwtLgFhBxFjD5SyIZ6gclia+jy3DgKg0Uep4/XsV6dtqjCl7mXuvjt8wtN+JqvR1TJBnP7ZqUeb7SeDMegG1rcGlRwGqjOwbovynsiYADe9Tqm25p7JZYgr+maPFKOP0Js5wpt/vshspLSPxFUO7SJ7sIQ5gJFJ8IB5gYXvLhhAHmXNjhWkVv/pLNtImqTP8gM/6cDef1kuHjw+yBlhNjh/2bJwz8gkBjG63e9MguB/q55TCuG6C2zTkBAME8tRCAGqmMMd/GLKzRAdhVgQ2alaEhcee/2kEoLPeHVeN1NQpEMvNxIYnJ/EE5GaRt5KNVjMrVZUpn5vXObrrlIdBBxevlc1aZVwNfLciOZCR2WbjeQxIeJWIwBv9dQP0x7hnBqXco9ujigwdP4wYKFhQ7lrGnLDJcX6I8UIWc3MaNEPUADRCYqZWnQGDHIdGjJPMzaWqQ0gqFI7mjKSTy9t09WsT3h4jqN9Za5gwiEmwzZLPMT1iQ7+jZzP/k8qa1FTwlH2Se6qFcJbEOnWAWwTLPApkmL6TVoh1ro7eIvZeOY3zhet36X7yYy7LhNh8YBz9GRWrouvc39qVDlxdCA+jtzaMZbWiohgaAhhebh1LM4AWU3C62xgNW7T35dZF4sJa7q7+PWEtonv0mSRgONBtqczwKeJkMBdrDj1/2T7hT5Zf9IkWTcWQo71Xof3KdNU3oXpgSMc6uEvW8oDy+F616bCq24dqFe/qNjMMlb0IcOIOfcxlV4qJ4zDHTm1B0fOkCfRGGVUVLjxk3/7LRdM/X/tyMi4bdwQNbyvXUev6cXwtMn9Tn9rkPCio14wIq0vhymVPGKRLI9xKtFhV7lTrZ1CQLCFXF5wJCxsd8x7SrDf15Ox78N3ZtAuNAr52cG3J9ShUnDYNCKJLL65VnkwqhGQ4dA09Vhbp2bV4mNxTX IJBhPiu2 9tZN2CtejHn3XVFvVs1gFqfHZHfvwawfOA6MJfzX05Y9v3mDH01lYgl/+Z1MWbgeZM8ybtwAmS8WEE6QUFV7DgANLM4s3ijIBAlQYLKuQXCaGC2YVIc+3TRVNvE6P3iFoa2LdSpQE/B4UwcVpeUoOx+3aaaFuLcQQkddnANS51vbwGT7jpXArp+hZg3paIi5R8BqGnbwXsXN/l/J9tprvF01B9EpqvzyB8ciQQjyIkxZpimMnpR6wEGUd3eH4a5hSRmZuweRvzoT/rz+zZBpb/khEsIx+lc0QmxfEdKlV+JlWT9lW6H+X4Myd5ASdlcTpwyv2szyNUs/M8hLOOUumscVTlXeQPQIPLltsluNZz+SlCaZYyL3OC3hJwlltoRePWkVGC9RE4idGEjwdCSe0wp89Ly1r9CmhrYePTlbD4eC16N1n4ST97mvYU7owGFPW7mqJP8bWYmGi1cNzd81Z8cdrnKi/mkTFsEovh40Lkxj/7bC58vRDaSsT8Gl5xiqe9oz+YfS16z6lm6TUm+A4L2Qo6rRabhF3XDkM4dYHOGV+nG6CGGow9nD3va/Ki1QMGV5wu++soMFsUImlXBWr0/c9nCII7AjZ3paN X-Bogosity: Ham, tests=bogofilter, spamicity=0.015448, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index 1facfb79e09aa4113e344d7d90dec06a37264058..f306accbef255c79bc3eeba8b9e42161a88fc10e 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -453,6 +453,10 @@ int main(int argc, char **argv) } nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + nr_cpus = 32; + } nr_pages_per_cpu = bytes / page_size / nr_cpus; if (!nr_pages_per_cpu) {