From patchwork Thu Feb 20 20:02:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13984470 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E186CC021B1 for ; Thu, 20 Feb 2025 20:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 482844401EA; Thu, 20 Feb 2025 15:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 432184401E9; Thu, 20 Feb 2025 15:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9444401EA; Thu, 20 Feb 2025 15:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D99D4401E9 for ; Thu, 20 Feb 2025 15:02:16 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ADDD8A62F5 for ; Thu, 20 Feb 2025 20:02:15 +0000 (UTC) X-FDA: 83141394630.12.7E3C1CC Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf01.hostedemail.com (Postfix) with ESMTP id A3F7940007 for ; Thu, 20 Feb 2025 20:02:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L9jIMVPX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3RIq3ZwYKCHsrtqdmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--surenb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3RIq3ZwYKCHsrtqdmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740081733; a=rsa-sha256; cv=none; b=wMiiKJivoMetRdNEJ3q7obXksoDUfDL+iBBR5v9589xNPkX2VxJo1EEukSfOE+KAniwcGu /jQdcOwSKc1iAL/9fBEsb8VwiToawCTAVJaIh1Ni5MBjCPBQIJ2N3FusKbyjyVsrY9UlYL K8WEO9RPLD1Sfq/iLvK/IurhNslfITM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L9jIMVPX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3RIq3ZwYKCHsrtqdmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--surenb.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=3RIq3ZwYKCHsrtqdmafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740081733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Bs4ICV92lNNA+t7itNY/GyIOuvUFwmfXCBMREBnAmzs=; b=cy3Lvd0knOYi9F30/LknHhUf6BkoDCcxE26imxx/B0DwfAKi5SG8zFVZOIptINP9OYEspB Xf2U+EZbw1XDrZN1PUWzJCscNSX91h7c3vO3iB0Wpgy7dJrhUS8hwa+pgyrp/YpqpT3sNU T3niroiscviZ+F6OsaLY7vgyyHb2ZmE= Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-220c86e46ebso23912635ad.0 for ; Thu, 20 Feb 2025 12:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740081732; x=1740686532; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Bs4ICV92lNNA+t7itNY/GyIOuvUFwmfXCBMREBnAmzs=; b=L9jIMVPX0xm4MDTycTuZse9xdeeYZCvPkZ/MYlPNofWlpxGcUXoXQKECMZ2Fvczq+q OH9xD4uSB3GtNazyYJfJGaQG9B7Rk3YYSu4ap8L+YY/y1Di1SfCJv7v65Ztq9J64alRI QCIF5uU9qqrA5/JjyRc9nC8rJL6ZPLtlo3D8K8Gc9K2oBmCIoA/bAyX7VrrVfZWWBWu0 aoVnAw2tixX4pCQPKpOh6UvBlqbUJiyTBT7EHQFBL4totWg8IJK88FFob3v/9nkiqFZG gQ9+xFlcyUaDbt1D1JXsqfRlRXr6EFXqIpJS4cWjhVvpfAtoV8LJYagE4BHbOhuQjGnQ pRrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740081732; x=1740686532; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Bs4ICV92lNNA+t7itNY/GyIOuvUFwmfXCBMREBnAmzs=; b=BdKfG9c5utNv49M4Z9ZyDbbWzcxK+D8L70hKGdn+NmR1G1IZpJGatjchdROr/ZZcN+ w3iXD2FdEm4UXEbWw3dJys+nMkxpv5UrGwMGoaBn9etUcToiy0tZ5Get23hPtCPyFG6N +J2riHIajLevGjTDy2G4pSi0iGOGBdd2knjmFu4OeIFaErjYYxH3eYwr8EQOlgpukqAj X17MP0aYwtJBbC81ByNd/1a4cI+q+lr5ffRx/dRiXxo1H5/ow0r96P+F87sK8Cjpool5 aF/SsgcJicze+TjOUcLqpZPAf7UEzZIKPqhrSQI4L2TDxrDUs0+66zgV09O+epAVukXh 8J+w== X-Forwarded-Encrypted: i=1; AJvYcCU1GAqQc81EosfiuC3i1D5FHFRjfKU54P5R2TnjbmVv0fwKmyn6ObTZ/84MQ5ULkLBLnKgNFgDGnQ==@kvack.org X-Gm-Message-State: AOJu0YwztzOl0tEbMG5diAFjY6GoAzZZLF6VNBU92TT55aQbT1WSoh2w BDKUoOl/RlrvAfaZEyZJ85kCei31UfKqHvaNtS4BiqDOhyVGPIN9TXPGDpVizBqTdP+VmAMS75C k6Q== X-Google-Smtp-Source: AGHT+IGhnv/b9NKb1nCWT3Dat4UCewxN6QZHqaa7b5Lzmmmpxs45FNSKjTV31tV543Sx2LCzk8TNaJay418= X-Received: from pjbnd6.prod.google.com ([2002:a17:90b:4cc6:b0:2fa:284f:adae]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d4c8:b0:21f:6dca:6932 with SMTP id d9443c01a7336-2219ffbba1bmr6717575ad.43.1740081732407; Thu, 20 Feb 2025 12:02:12 -0800 (PST) Date: Thu, 20 Feb 2025 12:02:08 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.601.g30ceb7b040-goog Message-ID: <20250220200208.323769-1-surenb@google.com> Subject: [PATCH 1/1] fixup! mm: fix a crash due to vma_end_read() that should have been removed From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: sfr@canb.auug.org.au, hca@linux.ibm.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org X-Rspam-User: X-Rspamd-Queue-Id: A3F7940007 X-Rspamd-Server: rspam12 X-Stat-Signature: kkn6pqoystonw9ha9gu9k9ts6zafj3zd X-HE-Tag: 1740081733-997462 X-HE-Meta: U2FsdGVkX19FT7BF8pZEjGzY6PEtE7222Nnk2MuNOdCcySTT4wylZPZQ/r64ONADp6gAfNB/8J5H5ry9Q5mmpi0Z5giKXEUdg5dtSGthjRO6qllPyLq7m903gHTgh2P7iC8mlYaBRFkfmGGImLljUPXZuq2WaLsAJkE/5flU72JDg/fKTIKRuorfd2+IBDiRtbIeI7cU6+PFONCO2/P2Bm8l87HjjrP+b9DWOO/NFmkLGSxV3rXQicxr7HMmBn+ZP0ZQsSDnIqg9LZfyn+DtQMRhTbcOvtmj/65x6GyNQCf3LoUjzzAKbCVfRmY/XEt8+Z+UP908gozvFpyKdCGix/nc/BMO9c8d37JhOs4u4xgFkh2FIHwlfd3E8jhZ3ct7SMxix6rtFh4mCCL3ErCQfCcincDKrbek9LVZt/yggpJr/L5RsuXTtpqVtoWu/4c3fLMi6nYzFjvmBhZjsyPppLxwcqBylKzVowGkNmuFlZ+oodQd7lwoDahKQtg4H7a0DFNUV5MKv4XL0c6vmvDwExVspnM+jLaG0txu0dDJWxkVODFUhqEs3J06IbN88Ux726275R6pY1rZJQuuEfYZMqbwKEJzhxR25NWCXhd2Zn+7domgbr9JpPoSmltc9rzRcdTLqtWdAALLr8wfzME4A4tmiE7CaKtK0p3RKe9x9D/3aP02aBtp2AxOXPu3wmP4ups7yiSTEES6K/OzSbypjRJJrWnhSi/Ts/CWBHuHnYiknx6gZgy7lZejAuBCs8/ZRRfos4hvBhHGFsyc37K0PynTjZq7jsb2iKcj98qKa5k8Rd5w8QymCLpg4bDSohb8nI2nGtc/V6dTago/guyPD73mgYiHEylfUi10KruZpacHsdaZLnA57gWhUijZg/1p7nuFqxGXV50x3Uiis+THBIUETN/l4yJ6h73J/NLVdxYs9OVLpxmcPMbxxgnU63GuENz+wyTuvJ+FtEoWsPB ez4x5PiS N9llWjr3xTmlaSimIXhZ+TBPJ9flKwZJ63QR/0/lsM0RPfVHw9GmXkO+GlLmT23hjyFJak/j7vGqnNu2NHWPynSC6pxmrgAO+E3QR38MQl1VUldoF66D2l3TIGx17H1XV4LPNv0BWA0nGgzO9MgSw5F1KbaEW9xkiir9fhIrhY1B6yG5pwWxdWyzv59VCeAReMsPEzU05M59xcyvpFlJNI1FxQCOGsCqkMxa4BI6QjS/vonbSG4od2oKJIS2PojLRiPVd5PnE6IHgzaz/QqDtkaRblGzbV+OCqqB9SEdjbXS0VQbNrPMgsYNZ0gEWQ4Savp6stf6i8chJuE+nhpkxGk46sCVAvTxFGBsYZD9JuoQBNd1z6fw/V2lBhui54qSPYreha79MdcoalE1/Fblv0NTDVVFqS8NATGs4M8PUL0wa8ovroGs+FRbM5UXY8iMGIX8Yb0miPsqVD4mEAWiOzv3tn7QKVKgA95lpKEd5BiHkhU+T+P1O+zrXQ6xvVZckg+lJMD5q+hixD3MF0y6O+pegRxTCDr0Pej2DeOKHl4jPEH3pUZPJdqln7/NayGiB+2E97Jxrq40VVW/peBl/iG+Dnbk6L+21yWjTnMxQMivQZf6PrLdWkPCsAiCfwUl6mRIk1vn9rgLcLFM71k/voJnIueEQ7C+E66nwCISjlD287nvnsziFwF2OHD5UeqCWpJg9RBx0TQrk0qbAtAZQwSHOFK5ibQYXmeuRuM2VPgDMRNgkNT16ucwXk35bfDL+XoiBTBWuDA+2RUDJTTXZarf4QQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.298828, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Handling a vma lock failure due to vma being detached from under us got changed but vma_end_read() in that path was left untouched while it should have been removed. Remove it. Fixes: 758f7664c3d1 ("mm: replace vm_lock and detached flag with a reference count") Reported-by: Heiko Carstens Closes: https://lore.kernel.org/all/20250220185304.8313A7d-hca@linux.ibm.com/ Signed-off-by: Suren Baghdasaryan --- mm/memory.c | 1 - 1 file changed, 1 deletion(-) base-commit: f7ed46277aaa8f848f18959ff68469f5186ba87c diff --git a/mm/memory.c b/mm/memory.c index cacf6d53bdf3..567b45e5d149 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6496,7 +6496,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm, if (IS_ERR_OR_NULL(vma)) { /* Check if the VMA got isolated after we found it */ if (PTR_ERR(vma) == -EAGAIN) { - vma_end_read(vma); count_vm_vma_lock_event(VMA_LOCK_MISS); /* The area was replaced with another one */ goto retry;