From patchwork Mon Feb 24 09:30:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 13987678 X-Patchwork-Delegate: jikos@jikos.cz Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405B3158D96 for ; Mon, 24 Feb 2025 09:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389416; cv=none; b=NqIWZ2iYSPUdrUB7kDosbTwCGVaT1E3wIPQX1fb3HKbZNH1PUVwfpWxpmpDn13bKtl5UxUt8btEcerq1sQ8tg8/rz0+55ygctqcH+WSxZjvZ+U/Q6d2mTiBPJUI4fvYeOD5uJqMFnvNQ7gVN36ydBIjEetkBD2P9GhXVEy/QOGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389416; c=relaxed/simple; bh=3T4YzAQURkv2cYSaZM4p2LxoTFID/ZnnSccXjrjxqf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bFcNTVIcIiKaY/tg27g8T/i+1obmluHPaMO7yg6QryLWj14ozPf8kaVH4z96FbGIwnDhnS1Lk1dC6HD8UKNq+kliVAvYooTKvW4vI/uuT58oqmq5H7yzQvqzgEIiL0YOwmNX4Uuae1gRId+IEbDkAUrZtMIuZudrqn2GNqVXE4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WH78KHBX; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WH78KHBX" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5de8e26f69fso768019a12.0 for ; Mon, 24 Feb 2025 01:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740389413; x=1740994213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bZYzwX+kmo0dpwpxSXaKJth2MnjzSzA80scLUp1v0LE=; b=WH78KHBXaXkuyVzSuJ63Gz4GB8ksvgBwJnGsQH5+HtylqcCE18tiruETFNeIrqYAEd D4TGQpDS9y+mR4YHm1t3Ksjx3XZS+xdVqBQeXlmUyqh909rcNYEqw+9CzeoVAnyy33+K CfqNFgQDrqZ2M9v570xdDhM4Ll5XUPKyARxfDRazeK/nJUSXwk/4eZMMFUfn81rryUgl Q7wbb/80RE0UZ8h/4nPMoaVZHTLtLXfN66j2tEtAWQOlu1qFPwn9TMC57m1wvlgWSGD4 brK+KwbQlZgTkVjysnnaNNUJFP1ywUa9y0mw7eiQN4lj3HaHZeLo/WVlSYMGooREkBL8 maVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740389413; x=1740994213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bZYzwX+kmo0dpwpxSXaKJth2MnjzSzA80scLUp1v0LE=; b=viak6HGOqdqJbh6u0KILwrLryiUlgdboFPTKZO+KsGmkD/2gDdIKEg0q3MSGZZ0eyL vJFl0/7UKKDSYg9EIWsXfyx2roZABK53ETUWYIFB78BHrLLWdPp4O6cYEgeuLQu/Yheb 36qRxY0WXENhYp+HVjRbG+KXJIlFfC8MNAaqnM8ySzZgWul0U5oHPOx2xqwWZLhwk2W/ 2VatesHfuXCw/xf1E6MowCaMlJg4tXaZZII+K8lDoVLgJPF2VuwMDRY8AFBAPD7qVs14 kDw5Ayu7te196n97HXoYoT61S5OYBHshH87qd7GiTKAuxonSBBiG7HcnpXqqwQG/YoPt pYLQ== X-Forwarded-Encrypted: i=1; AJvYcCURCnsoAdnqImOmQDYXh3wLlqKLgK35Ddoo/gWlD0TWJnRQWVRTcNb7OtRuB5eSlffbHBZy0zb10/Me8g==@vger.kernel.org X-Gm-Message-State: AOJu0YzbKgqtvPnt5mFPFDxVKD+FA06KCIBDZp3bbJQrd5hddkY+w3O1 zhyedgVU7RMt0D7W5NLgjRUToK5O7dIzz5iFKGG+IYRvvP+2Gc05 X-Gm-Gg: ASbGnctD2Dl0IyoStLicrhOkQEUNZSIPZjhhsAY2I/vOL0bESBiPh7mD8d2jdDcEmsu oEday9kkPMFdhVC5HxKz23jH8yO+wWVcvCdfL4T2mGo1Z755O4FNLlomudhSb9blExLYmdJb2Tt wdy/Q6Iw/ns5aM7K6dtlep01YIhAkD0eQd6E0eS0njiiCcVddon2XyTxCTvhRLw7ts9Ji6g2z4N t7fH0BGknV1xTYpMXKTHLhhGClg9Kgn98/0jMJCocoTHpWy7Pc0meD/TGtfVl+VnVVbe5CGgt06 LESWvAosvcL9ImRtLcP13M9Uujjra2TRW6N2kOldQD/Qx+XSUMAbkDFFpbeKkO3CbsUcjNKR X-Google-Smtp-Source: AGHT+IHEQJuB3LEkS8l8wyPHKNcNXQ7jeJNq+3Wha+UPjwFsNF1grnDTQGLz9ZFiafrz8lIBapCuTA== X-Received: by 2002:a17:906:16d5:b0:abc:37ac:6e6b with SMTP id a640c23a62f3a-abc37ac700emr208910766b.7.1740389413069; Mon, 24 Feb 2025 01:30:13 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abba4b9ee98sm1416668666b.167.2025.02.24.01.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 01:30:12 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, anssi.hannula@gmail.com, linux-input@vger.kernel.org Subject: [PATCH 1/3] HID: pidff: Rename two functions to align them with naming convention Date: Mon, 24 Feb 2025 10:30:07 +0100 Message-ID: <20250224093009.1831811-2-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> References: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Driver uses "set" everywhere to indicate setting report values and requesting HID_REQ_SET_REPORT Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 6f6c47bd57ea..ffecc712be00 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -552,7 +552,7 @@ static void pidff_set_gain_report(struct pidff_device *pidff, u16 gain) /* * Clear device control report */ -static void pidff_send_device_control(struct pidff_device *pidff, int field) +static void pidff_set_device_control(struct pidff_device *pidff, int field) { int i, tmp; int field_index = pidff->control_id[field]; @@ -578,10 +578,10 @@ static void pidff_send_device_control(struct pidff_device *pidff, int field) /* * Modify actuators state */ -static void pidff_modify_actuators_state(struct pidff_device *pidff, bool enable) +static void pidff_set_actuators(struct pidff_device *pidff, bool enable) { hid_dbg(pidff->hid, "%s actuators\n", enable ? "Enable" : "Disable"); - pidff_send_device_control(pidff, + pidff_set_device_control(pidff, enable ? PID_ENABLE_ACTUATORS : PID_DISABLE_ACTUATORS); } @@ -591,12 +591,12 @@ static void pidff_modify_actuators_state(struct pidff_device *pidff, bool enable static void pidff_reset(struct pidff_device *pidff) { /* We reset twice as sometimes hid_wait_io isn't waiting long enough */ - pidff_send_device_control(pidff, PID_RESET); - pidff_send_device_control(pidff, PID_RESET); + pidff_set_device_control(pidff, PID_RESET); + pidff_set_device_control(pidff, PID_RESET); pidff->effect_count = 0; - pidff_send_device_control(pidff, PID_STOP_ALL_EFFECTS); - pidff_modify_actuators_state(pidff, 1); + pidff_set_device_control(pidff, PID_STOP_ALL_EFFECTS); + pidff_set_actuators(pidff, 1); } /* From patchwork Mon Feb 24 09:30:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 13987679 X-Patchwork-Delegate: jikos@jikos.cz Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F7B245007 for ; Mon, 24 Feb 2025 09:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389418; cv=none; b=jP8YbBynfn3pJXrE2gIMJ2UO0TsRigGvDt9G4yKZBb9K/kM8AcDLuv/x+rnac6+obvFIkCqYoxRBF0yJFWfsXsrvt9L98q4hODNcHvOZgkpapd6Cj772Nzbl9mn85zktIhsienkUkeG0zLQeJgwz36HH7io+O4R6O4B5AArkYgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389418; c=relaxed/simple; bh=rDNXna+gN2QDPeh5Mes6QRGVy0ST1p5cqn2Zp5ZQ6EA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jD3gjvRo1FhfQAA0q4WPwgCwWvTf3MF+pTQFKr0Oy9CMIHsMl8X1CPOGFxnZtgu4EjemjNB7FO9v/QJj1G0RjjLqt4Fl8vQCUJFg9QPjkyupvYoWbufIYvkVx2Do1bmHQs6RBw8hEez46ihQfbL/l6q9QnNHSbJc9NVWY6gyJvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O89drmDH; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O89drmDH" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5debb4aef2eso716048a12.3 for ; Mon, 24 Feb 2025 01:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740389414; x=1740994214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zTk2aSpUgOWcjZ+Aa61IU/vjwVvxUJEha1zttmZAei8=; b=O89drmDHrukoCPS6XqBsDMVTJ7oCn/9AJiis72HUzH5hsPxUP4INVnYTYet0v5Eb1y N9LPG360HyquWyQTW9q8nF6ePEe+ZX6D9uAFiRebAGtwUOg4z75xqvMWp4cL2ThTw7BB nFQ+Yd8TGBCgDCw9T18Fb5+16Rw2uvOhQz7JkvxYhN/RS9FmsuDzKbohUR6qPlDUCd9q 3Ddb9NSxsbdpDToaXI0/x255eA9PEz2rsHUliTsDKL0RVcqB+G/K8l6SLXJC+qxVMlyj 7OrnBTmThIMwcMoMwubVK214Hkzm4ETjP0iPKi7V+eCluoM9lnW5y7w5koF/B6iavTjh tXgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740389414; x=1740994214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zTk2aSpUgOWcjZ+Aa61IU/vjwVvxUJEha1zttmZAei8=; b=M2MadGY+oNpi/LJ4gk7e5ryiu0ZjJu4j4qamv47O5yWPASE/HonjyfUJGM1MqPMSs7 2JzTCX2LWUUFZ94dyYnJ6GXgSuIvgbxpq92YnMIrO1BIEcsFS3vZkzuFJ9VtUp9xNVTw /nbxZAY466X9/jq/mbIe9/8uQwC9n7CUGs712H7LqUGLVnTwz1d7fudAAMjuK6LDdKCF c84OUrSUFpgGBBWSdOBWmG42PjomdJrS2POoFfD7JALNWgfMLpEkeDJJcIZC6o6D2oiH JhBOnbgcleArgoEFQkjRH1drCLiry0CoSAbKg634j8F7z0lH1NZOydn1nQE7wo00jLgZ 8tsA== X-Forwarded-Encrypted: i=1; AJvYcCVEgy/9JVu2nOylnJU6wPYLOYNtjqsaWUOP/bm1l4aBZMXUIEPcr9s/LOQ5uqZ/w98J1sna49RKb0wJPQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwTwmyuDPRRKjdTI+47X6BOTs7yqpD7ECLqn7vvxH4bVW47GnvF 0uOtdHkR4o/SrX7Ma5eA6ZFf/aXFTWxaJXoAlaQXnFs//fLnsot48+Kgb3yt X-Gm-Gg: ASbGnct1ULuR3iCXY+RMXMVpLXu0llFaxD/oX++5C/46MrRa44MADW93jERDdVOOwUo ifB1UMa0f5+HnjKdninorxqzWTdXpEA/yF6xc1jm25aRmSehMvUvEoGudq3NvrrGENHA3T+yBP9 I3L55LFUDar+zRqh5zg3JL7NDAqv0PeR5LzDMjDuK9XioZZEWe2A/zxb7PmAtIBml9CX6H8C8pE YoKCJEDHRbso3G9feeoVSnnZTQ/gM4+Mg7WlWZdjC0q0t+nnkL/YdlZf7UWXqKKiIespy/1XOWi N7jLPUypqBx4TXgfF2AA3BU0xAEoId/J8+ljaAnSk0BakozklD1hF8trumBGLcDxLzPkYZpC X-Google-Smtp-Source: AGHT+IGjLASHafgq9RZXxdgQTy9f3RB9YMVWHWC6vKuOdqJOXC3O0Ahtnbg+S6+1cMGnbC0VF3fORw== X-Received: by 2002:a17:907:9406:b0:abb:e7b0:5449 with SMTP id a640c23a62f3a-abc09c30bcemr385394766b.11.1740389414240; Mon, 24 Feb 2025 01:30:14 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abba4b9ee98sm1416668666b.167.2025.02.24.01.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 01:30:13 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, anssi.hannula@gmail.com, linux-input@vger.kernel.org Subject: [PATCH 2/3] HID: pidff: Clamp effect playback LOOP_COUNT value Date: Mon, 24 Feb 2025 10:30:08 +0100 Message-ID: <20250224093009.1831811-3-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> References: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ensures the loop count will never exceed the logical_maximum. Fixes implementation errors happening when applications use the max value of int32/DWORD as the effect iterations. This could be observed when running software both native and in wine when driver tried to cram 2147483647 into an 8 bit field. Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index ffecc712be00..74b033a4ac1b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -690,7 +690,8 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) } else { pidff->effect_operation_status->value[0] = pidff->operation_id[PID_EFFECT_START]; - pidff->effect_operation[PID_LOOP_COUNT].value[0] = n; + pidff->effect_operation[PID_LOOP_COUNT].value[0] = + pidff_clamp(n, pidff->effect_operation[PID_LOOP_COUNT].field); } hid_hw_request(pidff->hid, pidff->reports[PID_EFFECT_OPERATION], From patchwork Mon Feb 24 09:30:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 13987680 X-Patchwork-Delegate: jikos@jikos.cz Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61EEC158D96 for ; Mon, 24 Feb 2025 09:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389419; cv=none; b=S9eG83lTfnxFeT6992/oEOh8C7Rqx92QAd3UYIZHTrKnxfuCWPYeMQiZ2pH6hslxcq2IWqCy7vojvNRj+g8mK8l7pil255mfqAOG2ssIy+PrSyLbOf/ww/tklAk/FAYX6kz906Rv8e8x1zkSxO6vSlQKAeOKQPOQoI9TkVT0nVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740389419; c=relaxed/simple; bh=YQExJ7jUd/Cw+KmuNvncQzBndAiLM9ouibxbO6Z7Hb0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pFkrzDAO4I+ioF4KxtOOugc/NuwUQhrg3ciDksnoIuSN3HBwYt+UHonDI0Q3scBlkMydF/hTUpP3jafL+6zWHfgSNIfhUg5iGNvliTakVKkRu2Ic4xWdCzuf30tXk/IFX3q0I+gk6JOZ2UzU87ZnmCcAeeOkEyw3g7X9eJViQzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WP3+kOa3; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WP3+kOa3" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-abb88d2b67eso46775166b.0 for ; Mon, 24 Feb 2025 01:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740389415; x=1740994215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HLX8/NM8OxV+h6FP7c/FoaB9RiQlmNSOqyds5cH+az8=; b=WP3+kOa3qKe8+UYYjUoFCs9Z84Eads58NGDKV9RV4vAk3toT+ZmwDXkWKTLF6sJ+4x 8wtiwCBea60W8RnvD+uLtsYYG+cjbQ+NjTqPNMgm7hynP66Ytdc3O+KXSDbT7v5VuDcR fM4Hdg430vlALMvaweNLhJXkptWSAwZU3f+9CET/J2SjXKT85phxZHCkdPGhwgj/nDgH tnc9FYsl3ws8REsVLuJx3PcFhFXh4BTi1khQ27gvRGC2e3z3lHgijkOyX6mDmO9vhu7U UEhq2cUGRIsNzuh7BM7s4yTbJXVNiRUROhiKsKrxs/o7JedTlxkXV4/DnBEzfEZdxPst c7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740389415; x=1740994215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLX8/NM8OxV+h6FP7c/FoaB9RiQlmNSOqyds5cH+az8=; b=nY7TTFLk9ZQoxyGCAUpN9wcjKkDkT1z1vRG+jsPpPBpT1v9qLgcy59Xv6aXwjz4nxJ ZzLSRr8XPu3R8hI0a7N/zaO1y8hmFvf6RnRqgBJFu5sKdjVGWU6jzIpp/LTXy+zjWSn+ t5zPtEbyt0mP1tZ4UJC3eHzEGrlASbGGTmLLgaw26LufPh/xIcyBeFiQGJ9NzUWAK6X4 ebx/9s/HtATfATUJQkl0MYmDbG5v7DCawTGd2JyIvxf9Hs3nhkShRZsCuDJAoQLpValW ccJJVO50vd/iEOBgt7RgZ6iGVUnFu6+5rQZYgRi/2oByA20hJOy9Caz6GFXmYEzrozTG majA== X-Forwarded-Encrypted: i=1; AJvYcCVSR2JSJtB/T3BkT1xl6D+IR/iKaeCd8WxOD2pBv0M5iwtL/ow5NlsPVEb9QYjQY0M9Cs9qpmA0Gg1i7g==@vger.kernel.org X-Gm-Message-State: AOJu0Yy9nRRxps5Im44SaXXXTUPhYAg8vft92MB2UiLON2CfzTYsx9hC gBIEsol5nGIuHSQ0DsBQCwmLfNUV24INQRLh2cMKiQ4JOplSpdL8 X-Gm-Gg: ASbGncsgoV4p1HA92N9r4WA6xlS9lAx2YbwNXDXFKKu64J7S3UnA80Zj192s/VwM4qz 8PTk74MipIc8H34I6+jFqZR1xtEn69AkTge4jI2XT1k0abTbmuRPZ4xRe5eaR+QYUpuJq8SEaYx kmFso7PVUM+iYG5iRuys2vuVkcYWYJ6rJFKsFFFyAMWYy9rhdyEuZ70AVzT/rmGfPchGn4cm05n 4ZhIxUc+RfvfR9brUCHyqmVaihzwQFRM4xrcaEqr+La4/WZ4T8zGjL1w3Cg8pIfKaUIj93DW2se vZqd1ZZMxreXSCyzeI7R2aczshvlyD5GaEdd2JdCgltz2gJQ5BzTzrQ3kHxnd/yAlWU6KwRp X-Google-Smtp-Source: AGHT+IFKSl+K6Z7qlMaI6GrBCAiX2Y+x+CxhBcBRGWjUmiwW5Ec/V+BJGDkkC7pIWqISid2WD5xn7Q== X-Received: by 2002:a17:907:608f:b0:ab7:5fcd:d4d5 with SMTP id a640c23a62f3a-abc09bd169dmr465665466b.8.1740389415455; Mon, 24 Feb 2025 01:30:15 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abba4b9ee98sm1416668666b.167.2025.02.24.01.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 01:30:15 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, anssi.hannula@gmail.com, linux-input@vger.kernel.org Subject: [PATCH 3/3] HID: pidff: Compute INFINITE value instead of using hardcoded 0xffff Date: Mon, 24 Feb 2025 10:30:09 +0100 Message-ID: <20250224093009.1831811-4-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> References: <20250224093009.1831811-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As per USB PID standard: INFINITE - Referrers to the maximum value of a range. i.e. if in an 8 bit unsigned field the value of 255 would indicate INFINITE. Detecting 0xffff (U16_MAX) is still important as we MIGHT get this value as infinite from some native software as 0 was never actually defined in Linux' FF api as the infinite value. I'm working on it though. Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 74b033a4ac1b..a614438e43bd 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -283,8 +283,9 @@ static void pidff_set_duration(struct pidff_usage *usage, u16 duration) if (duration == FF_INFINITE) duration = PID_INFINITE; + /* PID defines INFINITE as the max possible value for duration field */ if (duration == PID_INFINITE) { - usage->value[0] = PID_INFINITE; + usage->value[0] = (1U << usage->field->report_size) - 1; return; }