From patchwork Mon Feb 24 13:03:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Felipe Takao Hirata X-Patchwork-Id: 13987997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F120C021A4 for ; Mon, 24 Feb 2025 13:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE4B26B007B; Mon, 24 Feb 2025 08:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B94616B0083; Mon, 24 Feb 2025 08:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5BEB6B0085; Mon, 24 Feb 2025 08:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 896A96B007B for ; Mon, 24 Feb 2025 08:03:53 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 236F9B6A95 for ; Mon, 24 Feb 2025 13:03:52 +0000 (UTC) X-FDA: 83154855504.20.1943DE5 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 2DE94C0032 for ; Mon, 24 Feb 2025 13:03:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="BeRc/ItV"; spf=pass (imf28.hostedemail.com: domain of leo.fthirata@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=leo.fthirata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740402230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=K2yGA1NhGbMJI9b6zgvWTEkXn51K+UPXbLwr9O6ldtY=; b=Vn1l0AFHIU3KiW+RB4BBQ2WLk7MjLb14fXthjBb03mXWHlPXG1uQN3OFejIdPk/UU/nvXr /CnjmEoyGXG1tIVChmx3UxC9vPDH0fJP5B71B70wQ2EZ0D6tGq02biS1+OnhDE+poy83Ei ZlURVXfmkuOAy9EynOV2yOLD/gmny0k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="BeRc/ItV"; spf=pass (imf28.hostedemail.com: domain of leo.fthirata@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=leo.fthirata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740402230; a=rsa-sha256; cv=none; b=tKwiwLaQwt6VrFnvGwId/lAElLsrQip9+2hX5y+Xniut2DGq1SZvch1II4gCBR8yAdEAa7 eGLjsMWtqhPi0JWiMjodhW4q+9MtcM1ehFxAfSDPOTrrAyjrOuzqgyFAgDPjLHfdTQpPWc iVv3PzY2jpbi9tKwnKVmG3fRcR09mpk= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-220c4159f87so59016215ad.0 for ; Mon, 24 Feb 2025 05:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740402229; x=1741007029; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K2yGA1NhGbMJI9b6zgvWTEkXn51K+UPXbLwr9O6ldtY=; b=BeRc/ItVvezZzWTOL8u/eO0GkC0E/rG/y53XlnhAitH2yTDiOL2XzUIzrwYms5oWlF lXn1UI1nroR6iTLmatIF/VZl3BTXbTmdSWbznNFA9egSmCA3MKoltEHSknxM/Nk7eh6M j5i/8GihErWifFG/sHD3jBendXkFyLzrsbHdOZNebycDO1WpSYhUtgdakaodO8EMBnLK fG/NtEu8Um8oNncfHnLZVrMUSrh12NiHEhCQP4zKyJhCIWBhpQHE6O5xIDDZkxj6I+HI VDp8aGAH8VqSPD2wl2LeMRIIJ1Pme4EfopurEeYlEMCaIUP0sn60rvir+t9eVnlGcLoW Mr3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740402229; x=1741007029; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K2yGA1NhGbMJI9b6zgvWTEkXn51K+UPXbLwr9O6ldtY=; b=gQ2/IVh+1CxF1vazUtON0aExt1msRAldnP1gkUDuZ4ii88IjA32X9XYQXSQFoesemA Z5vo0K2CZG0TfKYl/a0bzDZflQMhX66k2hsWLBUO1ZSLedOLyyAe8bQmzM7POTWyKNZT qQELbXxZGPT7CIzEl62mrLBlyehjWEO8/heCi6Vpk0Ne5jCIzJO4DoqXSNEH/+6AJLZi IE/YTH3BZ7A1zYrL5XXXE/wvHkOptVH1KURoymuMf84PWWsJwKfB03EqWYuBP3IrxY2n Su1IFN/ddFCUVFr4yFujlBruStdvHeVINnMyMvjk1JRwFzfrvc2ShQLB087wG2TQvyBV NUqg== X-Forwarded-Encrypted: i=1; AJvYcCXMn+jAOuC1cz7KVGeOmL2wQU/6PII3qPq1Um6Xb53PMEz9l7+h5nYAgaYIDNVyQTSEuER4muoEfQ==@kvack.org X-Gm-Message-State: AOJu0YyxkQUGVRECJhgYzd+1dP2bZuG5GGbZrxtaYUiguc6kZqW28MK/ 0NBjsnlyWXlUetH2ti+VKTZxO5vwSBOlaZEinJWxjMscD8MFpeXP X-Gm-Gg: ASbGncs/MeocBRENZ9B4VZsOSya1lidNe6oBUNj/VMpcZK5cl6WvjDW+DjNPl+UtXFl IH95PyKnakaEyp70foB8niZGBaW8XUd0+7hbaqE1D3f7F0z8/1VNputMmwFWdZhmt+lDvx2rFJk VLvNSoN6gD+NZV8h13eHtyf/P3ESXukWgOsSMqPb7MoN10mCVyLqIX9FWJG5FH+CdHZtVd7LbOk I7ry6QY8SS9Y6e/BFWklO/FnZ4WmAf72XmMk6tPw1TWyYV7WLJoge+FaX9bZf3gXAb/n2Pw5pPH MYjjWET8jH5vOfp7Bgs5 X-Google-Smtp-Source: AGHT+IGgDwE3drF3XPiR4PgO0QiIq/gzYst8UaIiUyo9KJCwD6vSvTrQUc35zV8OFRAWRZHDZB7oIw== X-Received: by 2002:a17:903:32c5:b0:21f:658b:8ed5 with SMTP id d9443c01a7336-2219ff30c91mr211707465ad.6.1740402228768; Mon, 24 Feb 2025 05:03:48 -0800 (PST) Received: from dev.. ([2804:14d:887:95a9:942:b4ba:d811:bd8e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d53491besm180097185ad.14.2025.02.24.05.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 05:03:48 -0800 (PST) From: Leonardo Felipe Takao Hirata X-Google-Original-From: Leonardo Felipe Takao Hirata To: david@redhat.com, osalvador@suse.de, shuah@kernel.org Cc: Leonardo Felipe Takao Hirata , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH] selftests/memory-hotplug: debugging improvement Date: Mon, 24 Feb 2025 10:03:00 -0300 Message-ID: <20250224130341.10613-1-leofthirata@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 2DE94C0032 X-Stat-Signature: 34a8bso4x37gyeopjzi557bwgx8s5hj1 X-Rspamd-Server: rspam03 X-HE-Tag: 1740402229-896067 X-HE-Meta: U2FsdGVkX198E7IPTkquDn90cxVrroQ6Ctpqnux/iWmQWDb7xF3Z1DaIRLqdlnXRHH1XpW+Fpenkg4msgIBYxWDcQzDmsr2nPfSlS1ijNtUXB1R0JXtdrv7rFb/b7E+Tb2NdqjgEznDpmbDxPSvPDocO2VHDWLeub71/E8tm37Q4Zl4Le/HewlzIqBW5YWn4iDGuQyztTM4ZJGelQ9cYX3UguCdj7MPAVKeAn0bnS/thMKeZhtT5e3Y0qdClLrteuzDfCzoJB1oRekXZ58C/AlWAUtisbUUxuBQz06KDbDBnwpos/5Rh6W4t8YHbuPi6xmFjAOFHycNkuS+UeOHM0f+tAxwPtEq5XBTF2pJzms8XN/THCqhCp3L2C4NyHj+LWo9+2U9thoKGWyQ5EITwhK3x6i0Im5Yo1Qsc34kNd0sARVVC/LF2j6rZSgsuVT3vfmICVEw07jmIaDlGaSue6XRs7IqlLYIh5vBqSC6DSkmrnL4VmOoaLapIGECo1Oz2zAfU4xMOyRx1XMIxHvlkOlx72amKCKJMFuCjrFlIvrAH/219x3LyWFHuCxWNO2fw3L1cr/dDnLOmKntrQMN785mi/hgHZ2U4qchhzsSV2afGi4dbR9of9SDY3fLXdtqYZX9Y2wQEwzbtc0YNJITvqTgTcR9ySuWvZW8k/FL2TEbt64JTbgy479Y3jl6DkVSmjTKxqzlJcms5cx97wG/ENmjjeHNWdKHgUPhcM7+0djBP3Gwr3zZMNU+ceIxEVGew9pRH82rScfDoczownavvuocmIiBY6J3dkFC8qq6qadcxKLd9z19o9dVNscsZMYmY5begQqq6XvGw6+WEgLxpa35hgKxjn557vJ0yUZAY961ELiw5smg0pf+Db4a7v8rzFgeQdI/0bTVHAk2RBcuvpJ1MQpwWkQ11v9jEh9mm5LRx+QxtGfuRNYOI6ZbYaX/ouXK2ljHokA081hqjIHU lDfVNgGl oOQvt5CGdMqhEZqRqJmqoHyGiUOMzLQn4ZL9vgCNUCGWoQhkZvlPc+HySbWZ4SdHMB+3W29YNCClMGXFvz4fuQlARiI9whjT8KXJ8wO1KM0fwTreIBgdag3DCvMaEUkVqNJn9vMaWZMhRQCPaW1QHHGyWBVYHrZw4Y9CW952EhwN2XRI0x6GP9w3kn/DdrR86/LKGeqlNLozoRotmqHWQsUsQbuRzo2v3Fnl5k4mwpIpoANJssmbBq1iJ8pM8GO9dNF5MKWT3viz0g9R3PiyMdOeqShpaTCZhDUzuYaFlgxcMuNuoh1J6oYfd907grlb0n2FTZENnY6cHzJmeZzP1Ta9aiqk6X0vpBlbPPF42fbK4hPgqY2HVkawWkcrRV/1B5DU+Vte7hrHRQwIRzUBSnUd5D6xPVicORxIl X-Bogosity: Ham, tests=bogofilter, spamicity=0.196374, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Formats testing messages to improve debugging: - Inserts alignment tabs with printf for testing results - Changes messages to improve readability and understanding Signed-off-by: Leonardo Felipe Takao Hirata --- .../memory-hotplug/mem-on-off-test.sh | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh index 611be86eaf3d..7a2eea366c1b 100755 --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh @@ -143,6 +143,11 @@ online_all_offline_memory() done } +print_status() +{ + printf '\t\t%-37s %12s\n' "$1" "$2" +} + error=-12 priority=0 # Run with default of ratio=2 for Kselftest run @@ -184,16 +189,16 @@ echo "Test scope: $ratio% hotplug memory" # Online all hot-pluggable memory # hotpluggable_num=`hotpluggable_offline_memory | wc -l` -echo -e "\t online all hot-pluggable memory in offline state:" +echo -e "Changing all OFFLINE hot-pluggable memory blocks to ONLINE:\n" if [ "$hotpluggable_num" -gt 0 ]; then for memory in `hotpluggable_offline_memory`; do - echo "offline->online memory$memory" + echo -e "\t\tOFFLINE -> ONLINE memory block ($memory)" if ! online_memory_expect_success $memory; then retval=1 fi done else - echo -e "\t\t SKIPPED - no hot-pluggable memory in offline state" + echo -e "\t\t SKIPPED - no hot-pluggable memory in OFFLINE state" fi # @@ -201,16 +206,16 @@ fi # hotpluggable_num=`hotpluggable_online_memory | wc -l` target=`echo "a=$hotpluggable_num*$ratio; if ( a%100 ) a/100+1 else a/100" | bc` -echo -e "\t offline $ratio% hot-pluggable memory in online state" -echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):" +echo -e "\nOFFLINE $ratio% hot-pluggable memory in ONLINE state ($target memory block(s))" +echo -e "Changing $target out of $hotpluggable_num OFFLINE memory block(s) to ONLINE:\n" for memory in `hotpluggable_online_memory`; do if [ "$target" -gt 0 ]; then - echo "online->offline memory$memory" + tmp="ONLINE -> OFFLINE memory block (${memory})" if offline_memory_expect_success $memory &>/dev/null; then target=$(($target - 1)) - echo "-> Success" + print_status "$tmp" "[SUCCESS]" else - echo "-> Failure" + print_status "$tmp" "[FAILURE]" fi fi done