From patchwork Mon Feb 24 13:36:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13988062 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B576286340; Mon, 24 Feb 2025 13:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404226; cv=none; b=PsIBmA63x32i1TYoYCUacvpTf7iSdOpJM56QuswCv0MNX/JHWHz4IL8gV5GW5sVcdBxtk4jmw7ONcxMIoZBai2pZKg8GrXNo6X+o+FbSTTFpkjA17hGF503GJOqRPJAREt6l6qYgwMxRvSFPQDFII1WRtexxqx3PGf9Q1fyIH1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404226; c=relaxed/simple; bh=9bv/BkfKEIv9oVjGUQsKqnEbdHXpyR6xGX9zMJD+pwE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qNIQgfRQxpJzOIKRw6eugWI5nxvcKBnbdspjIbA0QfWSaCeaNi9ez+f0AvmPV7qkXbH5GGfdnT3wjMk/jUyBjxKlLuLCZn6qQL6u8LQ2DN5Mqv+01MGEh/8WMHgKILjePlnW+13W2ZS/9PTbguEtNiu/z4H9lu8Tm2WDDyOki34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EdtVjHcT; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EdtVjHcT" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-546210287c1so4589900e87.2; Mon, 24 Feb 2025 05:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740404223; x=1741009023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wdv8+U0yij4s1XgNV9ma7hVlOv6Caj6S/IBFLz/1n8s=; b=EdtVjHcTsN7lq5u4hj5DeTtAIzekBw3lZFiqSh4VnVaXrb9l0oWyxEGiEPjU0E01ps Dz3obP4TEqZThzHATEoX+XhGnw7li3vpRHA/KiiognY94LTb6C/XsSeBCpjEU3TRdbmw skFP+cmi6N6MX2BFPBTrgIyA1lc3hOHmk8B4qA0zWsDEZlbWcII+HImXy8gGQxPLpx4m 6HXM5xNGK2eGyvKbJ57Rk6Og3BCIkqKX6AABHewDTJQHtCEjRclUl0KTeB3DPMrwUvXP B8Ry+gUpXz2CAqsSsoj7OsgFeS2vFjEX39Kep2j1qYYdxbMYmviSZDmUh/hNAvOgxbHG UT0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740404223; x=1741009023; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wdv8+U0yij4s1XgNV9ma7hVlOv6Caj6S/IBFLz/1n8s=; b=mnQcZt6Ifw33rfpplTCjSal/UX5lkQseuRPdM9fCFOJTYKkFHs82WBKLWQzrkGCZHZ hVWyz1HbPehbHSGZ5D5/XaiPEldk2C8yCwigghaeRPfEFHLCjw0V1vNg38n58n7a1euk kZwBjBpOcoC9jZlQhQLrgwjjwXuYhcwowMpnCOqvVFb9naT0E+17BxTrPOkV1LmGpZkS 1HNnuVzqD8+ayny37rljxl9u/Ui3fLo3plnAbuwCrHzNi9ZTuoqIzAEPE1M/FfDTVjpF uQaV1fFSQGoBRFLYNBjUM7mNr14D6mpH1gdqW3I+zri5kttB1N+rdYmcoTEyCKufNohW tzvA== X-Forwarded-Encrypted: i=1; AJvYcCUxtP2h0TmBfG6o3zAlzyM3rETGRBXgagGsyYOWGFS/VhKFct61tfhWXzZPcI1SMzup2QxDDzfLozPicX8=@vger.kernel.org X-Gm-Message-State: AOJu0YwyDDKajMvtqwqjcNoweZxqD0kc5jdtc3EEp9mnLX92CoSND+8P YYipvkO0lqBZsmaIb5jEQBZdHdgW6+dMv+8nWGBtliHjF/FhVPrs X-Gm-Gg: ASbGncs9DH8ih2P8FVs8FhiUWrbzqA+H3Gr1cOtjzlyQVEKXCGDpPATXxg1TyBXuqPq Cio4QKScIYxJQzsyYcwrafq5vVLI0Ux0TAkODs6MP7xpPeKaNybqRwC+FwGLTCrifELoGbKOjxI AGjQqQbeD17eBPCv4HXlyAGXDVS1piDUDQBHzm11vNcXMmU0xQIpgHqS9AnGCOZT/02HxAfQGaN EXY/g3O5zUJiYtGS2adBLgXts21aBwqqzRay24fyH0Fuz1QN5l7Ra0NSEVek56UkOQAayD2gK9i l9e/3+4YVhfemUR+kT1b4Q== X-Google-Smtp-Source: AGHT+IF9V3z7jyWk2I52KnpgJLgcQTTOJI1gAW4Nz7p5BXjwR8EeAlRkkNBmXL0VdG/Lj6HLGi4t4g== X-Received: by 2002:a05:6512:1244:b0:545:ee3:f3cd with SMTP id 2adb3069b0e04-5483912fd2dmr4529859e87.9.1740404222396; Mon, 24 Feb 2025 05:37:02 -0800 (PST) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5461eb04602sm2424799e87.68.2025.02.24.05.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 05:37:01 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: "Paul E . McKenney" , Boqun Feng Cc: RCU , LKML , Frederic Weisbecker , Cheung Wall , Neeraj upadhyay , Joel Fernandes , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH v2 1/3] rcutorture: Allow a negative value for nfakewriters Date: Mon, 24 Feb 2025 14:36:57 +0100 Message-Id: <20250224133659.879074-1-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Currently "nfakewriters" parameter can be set to any value but there is no possibility to adjust it automatically based on how many CPUs a system has where a test is run on. To address this, if the "nfakewriters" is set to negative it will be adjusted to num_online_cpus() during torture initialization. Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Paul E. McKenney --- kernel/rcu/rcutorture.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index d98b3bd6d91f..f376262532ce 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -148,6 +148,7 @@ MODULE_PARM_DESC(torture_type, "Type of RCU to torture (rcu, srcu, ...)"); static int nrealnocbers; static int nrealreaders; +static int nrealfakewriters; static struct task_struct *writer_task; static struct task_struct **fakewriter_tasks; static struct task_struct **reader_tasks; @@ -1763,7 +1764,7 @@ rcu_torture_fakewriter(void *arg) do { torture_hrtimeout_jiffies(torture_random(&rand) % 10, &rand); if (cur_ops->cb_barrier != NULL && - torture_random(&rand) % (nfakewriters * 8) == 0) { + torture_random(&rand) % (nrealfakewriters * 8) == 0) { cur_ops->cb_barrier(); } else { switch (synctype[torture_random(&rand) % nsynctypes]) { @@ -2568,7 +2569,7 @@ rcu_torture_print_module_parms(struct rcu_torture_ops *cur_ops, const char *tag) "nocbs_nthreads=%d nocbs_toggle=%d " "test_nmis=%d " "preempt_duration=%d preempt_interval=%d\n", - torture_type, tag, nrealreaders, nfakewriters, + torture_type, tag, nrealreaders, nrealfakewriters, stat_interval, verbose, test_no_idle_hz, shuffle_interval, stutter, irqreader, fqs_duration, fqs_holdoff, fqs_stutter, test_boost, cur_ops->can_boost, @@ -3644,7 +3645,7 @@ rcu_torture_cleanup(void) rcu_torture_reader_mbchk = NULL; if (fakewriter_tasks) { - for (i = 0; i < nfakewriters; i++) + for (i = 0; i < nrealfakewriters; i++) torture_stop_kthread(rcu_torture_fakewriter, fakewriter_tasks[i]); kfree(fakewriter_tasks); @@ -4066,6 +4067,14 @@ rcu_torture_init(void) rcu_torture_init_srcu_lockdep(); + if (nfakewriters >= 0) { + nrealfakewriters = nfakewriters; + } else { + nrealfakewriters = num_online_cpus() - 2 - nfakewriters; + if (nrealfakewriters <= 0) + nrealfakewriters = 1; + } + if (nreaders >= 0) { nrealreaders = nreaders; } else { @@ -4122,8 +4131,9 @@ rcu_torture_init(void) writer_task); if (torture_init_error(firsterr)) goto unwind; - if (nfakewriters > 0) { - fakewriter_tasks = kcalloc(nfakewriters, + + if (nrealfakewriters > 0) { + fakewriter_tasks = kcalloc(nrealfakewriters, sizeof(fakewriter_tasks[0]), GFP_KERNEL); if (fakewriter_tasks == NULL) { @@ -4132,7 +4142,7 @@ rcu_torture_init(void) goto unwind; } } - for (i = 0; i < nfakewriters; i++) { + for (i = 0; i < nrealfakewriters; i++) { firsterr = torture_create_kthread(rcu_torture_fakewriter, NULL, fakewriter_tasks[i]); if (torture_init_error(firsterr)) From patchwork Mon Feb 24 13:36:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13988063 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A7823372B; Mon, 24 Feb 2025 13:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404227; cv=none; b=U8bNNhBbEZd9QmXLh1UZoXhn/bHIEomF9u/43x36Uuti0NtOrdtNJ60n+cvWrxTasNcLL2OuNoU9WyxD4VVxUILTmUGPN4t5FFtaC8pzi1cCqOJWw8FdPKOhSYke7rKwQEVSjLSxKGrWfXHfFx1YcvigcFLskR382VmFntShruc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404227; c=relaxed/simple; bh=sCuflgFUh/45tShowZi3ebLKyBuj3+UPfLcwZ/CRsbA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lEoIjLwygYsNUODBNaXw0UpJvTXRkxeRCYqqcilvZfVRweZ3PR6QhGtFV+wsSN+vsJHPomW+crCD5CQGWAVoFA53d0s/W/OfihVje/DKT3rd/n+SqmRtw3ZVd1j1ulnWSJtmUdzXTwr1ntkhjF95iFEegk9JhuifrA7lFscx/84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VPIrE9Xi; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VPIrE9Xi" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5461a485aa2so4070270e87.2; Mon, 24 Feb 2025 05:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740404224; x=1741009024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c8AAp3JK/Rr4QIILXNDXheLWWABxs1/zeQyrDjipUFA=; b=VPIrE9XiL6arzN31khRKKuebcVJKd3Q2arUoTkfu9N2entfBjVKSchxGcoVyG4xPR3 QEuO+jWU94nYpPpl9an25ptTjMCNvTfFoLK4WUZPYC3EkKVPsB8E8kjp+aMxksVENXS7 QqC7kOFTAa5dHLjPGa+KTB1k0nk8dddIdvhxFw4BflUPNF72kNRMi34Kv2gUsyPHI++T nZBzszAzT2tzfQJi06/N56v2HJW2JO+06tVxSv2m+KoRSl0/wtvsznfZ6/SX+Hx1ET5r OBuAaVGTInI4WlXDTiKhk+CMdvvubQDrt8eN8vvvdbqKR5KkcKZThQcMWBauflTRpduf C6/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740404224; x=1741009024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c8AAp3JK/Rr4QIILXNDXheLWWABxs1/zeQyrDjipUFA=; b=Nvk+jD0tJYFPrP/aI9tEdVmBnXeTQwQ3OXL9RAo/eybVR//5+WMuSagaOerMc6gHjm Biuo0m6eMFYbjsFfz+VNs8TqdcG7gwpTslHrmQyK+4pEbkf90bxKKXbTV7BUtwYyYeAM y7nXVH3AZmAm3VOMMsHs7hB/4c/XlI8L/wgOg3HOSs75za3GIAag3dXrDc3BCN2Au+EZ mkYkqSPM0tMTKO2Ud35CTOpbUmb5Fa34umhlEziz5b4klimkb0KCdpyE6CVbC/MV+S64 PGVmzS3AIA9Lwile7ufv0YfX6VkYKvMKZWDUPouEMElRiNLH8bmEUExjXcE00S2lgZzE uh2w== X-Forwarded-Encrypted: i=1; AJvYcCWs22oCpiDDf7UJXZZ0Nih2lqCHb34VRTyy7E187Z1tarpqbQ0qQvBudYrjj3WJTHIGBNrQxYjepavu/Z0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3MuJy4qe4eisq2b4sqk+vKRwWp0rF0N90NRsa+v9CmsrInKqN 5liIL04mhxtn3G+0O2UApG3y8d+NXsIxfr5IX4fHqgIDU1da060u X-Gm-Gg: ASbGnctsdonHROPrKacfDUv3y7JpHJRqAOh4PrnDx9kOlzMZa7OhwD+sm+w6xjy4a7b 0UZTdfzAc8ZociEgBVHWyBA35eIXYUZ+pmwFnnFTacK0BdWkvllTWA7oL1KCXOQBugCnYLABZBJ 6GdVFOjCPL1T7751QxB012+H7+shi4NJpslI3E+dlbrQOJoVIkPH6usGIeAiZ3GryDnOiN/lupF Ucu5aoDYfApDNMnywPYsijrquozEhPshCzUUUz1F4wj+gbJrO0KNl2dGJmCqj6ZZYgYYaKo4n+9 vOCPHOSGxGM3N6S37m8ZDg== X-Google-Smtp-Source: AGHT+IGvb98xMoDkb16VRq6TsgBIQrDI2uk9mhm0fZPOnTDrl8Z4JPeyRurmrJrI3hJdfJKilNKaAw== X-Received: by 2002:a05:6512:3b97:b0:545:d70:1d1c with SMTP id 2adb3069b0e04-54838ee2993mr5839079e87.11.1740404223297; Mon, 24 Feb 2025 05:37:03 -0800 (PST) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5461eb04602sm2424799e87.68.2025.02.24.05.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 05:37:02 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: "Paul E . McKenney" , Boqun Feng Cc: RCU , LKML , Frederic Weisbecker , Cheung Wall , Neeraj upadhyay , Joel Fernandes , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH v2 2/3] rcu: Update TREE05.boot to test normal synchronize_rcu() Date: Mon, 24 Feb 2025 14:36:58 +0100 Message-Id: <20250224133659.879074-2-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250224133659.879074-1-urezki@gmail.com> References: <20250224133659.879074-1-urezki@gmail.com> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add extra parameters for rcutorture module. One is the "nfakewriters" which is set -1. There will be created number of test-kthreads which correspond to number of CPUs in a test system. Those threads randomly invoke synchronize_rcu() call. Apart of that "rcu_normal" is set to 1, because it is specifically for a normal synchronize_rcu() testing, also a newly added parameter which is "rcu_normal_wake_from_gp" is set to 1 also. That prevents interaction with other callbacks in a system. Reviewed-by: Paul E. McKenney Signed-off-by: Uladzislau Rezki (Sony) --- tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot index c419cac233ee..54f5c9053474 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot +++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE05.boot @@ -2,3 +2,9 @@ rcutree.gp_preinit_delay=3 rcutree.gp_init_delay=3 rcutree.gp_cleanup_delay=3 rcupdate.rcu_self_test=1 + +# This part is for synchronize_rcu() testing +rcutorture.nfakewriters=-1 +rcutorture.gp_sync=1 +rcupdate.rcu_normal=1 +rcutree.rcu_normal_wake_from_gp=1 From patchwork Mon Feb 24 13:36:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13988064 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCA9243369; Mon, 24 Feb 2025 13:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404228; cv=none; b=bfrCEseliYz28fsPKI/X1miV+fhaoJC12OT4VGzgPlDhWLdrViKOz97ajH8Tmo9q2FWPXUO4JLlmCK5viQkIbfH8OQP3lFLZE+qHrI4sKW7TCNrxHOXdS91HPYYLkMbsRM1ucq3qny7dK7KEFhEqKGePyz6M4bRDnZuwgoPNg/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740404228; c=relaxed/simple; bh=pkWTCsEa6IS0VHokuR+HUR9w20hV7VXpFtsdVk2ZZGM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tvlA1UzcFT+nFuLuTOw+xkPqfuxco1yUTCqoNNmqg31PJcjLFGAzJZiM+9yp9AygoyBq/O7h5TEhsSEWyn5w3YJUW4XfrdxpsBCp8l0+yfv2PPyk00daNizf7dvvmeMX5xFYB+1Jc6nS8aj3wFQTod/3gyIF/JplBivgfyMXF1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ar7Zk7hU; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ar7Zk7hU" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5484fa1401cso253023e87.1; Mon, 24 Feb 2025 05:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740404224; x=1741009024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/eXqFdLeZVXSPcLMt09mytyCkKizYEWoEdvJ/UL21oQ=; b=Ar7Zk7hUGXlKBxQ3mK5/tBXxB1oNeKFfpbJdW4Tg4OUTNyUly6uDKjzOtzc1afRafZ gH2HfHXnbgr7MMPPLQHJ8QzwamRUM8vT0oIAC2QmXghJcelwhKh03RVk86Rpvpth2aLF yjofy1wBl5iidijsTd+ssUTJEKlKx/MfEpekiWnW91Hh3k0aTuoso5qFPiFXH1XifLtU D+S2A82ZAhb3sXcGns8klc1Fjx0o5NtORXFEaTuAvVGB/A4uyyrZVdwYmUKl2CCy8OLV eg6xevzKUEchVlTRtokgl5dPg7GABdAx5tkUopMDzD70hqRgegIO+6I/8fcLLun9q/jN 4mQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740404224; x=1741009024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/eXqFdLeZVXSPcLMt09mytyCkKizYEWoEdvJ/UL21oQ=; b=xRILiaT68aqTnAviqcLzNnjRMB9rn/0Q3sbtLnKUT9y5BVQCLUzFKm3YE4IBWhlTtj qfl7AEQv/2WqmqfvIPtckguPn+zlIm9wSbvOT7zzhtuQCaYP+mEX/sHBr1NQvSyHUHmI lqXtkQ4oNLpqosZHzmWbjNu1JrlI5qdr4gZdIq7wN7/dNjRQnY1KzjzsGhkazsVZsfG7 FEvNGLokSA+45+Y6CGhpGDU8socOdkG7VIXZs6pJM3BrsN5s3384POP6l+/B93H0JZIR SEAb0S5Ivx8dKoS1hkcPeup1fWp3cQwhT33+7vNhqIcIL5XAFlvUMwKj1AC5A8OZgQkd hDqA== X-Forwarded-Encrypted: i=1; AJvYcCUnwTHXd+WDbpDfEtlGvkDVDp8mc1FpD3axNSnwlmLsuKplu7fI9sXsIBbUoQCNalmwkZ86vH8H7hcirmw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9OesregyCr0HPXDvQkshFjCG2kp/DyzAhEhE8VF14jgG1pkkn wihveBXb8uW4TNo/nfSJ5tLBs0G57tvKfoWFsaYXRpL1hx/kOzsmJjyKb6Ee X-Gm-Gg: ASbGncvUJb+n0pryUlPGHOhQLtx8bIPlgVtoULlwJYt9PHJknXVgD1nUjzYcoXJQuZ2 6k+aUJO33IBXQYq7CCFj9P87H5l96lQsFVw+aSIpyjFIBqfa3ZWtlbluaqZUiNDO2Bc48yYP/h1 OBdLrZyEGFmS/smJGfVjZw6ITIHnBqVK4gb3oeeMAL5JlaQpKbaE690vci48lptQcnAPX0yxD+g twCHVQuz/pvJsBTb7CwKlqKCl8j73hQS7ID/wxHhmYqGrNClp6RgnriaVbpC4/GJttTRZaxiXFA KnhIMkP+yirarccIYixq6w== X-Google-Smtp-Source: AGHT+IEMNu2VKNIuFdLI6GuahDFVwEebQB5DscNSdB27lRmLJ/IUbTndD683WMxhKdu++b3WWV9Jhw== X-Received: by 2002:a05:6512:108f:b0:545:27af:f2e4 with SMTP id 2adb3069b0e04-54838ee8c9fmr5685320e87.18.1740404224221; Mon, 24 Feb 2025 05:37:04 -0800 (PST) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5461eb04602sm2424799e87.68.2025.02.24.05.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 05:37:03 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: "Paul E . McKenney" , Boqun Feng Cc: RCU , LKML , Frederic Weisbecker , Cheung Wall , Neeraj upadhyay , Joel Fernandes , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH v2 3/3] rcu: Use _full() API to debug synchronize_rcu() Date: Mon, 24 Feb 2025 14:36:59 +0100 Message-Id: <20250224133659.879074-3-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250224133659.879074-1-urezki@gmail.com> References: <20250224133659.879074-1-urezki@gmail.com> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Switch for using of get_state_synchronize_rcu_full() and poll_state_synchronize_rcu_full() pair for debug a normal synchronize_rcu() call. Just using "not" full APIs to identify if a grace period is passed or not might lead to a false kernel splat. Link: https://lore.kernel.org/lkml/Z5ikQeVmVdsWQrdD@pc636/T/ Fixes: 988f569ae041 ("rcu: Reduce synchronize_rcu() latency") Reported-by: cheung wall Signed-off-by: Uladzislau Rezki (Sony) --- include/linux/rcupdate_wait.h | 4 ++++ kernel/rcu/tree.c | 8 +++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/linux/rcupdate_wait.h b/include/linux/rcupdate_wait.h index f9bed3d3f78d..a16fc2a9a7d7 100644 --- a/include/linux/rcupdate_wait.h +++ b/include/linux/rcupdate_wait.h @@ -16,6 +16,10 @@ struct rcu_synchronize { struct rcu_head head; struct completion completion; +#ifdef CONFIG_PROVE_RCU + /* This is for testing. */ + struct rcu_gp_oldstate oldstate; +#endif }; void wakeme_after_rcu(struct rcu_head *head); diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 8625f616c65a..48384fa2eaeb 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1632,12 +1632,10 @@ static void rcu_sr_normal_complete(struct llist_node *node) { struct rcu_synchronize *rs = container_of( (struct rcu_head *) node, struct rcu_synchronize, head); - unsigned long oldstate = (unsigned long) rs->head.func; WARN_ONCE(IS_ENABLED(CONFIG_PROVE_RCU) && - !poll_state_synchronize_rcu(oldstate), - "A full grace period is not passed yet: %lu", - rcu_seq_diff(get_state_synchronize_rcu(), oldstate)); + !poll_state_synchronize_rcu_full(&rs->oldstate), + "A full grace period is not passed yet!\n"); /* Finally. */ complete(&rs->completion); @@ -3247,7 +3245,7 @@ static void synchronize_rcu_normal(void) * snapshot before adding a request. */ if (IS_ENABLED(CONFIG_PROVE_RCU)) - rs.head.func = (void *) get_state_synchronize_rcu(); + get_state_synchronize_rcu_full(&rs.oldstate); rcu_sr_normal_add_req(&rs);