From patchwork Mon Feb 24 14:07:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13988247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB541C021BB for ; Mon, 24 Feb 2025 14:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A23B6B007B; Mon, 24 Feb 2025 09:11:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7598E6B0088; Mon, 24 Feb 2025 09:11:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619186B0089; Mon, 24 Feb 2025 09:11:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 44ADE6B007B for ; Mon, 24 Feb 2025 09:11:33 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC756B69EB for ; Mon, 24 Feb 2025 14:11:32 +0000 (UTC) X-FDA: 83155026024.24.B6FDD9F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id CFDE940007 for ; Mon, 24 Feb 2025 14:11:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k1QOofvF; spf=pass (imf04.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740406290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=YnPZgU9Z+hHif0E3kPl74H7ZUDIe5NfHOMLzqWP0xDQ=; b=nK3FOR3BcKgji3CYUziGZZR9EHBwb1HqE83cC1BqR5PFf3zdWdrRCsOohiHVpM7iICwUGM KF+lADwRd9Bq9U/2SKpRR9+EVZTJNEYnZKRHn4oIqm1DGq6qBTG1PTrufY2VSxoCposuwB 871hRm2pMHeCvS6t1gOPNVPB6nwEm5M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k1QOofvF; spf=pass (imf04.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740406291; a=rsa-sha256; cv=none; b=4iNNC/3RvnPJUpIns9KrDJoooXuVg7HnPI0AHJmaFS51THc9GOHWuT+cV6qI85xHzqWOn9 M5m7T0aGqbGcVX8T8pFc8kmClgliRxBLMOTOgiz2aIvh8QBQdBN2Riy4WBeddksNPzMmcm JrCZ6QqFVrPrn99HQc5p/xxYD+zzXhQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7A1725C6DF8; Mon, 24 Feb 2025 14:10:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA91BC4CED6; Mon, 24 Feb 2025 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740406289; bh=RQdVPYUPxuE56GoXKqcHw8DD6iWVMqD2pu1GTpiafhg=; h=From:To:Cc:Subject:Date:From; b=k1QOofvF8qjd2BhDzXY2lzFSfZlTU9nlFLKbhztRIolki5vp1ZsqoSpykZpnUqg4h Xm3rODsno22eUymgUI3L+5AHfYvAbGb4xZR0l5YTQ+lHi8BGw0OBZK/6fXnRq0Tzgc ZTmdprto+vVRrEbVylp27siCaZBgWkZfo/V8o+ulgS1jRC3y3rLyO8bnRklcB86KTi SmUq6V3UUhQqMx8wLv/LDC3jMR98zO+Lj8Teyi/o7kK4lIo0izD/fCQtoQqsRqyO4J qZv5pmWzlDsk6294meAG4ELObwdo4eA0Unk1VSiYHGmEHUKCIK0vDMFhuoNr4jpyFi CT7KwdiCTaBJg== From: Arnd Bergmann To: Andrew Morton , Nathan Chancellor , Frank van der Linden Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , David Hildenbrand , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 1/2] mm, cma: fix 32-bit warning Date: Mon, 24 Feb 2025 15:07:35 +0100 Message-Id: <20250224141120.1240534-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: no7j9yhiwro4qzndemuqtcbhns9uezxw X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CFDE940007 X-HE-Tag: 1740406290-56572 X-HE-Meta: U2FsdGVkX1/vgWWIu66ZQb0jhsgddJUhhyJXuutbOfncwcN/myVF1MOp30GWpaJ5VIb4s9Xfmfz/sbu2WChwzlkwri4oEXdbNMUbbdgIzrE1on3XGLHN+oN9asacBI0OdgDg++2Dks0DE3SjHbiE1jCpHpyoWeFuTz8nwcSFXqoSzREEAwi7VmW+HRALwfvEFX6kdMKi9VOsbLMy0s/sJ+ctgt5iT56j3fvGuWbOX1r7AdePrxjw6WUsuUduN3p0QDoWW1/l4EKJuk+dJ68aT70xNCDx6R+qJaL7fYS2UyJ3DkflkucvR0uVnPiGQ76w9CMZu4abhtWs+2wfVtlX9xsLrr+v2KoQHK3Hfuk8+b9+MNEGyO9E/HZHfS4QGSrWBuGWXn+Zv4kMpF7gmdYqZ4lbPS4RiCkSZuL13cV37MlV3DfqXdPIl5T6yfe6dEMRl5li9en/8GcWJ38WXlIdvLD0Jc9tJU5Dh0L7fUTtJBFmGkY91BDeU/IoehGfAQ6mHkOMQ1IO1mP1yccJPeb4faNPsK04xPY/f4U6Ep8EgEslrRcWGsckwANWFcVcz/XQzK00+155+jhv7udFQDuDElotlWU/vbfUb5coNN+Y/dNcrgjRRnn2QMSB0T3iZL8BtF0lSh0kyDvq2FLom4odKWYjxE+lVSWt0Js0Nh1I/ugzJEgzwY06IXsGNOu4UYi7maZiZPWvsbseHRWWCoICULiL4n5TMuXmpszO9UdKPXewpUI0bDFp+P86lO1H4sphWnVr9iXOdBY66WPbVt9Vu+3fIjAs/j08PtQcV20la/JYwBm2KI1GgspK6w8N88t6dBbSmcFkdqBBU4ANwDnuzr4cKEygzhK0K4a4PYgY2a+G6x9bSElxikt6QvuM29YwAp5IC9pue8AfvEFrfHiPWMyVSBDpMD519d510BZLxGGfzNchcGOb3IGN0HPEwS0mCpLJZ66GipQKw3nrgHv Z0zPnNYG QjKjWwf0fiGMg5s5DTWKN/bk6dXDWe99tHlHK+j+Mm1X5Xa3Z9PZkCPKSUY4/WyHDgVECD+9xMaOvrDWwBdkfogZd37zdIna6uuKQa21Go8aPwwjNgjaMTpltUchus57hGy1Q3ZRs7FJwxSGFnH1DGrMLMoBsxSVmnFlJi1OTI0agmMelnfAIXAKQUCbfiYkpM1lKOPdKDxZfMtrEMMigBSf1JITRzhvwTm/acrJo+GT26F5z4H9vjDX519taEWBcqRovHDdg41NlvHnnsRan6SWLg6NdIgNg0ZNw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann clang warns about certain always-true conditions, like this one on 32-bit builds: mm/cma.c:420:13: error: result of comparison of constant 4294967296 with expression of type 'phys_addr_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare] 420 | if (start < SZ_4G) | ~~~~~ ^ ~~~~~ Replace this one with an equivalent expression that does not cause a warning. Fixes: 4765deffa0f7 ("mm, cma: support multiple contiguous ranges, if requested") Signed-off-by: Arnd Bergmann Acked-by: David Hildenbrand Reviewed-by: Frank van der Linden --- mm/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/cma.c b/mm/cma.c index 34a4df29af72..ef0206c0f16d 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -417,7 +417,7 @@ int __init cma_declare_contiguous_multi(phys_addr_t total_size, * Create a list of ranges above 4G, largest range first. */ for_each_free_mem_range(i, nid, MEMBLOCK_NONE, &start, &end, NULL) { - if (start < SZ_4G) + if (upper_32_bits(start) == 0) continue; start = ALIGN(start, align); From patchwork Mon Feb 24 14:07:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13988248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FDDC021A4 for ; Mon, 24 Feb 2025 14:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9297B6B0089; Mon, 24 Feb 2025 09:11:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8FD6B008A; Mon, 24 Feb 2025 09:11:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A0C56B008C; Mon, 24 Feb 2025 09:11:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55C226B0089 for ; Mon, 24 Feb 2025 09:11:49 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 01F9E1A151A for ; Mon, 24 Feb 2025 14:11:48 +0000 (UTC) X-FDA: 83155026738.02.A2B49BE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 2041D1C0008 for ; Mon, 24 Feb 2025 14:11:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pP8fuQDN; spf=pass (imf21.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740406307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m/G4LBJ9xYQ92gbzL04F/uv90H72omaXhsvvGCjR0gA=; b=66G9PbQCD5CBXU13ZBAIu7KNbHezWPIirBK4/Vv5qnprWsMzHuvHHlNZH7NSOrVIQH0+R2 YW4W1sK8hFagF9VXYoZ+eYet/FO2POXmLqIfszZHb8YV2wpYmztZIddEts4RLwqMuY2O2B LgGMzWrH7HumpP9qtVZmlIBprytkB0A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pP8fuQDN; spf=pass (imf21.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740406307; a=rsa-sha256; cv=none; b=DwIVVyMDEOhYiedB+Wxg7OTZ5rMDILHV7GhMo74xYDqb+Z3NasAMqvp6p1fRRYnSF11va+ ICj4gXeuKUhKZIR8ufk6cyf0cpndKMb4NfE5ds8G0z8HI1xeic1Tq8agmMmsk5oQI0+ILG U5BU9Ngr5QPsG83ykY+AnoyRA7qB+VQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 374785C6E65; Mon, 24 Feb 2025 14:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AA9BC4CEEA; Mon, 24 Feb 2025 14:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740406305; bh=P+1IoKn7bZFna+Dvhn79iyuL/7QRo0aRpzyot3u6GY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pP8fuQDNB6qo4ZApjtvIMekhCQWKdasRAz6o4PmCHpMKk77semF4l01rB60J8L+PA gfX5Sjbfaxm0fxN185wvji8xUFMXdO82x79T/Zymi/gMXk+GEnuL36E/f3SXucicd/ 7DRAHddWWINUkGHn51BTAzazfoKQeYOrXNg24foCXAK59Xddey5u5YcPbLjhuuC2wd TTId/UcA52x8RxOObRoMdQQ8z4DxczZgjO5sBqbp5/wv4PhDSeTlTQGKuf/FfZKpRK fxBbIswIpZI1NHJXFNncWvfseTOCfWEn2Ng1NvEU0SteU7uKr35Kizqjw6jJJLono1 gypPYWuz/H4JA== From: Arnd Bergmann To: Andrew Morton , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Frank van der Linden , David Hildenbrand , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 2/2] mm, cma: use literal printf format string Date: Mon, 24 Feb 2025 15:07:36 +0100 Message-Id: <20250224141120.1240534-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250224141120.1240534-1-arnd@kernel.org> References: <20250224141120.1240534-1-arnd@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2041D1C0008 X-Stat-Signature: 6gaexmomjf44k78du4t1btas84kka5ky X-HE-Tag: 1740406306-848971 X-HE-Meta: U2FsdGVkX1+JkmbkQBL47KOff00/E0ni3lOVdByAtMsJlySW6/FMVz3vEIhqPkWS/AEZBLUcoQ4aJH62VBYqg+ATzSVYl9l7zdTJ9U3nNZLLPlQ6+B6kMGY78Ugz3Ue75WEz09uF90veXMOH4IoTxUe7ZcMQo+7xh+Kxl++6NS2vQl09MXs54rSDb/ONfcTRJi99IfQFpUOLXQwnDX+/RaNbVMBU87x1RKsHlAIkDCCdDZKlg0SizA/Q5c5G4TqjnnfiynWgcEIB36HzS9EmQo/8PCfIZB7TTjyJjERQEJaiAqWjMVWpBwP8KXdyPz59hKwAge5mjSsb7H3mGUp/3577RXDpXl3v5Ucb9dDIQmNxDkL8Hy/0ndrnLyNWYOBzZwbH3tK+jqo/MaKpwVCC4i11D3rukbw65YYhhQ4ji5wp45oMDKbv8zhKbCzAo7gUo69bD+0OwIE3JfiKJTB+P8cxcAerwxzT+lfpI4BNyXuvuw6rrII5mgTsefa9xUr3q5NKuHMzxJMXXHhi4EMOaHR/ha+7tnsIB0yvcZ8ZfqTzUeja+SlUblDPcjdgWgXrjGuiimah1ymEhi6Y3VN4oAYVXXHuwNLP/2sKfjM2cvZEipKS21ZU5gtUCWT/FKqLKvcT+XiZKq2F1HjmkT+ny/ZGWUmeCARzAVvsrtzX7u/2Bc/zgc8UoEy4eLGQ6Epa5Els2e3EUiqfllpCePQdr7vofvgwUg56eXOj+823BQAxF7+t6YmyO8UolVRf73pshvNqUMUUQRH71WvWdYpIkGCNPx0DY4s8NJPJT62TqlAPmS2UH21IxCXi9DUi7gNi91a+6KZszLfuPvt1fDzUDW9LCHmTOQ+sie24bvVV85gUHlnVxgOClWDXEx0WdbpelonxNTrWsHXgA945M9oACUJg/GFk3atVALoQr82OoUj9FAx9cSHfIxn1g9kyIuPlgt4kv66UKLhe5J48Eat S6feJwhj IOasXBl+xY3nzPh4KGQKy99q4fpOC5DxRnFk+rzNvg9qrJltNlezNvi5aRpTi70DXp07FY7M1w8ZTGo9NrwCzEb7Unu3Tw+q9zrvrDj0K8LGeq9R48ibxC+vaeuFH9CzrbSElmYolfmpb+cqWmcBVqBaepnLjnrv9Do/2oGgHAI9nGq08IitTprrnEMK3DqLp9ugGnIPG2pk4O9Fxe0/qGRMM4K9lgRRrN0E+icfhDeVvLACn8KikfdeHTgwYCgoPCGMzWZSEuOhJsq65zUPYOxTDBxLd1pnsLc/m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann Using a variable string as a printf format can be a security issue that clang warns about when extra warnings are enabled: mm/cma.c:239:37: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] 239 | snprintf(cma->name, CMA_MAX_NAME, name); | ^~~~ This one does not appear to be a security issue since the string is not user controlled, but it's better to avoid the warning. Use "%s" as the format instead and just pass the name as the argument. Signed-off-by: Arnd Bergmann Acked-by: David Hildenbrand Reviewed-by: Frank van der Linden --- mm/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/cma.c b/mm/cma.c index ef0206c0f16d..09322b8284bd 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -236,7 +236,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size, cma_area_count++; if (name) - snprintf(cma->name, CMA_MAX_NAME, name); + snprintf(cma->name, CMA_MAX_NAME, "%s", name); else snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count);