From patchwork Mon Feb 24 15:12:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13988343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDC3C021A4 for ; Mon, 24 Feb 2025 15:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0CC36B007B; Mon, 24 Feb 2025 10:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABCCC6B0082; Mon, 24 Feb 2025 10:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 986A76B0083; Mon, 24 Feb 2025 10:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B79A6B007B for ; Mon, 24 Feb 2025 10:12:34 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36BBEB6B57 for ; Mon, 24 Feb 2025 15:12:34 +0000 (UTC) X-FDA: 83155179828.21.10D84CE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 664E840019 for ; Mon, 24 Feb 2025 15:12:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uRJA0yzC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740409952; a=rsa-sha256; cv=none; b=W4SfYFCZ5cxZUYGo7ALoyYIVp2PNC80lIIxRuMCe0fdbjg3L74ihOA14cRJLaTU3CMqTVk Yi2pOw5sp8vM29x7XngGhaX4Ea8VLeIfDjzEZQrx7ecEtDFh0jKccu906cL2LczeZpI6PP ukITh6KiQTYRB24eZRxgQZZv3Qg8VJk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uRJA0yzC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740409952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=o6Xl/+0DRU+k66riUCOxFg+s3uDKCEWz3Www6Vaym5A=; b=7axLMU+wTULvUnQimBkUa6yevNKY9idgsS0JMxBZsQffOmDHmG+x9SUF75sqyYVuB1QIGY O4ZyDzTZpQSaMyNphV8gp6qw0wJamIGlOY0TlkrLVYefBvMJHDk/BSLIaKTBF61YCudfuk iwzZ2p9mvecvER0y9lgoZu9QpY0deUQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4504A5C5552; Mon, 24 Feb 2025 15:11:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5094FC4CED6; Mon, 24 Feb 2025 15:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740409950; bh=QOXTNbclUJQiLSqfGNlJQuuPZknq5UFrWgldy6ueUKE=; h=From:To:Cc:Subject:Date:From; b=uRJA0yzCNnI6P44jCX7BHj5JkZSAV+28+swusa/E90doZzREjCo3EZo8fQz8/8P7S 9LUseBelDaix555oTQ8JpEc6E6q1hlwYYRAd/6AmWCWA9FBdMbbr6ZYSDaifp+LSwB ZVndzQMpJ5DDtaaobXM9mYgj/fAVcSemHcgJPiqlqVHPIaKdCcjDNXm3v1re6Bim4I ngmqRS1fqxnADMGSEKaqvBo0c5gdugbXM0np/D6Nm9UBkWwY6pJKXPN7c9imJA65gm 9uZ+A9BC9w7ylF8CfYhhl5ZjYXsdN4S2emOUMoFgRyn6wigjx8UsrndtOrLzugTNBJ LkVgvJ6Rgj5Pw== From: Arnd Bergmann To: Andrew Morton , Kees Cook , Brian Mak Cc: Arnd Bergmann , David Hildenbrand , Peter Xu , Jason Gunthorpe , John Hubbard , Steve Sistare , Vivek Kasireddy , Yang Shi , Christophe Leroy , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: unhide get_dump_page() function Date: Mon, 24 Feb 2025 16:12:21 +0100 Message-Id: <20250224151225.3637934-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 664E840019 X-Rspamd-Server: rspam12 X-Stat-Signature: gyh1uasug4kpy81gamdxycer414afe1z X-HE-Tag: 1740409952-21429 X-HE-Meta: U2FsdGVkX199Ob2CU0w4/vjHuvlZqWvcGxvQ8qx/fz6lwISnp4MalJr8p3ou9w1buOxBvB27TQDQGaLZVmzK3Z4HjslpuEpnMbsDHHVsbOaVTRbjmkUxmimHygRU0NHW+v4/Hz9tZCZ+tuyCjs7iNWuao0ImX26MfF6Ot9vW6bN071a6LR9fqqONT2IhGGWcZLobnYBRMdHGigqwrEEnkmb/NzQWdO0X0Te0PWnNX0bBEl0iiBB9o9cKw7UTUhCjk4XtVuKLVBi/1rpt1w6uSVuavwTpCmU2seKVflF/eB3+fR/5Dq1Rq+WVNxvtO2JsK9QSeTJxb84ra8/lDYlFFAAC41wew68eLg/gfpdE1dOGsHF0f9ZvUvF4ENYZbHNwH7d9DN6W+KrXkSk466PmGAGq1bzgz/NiQYDko3gUeqGJsgEGV9Mg7TjeXRtnzfxNF7vUBuCUrEeLEosvR5JhAnnSEnJrJs6n6qXOICwNGWFqaIrZiGdgANjBSReYVlMP8cUDxJOgtedkwMlYDKMJfIKDJwYVqwDgUB2C4Vq7aRH5vBSRVj9DQVRvEv6KQyFMWS7JnDVvwHUI6C+msFnfr4BY4uqmjWdlYIItLn7Co6vNvqEL+qnn5spmHdYELz77xxYF0WkGD4uio0IdEfRaEiD/3Gf844ddkaJN+AsPFxsvAYJW7gTGdvAQLgCVzOJN5meswa86Mj9q5iDdCCARHJDsHkOaA4oUVqYkRKmhxdSbllXwY+CKS86UWP0I0PKXl5ILTAyOa5InhAAzV1zwsHl+kc3gefsYp9nseyGeMP9ROUQt9XxOxSiLkc7bnTybkfu2WynYAcBPHq3TrqgycccqxRxAJaLiZrOpQI0ZOT00RSCzjDOvLt0Z3sCoJSDDT+sKtAI4JpGJs4Nm0c8O7tsrsFlFUyLTqk1T1wjeWVyVNRwxgO063TdGDSZwLoIQMqLNzB87v5YwXbLcNq1 JdKbgWvj 8JfcSGPSlMeszyTS4bOPQuwYyeeAs/nlQHV2vpUDLTcs8b2XgCZ758EGKFMe3+NHWEM3CZcg8p2GHilNwPawbj7OkCtiswBJutcKCW4kGlbZScd+bSNUysfycepW28KcFCAcrOQUwwUxq00gwBBG2rQcWOtxsvvgoZpkVwpR9s92j3mkeYYQqbdevc5wKQhYOTk5KfdHssAas7OjftfKGFpoyO8NsWWR/cPuCkU34X2RkjsLB05iRVHpL86feepNSWyf4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann The definition of get_dump_page() is guarded by CONFIG_ELF_CORE, but the caller has now moved into a function that is built based on CONFIG_COREDUMP, which leads to a possible link failure: ld.lld-21: error: undefined symbol: get_dump_page >>> referenced by coredump.c >>> fs/coredump.o:(dump_vma_snapshot) in archive vmlinux.a Change the #ifdef block around the definition to match the caller. In practice there is very little difference, as setting COREDUMP but not ELF_CORE is not useful. Fixes: ff41385709f0 ("coredump: Only sort VMAs when truncating or core_sort_vma sysctl is set") Signed-off-by: Arnd Bergmann --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index d846c0ce41d6..15d6d7b5df1d 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2266,7 +2266,7 @@ EXPORT_SYMBOL(fault_in_readable); * * Called without mmap_lock (takes and releases the mmap_lock by itself). */ -#ifdef CONFIG_ELF_CORE +#ifdef CONFIG_COREDUMP struct page *get_dump_page(unsigned long addr, int *locked) { struct page *page; @@ -2276,7 +2276,7 @@ struct page *get_dump_page(unsigned long addr, int *locked) FOLL_FORCE | FOLL_DUMP | FOLL_GET); return (ret == 1) ? page : NULL; } -#endif /* CONFIG_ELF_CORE */ +#endif /* CONFIG_COREDUMP */ #ifdef CONFIG_MIGRATION