From patchwork Tue Feb 25 03:45:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989218 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B42C021BC for ; Tue, 25 Feb 2025 03:46:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B50A6B0085; Mon, 24 Feb 2025 22:46:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 664CE280002; Mon, 24 Feb 2025 22:46:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52CBD280001; Mon, 24 Feb 2025 22:46:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 35FB56B0085 for ; Mon, 24 Feb 2025 22:46:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BA26F1C7E25 for ; Tue, 25 Feb 2025 03:46:31 +0000 (UTC) X-FDA: 83157079782.07.7D1521A Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf27.hostedemail.com (Postfix) with ESMTP id E77B040008 for ; Tue, 25 Feb 2025 03:46:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Sj4Vbr65; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=fGUN/VkHQKeU/dJTOx4ehsbLfly4Dw2ABprkzKhXxY5CvIltAEy7DwL06naFj1JpZIvVK6 tOMsmjzHu4vPLruwj0xdUShCWI+Of3FB4RN+8290G4QO9UoeRTYqFQBJuZ94IiT5XO8G+n Di9Y6UNCAjVsmJGjIheaZ6xofMFgcg0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Sj4Vbr65; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455190; a=rsa-sha256; cv=none; b=MNLS+api8sGOSegx4G9BsFkTxpsowb/P8ngUj4Ps4XLxro8Mx92RIewoJxTuk3SFTNxPDn b+/9hR1mBQ1JDWWRDUu1J2ut48oduHjWIVRDqwS3rq2xYXR/BKhm/ueYmX+NgfEBNk/+eh u63i510px7BxrTGUpP3/pKhVaEZ8nIQ= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220bff984a0so108512015ad.3 for ; Mon, 24 Feb 2025 19:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455189; x=1741059989; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=Sj4Vbr65cua7QDj5D4wwWmJl3hFUxW4emqc/JiXf9VTbzKnu+sdaE3u2wKCfp5GMCH bMkCS7smOv3GBde7K534++/JsYqZS63aKeBcdS+lXSGB4TTylJg9ToZqgL4llrFRYC14 hHWl+zqci3/iwy5an4hdp8pz16NFian0kxk0ONsL+a9ywz49A9RHVJ0DjrX+g540XEuB OifGv2eWKEgF6tML+A3t6Kr8/YubIe7XswN6jwtOZLZUj8AJf1VZ0t3+Gmqt+wcn3Se8 Z+OtZCeasD0zM5LDn5SAMdC3P2cggAhKiZG3TKvG3Rw84S0pa2IiUjjBqI45JmgQTTx+ HH9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455189; x=1741059989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=tUdjwC9aVt8bIjATRErBLbhQvqe8Vhl6qIrg908Ks8KSQLBKhG63xxA4IKxIoHH7IJ wnrs5/y/mTAP35JTn01+8yiufEPMl0J5peUKPDL1C0Azx4Tb4mHIAfpirXmHcP6xIX5b 6Edz5Oj8uSNwXEzANC867Ad3HU0yarCUSXWaT6E5eaHMfUlw9X0Vf45ZA46yBVE56BCP 9cFw9gMZVcER5nsSAyG7lOJREC06x5+/gjEXuQmQ4fR/ZRC3PRYMzIlPqOBUIa0skVDy tOZHkIsC65UsTFukXDnmhozT5lw/5JjYpIsOFmj7VC3cT2NEp03j6bgXNevvkxsC0Ora 2ncA== X-Gm-Message-State: AOJu0Yy+l1ouLGQcoHkutVtjebnJkXtA8+Hn6Ny53fdxDiniRhAGIYNS l3P5aZPHsKf7Tw/EGdSLzm5j9VthCFjpeOaNkirfAnaKLrJf7EvMohIYlvS8PvM= X-Gm-Gg: ASbGncvJx3t8EsgJGGGvRyPTg8dz+tKFOQSzYPrICpua8vf5UII6Jg8Bo8rHjBK/fx3 MqbZErnJnmlloBeCt7ZH/IbZ22tPf1caIm+DQV4aXpcZK5TVY4rtvxy5b3nq0NsB8alUqXGZyUK wGM4Yzx2J4MTZbK+FjITzR9d5u7lrEzY09073oOc7cFxwYKq2+ImP62CGQtF1AdLB5YanCaxZ/5 E40ZuzR7LE5eHjaUv3kQUbDSm/vp8cRrrwQiwLHyxiNJfFtlh6DoG6gi+lASKXtqhSzxQOVEFsx RGIuk2/ry4qZOKlO6eVpnxYqua1m+T/u1f3uRjGR9eSWLw3gWC+ILywFxmIR8w3Eiw== X-Google-Smtp-Source: AGHT+IGBfXw23ytiI6FvQDqnu6HA+6X81xKlY5Cdi/AJkyrR2YGvsG8wye6vZ+K3tNu1qHLJYKOiEg== X-Received: by 2002:a05:6a00:22c9:b0:731:771:38f2 with SMTP id d2e1a72fcca58-734790de607mr3427312b3a.8.1740455188892; Mon, 24 Feb 2025 19:46:28 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:46:28 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 1/6] mm: pgtable: make generic tlb_remove_table() use struct ptdesc Date: Tue, 25 Feb 2025 11:45:51 +0800 Message-Id: <5be8c3ab7bd68510bf0db4cf84010f4dfe372917.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E77B040008 X-Stat-Signature: emaa94c33pbxjjqua33pptti4g3n1zqc X-Rspamd-Server: rspam03 X-HE-Tag: 1740455189-957054 X-HE-Meta: U2FsdGVkX18WQJdSBnBdAlDQQExnXgJqmVRluAyrJHwh9bFRze+6AkJ30OyLdQcLutWb7usjwC9dXxXwnhN6fyPBDruU9em7PyCB3P8SRvqxeIYyUp3WbzxsR1EMsvRjQs+1qIpZ8qsxnLFRM+lyKdPdCbi45l0GaWJmKAXAqFVLk17cCRnKHB6ONx1PjrEc/WkUrcdP1jDzOk/13qKfZ3YMnne9NNX0n8IIdPqC5tbDUZ817Zn4lngkU+rU+ohy/6c7abGdIBL4BJa41eyXBjFgiF8YctCMvSu3/G6FL6R34yIE879jwU8btHf/Jjp3jlnJn0+/QQpkgvLqL+uGEVkxVmTyHfjrvrx69QHljgdhFEIK5jgeIkPDkirdvhBwVthq83FULqnsEXAAhs/n/qvS2vb2loMYjb912R0n78GX/l2yFce1lHfE4yn+5lQd7zqCXAsos5k/9LEc2YUB+xDC4IjiLVXYk/duR4t78Bji5RMW40vw+qtEwKuIslf5ELCxZFPGLWmNomLq/FRo6GqEJlY0NrMWnwFCUriMsDVRxoZC1MI5P9DupYfQf8+k84qlmlD88iXj7xSr4DEfKq7h/F1Ft6E7m8VtgHBp5VB3RPfJx8pDb5ecwI1cHRV91fiKOJ+xJJC5yWSmHtnD07BFh6gID0RbZrw7mGI1U212j50XHYuAbsy+rm2srP/nCQlKDNNp6RXtguDqYRs4Bu5+uhgzv4uwatBDjcwzqo5gpNEfZZvP4BpqKJvpeD7WC+G1TmhVWx1IIoQ4Frgy/XIN5JeUAZoi6idk/noV5mH5EVEY0U42VnslpRQYUImUqbR1qZzen9N9WPOvMC2L8gIRphIPYLvbuxPO2teoMYrBbwmVlTKjpdgzRfLFiIXQ/MNz/L4D0w65wa3iu5PF27xDSYgeCk0HYoja5McK5EZ2Z2oyYoMnA4Uq2BUJmM9fzFSMKpDJ5BGmpflYHVe t3SCjSKa 31XeveehRhF261jAqF3vaFBytqWEid8jy2xX3ka67hpnB3D06xrI2h3K7tRuORtZTwJETStG9lFUMgpazqcNGTNMWaEAKnPsQv4dPD4ahktCJrlPUU10HL+cvrVGkZsmPnEqaW9cuECXpEVlQ9WZMrUL4NJ93Entb4K5/sfUMF2tkj9qpWD3pop+CJBYG31uKw04VnU7woZCpSH2bssmZK5VrPDnE0xxb6wqK5C4hcwaGCHwOP8pMs8thNfsjrVg0hWlPWsKX8Os5LdMRz7Hm3kFkKeoY8NFjuurudylueV2U+DnFSFYu0kFTTp2N0i8Mc673XRTZvfwHFu9qnKGrYXnxeWNtncIfcM3iCkpxt5yYiOKuOainIHxY6NUBQIyikUUdI0BPNt5OuZ+1+OUw+oR0dO4pviqZgTe0fn9wC5DE4L4/y9iRCcn1XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now only arm will call tlb_remove_ptdesc()/tlb_remove_table() when CONFIG_MMU_GATHER_TABLE_FREE is disabled. In this case, the type of the table parameter is actually struct ptdesc * instead of struct page *. Since struct ptdesc still overlaps with struct page and has not been separated from it, forcing the table parameter to struct page * will not cause any problems at this time. But this is definitely incorrect and needs to be fixed. So just like the generic __tlb_remove_table(), let generic tlb_remove_table() use struct ptdesc by default when CONFIG_MMU_GATHER_TABLE_FREE is disabled. Signed-off-by: Qi Zheng Reviewed-by: Kevin Brodsky --- include/asm-generic/tlb.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index b35b36fa7aabf..54f579750c8e5 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -232,10 +232,10 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page); */ static inline void tlb_remove_table(struct mmu_gather *tlb, void *table) { - struct page *page = (struct page *)table; + struct ptdesc *ptdesc = (struct ptdesc *)table; - pagetable_dtor(page_ptdesc(page)); - tlb_remove_page(tlb, page); + pagetable_dtor(ptdesc); + tlb_remove_page(tlb, ptdesc_page(ptdesc)); } #endif /* CONFIG_MMU_GATHER_TABLE_FREE */ From patchwork Tue Feb 25 03:45:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C5EC021BC for ; Tue, 25 Feb 2025 03:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5077A280001; Mon, 24 Feb 2025 22:46:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DE536B008A; Mon, 24 Feb 2025 22:46:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37EB3280001; Mon, 24 Feb 2025 22:46:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B6026B0089 for ; Mon, 24 Feb 2025 22:46:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C497DC0878 for ; Tue, 25 Feb 2025 03:46:41 +0000 (UTC) X-FDA: 83157080202.04.1EF4806 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf16.hostedemail.com (Postfix) with ESMTP id EB1F218000D for ; Tue, 25 Feb 2025 03:46:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XpkozpK4; spf=pass (imf16.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8OP1Tf7pAaJ4pNIvAgoQe1yrsY5TH0xWN2DlWHIb0tQ=; b=bO4vL27Ab9f/Z4+0j/aiwz6gQiuvhdNGrBepCwekCKv4kYjHHS4bLlkFO4JL76rptTdxTb CZrU/+czNR/jsAqu6KbO5Q991KF0oZ4POWZSDJW8YJk90dJzGR4zOdlDsAdH9Kzt1/+mRz nVinb/HGDehhTR8Jo0amivUH++mTDYs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XpkozpK4; spf=pass (imf16.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455200; a=rsa-sha256; cv=none; b=oWBhwLMwkZmZxznq5CEMDNMQRS2ZjVaPjZNGbPxo0hqr25u1tNyY316ogvKG+0pVonv5bg 3LHUaQ+foeusivzmKbMdlLWx6d/HeLdgXfu1VHKGI+4P0g0A70BxY0O0uo6xWV25QD9/nc EgBqRAA8JJ9xxbFmdfhggUsIEv5VvdQ= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-221050f3f00so115931485ad.2 for ; Mon, 24 Feb 2025 19:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455199; x=1741059999; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8OP1Tf7pAaJ4pNIvAgoQe1yrsY5TH0xWN2DlWHIb0tQ=; b=XpkozpK4Ns0esyhJNTo3pUVZeJxxIGBhCOwg1OdR+sB0wT0iTb3THr8VCjA+yd/72w bE7MsZNHuLYUGcLYfYFndAw0aG+8PXzwVHq9ActvJxeBWEDsnh+Fw+2oI7lOcK5ibaIZ 23GWnIqqBiDArgudNEW+LmyZwU6nrD3NBrj4hYvV4L2tU7QJwGX6af9p6Q6oqaX68WzX 11USP00EWrD4pyJlTL58c1beazSs1W2hntW+85d2BoBH9NwB4c7TPtSLyQD1/4M+Oqvy 5EtVEW0KXbDfjKgo7jWNXO1zjgLteYO5vJ2JiQfK3i7kTPtDyhx6no4YvAfu/N2mNPXP iunw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455199; x=1741059999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8OP1Tf7pAaJ4pNIvAgoQe1yrsY5TH0xWN2DlWHIb0tQ=; b=dRdgzyC2Y66iotelarkeVV9qB1Plx6OfPQMqgbBT09nnpc9VTwmJ3nxhBNchIDe7X1 NsZf/+lIowIMMB+X0UCIY7qJR4Z+RujViwg5iIhgSRiqoHKHNP8TDl4GYyBJRqVpWwJ1 qgO2YSdk7SN/PoplK7aseE0dHCJ2PEkk9iMRgdlhU14TNzBjIqhl9rtGYNxiqCwoi7Md faVynRfTENGE4tWtUPS74Tj+KHkyCb/q6bSYfAJ2BQgyC5lz1VjUL3j0g3TwHdxijmLw W+r08qHYPjJlKJCNct/J8lSqGfgn9tXKWjDWh3255lC78Ws7zszgoWbStxyoFw8VFSAN yj4w== X-Gm-Message-State: AOJu0YxtENJE0PbQy1F6IQlgucKOt7KsPxGYxAOKmd3YrBg7ngDL07Wx sVTtzEyK/c18po2h3iivVfYumN73wGoG68YVhK9PdjiYxWmaFv2ilY39f8jUovo= X-Gm-Gg: ASbGnctD1PPswtNTYZXSWCZDk5b5LKCPViFuVu2G4KcMgxjzatvw3mZ9WMhM+ZMuXwZ NFenN+x0vv1qnJqYAaXkOWqxlkIWDVw8CCYqBKq4zD0Z4gCBHig3Ik6H8qsk5kFUceDy3yXq0s9 WKURmfLY6UEi/Uwf8Zb6Z6xBdqRUPVDpxtXIi3VY+TljgpzhxSBVEcd/vZoXO0tvDQCyvi7I8yI SdGUdyFykR6QWn8NL4ejoeXthSgo7S9m/uqnOK/DjFEIpl5di2nHMiB+hAO1g2kVkMYVLks3xhH bIT9OIWzZ25xb661wQCfE/v4W7BtH7ChSYoipHiVWSaQ74mW2gb/sh3H8Jvi6Mq+Yw== X-Google-Smtp-Source: AGHT+IFHXm4yz9k/q53vQDLsSd2kyUiUDLPeAK4sNAWc/t1WzpyNSO/kW4XJ16gHc0dMjVe/gJ+ItQ== X-Received: by 2002:a05:6a00:230b:b0:734:9cc:a6e4 with SMTP id d2e1a72fcca58-734791ab6bfmr3168643b3a.21.1740455198810; Mon, 24 Feb 2025 19:46:38 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:46:38 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 2/6] mm: pgtable: change pt parameter of tlb_remove_ptdesc() to struct ptdesc * Date: Tue, 25 Feb 2025 11:45:52 +0800 Message-Id: <60bb44299cf2d731df6592e446e7f694054d0dbe.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EB1F218000D X-Stat-Signature: 54js56zx4wde38pybiu66t1opm7grfco X-HE-Tag: 1740455199-84162 X-HE-Meta: U2FsdGVkX18YfJQTE+OJBu5buEwta1ZH2RCS8OJD3ikwGuGWLiKVwV3FA07XLnQyuY/oJo8jvQ59e+gasJbEgW6iQQqF/vlbQRHUsqIU3LIdfCmvuy7QyNCzds1Cd3c9wuHQXNUabIpxAkJHB+m8QCs+/27YaJKLPCyiTPoK6pW1jXEyhKamFKnnt8kJ9/oGMViVnCjHjfK1gQzi6JF0SkF+ArYXotDyovmzKeYEl+XtnX+MwPbNB7Wa9BSyDE/JTY1EWg1HEo+ZXwJWGWSE+RpCf2X+3c9GHwnWG5BmAkWA4TvzhrjDdZaYr/HPFBz3Pgoh7njqtO7UblX/J2NWAb+Z5Zk7OHSDNvXgK0WffXtfNzBvKXk+EkejqbUdpxuVVTWCkESCgH8S05d2+y0aA0zVGXOzxDs5HatsLNekdcFxCkCvRvR0FQK10eTfi7q1a6fQRd0gF5Y1+Ov9ojETjfpVL4Z2qDo379KwEfvV2f/uHeZT56UrsXgoHNp/xWN4tmofkbPVc/cKz83MDG6DbGWpRqnzvCU3sd1QItcjUpGxnynVnP/3TtZI8MGFWbiPU3iDjdOTYG1uYUD8a4ey3OAAL2JYufxoAt/FmMMrQgnfg51GRNu+SsOcMsVz8GRMCcrfkX9coaghkrC013AnvcW6bfjPs4nXJuCmLh2unpe6scGoJRjaYjbG3Ayky8SGBn5MEbPuD5rCn+6z1wtc6NGfhjMx+bG2U66R4cIbmD0EnxJ1TKNu1d5VpxA5USqZiYCT46S7MyJd2x8YBK06+08P8Mj0K4tj3x+HcxkilsoPp3HINFW46C4MeoYIzfrfwCTPKS/Kmz9F9sQGYS6YXXPrwGUUCu9PgkYeJ031Bvbduhx+G6cYX2N8Am3hIKIrYaEIGQqtVNORgvOgZYSdG3wNbPTmkXx7CrLO+cCkhwy4BcFJyShFZ3ZaZ48dEohkkNFIYqSNuMqJZASxM8o lvKpT2vc qbIl/z8ClBzqJOH1Eei8vFqrVIv5toPVQ5vvJIq8QYjHy2VSCf8RZI/J0tgjWt2TNgVRLImXFW+ms3L8kooR27C8i+nPZkKq9C3PRAy6ZtDEYcZXvih6ImuMPbnyMfvDRN9IcLWOOHTYL1UvxlAnpcuyJxwXU47p0nrhqUVe3V7T5uKEQedaP+t/4w/N+LqRvhgpKu74VykruPplbBeBDvtHkOhcvmgDb7/8+WX1fuds1jryXBWYMxLogcGRgIpQl6Mw5+BhdKOdbF58+11BvwJXGchtHwX6b2OUbnRbqWqDCBKMZQmZvSR618tWZOi/q1Ku1It+ZHu0YPs9OM0tefkKhuZm2/MLTNN5ys5YY0OvYoS22PCF6rMqP/L7RIl/sRkSBAxuQDB5JMc3Kb6+nrsnfwWcAT/nkNzIFc6WHkslCYu2EXpYxKBaBs8W611EZcHXs0AfDehDbKifpTBWPoCNQ/HOwur5H3Ub2NN9oQuqPeyw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: All callers of tlb_remove_ptdesc() pass it a pointer of struct ptdesc, so let's change the pt parameter from void * to struct ptdesc * to perform a type safety check. Signed-off-by: Qi Zheng Originally-by: Peter Zijlstra (Intel) Reviewed-by: Kevin Brodsky --- include/asm-generic/tlb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index 54f579750c8e5..18bf499ef8801 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -506,7 +506,7 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) return tlb_remove_page_size(tlb, page, PAGE_SIZE); } -static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) +static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) { tlb_remove_table(tlb, pt); } From patchwork Tue Feb 25 03:45:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D392DC021B2 for ; Tue, 25 Feb 2025 03:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5553B280002; Mon, 24 Feb 2025 22:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 505496B008C; Mon, 24 Feb 2025 22:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CCF4280002; Mon, 24 Feb 2025 22:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1FA1B6B008A for ; Mon, 24 Feb 2025 22:46:52 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C0CF14B825 for ; Tue, 25 Feb 2025 03:46:51 +0000 (UTC) X-FDA: 83157080622.01.A12EA1C Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf17.hostedemail.com (Postfix) with ESMTP id E9D4440009 for ; Tue, 25 Feb 2025 03:46:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AvDl5Kyh; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+WhvhnqTOqnsJRoRSYGkE7Nvf8aJcMBRIuvNZLKTVVg=; b=byz46pn9+JTP2+9ueYDINHWY7+PvwESg+ECmDO6eQP7L1QMBbuQ3Fzx6XzJALAenb6bITb UvnHhg5sAJbAAlJb/HJ7XJdygYcjR4LdqWdaaeKcGNnLBj8j091on1NxI1Pz1/TIYa7IEo qHVLNd5mHHFpgWl3xXCcGOc1wBlIj94= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455210; a=rsa-sha256; cv=none; b=u0ziN84gcrBFyTZlWidu8Psy4h8AdOSRZ18jG9eN+6abrDOiVqyNtbSgDZa+WyJrIIeK2n DkmK17qoJ+aIg9ybu+RBNRqMonH2AWYsa1R7u+wz+8ctJsqZFmmQy1N1pIbbS4y8zuVRfC zxP1dbbdU2mZfjQoEYk/aa477Eptsrk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AvDl5Kyh; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fc291f7ddbso8280923a91.1 for ; Mon, 24 Feb 2025 19:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455209; x=1741060009; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+WhvhnqTOqnsJRoRSYGkE7Nvf8aJcMBRIuvNZLKTVVg=; b=AvDl5KyhJzsyTghUsHLkhsiUAadbLm82vCEmvyM201Vcre62ayP+vmwYr0VGuMclhL 1FVmD6krmzSYje/JNUc20Tj6tGjX1RiXxazzOleLkK5c9Q+r+DmMNDxglJ8PO7quZNII uo/lCFk8yl8RN/8Y1ruh2lYBfiHvW+fw7t4WiKxEhp2gBmPI9od88SDfW+GmHmbNwiqQ QHEhtsji2dUC8nuK9Zc8DD9L+Hah8ZkBGvjYACkQO7ZA/xyPYZYHr549xtOhWBHfeZVs gVucj9jpAxeN78xorh8fXol5WHzcbb//gtdgIYg8AGuY9AOjKtjqUsHDYyQ7i9g3UDc1 sweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455209; x=1741060009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+WhvhnqTOqnsJRoRSYGkE7Nvf8aJcMBRIuvNZLKTVVg=; b=hkjhs2WPLjmAWZBD+F/Lz0odYWTfTb7mluHFzOhM6JMMVOgBxapCXm1iFTUecm68S5 mDJoSHkn4PJ8I1iC1X/pFnH7/L6XL5UUZSkC5oIqsEnH+TsKRzGWMlxe/PVSiDoe4n5O QnRnWo8DLApS36xXgxGwYjDHj6/AZoPrcZPzxfhgBlg5ilvS5eGKoH3G1JQjSe7xwgxH 7RtGI+gVhaq7ZifpFTdlOZBzGySq5fGD+g7TolGFIjemkuNLngARn2rOA300lvzNYWxe e3v6ULi9wwvOjAL/iINz4gLXnbY84yzET1KD+QSZPG/7yY0X092qVimDZ24ATqVfKAzR 5Iog== X-Gm-Message-State: AOJu0Yxb4e+8pMGAkgRWKuiJVopIP12wkGptn08e0RgWh8mS7T3EzL9b ZwzRhiVsoV5GUfUBTxtjapM40MITtFg+irYtubno0W9SIo31uftFlB++ANQEiJk= X-Gm-Gg: ASbGncsUWd1nOaFk+ctIGIIcZu5btQZi1uKAAk89zIEOn6uf6OtR4eTKRw4X74Nsgc+ 6Njj8MqNicLiUehme16EK17LcWnNyR5CiLjUG9l0tF3udt32jJWjKbrM2P4h/E7RijXIY3Ko2F5 KVtkn8y/QpOn0pSCa65yZBMm46MELb2S1yAm25w0CRR2sQBPK6i8cLd+UNC+MbhlYMvXvO/Uclq fDGXekYLtio8HQ1OH1L+cwxWcYOQ/DZ82Te7Cg4PTPvLD+ABChVQahfFUlqIHfNcE0hypCcmtJY nu9m+9PSusEisjQzBEmGeXyRf7SAv/jxNUodFJkCvwwkH+QoarUybrSNFkUw5utbmg== X-Google-Smtp-Source: AGHT+IFoZm5A7KJfLiXXGkFybdFv8MW6FGVkhPNKsRMzkFsrmZE9FMc5jXLgIOhcL2vDMu87N5uJKQ== X-Received: by 2002:a05:6a20:7347:b0:1ee:e16a:cfa4 with SMTP id adf61e73a8af0-1f0fc78fb8fmr2712731637.33.1740455208891; Mon, 24 Feb 2025 19:46:48 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:46:48 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 3/6] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() Date: Tue, 25 Feb 2025 11:45:53 +0800 Message-Id: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E9D4440009 X-Rspamd-Server: rspam07 X-Stat-Signature: wozstmuczse434x3wkakypxosmjik7qt X-HE-Tag: 1740455209-440510 X-HE-Meta: U2FsdGVkX18zg523daIe6y1eP6z78RLWmIdyCesWW/NXSgYeKaCT58b8BwK91JZD92DYAAXzcWqqLvYG3jpsFgXuGQ8RtJrrFaM553PGNIX7TBDs60FpnFjQVK1fFhis2vaZri/aexvvtvCnKZEcy+H8clnaenMemc/aX3fKnEkdDZTxGVk08kxlNtrsapSibYUaYeKl3TefSGKw67+obRlpZIgbkvZu/H4UT3n/HXTtVenfuLIngHQQjKDNQHvlSRdNH6o7ef9glCayvg+uKcQlPzB5UKB1O/n6wFZc3LQ1vSVm/6WNrVuZk1+79Ha02g47FHrITH9Wjw51DfHWgDuYneF7eSNp6koQ9QAF77VcIeeUJdUpRjLKhAMPcbE4fFcp6urRYY37P/GRPzARmOhaIDOJToYgKJIcN+orvgvjD5IKfYhXHqXCb+WiCxM9Ll3ViF5qxwBrSiAjtRx3/7/f7XMv+8EkINcjPLizMELUVS1UDJJjg4Wog7oNQn2p2SJccFQQF+IdMHsPH6p/ZEtSq0pZsS68A0IUWvS394Arx1CGQinOE17B9gHCl/BH9jZyWZQsJqZ2lbLn/TsbyiI3TlF1Io/gkQ+bXA0cI0wzybya6B1byK+7/0CaaaHTeI/m/yHs2VNz219h8VmFlMtP8whzvU22fiicbS59CBlZ0GpE813gU4/74+mE2rnAoRfLEuI8raTGwnhGB779NUQBUm1WW5/LwajQc7UsHRxWrLSCP42RmFd9Rj6BzjwzmTUNDfsLwWBZ0uloXwlJ6MjV/JX/z+oVOVmirAoGfoUNVEzDlBJTuFfZm+DU9XZcDd0rJKtfSKb/Q69BaYyTbDJAn1+xQvaIUzMO1eHAJIeab8mPCFdC4aHMrwbxUHBbkzmyKTlmBEkmeXi+zl5BafORaNYkDpFaWNQDflqsrEKcp9rcijfD0hzQ7K0JcBEN9VvIzlGWTVpfsDNqGlv v8SHqA9W V/In6Nx4alTiVLBp6siNQyNRkDwHpJyrUhgKava+GqK8Et1Qmp9yROM1YVgF7AbI3HlH6Nd8vbxER4X+VJV+1BJvCnusfGjRWSfUgq26NNZ0/k1Ykn1ZkYOp593SoRvUN2MUNnoK7+NvXA9OnsFMs/nA/94Zo6Uka7VS9uT7ML+DoWRTXkv5Pmv9wJhRS9FVpOT1xOv8zFp8jgfF+XGO7SH4PXJjvP3w68zW7qTJR833PRNo6836XXZks0gMzKdC4mydaLKLJetQCSyu1RzRLbXwWLwsKxrm2xPbin0L9XBZhaEK2Q96YTzicKrbZZMEb/Zvo6mKGXcRMqSjPnEwFrU5cLp53rxP0ZKpx5KRoQMGk6T0ZSf/+Hci6CKBljJrbpD3A2O1IMas8fKr6Q+6n+n8wf3zF+IUvIrZK5uZo+UXdEX0N/MzoSZyjxgxdtE6Epn8kjC/RRao0KdTy4GxyWmFAzL3M+ue9hcD1GuuLE/hsNLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of tlb_remove_page()). This is the same as the implementation of tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so convert these architectures to use tlb_remove_ptdesc(). The ultimate goal is to make the architecture only use tlb_remove_ptdesc() or tlb_remove_table() for page table pages. Signed-off-by: Qi Zheng Suggested-by: Peter Zijlstra (Intel) Reviewed-by: Kevin Brodsky --- arch/csky/include/asm/pgalloc.h | 3 +-- arch/hexagon/include/asm/pgalloc.h | 3 +-- arch/loongarch/include/asm/pgalloc.h | 3 +-- arch/m68k/include/asm/sun3_pgalloc.h | 3 +-- arch/mips/include/asm/pgalloc.h | 3 +-- arch/nios2/include/asm/pgalloc.h | 9 ++++----- arch/openrisc/include/asm/pgalloc.h | 3 +-- arch/sh/include/asm/pgalloc.h | 3 +-- arch/um/include/asm/pgalloc.h | 9 +++------ 9 files changed, 14 insertions(+), 25 deletions(-) diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index bf8400c28b5a3..9d2b50265a8d8 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -63,8 +63,7 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) #define __pte_free_tlb(tlb, pte, address) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc(tlb, page_ptdesc(pte)); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) extern void pagetable_init(void); diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index 1ee5f5f157ca7..3d35d2bc42534 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -89,8 +89,7 @@ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, #define __pte_free_tlb(tlb, pte, addr) \ do { \ - pagetable_dtor((page_ptdesc(pte))); \ - tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #endif diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h index 7211dff8c969e..ac026146e7e95 100644 --- a/arch/loongarch/include/asm/pgalloc.h +++ b/arch/loongarch/include/asm/pgalloc.h @@ -57,8 +57,7 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) #define __pte_free_tlb(tlb, pte, address) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 80afc3a187249..ddc24812f1832 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -19,8 +19,7 @@ extern const char bad_pmd_string[]; #define __pte_free_tlb(tlb, pte, addr) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index 26c7a6ede983c..7e73d2f913dd4 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -50,8 +50,7 @@ extern pgd_t *pgd_alloc(struct mm_struct *mm); #define __pte_free_tlb(tlb, pte, address) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index 12a536b7bfbd4..4b4a1766e2cc7 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -28,10 +28,9 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, extern pgd_t *pgd_alloc(struct mm_struct *mm); -#define __pte_free_tlb(tlb, pte, addr) \ - do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ - } while (0) +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ +} while (0) #endif /* _ASM_NIOS2_PGALLOC_H */ diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index 3372f4e6ab4b5..2964e26980a18 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -66,8 +66,7 @@ extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); #define __pte_free_tlb(tlb, pte, addr) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #endif diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index 96d938fdf2244..c376d4b708fda 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -34,8 +34,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, #define __pte_free_tlb(tlb, pte, addr) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #endif /* __ASM_SH_PGALLOC_H */ diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index f0af23c3aeb2b..a70151cfd11c9 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -27,24 +27,21 @@ extern pgd_t *pgd_alloc(struct mm_struct *); #define __pte_free_tlb(tlb, pte, address) \ do { \ - pagetable_dtor(page_ptdesc(pte)); \ - tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #if CONFIG_PGTABLE_LEVELS > 2 #define __pmd_free_tlb(tlb, pmd, address) \ do { \ - pagetable_dtor(virt_to_ptdesc(pmd)); \ - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pmd)); \ } while (0) #if CONFIG_PGTABLE_LEVELS > 3 #define __pud_free_tlb(tlb, pud, address) \ do { \ - pagetable_dtor(virt_to_ptdesc(pud)); \ - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pud)); \ + tlb_remove_ptdesc((tlb), virt_to_ptdesc(pud)); \ } while (0) #endif From patchwork Tue Feb 25 03:45:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52F2C021BC for ; Tue, 25 Feb 2025 03:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B976280003; Mon, 24 Feb 2025 22:47:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4691D6B0092; Mon, 24 Feb 2025 22:47:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E2F8280003; Mon, 24 Feb 2025 22:47:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0A3166B008C for ; Mon, 24 Feb 2025 22:47:02 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BFF59C0881 for ; Tue, 25 Feb 2025 03:47:01 +0000 (UTC) X-FDA: 83157081042.09.43BDF3F Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf15.hostedemail.com (Postfix) with ESMTP id EEBDCA0006 for ; Tue, 25 Feb 2025 03:46:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dD2ToK3D; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zIKiL/cvy76O78IwclMxfA3FUb4EAj4nzgq2isZtk2Q=; b=sizjJMN18CFgPA2Tk6DSLCCdGtkkhhDSym+HxOvkr+sxhAatlCMc2Hjp9PODmCtzDX4ihZ SrzOgsJFcPh8Kt+EYOpmBzJH0tIMFwBL7+wBS0X1IvGO6ql4jbC2oQYOsqGSrvIF86VrJb 009XwHUdlDtEOTE7XUcmEllFgW8VJKw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dD2ToK3D; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455220; a=rsa-sha256; cv=none; b=zSpGgaSrEFQZwDPlC0BCq2mv9j91Me+afEmlx2ta0ekDHNLR8tTGB1Yue/4muiQ1vL4vyU 2r5lodov3wN8TfQatHbBOA4S9qlJGsJr+om9X4IMWGiHY1m9QOF0kuFgBxKcNvDEL+post jvgKonWJu65pvlmsD/1Qns0H4KUElgU= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-220dc3831e3so95475985ad.0 for ; Mon, 24 Feb 2025 19:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455219; x=1741060019; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zIKiL/cvy76O78IwclMxfA3FUb4EAj4nzgq2isZtk2Q=; b=dD2ToK3D8zlCPM0BCXrtjUpJ6+8U0awL2L4pz525iaa3VUtwrGzo2n0Hy2ubhKJrqW fi7FH3DHVvhEegK7dVpVdOLJEkjjPpkpNhOaENS5aqZOK+R62fwjdi+axAshrBuGFcfb a4yFACVWs7zacJ0sS8PvZEn9iApSBIZ316nbFKsFwTIBwpJOpy7fOweJq8uvuQVFjYIf kwxtY1mmsGveRuSYPSAFXXLZlN447ogtayiVh/+9OBMrF4Yp5vReF/MGQPZO53B6rKie PByXvI1QNgUoi4SWqGQUMHW02noPVE7TpVFQR1vXegHVRHkcYzDAjNXjSvO7wqYoYTud MfmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455219; x=1741060019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zIKiL/cvy76O78IwclMxfA3FUb4EAj4nzgq2isZtk2Q=; b=IbzkO56aTjodx/Q1mYt7Dc989PUBOOwEy0Vjke5eID7SP9TS0W3WTv9SiE/Y5CwMV5 eVAnaHm0fSLOR3UAeTgfsLiYFzCrDlZKwkpL0or1jfuT/4dWJ7HxtBYxlLhoz9MLN63F 8C/tlfenrBdk/zElbwt1DL4RRTHVHoF2w+SRSw0yGh1m3H/hgwYCMEZp1y3Kq5TfZD4r SeHIBkDafWn699G/37b1hdiZYPjuE++QMmdIi2nVBfKUfTBqomEYGt6kTc50ydEDvybC DlhOh1evhY+jBfN3pl9B61cGfexGu4ujsda/6fl7l5sB81IwhJTSI28r7h8cIqwxUC7H 83Wg== X-Gm-Message-State: AOJu0YzjgQR8qIuhDhLwmqVVoEvKYZyfQWYhfiykagvdvXgGXdoZWixF 2EzcDs/nBWyV7vhXHwMTtZ8KAFLhrF7M5hyBiYZABCzWRtDEgns8DPFwCkbLSCk= X-Gm-Gg: ASbGncs+cYnyVwPhNhJ7Kdae7MyhpoL7OSqFXCZqJSXNsQg/Yon8eTDlcl8nqmewltf y/cBZZyzYxBjjrPVNWb0QwhiHlSUjtil1UHkLtGXw1SixxBZAEBd2SMtqIBgKStGofz6672uOsX mzQlUDbtsufiO6K19iFk3f0yH8O/AFZOZAGEiCLbB3IC94Oh3ZIhtf1X5AFI8FMSYjkZBj65+YH g5RLAoWbjpqbGhqNSvdNFRKUmDwlo1r8QEWH5IsLx0xCB32jvMt7jKm2Xi6nHVzQDB608iqxHwc KHsUHsdg6S29SRhiqIlD8rH+ATJ05PVLfWCA15d5Z/7yV5kJ6KkOl1oaWYe/ChcMOA== X-Google-Smtp-Source: AGHT+IGrbcobmtkudsLXXtQABX/QCxCZukDHXrGqT8EvNNCQnozfEzflYDWPRR+Q4O9sUaua1jgg6Q== X-Received: by 2002:a05:6a00:3cd5:b0:725:41c4:dbc7 with SMTP id d2e1a72fcca58-73425b7fd45mr26417726b3a.4.1740455218800; Mon, 24 Feb 2025 19:46:58 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:46:58 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 4/6] riscv: pgtable: unconditionally use tlb_remove_ptdesc() Date: Tue, 25 Feb 2025 11:45:54 +0800 Message-Id: <9025595e895515515c95e48db54b29afa489c41d.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EEBDCA0006 X-Stat-Signature: tfu7e6sdgre1w8et7amwgrpefwe96u6y X-HE-Tag: 1740455219-373374 X-HE-Meta: U2FsdGVkX1/L/OUiKBdBZa8B1ob1gCn8zv+kidu67XE68jiIdmsVHZiRuYsNhYJg1JZSXq5+J1qz942Nvg0pd9Re/R6OsSA7d44/Jcle9KLtoR+NCgH5XvACzcCvZEhChLDHEbRkjfmKvYOCp0e5M2aRM4JKlGjKd+deT+Nmfung9E9f02k/Rj7hQ8dHqNcn34sbmxpvLf23yIV/3mm1L70A1j25xV5oA9oD1nMpbDgpDzdSEKZ6p1fUAeIhiYjqWilgqBc7bC3nOqiguFkBmXmUtbW06Ez29JILXnVmDIUq5GOOE1a/rQ1rEUoYsW9SB2y167O2MJoN8JTx9RgwvaOqBJf32zFR8yp2EjNQ557A63Gf6rtD1OqD+ufqS4Aj36bSPpdVmV7RSPHHPMkEQHvAGMGr8v0JLvnHN9Fx7yn+em4GCeaAkeBXe2bVS2cwUswZC6s5ul/xnPnIc3zvETmzTXSy544dwTESl2i5N6M5aw4MelV0NnMzpD2FVw0+wVcwvhFErKAUf0dQixJdQOWX86agKVcv+fOKuEexsNFiMpLl0+AYYrTWnU+7Uo+zYX6FIGPZsnpop1bcjD9zgyund3QnFQCqbMoRgGUqQ8sb3ls+N4v3oiVskqw0ZBuJIjusgyQkgH2vH0aXtG5JykydcjW07TaWeMJEQdhs6Zw5twfeLIeJPlRajiw3nWMwawKIucAKQGHmXQomH7hBNYdMZyZy1DOttjJ09craNb/anbslvrkYq80bcRk3lBTWrHMBgde9bqSWZSQluv4Z5P39pu/7TKDkg5e/bs1P8vswta4Ns3Sp8ySxP+eJ9S9TSCA5GkNSkEgVZDmUnK/VJCcOjPF9y/s5TU72Cm6q23hcAS61k36+sa41UoRl2WyIzUMbVSakmyKnFBvgBLD65cW9dVJuEfB2Ea7qf/a0gLq2U/GFbfv+vJz6g4X7KGY1miwUALypODeKOqSN58e oivWhKnv /29hpn9NpiQ81fLoWfKRhf8VMuFkoE+Eghr2qDbIplA0d1m3yVYNKnoJEPIff2TcgZeObyS/TAUrnMAcE3hA/ALbZlSkyRH7i6HCa/Lg5ZGOsHGhIxHFEh2HyCQPqB4lM92MJHV6Yt7pE83a8bKsrpx02YuyCiCGlcYApMviUivy3SJxuSUFzCYIBluWJXQ/QkGSMaerVs43HyXqRMa/vsMf2+461OubXDv0OI6TiJvIrk787TppESwtA9dFGcviXFXBU13EFF6WSkz9hbRmfAbwFK5y5V6w2hfMvEyME7U43JeTwJlqFbR+ASmk7ypyF9LkO6bB7sJ7NszqAVi7Swn+VOdSNbCyB1UOxMNwbyUTyBS9fSGVbeAcorZesXCvqIjFfOJ8M3CzyRIfmjKLalOGeKUM7w35i1sfbw+WDtHjBlog9D0uo80z6XDBK2BkjBQaeVnQpoNWmor03IX4yxJRvQXWvTfmWH8gefA2Pc2zi4Vs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To support fast gup, the commit 69be3fb111e7 ("riscv: enable MMU_GATHER_RCU_TABLE_FREE for SMP && MMU") did the following: 1) use tlb_remove_page_ptdesc() for those platforms which use IPI to perform TLB shootdown 2) use tlb_remove_ptdesc() for those platforms which use SBI to perform TLB shootdown The tlb_remove_page_ptdesc() is the wrapper of the tlb_remove_page(). By design, the tlb_remove_page() should be used to remove a normal page from a page table entry, and should not be used for page table pages. The tlb_remove_ptdesc() is the wrapper of the tlb_remove_table(), which is designed specifically for freeing page table pages. If the CONFIG_MMU_GATHER_TABLE_FREE is enabled, the tlb_remove_table() will use semi RCU to free page table pages, that is: - batch table freeing: asynchronous free by RCU - single table freeing: IPI + synchronous free If the CONFIG_MMU_GATHER_TABLE_FREE is disabled, the tlb_remove_table() will fall back to pagetable_dtor() + tlb_remove_page(). For case 1), since we need to perform TLB shootdown before freeing the page table page, the local_irq_save() in fast gup can block the freeing and protect the fast gup page walker. Therefore we can ensure safety by just using tlb_remove_page_ptdesc(). In addition, we can also the tlb_remove_ptdesc()/tlb_remove_table() to achieve it, and it doesn't matter whether CONFIG_MMU_GATHER_RCU_TABLE_FREE is selected. And in theory, the performance of freeing pages asynchronously via RCU will not be lower than synchronous free. For case 2), since local_irq_save() only disable S-privilege IPI irq but not M-privilege's, which is used by the SBI implementation to perform TLB shootdown, so we must select CONFIG_MMU_GATHER_RCU_TABLE_FREE and use tlb_remove_ptdesc() to ensure safety. The riscv selects this config for SMP && MMU, the CONFIG_RISCV_SBI is dependent on MMU. Therefore, only the UP system may have the situation where CONFIG_MMU_GATHER_RCU_TABLE_FREE is disabled but CONFIG_RISCV_SBI is enabled. But there is no freeing vs fast gup race in the UP system. So, in summary, we can use tlb_remove_ptdesc() to support fast gup in all cases, and this interface is specifically designed for page table pages. So let's use it unconditionally. Signed-off-by: Qi Zheng Suggested-by: Peter Zijlstra (Intel) --- arch/riscv/include/asm/pgalloc.h | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index 3e2aebea6312d..770ce18a7328b 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -15,24 +15,6 @@ #define __HAVE_ARCH_PUD_FREE #include -/* - * While riscv platforms with riscv_ipi_for_rfence as true require an IPI to - * perform TLB shootdown, some platforms with riscv_ipi_for_rfence as false use - * SBI to perform TLB shootdown. To keep software pagetable walkers safe in this - * case we switch to RCU based table free (MMU_GATHER_RCU_TABLE_FREE). See the - * comment below 'ifdef CONFIG_MMU_GATHER_RCU_TABLE_FREE' in include/asm-generic/tlb.h - * for more details. - */ -static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) -{ - if (riscv_use_sbi_for_rfence()) { - tlb_remove_ptdesc(tlb, pt); - } else { - pagetable_dtor(pt); - tlb_remove_page_ptdesc(tlb, pt); - } -} - static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) { @@ -108,14 +90,14 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, unsigned long addr) { if (pgtable_l4_enabled) - riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(pud)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pud)); } static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, unsigned long addr) { if (pgtable_l5_enabled) - riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); } #endif /* __PAGETABLE_PMD_FOLDED */ @@ -143,7 +125,7 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, unsigned long addr) { - riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(pmd)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pmd)); } #endif /* __PAGETABLE_PMD_FOLDED */ @@ -151,7 +133,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) { - riscv_tlb_remove_ptdesc(tlb, page_ptdesc(pte)); + tlb_remove_ptdesc(tlb, page_ptdesc(pte)); } #endif /* CONFIG_MMU */ From patchwork Tue Feb 25 03:45:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB25FC021B2 for ; Tue, 25 Feb 2025 03:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30BB7280005; Mon, 24 Feb 2025 22:47:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 294CD280004; Mon, 24 Feb 2025 22:47:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E700280005; Mon, 24 Feb 2025 22:47:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DAE63280004 for ; Mon, 24 Feb 2025 22:47:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84DD580821 for ; Tue, 25 Feb 2025 03:47:11 +0000 (UTC) X-FDA: 83157081462.26.83AFDC6 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf06.hostedemail.com (Postfix) with ESMTP id B4934180002 for ; Tue, 25 Feb 2025 03:47:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hCo1AmAT; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455229; a=rsa-sha256; cv=none; b=laLjSKDcZUfPGijrLMH7xWJUhjfQDRP8kxRI4JP0E9yJfEJ7ULotb5EUsEj6sgFJkK7usd /Z6vh1hcdcUfyXPND67hCZ5ODAT8TcOnCv2sJIVIt/tsJN2j4HNFFEeEiXHxLFvm3WqMkw KjzIEz8vU3MeeUSxh0vI4PEzUnAo/L4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hCo1AmAT; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=36KztU5HqI7wNxhzV6WNrh7mWCrhUr2tDKJnWGxYavY=; b=5w6ENk44iz6HEGiAnudiaegcZ+bYxFscE07z3u9CMFZ2l8WCIu1rgjGbfqSTV4jkEyQyU6 CXs9x5U/tKJrrSxtSqYG0n5c5ORSzKwm5P3zoEvZisdJsjUVBa1WYLkz+0xGb8J/Idd9Q0 lIIfn5C12XR79SqJjXpRi2Fn0ict4os= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2230c74c8b6so4762925ad.0 for ; Mon, 24 Feb 2025 19:47:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455228; x=1741060028; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=36KztU5HqI7wNxhzV6WNrh7mWCrhUr2tDKJnWGxYavY=; b=hCo1AmATuU9QPwhVjXz7O4oulSi8/CoXhHQAGMVx25t6qR42o4h6WHl/7yHFMgQf/M NTo2K4eeYTvAJ3JvneUJymA7YGG24N0ypKwbe4mjkwklePFKnzyrCkzwaveby3aNFrY3 eVEE3fWqaCjg0WCIjfTHnqkyiyyiB4JsaSunWkwFL0G6sjASkUxgdzqgAwwJbKFkImlQ nyGF7jbgRjybptGK6objNpdpJWoQYdrKpH6Y75oWpTaJX/tx8J5d91XtVCI/4pZfp/uB Ls4go2S6pYRhVJQhqJPqBq65iOrmuKrZGy1KZC+z0kKpxTM4u92c+4ki6Sc1NK6IpgFb 8IPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455228; x=1741060028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=36KztU5HqI7wNxhzV6WNrh7mWCrhUr2tDKJnWGxYavY=; b=KlThXTAr/DWQ0TyXp0GUR/1udXNeIGXbK5Z/GYMbadI9N0NdQZxviacyPPQmKaRkFg +YCnRPZahGetD6q7ZqjCuARl6jKwVqFbDVwum4OTCUeSMy8yv1jxMvOTolVmB5OOwrME 2I6tAhFgzwsLBsCNKmTcPmMQWho4YhxQAHaTpBDpciKqzp6JsccS7Y7NsfhGooX0eOcH h2WyBWhEnEYTxxSzPxzCFczshADa6mxX5baajl/04XoN0LjwoVy9MAhOL+ZgROA+01Vw J6ZpwygD+dQkoTlF4ss4tR+wejhwMf8f5CJSyHuoYIvZa4lwbxrhoL2P3bB410tjMl83 02ZQ== X-Gm-Message-State: AOJu0Yw2gizGK8CLqTDZEd911iUBc8h1dJFYu3Uh6b3FZSHCwLL0pGZ0 bjBfzo72FEHgNWAJq+RfGG29zjass/8jSU3n9Oxge+lp7pxuIHYNX0wYrs7oF34= X-Gm-Gg: ASbGnctiiaJ25sC1eRiVVE5oOhrDGEbGOt2oaShWrlLJXEdgYuJbJ23hZhWck1aQaA6 WySW1jPsG94riPG8iyDpKij+lRod909cLfcEyXZaZWMhNLRTxvZtW0ElfH88LhZxB111oWpbB+u G9mg7vXskE3sC4dNR5f+GZAd4BcwbIh84bjiH5G+Q8/shUAXg3WqFYdy7zyDE2U34TC21R0rveR N2TaKZRU7+TDFmURBojvB4e/rTvfwv26Cup27kgF746fq+0ZLE0M48mSa2/MnOV+c3enbc7A+nf jBA9R3hWzOdO+BQPbxQeYSNXRlBl7ezDNt2Y9TWP8plxGMEv7eWq0KIEsFz9F7WsLA== X-Google-Smtp-Source: AGHT+IHErQlNtWAOdWTcDw4ZwAn3kttLeu4q3Mf0dru9ScBNUcUevexLBEyVDaZ2sKSBMgz3Y5FwbQ== X-Received: by 2002:a05:6a21:7a44:b0:1ee:cb9c:9dc9 with SMTP id adf61e73a8af0-1f0fc89a091mr2965600637.35.1740455228677; Mon, 24 Feb 2025 19:47:08 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:47:08 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 5/6] x86: pgtable: convert to use tlb_remove_ptdesc() Date: Tue, 25 Feb 2025 11:45:55 +0800 Message-Id: <36ad56b7e06fa4b17fb23c4fc650e8e0d72bb3cd.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: B4934180002 X-Stat-Signature: wkfuu3j7ipbz36shggd1brrkc6fhe99z X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740455229-222649 X-HE-Meta: U2FsdGVkX1+mkds4TrD3elyTeIBzYJczsGrzzJWR7ZCivhkYMmiiNV/Hf8Tq4x6zy8SIsnAdNTkqUVAMO+RMv9qRqBW8MbMIKAQF4mq4ISqGBtoJd3r8j7sPJhMSr+z7+3F6cNiQXUOOdjx090X5RanO/9NkfSaI6vVikl3L6/OKbrYLSO/FjQiMafJ42LZ3O67CzHYE26JDSWFP+pdRHg8ttuD9IR8o3qiB/Yk5r+HdBg/MWEjFNWkiiKwfoxcxlG/ep1F6OZNRhEQYAj7zo8euPaLf9ahXHqeK+W1usXkM5ib5S1K2WLD4CMT+cZDGEMzSeHbMHYdg6zyV4dL+R9fdbQvK3IRqY7i7BS8kFY6SizX+7DNoLZOBvNDfO79EPNZMrh7DhLY4aFgerOaCBwZf3B467Br6m1dskpgZdSMOAmkTLg/egr2z8wW1GnAes6G0lEeyaJCB2SZtthNSfw/QMePoq7Bz0uGfuXMs3n7zBrPviDVC+IstgItauHVe9QFT9YNjJT0An52A1sIqluq5mND2I7Ijitxav+inieJYaLJY6wDIXapHBpUhjuoUXQFyzjIe2YwQt3kWZ5tvzXglleFCEaUoHsPr7fBWg5Y3zNMFZ6NuXv7nVdeCc+auGXjVBB+DKbMxmt6p46zhSLwDTp2fW4ShWMRqQrZcqz4gpNP0O/AOdqQqGWPEsBwKrIsXHDjyfvUZMPArgMiKQT6xMEC6fBIcsKLzchmVmzMp7QYxL6fsOmM0xzXEUKvIwLLDvsnS6RSTYyFcAO6dX90Ovbyms6bnsxunl+NVz+O7R6Mtsmyl1379weV6ZDd2NOc6dtzye/loSRqIIzAkmBfmwEyDLYwxa6/SDXPeUClFhceWi/2qxOFPEzkAa6LR1WLKyrSQk4YA5BP3ZytsIesIXIf8PpCPTTypmlPFJxe+gBzLIiAej94G2Bo7TcUilDsrURxMqhBYSE75iGD K3+7856y xbcoU7iy5F6MWoxzpxT/dS+aJfCBgCOyWogBmFWfyX1faDAkma2OIAFLqDXbJ4YShYoAxNK9SpajYNdfdM8vvcip4v+mNaJpPBykpiy0ve80iojhhGWevcf0eusXBNzMr9QM2tfyz2m2e/PBZySbXIQ4nqGSNVwLRcW8o9yIMMWUh6FHYWn20zuBP2YXFRAaupAFJTEyykWWiFiNTidijqT+rE/qOMjpHIMzupD+KNHnXnlB9cAtqhiEn23TosBulmz1pPBa3c3brlkKv7ChhkX2KZR8rH6uENlPXDxPk8T7gEfi0Orb7y2VF3MfIJ0lP5/apK9VT8q1gtIcRRKJasMsXf64GvEend8XhtOWQ62YXkAurnR2yKgiVKKIwKf2WnRibQUUvbrNDL8V8YvhL1u0BrHfxXz+/R5VIyOVnSfD5Imkw6gcpwxcAIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The x86 has already been converted to use struct ptdesc, so convert it to use tlb_remove_ptdesc() instead of tlb_remove_table(). Signed-off-by: Qi Zheng --- arch/x86/mm/pgtable.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index b1c1f72c1fd1b..f28ddac0f734a 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -45,7 +45,7 @@ early_param("userpte", setup_userpte); void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) { paravirt_release_pte(page_to_pfn(pte)); - tlb_remove_table(tlb, page_ptdesc(pte)); + tlb_remove_ptdesc(tlb, page_ptdesc(pte)); } #if CONFIG_PGTABLE_LEVELS > 2 @@ -59,21 +59,21 @@ void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) #ifdef CONFIG_X86_PAE tlb->need_flush_all = 1; #endif - tlb_remove_table(tlb, virt_to_ptdesc(pmd)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pmd)); } #if CONFIG_PGTABLE_LEVELS > 3 void ___pud_free_tlb(struct mmu_gather *tlb, pud_t *pud) { paravirt_release_pud(__pa(pud) >> PAGE_SHIFT); - tlb_remove_table(tlb, virt_to_ptdesc(pud)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pud)); } #if CONFIG_PGTABLE_LEVELS > 4 void ___p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d) { paravirt_release_p4d(__pa(p4d) >> PAGE_SHIFT); - tlb_remove_table(tlb, virt_to_ptdesc(p4d)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); } #endif /* CONFIG_PGTABLE_LEVELS > 4 */ #endif /* CONFIG_PGTABLE_LEVELS > 3 */ From patchwork Tue Feb 25 03:45:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13989223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC279C021B8 for ; Tue, 25 Feb 2025 03:47:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5557E280006; Mon, 24 Feb 2025 22:47:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DE4F280004; Mon, 24 Feb 2025 22:47:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358B2280006; Mon, 24 Feb 2025 22:47:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 132DE280004 for ; Mon, 24 Feb 2025 22:47:22 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A1C934BF5C for ; Tue, 25 Feb 2025 03:47:21 +0000 (UTC) X-FDA: 83157081882.27.CB08840 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf03.hostedemail.com (Postfix) with ESMTP id D227320008 for ; Tue, 25 Feb 2025 03:47:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YspRPXsy; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+AOLMBHyoEBsAHQDRMLfrp+DU3rIi9C1hjH+u4umGY=; b=u0SCkwi6ywChhgLSsv5aGmJhlcBbXqfCsr6w/xalI/Tb2cWbJDpX+9A9Armxw9A65dOhQk Y99wYjwN1JbHNdhGFjub193MShTVPHzQOd41CEnB6x/7wyIN6sNDH/O7q6JbQ29/vleRPq vgQpU75esh/5OjdDZ2/CZIUm120eK6M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YspRPXsy; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455239; a=rsa-sha256; cv=none; b=lOpscL7um3ieBxBb1veDfdPXvoPPqwF7KBRDekhXr2hI5s7W5ew/OyJU2OxrLqDu8v00in 1h0cuH/uuyO2ROeqeA0ZkNK1QJGYSkQNth+uPcPH/I35jfYg7t8SJciDQvwZmm0rvkpqhQ erCgmzvCck6bLbHV7nnAyT0+64aDVGU= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-220dc3831e3so95477875ad.0 for ; Mon, 24 Feb 2025 19:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455238; x=1741060038; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y+AOLMBHyoEBsAHQDRMLfrp+DU3rIi9C1hjH+u4umGY=; b=YspRPXsyufna9qvVoDeODOjFY2n7MaYsnRwh0ddjm2Kr3t3D5nEXeN6yfQou5ft6Z/ ica7SeP2o6pljAx882Cr0Rgg6mQIm1s8kl8lOPduKJBWBQLrNm61jw1CLMDJnUXOP07m 6zKh2WMHQneMmSnqJUbdPaNRvtzy2F5DmLPmpIQQ5kjy7pkdcEW585W5rOvkxZStgDlc r+aaAIoP5LmOayMUjRkyrDDaSLR2+D6oKkahJFJmWooxQhSCB3htFKdzh8uECUk7gsbV +760HKuA3v6cMOBUyYiKSwY/AQSEcfVumFKXpJT7MCXJk+ZaqkHGt/CmZSEWpMuAFLfv vDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455238; x=1741060038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+AOLMBHyoEBsAHQDRMLfrp+DU3rIi9C1hjH+u4umGY=; b=lI3XovgUJjrn8V4gtX4vJfbl1UR7y8QjN0adgzAaw3JYqgKEHljaNE4dEYbTwrd/hD S2O9aOPWgBf9Bl3HvQicujW8bQ1wWA4A2XluSXPVqrDPl82uXweHg1bqO0Sr+f81qtWI TnXqocXrap+e3F2ASricOQIJRCdAmMNSnX6D7hHbNMcGTl5EjQfU8fq4pDdE905L0gOp z+kIllTYBfiKdBDvFHDhuYAsUgjJyQQDr8zmBS1DvqErjP91OculAwqfKskjx8LAbze9 syKMOvIv0euvaMcesWs44LU+Tf1wZObEk7iz91J9z9NHbCzjBvfsfv2DQwebfDljHqR1 Qudg== X-Gm-Message-State: AOJu0YxVNIJBsn6zXhZuYqSHYl9zCitLjE0lYA3KtR+q4bqsp8ezT/uB nBpus6eaELNBPaZgl+8sio7CzyFVWj8uJMyco2cUm4o8Sd0WQ3EsTbEpVkT9Nw4= X-Gm-Gg: ASbGncvy6BlijCYs2UAGDGe3BLZc/BJjPDk9ov9wjDPEdGEPkMvRHDjTSjhaqt1+8pA 8L4J2SwC57h5QJhmkqoO5X58p47mNQXkZlDWCLQovtLk3mKzW2hBiPAwxA7zUrp0DUxnSXPPsqw qmS1SqBfvOTnE0JVYJcr0xPwAP0wI6z0/sxvPae+44Sq5OMVHHBwI3c0o4ZbwxOScEHNFs4u3kQ lV41cykGLofQFlqkD2S9+4CA6vWJYUDAhTPx1f2LVjIbQH5fUVlElsnCr3guzqtL8CiGLwx4Y6G 8ImMbrW8CHuEZrc+xOijrQIZsR4sH2vYJGG2NUm1OvnlXWu9nZeAmLqokO0pEESn/w== X-Google-Smtp-Source: AGHT+IHDwvQZzbKv24vEjKNvLJNI+R1iJ4OqsIlmXN9p1d6u9OWq0+ZfVfD6gOTuv6xGQ3OntwSRRg== X-Received: by 2002:a05:6a00:6f0e:b0:734:26c6:26d3 with SMTP id d2e1a72fcca58-73426c62969mr26062579b3a.5.1740455238550; Mon, 24 Feb 2025 19:47:18 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:47:18 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 6/6] mm: pgtable: remove tlb_remove_page_ptdesc() Date: Tue, 25 Feb 2025 11:45:56 +0800 Message-Id: <3df04c8494339073b71be4acb2d92e108ecd1b60.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D227320008 X-Stat-Signature: cwtg5gmxi5d3k1ybyw6zfsiequdko9uz X-Rspam-User: X-HE-Tag: 1740455239-832538 X-HE-Meta: U2FsdGVkX1+tmtcSfLgi7rcRbJoIfqEzD/pIYeBJ42SOfvCxaCc7iRGtq3lqUi2xvGpQ63y9Tnjufnt2V2C5BfB4cnGpMx0w/EFDHNUuF8eKn3azOEqPry/kYdX6q/IFxZiIFz7MjkSwjbMuqLwtoP6IOBxfSwZvO8/B0ca3TOBs7mV9KVNR7iCAgLSw2DV/FNTqSGtwarjKhUH5whitEYQkVNFpyLfEAHorLXN/7SxUpZX6eIuCc0+/iGbDF7hMzVZ1ggw03elmkJaiC6hrpPeEV2t5MW8czHJ4OUeBCSTsW9sGoyAvrwbUNXl+mZCBfA2Qnyc+CtU35g03De+8pOff0L6iuueIsfZdSay4htIen2GvODmRbiKtQNx5TlFodl+fj5gyRNBFDwqeDncvyJ+HLW1Ih7SmEMTI2XkugoU9zm6KSo9uV929LEVl7X0ErFHrgY5bM66rXPNZYTf/xXugL9+W+G2CralfK0MLCiukq8/z3HZ+OrqKrEtSS1NZp2s0p2fGzaaTydx4FpEzfMG2gqzP2zuUgAwZTuoTCQx7Am7erD4BFQAMTI8qTwdIJWANeiKFBGvoMe9WUIrFQ2VLkJ/CoKu2wgADaz1n0ReB8qFRGewYkf4/Q8wQ2DfZQSXlrRiyx6EFp5SDiOKzbOThWn1QrxHsmeceJtZm4jVBpB9yfk73YbzW/0MpONBa5WlTSURuVmVxdED4siF3w4uai6BoX28m+rMcRfatiRWkAotJVBnSuUXNyy31Q3f/qnCaS9TIzMNsE/NvqrbdpjsF1nKGBwwVauYdXda+zfamHTftnPBiDfWUNw4Rag3mOJhJ5LdOEnBo7tteUMNuVvusBPLta53uXs1p6MG85JGPuZfsxL5CWavXbss8yJrP/2CzcY+y8ZFdzSLGoFS+C1Qt3B03hq1165z0UFCogbk70XmdIS3/bCQR5pBzRpSjWSRxmeyYFQThrMv2jQq IgxHgmKl 0eNUsrh5sCcpENiJHbIt8QabXVYrKhht0Ot4ZJaSxnIC+79oWXSvC5OAYvG3xEivn+KyIWKXxlI4kV6YJ0F579aAHh4CLcP3Kvl7aNTgq5tQwuRLzI6v2SxUb88G/H/8PV1du9UeG12byv+jTn2LD5OfHc/ojPzrtlimX7BdqibW+osbgGh6bSpSb/URlCFuF969SdyjEmyEy/Z72/9f8x9+EmPs28exOPzDiWaN0YwXMJhETt844geyCdOl/26aq7Iz3obJxE47u2E4qrFZWDE7qSYSIdXWdz1LmBnc+EXgGSI90AOingY0apMZCgn8ZzZKgEb5ybTlrj28YkyMZsp1EdWJSN4rPqr29LnMx4tWBWQ1tSr/zWjvfJbaXzbb5YU9ORnY26QPTGlqRWcuGyrf4XDlIkifBLR472Mw7KiOr5ASbNCbGmkcE0k0hZpZUD3phAZX1tzBBlCuiXtcK4QWqCDDcIVqRYlwvQe/JHBD8u3E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The tlb_remove_ptdesc()/tlb_remove_table() is specially designed for page table pages, and now all architectures have been converted to use it to remove page table pages. So let's remove tlb_remove_page_ptdesc(), it currently has no users and should not be used for page table pages. Signed-off-by: Qi Zheng Suggested-by: Peter Zijlstra (Intel) Reviewed-by: Kevin Brodsky --- include/asm-generic/tlb.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index 18bf499ef8801..dd292c6d3ce88 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -511,12 +511,6 @@ static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) tlb_remove_table(tlb, pt); } -/* Like tlb_remove_ptdesc, but for page-like page directories. */ -static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) -{ - tlb_remove_page(tlb, ptdesc_page(pt)); -} - static inline void tlb_change_page_size(struct mmu_gather *tlb, unsigned int page_size) {