From patchwork Tue Feb 25 05:34:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13989326 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558092561C9 for ; Tue, 25 Feb 2025 05:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461699; cv=none; b=E/jOMq0AYk6+HpBAj+cmMUP0t/Ncyf6JFo5H56yx3Q2+5Ujku9LfEzAiYFHOB5tPImZj3bBa0dG0S6kewqRCMalV/BBWbU73FCLqsaMKdvzBKE6uI7B6UkHHTgVh36ujgvP+pu5nnGOtstqLPql+UGF+4n1dV4QH1eNttAqFXsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461699; c=relaxed/simple; bh=LdVk8C3dYDmty4gxkSuuGDDu8zkpk1p5J4v3VnCRaC8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FltPnofc+0noUg0TFZiEYARbcYMQiQyY5nGgdvbpFKwKTIxCAgZVicy+V9hFFlI+lABXwImDJyPhZ8W/jOCyxy3eNTTcgy33OGf8IkRE/KtXwWzIY8l2WbPXLv5nQZtEqpaNRkh50nYxJd91W5gnvn4oHfZ13gRPXzTyuQYTqrA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x3Ko8wH5; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x3Ko8wH5" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2212a930001so28602935ad.0 for ; Mon, 24 Feb 2025 21:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740461697; x=1741066497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Alp/86Yl8dv5OV9OIvJcS/PHlfX7ulpzzZhhzjQV/Tg=; b=x3Ko8wH5y0SutybJLEXTKcO6rncamISSQugXgiyYV8h1OhRXzX04W1KSZedh6vrDDX vFYQ7akej4z3CMCMzKdy/JZ3vFzn74sm+itk/OuUnhnVTRSm5FW/kgjE9r1P4qlO7slJ nROorqbMhqGGMQhoHIAFyt69aojvB7/nLHgPefsx4kMCaDGV0hUpPG03d+8Xesllh8A0 JnRLsdTrSWrOtAZcdK5CG8+RA3DGxfmJkEajy3ngjHTIJ5tlqJ+S988BKXc+zqgDJe1M +xTm8KHRZasiC4fpJ09YtS/CKire6fSv/n1uhSjnAW67ukdhmTVL1KcwT4y3L4i6ykUb O/kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740461697; x=1741066497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Alp/86Yl8dv5OV9OIvJcS/PHlfX7ulpzzZhhzjQV/Tg=; b=txbY9LIcLYDbPHVlGJLvZwW9qrminrKVRMz6n560ninpjrfwbBY9FW/NcqWD63FO6Y DQ91mSnpPPI9ugTI6qXpyRI+DcHqMaDQMBCtCiA/CzTXzRjAsalLQ6tnl1gHIRmnMvjL W6klLdoDWHHbFOnKIOAZNbbye7tM99Xnk+OUmYM8+iVDQT8Pg23YGi0CgcZnHX5QMhx3 VQ/1NQCyVssFLacX0qP9HP74D1CvVQ3AL+UjcH6q6WjRRoJJ5MVTVHTtQyBGFmmfXui2 vVY5smNC0IszGqQE0Y7L0Mt3nD44OWgl5Dc+UE3IpPU5Hm0eJ2E7iCoIJXmTbsuAuvIE Gt4Q== X-Gm-Message-State: AOJu0Yxv/G9apNcfu2iBRpBKwptR9TDc3bZBmCVzHKV6t2HIhIKSCtMR g4QKb3HDOFEi2TLp/2zlxLDyTe2NLVmx/b+Ycn++mOLkPCMUhdxM+wb3/LOhjwSUMaW7ejcvH3w = X-Gm-Gg: ASbGncs730SkKxx32X8WMFkaXmnMTdOe5MpRCCk40IcMEhgVHJyd0u16fnUH4tN4QtS w5jhDVrjGD1k1gJ4eutjlIgGHe8kfgI7Djvvl1QO5NR30K4gZ+zQQZCI53SGtg2GHWBHE6Qum3V voRtVdny10ObN+Es2aoO2EOzKdcGgtgMfPLj6K9tQBQjeWmkqEXbTXC17YbKCQz13VBZljsqBsB 6Mt+38yNDC69Xh4vS+tOLd5Ek0UIC+YZMddsG6OZy0LGkU9J0wwMqB07ylaFvjkyGifzEDmAzMU BGpDl/4Zlq8UbPoOlJx60cIorTc4CdL4enPJHgiv99IXwnZOJHWOFg== X-Google-Smtp-Source: AGHT+IHmuD1aWu/v1EBbeaPKC/rVSjBidCILD+wsg56kWI0wnKQ941LQEdS/f9KRvfrcz7v3nfAKMw== X-Received: by 2002:a05:6a20:a103:b0:1ee:dcd3:80e6 with SMTP id adf61e73a8af0-1eef517dd67mr30705278637.0.1740461697436; Mon, 24 Feb 2025 21:34:57 -0800 (PST) Received: from localhost.localdomain ([36.255.17.214]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a7f9af3sm582101b3a.110.2025.02.24.21.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 21:34:56 -0800 (PST) From: Manivannan Sadhasivam To: jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, Manivannan Sadhasivam , Baochen Qiang Subject: [PATCH v2 1/3] wifi: ath11k: Clear affinity hint before calling ath11k_pcic_free_irq() in error path Date: Tue, 25 Feb 2025 11:04:45 +0530 Message-Id: <20250225053447.16824-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> References: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If a shared IRQ is used by the driver due to platform limitation, then the IRQ affinity hint is set right after the allocation of IRQ vectors in ath11k_pci_alloc_msi(). This does no harm unless one of the functions requesting the IRQ fails and attempt to free the IRQ. This results in the below warning: WARNING: CPU: 7 PID: 349 at kernel/irq/manage.c:1929 free_irq+0x278/0x29c Call trace: free_irq+0x278/0x29c ath11k_pcic_free_irq+0x70/0x10c [ath11k] ath11k_pci_probe+0x800/0x820 [ath11k_pci] local_pci_probe+0x40/0xbc The warning is due to not clearing the affinity hint before freeing the IRQs. So to fix this issue, clear the IRQ affinity hint before calling ath11k_pcic_free_irq() in the error path. The affinity will be cleared once again further down the error path due to code organization, but that does no harm. Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-05266-QCAHSTSWPLZ_V2_TO_X86-1 Cc: Baochen Qiang Fixes: 39564b475ac5 ("wifi: ath11k: fix boot failure with one MSI vector") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Baochen Qiang --- drivers/net/wireless/ath/ath11k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c index b93f04973ad7..eaac9eabcc70 100644 --- a/drivers/net/wireless/ath/ath11k/pci.c +++ b/drivers/net/wireless/ath/ath11k/pci.c @@ -939,6 +939,8 @@ static int ath11k_pci_probe(struct pci_dev *pdev, return 0; err_free_irq: + /* __free_irq() expects the caller to have cleared the affinity hint */ + ath11k_pci_set_irq_affinity_hint(ab_pci, NULL); ath11k_pcic_free_irq(ab); err_ce_free: From patchwork Tue Feb 25 05:34:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13989327 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84B017E4 for ; Tue, 25 Feb 2025 05:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461702; cv=none; b=nG2vM7aB8z3ehOlzxseGAXaWGm0IK5FAjsAzOfKkNCBzl0+bNdkJ2eFl0LzXY0bw6EsRpxzJG6SpprBHfENrkUk/EJZOX9U8aS/Fv1sPcaA6DkO6n2FTPVwufM+6WC0trrU53ZJxAQ2iPieiDCtbuP3I7Bw3WeaN9azNrq6+KeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461702; c=relaxed/simple; bh=FmjQKYch6XSD5pbW1Tn3YSdPQVc9xHCO/JMUTJbJyPk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ThAnJDmgrmarKTI7n8EEjNvLr+4KLcXA/X1CHSAGF3Ek/hqsciO1fbDVuzHEztu/xYam/p/MNHpk0o2AO564cIcM5coZUgiUD3q2myf3UZFqTymlpaUBDdKM17bf7Pxx7OZ7O/NiOdYECx8N/YPef+5gq9lP59N0IoKnKl+BTd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GvWsYNST; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GvWsYNST" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-221050f3f00so117107975ad.2 for ; Mon, 24 Feb 2025 21:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740461700; x=1741066500; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F6Il8METpmlUQkRbSAgjzH18Gr01cpODvArSkIp0bgs=; b=GvWsYNSTIsVy6ueVfKcYCEgMlB5NOeOuS3+/HT+hj66ZyL3SXypWtq/t77Bz7ijcOH NhJ0uJ2f9HvlFcPe0sv+R/ycc6PMq+VkLTVVOtigfN5V1ZN4740kicbtlCe3pu7BSby7 pQRD5lB8LJ5mH5NyeidqnSbqrMD5GiZnpnBCgfia7Fr4wcMQY0g73cKOuNKCAEH65E14 GdIJVzAHZ9+VtOg/vw7yAkcNEa+FqzxUnFjnnBX9kpPC+dMIaN94GEvWhF5bHjbBCoqL N/ZG89QdONEnDblC5FSi00w3RdEsavcCH6cRc84RTPldUwqckCDNs1C9sA84JTmdlgz6 c18A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740461700; x=1741066500; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F6Il8METpmlUQkRbSAgjzH18Gr01cpODvArSkIp0bgs=; b=vT3HEBVpVGnAoOlxB9BmqRPAZZOGy0ipev/RsaGC7dCHVSWLkjYdyL3UoC5JH1Ryix ww7R5rMm7P35/NXRMVQRaVckAVshrxkGPAxjTXRT8KR2q6VuvOhDhOAObljnYy1VdF4C BYGRZXp9E5lqReWRWaT/Gg9ThnvgRCSvzocOOYpW7Q2bWhGJxiswmMAfXDgGkUPBpQb3 CXKUrubYptxJR1l/UggvJcXcTtSsWjCnVWIzYrQ4b7Tl2NTsfyT2EtsaG8CauRKSVIPL bvg//YDyEmWgXFnT3get3HU+im1ZfXaq4FRlM5rp5lVx7GsETBzbyNCuYXz/OcQQ15TT iDAw== X-Gm-Message-State: AOJu0YxX4hECAkZ3aM/sg+6r4ADY53dTxRkRBPSjeG14rs3slNUY2MP0 kEDILQ0zQxtCu+SFGbpWcN4Hn46WrkUeonEmbaCYyT/lFNIL4tvRJcfIkb04JIWFUpuDDzFrDdo = X-Gm-Gg: ASbGncu4bf9HAI2a83k3ImVKMMDh5QiQC3BVfEDlKoABUlD2fXlKMZpQLLHxg2+tmVZ pFIxlel0oUioRcAOtoc1bgNvt8KIJH4JT/GLxwmVC0JHJBvrh7n5ackgQkCFauXe3yBtzcck/jE LSplpdKe2r9qPu5xJOXXQC3SwvpdbYW3gsEtRKtnbAgw9FmbzTBh680EdXP1O93Z2M0gnWxWfaf XwWPf7PFN2wlHbpJav9BF1BxlTeHpsdT7hYOUjmQ7kYtERDI4OMTUBbs7x1izKa5f2qz5ji4tnM 53VDHPcWIjdTxf1/FmdAEhhEzCpS2LW+wSLrvTdg3H1/czX7HL3r3g== X-Google-Smtp-Source: AGHT+IGOuK5WVs/FNS54x208S7fpWZaQq234w5cakUj39RKsU7tmbyu7PT7tpCGWSjC4Q4d8G+DFOQ== X-Received: by 2002:a05:6a20:a103:b0:1ee:de1d:5abc with SMTP id adf61e73a8af0-1f0fc78bfe1mr2892953637.33.1740461700018; Mon, 24 Feb 2025 21:35:00 -0800 (PST) Received: from localhost.localdomain ([36.255.17.214]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a7f9af3sm582101b3a.110.2025.02.24.21.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 21:34:59 -0800 (PST) From: Manivannan Sadhasivam To: jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, Manivannan Sadhasivam Subject: [PATCH v2 2/3] wifi: ath12k: Clear affinity hint before calling ath12k_pci_free_irq() in error path Date: Tue, 25 Feb 2025 11:04:46 +0530 Message-Id: <20250225053447.16824-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> References: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If a shared IRQ is used by the driver due to platform limitation, then the IRQ affinity hint is set right after the allocation of IRQ vectors in ath12k_pci_msi_alloc(). This does no harm unless one of the functions requesting the IRQ fails and attempt to free the IRQ. This may end up with a warning from the IRQ core that is expecting the affinity hint to be cleared before freeing the IRQ: kernel/irq/manage.c: /* make sure affinity_hint is cleaned up */ if (WARN_ON_ONCE(desc->affinity_hint)) desc->affinity_hint = NULL; So to fix this issue, clear the IRQ affinity hint before calling ath12k_pci_free_irq() in the error path. The affinity will be cleared once again further down the error path due to code organization, but that does no harm. Fixes: a3012f206d07 ("wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Baochen Qiang --- drivers/net/wireless/ath/ath12k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c index 06cff3849ab8..2851f6944b86 100644 --- a/drivers/net/wireless/ath/ath12k/pci.c +++ b/drivers/net/wireless/ath/ath12k/pci.c @@ -1689,6 +1689,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev, return 0; err_free_irq: + /* __free_irq() expects the caller to have cleared the affinity hint */ + ath12k_pci_set_irq_affinity_hint(ab_pci, NULL); ath12k_pci_free_irq(ab); err_ce_free: From patchwork Tue Feb 25 05:34:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13989328 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3EA17E4 for ; Tue, 25 Feb 2025 05:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461704; cv=none; b=cVYHfbSFTg7I9+uZusi1aVmf85XbNdJF7/jQP06MpD9mUcunPAgMHrM4hrCnB9JpcKUQRQUf40AGTUo/jsifLMZsXLBFWcfSRXvttZYpQLkHXI5jpdGMmQy5+KAHK5U5hXjt0jaW9SPuQryO/RkPL34t6iUdzBssCyWDa597O3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740461704; c=relaxed/simple; bh=m0ENAYkK9uSzSQgO0nychnr6WiQxO2uAemDG45GIDpA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Sne9qBlpYXylfD8yF2WdmPfZNdMH8VNmErJsuAbg3awkNT1+jXed1OL79JWtMqhKXFE6N5L2Alf6XTICC4lNtXjf5dpcIJqUKISPKKL6pEGBVkavQck5lKs4j3SV3zJalhapmYSHaYFaBYh33xDpVmsFBCr07lxKjRoPAk7MZKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XCzWZ9Dp; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XCzWZ9Dp" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-220f4dd756eso107622515ad.3 for ; Mon, 24 Feb 2025 21:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740461702; x=1741066502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AYmnWqCfl4BTw5dpDwtuCHljGqr5uXG7tQyflbiZ1TI=; b=XCzWZ9DpJfpUhieCl8OvFY+EfDWk/cJL0RAhHrDsUD6/YRxTBeZuxaGFvf3jE+6Y5R 7wWgYtsEeo1msxdc01+ZFx3K9u5RsWKaVV0Qt3jdT5BVYVfGca8uKJaDZ+qF/d5Sq02x feJLwKbPfzUOnJ1XkYpIkoXfn7QB0kQ3fEkx+VfPlLWJfIzkcX7Ncz1sT92/3fEtzH9N 3F171KxK+622g0DovPjnksnVGQVaHSZac0pwrXnoKHi1HMnWkPcD0X6X6MKyYX5WTmoZ PNYq4DfaFMTwlh7xzyxmwDME80ibQ10X/X0yyIfYOcL1UINGP1gf6WwX0/iTV4fR+gsJ aMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740461702; x=1741066502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AYmnWqCfl4BTw5dpDwtuCHljGqr5uXG7tQyflbiZ1TI=; b=cyJ16hKOPee9biZ85yWH5ucfBjGGWudS3klO278F8Z3GC89gU5E/xKtoSbVee8Vftv n9Omiq+ycO3ZMi3wJfynaUrEVenFZey05mmhLo+GkhWiv8PbfNIJ62qm4UVgt8eNBncE 7Eu/eiIlWIimQD+aPrvslqAJiJPWYY94J5+nYUlNYiz9K8vBBsJQTYElH1az/lOmgc1D gZKe8yPU6Hl5VUVZhR0bKzTr+hROzgFvv+oZt3aW5+8Ph3Za/8ESw615VKWpDegu9RSG PV7BhExl9ZsZCMgrdJYk6C8Xc0KPFamjJ45F25PpYkNcdy8qh2owBr/BSBY2/7g8OjXo Jf9w== X-Gm-Message-State: AOJu0Yx5TPyvedRmbwyV+ftrzjPtMsjDAm5MtzpgA8HtzNHWSZ4owROJ OGFkUYheTab80oTO+3zmZ511LzNh3RFMis0vFEuMyv4cxgpA1xIj5qypw61uUA== X-Gm-Gg: ASbGncseTqXbdAo4ax1LpZrMzdr+PEfPMlQnZqxZzPUf2MVdXddCYRTyZYuMZJ7UcC4 KzS1usXP1fItCGb6QrcCmekZVvbXJYTXNSUd21cA+tnZI9vXB6Ra0zJA1j1yq29roSSU0Sb7W02 BfFKYjlbXzq6LZt541Jn1KnmYZZ/dWjk3PiO29bRQWpNws1t4mCtutl9uiRpek1tqXYGv/+QMw7 T6SlVrep0+pmhipjoRFCaPYowlcbHG1EBmJ9gZ25oDXZvXMD9QyRFYjnwX84c6CkrSi/jEVkNr+ +baWKIdZPLx5b+Yh0Sd9mszF3QoxTG1ZFOf6ztJSDhxBKXSbNo3NlA== X-Google-Smtp-Source: AGHT+IEHljzwJD36eza1aeKcaU2dWlFSTtvnEQrg+fmzOtR5w21SUg7QvbAbtZaZAXH1YQPPhdGwlg== X-Received: by 2002:a05:6a00:2e9c:b0:730:8526:5db4 with SMTP id d2e1a72fcca58-734790f8cfemr3218117b3a.13.1740461702511; Mon, 24 Feb 2025 21:35:02 -0800 (PST) Received: from localhost.localdomain ([36.255.17.214]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a7f9af3sm582101b3a.110.2025.02.24.21.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 21:35:02 -0800 (PST) From: Manivannan Sadhasivam To: jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, Manivannan Sadhasivam Subject: [PATCH v2 3/3] wifi: ath11k/ath12k: Replace irq_set_affinity_hint() with irq_set_affinity_and_hint() Date: Tue, 25 Feb 2025 11:04:47 +0530 Message-Id: <20250225053447.16824-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> References: <20250225053447.16824-1-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 irq_set_affinity_hint() API is deprecated now, so let's use the recommended equivalent irq_set_affinity_and_hint(). Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-05266-QCAHSTSWPLZ_V2_TO_X86-1 Signed-off-by: Manivannan Sadhasivam --- drivers/net/wireless/ath/ath11k/pci.c | 2 +- drivers/net/wireless/ath/ath12k/pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c index eaac9eabcc70..be2791cd79d5 100644 --- a/drivers/net/wireless/ath/ath11k/pci.c +++ b/drivers/net/wireless/ath/ath11k/pci.c @@ -735,7 +735,7 @@ static int ath11k_pci_set_irq_affinity_hint(struct ath11k_pci *ab_pci, if (test_bit(ATH11K_FLAG_MULTI_MSI_VECTORS, &ab_pci->ab->dev_flags)) return 0; - return irq_set_affinity_hint(ab_pci->pdev->irq, m); + return irq_set_affinity_and_hint(ab_pci->pdev->irq, m); } static int ath11k_pci_probe(struct pci_dev *pdev, diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c index 2851f6944b86..9883cb2de548 100644 --- a/drivers/net/wireless/ath/ath12k/pci.c +++ b/drivers/net/wireless/ath/ath12k/pci.c @@ -646,7 +646,7 @@ static int ath12k_pci_set_irq_affinity_hint(struct ath12k_pci *ab_pci, if (test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags)) return 0; - return irq_set_affinity_hint(ab_pci->pdev->irq, m); + return irq_set_affinity_and_hint(ab_pci->pdev->irq, m); } static int ath12k_pci_config_irq(struct ath12k_base *ab)