From patchwork Tue Feb 25 09:38:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13989650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18DDDC021B8 for ; Tue, 25 Feb 2025 09:39:04 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.895564.1304243 (Exim 4.92) (envelope-from ) id 1tmrOk-0000F0-JY; Tue, 25 Feb 2025 09:38:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 895564.1304243; Tue, 25 Feb 2025 09:38:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOk-0000Et-G5; Tue, 25 Feb 2025 09:38:42 +0000 Received: by outflank-mailman (input) for mailman id 895564; Tue, 25 Feb 2025 09:38:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOi-0007uj-RN for xen-devel@lists.xenproject.org; Tue, 25 Feb 2025 09:38:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 461b1daa-f35c-11ef-9897-31a8f345e629; Tue, 25 Feb 2025 10:38:31 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) (Authenticated sender: nicola) by support.bugseng.com (Postfix) with ESMTPSA id 628394EEF417; Tue, 25 Feb 2025 10:38:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 461b1daa-f35c-11ef-9897-31a8f345e629 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1740476310; b=UgHK9SUHjxkog9+ljIoXBvg075L4hczi7boVL00JrO2Rcnz+8wXYhtusuJVxhS9EZqqU AnTagonxtRM9w9KVv9+SMVQdiyBrYZTndUgcof36r0gALeQJwstnYR4i+tmJtZOkQNuVv UmyZsyOJJD9ozeqBNcmRprs/pXMWlAtr2lkcK4NpDzyTrIJzVp5EjE3iTLnFY3iHNjQ+o Y2ExdOZ3h8Ca87NtAiylOaOLfUNBchb/PxivkyTYsVDzTeguH6/K0s16ZKfrRUdOFL5sY Lmx+xPeikSiGJ+bDVYgjLLuFoxgyDU1XCvMrY1eoGdhvLZVoIhmPiZk0ZaPaMlK+sAlkD AXcIQaPP4iGtxOb5ORBjkylesy0Ht6Ra/lU/X6WgLz7sykztZgrA1cGkgLNPGLQkVUgk6 VnMS747js7s8jllWH4aIJFadzwFgSOuDwJAf9K0ezBfjQHz49tsPFDQKkj0D8HNZaFNMw BMLAUVDl5z0S48KZtvw/9ZxwjMMb2j8ufUY6coLI9ilgw80HS2YJwpWRO+AXD6A13WYQS 9f0nkKPx68/JwqG9AIyklx8KbbF+nJmB2qasijowXBOmqMpjaDlXeq8uTmmBBEBKRx4TU tLk9l/aMWuPdH4Fpa1HrXk5CPjEhKHuY9BnPDg1yjVOGqcCWrHrvVQ5ig2VSbhM= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1740476310; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=NaFM1ueXPHGKYX1U4ZSt2Db8MZfE259Ddc2DPa/4Sw4=; b=zT6IoJmiGL0WofYBpGe5gIVyHZBRR+ukecXu6olx1MlwOlc2f8MTTcHoUHoj3idQSPv+ TWOE/QAncA5kRKNq3NhYGMNuPhQg3dKRzmhrx6o53Kvgak58zg9blZrkGpeGH1CuY1i/H BkCAipNolktmKYnjY/O8mc5ylBAqALprWAQcADUYDRYQIBEG78ejpOWmyZiBslMNsQOoO 1RkVlzo6uydXMRTjkFR0BmplCHMkQDphT8JexcE4vUV5mlBhWaH0sbai0leZFVom5MXWo /dTYPgCl5lgHFUPxUQUcTvMFdrWp+I2oqOIgkF+ZoGiAVfXJgp6pJEkMPCdUWz0bAHJ/Y tzn/zs/n8SgXcqnqZ1pNCs8KKr7KLXLsxxhhKL7OFzLTxP1jvhTFwkjKYOmw6ESVaNnuv rO16qztLLlxG2Nfkj3yarEdoaKEAQvjptHEbgpbCqaqvqwfMi4t3U4H1+yuQ3yUmN289u zQuDd7e3XcKLGAmSIm3x2owqnOoYVKd1TABZrz0Z899KL01N6Jq1TATPP0AbVfHq7P3eR dO4FzLqA5FHY5OkOr1SUdqlpejjv3Uhov//Hja+idu+Y+OHp6oifROxfmBvxAJuCoqJEx nIGZHyYUoN54VnJ/FLtLLClEUmAE2UjkFUkNsPAOO6arCe8uBhPzPIHH9q8W9jU= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1740476310; bh=ng7o1c8BcckGiZwxtkPfaKrDbbxTxj9uS+gE48lZqZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uDUd5xGo2rf79k0eD8Al7YpNvEwm0J07t6Ub2YN1uYcCpG5R/91uhX2qNbtgK7ahN s2f/edDdmRuh1QMgnqMAQJ9GUsyNIB8uLEqVjMHa0Hx11h13RVmB2ArmUiCn2QR1f6 vfQ298kHES2ptVXpR5XHdobzHEdyPgnlU1fMiW3WvRFhl7JuHu1dLwmdQ7++Gg1pBd LBpv/88OPStjgfGkgzgk53pZwL4K3b0d9w3GS0D1uhTJvEW/gvn8KdLbn9HnZj3lFX uNtSgw/QTqjb8WCfmtb4cy729Y1+sOK8hdY0nRh5baumDl3tDxoiUQz1qpcJNVYXg0 /5fooF9chDRgw== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH v2 1/3] xen/arm: platform: address violation of MISRA C Rule 7.2 Date: Tue, 25 Feb 2025 10:38:22 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Rule 7.2 states: "A u or U suffix shall be applied to all integer constants that are represented in an unsigned type". Some PM_* constants are unsigned quantities, despite some of them being representable in a signed type, so a 'U' suffix should be present. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- This fix is needed in order to keep the rule clean when the Xen configuration under static analysis is changed later in patch 3 of this series. Only PM_RSTC_WRCFG_CLR is strictly needed to conform to the rule, but the other constants have a 'U' added for consistency. PM_RSTC and PM_WDOG are used as offsets, so in principle they can be negative, therefore they are left as is. --- xen/arch/arm/platforms/brcm-raspberry-pi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c index 407ec07f63b8..d49460329cc8 100644 --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c @@ -47,11 +47,11 @@ static const struct dt_device_match rpi4_blacklist_dev[] __initconst = }; -#define PM_PASSWORD 0x5a000000 +#define PM_PASSWORD 0x5a000000U #define PM_RSTC 0x1c #define PM_WDOG 0x24 -#define PM_RSTC_WRCFG_FULL_RESET 0x00000020 -#define PM_RSTC_WRCFG_CLR 0xffffffcf +#define PM_RSTC_WRCFG_FULL_RESET 0x00000020U +#define PM_RSTC_WRCFG_CLR 0xffffffcfU static void __iomem *rpi4_map_watchdog(void) { From patchwork Tue Feb 25 09:38:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13989647 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83E9CC021B8 for ; Tue, 25 Feb 2025 09:38:56 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.895562.1304217 (Exim 4.92) (envelope-from ) id 1tmrOd-0007x1-75; Tue, 25 Feb 2025 09:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 895562.1304217; Tue, 25 Feb 2025 09:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOd-0007wa-2o; Tue, 25 Feb 2025 09:38:35 +0000 Received: by outflank-mailman (input) for mailman id 895562; Tue, 25 Feb 2025 09:38:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOc-0007uj-7R for xen-devel@lists.xenproject.org; Tue, 25 Feb 2025 09:38:34 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46795622-f35c-11ef-9897-31a8f345e629; Tue, 25 Feb 2025 10:38:31 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) (Authenticated sender: nicola) by support.bugseng.com (Postfix) with ESMTPSA id 0B7934EEF418; Tue, 25 Feb 2025 10:38:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46795622-f35c-11ef-9897-31a8f345e629 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1740476311; b=tbnGIMAl5vQUC8dk42k393Voa6dyvhHNa2ZE5Z5RvOkPlnqAW5EA3HJnPBGEqPueX2tt wkzadyIylqjEv+NdiF6XzZiwLfrG7UMIIC0RGHV3Rab9zjukYYDOisl+9auefHXHi1xGd ltYBq/kbZRoADJED4u0h3bq/nOOxv3jj2ayTswLxldThu9fgCWdIiAKqYLYjbnwSCUd+P MGHCLXpUoQXyBkzDA9mlM6LuB8/SXAZeUHAXa0J5WOH9YIIV7a+NNJefHu3okYoA6dHPZ HNz6QooScv0+WlGzEjmo5Q+lX8UhMIEpA3WZgLWVEfJkaI7DoUaesvN3wr5r/AvTTuDZ4 IphS9W9pFEtHzgI9cAseBEkXA8QaElnyH7Cm8GeNh/gqaYrx1L5ZevXA5FpRb3BKI1fn2 rx0YgqNq0fQownJmbeqFbdfwkVMAGj9PbvP0f08qsJaAopH0GrLkJ0h4zNoLeI1GCvkr+ S82OmlRbIU5GSPJgCqWwbJDsreogN1t0a0ftjW4P8JfbJ24xlJf6fIrkyj+LWFpRuLSYx FW3iNGhinWxi1fiIrzA0DkcrScMuN/oJDIE51kXhIyMmlHmwWe9WFP7y6x9zONgvKpFgu PC06nYzeIBoqlJ26D8Qmz+Fk2ABXHeT1JsuU5idRnQSV4h7EEWnzC35K7za8ZZw= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1740476311; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=mV2Snw/5hKKaTOvK0VHkFyXhGumz3S2bWIiAkQCSB3U=; b=jbpCIB2sP3pykhFtwSRfcJdo7tO7X0I8cb16Kr0nBfZ4BZLSkutqoG40N+qM1RBvfKzy 9pZTvQsqjS8MbDlJXP6v1/0ypspTXRs6MoVPGlQMJTgKLQR7rrOdqLT+J0Ju4pIOZVg5c GXV9T74Fotenr9Z6rPa/QGYs95rQ3Hsiw5qzLh/e0HmCItpJSFJ4Oa8jnrWylF1eCIs8d qpj0tLUwzLaugJuKJY66OVX8rWCAMHfU7bkPqQjB77EaCSINAXFVKJCkz9s3HXuakiSbm v6xU4NSFm0vyHJGdN0yIJYLK024j4f9wTvlCnOUZyhCpJrpO8Hd2PE4isvvfJ6J6URmY/ jpAUesbTalBUPwjU0ElpdkvecXrpAuIPpN86qQWhm/wk38HlVAkehENvHuphtUWZzrHAx 9ubmzPgrGGG0XJrTIm36asQlHWWDn3QkKsY0QxlPbja979fgKMJkzuC6+tnYk3RR2mfh2 afe9Ikwq8YOf6M1AGhPri2SEmtf1o2RZta3l7GDzennEy3Oo7099cPl1oSLTJiSiEB3x9 i2K/hVhMd15L4mGV045DVLFzlx+HsgJIEIK7ObUMdPgSBFkd0pfOvaVmhEvPDQ2VGMOzC sarS5/Jm8wD3ClbCMXGC+jdMnGB/Zjvmvok3qvOLw8ZY87WTpOH4DD6Ob6lHVPI= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1740476311; bh=4mhypLmI+bzEIqJvhupyhI6zRRj5uMfdpWb9moyuUek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L/sqaLDyqGy9c4R1UdyH+e2YO+Uyc4n0KPwqSNUKjXdOHmq/rMVHSy4W9F0rg8CXB JkDfVrTcuXoP0/d5PSYQ22iPKg4gwRZ3ZzAHRQi98ZW2ySPCUmaP8RaRXFUKpC15fS ozksbDfTgppe9SQ3xi/fTpEgwzPAlaDJUmWzsnX3QBf6qEOQO1P0sxkoPDN3gNejiK funURqDlUQXP2mOmTe+JAxM8upuDVplA6A3S450PFThUdYijrZ5WeT8Vy6IAEP4ZZs /PBeKl44Z7Sgb2kHxmA8dM6NSSRqjt5+iIF9o9qVueVbEZeYwfLyfc+QAsbUXvJbCJ bC0W1pWplC2kA== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Dario Faggioli , Meng Xu , Juergen Gross , George Dunlap Subject: [XEN PATCH v2 2/3] xen/rt: address violation of MISRA C Rule 8.2 Date: Tue, 25 Feb 2025 10:38:23 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Rule 8.2 states: "Function types shall be in prototype form with named parameters". The parameter name is missing from the function pointer type that constitutes the first parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Reviewed-by: Juergen Gross --- Changes in v2: - renamed function parameter name to "elem" - changed prefix to xen/rt since only that scheduler is touched --- xen/common/sched/rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index f368e0fdd5a5..7b1f64a779ea 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -500,7 +500,7 @@ deadline_queue_remove(struct list_head *queue, struct list_head *elem) } static inline bool -deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *), +deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *elem), struct rt_unit *svc, struct list_head *elem, struct list_head *queue) { From patchwork Tue Feb 25 09:38:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13989648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9679EC021BC for ; Tue, 25 Feb 2025 09:38:56 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.895563.1304233 (Exim 4.92) (envelope-from ) id 1tmrOe-0008Mt-CW; Tue, 25 Feb 2025 09:38:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 895563.1304233; Tue, 25 Feb 2025 09:38:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOe-0008Mi-9E; Tue, 25 Feb 2025 09:38:36 +0000 Received: by outflank-mailman (input) for mailman id 895563; Tue, 25 Feb 2025 09:38:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tmrOc-0007uj-SZ for xen-devel@lists.xenproject.org; Tue, 25 Feb 2025 09:38:34 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46d426fe-f35c-11ef-9897-31a8f345e629; Tue, 25 Feb 2025 10:38:32 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) (Authenticated sender: nicola) by support.bugseng.com (Postfix) with ESMTPSA id A7ABB4EEF419; Tue, 25 Feb 2025 10:38:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46d426fe-f35c-11ef-9897-31a8f345e629 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1740476312; b=dxOi2iAiTGUqiMx2GTVArA16f4gbHXD2osLGIj4nu2LMhyyLDMS1q6WlmXpE60rEamco Ge2IzFdE1tRRsDDpvbuxyb5P5B6HNOCJ+uIAsvvn7a+ya4nOO8bwM6Oq7izIcN2jzkKLN DzNvtRKmIt0JLMT4524kokJKUBHtJ9U85X94rp7wZIJwMQ0OcKyze6q6WEjvnkMR17KL0 jT0qSGLvy2v+hoVwrwQnioMCaGdDbKudJMb0D9ZmHQ7DP6qpTCVWt4Jd0Rk2oLGcQ4m7X zGBCcyzuTzZp/LX4qV8LNJJ1PkaaiiBXvtozPHgqwocv0UTU+VppGXfc2urfTgHJxP5hg JtxdqbbV9mjhB1jKUlVvHgVXDwoqS7lbJ5MpnoaAFauVC06k8MQpI3f9TlRr5BFRTSUwq kmDsITqFK2VXa5DAdyMLWK46As/UjNxBdtV0hDk46n0kwaAC8VojVZTAuYdICNSRWoZC7 F+ezf4hlzPEuG8PzvpFOMsBkX64KnE1uxmNKfl7zvdhVnSbqouCcN3uSY/OgtxWWQwq/4 D41lKrdMMWrYVlBbm7kRm0AsfLa/2HYIvU434bhwZixap1T8F+Pcm+vzJm3fpf/FSwQ2L 0NVIW8MBBDM4OH+oK0Vmcb+Kd45vSvmxVUP/L5+643rb4pD51MU/gZUpusHXHnc= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1740476312; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=UVBX/hsJ3098u1YJ7DWvTChlHimdHgM6KhjX9q6PP+o=; b=3ioOijeu0hvdxVs2frOwhKc0IM2GFecTIqWj1N1GkUhAEc4AtrmD6erW9nmGVTi4CccR tKgTa0cE8iDcqnxv2t19Mr9RlM9kB5/5IhuH1Wq9/IGhddYoz3nG51E8uue4B0HG1Wf98 RZnGzO/hhPh0OfyOM8SDzeoxqRaZ8PTIpZf3ZwJRzInRgbukJJHkJjdryFxhEGPIu+PVL oFgG7NP5pJTI9q5hvNTAxbjzLG2x3xdDTY+5BwUuz6o0VqiPImr4RMtU/WmIq8uLp0DPa kSBMO13YPko8lp258C4VeTig1f3C3of/eSnO+Wa+R0Z1E9hHj44WiCvJSfuofxtPxUWA6 Tb3Og/8++1qZCiZtQE6e20ZG1jjxpNDbn+kytmoEUpXNjHUckRjqgeeHqJK3UDAWG5KSg 4Yt9XwB0lt2KtEBA8zhJDkHiCNvIFlp05+edftnek7mIjiwvKnAqbMWEtimxugaS+82g1 K0wo/H5PYdMORGG2XDbtWEr0nEYByZSzyv1s2cI4JJxeMP/n5plF/ZIG1BHt6wQI5bd9W KW12KNA8HlQaIIHRDNcZkYusfDsn1E0QWPRMNUGkIVH9+bPL/7C8UoGELZcItY6LBlCID vSUeIuMpSZXVW3CwhV7AW+KslwquguNNcWnKJMxZ6EorAa5UaGed0ZUA1n6DNTk= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1740476312; bh=dxCVLK5mc1cedb+GrWJHR49a9qftfFcxzud59P193Uc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ndSR5e2qabhRPffSO3tvOC2MbAbmfrwEJuAP362JIBVQ1ti0++pDq331u7bzXnpEd kiZJhRfiC5hVbNubg8ocgN+DLX7vtB8b3HL3YvmewAG6qqYXfFfya3+8wgefyaC40I omyyHG5aghZVo7ry40IFgq8FkvpW7pa3sm5w9NymHYeeMoBK/zeTYO8Fj33Ub+i/fJ 3h/+iDlmpP0VJaL1E0vJw71HgLjYW4m/uaTLMeniIAce9fcavH9DYgjpP9s9SFbkBl veAd9sJsPkz6im3lRmaf62tqhcmD+p7dpZwh/fIqkVdb3D4WCXFfl3TvVpY2gTTiwT QIVYp1nYtkHRw== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Doug Goldstein Subject: [XEN PATCH v2 3/3] automation: Update ECLAIR analysis configuration Date: Tue, 25 Feb 2025 10:38:24 +0100 Message-ID: <3926bf39f742a166d2190e2a10f1806a36cca2e9.1740476096.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 The Xen configurations for the ARM64 and X86_64 ECLAIR analyses is currently held in fixed files under 'automation/eclair_analysis/xen_{arm,x86}_config'. The values of the configuration options there are susceptible to going stale due to configuration option changes. To enhance maintainability, the configuration under analysis is derived from the respective architecture's defconfig, with suitable changes added via EXTRA_XEN_CONFIG. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- This patch should be applied on top of the other two in the series to ensure that the CI has no failures related to clean guidelines. Note that any out of date values taken by configuration options currently in xen_*_config were determined to be benign with respect to the analysis results, but this wasn't the right approach in the long term. --- automation/eclair_analysis/prepare.sh | 8 +- automation/eclair_analysis/xen_arm_config | 141 --------------------- automation/eclair_analysis/xen_x86_config | 143 ---------------------- automation/gitlab-ci/analyze.yaml | 68 ++++++++++ 4 files changed, 73 insertions(+), 287 deletions(-) delete mode 100644 automation/eclair_analysis/xen_arm_config delete mode 100644 automation/eclair_analysis/xen_x86_config diff --git a/automation/eclair_analysis/prepare.sh b/automation/eclair_analysis/prepare.sh index 3a646414a392..4285ff26de54 100755 --- a/automation/eclair_analysis/prepare.sh +++ b/automation/eclair_analysis/prepare.sh @@ -25,18 +25,20 @@ fi export XEN_TARGET_ARCH if [ "$1" = "X86_64" ]; then - CONFIG_FILE="${script_dir}/xen_x86_config" XEN_TARGET_ARCH=x86_64 elif [ "$1" = "ARM64" ]; then - CONFIG_FILE="${script_dir}/xen_arm_config" XEN_TARGET_ARCH=arm64 else fatal "Unknown configuration: $1" fi ( + make -C xen defconfig + if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then + echo "${EXTRA_XEN_CONFIG}" >> xen/.config + fi + ./configure - cp "${CONFIG_FILE}" xen/.config make clean find . -type f -name "*.safparse" -print -delete "${script_dir}/build.sh" "$1" diff --git a/automation/eclair_analysis/xen_arm_config b/automation/eclair_analysis/xen_arm_config deleted file mode 100644 index ef140ceb7383..000000000000 --- a/automation/eclair_analysis/xen_arm_config +++ /dev/null @@ -1,141 +0,0 @@ -CONFIG_CC_IS_GCC=y -CONFIG_GCC_VERSION=90400 -CONFIG_CLANG_VERSION=0 -CONFIG_LD_IS_GNU=y -CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE=y -CONFIG_ARM_64=y -CONFIG_ARM=y -CONFIG_ARCH_DEFCONFIG="arch/arm/configs/arm64_defconfig" - -# UBSAN -CONFIG_UBSAN=n - -# -# Architecture Features -# -CONFIG_ARM64_SVE=n -CONFIG_64BIT=y -CONFIG_NR_CPUS=4 -# CONFIG_ACPI is not set -CONFIG_ARM_EFI=y -CONFIG_GICV3=y -CONFIG_HAS_ITS=y -CONFIG_HVM=y -# CONFIG_NEW_VGIC is not set -CONFIG_SBSA_VUART_CONSOLE=y -CONFIG_ARM_SSBD=y -CONFIG_HARDEN_BRANCH_PREDICTOR=y -CONFIG_TEE=n -CONFIG_OPTEE=n -CONFIG_FFA=n -# CONFIG_STATIC_SHM is not set -# end of Architecture Features - -# -# ARM errata workaround via the alternative framework -# -CONFIG_ARM64_ERRATUM_827319=y -CONFIG_ARM64_ERRATUM_824069=y -CONFIG_ARM64_ERRATUM_819472=y -CONFIG_ARM64_ERRATUM_843419=y -CONFIG_ARM64_ERRATUM_832075=y -CONFIG_ARM64_ERRATUM_834220=y -CONFIG_ARM64_ERRATUM_1508412=y -CONFIG_ARM_ERRATUM_858921=y -CONFIG_ARM64_WORKAROUND_REPEAT_TLBI=y -CONFIG_ARM64_ERRATUM_1286807=y -# end of ARM errata workaround via the alternative framework - -CONFIG_ARM64_HARDEN_BRANCH_PREDICTOR=y -# CONFIG_ALL_PLAT is not set -# CONFIG_QEMU is not set -# CONFIG_RCAR3 is not set -CONFIG_MPSOC=y -# CONFIG_NO_PLAT is not set -CONFIG_MPSOC_PLATFORM=y - -# -# Common Features -# -CONFIG_GRANT_TABLE=y -CONFIG_HAS_ALTERNATIVE=y -CONFIG_HAS_DEVICE_TREE=y -CONFIG_HAS_FAST_MULTIPLY=y -CONFIG_HAS_PDX=y -CONFIG_HAS_PMAP=y -# CONFIG_MEM_ACCESS is not set -CONFIG_STATIC_MEMORY=y - -# -# Speculative hardening -# -CONFIG_SPECULATIVE_HARDEN_ARRAY=y -# end of Speculative hardening - -# CONFIG_HYPFS is not set -CONFIG_IOREQ_SERVER=y -# CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP is not set -# CONFIG_XSM is not set -# CONFIG_ARGO is not set - -# -# Schedulers -# -# CONFIG_SCHED_CREDIT is not set -CONFIG_SCHED_CREDIT2=y -# CONFIG_SCHED_RTDS is not set -# CONFIG_SCHED_ARINC653 is not set -CONFIG_SCHED_NULL=y -CONFIG_SCHED_CREDIT2_DEFAULT=y -# CONFIG_SCHED_NULL_DEFAULT is not set -CONFIG_SCHED_DEFAULT="credit2" -# end of Schedulers - -CONFIG_BOOT_TIME_CPUPOOLS=y -# CONFIG_LIVEPATCH is not set -# CONFIG_ENFORCE_UNIQUE_SYMBOLS is not set -CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=y -CONFIG_CMDLINE="" -CONFIG_DOM0_MEM="" -CONFIG_DTB_FILE="" -# CONFIG_TRACEBUFFER is not set -# end of Common Features - -# -# Device Drivers -# -# CONFIG_HAS_NS16550 is not set -CONFIG_HAS_CADENCE_UART=y -# CONFIG_HAS_IMX_LPUART is not set -# CONFIG_HAS_MVEBU is not set -# CONFIG_HAS_MESON is not set -CONFIG_HAS_PL011=y -# CONFIG_HAS_SCIF is not set -CONFIG_SERIAL_TX_BUFSIZE=16384 -CONFIG_HAS_PASSTHROUGH=y -CONFIG_ARM_SMMU=y -CONFIG_ARM_SMMU_V3=y -# CONFIG_IPMMU_VMSA is not set -CONFIG_IOMMU_FORCE_PT_SHARE=y -# end of Device Drivers - -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y - -# -# Debugging Options -# -CONFIG_DEBUG=y -CONFIG_FRAME_POINTER=y -CONFIG_COVERAGE=y -CONFIG_DEBUG_LOCK_PROFILE=y -CONFIG_DEBUG_LOCKS=y -CONFIG_PERF_COUNTERS=y -CONFIG_PERF_ARRAYS=y -CONFIG_VERBOSE_DEBUG=y -CONFIG_DEVICE_TREE_DEBUG=y -CONFIG_SCRUB_DEBUG=y -CONFIG_DEBUG_TRACE=y -CONFIG_XMEM_POOL_POISON=y -CONFIG_DEBUG_INFO=y -# end of Debugging Options diff --git a/automation/eclair_analysis/xen_x86_config b/automation/eclair_analysis/xen_x86_config deleted file mode 100644 index abc44d43e108..000000000000 --- a/automation/eclair_analysis/xen_x86_config +++ /dev/null @@ -1,143 +0,0 @@ -CONFIG_CC_IS_GCC=y -CONFIG_GCC_VERSION=90400 -CONFIG_CLANG_VERSION=0 -CONFIG_LD_IS_GNU=y -CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE=y -CONFIG_X86_64=y -CONFIG_X86=y -CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig" -CONFIG_CC_HAS_INDIRECT_THUNK=y -CONFIG_HAS_AS_CET_SS=y -CONFIG_HAS_CC_CET_IBT=y - -CONFIG_REQUIRE_NX=n - -# -# Architecture Features -# -CONFIG_64BIT=y -CONFIG_NR_CPUS=16 -CONFIG_NR_NUMA_NODES=2 -# CONFIG_PV is not set -CONFIG_HVM=y -# CONFIG_XEN_SHSTK is not set -# CONFIG_XEN_IBT is not set -# CONFIG_SHADOW_PAGING is not set -# CONFIG_BIGMEM is not set -# CONFIG_HVM_FEP is not set -# CONFIG_TBOOT is not set -CONFIG_XEN_ALIGN_DEFAULT=y -# CONFIG_XEN_ALIGN_2M is not set -CONFIG_X2APIC_PHYSICAL=y -# CONFIG_XEN_GUEST is not set -# CONFIG_HYPERV_GUEST is not set -# CONFIG_MEM_PAGING is not set -# CONFIG_MEM_SHARING is not set -# end of Architecture Features - -# -# Common Features -# -CONFIG_COMPAT=y -CONFIG_CORE_PARKING=y -CONFIG_GRANT_TABLE=y -CONFIG_ALTERNATIVE_CALL=y -CONFIG_ARCH_MAP_DOMAIN_PAGE=y -CONFIG_GENERIC_BUG_FRAME=y -CONFIG_HAS_ALTERNATIVE=y -CONFIG_HAS_COMPAT=y -CONFIG_HAS_EX_TABLE=y -CONFIG_HAS_FAST_MULTIPLY=y -CONFIG_HAS_IOPORTS=y -CONFIG_HAS_KEXEC=y -CONFIG_HAS_PDX=y -CONFIG_HAS_SCHED_GRANULARITY=y -CONFIG_HAS_UBSAN=y -CONFIG_MEM_ACCESS_ALWAYS_ON=y -CONFIG_MEM_ACCESS=y -CONFIG_NEEDS_LIBELF=y -CONFIG_NUMA=y - -# -# Speculative hardening -# -CONFIG_INDIRECT_THUNK=y -CONFIG_SPECULATIVE_HARDEN_ARRAY=y -CONFIG_SPECULATIVE_HARDEN_BRANCH=y -# end of Speculative hardening - -# CONFIG_HYPFS is not set -CONFIG_IOREQ_SERVER=y -# CONFIG_KEXEC is not set -# CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP is not set -# CONFIG_XENOPROF is not set -# CONFIG_XSM is not set -# CONFIG_ARGO is not set - -# -# Schedulers -# -# CONFIG_SCHED_CREDIT is not set -CONFIG_SCHED_CREDIT2=y -# CONFIG_SCHED_RTDS is not set -# CONFIG_SCHED_ARINC653 is not set -CONFIG_SCHED_NULL=y -CONFIG_SCHED_CREDIT2_DEFAULT=y -# CONFIG_SCHED_NULL_DEFAULT is not set -CONFIG_SCHED_DEFAULT="credit2" -# end of Schedulers - -# CONFIG_LIVEPATCH is not set -# CONFIG_ENFORCE_UNIQUE_SYMBOLS is not set -# CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS is not set -CONFIG_CMDLINE="" -CONFIG_DOM0_MEM="" -# CONFIG_TRACEBUFFER is not set -# end of Common Features - -# -# Device Drivers -# -CONFIG_ACPI=y -CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y -CONFIG_ACPI_NUMA=y -CONFIG_HAS_NS16550=y -CONFIG_HAS_EHCI=y -CONFIG_SERIAL_TX_BUFSIZE=16384 -# CONFIG_XHCI is not set -CONFIG_HAS_CPUFREQ=y -CONFIG_HAS_PASSTHROUGH=y -CONFIG_AMD_IOMMU=y -# CONFIG_INTEL_IOMMU is not set -# CONFIG_IOMMU_QUARANTINE_NONE is not set -CONFIG_IOMMU_QUARANTINE_BASIC=y -# CONFIG_IOMMU_QUARANTINE_SCRATCH_PAGE is not set -CONFIG_HAS_PCI=y -CONFIG_HAS_PCI_MSI=y -CONFIG_VIDEO=y -CONFIG_VGA=y -CONFIG_HAS_VPCI=y -# end of Device Drivers - -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y -CONFIG_ARCH_SUPPORTS_INT128=y - -# -# Debugging Options -# -CONFIG_DEBUG=y -# CONFIG_CRASH_DEBUG is not set -CONFIG_GDBSX=y -CONFIG_FRAME_POINTER=y -# CONFIG_COVERAGE is not set -# CONFIG_DEBUG_LOCK_PROFILE is not set -CONFIG_DEBUG_LOCKS=y -# CONFIG_PERF_COUNTERS is not set -CONFIG_VERBOSE_DEBUG=y -CONFIG_SCRUB_DEBUG=y -# CONFIG_UBSAN is not set -# CONFIG_DEBUG_TRACE is not set -CONFIG_XMEM_POOL_POISON=y -CONFIG_DEBUG_INFO=y -# end of Debugging Options diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml index 02e0ea692c66..35ff3620cf8e 100644 --- a/automation/gitlab-ci/analyze.yaml +++ b/automation/gitlab-ci/analyze.yaml @@ -40,6 +40,36 @@ eclair-x86_64: LOGFILE: "eclair-x86_64.log" VARIANT: "X86_64" RULESET: "monitored" + EXTRA_XEN_CONFIG: | + CONFIG_AMD=y + CONFIG_INTEL=n + CONFIG_AMD_SVM=y + CONFIG_INTEL_VMX=n + CONFIG_NR_CPUS=16 + CONFIG_NR_NUMA_NODES=2 + CONFIG_PV=n + CONFIG_XEN_IBT=n + CONFIG_XEN_SHSTK=n + CONFIG_SHADOW_PAGING=n + CONFIG_HVM_FEP=n + CONFIG_TBOOT=n + CONFIG_HYPFS=n + CONFIG_KEXEC=n + CONFIG_ARGO=y + CONFIG_SCHED_CREDIT=n + CONFIG_SCHED_RTDS=n + CONFIG_SCHED_ARINC653=n + CONFIG_LIVEPATCH=n + CONFIG_TRACEBUFFER=n + CONFIG_INTEL_IOMMU=n + CONFIG_EXPERT=y + CONFIG_DEBUG=y + CONFIG_GDBSX=n + CONFIG_FRAME_POINTER=n + CONFIG_SELF_TESTS=n + CONFIG_DEBUG_LOCKS=n + CONFIG_SCRUB_DEBUG=n + CONFIG_XMEM_POOL_POISON=n eclair-ARM64: extends: .eclair-analysis:triggered @@ -47,6 +77,44 @@ eclair-ARM64: LOGFILE: "eclair-ARM64.log" VARIANT: "ARM64" RULESET: "monitored" + EXTRA_XEN_CONFIG: | + CONFIG_NR_CPUS=16 + CONFIG_GICV2=n + CONFIG_GICV3=y + CONFIG_VGICV2=n + CONFIG_HAS_ITS=y + CONFIG_HWDOM_VUART=n + CONFIG_STATIC_SHM=y + CONFIG_STATIC_EVTCHN=y + CONFIG_STATIC_MEMORY=y + CONFIG_SCMI_SMC=n + CONFIG_PARTIAL_EMULATION=n + CONFIG_HYPFS=n + CONFIG_IOREQ_SERVER=y + CONFIG_XSM=n + CONFIG_ARGO=y + CONFIG_SCHED_CREDIT=n + CONFIG_SCHED_RTDS=n + CONFIG_SCHED_ARINC653=n + CONFIG_BOOT_TIME_CPUPOOLS=y + CONFIG_TRACEBUFFER=n + CONFIG_HAS_CADENCE_UART=n + CONFIG_HAS_NS16550=n + CONFIG_HAS_IMX_LPUART=n + CONFIG_HAS_MVEBU=n + CONFIG_HAS_MESON=n + CONFIG_HAS_OMAP=n + CONFIG_HAS_SCIF=n + CONFIG_HAS_LINFLEX=n + CONFIG_ARM_SMMU=n + CONFIG_ARM_SMMU_V3=y + CONFIG_EXPERT=y + CONFIG_DEBUG=y + CONFIG_FRAME_POINTER=n + CONFIG_SELF_TESTS=n + CONFIG_DEBUG_LOCKS=n + CONFIG_SCRUB_DEBUG=n + CONFIG_XMEM_POOL_POISON=n .eclair-analysis:on-schedule: extends: .eclair-analysis